@openparachute/agent 0.1.2 → 0.2.0

package/src/backends/stream-json.test.ts

@@ -0,0 +1,570 @@
+/**
+ * parseStreamJson tests — the `claude -p --output-format stream-json --verbose`
+ * NDJSON parser. Built to the VERIFIED event shapes (claude 2.1.179).
+ *
+ * Covered:
+ *  - a success turn: session_id from init, reply from result, success/subtype, usage, cost;
+ *  - apiKeySource "none" surfaced (the subscription-auth signal);
+ *  - an error turn (is_error / non-success subtype) → success=false, error message;
+ *  - session_id captured from the FIRST event (init precedes result);
+ *  - robustness: interleaved hook / rate_limit_event lines + a trailing PARTIAL line;
+ *  - no result event at all → success undefined (a truncated/crashed turn);
+ *  - blank/garbage input → an empty parse, never a throw.
+ */
+import { describe, test, expect } from "bun:test";
+import {
+  parseStreamJson,
+  parseStreamJsonStream,
+  MAX_TOOL_INPUT_CHARS,
+  MAX_TOOL_RESULT_CHARS,
+  type InterimTurnEvent,
+} from "./stream-json.ts";
+
+/** Join NDJSON event objects into the line-delimited blob claude emits. */
+function ndjson(...events: unknown[]): string {
+  return events.map((e) => JSON.stringify(e)).join("\n") + "\n";
+}
+
+/** A ReadableStream<Uint8Array> that emits the given byte chunks in order (then closes). */
+function streamOf(...chunks: string[]): ReadableStream<Uint8Array> {
+  const enc = new TextEncoder();
+  return new ReadableStream<Uint8Array>({
+    start(controller) {
+      for (const c of chunks) controller.enqueue(enc.encode(c));
+      controller.close();
+    },
+  });
+}
+
+/** Collect the interim events parseStreamJsonStream emits while parsing `chunks`. */
+async function collectInterim(
+  ...chunks: string[]
+): Promise<{ events: InterimTurnEvent[]; turn: Awaited<ReturnType<typeof parseStreamJsonStream>> }> {
+  const events: InterimTurnEvent[] = [];
+  const turn = await parseStreamJsonStream(streamOf(...chunks), (e) => events.push(e));
+  return { events, turn };
+}
+
+describe("parseStreamJson — success turn", () => {
+  test("captures session_id (from init), reply (from result), subtype, usage, cost", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "sess-123", apiKeySource: "none", mcp_servers: [] },
+      { type: "assistant", message: { content: [{ type: "text", text: "hi there" }] }, session_id: "sess-123" },
+      {
+        type: "result",
+        subtype: "success",
+        is_error: false,
+        result: "Here is the final reply.",
+        session_id: "sess-123",
+        usage: { input_tokens: 42, output_tokens: 7 },
+        total_cost_usd: 0.0012,
+      },
+    );
+    const t = parseStreamJson(blob);
+    expect(t.sessionId).toBe("sess-123");
+    expect(t.reply).toBe("Here is the final reply.");
+    expect(t.success).toBe(true);
+    expect(t.subtype).toBe("success");
+    expect(t.isError).toBe(false);
+    expect(t.usage).toEqual({ input_tokens: 42, output_tokens: 7 });
+    expect(t.totalCostUsd).toBe(0.0012);
+  });
+
+  test("surfaces apiKeySource 'none' — the subscription-auth signal (design §1)", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "s", apiKeySource: "none" },
+      { type: "result", subtype: "success", is_error: false, result: "ok", session_id: "s" },
+    );
+    expect(parseStreamJson(blob).apiKeySource).toBe("none");
+  });
+});
+
+describe("parseStreamJson — error turn", () => {
+  test("is_error true → success=false, error message captured from result", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "sess-err", apiKeySource: "none" },
+      {
+        type: "result",
+        subtype: "error_during_execution",
+        is_error: true,
+        result: "something went wrong",
+        session_id: "sess-err",
+      },
+    );
+    const t = parseStreamJson(blob);
+    expect(t.success).toBe(false);
+    expect(t.isError).toBe(true);
+    expect(t.subtype).toBe("error_during_execution");
+    expect(t.errorMessage).toBe("something went wrong");
+    // The session id is still captured (a turn can fail AFTER establishing a session).
+    expect(t.sessionId).toBe("sess-err");
+  });
+
+  test("a non-success subtype with is_error false is STILL not success", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "s" },
+      { type: "result", subtype: "error_max_turns", is_error: false, result: "partial", session_id: "s" },
+    );
+    const t = parseStreamJson(blob);
+    expect(t.success).toBe(false);
+    expect(t.subtype).toBe("error_max_turns");
+  });
+});
+
+describe("parseStreamJson — session_id capture", () => {
+  test("captured from the FIRST event that carries one (init precedes result)", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "first-id" },
+      { type: "result", subtype: "success", is_error: false, result: "ok", session_id: "first-id" },
+    );
+    expect(parseStreamJson(blob).sessionId).toBe("first-id");
+  });
+
+  test("falls through to the result event's session_id when there's no init", () => {
+    const blob = ndjson({ type: "result", subtype: "success", is_error: false, result: "ok", session_id: "from-result" });
+    expect(parseStreamJson(blob).sessionId).toBe("from-result");
+  });
+});
+
+describe("parseStreamJson — robustness", () => {
+  test("interleaved hook / rate_limit_event lines + a trailing PARTIAL line still parse the result", () => {
+    const blob =
+      // a non-JSON hook line (plain text from a user hook)
+      "running PreToolUse hook...\n" +
+      ndjson({ type: "system", subtype: "init", session_id: "sess-robust", apiKeySource: "none" }).trimEnd() +
+      "\n" +
+      // a rate_limit_event interleaved (the subscription five_hour pool signal)
+      ndjson({ type: "system", subtype: "rate_limit_event", rate_limit: { five_hour: { overageStatus: "rejected" } } }).trimEnd() +
+      "\n" +
+      ndjson({ type: "assistant", message: { content: [{ type: "text", text: "thinking" }] }, session_id: "sess-robust" }).trimEnd() +
+      "\n" +
+      JSON.stringify({
+        type: "result",
+        subtype: "success",
+        is_error: false,
+        result: "robust reply",
+        session_id: "sess-robust",
+        usage: { input_tokens: 1, output_tokens: 2 },
+      }) +
+      "\n" +
+      // a TRAILING PARTIAL line — a JSON object cut off mid-stream (no closing brace)
+      '{"type":"system","subtype":"in';
+    const t = parseStreamJson(blob);
+    expect(t.sessionId).toBe("sess-robust");
+    expect(t.reply).toBe("robust reply");
+    expect(t.success).toBe(true);
+    expect(t.apiKeySource).toBe("none");
+  });
+
+  test("blank lines + a leading non-{ line are skipped", () => {
+    const blob =
+      "\n\nsome banner text\n" +
+      JSON.stringify({ type: "result", subtype: "success", is_error: false, result: "ok", session_id: "s" }) +
+      "\n\n";
+    const t = parseStreamJson(blob);
+    expect(t.reply).toBe("ok");
+    expect(t.success).toBe(true);
+  });
+
+  test("no result event at all → success is undefined (a truncated/crashed turn)", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "sess-trunc", apiKeySource: "none" },
+      { type: "assistant", message: { content: [{ type: "text", text: "started…" }] }, session_id: "sess-trunc" },
+    );
+    const t = parseStreamJson(blob);
+    expect(t.success).toBeUndefined();
+    expect(t.reply).toBeUndefined();
+    expect(t.sessionId).toBe("sess-trunc"); // id still available for a resume
+  });
+
+  test("fully blank / garbage input → an empty parse, never a throw", () => {
+    expect(parseStreamJson("")).toEqual({});
+    expect(parseStreamJson("   \n  \n")).toEqual({});
+    expect(parseStreamJson("not json at all\nmore noise")).toEqual({});
+  });
+});
+
+describe("parseStreamJsonStream — interim events + final turn", () => {
+  test("emits init (session) + text chunks + tool_use, and returns the same final turn", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "sess-1", apiKeySource: "none", mcp_servers: [] },
+      { type: "assistant", message: { content: [{ type: "text", text: "let me check" }] }, session_id: "sess-1" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", name: "Read", input: {} }] },
+        session_id: "sess-1",
+      },
+      { type: "assistant", message: { content: [{ type: "text", text: " — done." }] }, session_id: "sess-1" },
+      {
+        type: "result",
+        subtype: "success",
+        is_error: false,
+        result: "let me check — done.",
+        session_id: "sess-1",
+        usage: { input_tokens: 9, output_tokens: 4 },
+        total_cost_usd: 0.0009,
+      },
+    );
+    const { events, turn } = await collectInterim(blob);
+
+    expect(events).toEqual([
+      { kind: "init", sessionId: "sess-1" },
+      { kind: "text", text: "let me check" },
+      // empty input `{}` still stringifies to "{}" and rides as the input field
+      { kind: "tool", tool: "Read", input: "{}" },
+      { kind: "text", text: " — done." },
+    ]);
+    // The FINAL turn is exactly what the blob parser would compute — durable path intact.
+    expect(turn).toEqual(parseStreamJson(blob));
+    expect(turn.reply).toBe("let me check — done.");
+    expect(turn.success).toBe(true);
+    expect(turn.sessionId).toBe("sess-1");
+  });
+
+  test("a SINGLE assistant event with multiple blocks emits each in order", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "s" },
+      {
+        type: "assistant",
+        message: {
+          content: [
+            { type: "text", text: "first" },
+            { type: "tool_use", name: "Bash" },
+            { type: "text", text: "second" },
+          ],
+        },
+        session_id: "s",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "ok", session_id: "s" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toEqual([
+      { kind: "init", sessionId: "s" },
+      { kind: "text", text: "first" },
+      { kind: "tool", tool: "Bash" },
+      { kind: "text", text: "second" },
+    ]);
+  });
+
+  test("chunk boundaries SPLIT mid-line still parse + emit correctly", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "split-1" },
+      { type: "assistant", message: { content: [{ type: "text", text: "streamed" }] }, session_id: "split-1" },
+      { type: "result", subtype: "success", is_error: false, result: "streamed", session_id: "split-1" },
+    );
+    // Split the blob at an arbitrary mid-line byte offset into two chunks.
+    const cut = Math.floor(blob.length / 2);
+    const { events, turn } = await collectInterim(blob.slice(0, cut), blob.slice(cut));
+    expect(events).toEqual([
+      { kind: "init", sessionId: "split-1" },
+      { kind: "text", text: "streamed" },
+    ]);
+    expect(turn).toEqual(parseStreamJson(blob));
+  });
+
+  test("a final result line with NO trailing newline is still folded (pipe close)", async () => {
+    // The result line is emitted WITHOUT a terminating \n (the pipe closed) — it must
+    // still be parsed (folded once at end-of-stream).
+    const init = JSON.stringify({ type: "system", subtype: "init", session_id: "no-nl" }) + "\n";
+    const result = JSON.stringify({
+      type: "result",
+      subtype: "success",
+      is_error: false,
+      result: "tail reply",
+      session_id: "no-nl",
+    });
+    const { turn } = await collectInterim(init, result);
+    expect(turn.reply).toBe("tail reply");
+    expect(turn.success).toBe(true);
+  });
+
+  test("interim sink is NEVER called for the result event (final-only), and tolerates noise", async () => {
+    const blob =
+      "PreToolUse hook running...\n" +
+      ndjson({ type: "system", subtype: "init", session_id: "noise" }).trimEnd() +
+      "\n" +
+      ndjson({ type: "assistant", message: { content: [{ type: "text", text: "hi" }] }, session_id: "noise" }).trimEnd() +
+      "\n" +
+      JSON.stringify({ type: "result", subtype: "success", is_error: false, result: "hi", session_id: "noise" }) +
+      "\n";
+    const { events, turn } = await collectInterim(blob);
+    // init + the one text chunk only — the result event produces no interim event.
+    expect(events).toEqual([
+      { kind: "init", sessionId: "noise" },
+      { kind: "text", text: "hi" },
+    ]);
+    expect(turn.reply).toBe("hi");
+  });
+
+  test("a null stream yields an empty turn with no events (no stdout)", async () => {
+    const events: InterimTurnEvent[] = [];
+    const turn = await parseStreamJsonStream(null, (e) => events.push(e));
+    expect(turn).toEqual({});
+    expect(events).toHaveLength(0);
+  });
+
+  test("an error turn streams nothing-but-init then the final turn carries the failure", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "err-1" },
+      { type: "result", subtype: "error_during_execution", is_error: true, result: "kaboom", session_id: "err-1" },
+    );
+    const { events, turn } = await collectInterim(blob);
+    expect(events).toEqual([{ kind: "init", sessionId: "err-1" }]);
+    expect(turn.success).toBe(false);
+    expect(turn.errorMessage).toBe("kaboom");
+    expect(turn.sessionId).toBe("err-1");
+  });
+});
+
+describe("parseStreamJsonStream — enriched tool events (inputs + result previews)", () => {
+  test("a tool_use carries its input JSON-stringified on the tool event", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tin-1" },
+      {
+        type: "assistant",
+        message: {
+          content: [{ type: "tool_use", id: "tu_1", name: "Read", input: { file_path: "/etc/hosts" } }],
+        },
+        session_id: "tin-1",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tin-1" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toEqual([
+      { kind: "init", sessionId: "tin-1" },
+      { kind: "tool", tool: "Read", input: JSON.stringify({ file_path: "/etc/hosts" }) },
+    ]);
+  });
+
+  test("an OVERSIZE tool input is truncated with the … marker", async () => {
+    const bigCmd = "x".repeat(MAX_TOOL_INPUT_CHARS + 500);
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tin-big" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_b", name: "Bash", input: { command: bigCmd } }] },
+        session_id: "tin-big",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tin-big" },
+    );
+    const { events } = await collectInterim(blob);
+    const toolEvent = events.find((e) => e.kind === "tool");
+    expect(toolEvent).toBeDefined();
+    const input = (toolEvent as { input?: string }).input!;
+    // exactly MAX chars + the 1-char marker, and it ends with the marker
+    expect(input.length).toBe(MAX_TOOL_INPUT_CHARS + 1);
+    expect(input.endsWith("…")).toBe(true);
+  });
+
+  test("an input at EXACTLY the cap is NOT truncated (no marker)", async () => {
+    // A JSON string whose serialized form is exactly MAX_TOOL_INPUT_CHARS chars: the
+    // `> max` (strictly-greater) guard must leave it untouched, no `…`.
+    const padTo = MAX_TOOL_INPUT_CHARS - JSON.stringify({ command: "" }).length;
+    const exactCmd = "z".repeat(padTo);
+    const inputObj = { command: exactCmd };
+    const expected = JSON.stringify(inputObj);
+    expect(expected.length).toBe(MAX_TOOL_INPUT_CHARS); // sanity: we built it right
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tin-exact" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_x", name: "Bash", input: inputObj }] },
+        session_id: "tin-exact",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tin-exact" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toContainEqual({ kind: "tool", tool: "Bash", input: expected });
+    expect((events.find((e) => e.kind === "tool") as { input?: string }).input!.endsWith("…")).toBe(false);
+  });
+
+  test("the id→name map accumulates MULTIPLE tool_use ids before their results arrive", async () => {
+    // Two tool_use blocks fire, THEN two tool_results — each result must be labeled
+    // with the right tool via the per-parse id→name map (no cross-talk, map survives).
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "multi" },
+      {
+        type: "assistant",
+        message: {
+          content: [
+            { type: "tool_use", id: "tu_a", name: "Read", input: { file_path: "/a" } },
+            { type: "tool_use", id: "tu_b", name: "Bash", input: { command: "ls" } },
+          ],
+        },
+        session_id: "multi",
+      },
+      {
+        type: "user",
+        message: {
+          content: [
+            { type: "tool_result", tool_use_id: "tu_b", is_error: false, content: "bash out" },
+            { type: "tool_result", tool_use_id: "tu_a", is_error: false, content: "read out" },
+          ],
+        },
+        session_id: "multi",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "multi" },
+    );
+    const { events } = await collectInterim(blob);
+    // tu_b → Bash, tu_a → Read (results arrived in reverse order; labels still correct)
+    expect(events).toContainEqual({ kind: "tool_result", tool: "Bash", ok: true, preview: "bash out" });
+    expect(events).toContainEqual({ kind: "tool_result", tool: "Read", ok: true, preview: "read out" });
+  });
+
+  test("a tool_use with NO input omits the input field (back-compat shape)", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tin-none" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_n", name: "Glob" }] },
+        session_id: "tin-none",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tin-none" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toEqual([
+      { kind: "init", sessionId: "tin-none" },
+      { kind: "tool", tool: "Glob" },
+    ]);
+  });
+
+  test("a tool_result → {kind:'tool_result', tool, ok, preview} labeled via the tool_use_id map", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tr-1" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_42", name: "Read", input: { file_path: "/a" } }] },
+        session_id: "tr-1",
+      },
+      {
+        type: "user",
+        message: {
+          content: [{ type: "tool_result", tool_use_id: "tu_42", is_error: false, content: "file contents here" }],
+        },
+        session_id: "tr-1",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tr-1" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toContainEqual({
+      kind: "tool_result",
+      tool: "Read", // labeled via the tool_use_id → name map
+      ok: true,
+      preview: "file contents here",
+    });
+  });
+
+  test("a tool_result with array content parts joins the text parts into the preview", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tr-arr" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_arr", name: "Bash", input: { command: "ls" } }] },
+        session_id: "tr-arr",
+      },
+      {
+        type: "user",
+        message: {
+          content: [
+            {
+              type: "tool_result",
+              tool_use_id: "tu_arr",
+              is_error: false,
+              content: [
+                { type: "text", text: "line1\n" },
+                { type: "text", text: "line2" },
+              ],
+            },
+          ],
+        },
+        session_id: "tr-arr",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tr-arr" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toContainEqual({ kind: "tool_result", tool: "Bash", ok: true, preview: "line1\nline2" });
+  });
+
+  test("an OVERSIZE tool_result preview is truncated with the … marker", async () => {
+    const bigOut = "y".repeat(MAX_TOOL_RESULT_CHARS + 500);
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tr-big" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_big", name: "Bash", input: {} }] },
+        session_id: "tr-big",
+      },
+      {
+        type: "user",
+        message: { content: [{ type: "tool_result", tool_use_id: "tu_big", is_error: false, content: bigOut }] },
+        session_id: "tr-big",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tr-big" },
+    );
+    const { events } = await collectInterim(blob);
+    const resultEvent = events.find((e) => e.kind === "tool_result");
+    expect(resultEvent).toBeDefined();
+    const preview = (resultEvent as { preview?: string }).preview!;
+    expect(preview.length).toBe(MAX_TOOL_RESULT_CHARS + 1);
+    expect(preview.endsWith("…")).toBe(true);
+  });
+
+  test("is_error:true → ok:false", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tr-err" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_e", name: "Bash", input: { command: "false" } }] },
+        session_id: "tr-err",
+      },
+      {
+        type: "user",
+        message: {
+          content: [{ type: "tool_result", tool_use_id: "tu_e", is_error: true, content: "command failed" }],
+        },
+        session_id: "tr-err",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tr-err" },
+    );
+    const { events } = await collectInterim(blob);
+    expect(events).toContainEqual({ kind: "tool_result", tool: "Bash", ok: false, preview: "command failed" });
+  });
+
+  test("a tool_result whose tool_use_id is unknown still emits, just without the tool label", async () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "tr-orphan" },
+      {
+        type: "user",
+        message: {
+          content: [{ type: "tool_result", tool_use_id: "tu_unknown", is_error: false, content: "orphan result" }],
+        },
+        session_id: "tr-orphan",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "done", session_id: "tr-orphan" },
+    );
+    const { events } = await collectInterim(blob);
+    // no `tool` key (unknown id), but ok + preview present
+    expect(events).toContainEqual({ kind: "tool_result", ok: true, preview: "orphan result" });
+  });
+
+  test("the blob parser (no sink) ignores tool inputs + results entirely — final turn unchanged", () => {
+    const blob = ndjson(
+      { type: "system", subtype: "init", session_id: "blob-tr" },
+      {
+        type: "assistant",
+        message: { content: [{ type: "tool_use", id: "tu_x", name: "Read", input: { file_path: "/x" } }] },
+        session_id: "blob-tr",
+      },
+      {
+        type: "user",
+        message: { content: [{ type: "tool_result", tool_use_id: "tu_x", is_error: false, content: "stuff" }] },
+        session_id: "blob-tr",
+      },
+      { type: "result", subtype: "success", is_error: false, result: "final", session_id: "blob-tr" },
+    );
+    const t = parseStreamJson(blob);
+    expect(t.reply).toBe("final");
+    expect(t.success).toBe(true);
+    expect(t.sessionId).toBe("blob-tr");
+  });
+});