@openparachute/agent 0.1.2 → 0.2.0

package/src/db/sessions.ts

@@ -1,241 +0,0 @@
-import type { Approval, ApprovalBody, ApprovalKind, ApprovalStatus, Session } from '../types.js';
-import { getDb, hasTable } from './connection.js';
-
-// ── Sessions ──
-
-export function createSession(session: Session): void {
-  getDb()
-    .prepare(
-      `INSERT INTO sessions (id, agent_group_id, messaging_group_id, thread_id, agent_provider, status, container_status, last_active, created_at)
-       VALUES (@id, @agent_group_id, @messaging_group_id, @thread_id, @agent_provider, @status, @container_status, @last_active, @created_at)`,
-    )
-    .run(session);
-}
-
-export function getSession(id: string): Session | undefined {
-  return getDb().prepare('SELECT * FROM sessions WHERE id = ?').get(id) as Session | undefined;
-}
-
-export function findSession(messagingGroupId: string, threadId: string | null): Session | undefined {
-  if (threadId) {
-    return getDb()
-      .prepare('SELECT * FROM sessions WHERE messaging_group_id = ? AND thread_id = ? AND status = ?')
-      .get(messagingGroupId, threadId, 'active') as Session | undefined;
-  }
-  return getDb()
-    .prepare('SELECT * FROM sessions WHERE messaging_group_id = ? AND thread_id IS NULL AND status = ?')
-    .get(messagingGroupId, 'active') as Session | undefined;
-}
-
-/**
- * Session lookup scoped to a specific agent group. Needed when multiple
- * agents are wired to the same messaging group + thread (fan-out) — the
- * plain `findSession` would return whichever agent's session happened to
- * be first and route to the wrong container.
- */
-export function findSessionForAgent(
-  agentGroupId: string,
-  messagingGroupId: string,
-  threadId: string | null,
-): Session | undefined {
-  if (threadId) {
-    return getDb()
-      .prepare(
-        "SELECT * FROM sessions WHERE agent_group_id = ? AND messaging_group_id = ? AND thread_id = ? AND status = 'active'",
-      )
-      .get(agentGroupId, messagingGroupId, threadId) as Session | undefined;
-  }
-  return getDb()
-    .prepare(
-      "SELECT * FROM sessions WHERE agent_group_id = ? AND messaging_group_id = ? AND thread_id IS NULL AND status = 'active'",
-    )
-    .get(agentGroupId, messagingGroupId) as Session | undefined;
-}
-
-/** Find an active session scoped to an agent group (ignoring messaging group). */
-export function findSessionByAgentGroup(agentGroupId: string): Session | undefined {
-  return getDb()
-    .prepare("SELECT * FROM sessions WHERE agent_group_id = ? AND status = 'active' ORDER BY created_at DESC LIMIT 1")
-    .get(agentGroupId) as Session | undefined;
-}
-
-export function getSessionsByAgentGroup(agentGroupId: string): Session[] {
-  return getDb().prepare('SELECT * FROM sessions WHERE agent_group_id = ?').all(agentGroupId) as Session[];
-}
-
-export function getActiveSessions(): Session[] {
-  return getDb().prepare("SELECT * FROM sessions WHERE status = 'active'").all() as Session[];
-}
-
-export function getRunningSessions(): Session[] {
-  return getDb().prepare("SELECT * FROM sessions WHERE container_status IN ('running', 'idle')").all() as Session[];
-}
-
-export function updateSession(
-  id: string,
-  updates: Partial<Pick<Session, 'status' | 'container_status' | 'last_active' | 'agent_provider'>>,
-): void {
-  const fields: string[] = [];
-  const values: Record<string, unknown> = { id };
-
-  for (const [key, value] of Object.entries(updates)) {
-    if (value !== undefined) {
-      fields.push(`${key} = @${key}`);
-      values[key] = value;
-    }
-  }
-  if (fields.length === 0) return;
-
-  getDb()
-    .prepare(`UPDATE sessions SET ${fields.join(', ')} WHERE id = @id`)
-    .run(values);
-}
-
-export function deleteSession(id: string): void {
-  getDb().prepare('DELETE FROM sessions WHERE id = ?').run(id);
-}
-
-// ── Approvals ──
-// Unified table for both inline UX prompts (`kind='question'`) and
-// admin-gating actions (`kind='install_packages'` etc.), collapsed in
-// migration 024 (paraclaw#11). The kind discriminator is open-string —
-// new module actions don't require a schema bump.
-
-interface ApprovalRow {
-  id: string;
-  kind: ApprovalKind;
-  agent_group_id: string;
-  session_id: string | null;
-  body: string;
-  status: ApprovalStatus;
-  approver_user_id: string | null;
-  decided_at: string | null;
-  created_at: string;
-  expires_at: string | null;
-}
-
-export interface CreateApprovalInput {
-  id: string;
-  kind: ApprovalKind;
-  agent_group_id: string;
-  session_id?: string | null;
-  body: ApprovalBody;
-  status?: ApprovalStatus;
-  created_at: string;
-  expires_at?: string | null;
-}
-
-function rowToApproval(row: ApprovalRow): Approval {
-  return {
-    id: row.id,
-    kind: row.kind,
-    agent_group_id: row.agent_group_id,
-    session_id: row.session_id,
-    body: JSON.parse(row.body) as ApprovalBody,
-    status: row.status,
-    approver_user_id: row.approver_user_id,
-    decided_at: row.decided_at,
-    created_at: row.created_at,
-    expires_at: row.expires_at,
-  };
-}
-
-/**
- * Insert an approval row. Idempotent: delivery retries with the same id must
- * not fail on UNIQUE before the send step gets a chance to succeed. Returns
- * true if a new row was inserted.
- */
-export function createApproval(input: CreateApprovalInput): boolean {
-  const result = getDb()
-    .prepare(
-      `INSERT OR IGNORE INTO approvals
-         (id, kind, agent_group_id, session_id, body, status, created_at, expires_at)
-       VALUES
-         (@id, @kind, @agent_group_id, @session_id, @body, @status, @created_at, @expires_at)`,
-    )
-    .run({
-      id: input.id,
-      kind: input.kind,
-      agent_group_id: input.agent_group_id,
-      session_id: input.session_id ?? null,
-      body: JSON.stringify(input.body),
-      status: input.status ?? 'pending',
-      created_at: input.created_at,
-      expires_at: input.expires_at ?? null,
-    });
-  return result.changes > 0;
-}
-
-export function getApproval(id: string): Approval | undefined {
-  const row = getDb().prepare('SELECT * FROM approvals WHERE id = ?').get(id) as ApprovalRow | undefined;
-  return row ? rowToApproval(row) : undefined;
-}
-
-export function deleteApproval(id: string): void {
-  getDb().prepare('DELETE FROM approvals WHERE id = ?').run(id);
-}
-
-/**
- * List pending approvals, optionally filtered by `kind`. Pass an array to
- * include only those kinds; pass `{ exclude }` to omit kinds (e.g. exclude
- * `'question'` for the admin-gating UI surface).
- */
-export function listPendingApprovals(filter?: { kinds?: ApprovalKind[]; excludeKinds?: ApprovalKind[] }): Approval[] {
-  const clauses = ["status = 'pending'"];
-  const params: Record<string, unknown> = {};
-  if (filter?.kinds && filter.kinds.length > 0) {
-    const placeholders = filter.kinds.map((_, i) => `@kind_${i}`).join(', ');
-    clauses.push(`kind IN (${placeholders})`);
-    filter.kinds.forEach((k, i) => {
-      params[`kind_${i}`] = k;
-    });
-  }
-  if (filter?.excludeKinds && filter.excludeKinds.length > 0) {
-    const placeholders = filter.excludeKinds.map((_, i) => `@xkind_${i}`).join(', ');
-    clauses.push(`kind NOT IN (${placeholders})`);
-    filter.excludeKinds.forEach((k, i) => {
-      params[`xkind_${i}`] = k;
-    });
-  }
-  const rows = getDb()
-    .prepare(`SELECT * FROM approvals WHERE ${clauses.join(' AND ')} ORDER BY created_at DESC`)
-    .all(params) as ApprovalRow[];
-  return rows.map(rowToApproval);
-}
-
-/**
- * Resolve ask_question render metadata (title + normalized options) for any
- * card, regardless of whether it lives in `approvals` (kind question or
- * action) or one of the permissions-module side tables.
- */
-export function getAskQuestionRender(
-  id: string,
-): { title: string; options: import('../channels/ask-question.js').NormalizedOption[] } | undefined {
-  if (hasTable(getDb(), 'approvals')) {
-    const a = getApproval(id);
-    if (a) {
-      const body = a.body as { title?: string; options?: import('../channels/ask-question.js').NormalizedOption[] };
-      if (body.title && Array.isArray(body.options)) {
-        return { title: body.title, options: body.options };
-      }
-    }
-  }
-
-  // Channel-registration + unknown-sender approvals persist title/options_json
-  // in their own tables — just SELECT and return.
-  if (hasTable(getDb(), 'pending_channel_approvals')) {
-    const c = getDb()
-      .prepare('SELECT title, options_json FROM pending_channel_approvals WHERE messaging_group_id = ?')
-      .get(id) as { title: string; options_json: string } | undefined;
-    if (c?.title) return { title: c.title, options: JSON.parse(c.options_json) };
-  }
-
-  if (hasTable(getDb(), 'pending_sender_approvals')) {
-    const s = getDb().prepare('SELECT title, options_json FROM pending_sender_approvals WHERE id = ?').get(id) as
-      | { title: string; options_json: string }
-      | undefined;
-    if (s?.title) return { title: s.title, options: JSON.parse(s.options_json) };
-  }
-
-  return undefined;
-}

package/src/delivery.test.ts

@@ -1,148 +0,0 @@
-/**
- * Delivery race tests.
- *
- * The active poll (1s, running sessions) and the sweep poll (60s, all
- * active sessions) both call deliverSessionMessages. A running session
- * sits in both result sets, so the two timer chains can race on the same
- * outbound row — read-undelivered → call channel API → markDelivered. The
- * INSERT OR IGNORE in markDelivered makes the DB write idempotent, but
- * the channel API has already fired twice → user sees the message twice.
- */
-import { openDb } from './db/connection.js';
-import fs from 'fs';
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-
-vi.mock('./container-runner.js', () => ({
-  wakeContainer: vi.fn().mockResolvedValue(undefined),
-  isContainerRunning: vi.fn().mockReturnValue(false),
-  killContainer: vi.fn(),
-  buildAgentGroupImage: vi.fn().mockResolvedValue(undefined),
-}));
-
-vi.mock('./config.js', async () => {
-  const actual = await vi.importActual<typeof import('./config.js')>('./config.js');
-  return { ...actual, DATA_DIR: '/tmp/paraclaw-test-delivery' };
-});
-
-const TEST_DIR = '/tmp/paraclaw-test-delivery';
-
-import { initTestDb, closeDb, runMigrations, createAgentGroup, createMessagingGroup } from './db/index.js';
-import { resolveSession, outboundDbPath } from './session-manager.js';
-import { deliverSessionMessages, setDeliveryAdapter } from './delivery.js';
-
-function now(): string {
-  return new Date().toISOString();
-}
-
-function seedAgentAndChannel(): void {
-  createAgentGroup({
-    id: 'ag-1',
-    name: 'Test Agent',
-    folder: 'test-agent',
-    agent_provider: null,
-    created_at: now(),
-  });
-  createMessagingGroup({
-    id: 'mg-1',
-    channel_type: 'telegram',
-    platform_id: 'telegram:123',
-    name: 'Test Chat',
-    is_group: 0,
-    unknown_sender_policy: 'public',
-    created_at: now(),
-  });
-}
-
-function insertOutbound(agentGroupId: string, sessionId: string, msgId: string): void {
-  const db = openDb(outboundDbPath(agentGroupId, sessionId));
-  db.prepare(
-    `INSERT INTO messages_out (id, timestamp, kind, platform_id, channel_type, content)
-     VALUES (?, datetime('now'), 'chat', 'telegram:123', 'telegram', ?)`,
-  ).run(msgId, JSON.stringify({ text: 'hello' }));
-  db.close();
-}
-
-beforeEach(() => {
-  if (fs.existsSync(TEST_DIR)) fs.rmSync(TEST_DIR, { recursive: true });
-  fs.mkdirSync(TEST_DIR, { recursive: true });
-  const db = initTestDb();
-  runMigrations(db);
-});
-
-afterEach(() => {
-  closeDb();
-  if (fs.existsSync(TEST_DIR)) fs.rmSync(TEST_DIR, { recursive: true });
-});
-
-describe('deliverSessionMessages — concurrent invocations', () => {
-  it('delivers a message exactly once when active and sweep polls overlap', async () => {
-    seedAgentAndChannel();
-    const { session } = resolveSession('ag-1', 'mg-1', null, 'shared');
-    insertOutbound('ag-1', session.id, 'out-1');
-
-    const calls: string[] = [];
-    setDeliveryAdapter({
-      async deliver(_channelType, _platformId, _threadId, _kind, content) {
-        calls.push(content);
-        // Hold long enough that the second concurrent caller can race the
-        // read-undelivered → markDelivered window.
-        await new Promise((r) => setTimeout(r, 100));
-        return 'plat-msg-1';
-      },
-    });
-
-    // Two concurrent calls — simulating active (1s) and sweep (60s) polls
-    // hitting the same running session at the same moment.
-    await Promise.all([deliverSessionMessages(session), deliverSessionMessages(session)]);
-
-    expect(calls).toHaveLength(1);
-  });
-
-  it('still delivers on a subsequent call after the first finishes', async () => {
-    seedAgentAndChannel();
-    const { session } = resolveSession('ag-1', 'mg-1', null, 'shared');
-    insertOutbound('ag-1', session.id, 'out-first');
-
-    const calls: string[] = [];
-    setDeliveryAdapter({
-      async deliver(_channelType, _platformId, _threadId, _kind, content) {
-        calls.push(content);
-        return 'plat-msg-id';
-      },
-    });
-
-    await deliverSessionMessages(session);
-    expect(calls).toHaveLength(1);
-
-    // Insert a second outbound message and deliver again — the lock from
-    // the first call must have been released.
-    insertOutbound('ag-1', session.id, 'out-second');
-    await deliverSessionMessages(session);
-    expect(calls).toHaveLength(2);
-  });
-
-  it('does not re-deliver when retried after a successful send (cleanup-after-send safety)', async () => {
-    // If something post-send throws (e.g. outbox cleanup), the message has
-    // still landed on the user's screen — the catch path must not trigger
-    // a re-send. We simulate by having the adapter succeed on the first
-    // call and recording how many times it's invoked across two attempts.
-    seedAgentAndChannel();
-    const { session } = resolveSession('ag-1', 'mg-1', null, 'shared');
-    insertOutbound('ag-1', session.id, 'out-once');
-
-    let callCount = 0;
-    setDeliveryAdapter({
-      async deliver() {
-        callCount++;
-        return 'plat-msg-id';
-      },
-    });
-
-    await deliverSessionMessages(session);
-    // Re-invoke — should be idempotent because the message is now in the
-    // delivered table; the channel adapter must not be called again.
-    await deliverSessionMessages(session);
-
-    expect(callCount).toBe(1);
-  });
-});