@openneuro/app 4.2.4 → 4.3.0-alpha.1

package/src/scripts/refactor_2021/dataset/fragments/__tests__/edit-button.spec.tsx

@@ -1,10 +1,10 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { render } from '@testing-library/react'
 import { EditButton } from '../edit-button'
 
 describe('EditButton component', () => {
   it('renders with default props', () => {
-    const wrapper = shallow(<EditButton action={() => {}} />)
-    expect(wrapper).toMatchSnapshot()
+    const { asFragment } = render(<EditButton action={() => {}} />)
+    expect(asFragment()).toMatchSnapshot()
   })
 })

package/src/scripts/refactor_2021/dataset/fragments/__tests__/edit-list.spec.jsx

@@ -2,7 +2,6 @@ import React from 'react'
 import { render, fireEvent, screen } from '@testing-library/react'
 import EditList from '../edit-list.jsx'
 
-// Mount is used because enzyme does not yet support hooks
 describe('EditList component', () => {
   it('renders with default props', () => {
     const { asFragment } = render(<EditList />)

package/src/scripts/refactor_2021/dataset/fragments/__tests__/save-button.spec.tsx

@@ -1,10 +1,10 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { render } from '@testing-library/react'
 import { SaveButton } from '../save-button'
 
 describe('SaveButton component', () => {
   it('renders with default props', () => {
-    const wrapper = shallow(<SaveButton action={() => {}} />)
-    expect(wrapper).toMatchSnapshot()
+    const { asFragment } = render(<SaveButton action={() => {}} />)
+    expect(asFragment()).toMatchSnapshot()
   })
 })

package/src/scripts/refactor_2021/dataset/fragments/__tests__/select-input.spec.tsx

@@ -1,10 +1,10 @@
 import React from 'react'
-import { shallow } from 'enzyme'
+import { render, fireEvent, screen } from '@testing-library/react'
 import SelectInput from '../select-input'
 
 describe('SelectInput', () => {
   it('handles display as disabled', () => {
-    const wrapper = shallow(
+    const { asFragment } = render(
       <SelectInput
         {...{
           name: 'Expected name',
@@ -16,10 +16,10 @@ describe('SelectInput', () => {
         }}
       />,
     )
-    expect(wrapper).toMatchSnapshot()
+    expect(asFragment()).toMatchSnapshot()
   })
   it('handles display as not disabled', () => {
-    const wrapper = shallow(
+    const { asFragment } = render(
       <SelectInput
         {...{
           name: 'Expected name',
@@ -31,10 +31,10 @@ describe('SelectInput', () => {
         }}
       />,
     )
-    expect(wrapper).toMatchSnapshot()
+    expect(asFragment()).toMatchSnapshot()
   })
   it('handles boolean display', () => {
-    const wrapper = shallow(
+    const { asFragment } = render(
       <SelectInput
         {...{
           name: 'Expected name',
@@ -50,12 +50,12 @@ describe('SelectInput', () => {
         }}
       />,
     )
-    expect(wrapper).toMatchSnapshot()
+    expect(asFragment()).toMatchSnapshot()
   })
   it('handles boolean values', () => {
     let _, value
     const onChange = (...args) => ([_, value] = args)
-    const wrapper = shallow(
+    render(
       <SelectInput
         {...{
           name: 'Expected name',
@@ -78,7 +78,7 @@ describe('SelectInput', () => {
       },
       target: { value: 'false' },
     }
-    wrapper.find('styledSelect[name="Expected name"]').simulate('change', event)
+    fireEvent.change(screen.getByRole('combobox'), event)
     expect(value).toBe(false)
   })
 })

package/src/scripts/refactor_2021/dataset/fragments/dataset-alert-draft.tsx

@@ -0,0 +1,79 @@
+import React from 'react'
+import { Link } from 'react-router-dom'
+import { DatasetAlert } from '@openneuro/components/dataset'
+
+export interface DatasetAlertDraftProps {
+  isPrivate: boolean
+  datasetId: string
+  hasDraftChanges: boolean
+  hasSnapshot: boolean
+}
+
+export const DatasetAlertDraft: React.FC<DatasetAlertDraftProps> = ({
+  isPrivate,
+  datasetId,
+  hasDraftChanges,
+  hasSnapshot,
+}) => {
+  if (isPrivate) {
+    if (hasSnapshot) {
+      return (
+        <DatasetAlert
+          alert="This dataset has not been published!"
+          footer={
+            hasDraftChanges &&
+            '* There have been changes to the draft since your last version'
+          }
+          level="warning">
+          <>
+            <Link
+              className="dataset-tool"
+              to={'/datasets/' + datasetId + '/publish'}>
+              Publish this dataset
+            </Link>
+            &#32; to make all versions available publicly.
+          </>
+        </DatasetAlert>
+      )
+    } else {
+      return (
+        <DatasetAlert
+          alert="This dataset has not been published!"
+          level="warning">
+          Before it can be published, please&#32;
+          <Link
+            className="dataset-tool"
+            to={'/datasets/' + datasetId + '/snapshot'}>
+            create a version
+          </Link>
+        </DatasetAlert>
+      )
+    }
+  } else {
+    if (hasDraftChanges) {
+      return (
+        <DatasetAlert alert="This dataset has been published!" level="warning">
+          There are currently unsaved changes to this Draft. Changes made here
+          become public when you&#32;
+          <Link
+            className="dataset-tool"
+            to={'/datasets/' + datasetId + '/snapshot'}>
+            create a new version.
+          </Link>
+        </DatasetAlert>
+      )
+    } else {
+      return (
+        <DatasetAlert alert="This dataset has been published!">
+          You can make changes to this Draft page, then&#32;
+          <Link
+            className="dataset-tool"
+            to={'/datasets/' + datasetId + '/snapshot'}>
+            create a new version
+          </Link>
+          &#32;to make them public.
+        </DatasetAlert>
+      )
+    }
+  }
+}

package/src/scripts/refactor_2021/dataset/fragments/dataset-alert-version.tsx

@@ -0,0 +1,24 @@
+import React from 'react'
+import { DatasetAlert } from '@openneuro/components/dataset'
+import { UndoDeprecateVersion } from '../mutations/undo-deprecate-version'
+
+export interface DatasetAlertVersionProps {
+  datasetId: string
+  tag: string
+  reason: string
+  hasEdit: boolean
+}
+
+export const DatasetAlertVersion: React.FC<DatasetAlertVersionProps> = ({
+  datasetId,
+  tag,
+  reason,
+  hasEdit,
+}) => (
+  <DatasetAlert
+    alert="This version has been deprecated!"
+    level="error"
+    footer={reason}>
+    {hasEdit && <UndoDeprecateVersion datasetId={datasetId} tag={tag} />}
+  </DatasetAlert>
+)

package/src/scripts/refactor_2021/dataset/fragments/select-input.tsx

@@ -70,7 +70,7 @@ const Select = styled.select<ShowOtherProps>(
       height: '100%',
       color: 'rgba(0,0,0,0)',
       backgroundColor: 'rgba(0,0,0,0)',
-      '-moz-appearance': 'none',
+      MozAppearance: 'none',
     },
   },
   ({ showOther }) =>

package/src/scripts/refactor_2021/dataset/mutations/__tests__/__snapshots__/deprecate-snapshot.spec.tsx.snap

@@ -0,0 +1,14 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`DeprecateVersion mutation renders with typical props 1`] = `
+<DocumentFragment>
+  <button
+    aria-label="Deprecate Version"
+    class="on-button on-button--small on-button--primary  btn-modal-action"
+    role="button"
+    type="button"
+  >
+    Deprecate Version
+  </button>
+</DocumentFragment>
+`;

package/src/scripts/refactor_2021/dataset/mutations/__tests__/__snapshots__/deprecate-version.spec.tsx.snap

@@ -0,0 +1,14 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`DeprecateVersion mutation renders with typical props 1`] = `
+<DocumentFragment>
+  <button
+    aria-label="Deprecate Version"
+    class="on-button on-button--small on-button--primary  btn-modal-action"
+    role="button"
+    type="button"
+  >
+    Deprecate Version
+  </button>
+</DocumentFragment>
+`;

package/src/scripts/refactor_2021/dataset/mutations/__tests__/__snapshots__/description.spec.jsx.snap

@@ -1,281 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`UpdateDescription mutation renders with common props 1`] = `
-<Mutation
-  mutation={
-    Object {
-      "definitions": Array [
-        Object {
-          "directives": Array [],
-          "kind": "OperationDefinition",
-          "name": Object {
-            "kind": "Name",
-            "value": "updateDescription",
-          },
-          "operation": "mutation",
-          "selectionSet": Object {
-            "kind": "SelectionSet",
-            "selections": Array [
-              Object {
-                "alias": undefined,
-                "arguments": Array [
-                  Object {
-                    "kind": "Argument",
-                    "name": Object {
-                      "kind": "Name",
-                      "value": "datasetId",
-                    },
-                    "value": Object {
-                      "kind": "Variable",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "datasetId",
-                      },
-                    },
-                  },
-                  Object {
-                    "kind": "Argument",
-                    "name": Object {
-                      "kind": "Name",
-                      "value": "field",
-                    },
-                    "value": Object {
-                      "kind": "Variable",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "field",
-                      },
-                    },
-                  },
-                  Object {
-                    "kind": "Argument",
-                    "name": Object {
-                      "kind": "Name",
-                      "value": "value",
-                    },
-                    "value": Object {
-                      "kind": "Variable",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "value",
-                      },
-                    },
-                  },
-                ],
-                "directives": Array [],
-                "kind": "Field",
-                "name": Object {
-                  "kind": "Name",
-                  "value": "updateDescription",
-                },
-                "selectionSet": Object {
-                  "kind": "SelectionSet",
-                  "selections": Array [
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "id",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "Name",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "BIDSVersion",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "License",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "Authors",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "Acknowledgements",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "HowToAcknowledge",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "Funding",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "ReferencesAndLinks",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "DatasetDOI",
-                      },
-                      "selectionSet": undefined,
-                    },
-                    Object {
-                      "alias": undefined,
-                      "arguments": Array [],
-                      "directives": Array [],
-                      "kind": "Field",
-                      "name": Object {
-                        "kind": "Name",
-                        "value": "EthicsApprovals",
-                      },
-                      "selectionSet": undefined,
-                    },
-                  ],
-                },
-              },
-            ],
-          },
-          "variableDefinitions": Array [
-            Object {
-              "defaultValue": undefined,
-              "directives": Array [],
-              "kind": "VariableDefinition",
-              "type": Object {
-                "kind": "NonNullType",
-                "type": Object {
-                  "kind": "NamedType",
-                  "name": Object {
-                    "kind": "Name",
-                    "value": "ID",
-                  },
-                },
-              },
-              "variable": Object {
-                "kind": "Variable",
-                "name": Object {
-                  "kind": "Name",
-                  "value": "datasetId",
-                },
-              },
-            },
-            Object {
-              "defaultValue": undefined,
-              "directives": Array [],
-              "kind": "VariableDefinition",
-              "type": Object {
-                "kind": "NonNullType",
-                "type": Object {
-                  "kind": "NamedType",
-                  "name": Object {
-                    "kind": "Name",
-                    "value": "String",
-                  },
-                },
-              },
-              "variable": Object {
-                "kind": "Variable",
-                "name": Object {
-                  "kind": "Name",
-                  "value": "field",
-                },
-              },
-            },
-            Object {
-              "defaultValue": undefined,
-              "directives": Array [],
-              "kind": "VariableDefinition",
-              "type": Object {
-                "kind": "NonNullType",
-                "type": Object {
-                  "kind": "NamedType",
-                  "name": Object {
-                    "kind": "Name",
-                    "value": "String",
-                  },
-                },
-              },
-              "variable": Object {
-                "kind": "Variable",
-                "name": Object {
-                  "kind": "Name",
-                  "value": "value",
-                },
-              },
-            },
-          ],
-        },
-      ],
-      "kind": "Document",
-      "loc": Object {
-        "end": 374,
-        "start": 0,
-      },
-    }
-  }
-  update={[Function]}
->
-  <Component />
-</Mutation>
+<DocumentFragment>
+  Mutation mock
+</DocumentFragment>
 `;

package/src/scripts/refactor_2021/dataset/mutations/__tests__/deprecate-snapshot.spec.tsx

@@ -0,0 +1,71 @@
+import React from 'react'
+import { render, fireEvent, screen, waitFor } from '@testing-library/react'
+import { MockedProvider } from '@apollo/client/testing'
+import { Router } from 'react-router-dom'
+import { createMemoryHistory } from 'history'
+import { DeprecateVersion, DEPRECATE_VERSION } from '../deprecate-version'
+
+describe('DeprecateVersion mutation', () => {
+  it('renders with typical props', () => {
+    const { asFragment } = render(
+      <MockedProvider>
+        <DeprecateVersion
+          datasetId="test00001"
+          tag="1.0.0"
+          reason="This is a test suite."
+        />
+      </MockedProvider>,
+    )
+    expect(asFragment()).toMatchSnapshot()
+  })
+  it('calls the DEPRECATE_VERSION mutation when clicked and navigates to the snapshot on success', async () => {
+    const datasetId = 'test00001'
+    const tag = '1.0.0'
+    const reason = 'This is a test suite.'
+    const history = createMemoryHistory({
+      initialEntries: [`/datasets/${datasetId}/versions/${tag}/deprecate`],
+    })
+    const historyPushSpy = jest.spyOn(history, 'push')
+    const snapshotId = `${datasetId}:${tag}`
+    const deprecateSnapshotMock = {
+      request: {
+        query: DEPRECATE_VERSION,
+        variables: {
+          datasetId,
+          tag,
+          reason,
+        },
+      },
+      result: {
+        data: {
+          deprecateSnapshot: {
+            __typename: 'Snapshot',
+            id: snapshotId,
+            deprecated: {
+              __typename: 'DeprecatedSnapshot',
+              id: snapshotId,
+              user: '1245',
+              reason,
+            },
+          },
+        },
+      },
+    }
+
+    render(
+      <Router history={history}>
+        <MockedProvider mocks={[deprecateSnapshotMock]} addTypename={false}>
+          <DeprecateVersion datasetId={datasetId} tag={tag} reason={reason} />
+        </MockedProvider>
+      </Router>,
+    )
+
+    fireEvent.click(screen.getByLabelText(/Deprecate Version/i))
+
+    await waitFor(() => expect(historyPushSpy).toHaveBeenCalledTimes(1))
+
+    expect(history.location.pathname).toBe(
+      `/datasets/${datasetId}/versions/${tag}`,
+    )
+  })
+})

package/src/scripts/refactor_2021/dataset/mutations/__tests__/deprecate-version.spec.tsx

@@ -0,0 +1,71 @@
+import React from 'react'
+import { render, fireEvent, screen, waitFor } from '@testing-library/react'
+import { MockedProvider } from '@apollo/client/testing'
+import { Router } from 'react-router-dom'
+import { createMemoryHistory } from 'history'
+import { DeprecateVersion, DEPRECATE_VERSION } from '../deprecate-version'
+
+describe('DeprecateVersion mutation', () => {
+  it('renders with typical props', () => {
+    const { asFragment } = render(
+      <MockedProvider>
+        <DeprecateVersion
+          datasetId="test00001"
+          tag="1.0.0"
+          reason="This is a test suite."
+        />
+      </MockedProvider>,
+    )
+    expect(asFragment()).toMatchSnapshot()
+  })
+  it('calls the DEPRECATE_VERSION mutation when clicked and navigates to the snapshot on success', async () => {
+    const datasetId = 'test00001'
+    const tag = '1.0.0'
+    const reason = 'This is a test suite.'
+    const history = createMemoryHistory({
+      initialEntries: [`/datasets/${datasetId}/versions/${tag}/deprecate`],
+    })
+    const historyPushSpy = jest.spyOn(history, 'push')
+    const snapshotId = `${datasetId}:${tag}`
+    const deprecateSnapshotMock = {
+      request: {
+        query: DEPRECATE_VERSION,
+        variables: {
+          datasetId,
+          tag,
+          reason,
+        },
+      },
+      result: {
+        data: {
+          deprecateSnapshot: {
+            __typename: 'Snapshot',
+            id: snapshotId,
+            deprecated: {
+              __typename: 'DeprecatedSnapshot',
+              id: snapshotId,
+              user: '1245',
+              reason,
+            },
+          },
+        },
+      },
+    }
+
+    render(
+      <Router history={history}>
+        <MockedProvider mocks={[deprecateSnapshotMock]} addTypename={false}>
+          <DeprecateVersion datasetId={datasetId} tag={tag} reason={reason} />
+        </MockedProvider>
+      </Router>,
+    )
+
+    fireEvent.click(screen.getByLabelText(/Deprecate Version/i))
+
+    await waitFor(() => expect(historyPushSpy).toHaveBeenCalledTimes(1))
+
+    expect(history.location.pathname).toBe(
+      `/datasets/${datasetId}/versions/${tag}`,
+    )
+  })
+})