@opengsd/gsd-pi 1.1.1-dev.616a1a1 → 1.1.1-dev.9bb7453

package/packages/gsd-agent-modes/dist/modes/interactive/controllers/chat-controller.js

@@ -20,6 +20,9 @@ let orphanedSegments = [];
 // Invocation matching only reconciles IDs reported by different event streams.
 // Same-source identical invocations are separate concurrent tool calls.
 const toolRegistrationSources = new WeakMap();
+const PROVISIONAL_PRE_TOOL_ACTIONS = "check|inspect|look(?:\\s+into)?|read|open|search|grep|scan|run|verify|test|trace|review|investigate|reproduce|use|gather|find|pull|query|take a look|update|patch|edit|change|modify|write|create|add|remove|apply";
+const FIRST_PERSON_PROVISIONAL_PRE_TOOL_RE = new RegExp(`^(?:i(?:'ll| will)|i(?:'m| am) going to|let me|i need to)\\s+(?:${PROVISIONAL_PRE_TOOL_ACTIONS})\\b`, "i");
+const GERUND_PROVISIONAL_PRE_TOOL_RE = /^(?:checking|inspecting|reading|searching|running|verifying|testing|tracing|reviewing|investigating|scanning|updating|patching|editing|writing|creating|applying)\b/i;
 function findPendingToolByInvocation(pendingTools, toolName, args, source) {
     let fallback;
     for (const component of pendingTools.values()) {
@@ -50,6 +53,7 @@ function registerPendingToolComponent(host, toolCallId, toolName, args, source,
     const component = createComponent();
     component.setExpanded(host.toolOutputExpanded);
     host.chatContainer.addChild(component);
+    markFirstVisibleAssistantOutput(host, "tool", { toolName, source });
     host.pendingTools.set(toolCallId, component);
     toolRegistrationSources.set(component, new Set([source]));
     return { component, created: true };
@@ -69,6 +73,12 @@ function startLoadingAnimation(host) {
         host.pendingWorkingMessage = undefined;
     }
 }
+function markTuiLatency(host, phase, data) {
+    host.session?.markTurnLatency?.(phase, data);
+}
+function markFirstVisibleAssistantOutput(host, kind, data) {
+    host.session?.markFirstVisibleTurnLatency?.(kind, data);
+}
 function getVisibleTextLikeBlockType(block) {
     if (block?.type === "text" && typeof block.text === "string" && block.text.trim().length > 0)
         return "text";
@@ -244,6 +254,64 @@ function buildDesiredSegments(blocks, options = {}) {
     closeRun();
     return desired;
 }
+function isToolUseBlock(block) {
+    return block?.type === "toolCall" || block?.type === "serverToolUse";
+}
+function isMcpToolBlock(block) {
+    if (!isToolUseBlock(block))
+        return false;
+    const toolName = typeof block?.name === "string" ? block.name : "";
+    return typeof block?.mcpServer === "string" || toolName.startsWith("mcp__");
+}
+function hasPostToolText(blocks, firstToolIdx) {
+    if (firstToolIdx < 0)
+        return false;
+    return blocks.some((b, idx) => (idx > firstToolIdx
+        && b?.type === "text"
+        && typeof b?.text === "string"
+        && b.text.trim().length > 0));
+}
+function normalizeProvisionalText(text) {
+    return text
+        .trim()
+        .replace(/[’`]/g, "'")
+        .replace(/\s+/g, " ");
+}
+export function isProvisionalPreToolProse(text) {
+    const normalized = normalizeProvisionalText(text);
+    if (!normalized)
+        return false;
+    if (textInvitesUserReply(normalized))
+        return false;
+    if (/\?\s*$/.test(normalized))
+        return false;
+    return FIRST_PERSON_PROVISIONAL_PRE_TOOL_RE.test(normalized)
+        || GERUND_PROVISIONAL_PRE_TOOL_RE.test(normalized);
+}
+function getProvisionalPreToolPrunePlan(message) {
+    const blocks = message.content;
+    const firstToolIdx = blocks.findIndex(isToolUseBlock);
+    return {
+        firstToolIdx,
+        shouldPrune: message.provider === "claude-code"
+            && firstToolIdx >= 0
+            && blocks.some(isMcpToolBlock)
+            && hasPostToolText(blocks, firstToolIdx),
+    };
+}
+function buildDesiredSegmentsForMessage(message) {
+    const { shouldPrune, firstToolIdx } = getProvisionalPreToolPrunePlan(message);
+    return buildDesiredSegments(message.content, {
+        shouldSkipTextBlock: (block, index) => {
+            if (!shouldPrune || firstToolIdx < 0 || index >= firstToolIdx)
+                return false;
+            if (getVisibleTextLikeBlockType(block) !== "text")
+                return false;
+            const textValue = typeof block?.text === "string" ? block.text : "";
+            return isProvisionalPreToolProse(textValue);
+        },
+    });
+}
 function hasVisibleAssistantContent(message) {
     return message.content.some((c) => getVisibleTextLikeBlockType(c) !== undefined);
 }
@@ -456,6 +524,7 @@ export async function handleAgentEvent(host, event) {
             }
             host.statusContainer.clear();
             startLoadingAnimation(host);
+            markTuiLatency(host, "tui.loader_visible");
             host.ui.requestRender();
             break;
         case "message_start":
@@ -473,6 +542,10 @@ export async function handleAgentEvent(host, event) {
                 // External-tool providers can stream multiple assistant turns through
                 // one response. Delay component creation until visible assistant text
                 // arrives so tool outputs keep chronological ordering.
+                markTuiLatency(host, "tui.assistant_message_start", {
+                    provider: event.message.provider,
+                    model: event.message.model,
+                });
                 host.ui.requestRender();
             }
             break;
@@ -576,44 +649,21 @@ export async function handleAgentEvent(host, event) {
                 // Build desired segment plan from content[].
                 {
                     const blocks = host.streamingMessage.content;
-                    const isClaudeCodeProvider = host.streamingMessage.provider === "claude-code";
-                    const hasMcpToolBlock = blocks.some((b) => {
-                        if (b?.type === "toolCall") {
-                            return typeof b?.mcpServer === "string" || String(b?.name ?? "").startsWith("mcp__");
-                        }
-                        if (b?.type === "serverToolUse") {
-                            return typeof b?.mcpServer === "string" || String(b?.name ?? "").startsWith("mcp__");
-                        }
-                        return false;
-                    });
-                    const firstToolIdx = blocks.findIndex((b) => b.type === "toolCall" || b.type === "serverToolUse");
-                    const hasPostToolText = firstToolIdx >= 0
-                        && blocks.some((b, idx) => (idx > firstToolIdx
-                            && b?.type === "text"
-                            && typeof b?.text === "string"
-                            && b.text.trim().length > 0));
                     // Only prune provisional pre-tool prose after post-tool prose exists,
                     // so MCP tool-only windows do not blank the assistant content.
-                    const shouldDropPreToolProse = isClaudeCodeProvider && hasMcpToolBlock && hasPostToolText;
-                    let desired = buildDesiredSegments(blocks, {
-                        shouldSkipTextBlock: (block, index) => {
-                            if (!shouldDropPreToolProse || firstToolIdx < 0 || index >= firstToolIdx)
-                                return false;
-                            if (getVisibleTextLikeBlockType(block) !== "text")
-                                return false;
-                            const textValue = typeof block?.text === "string" ? block.text : "";
-                            return !/\?\s*$/.test(textValue.trim());
-                        },
-                    });
+                    const { shouldPrune: shouldPruneProvisionalPreToolProse } = getProvisionalPreToolPrunePlan(host.streamingMessage);
+                    let desired = buildDesiredSegmentsForMessage(host.streamingMessage);
                     desired = filterRedundantDiscussTextRuns(desired, blocks);
                     // Claude Code MCP can emit provisional pre-tool prose that gets
                     // superseded by post-tool output. Prune stale text-run segments so
                     // the final assistant output remains below tool output.
-                    if (shouldDropPreToolProse && firstToolIdx >= 0) {
+                    if (shouldPruneProvisionalPreToolProse) {
                         if (orphanedSegments.length > 0) {
                             const remainingOrphans = [];
                             for (const orphan of orphanedSegments) {
-                                if (orphan.kind === "text-run" && orphan.contentType === "text") {
+                                if (orphan.kind === "text-run"
+                                    && orphan.contentType === "text"
+                                    && isProvisionalPreToolProse(orphan.cachedText ?? "")) {
                                     host.chatContainer.removeChild(orphan.component);
                                     if (host.streamingComponent === orphan.component) {
                                         host.streamingComponent = undefined;
@@ -674,6 +724,9 @@ export async function handleAgentEvent(host, event) {
                                     chatTurnFollowsUser(host.chatContainer.children);
                                 const comp = new AssistantMessageComponent(undefined, host.hideThinkingBlock, host.getMarkdownThemeWithSettings(), timestampFormat, { startIndex: seg.startIndex, endIndex: seg.endIndex }, connectedToUser);
                                 host.chatContainer.addChild(comp);
+                                markFirstVisibleAssistantOutput(host, seg.contentType, {
+                                    contentIndex: seg.startIndex,
+                                });
                                 renderedSegments.push({
                                     kind: "text-run",
                                     startIndex: seg.startIndex,
@@ -799,14 +852,14 @@ export async function handleAgentEvent(host, event) {
                 const shouldRenderAssistant = hasVisibleAssistantContent(host.streamingMessage)
                     || ((host.streamingMessage.stopReason === "aborted" || host.streamingMessage.stopReason === "error")
                         && !hasAssistantToolBlocks(host.streamingMessage));
-                const suppressRedundantHandoff = shouldSuppressRedundantHandoffText(host.session.messages, extractAssistantText(host.streamingMessage), orphanedSegments, renderedSegments);
+                const suppressRedundantHandoff = shouldSuppressRedundantHandoffText(host.session.messages, extractAssistantText(host.streamingMessage), orphanedSegments, []);
                 // The final message_end payload can contain additional text/thinking
                 // blocks that never arrived via message_update (e.g. SDK result
                 // aggregation). Rebuild this in-flight turn from final content so
                 // ranges/components don't keep stale partial indices.
                 if (renderedSegments.length > 0) {
                     const finalBlocks = host.streamingMessage.content;
-                    const desired = filterRedundantDiscussTextRuns(buildDesiredSegments(finalBlocks), finalBlocks);
+                    const desired = filterRedundantDiscussTextRuns(buildDesiredSegmentsForMessage(host.streamingMessage), finalBlocks);
                     const toolComponentsById = new Map();
                     for (const [toolId, component] of host.pendingTools.entries()) {
                         toolComponentsById.set(toolId, component);
@@ -858,6 +911,10 @@ export async function handleAgentEvent(host, event) {
                             continue;
                         }
                         host.chatContainer.addChild(comp);
+                        markFirstVisibleAssistantOutput(host, seg.contentType, {
+                            contentIndex: seg.startIndex,
+                            source: "message_end_rebuild",
+                        });
                         renderedSegments.push({
                             kind: "text-run",
                             startIndex: seg.startIndex,
@@ -874,6 +931,7 @@ export async function handleAgentEvent(host, event) {
                     const connectedToUser = chatTurnFollowsUser(host.chatContainer.children);
                     host.streamingComponent = new AssistantMessageComponent(undefined, host.hideThinkingBlock, host.getMarkdownThemeWithSettings(), timestampFormat, undefined, connectedToUser);
                     host.chatContainer.addChild(host.streamingComponent);
+                    markFirstVisibleAssistantOutput(host, "message_end_only");
                     reconcileChatTurnConnections(host.chatContainer.children);
                 }
                 if (host.streamingComponent) {
@@ -954,6 +1012,9 @@ export async function handleAgentEvent(host, event) {
                 host.streamingComponent.setShowMetadata(true);
                 host.streamingComponent.updateContent(host.streamingMessage);
             }
+            for (const component of new Set(host.pendingTools.values())) {
+                component.markHistoricalNoResult();
+            }
             replaceCompactToolRowsWithPhaseSummary(host);
             host.streamingComponent = undefined;
             host.streamingMessage = undefined;