@opengsd/gsd-pi 1.1.1-dev.616a1a1 → 1.1.1-dev.9bb7453

package/dist/resources/extensions/gsd/tools/workflow-tool-executors.js

@@ -3,13 +3,13 @@
 import { ensureDbOpen } from "../bootstrap/dynamic-tools.js";
 import { sanitizeCompleteMilestoneParams } from "../bootstrap/sanitize-complete-milestone.js";
 import { loadWriteGateSnapshot, shouldBlockContextArtifactSaveInSnapshot, shouldBlockRootArtifactSaveInSnapshot } from "../bootstrap/write-gate.js";
-import { getActiveRequirements, insertMilestone, getMilestone, getSliceStatusSummary, getSliceTaskCounts, readTransaction, saveGateResult, } from "../gsd-db.js";
+import { getActiveRequirements, insertMilestone, getMilestone, getSliceStatusSummary, getSliceTaskCounts, insertGateRun, readTransaction, saveGateResult, upsertQualityGate, } from "../gsd-db.js";
 import { GATE_REGISTRY } from "../gate-registry.js";
 import { generateRequirementsMd, saveArtifactToDb } from "../db-writer.js";
 import { clearPathCache, resolveGsdPathContract, resolveMilestoneFile, resolveSliceFile } from "../paths.js";
 import { saveFile, clearParseCache } from "../files.js";
-import { unlinkSync } from "node:fs";
-import { join } from "node:path";
+import { existsSync, readdirSync, readFileSync, unlinkSync } from "node:fs";
+import { isAbsolute, join, resolve } from "node:path";
 import { handleCompleteMilestone } from "./complete-milestone.js";
 import { handleCompleteTask } from "./complete-task.js";
 import { handleCompleteSlice } from "./complete-slice.js";
@@ -26,6 +26,7 @@ import { invalidateStateCache } from "../state.js";
 import { loadEffectiveGSDPreferences } from "../preferences.js";
 import { parseProject } from "../schemas/parsers.js";
 import { getAutoRuntimeSnapshot } from "../auto-runtime-state.js";
+import { canonicalWorkflowToolName, parseMcpToolName, RUN_UAT_FORBIDDEN_TOOL_NAMES, RUN_UAT_WORKFLOW_TOOL_NAMES, } from "../tool-presentation-plan.js";
 export const SUPPORTED_SUMMARY_ARTIFACT_TYPES = [
     "SUMMARY",
     "RESEARCH",
@@ -333,6 +334,28 @@ export async function executeTaskComplete(params, basePath = process.cwd()) {
                 isError: true,
             };
         }
+        if (result.escalation) {
+            const recommended = result.escalation.options.find((option) => option.id === result.escalation?.recommendation);
+            const optionIds = result.escalation.options.map((option) => option.id).join("|");
+            return {
+                content: [{
+                        type: "text",
+                        text: [
+                            `Task completed with escalation decision required: ${result.escalation.question}`,
+                            `Recommendation: ${result.escalation.recommendation}${recommended ? ` (${recommended.label})` : ""} — ${result.escalation.recommendationRationale}`,
+                            `Resolve with: /gsd escalate resolve ${result.taskId} <${optionIds}|accept|reject-blocker> [rationale...]`,
+                        ].join("\n"),
+                    }],
+                details: {
+                    operation: "complete_task",
+                    taskId: result.taskId,
+                    sliceId: result.sliceId,
+                    milestoneId: result.milestoneId,
+                    summaryPath: result.summaryPath,
+                    escalation: result.escalation,
+                },
+            };
+        }
         return {
             content: [{ type: "text", text: `Completed task ${result.taskId} (${result.sliceId}/${result.milestoneId})` }],
             details: {
@@ -775,6 +798,383 @@ export async function executeSaveGateResult(params, basePath = process.cwd()) {
         };
     }
 }
+function errorResult(operation, message, error) {
+    return {
+        content: [{ type: "text", text: `Error: ${message}` }],
+        details: { operation, error },
+        isError: true,
+    };
+}
+function isNonEmptyString(value) {
+    return typeof value === "string" && value.trim().length > 0;
+}
+function ensureUatRequiredFields(params) {
+    if (!isNonEmptyString(params.milestoneId))
+        return "milestoneId is required";
+    if (!isNonEmptyString(params.sliceId))
+        return "sliceId is required";
+    if (!isNonEmptyString(params.uatType))
+        return "uatType is required";
+    if (!["PASS", "FAIL", "PARTIAL"].includes(params.verdict))
+        return "verdict must be PASS, FAIL, or PARTIAL";
+    if (!Array.isArray(params.checks) || params.checks.length === 0)
+        return "checks must contain at least one UAT check";
+    if (!params.presentation || !Array.isArray(params.presentation.presentedTools))
+        return "presentation.presentedTools is required";
+    if (!Array.isArray(params.presentation.blockedTools))
+        return "presentation.blockedTools is required";
+    return null;
+}
+function approvedEvidenceRoots(basePath) {
+    const contract = resolveGsdPathContract(basePath);
+    return [contract.worktreeGsd, contract.projectGsd].filter((root) => typeof root === "string");
+}
+function approvedBrowserArtifactRoots(basePath) {
+    const contract = resolveGsdPathContract(basePath);
+    const roots = [contract.workRoot, contract.projectRoot].map((root) => join(root, ".artifacts", "browser"));
+    return [...new Set(roots)];
+}
+function pathStartsWithin(parent, target) {
+    const normalizedParent = parent.replace(/\\/g, "/").replace(/\/+$/, "");
+    const normalizedTarget = target.replace(/\\/g, "/").replace(/\/+$/, "");
+    return normalizedTarget === normalizedParent || normalizedTarget.startsWith(`${normalizedParent}/`);
+}
+function pushUnique(paths, candidate) {
+    if (!paths.includes(candidate))
+        paths.push(candidate);
+}
+function execMetaPathCandidates(basePath, ref) {
+    const trimmed = ref.trim();
+    const candidates = [];
+    const execDirs = approvedEvidenceRoots(basePath).map((root) => join(root, "exec"));
+    const normalizedRef = trimmed.replace(/\\/g, "/");
+    const pathLike = normalizedRef.endsWith(".meta.json") || normalizedRef.includes("/.gsd/exec/");
+    if (pathLike) {
+        const rawPath = isAbsolute(trimmed) ? resolve(trimmed) : resolve(basePath, trimmed);
+        pushUnique(candidates, rawPath);
+        const relativeExecMarker = ".gsd/exec/";
+        const markerIndex = normalizedRef.indexOf(relativeExecMarker);
+        if (markerIndex >= 0) {
+            const execRelative = normalizedRef.slice(markerIndex + relativeExecMarker.length);
+            for (const execDir of execDirs) {
+                pushUnique(candidates, join(execDir, execRelative));
+            }
+        }
+        return candidates.filter((candidate) => execDirs.some((execDir) => pathStartsWithin(execDir, candidate)));
+    }
+    for (const execDir of execDirs) {
+        pushUnique(candidates, join(execDir, `${trimmed}.meta.json`));
+    }
+    return candidates;
+}
+function resolveExecMetaPath(basePath, ref) {
+    for (const candidate of execMetaPathCandidates(basePath, ref)) {
+        if (existsSync(candidate))
+            return candidate;
+    }
+    return null;
+}
+function evidencePathIsApproved(basePath, ref) {
+    const normalizedRef = ref.replace(/\\/g, "/");
+    if (normalizedRef.startsWith(".gsd/exec/") || normalizedRef.startsWith(".gsd/uat/"))
+        return true;
+    if (normalizedRef.startsWith(".artifacts/browser/")) {
+        const resolvedRef = resolve(basePath, ref);
+        return approvedBrowserArtifactRoots(basePath).some((root) => pathStartsWithin(root, resolvedRef));
+    }
+    const gsdEvidenceApproved = approvedEvidenceRoots(basePath).some((root) => {
+        return pathStartsWithin(join(root, "exec"), ref) || pathStartsWithin(join(root, "uat"), ref);
+    });
+    if (gsdEvidenceApproved)
+        return true;
+    return approvedBrowserArtifactRoots(basePath).some((root) => pathStartsWithin(root, ref));
+}
+function validateEvidenceRef(basePath, evidence) {
+    if (!isNonEmptyString(evidence.ref))
+        return "evidence.ref is required";
+    if (evidence.kind === "gsd_uat_exec" || evidence.kind === "gsd_exec") {
+        const path = resolveExecMetaPath(basePath, evidence.ref.trim());
+        if (!path)
+            return `missing gsd_exec metadata for evidence id "${evidence.ref}"`;
+        if (evidence.kind === "gsd_uat_exec") {
+            try {
+                const meta = JSON.parse(readFileSync(path, "utf-8"));
+                if (meta.metadata?.kind !== "uat_exec")
+                    return `evidence id "${evidence.ref}" is not typed as uat_exec`;
+            }
+            catch {
+                return `invalid gsd_exec metadata JSON for evidence id "${evidence.ref}"`;
+            }
+        }
+        return null;
+    }
+    if (evidence.kind === "url") {
+        try {
+            const parsed = new URL(evidence.ref);
+            return parsed.protocol === "http:" || parsed.protocol === "https:"
+                ? null
+                : `invalid URL evidence ref "${evidence.ref}"`;
+        }
+        catch {
+            return `invalid URL evidence ref "${evidence.ref}"`;
+        }
+    }
+    return evidencePathIsApproved(basePath, evidence.ref)
+        ? null
+        : `evidence ref "${evidence.ref}" is outside approved evidence locations`;
+}
+function validateUatChecks(basePath, params) {
+    for (const check of params.checks) {
+        if (!isNonEmptyString(check.id))
+            return "every check must have a non-empty id";
+        if (!isNonEmptyString(check.description))
+            return `check ${check.id} must have a description`;
+        if (!["artifact", "runtime", "browser", "human-follow-up"].includes(check.mode)) {
+            return `check ${check.id} has invalid mode "${check.mode}"`;
+        }
+        if (!["PASS", "FAIL", "NEEDS-HUMAN"].includes(check.result)) {
+            return `check ${check.id} has invalid result "${check.result}"`;
+        }
+        if (check.result === "PASS" || check.result === "FAIL") {
+            if (!Array.isArray(check.evidence) || check.evidence.length === 0) {
+                return `check ${check.id} is ${check.result} but has no objective evidence`;
+            }
+            for (const evidence of check.evidence) {
+                const error = validateEvidenceRef(basePath, evidence);
+                if (error)
+                    return `check ${check.id}: ${error}`;
+            }
+        }
+        else if (!isNonEmptyString(check.notes)) {
+            return `check ${check.id} is NEEDS-HUMAN but has no manual instruction or reason`;
+        }
+    }
+    return null;
+}
+function validateUatMode(params) {
+    const modes = new Set(params.checks.map((check) => check.mode));
+    const hasHuman = params.checks.some((check) => check.result === "NEEDS-HUMAN");
+    if (params.uatType === "artifact-driven" && hasHuman && params.verdict === "PASS") {
+        return "artifact-driven UAT cannot PASS with human-only checks";
+    }
+    if (hasHuman &&
+        params.verdict === "PASS" &&
+        !["human-experience", "mixed", "live-runtime"].includes(params.uatType) &&
+        !params.checks.every((check) => check.result !== "NEEDS-HUMAN" || check.nonAutomatable === true)) {
+        return "NEEDS-HUMAN checks can only coexist with PASS for human-experience, mixed, live-runtime, or explicitly non-automatable checks";
+    }
+    if (params.uatType === "runtime-executable" && !modes.has("runtime")) {
+        return "runtime-executable UAT requires at least one runtime check";
+    }
+    if (params.uatType === "browser-executable" && !modes.has("browser")) {
+        return "browser-executable UAT requires at least one browser check";
+    }
+    if (params.uatType === "live-runtime" && !modes.has("runtime") && !modes.has("browser")) {
+        return "live-runtime UAT requires runtime or browser evidence";
+    }
+    return null;
+}
+function quoteToolNames(toolNames) {
+    return toolNames.map((toolName) => `"${toolName}"`).join(", ");
+}
+function validateCanonicalPresentation(params) {
+    const aliasHints = {
+        gsd_save_summary: "gsd_summary_save",
+        gsd_complete_task: "gsd_task_complete",
+        gsd_complete_slice: "gsd_slice_complete",
+        gsd_milestone_complete: "gsd_complete_milestone",
+    };
+    const errors = [];
+    for (const toolName of params.presentation.presentedTools) {
+        const baseName = parseMcpToolName(toolName)?.tool ?? toolName;
+        const canonical = aliasHints[baseName];
+        if (canonical)
+            errors.push(`presentation tool "${toolName}" uses an alias; use canonical "${canonical}"`);
+    }
+    const presentedCanonical = new Set(params.presentation.presentedTools.map((toolName) => canonicalWorkflowToolName(parseMcpToolName(toolName)?.tool ?? toolName)));
+    const missingRequiredTools = RUN_UAT_WORKFLOW_TOOL_NAMES.filter((requiredTool) => !presentedCanonical.has(requiredTool));
+    if (missingRequiredTools.length === 1) {
+        errors.push(`presentation is missing required UAT tool "${missingRequiredTools[0]}"`);
+    }
+    else if (missingRequiredTools.length > 1) {
+        errors.push(`presentation is missing required UAT tools ${quoteToolNames(missingRequiredTools)}`);
+    }
+    const forbiddenCanonical = new Set(RUN_UAT_FORBIDDEN_TOOL_NAMES
+        .filter((toolName) => !toolName.includes("*"))
+        .map((toolName) => canonicalWorkflowToolName(parseMcpToolName(toolName)?.tool ?? toolName)));
+    const forbiddenPresentedTools = [];
+    for (const toolName of params.presentation.presentedTools) {
+        const canonical = canonicalWorkflowToolName(parseMcpToolName(toolName)?.tool ?? toolName);
+        if (toolName === "mcp__gsd-workflow__*" || forbiddenCanonical.has(canonical)) {
+            forbiddenPresentedTools.push(toolName);
+        }
+    }
+    if (forbiddenPresentedTools.length === 1) {
+        errors.push(`presentation includes forbidden run-uat tool "${forbiddenPresentedTools[0]}"`);
+    }
+    else if (forbiddenPresentedTools.length > 1) {
+        errors.push(`presentation includes forbidden run-uat tools ${quoteToolNames(forbiddenPresentedTools)}`);
+    }
+    const blockedCanonical = new Set(params.presentation.blockedTools.map((entry) => canonicalWorkflowToolName(parseMcpToolName(entry.name)?.tool ?? entry.name)));
+    const missingBlockedTools = ["gsd_exec", "gsd_summary_save", "gsd_save_gate_result"].filter((blockedTool) => !blockedCanonical.has(blockedTool));
+    if (missingBlockedTools.length === 1) {
+        errors.push(`presentation must record "${missingBlockedTools[0]}" as blocked during run-uat`);
+    }
+    else if (missingBlockedTools.length > 1) {
+        errors.push(`presentation must record ${quoteToolNames(missingBlockedTools)} as blocked during run-uat`);
+    }
+    return errors.length > 0 ? errors.join("; ") : null;
+}
+function nextUatAttempt(basePath, milestoneId, sliceId) {
+    const contract = resolveGsdPathContract(basePath);
+    const dir = join(contract.projectGsd, "uat", milestoneId, sliceId);
+    if (!existsSync(dir))
+        return 1;
+    let max = 0;
+    for (const entry of readdirSync(dir)) {
+        const match = /^attempt-(\d+)\.json$/.exec(entry);
+        if (match)
+            max = Math.max(max, Number(match[1]));
+    }
+    return max + 1;
+}
+function escapeMarkdownTableCell(value) {
+    return String(value ?? "")
+        .replace(/[\\|]/g, (char) => `\\${char}`)
+        .replace(/\r?\n/g, "<br>");
+}
+function renderUatAssessment(params, attempt, gateVerdict) {
+    const lines = [
+        "---",
+        `sliceId: ${params.sliceId}`,
+        `uatType: ${params.uatType}`,
+        `verdict: ${params.verdict}`,
+        `attempt: ${attempt}`,
+        `date: ${new Date().toISOString()}`,
+        "---",
+        "",
+        `# UAT Result - ${params.sliceId}`,
+        "",
+        "## Checks",
+        "",
+        "| Check | Mode | Result | Evidence | Notes |",
+        "|-------|------|--------|----------|-------|",
+        ...params.checks.map((check) => {
+            const evidence = (check.evidence ?? []).map((entry) => `${entry.kind}:${entry.ref}`).join("<br>") || "-";
+            return `| ${escapeMarkdownTableCell(check.description)} | ${escapeMarkdownTableCell(check.mode)} | ${escapeMarkdownTableCell(check.result)} | ${escapeMarkdownTableCell(evidence)} | ${escapeMarkdownTableCell(check.notes)} |`;
+        }),
+        "",
+        "## Overall Verdict",
+        "",
+        `${params.verdict} - ${params.notes ?? "UAT result saved."}`,
+        "",
+        "## Tool Presentation",
+        "",
+        "```json",
+        JSON.stringify(params.presentation, null, 2),
+        "```",
+        "",
+        "## Gate",
+        "",
+        `Aggregate UAT gate saved as ${gateVerdict}.`,
+    ];
+    return `${lines.join("\n")}\n`;
+}
+async function saveUatAttemptArtifact(basePath, params, attempt) {
+    const contract = resolveGsdPathContract(basePath);
+    const relativePath = `uat/${params.milestoneId}/${params.sliceId}/attempt-${attempt}.json`;
+    await saveFile(join(contract.projectGsd, relativePath), `${JSON.stringify({ ...params, attempt }, null, 2)}\n`);
+    return relativePath;
+}
+export async function executeUatResultSave(params, basePath = process.cwd()) {
+    const dbAvailable = await ensureDbOpen(basePath);
+    if (!dbAvailable)
+        return errorResult("save_uat_result", "GSD database is not available.", "db_unavailable");
+    const requiredError = ensureUatRequiredFields(params);
+    if (requiredError)
+        return errorResult("save_uat_result", requiredError, "invalid_params");
+    const presentationError = validateCanonicalPresentation(params);
+    if (presentationError)
+        return errorResult("save_uat_result", presentationError, "alias_tool_name");
+    const checkError = validateUatChecks(basePath, params);
+    if (checkError)
+        return errorResult("save_uat_result", checkError, "invalid_evidence");
+    const modeError = validateUatMode(params);
+    if (modeError)
+        return errorResult("save_uat_result", modeError, "uat_mode_mismatch");
+    try {
+        const attempt = params.attempt === "auto" || params.attempt === undefined
+            ? nextUatAttempt(basePath, params.milestoneId, params.sliceId)
+            : typeof params.attempt === "string"
+                ? Number.parseInt(params.attempt, 10)
+                : params.attempt;
+        if (!Number.isInteger(attempt) || attempt < 1) {
+            return errorResult("save_uat_result", "attempt must be a positive integer or auto", "invalid_attempt");
+        }
+        const gateVerdict = params.verdict === "PASS" ? "pass" : "flag";
+        const rationale = params.notes ?? `UAT ${params.verdict} for ${params.sliceId}.`;
+        const assessment = renderUatAssessment(params, attempt, gateVerdict);
+        const summary = await executeSummarySave({
+            milestone_id: params.milestoneId,
+            slice_id: params.sliceId,
+            artifact_type: "ASSESSMENT",
+            content: assessment,
+        }, basePath);
+        if (summary.isError)
+            return summary;
+        const attemptPath = await saveUatAttemptArtifact(basePath, params, attempt);
+        const evaluatedAt = new Date().toISOString();
+        upsertQualityGate({
+            milestoneId: params.milestoneId,
+            sliceId: params.sliceId,
+            gateId: "UAT",
+            scope: "slice",
+            taskId: "",
+            status: "complete",
+            verdict: gateVerdict,
+            rationale,
+            findings: assessment,
+            evaluatedAt,
+        });
+        insertGateRun({
+            traceId: `uat:${params.milestoneId}:${params.sliceId}`,
+            turnId: `uat:${params.sliceId}:attempt-${attempt}`,
+            gateId: "UAT",
+            gateType: "uat",
+            unitType: "run-uat",
+            unitId: `run-uat:${params.milestoneId}/${params.sliceId}`,
+            milestoneId: params.milestoneId,
+            sliceId: params.sliceId,
+            outcome: params.verdict === "PASS" ? "pass" : "fail",
+            failureClass: params.verdict === "PASS" ? "none" : "verification",
+            rationale,
+            findings: assessment,
+            attempt,
+            maxAttempts: attempt,
+            retryable: params.verdict !== "PASS",
+            evaluatedAt,
+        });
+        invalidateStateCache();
+        return {
+            content: [{ type: "text", text: `UAT result saved for ${params.milestoneId}/${params.sliceId}: ${params.verdict}` }],
+            details: {
+                operation: "save_uat_result",
+                milestoneId: params.milestoneId,
+                sliceId: params.sliceId,
+                verdict: params.verdict,
+                gateVerdict,
+                attempt,
+                attemptPath,
+                recommendedNextUnit: params.verdict === "PASS" ? null : "reactive-execute",
+            },
+        };
+    }
+    catch (err) {
+        const msg = err instanceof Error ? err.message : String(err);
+        logError("tool", `gsd_uat_result_save failed: ${msg}`, { tool: "gsd_uat_result_save", error: String(err) });
+        return errorResult("save_uat_result", `saving UAT result failed: ${msg}`, msg);
+    }
+}
 export async function executePlanMilestone(params, basePath = process.cwd()) {
     const dbAvailable = await ensureDbOpen(basePath);
     if (!dbAvailable) {

package/dist/resources/extensions/gsd/unit-context-manifest.js

@@ -83,6 +83,10 @@ const COMMON_BUDGET_SMALL = 250_000; // ~65K tokens
 const TOOLS_ALL = { mode: "all" };
 const TOOLS_PLANNING = { mode: "planning" };
 const TOOLS_VERIFICATION = { mode: "verification" };
+const TOOLS_VERIFICATION_DISPATCH_UAT = {
+    mode: "verification",
+    allowedSubagents: ["mnemo", "scout", "reviewer", "tester"],
+};
 // Like TOOLS_PLANNING but permits dispatch to read-only recon/planning
 // specialists. Runtime-enforced by write-gate.ts before the subagent tool runs.
 const TOOLS_PLANNING_DISPATCH_RECON = {
@@ -372,7 +376,7 @@ export const UNIT_MANIFESTS = {
         codebaseMap: false,
         preferences: "active-only",
         contextMode: "verification",
-        tools: TOOLS_VERIFICATION,
+        tools: TOOLS_VERIFICATION_DISPATCH_UAT,
         artifacts: {
             inline: ["slice-uat"],
             excerpt: ["slice-summary"],
@@ -551,9 +555,10 @@ export function compileSubagentPermissionContract(policy) {
     if (policy.mode === "all") {
         return { allowed: true, allowedSubagents: ["*"], toolsMode: policy.mode };
     }
-    if (policy.mode === "planning-dispatch") {
+    if ((policy.mode === "planning-dispatch" || policy.mode === "verification") &&
+        Array.isArray(policy.allowedSubagents)) {
         return {
-            allowed: true,
+            allowed: policy.allowedSubagents.length > 0,
             allowedSubagents: [...policy.allowedSubagents],
             toolsMode: policy.mode,
         };

package/dist/resources/extensions/gsd/validation-block-guard.js

@@ -8,6 +8,8 @@ import { deriveState } from "./state.js";
 import { detectWorktreeName } from "./worktree.js";
 const VALIDATION_BLOCK_RE = /milestone validation returned needs-(?:attention|remediation)|validation verdict is needs-(?:attention|remediation)/i;
 const VALIDATION_SAFE_DISPATCH_COMMANDS = new Set([
+    "reassess",
+    "reassess-roadmap",
     "validate",
     "validate-milestone",
 ]);

package/dist/resources/extensions/gsd/verdict-parser.js

@@ -5,7 +5,62 @@
  * (e.g. `passed` → `pass`) are applied consistently across the codebase.
  */
 import { extractUatType } from "./files.js";
+import { splitFrontmatter, parseFrontmatterMap } from "../shared/frontmatter.js";
+import { parse as parseYaml } from "yaml";
+function normalizeVerdict(value) {
+    if (typeof value !== "string")
+        return undefined;
+    let verdict = value.trim().toLowerCase();
+    if (!verdict)
+        return undefined;
+    if (verdict === "passed")
+        verdict = "pass";
+    return verdict;
+}
+function getCaseInsensitive(obj, key) {
+    const lowerKey = key.toLowerCase();
+    for (const [candidate, value] of Object.entries(obj)) {
+        if (candidate.toLowerCase() === lowerKey)
+            return value;
+    }
+    return undefined;
+}
 // ── Verdict extraction ──────────────────────────────────────────────────
+/**
+ * Extract and normalize the frontmatter `verdict` value.
+ *
+ * Supports both top-level `verdict` and the hook outcome shape
+ * `outcome.verdict`. Returns `undefined` when frontmatter is absent or has no
+ * verdict field.
+ */
+export function extractFrontmatterVerdict(content) {
+    const [frontmatterLines] = splitFrontmatter(content);
+    if (!frontmatterLines)
+        return undefined;
+    try {
+        const parsed = parseYaml(frontmatterLines.join("\n"));
+        if (parsed && typeof parsed === "object") {
+            const root = parsed;
+            const topLevel = normalizeVerdict(getCaseInsensitive(root, "verdict"));
+            if (topLevel)
+                return topLevel;
+            const outcome = getCaseInsensitive(root, "outcome");
+            if (outcome && typeof outcome === "object") {
+                const nested = normalizeVerdict(getCaseInsensitive(outcome, "verdict"));
+                if (nested)
+                    return nested;
+            }
+        }
+    }
+    catch {
+        // Fall through to the permissive parser used by legacy frontmatter paths.
+    }
+    const frontmatter = parseFrontmatterMap(frontmatterLines);
+    const topLevel = normalizeVerdict(getCaseInsensitive(frontmatter, "verdict"));
+    if (topLevel)
+        return topLevel;
+    return undefined;
+}
 /**
  * Extract and normalize the `verdict` value from YAML frontmatter.
  *
@@ -17,25 +72,14 @@ import { extractUatType } from "./files.js";
  */
 export function extractVerdict(content) {
     // Primary: YAML frontmatter verdict (canonical format)
-    const fmMatch = content.match(/^---\n([\s\S]*?)\n---/);
-    if (fmMatch) {
-        const verdictMatch = fmMatch[1].match(/verdict:\s*([\w-]+)/i);
-        if (verdictMatch) {
-            let v = verdictMatch[1].toLowerCase();
-            if (v === "passed")
-                v = "pass";
-            return v;
-        }
-        return undefined;
-    }
+    const [frontmatterLines] = splitFrontmatter(content);
+    if (frontmatterLines)
+        return extractFrontmatterVerdict(content);
     // Fallback: detect verdict in markdown body (LLM manual writes, #2960).
     // Matches patterns like: **Verdict:** PASS, **Verdict:** ✅ PASS, **Verdict** needs-remediation
     const bodyMatch = content.match(/\*\*Verdict:?\*\*\s*(?:✅\s*)?(\w[\w-]*)/i);
     if (bodyMatch) {
-        let v = bodyMatch[1].toLowerCase();
-        if (v === "passed")
-            v = "pass";
-        return v;
+        return normalizeVerdict(bodyMatch[1]);
     }
     return undefined;
 }

package/dist/resources/extensions/gsd/verification-gate.js

@@ -246,6 +246,76 @@ function hasUnsafeShellSyntax(cmd) {
     }
     return false;
 }
+function splitLeadingShellWords(cmd) {
+    const words = [];
+    let current = "";
+    let inSingle = false;
+    let inDouble = false;
+    let escaped = false;
+    for (let i = 0; i < cmd.length; i += 1) {
+        const ch = cmd[i];
+        if (escaped) {
+            current += ch;
+            escaped = false;
+            continue;
+        }
+        if (ch === "\\" && !inSingle) {
+            escaped = true;
+            continue;
+        }
+        if (ch === "'" && !inDouble) {
+            inSingle = !inSingle;
+            continue;
+        }
+        if (ch === "\"" && !inSingle) {
+            inDouble = !inDouble;
+            continue;
+        }
+        if (!inSingle && !inDouble) {
+            if (/\s/.test(ch)) {
+                if (current) {
+                    words.push(current);
+                    current = "";
+                }
+                continue;
+            }
+            if ([";", "|", "&", "<", ">"].includes(ch)) {
+                break;
+            }
+        }
+        current += ch;
+    }
+    if (current) {
+        words.push(current);
+    }
+    return words;
+}
+function isCountFlag(token) {
+    return (token === "--count" ||
+        token.startsWith("--count=") ||
+        token === "--count-matches" ||
+        token.startsWith("--count-matches=") ||
+        /^-[A-Za-z]*c[A-Za-z]*$/.test(token));
+}
+function countSearchWarning(command, exitCode) {
+    if (exitCode !== 1)
+        return null;
+    const trimmed = command.trim();
+    if (trimmed.startsWith("!"))
+        return null;
+    const [tool, ...args] = splitLeadingShellWords(trimmed);
+    if (tool !== "grep" && tool !== "rg")
+        return null;
+    if (!args.some(isCountFlag))
+        return null;
+    return `verification-gate: warning: '${tool} -c' returns exit 1 when count=0; for absence checks use '! ${tool} -q ...' instead.`;
+}
+function appendStderrWarning(stderr, warning) {
+    if (!warning)
+        return stderr;
+    const trimmed = stderr.trimEnd();
+    return trimmed ? `${trimmed}\n${warning}` : warning;
+}
 /**
  * Known executable first-tokens that are safe to run.
  * Lowercase commands, common build/test tools, and npm/yarn/pnpm invocations.
@@ -411,11 +481,12 @@ export function runVerificationGate(options) {
             exitCode = result.status ?? 1;
             stderr = truncate(result.stderr, MAX_OUTPUT_BYTES);
         }
+        const warning = countSearchWarning(command, exitCode);
         checks.push({
             command,
             exitCode,
             stdout: truncate(result.stdout, MAX_OUTPUT_BYTES),
-            stderr,
+            stderr: truncate(appendStderrWarning(stderr, warning), MAX_OUTPUT_BYTES),
             durationMs,
         });
     }

package/dist/resources/extensions/gsd/workflow-mcp-auto-prep.js

@@ -33,6 +33,8 @@ export function shouldAutoPrepareWorkflowMcp(ctx) {
     const authMode = getAuthModeSafe(ctx, provider);
     if (provider !== "claude-code")
         return false;
+    if (authMode === undefined)
+        return true;
     return usesWorkflowMcpTransport(authMode, baseUrl) || authMode === "externalCli";
 }
 export function prepareWorkflowMcpForProject(ctx, projectRoot, modelOverride) {
@@ -42,7 +44,7 @@ export function prepareWorkflowMcpForProject(ctx, projectRoot, modelOverride) {
     try {
         const result = ensureProjectWorkflowMcpConfig(projectRoot);
         if (result.status !== "unchanged") {
-            prepCtx.ui?.notify?.(`Claude Code MCP prepared at ${result.configPath}`, "info");
+            prepCtx.ui?.notify?.(`GSD MCP Server Prepared at ${result.configPath}`, "info");
         }
         return result;
     }