@opengsd/gsd-core 1.8.0 → 1.9.0

package/gsd-core/bin/lib/commands.cjs

@@ -24,7 +24,7 @@ const coreUtilsMod = require("./core-utils.cjs");
 const { toPosixPath, generateSlugInternal, extractOneLinerFromBody } = coreUtilsMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const phaseIdMod = require("./phase-id.cjs");
-const { normalizePhaseName, comparePhaseNum, extractPhaseToken } = phaseIdMod;
+const { normalizePhaseName, comparePhaseNum, extractPhaseToken, PHASE_NUMBER_TOKEN_SOURCE } = phaseIdMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const phaseLocatorMod = require("./phase-locator.cjs");
 const { getArchivedPhaseDirs, findPhaseInternal } = phaseLocatorMod;
@@ -39,6 +39,8 @@ const agentCommandRouterMod = require("./agent-command-router.cjs");
 const { AGENT_FAILURE_CLASSES } = agentCommandRouterMod;
 const model_catalog_cjs_1 = require("./model-catalog.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports
+const hostIntegrationMod = require("./host-integration.cjs");
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 const planningWorkspace = require("./planning-workspace.cjs");
 const { planningDir, planningPaths } = planningWorkspace;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
@@ -104,12 +106,13 @@ function determinePhaseStatus(plans, summaries, phaseDir, defaultPending) {
         const files = node_fs_1.default.readdirSync(phaseDir);
         const verificationFile = files.find(f => f === 'VERIFICATION.md' || f.endsWith('-VERIFICATION.md'));
         if (verificationFile) {
-            const content = (0, shell_command_projection_cjs_1.platformReadSync)(node_path_1.default.join(phaseDir, verificationFile)) || '';
+            const verificationFilePath = node_path_1.default.join(phaseDir, verificationFile);
+            const content = (0, shell_command_projection_cjs_1.platformReadSync)(verificationFilePath) || '';
             // #1159 (Defect A): read ONLY the frontmatter `status` key to avoid false
             // matches from historical body metadata such as `previous_status: gaps_found`.
             // Full-text regexes like /status:\s*gaps_found/ match the substring inside
             // `previous_status: gaps_found`, producing incorrect phase status labels.
-            const fm = extractFrontmatter(content);
+            const fm = extractFrontmatter(content, verificationFilePath);
             // Normalise to lower-case to preserve the prior case-insensitive behaviour
             // while reading only the frontmatter `status` key (not the full body text).
             const fmStatus = typeof fm['status'] === 'string' ? fm['status'].trim().toLowerCase() : '';
@@ -261,7 +264,7 @@ function cmdListSeeds(cwd, statusFilter, raw) {
         const content = (0, shell_command_projection_cjs_1.platformReadSync)(safeFilePath);
         if (content === null)
             continue;
-        const fm = extractFrontmatter(content);
+        const fm = extractFrontmatter(content, safeFilePath);
         const status = (fmStr(fm.status) || 'dormant').toLowerCase().trim() || 'dormant';
         // Match on the raw lowercased status (both sides already normalized);
         // sanitizeForDisplay is for output, not comparison.
@@ -347,11 +350,12 @@ function cmdHistoryDigest(cwd, raw) {
         for (const { name: dir, fullPath: dirPath } of allPhaseDirs) {
             const summaries = node_fs_1.default.readdirSync(dirPath).filter(f => f.endsWith('-SUMMARY.md') || f === 'SUMMARY.md');
             for (const summary of summaries) {
-                const content = (0, shell_command_projection_cjs_1.platformReadSync)(node_path_1.default.join(dirPath, summary));
+                const summaryFilePath = node_path_1.default.join(dirPath, summary);
+                const content = (0, shell_command_projection_cjs_1.platformReadSync)(summaryFilePath);
                 if (content === null)
                     continue;
                 try {
-                    const fm = extractFrontmatter(content);
+                    const fm = extractFrontmatter(content, summaryFilePath);
                     const phaseNum = fm['phase'] || dir.split('-')[0];
                     if (!digest.phases[phaseNum]) {
                         digest.phases[phaseNum] = {
@@ -440,7 +444,7 @@ function cmdResolveGranularity(cwd, phaseType, raw, override) {
  *     fast_mode, fast_mode_supported, [unknown_agent] }
  *
  * Flags: --effort <level>, --fast-mode <true|false>, --attempt <n>,
- *        --failure-class <class> (#2296)
+ *        --failure-class <class> (#2296), --host <runtime-id> (#2481)
  */
 function cmdResolveExecution(cwd, agentType, raw, opts) {
     if (!agentType) {
@@ -496,12 +500,54 @@ function cmdResolveExecution(cwd, agentType, raw, opts) {
         fast_mode: fastMode,
         fast_mode_supported: fastModeSupported,
     };
+    // ADR-1239 amendment (#2481) / ADR-443 path (a): invocation-time effort for a
+    // named host. The host's negotiated `effortSurface` decides WHETHER an argument
+    // is emitted; the catalog knows the syntax. Absent --host the contract is
+    // byte-identical to before, so every existing caller is unaffected.
+    if (typeof opts.host === 'string' && opts.host.length > 0) {
+        const surface = effortSurfaceForHost(cwd, opts.host);
+        const argvRendered = (0, model_catalog_cjs_1.renderEffortArgv)(opts.host, effort, surface);
+        result['host'] = opts.host;
+        result['effort_surface'] = surface;
+        result['effort_argv'] = argvRendered.argv;
+        result['effort_argv_string'] = argvRendered.argv.join(' ');
+        result['effort_argv_value'] = argvRendered.value;
+    }
     if (!agentModels)
         result['unknown_agent'] = true;
     if (escalation)
         result['escalation'] = escalation;
     output(result, raw, effort);
 }
+/**
+ * ADR-1239 amendment (#2481) — resolve a host's negotiated `effortSurface`.
+ *
+ * Reads the host's runtime descriptor from the generated capability registry and
+ * runs it through the Host-Integration negotiation so the trust-boundary invariant
+ * applies here exactly as everywhere else: an unknown host, a missing axis, or the
+ * `undocumented` sentinel all degrade to the safe floor rather than being trusted.
+ * Never throws — a lookup failure yields `'none'`, which renders no argument.
+ */
+function effortSurfaceForHost(cwd, host) {
+    void cwd;
+    try {
+        // Mirrors the lazy-require pattern from runtime-slash.cts §runtimeSlash —
+        // capability-registry.cjs is generated and carries no type declarations.
+        // eslint-disable-next-line @typescript-eslint/no-require-imports
+        const { runtimes } = require('./capability-registry.cjs');
+        const declared = runtimes[host]?.runtime?.hostIntegration;
+        if (!declared || typeof declared !== 'object')
+            return 'none';
+        // The descriptor is untrusted JSON; negotiation applies the trust-boundary
+        // invariant (effective ⊆ host-declared ∩ engine-known) and fails closed.
+        const negotiated = hostIntegrationMod.negotiateHostCapabilities(declared);
+        const surface = negotiated?.effective?.effortSurface;
+        return typeof surface === 'string' ? surface : 'none';
+    }
+    catch {
+        return 'none';
+    }
+}
 /**
  * #488 — Replace or inject the `effort:` value in YAML frontmatter.
  * Unlike injectEffortFrontmatter (install.js), this overwrites an existing value.
@@ -594,6 +640,59 @@ function cmdEffortSync(cwd, raw, opts) {
     }
     output({ synced, skipped, changes, dry_run: dryRun, agents_dir: agentsDir }, raw, synced > 0 ? 'changed' : 'ok');
 }
+/**
+ * Detect the phase number for a commit from its `--files` path list.
+ *
+ * #2539: the extraction is anchored to the directory segment immediately under
+ * `.planning/phases/` or `.planning/milestones/<version>-phases/`, then run
+ * through the project-code-aware `extractPhaseToken` helper. The prior
+ * unanchored `match(/(\d+(?:\.\d+)*)-/)` returned the leftmost digit-run-then-
+ * hyphen anywhere in the joined path, so a project_code ending in a digit
+ * (e.g. PROJECT_V2) made `…/PROJECT_V2-07-name/…` match the `2-` inside `V2-`
+ * before the real `07-` phase token — resolving phase "2" instead of "7".
+ *
+ * Returns the phase number string (e.g. '07', '45.14'), or null when no phase
+ * directory segment is present in any of the file paths (e.g. a commit of
+ * `.planning/ROADMAP.md` has no phase segment, so no branch is resolved —
+ * matching the prior regex-no-match behaviour).
+ */
+function detectPhaseNumberFromFiles(files) {
+    if (!files || files.length === 0)
+        return null;
+    // A phase directory lives one segment below a `phases` parent segment:
+    //   .planning/phases/<phase-dir>/…
+    //   .planning/milestones/v1.0-phases/<phase-dir>/…
+    // The segment immediately after the `…phases` segment is the phase directory
+    // name. extractPhaseToken owns the project-code-aware token read.
+    for (const file of files) {
+        const norm = String(file).replace(/\\/g, '/').replace(/^\.\//, '');
+        const segments = norm.split('/');
+        for (let i = 0; i < segments.length - 1; i++) {
+            if (segments[i] === 'phases' || segments[i].endsWith('-phases')) {
+                const phaseDir = segments[i + 1];
+                if (!phaseDir)
+                    continue;
+                const token = extractPhaseToken(phaseDir);
+                // extractPhaseToken falls back to returning dirName unchanged when no
+                // numeric token is found. normalizePhaseName is the canonical arbiter
+                // of "is this a real phase token": it strips the project-code prefix
+                // and returns a zero-padded numeric form for a genuine phase token, or
+                // the input unchanged otherwise. Accept the token only when it
+                // normalizes to a numeric phase form (the single-owner rule shared by
+                // every other phase-token reader — see #2528).
+                const normalized = normalizePhaseName(token);
+                // Built from the single-owner PHASE_NUMBER_TOKEN_SOURCE (the canonical
+                // phase-number grammar — #2128 anti-divergence guard) so this read-side
+                // acceptance check cannot drift from every other phase-token reader.
+                const phaseTokenShape = new RegExp(`^${PHASE_NUMBER_TOKEN_SOURCE}$`, 'i');
+                if (token !== phaseDir && phaseTokenShape.test(normalized)) {
+                    return token;
+                }
+            }
+        }
+    }
+    return null;
+}
 function cmdCommit(cwd, message, files, raw, amend, noVerify) {
     if (!message && !amend) {
         error('commit message required');
@@ -629,10 +728,21 @@ function cmdCommit(cwd, message, files, raw, amend, noVerify) {
     if (branchingStrategy && branchingStrategy !== 'none') {
         let branchName = null;
         if (branchingStrategy === 'phase') {
-            // Determine which phase we're committing for from the file paths
-            const phaseMatch = (files || []).join(' ').match(/(\d+(?:\.\d+)*)-/);
-            if (phaseMatch) {
-                const phaseNum = phaseMatch[1];
+            // Determine which phase we're committing for from the file paths.
+            // #2539: the extraction is anchored to the directory SEGMENT immediately
+            // under `.planning/phases/` (or `.planning/milestones/<v>-phases/`) and
+            // runs through the project-code-aware extractPhaseToken helper, NOT a
+            // free unanchored regex. The prior `match(/(\d+(?:\.\d+)*)-/)` returned
+            // the leftmost digit-run-then-hyphen anywhere in the joined path, so a
+            // project_code ending in a digit (PROJECT_V2) made `.../PROJECT_V2-07-…`
+            // match the `2-` inside `V2-` before the real `07-` phase token —
+            // resolving phase "2" instead of phase "7" and silently checking out the
+            // wrong branch. extractPhaseToken already owns project-code-aware phase-
+            // token parsing (it is the single owner shared by the other 6 call sites
+            // — see #2528 for the parallel drift problem in phase-locator/phase),
+            // so this is the canonical path-segment-bound read, not a fourth copy.
+            const phaseNum = detectPhaseNumberFromFiles(files);
+            if (phaseNum) {
                 const phaseInfo = findPhaseInternal(cwd, phaseNum);
                 if (phaseInfo) {
                     branchName = config['phase_branch_template']
@@ -652,10 +762,23 @@ function cmdCommit(cwd, message, files, raw, amend, noVerify) {
         if (branchName) {
             const currentBranch = (0, shell_command_projection_cjs_1.execGit)(['rev-parse', '--abbrev-ref', 'HEAD'], { cwd });
             if (currentBranch.exitCode === 0 && currentBranch.stdout.trim() !== branchName) {
-                // Create branch if it doesn't exist, or switch to it if it does
+                // #2539: the #1278 intent is to CREATE the phase/milestone branch
+                // before the FIRST commit on it — not to force-switch an already-
+                // checked-out working branch onto a DIFFERENT existing branch. The
+                // prior fallback to a bare `git checkout <branch>` silently switched
+                // the whole working tree onto an existing unrelated branch in the same
+                // call that then committed (the only trace was a reflog entry). So:
+                // create-if-absent only. If the resolved branch already exists and the
+                // tree is on some other branch, do NOT switch — but never silently: log
+                // the resolution so the operator sees that the phase branch was
+                // resolved and deliberately not switched to (#2539 AC2: an auto-
+                // checkout mid-commit must never happen silently).
                 const create = (0, shell_command_projection_cjs_1.execGit)(['checkout', '-b', branchName], { cwd });
                 if (create.exitCode !== 0) {
-                    (0, shell_command_projection_cjs_1.execGit)(['checkout', branchName], { cwd });
+                    // `git checkout -b` fails (non-zero) when the branch already exists.
+                    // The operator is on the branch they intend to be on; commit there.
+                    process.stderr.write(`Warning: resolved ${branchingStrategy} branch "${branchName}" already exists; ` +
+                        `committing on the current branch "${currentBranch.stdout.trim()}" instead of switching.\n`);
                 }
             }
         }
@@ -664,8 +787,21 @@ function cmdCommit(cwd, message, files, raw, amend, noVerify) {
     const explicitFiles = files && files.length > 0;
     const filesToStage = explicitFiles ? files : ['.planning/'];
     const stagedPaths = [];
+    // #2608: a `git add` that fails must abort the commit, not be skipped.
+    // #2523 stopped a failed path entering the commit pathspec, but skipping it
+    // silently left two bad outcomes: a PARTIAL commit when only some requested
+    // paths failed, and a misleading `nothing_to_commit` when all of them did —
+    // in both cases the original staging error (permissions, unwritable index in
+    // a linked worktree, timeout) was discarded and the operator saw a downstream
+    // pathspec error pointing at an innocent file.
+    const stagingFailures = [];
+    // Paths already in the index BEFORE this call. On a staging failure the
+    // rollback below unstages only what THIS call added — unstaging a path the
+    // caller had staged themselves would destroy their work.
+    const preStaged = new Set((0, shell_command_projection_cjs_1.execGit)(['diff', '--cached', '--name-only'], { cwd })
+        .stdout.split('\n').map(s => s.trim()).filter(Boolean));
     for (const file of filesToStage) {
-        const fullPath = node_path_1.default.join(cwd, file);
+        const fullPath = node_path_1.default.resolve(cwd, file);
         if (!node_fs_1.default.existsSync(fullPath)) {
             if (explicitFiles) {
                 // Caller passed an explicit --files list: missing files are skipped.
@@ -675,13 +811,74 @@ function cmdCommit(cwd, message, files, raw, amend, noVerify) {
             }
             // Default mode (staging all of .planning/): stage the deletion so
             // removed planning files are not left dangling in the index.
-            (0, shell_command_projection_cjs_1.execGit)(['rm', '--cached', '--ignore-unmatch', file], { cwd });
+            // This mutates the index exactly like `git add` does, so it fails closed
+            // the same way — an unwritable index must not be swallowed here either.
+            // `--ignore-unmatch` already makes "no such path" a success, so a non-zero
+            // exit is a real I/O failure, not a missing file.
+            const rmResult = (0, shell_command_projection_cjs_1.execGit)(['rm', '--cached', '--ignore-unmatch', file], { cwd });
+            if (rmResult.exitCode !== 0) {
+                const rmErr = rmResult.error;
+                stagingFailures.push({
+                    file,
+                    error: rmResult.stderr || rmResult.stdout,
+                    timed_out: rmResult.signal === 'SIGTERM' && rmErr?.code === 'ETIMEDOUT',
+                });
+            }
         }
         else {
-            (0, shell_command_projection_cjs_1.execGit)(['add', file], { cwd });
-            stagedPaths.push(file);
+            const addResult = (0, shell_command_projection_cjs_1.execGit)(['add', file], { cwd });
+            // Only record paths that actually staged — a failed `git add` (permissions,
+            // out-of-repo edge) must not enter the commit pathspec (#2523). Mirrors
+            // cmdCommitToSubrepo's exitCode-gated push.
+            if (addResult.exitCode === 0) {
+                stagedPaths.push(file);
+            }
+            else {
+                // `SpawnResultOutput.error` is typed `Error | null`; widen to the errno
+                // shape by ANNOTATION rather than assertion — `Error` is assignable to
+                // `NodeJS.ErrnoException` (its extra fields are optional), so an `as`
+                // cast here trips no-unnecessary-type-assertion.
+                const addErr = addResult.error;
+                stagingFailures.push({
+                    file,
+                    error: addResult.stderr || addResult.stdout,
+                    // The projection exposes a timeout distinctly (#2608 AC5); this is the
+                    // same SIGTERM+ETIMEDOUT idiom worktree-safety.cts uses.
+                    timed_out: addResult.signal === 'SIGTERM' && addErr?.code === 'ETIMEDOUT',
+                });
+            }
         }
     }
+    // #2608: fail closed before `git commit` runs. Checked ahead of the
+    // nothing_to_commit branch below so a run where EVERY path failed to stage
+    // reports the staging cause rather than "nothing to commit", and ahead of the
+    // commit itself so a multi-file scope never partially commits the subset that
+    // happened to stage.
+    if (stagingFailures.length > 0) {
+        // Fail closed AND clean. Without this the paths that DID stage stay in the
+        // index with no commit made, so the next bare `git commit` sweeps them up —
+        // the same silent partial commit this fix exists to prevent, deferred one
+        // step. Mirrors cmdPrSubrepo's rollback-then-error convention. Only paths
+        // this call staged are unstaged (preStaged is excluded), and the reset is
+        // best-effort: if the index is unwritable — the very failure being reported
+        // — the reset cannot succeed either, and the staging error is still what
+        // gets returned.
+        const toUnstage = stagedPaths.filter(p => !preStaged.has(p));
+        if (toUnstage.length > 0) {
+            (0, shell_command_projection_cjs_1.execGit)(['reset', '-q', '--', ...toUnstage], { cwd });
+        }
+        const first = stagingFailures[0];
+        const result = {
+            committed: false,
+            hash: null,
+            reason: first.timed_out ? 'staging_timeout' : 'staging_failed',
+            file: first.file,
+            error: first.error,
+            failures: stagingFailures,
+        };
+        output(result, raw, 'failed');
+        return;
+    }
     // Commit — when the caller declared a scope (--files), append a pathspec so
     // only the declared files land in the commit, not the entire index (#2112).
     // The pathspec uses stagedPaths (not filesToStage) so skipped missing files
@@ -802,13 +999,44 @@ function cmdCommitToSubrepo(cwd, message, files, raw) {
     for (const [repo, repoFiles] of Object.entries(grouped)) {
         const repoCwd = node_path_1.default.join(cwd, repo);
         // Stage files (strip sub-repo prefix for paths relative to that repo)
+        // #2608: this is the sub-repo twin of cmdCommit's staging loop and carried
+        // the identical defect — a failed `git add` was dropped silently and the
+        // function went straight on to commit the subset that happened to stage,
+        // discarding git's stderr. Fails closed per-repo, with the same rollback of
+        // only what this call staged.
+        const preStagedSub = new Set((0, shell_command_projection_cjs_1.execGit)(['diff', '--cached', '--name-only'], { cwd: repoCwd })
+            .stdout.split('\n').map(s => s.trim()).filter(Boolean));
         const stagedRelPaths = [];
+        const subStagingFailures = [];
         for (const file of repoFiles) {
             const relativePath = file.slice(repo.length + 1);
             const addResult = (0, shell_command_projection_cjs_1.execGit)(['add', relativePath], { cwd: repoCwd });
             if (addResult.exitCode === 0) {
                 stagedRelPaths.push(relativePath);
             }
+            else {
+                const addErr = addResult.error;
+                subStagingFailures.push({
+                    file,
+                    error: addResult.stderr || addResult.stdout,
+                    timed_out: addResult.signal === 'SIGTERM' && addErr?.code === 'ETIMEDOUT',
+                });
+            }
+        }
+        if (subStagingFailures.length > 0) {
+            const toUnstageSub = stagedRelPaths.filter(p => !preStagedSub.has(p));
+            if (toUnstageSub.length > 0) {
+                (0, shell_command_projection_cjs_1.execGit)(['reset', '-q', '--', ...toUnstageSub], { cwd: repoCwd });
+            }
+            const firstSub = subStagingFailures[0];
+            repos[repo] = {
+                committed: false,
+                hash: null,
+                files: repoFiles,
+                reason: firstSub.timed_out ? 'staging_timeout' : 'staging_failed',
+                error: firstSub.error,
+            };
+            continue;
         }
         // Commit — pathspec limits the commit to the staged files only (#2112)
         const isMergeInProgressSub = (0, shell_command_projection_cjs_1.execGit)(['rev-parse', '-q', '--verify', 'MERGE_HEAD'], { cwd: repoCwd }).exitCode === 0;
@@ -994,7 +1222,7 @@ function cmdSummaryExtract(cwd, summaryPath, fields, raw) {
         return;
     }
     const content = node_fs_1.default.readFileSync(fullPath, 'utf-8');
-    const fm = extractFrontmatter(content);
+    const fm = extractFrontmatter(content, fullPath);
     // Parse key-decisions into structured format
     const parseDecisions = (decisionsList) => {
         if (!decisionsList || !Array.isArray(decisionsList))