@opengsd/gsd-core 1.5.0-rc.2 → 1.5.0-rc.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opengsd/gsd-core",
-  "version": "1.5.0-rc.2",
+  "version": "1.5.0-rc.4",
   "description": "GSD Core is a meta-prompting, context engineering, and spec-driven development system for AI coding agents.",
   "bin": {
     "gsd-core": "bin/install.js",
@@ -92,7 +92,8 @@
     "pretest:coverage": "npm run build:lib && npm run lint:skill-deps",
     "lint": "eslint . --cache --cache-location node_modules/.cache/eslint/",
     "lint:fix": "eslint . --fix",
-    "lint:ci": "npm run lint && npm run lint:skill-deps && node scripts/lint-test-file-count.cjs && node scripts/lint-command-contract.cjs && node scripts/lint-pr-check-project-dir.cjs && npm run lint:legacy-name && node scripts/lint-regression-test-names.cjs && node scripts/lint-windows-test-portability.cjs",
+    "lint:ci": "npm run lint && npm run lint:skill-deps && node scripts/lint-test-file-count.cjs && node scripts/lint-command-contract.cjs && node scripts/lint-pr-check-project-dir.cjs && npm run lint:legacy-name && node scripts/lint-regression-test-names.cjs && node scripts/lint-windows-test-portability.cjs && node scripts/lint-allow-test-rule-refs.cjs",
+    "lint:allow-test-rule-refs": "node scripts/lint-allow-test-rule-refs.cjs",
     "lint:windows-test-portability": "node scripts/lint-windows-test-portability.cjs",
     "lint:regression-names": "node scripts/lint-regression-test-names.cjs",
     "lint:descriptions": "node scripts/lint-descriptions.cjs",
@@ -113,9 +114,9 @@
     "test:security": "node scripts/run-tests.cjs --suite security",
     "test:slow": "node scripts/run-tests.cjs --suite slow",
     "test:affected": "node scripts/run-affected-tests.cjs",
-    "test:coverage": "c8 --check-coverage --lines 70 --reporter text --include 'gsd-core/bin/lib/*.cjs' --exclude 'tests/**' --all node scripts/run-tests.cjs",
+    "test:coverage": "c8 --check-coverage --lines 70 --branches 60 --reporter text --include 'gsd-core/bin/lib/*.cjs' --exclude 'tests/**' --all node scripts/run-tests.cjs",
     "test:coverage:scripts-floor": "c8 check-coverage --lines 55 --include 'scripts/**/*.cjs' --exclude 'tests/**' --all",
-    "test:coverage:unit": "c8 --check-coverage --lines 70 --reporter text --include 'gsd-core/bin/lib/*.cjs' --exclude 'tests/**' --all node scripts/run-tests.cjs --suite unit",
+    "test:coverage:unit": "c8 --check-coverage --lines 70 --branches 60 --reporter text --include 'gsd-core/bin/lib/*.cjs' --exclude 'tests/**' --all node scripts/run-tests.cjs --suite unit && c8 check-coverage --per-file --lines 0 --functions 0 --statements 0 --branches 70 --include 'gsd-core/bin/lib/state.cjs' --include 'gsd-core/bin/lib/phase.cjs' --include 'gsd-core/bin/lib/verify.cjs' --include 'gsd-core/bin/lib/init.cjs' --exclude 'tests/**'",
     "test:coverage:all": "npm run test:coverage",
     "test:mutation": "stryker run",
     "test:mutation:since": "stryker run --incremental --since origin/next"

package/scripts/affected-tests-lib.cjs

@@ -259,10 +259,21 @@ function shouldRunFullSuite(changedFiles) {
 }
 
 function listTestFiles(repoRoot) {
-  return readdirSync(path.join(repoRoot, 'tests'))
-    .filter(file => file.endsWith('.test.cjs'))
-    .map(file => `tests/${file}`)
-    .sort();
+  const results = [];
+  function walk(dir, relBase) {
+    for (const entry of readdirSync(dir, { withFileTypes: true })) {
+      if (entry.isDirectory()) {
+        if (entry.name === 'node_modules') continue;
+        const nextRel = relBase ? `${relBase}/${entry.name}` : entry.name;
+        walk(path.join(dir, entry.name), nextRel);
+      } else if (entry.name.endsWith('.test.cjs')) {
+        const rel = relBase ? `${relBase}/${entry.name}` : entry.name;
+        results.push(`tests/${rel}`);
+      }
+    }
+  }
+  walk(path.join(repoRoot, 'tests'), '');
+  return results.sort();
 }
 
 /**
@@ -531,6 +542,7 @@ module.exports = {
   buildForwardGraph,
   buildReverseIndex,
   buildTransitiveReverseIndex,
+  listTestFiles,
   parseRelativeSpecifiers,
   pickAffectedTests,
   resolveBaseRef,

package/scripts/build-hooks.js

@@ -26,6 +26,13 @@ const STAGE_DIR = path.join(HOOKS_DIR, `.dist-staging-${process.pid}`);
 const HOOKS_TO_COPY = [
   'gsd-check-update-worker.js',
   'gsd-check-update.js',
+  // SessionStart canonical-path bootstrap (#997). In a Claude Code marketplace
+  // plugin install, ~/.claude/gsd-core is never created, so every
+  // `@~/.claude/gsd-core/...` include in agents/commands/templates resolves to
+  // nothing. This hook symlinks the canonical path's immutable subdirs to the
+  // plugin's bundled gsd-core/ tree; no-op in classic installs. Must ship to
+  // dist so the installer copies it into the target hooks/ dir.
+  'gsd-ensure-canonical-path.js',
   // Required by gsd-check-update-worker.js at runtime — must ship alongside it
   // so require('./managed-hooks-registry.cjs') resolves in the installed hooks/ dir.
   'managed-hooks-registry.cjs',

package/scripts/changeset/new.cjs

@@ -106,8 +106,14 @@ function parseArgs(argv) {
       const r = requireValue(a, i);
       if (!r.ok) return { ok: false, error: r.error };
       if (a === '--type') opts.type = r.value;
-      else if (a === '--pr') opts.pr = Number(r.value);
-      else if (a === '--body') opts.body = r.value;
+      else if (a === '--pr') {
+        // Accept only decimal-integer strings (digits only, no sign, no dot,
+        // no hex prefix, no scientific notation). Non-integer input — including
+        // empty string and whitespace — is normalized to NaN so the prNaN
+        // guard below rejects it with the usage error.
+        const trimmed = r.value.trim();
+        opts.pr = /^\d+$/.test(trimmed) ? Number(trimmed) : NaN;
+      } else if (a === '--body') opts.body = r.value;
       else if (a === '--repo') opts.repo = r.value;
       i++;
       continue;
@@ -125,7 +131,15 @@ function main() {
     throw new ExitError(2);
   }
   const { opts } = parsed;
-  if (!opts.type || !opts.pr || !opts.body) {
+  // opts.pr starts as null (missing flag) and is set by parseArgs to a Number when
+  // the raw value is a pure decimal-integer string (digits only), or to NaN for any
+  // other input (empty, whitespace, floats, hex, negatives, scientific notation, etc.).
+  // Accept integer 0 (the documented pr:0 placeholder); reject a missing flag (null)
+  // and any non-decimal-integer value (NaN). The merge/lint gate separately
+  // enforces pr > 0 before a fragment can land, so 0 still cannot be merged.
+  const prMissing = opts.pr === null;
+  const prNaN = typeof opts.pr === 'number' && Number.isNaN(opts.pr);
+  if (!opts.type || prMissing || prNaN || !opts.body) {
     throw new ExitError(2, 'usage: changeset/new.cjs --type <Fixed|Added|...> --pr NNNN --body "..."');
   }
   const file = scaffoldFragment(opts);

package/scripts/fix-slash-commands.cjs

@@ -92,9 +92,21 @@ function transformContentToHyphen(src, cmdNames) {
 }
 
 function readCmdNames() {
-  return fs.readdirSync(COMMANDS_DIR)
-    .filter(f => f.endsWith('.md'))
-    .map(f => f.replace(/\.md$/, ''));
+  try {
+    return fs.readdirSync(COMMANDS_DIR)
+      .filter(f => f.endsWith('.md'))
+      .map(f => f.replace(/\.md$/, ''));
+  } catch (err) {
+    // Only swallow the missing-directory case. Any other error (EACCES, ENOTDIR,
+    // etc.) indicates a real misconfiguration and must propagate so callers are
+    // not silently handed an empty registry while the real problem goes undetected.
+    if (err.code !== 'ENOENT') throw err;
+    // COMMANDS_DIR may not exist on installs that use skill-based runtimes or
+    // global Claude installs (no local commands/gsd/ directory). Return [] so
+    // callers that handle an empty array gracefully (buildPattern returns null,
+    // transformContent is a no-op) are not broken by a missing directory.
+    return [];
+  }
 }
 
 function processFile(file, cmdNames) {