@opengsd/gsd-core 1.5.0-rc.2 → 1.5.0-rc.4

package/gsd-core/bin/lib/verify.cjs

@@ -24,6 +24,8 @@ const frontmatterMod = require("./frontmatter.cjs");
 const stateMod = require("./state.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- model-profiles.cjs is an export= CommonJS module
 const modelProfilesMod = require("./model-profiles.cjs");
+// eslint-disable-next-line @typescript-eslint/no-require-imports -- plan-scan.cjs is an export= CommonJS module
+const planScanMod = require("./plan-scan.cjs");
 const shell_command_projection_cjs_1 = require("./shell-command-projection.cjs");
 const package_identity_cjs_1 = require("./package-identity.cjs");
 const runtime_slash_cjs_1 = require("./runtime-slash.cjs");
@@ -450,6 +452,39 @@ function cmdVerifyArtifacts(cwd, planFilePath, raw) {
         artifacts: results,
     }, raw, passed === results.length ? 'valid' : 'invalid');
 }
+/**
+ * Returns a Set of file paths (relative to cwd) that are promised by plans in
+ * the same phase directory at a wave number >= minWave.
+ *
+ * Used by cmdVerifyKeyLinks to avoid hard-failing a missing `from:` file that
+ * is a planned future artifact (fix #1202).
+ */
+function collectPromisedFilesAtOrAfterWave(phaseDir, minWave) {
+    const promised = new Set();
+    const { planFiles } = planScanMod.scanPhasePlans(phaseDir);
+    for (const planFile of planFiles) {
+        const planFullPath = node_path_1.default.join(phaseDir, planFile);
+        const planContent = (0, shell_command_projection_cjs_1.platformReadSync)(planFullPath);
+        if (!planContent)
+            continue;
+        const fm = extractFrontmatter(planContent);
+        const waveRaw = fm['wave'];
+        const wave = typeof waveRaw === 'string' ? parseInt(waveRaw, 10) : (typeof waveRaw === 'number' ? waveRaw : NaN);
+        if (isNaN(wave) || wave < minWave)
+            continue;
+        const filesModified = fm['files_modified'];
+        if (!filesModified)
+            continue;
+        const files = Array.isArray(filesModified)
+            ? filesModified
+            : (typeof filesModified === 'string' ? [filesModified] : []);
+        for (const f of files) {
+            if (typeof f === 'string' && f.trim())
+                promised.add(f.trim());
+        }
+    }
+    return promised;
+}
 function cmdVerifyKeyLinks(cwd, planFilePath, raw) {
     if (!planFilePath) {
         error('plan file path required');
@@ -465,7 +500,25 @@ function cmdVerifyKeyLinks(cwd, planFilePath, raw) {
         output({ error: 'No must_haves.key_links found in frontmatter', path: planFilePath }, raw);
         return;
     }
+    // Derive the current plan's wave number and phase directory for wave-aware
+    // missing-file handling (fix #1202).
+    const currentFm = extractFrontmatter(content);
+    const currentWaveRaw = currentFm['wave'];
+    const currentWave = typeof currentWaveRaw === 'string'
+        ? parseInt(currentWaveRaw, 10)
+        : (typeof currentWaveRaw === 'number' ? currentWaveRaw : 1);
+    const phaseDir = node_path_1.default.dirname(fullPath);
+    // Collect files promised by plans at wave >= currentWave (lazy: computed once
+    // the first time a missing source is encountered).
+    let promisedFiles = null;
+    function getPromisedFiles() {
+        if (promisedFiles === null) {
+            promisedFiles = collectPromisedFilesAtOrAfterWave(phaseDir, isNaN(currentWave) ? 1 : currentWave);
+        }
+        return promisedFiles;
+    }
     const results = [];
+    let pendingCount = 0;
     for (const link of keyLinks) {
         if (typeof link === 'string')
             continue;
@@ -476,9 +529,20 @@ function cmdVerifyKeyLinks(cwd, planFilePath, raw) {
             verified: false,
             detail: '',
         };
-        const sourceContent = (0, shell_command_projection_cjs_1.platformReadSync)(node_path_1.default.join(cwd, link['from'] || ''));
+        const fromPath = link['from'] || '';
+        const sourceContent = (0, shell_command_projection_cjs_1.platformReadSync)(node_path_1.default.join(cwd, fromPath));
         if (!sourceContent) {
-            check['detail'] = 'Source file not found (from: must be a relative file path; describe components/endpoints in via:)';
+            // Check if the missing file is promised by a plan at the same or later wave.
+            const promised = getPromisedFiles();
+            const isPromised = fromPath.trim() !== '' && promised.has(fromPath.trim());
+            if (isPromised) {
+                check['pending'] = true;
+                check['detail'] = 'Source file not yet created — declared in files_modified of a same-or-later-wave plan';
+                pendingCount++;
+            }
+            else {
+                check['detail'] = 'Source file not found (from: must be a relative file path; describe components/endpoints in via:)';
+            }
         }
         else if (link['pattern']) {
             try {
@@ -514,12 +578,17 @@ function cmdVerifyKeyLinks(cwd, planFilePath, raw) {
         results.push(check);
     }
     const verified = results.filter((r) => r['verified']).length;
+    // A pending link (from: file promised by a same-or-later-wave plan) is not a
+    // hard failure — it should not count against the all_verified gate (#1202).
+    const hardFailed = results.filter((r) => !r['verified'] && !r['pending']).length;
+    const allVerified = hardFailed === 0;
     output({
-        all_verified: verified === results.length,
+        all_verified: allVerified,
         verified,
+        pending: pendingCount,
         total: results.length,
         links: results,
-    }, raw, verified === results.length ? 'valid' : 'invalid');
+    }, raw, allVerified ? 'valid' : 'invalid');
 }
 function listMilestoneArchiveDirs(planBase) {
     const milestonesDir = node_path_1.default.join(planBase, 'milestones');
@@ -1352,7 +1421,7 @@ function cmdVerifySchemaDrift(cwd, phaseArg, skipFlag, raw) {
     const pDir = planningDir(cwd);
     const phasesDir = node_path_1.default.join(pDir, 'phases');
     if (!node_fs_1.default.existsSync(phasesDir)) {
-        output({ drift_detected: false, blocking: false, message: 'No phases directory' }, raw);
+        output({ block: false, drift_detected: false, blocking: false, message: 'No phases directory' }, raw);
         return;
     }
     let phaseDir = null;
@@ -1369,7 +1438,7 @@ function cmdVerifySchemaDrift(cwd, phaseArg, skipFlag, raw) {
             phaseDir = exact;
     }
     if (!phaseDir) {
-        output({ drift_detected: false, blocking: false, message: `Phase directory not found: ${phaseArg}` }, raw);
+        output({ block: false, drift_detected: false, blocking: false, message: `Phase directory not found: ${phaseArg}` }, raw);
         return;
     }
     const allFiles = [];
@@ -1392,14 +1461,20 @@ function cmdVerifySchemaDrift(cwd, phaseArg, skipFlag, raw) {
         executionLog += '\n' + gitLog.stdout;
     }
     const result = (0, schema_detect_cjs_1.checkSchemaDrift)(allFiles, executionLog, { skipCheck: !!skipFlag });
+    const isSkipped = !!result['skipped'];
     output({
+        // Uniform gate contract: `block` = true means "this gate's bad condition is met".
+        // When skipCheck is true (GSD_SKIP_SCHEMA_CHECK=true), the gate is bypassed —
+        // block must be false regardless of whether drift was detected.
+        // drift_detected and blocking are kept for compatibility.
+        block: isSkipped ? false : !!result['driftDetected'],
         drift_detected: result['driftDetected'],
         blocking: result['blocking'],
         schema_files: result['schemaFiles'],
         orms: result['orms'],
         unpushed_orms: result['unpushedOrms'],
         message: result['message'],
-        skipped: result['skipped'] || false,
+        skipped: isSkipped,
     }, raw);
 }
 function cmdVerifyCodebaseDrift(cwd, raw) {
@@ -1412,6 +1487,8 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
         const structurePath = node_path_1.default.join(codebaseDir, 'STRUCTURE.md');
         if (!node_fs_1.default.existsSync(structurePath)) {
             emit({
+                // Uniform gate contract: block = action_required (false when skipped).
+                block: false,
                 skipped: true,
                 reason: 'no-structure-md',
                 action_required: false,
@@ -1426,6 +1503,7 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
         }
         catch (err) {
             emit({
+                block: false,
                 skipped: true,
                 reason: 'cannot-read-structure-md: ' + (err instanceof Error ? err.message : String(err)),
                 action_required: false,
@@ -1438,6 +1516,7 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
         const revProbe = (0, shell_command_projection_cjs_1.execGit)(['rev-parse', 'HEAD'], { cwd });
         if (revProbe.exitCode !== 0) {
             emit({
+                block: false,
                 skipped: true,
                 reason: 'not-a-git-repo',
                 action_required: false,
@@ -1459,6 +1538,7 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
         const diff = (0, shell_command_projection_cjs_1.execGit)(['diff', '--name-status', base, 'HEAD'], { cwd });
         if (diff.exitCode !== 0) {
             emit({
+                block: false,
                 skipped: true,
                 reason: 'git-diff-failed',
                 action_required: false,
@@ -1500,10 +1580,13 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
             action,
             runtime: (0, runtime_slash_cjs_1.resolveRuntime)(cwd),
         });
+        const actionRequired = !!driftResult['actionRequired'];
         emit({
+            // Uniform gate contract: block = action_required.
+            block: actionRequired,
             skipped: !!driftResult['skipped'],
             reason: driftResult['reason'] || null,
-            action_required: !!driftResult['actionRequired'],
+            action_required: actionRequired,
             directive: driftResult['directive'],
             spawn_mapper: !!driftResult['spawnMapper'],
             affected_paths: driftResult['affectedPaths'] || [],
@@ -1516,6 +1599,7 @@ function cmdVerifyCodebaseDrift(cwd, raw) {
     }
     catch (err) {
         emit({
+            block: false,
             skipped: true,
             reason: 'exception: ' + (err && err instanceof Error ? err.message : String(err)),
             action_required: false,

package/gsd-core/bin/lib/worktree-safety.cjs

@@ -701,6 +701,7 @@ function reapOrphanWorktrees(repoRoot, deps = {}) {
     const readFileSafe = deps.readFileSafe || defaultReadFileSafe;
     const mtimeSafe = deps.mtimeSafe || defaultMtimeSafe;
     const reapMtimeGuardMs = deps.reapMtimeGuardMs !== undefined ? deps.reapMtimeGuardMs : REAP_MTIME_GUARD_MS;
+    const nowMs = deps.nowMs ?? Date.now();
     const results = [];
     // 1. Discover the .git/worktrees/ admin directory.
     const gitDir = execGit(['rev-parse', '--git-dir'], { cwd: repoRoot });
@@ -803,7 +804,7 @@ function reapOrphanWorktrees(repoRoot, deps = {}) {
         }
         // 4a. Stale-lock guard: skip if lock is too fresh (PID recycling / race).
         const lockMtime = mtimeSafe(lockedFile);
-        if (!lockMtime || Date.now() - lockMtime.getTime() < reapMtimeGuardMs) {
+        if (!lockMtime || nowMs - lockMtime.getTime() < reapMtimeGuardMs) {
             results.push({ path: worktreePath, status: 'skipped', reason: 'lock_too_fresh' });
             continue;
         }

package/gsd-core/bin/shared/config-defaults.manifest.json

@@ -13,7 +13,7 @@
   "project_code": null,
   "phase_id_convention": null,
   "mode": "interactive",
-  "claude_md_path": "./CLAUDE.md",
+  "claude_md_path": "./.claude/CLAUDE.md",
   "git": {
     "branching_strategy": "none",
     "create_tag": true,
@@ -28,7 +28,6 @@
     "verifier": true,
     "nyquist_validation": true,
     "ai_integration_phase": true,
-    "tdd_mode": false,
     "human_verify_mode": "end-of-phase",
     "auto_advance": false,
     "_auto_chain_active": false,

package/gsd-core/bin/shared/config-schema.manifest.json

@@ -10,17 +10,11 @@
     "brave_search",
     "firecrawl",
     "exa_search",
-    "workflow.research",
     "workflow.plan_check",
     "workflow.verifier",
-    "workflow.nyquist_validation",
-    "workflow.ai_integration_phase",
-    "workflow.ui_phase",
-    "workflow.ui_safety_gate",
     "workflow.auto_advance",
     "workflow.node_repair",
     "workflow.node_repair_budget",
-    "workflow.tdd_mode",
     "workflow.human_verify_mode",
     "workflow.text_mode",
     "workflow.research_before_questions",
@@ -29,21 +23,12 @@
     "workflow.auto_prune_state",
     "workflow.use_worktrees",
     "workflow.worktree_skip_hooks",
-    "workflow.code_review",
-    "workflow.code_review_depth",
     "workflow.code_review_command",
-    "workflow.pattern_mapper",
     "workflow.plan_bounce",
     "workflow.plan_bounce_script",
     "workflow.plan_bounce_passes",
     "workflow.plan_chunked",
     "workflow.plan_review_convergence",
-    "workflow.post_planning_gaps",
-    "workflow.security_enforcement",
-    "workflow.security_asvs_level",
-    "workflow.security_block_on",
-    "workflow.drift_threshold",
-    "workflow.drift_action",
     "code_quality.fallow.enabled",
     "code_quality.fallow.scope",
     "code_quality.fallow.profile",
@@ -76,7 +61,6 @@
     "workflow.context_coverage_gate",
     "statusline.show_last_command",
     "statusline.context_position",
-    "workflow.ui_review",
     "workflow.max_discuss_passes",
     "features.thinking_partner",
     "context",
@@ -90,8 +74,6 @@
     "manager.flags.execute",
     "response_language",
     "context_window",
-    "intel.enabled",
-    "graphify.enabled",
     "graphify.build_timeout",
     "graphify.auto_update",
     "claude_md_path",

package/gsd-core/bin/shared/model-catalog.json

@@ -153,6 +153,7 @@
     "gsd-eval-planner":           { "golden": "opus",   "balanced": "opus",   "budget": "sonnet", "phaseType": "planning",     "routingTier": "heavy" },
     "gsd-framework-selector":     { "golden": "opus",   "balanced": "sonnet", "budget": "sonnet", "phaseType": "planning",     "routingTier": "heavy" },
     "gsd-intel-updater":          { "golden": "opus",   "balanced": "sonnet", "budget": "haiku",  "phaseType": "research",     "routingTier": "light" },
+    "gsd-mempalace-curator":      { "golden": "sonnet", "balanced": "sonnet", "budget": "haiku",  "phaseType": "research",     "routingTier": "light" },
     "gsd-security-auditor":       { "golden": "opus",   "balanced": "sonnet", "budget": "sonnet", "phaseType": "verification", "routingTier": "heavy" },
     "gsd-user-profiler":          { "golden": "opus",   "balanced": "sonnet", "budget": "sonnet", "phaseType": "research",     "routingTier": "heavy" }
   }

package/gsd-core/references/edge-probe.md

@@ -77,6 +77,17 @@ Two rules keep the probe honest and prevent an "everything is N/A" failure mode:
 2. **Dismissal requires a reason string.** "N/A — input is a bounded enum, no boundary
    exists" is valid; silence is not. The reason string is the audit trail.
 
+**Zero-classification surfaces an `unclassified` candidate (#1110).** The relevance filter is
+a heuristic over prose cues, so a requirement whose wording *is* edge-relevant but matches no
+shape cue would otherwise classify to zero shapes → zero edges and vanish from coverage with
+no signal — the same silent blind spot the probe exists to catch. Instead, a requirement with
+non-empty prose, no authored `shapes`, and zero matched shapes surfaces exactly one soft
+`unclassified — review manually` candidate (`category: "unclassified"`, `status: "unresolved"`).
+It is a dismissible nudge — resolve it, or dismiss it with a reason (e.g. a genuinely edge-free
+static-asset requirement) — never a hard block. `unclassified` is a review signal, **not** a
+ninth taxonomy category: the closed eight above are unchanged, and an explicit `shapes: []`
+opt-out stays silent (the author's deliberate "no edge surface").
+
 Each raised edge carries two orthogonal axes — a resolution **lifecycle** and, when
 resolved, a **verification** tier (ADR-550 Decision 7, the shared probe-core model):
 

package/gsd-core/references/loop-hook-dispatch.md

@@ -0,0 +1,61 @@
+# Loop Hook Dispatch Contract
+
+Generic reference for consuming the `--raw` JSON output of `gsd_run loop render-hooks <point>`
+in any host-loop workflow. This document is point-agnostic — it applies to every loop
+extension point (discuss:pre, discuss:post, plan:pre, plan:post, execute:pre, execute:wave:pre,
+execute:wave:post, execute:post, verify:pre, verify:post, ship:pre, ship:post).
+
+## Envelope shape
+
+```json
+{
+  "point": "discuss:pre",
+  "activeHooks": [
+    { "kind": "contribution", "into": "orchestrator", "fragment": { "inline": "..." } },
+    { "kind": "step", "ref": { "skill": "my-skill" } },
+    { "kind": "gate", "check": { "query": "..." }, "blocking": true, "onError": "skip" }
+  ],
+  "rendered": "..."
+}
+```
+
+`activeHooks` is an array of enabled hook entries for the named point. It is empty (or absent)
+when no capability has registered an active hook at this point — treat that as a no-op.
+
+## Dispatch rules by `kind`
+
+### `contribution`
+
+Inject `fragment.inline` verbatim into the context for the role named in `into`
+(e.g. `orchestrator`, `planner`). Do not paraphrase — the text is the product.
+
+### `step`
+
+Dispatch the referenced unit:
+
+- `ref.skill` present → dispatch via the Skill tool with skill id `gsd-<ref.skill>`.
+- `ref.agent` present → dispatch via the Agent tool with `subagent_type` = `ref.agent`.
+  Before dispatching an agent, print the canonical liveness banner so users know silence
+  is expected and do not kill a healthy agent:
+
+  ```
+  ◆ Spawning <agent>... (runs in a subagent — no output until it returns; expected, not a freeze)
+  ```
+
+Wait for the result before continuing to the next hook or the next step.
+
+### `gate`
+
+Evaluate `check` (one of `query`, `predicate`, or `agentVerdict`). Then honor `blocking`:
+
+- `blocking: true` → if the check returns `block: true`, surface `check.message` to the user
+  and stop the current step. Do not continue.
+- `blocking: false` → advisory only; surface the message but continue regardless of outcome.
+
+Honor `onError` if the check itself errors: `skip` means treat as non-blocking and continue;
+`fail` means surface the error and stop.
+
+## Empty / absent `activeHooks`
+
+If `activeHooks` is absent, null, or an empty array, skip silently and continue to the next
+step in the workflow. No output to the user is needed.

package/gsd-core/references/prohibition-probe-fixtures/01-streak-reminder/expected.json

@@ -0,0 +1,14 @@
+{
+  "items": [
+    {
+      "requirement_id": "R1",
+      "category": "values",
+      "status": "resolved",
+      "verification": "judgment",
+      "resolution": null,
+      "reason": null,
+      "statement": "MUST NOT use shaming, guilt, or loss-aversion streak framing (e.g. \"Don't lose your streak!\") — the reminder must encourage without penalty framing"
+    }
+  ],
+  "coverage": { "applicable": 1, "resolved": 1, "unresolved": 0, "byVerification": { "test": 0, "judgment": 1 } }
+}

package/gsd-core/references/prohibition-probe-fixtures/02-clean-utility/expected.json

@@ -0,0 +1,4 @@
+{
+  "items": [],
+  "coverage": { "applicable": 0, "resolved": 0, "unresolved": 0, "byVerification": { "test": 0, "judgment": 0 } }
+}

package/gsd-core/references/prohibition-probe-fixtures/03-multi-prohibition/expected.json

@@ -0,0 +1,32 @@
+{
+  "items": [
+    {
+      "requirement_id": "R1",
+      "category": "fairness",
+      "status": "resolved",
+      "verification": "judgment",
+      "resolution": null,
+      "reason": null,
+      "statement": "MUST NOT use protected attributes (race, gender, age, national origin) or their proxies (zip code, name) in the loan decision or rate"
+    },
+    {
+      "requirement_id": "R1",
+      "category": "privacy",
+      "status": "resolved",
+      "verification": "test",
+      "resolution": null,
+      "reason": null,
+      "statement": "MUST NOT store raw PII / financial secrets (SSN, full account or card numbers) in plaintext in the audit log"
+    },
+    {
+      "requirement_id": "R1",
+      "category": "transparency",
+      "status": "resolved",
+      "verification": "judgment",
+      "resolution": null,
+      "reason": null,
+      "statement": "MUST NOT mislead or omit the true rate/APR/terms in the explanation; an adverse decision must state the real principal reason (adverse-action)"
+    }
+  ],
+  "coverage": { "applicable": 3, "resolved": 3, "unresolved": 0, "byVerification": { "test": 1, "judgment": 2 } }
+}