@open-mercato/core 0.9.0 → 0.9.1-develop.7459.1.99e3accd30

package/dist/modules/customers/commands/interactions.js

@@ -42,6 +42,11 @@ import {
 } from "../lib/interactionStatus.js";
 import { canChangeEmailVisibility } from "../lib/visibilityFilter.js";
 import { createLogger } from "@open-mercato/shared/lib/logger";
+import { loadCustomFieldDefinitionIndex } from "@open-mercato/shared/lib/crud/custom-fields";
+import { resolveCatalogEventType, resolveScopedCalendarEventTypes } from "../lib/calendar/eventTypeResolver.js";
+import { clearInapplicableCoreFields, findInapplicableCoreFields, omitHiddenCoreClears, preserveHiddenCoreValuesOnSameTypeEdit } from "../lib/calendar/interactionApplicability.js";
+import { calendarEventTypes } from "../calendar-event-types.js";
+import { canonicalCalendarTimezone } from "../lib/calendar/timezone.js";
 const logger = createLogger("customers");
 const INTERACTION_ENTITY_ID = "customers:customer_interaction";
 const interactionCrudIndexer = {
@@ -100,6 +105,7 @@ async function loadInteractionSnapshot(em, id) {
       appearanceColor: interaction.appearanceColor ?? null,
       source: interaction.source ?? null,
       durationMinutes: interaction.durationMinutes ?? null,
+      timezone: interaction.timezone ?? null,
       location: interaction.location ?? null,
       allDay: interaction.allDay ?? null,
       recurrenceRule: interaction.recurrenceRule ?? null,
@@ -125,6 +131,61 @@ async function setInteractionCustomFields(dataEngine, interactionId, organizatio
     notify: false
   });
 }
+function requestsSelectableTypeEnforcement(input) {
+  return input !== null && typeof input === "object" && "enforceSelectableType" in input && input.enforceSelectableType === true;
+}
+async function resolveInteractionTypeBehavior(ctx, em, tenantId, organizationId, key, unchangedType, enforceSelectableType) {
+  const hierarchy = ctx.container.resolve("organizationHierarchyService");
+  const ancestors = await hierarchy.resolveAncestorIds({ tenantId, organizationId });
+  if (ancestors === null) throw notFound("Organization not found");
+  const organizationIds = [organizationId, ...ancestors.slice().reverse()];
+  let catalog;
+  try {
+    catalog = await resolveScopedCalendarEventTypes({
+      em,
+      tenantId,
+      organizationId,
+      readableOrganizationIds: organizationIds
+    });
+  } catch {
+    const { translate: translate2 } = await resolveTranslations();
+    throw new CrudHttpError(503, {
+      error: translate2("customers.calendar.activityTypes.errors.loadFailed", "Failed to load activity types"),
+      code: "activity_type_catalog_unavailable",
+      retryable: true
+    });
+  }
+  const selected = resolveCatalogEventType(catalog, key, { includeHistorical: unchangedType || !enforceSelectableType });
+  if (selected && (unchangedType || !enforceSelectableType || selected.selectable)) {
+    return { behavior: selected.behavior, organizationIds };
+  }
+  if (unchangedType) return { behavior: calendarEventTypes[0].behavior, organizationIds };
+  const { translate } = await resolveTranslations();
+  throw new CrudHttpError(400, {
+    error: translate("customers.calendar.activityTypes.errors.unavailable", "Activity type is unavailable"),
+    code: "activity_type_unavailable"
+  });
+}
+async function loadApplicableCustomFieldKeys(em, tenantId, organizationIds, behavior) {
+  const options = { em, entityIds: [INTERACTION_ENTITY_ID], tenantId, organizationIds };
+  const all = await loadCustomFieldDefinitionIndex(options);
+  const fieldsets = behavior.customFieldsetIds.map((id) => id === "__general__" ? "" : id);
+  const applicable = fieldsets.length ? await loadCustomFieldDefinitionIndex({ ...options, fieldset: fieldsets }) : all;
+  return {
+    defined: new Set([...all.keys()].map((key) => key.toLowerCase())),
+    allowed: new Set([...applicable.keys()].map((key) => key.toLowerCase()))
+  };
+}
+function inapplicableCustomFieldKeys(values, keys) {
+  return Object.entries(values).filter(([key, value]) => keys.defined.has(key.toLowerCase()) && !keys.allowed.has(key.toLowerCase()) && value !== null && value !== void 0 && value !== "" && (!Array.isArray(value) || value.length > 0)).map(([key]) => key);
+}
+function inapplicableFieldError(fields, message) {
+  return new CrudHttpError(400, {
+    error: message,
+    code: "activity_type_field_not_applicable",
+    fields
+  });
+}
 async function emitLifecycleEvent(ctx, eventId, payload) {
   let bus = null;
   try {
@@ -159,13 +220,18 @@ function createTransactionalDataEngine(ctx, em) {
   }
   return new DefaultDataEngine(em, ctx.container);
 }
-async function runInTransaction(em, operation) {
+async function runInTransaction(em, operation, beforeWrite, input) {
+  if (typeof em.isInTransaction === "function" && em.isInTransaction()) {
+    await beforeWrite?.(em, input);
+    return operation(em);
+  }
   const supportsBegin = typeof em.begin === "function" && typeof em.commit === "function" && typeof em.rollback === "function";
   if (!supportsBegin) {
     return operation(em);
   }
   await em.begin();
   try {
+    await beforeWrite?.(em, input);
     const result = await operation(em);
     await em.commit();
     return result;
@@ -212,6 +278,7 @@ function buildInteractionGraph(em, values) {
     appearanceIcon: values.appearanceIcon,
     appearanceColor: values.appearanceColor,
     durationMinutes: values.durationMinutes,
+    timezone: values.timezone ?? null,
     location: values.location,
     allDay: values.allDay,
     recurrenceRule: values.recurrenceRule,
@@ -229,7 +296,7 @@ const createInteractionCommand = {
   id: "customers.interactions.create",
   async execute(rawInput, ctx) {
     const { parsed, custom } = parseWithCustomFields(interactionCreateSchema, rawInput);
-    const em = ctx.container.resolve("em").fork();
+    const em = ctx.transactionalEm ?? ctx.container.resolve("em").fork();
     const normalizedAuthor = normalizeAuthorUserId(parsed.authorUserId ?? null, ctx.auth);
     const { interaction, entityId, nextInteractionId } = await runInTransaction(em, async (trx) => {
       const entity = await requireTimelineParentEntity(trx, parsed.entityId, { tenantId: parsed.tenantId, organizationId: parsed.organizationId });
@@ -238,6 +305,26 @@ const createInteractionCommand = {
       if (parsed.dealId) {
         await requireDealInScope(trx, parsed.dealId, entity.tenantId, entity.organizationId);
       }
+      const enforceSelectableType = requestsSelectableTypeEnforcement(rawInput);
+      const { behavior, organizationIds } = await resolveInteractionTypeBehavior(
+        ctx,
+        trx,
+        entity.tenantId,
+        entity.organizationId,
+        parsed.interactionType,
+        false,
+        enforceSelectableType
+      );
+      const inapplicableCore = findInapplicableCoreFields(behavior, parsed);
+      const customKeys = Object.keys(custom).length ? await loadApplicableCustomFieldKeys(trx, entity.tenantId, organizationIds, behavior) : null;
+      const inapplicableCustom = customKeys ? inapplicableCustomFieldKeys(custom, customKeys) : [];
+      if (enforceSelectableType && (inapplicableCore.length || inapplicableCustom.length)) {
+        const { translate } = await resolveTranslations();
+        throw inapplicableFieldError(
+          [...inapplicableCore, ...inapplicableCustom.map((key) => `cf_${key}`)],
+          translate("customers.calendar.activityTypes.errors.fieldNotApplicable", "Field is not applicable to this activity type")
+        );
+      }
       const interaction2 = buildInteractionGraph(trx, {
         ...parsed.id ? { id: parsed.id } : {},
         organizationId: entity.organizationId,
@@ -257,6 +344,7 @@ const createInteractionCommand = {
         appearanceIcon: parsed.appearanceIcon ?? null,
         appearanceColor: parsed.appearanceColor ?? null,
         durationMinutes: parsed.durationMinutes ?? null,
+        timezone: canonicalCalendarTimezone(parsed.timezone) ?? null,
         location: parsed.location ?? null,
         allDay: parsed.allDay ?? null,
         recurrenceRule: parsed.recurrenceRule ?? null,
@@ -282,7 +370,7 @@ const createInteractionCommand = {
         entityId: entity.id,
         nextInteractionId: projection.nextInteractionId
       };
-    });
+    }, ctx.beforeTransactionalWrite, rawInput);
     const de = ctx.container.resolve("dataEngine");
     await emitCrudSideEffects({
       dataEngine: de,
@@ -305,7 +393,7 @@ const createInteractionCommand = {
     return { interactionId: interaction.id, entityId };
   },
   captureAfter: async (_input, result, ctx) => {
-    const em = ctx.container.resolve("em").fork();
+    const em = ctx.transactionalEm ?? ctx.container.resolve("em").fork();
     return await loadInteractionSnapshot(em, result.interactionId);
   },
   buildLog: async ({ result, snapshots }) => {
@@ -383,6 +471,7 @@ const createInteractionCommand = {
           appearanceIcon: after.interaction.appearanceIcon,
           appearanceColor: after.interaction.appearanceColor,
           durationMinutes: after.interaction.durationMinutes,
+          timezone: after.interaction.timezone ?? null,
           location: after.interaction.location,
           allDay: after.interaction.allDay,
           recurrenceRule: after.interaction.recurrenceRule,
@@ -411,6 +500,7 @@ const createInteractionCommand = {
         interaction2.appearanceIcon = after.interaction.appearanceIcon;
         interaction2.appearanceColor = after.interaction.appearanceColor;
         interaction2.durationMinutes = after.interaction.durationMinutes;
+        interaction2.timezone = after.interaction.timezone ?? null;
         interaction2.location = after.interaction.location;
         interaction2.allDay = after.interaction.allDay;
         interaction2.recurrenceRule = after.interaction.recurrenceRule;
@@ -462,17 +552,19 @@ const createInteractionCommand = {
     return { interactionId: interaction.id, entityId: after.interaction.entityId };
   }
 };
+async function prepareUpdateInteractionSnapshot(rawInput, ctx) {
+  const { parsed } = parseWithCustomFields(interactionUpdateSchema, rawInput);
+  const em = ctx.transactionalEm ?? ctx.container.resolve("em").fork();
+  const snapshot = await loadInteractionSnapshot(em, parsed.id);
+  return snapshot ? { before: snapshot } : {};
+}
 const updateInteractionCommand = {
   id: "customers.interactions.update",
-  async prepare(rawInput, ctx) {
-    const { parsed } = parseWithCustomFields(interactionUpdateSchema, rawInput);
-    const em = ctx.container.resolve("em").fork();
-    const snapshot = await loadInteractionSnapshot(em, parsed.id);
-    return snapshot ? { before: snapshot } : {};
-  },
+  prepare: prepareUpdateInteractionSnapshot,
+  prepareSnapshotInsideTransaction: true,
   async execute(rawInput, ctx) {
     const { parsed, custom } = parseWithCustomFields(interactionUpdateSchema, rawInput);
-    const em = ctx.container.resolve("em").fork();
+    const em = ctx.transactionalEm ?? ctx.container.resolve("em").fork();
     const { interaction, projections } = await runInTransaction(em, async (trx) => {
       const interaction2 = await findOneWithDecryption(trx, CustomerInteraction, { id: parsed.id, deletedAt: null });
       if (!interaction2) {
@@ -487,6 +579,64 @@ const updateInteractionCommand = {
         current: interaction2.updatedAt,
         request: ctx.request ?? null
       });
+      const nextType = parsed.interactionType ?? interaction2.interactionType;
+      const changingType = nextType !== interaction2.interactionType;
+      const enforceSelectableType = requestsSelectableTypeEnforcement(rawInput);
+      const { behavior, organizationIds } = await resolveInteractionTypeBehavior(
+        ctx,
+        trx,
+        interaction2.tenantId,
+        interaction2.organizationId,
+        nextType,
+        !changingType,
+        enforceSelectableType
+      );
+      const currentCoreValues = {
+        durationMinutes: interaction2.durationMinutes,
+        timezone: interaction2.timezone ?? null,
+        allDay: interaction2.allDay,
+        recurrenceRule: interaction2.recurrenceRule,
+        recurrenceEnd: interaction2.recurrenceEnd,
+        location: interaction2.location,
+        participants: interaction2.participants,
+        priority: interaction2.priority,
+        linkedEntities: interaction2.linkedEntities
+      };
+      const typeChangeFields = changingType && enforceSelectableType ? omitHiddenCoreClears(behavior, parsed) : parsed;
+      const coreValues = { ...currentCoreValues, ...typeChangeFields };
+      const inapplicableCore = findInapplicableCoreFields(behavior, changingType ? coreValues : parsed);
+      const confirmsDiscard = parsed.confirmDiscardInapplicableValues === true;
+      const currentCustom = changingType && (enforceSelectableType || confirmsDiscard) ? await loadCustomFieldSnapshot(trx, {
+        entityId: INTERACTION_ENTITY_ID,
+        recordId: interaction2.id,
+        tenantId: interaction2.tenantId,
+        organizationId: interaction2.organizationId
+      }) : {};
+      const customValues = changingType ? { ...currentCustom, ...custom } : custom;
+      const customKeys = Object.keys(customValues).length ? await loadApplicableCustomFieldKeys(trx, interaction2.tenantId, organizationIds, behavior) : null;
+      const inapplicableCustom = customKeys ? inapplicableCustomFieldKeys(customValues, customKeys) : [];
+      if (!changingType && enforceSelectableType && (inapplicableCore.length || inapplicableCustom.length)) {
+        const { translate } = await resolveTranslations();
+        throw inapplicableFieldError(
+          [...inapplicableCore, ...inapplicableCustom.map((key) => `cf_${key}`)],
+          translate("customers.calendar.activityTypes.errors.fieldNotApplicable", "Field is not applicable to this activity type")
+        );
+      }
+      if (changingType && enforceSelectableType && (inapplicableCore.length || inapplicableCustom.length) && !confirmsDiscard) {
+        const { translate } = await resolveTranslations();
+        throw new CrudHttpError(409, {
+          error: translate("customers.calendar.activityTypes.errors.changeConfirmationRequired", "Changing type will clear existing values"),
+          code: "calendar_type_change_confirmation_required",
+          fields: [...inapplicableCore, ...inapplicableCustom.map((key) => `cf_${key}`)]
+        });
+      }
+      const discardsInapplicableValues = changingType && confirmsDiscard;
+      const clearedCore = discardsInapplicableValues ? clearInapplicableCoreFields(behavior, coreValues) : {};
+      const clearedCustom = discardsInapplicableValues ? Object.fromEntries(inapplicableCustom.map((key) => [key, Array.isArray(customValues[key]) ? [] : null])) : {};
+      const sameTypeFields = changingType ? typeChangeFields : preserveHiddenCoreValuesOnSameTypeEdit(behavior, currentCoreValues, parsed, {
+        ignoreHiddenClears: enforceSelectableType
+      });
+      const sameTypeCustom = changingType || !customKeys || !enforceSelectableType ? custom : Object.fromEntries(Object.entries(custom).filter(([key]) => !customKeys.defined.has(key.toLowerCase()) || customKeys.allowed.has(key.toLowerCase())));
       if (parsed.visibility !== void 0 && interaction2.interactionType === "email" && (parsed.visibility ?? null) !== (interaction2.visibility ?? null)) {
         const actorUserId = ctx.auth?.sub ?? null;
         if (!canChangeEmailVisibility({
@@ -519,23 +669,34 @@ const updateInteractionCommand = {
       if (parsed.body !== void 0) interaction2.body = parsed.body ?? null;
       if (parsed.status !== void 0) interaction2.status = parsed.status;
       if (parsed.scheduledAt !== void 0) interaction2.scheduledAt = parsed.scheduledAt ?? null;
+      if (parsed.timezone !== void 0) interaction2.timezone = canonicalCalendarTimezone(parsed.timezone) ?? null;
       if (parsed.occurredAt !== void 0) interaction2.occurredAt = parsed.occurredAt ?? null;
-      if (parsed.priority !== void 0) interaction2.priority = parsed.priority ?? null;
+      if (sameTypeFields.priority !== void 0) interaction2.priority = sameTypeFields.priority;
       if (parsed.authorUserId !== void 0) interaction2.authorUserId = parsed.authorUserId ?? null;
       if (parsed.ownerUserId !== void 0) interaction2.ownerUserId = parsed.ownerUserId ?? null;
       if (parsed.appearanceIcon !== void 0) interaction2.appearanceIcon = parsed.appearanceIcon ?? null;
       if (parsed.appearanceColor !== void 0) interaction2.appearanceColor = parsed.appearanceColor ?? null;
       if (parsed.pinned !== void 0) interaction2.pinned = parsed.pinned;
-      if (parsed.durationMinutes !== void 0) interaction2.durationMinutes = parsed.durationMinutes ?? null;
-      if (parsed.location !== void 0) interaction2.location = parsed.location ?? null;
-      if (parsed.allDay !== void 0) interaction2.allDay = parsed.allDay ?? null;
-      if (parsed.recurrenceRule !== void 0) interaction2.recurrenceRule = parsed.recurrenceRule ?? null;
-      if (parsed.recurrenceEnd !== void 0) interaction2.recurrenceEnd = parsed.recurrenceEnd ?? null;
-      if (parsed.participants !== void 0) interaction2.participants = parsed.participants ?? null;
+      if (sameTypeFields.durationMinutes !== void 0) interaction2.durationMinutes = sameTypeFields.durationMinutes;
+      if (sameTypeFields.location !== void 0) interaction2.location = sameTypeFields.location;
+      if (sameTypeFields.allDay !== void 0) interaction2.allDay = sameTypeFields.allDay;
+      if (sameTypeFields.recurrenceRule !== void 0) interaction2.recurrenceRule = sameTypeFields.recurrenceRule;
+      if (sameTypeFields.recurrenceEnd !== void 0) interaction2.recurrenceEnd = sameTypeFields.recurrenceEnd;
+      if (sameTypeFields.participants !== void 0) interaction2.participants = sameTypeFields.participants;
       if (parsed.reminderMinutes !== void 0) interaction2.reminderMinutes = parsed.reminderMinutes ?? null;
       if (parsed.visibility !== void 0) interaction2.visibility = parsed.visibility ?? null;
-      if (parsed.linkedEntities !== void 0) interaction2.linkedEntities = parsed.linkedEntities ?? null;
+      if (sameTypeFields.linkedEntities !== void 0) interaction2.linkedEntities = sameTypeFields.linkedEntities;
       if (parsed.guestPermissions !== void 0) interaction2.guestPermissions = parsed.guestPermissions ?? null;
+      for (const [field, value] of Object.entries(clearedCore)) {
+        if (field === "linkedEntities") interaction2.linkedEntities = value;
+        else if (field === "durationMinutes") interaction2.durationMinutes = null;
+        else if (field === "allDay") interaction2.allDay = null;
+        else if (field === "recurrenceRule") interaction2.recurrenceRule = null;
+        else if (field === "recurrenceEnd") interaction2.recurrenceEnd = null;
+        else if (field === "location") interaction2.location = null;
+        else if (field === "participants") interaction2.participants = null;
+        else if (field === "priority") interaction2.priority = null;
+      }
       await trx.flush();
       const entityId = typeof interaction2.entity === "string" ? interaction2.entity : interaction2.entity.id;
       await setInteractionCustomFields(
@@ -543,7 +704,7 @@ const updateInteractionCommand = {
         interaction2.id,
         interaction2.organizationId,
         interaction2.tenantId,
-        custom
+        { ...sameTypeCustom, ...clearedCustom }
       );
       const projection = await recomputeNextInteraction(trx, entityId);
       const projections2 = [
@@ -554,7 +715,7 @@ const updateInteractionCommand = {
         projections2.push({ entityId: previousEntityId, nextInteractionId: previousProjection.nextInteractionId });
       }
       return { interaction: interaction2, projections: projections2 };
-    });
+    }, ctx.beforeTransactionalWrite, rawInput);
     const de = ctx.container.resolve("dataEngine");
     await emitCrudSideEffects({
       dataEngine: de,
@@ -579,7 +740,7 @@ const updateInteractionCommand = {
     return { interactionId: interaction.id };
   },
   captureAfter: async (_input, result, ctx) => {
-    const em = ctx.container.resolve("em").fork();
+    const em = ctx.transactionalEm ?? ctx.container.resolve("em").fork();
     return await loadInteractionSnapshot(em, result.interactionId);
   },
   buildLog: async ({ snapshots }) => {
@@ -633,6 +794,7 @@ const updateInteractionCommand = {
           appearanceIcon: before.interaction.appearanceIcon,
           appearanceColor: before.interaction.appearanceColor,
           durationMinutes: before.interaction.durationMinutes,
+          timezone: before.interaction.timezone ?? null,
           location: before.interaction.location,
           allDay: before.interaction.allDay,
           recurrenceRule: before.interaction.recurrenceRule,
@@ -662,6 +824,7 @@ const updateInteractionCommand = {
         interaction2.appearanceIcon = before.interaction.appearanceIcon;
         interaction2.appearanceColor = before.interaction.appearanceColor;
         interaction2.durationMinutes = before.interaction.durationMinutes;
+        interaction2.timezone = before.interaction.timezone ?? null;
         interaction2.location = before.interaction.location;
         interaction2.allDay = before.interaction.allDay;
         interaction2.recurrenceRule = before.interaction.recurrenceRule;
@@ -1077,6 +1240,7 @@ const deleteInteractionCommand = {
           appearanceIcon: before.interaction.appearanceIcon,
           appearanceColor: before.interaction.appearanceColor,
           durationMinutes: before.interaction.durationMinutes,
+          timezone: before.interaction.timezone ?? null,
           location: before.interaction.location,
           allDay: before.interaction.allDay,
           recurrenceRule: before.interaction.recurrenceRule,
@@ -1107,6 +1271,7 @@ const deleteInteractionCommand = {
         interaction2.appearanceIcon = before.interaction.appearanceIcon;
         interaction2.appearanceColor = before.interaction.appearanceColor;
         interaction2.durationMinutes = before.interaction.durationMinutes;
+        interaction2.timezone = before.interaction.timezone ?? null;
         interaction2.location = before.interaction.location;
         interaction2.allDay = before.interaction.allDay;
         interaction2.recurrenceRule = before.interaction.recurrenceRule;