@open-mercato/core 0.6.3-develop.3635.1.e4a05c16e8 → 0.6.3-develop.3653.1.b8558737ae

package/src/modules/customers/lib/bulkDeals.ts

@@ -0,0 +1,231 @@
+import type { AwilixContainer } from 'awilix'
+import type { EntityManager as CoreEntityManager } from '@mikro-orm/core'
+import type { CommandBus, CommandRuntimeContext } from '@open-mercato/shared/lib/commands'
+import { invalidateCrudCache } from '@open-mercato/shared/lib/crud/cache'
+import { runWithCacheTenant } from '@open-mercato/cache'
+import { createModuleQueue, type Queue } from '@open-mercato/queue'
+import type { ProgressService, ProgressServiceContext } from '../../progress/lib/progressService'
+
+export const CUSTOMERS_DEALS_BULK_UPDATE_STAGE_QUEUE = 'customers-deals-bulk-update-stage'
+export const CUSTOMERS_DEALS_BULK_UPDATE_OWNER_QUEUE = 'customers-deals-bulk-update-owner'
+
+const queues = new Map<string, Queue<Record<string, unknown>>>()
+
+export function getCustomersQueue(queueName: string): Queue<Record<string, unknown>> {
+  const existing = queues.get(queueName)
+  if (existing) return existing
+  const concurrency = Math.max(
+    1,
+    Number.parseInt(process.env.CUSTOMERS_QUEUE_CONCURRENCY ?? '3', 10) || 3,
+  )
+  const created = createModuleQueue<Record<string, unknown>>(queueName, { concurrency })
+  queues.set(queueName, created)
+  return created
+}
+
+export type CustomersDealsBulkScope = {
+  organizationId: string
+  tenantId: string
+  userId?: string | null
+}
+
+export type CustomersDealsBulkUpdateStageJobPayload = {
+  progressJobId: string
+  ids: string[]
+  pipelineStageId: string
+  scope: CustomersDealsBulkScope
+}
+
+export type CustomersDealsBulkUpdateOwnerJobPayload = {
+  progressJobId: string
+  ids: string[]
+  ownerUserId: string | null
+  scope: CustomersDealsBulkScope
+}
+
+export type CustomersDealsBulkFailedItem = {
+  id: string
+  message: string
+}
+
+export type CustomersDealsBulkSummary = {
+  affectedCount: number
+  failedCount: number
+  failedItems: CustomersDealsBulkFailedItem[]
+}
+
+export class BulkDealsPreflightError extends Error {
+  readonly code: string
+  constructor(code: string, message: string) {
+    super(message)
+    this.name = 'BulkDealsPreflightError'
+    this.code = code
+  }
+}
+
+async function verifyPipelineStageExists(
+  em: CoreEntityManager,
+  stageId: string,
+  scope: CustomersDealsBulkScope,
+): Promise<void> {
+  // The `pipelineStageId` posted from the kanban is a `customer_pipeline_stages.id`
+  // (the per-pipeline stage definition that `commands/deals.ts:loadPipelineStageSnapshot`
+  // also reads). It is NOT a `customer_dictionary_entries.id` — those entries are a
+  // per-tenant dictionary used to centralize stage colours/icons by normalized label.
+  const rows = await em.getConnection().execute<Array<{ id: string }>>(
+    `SELECT id FROM customer_pipeline_stages
+       WHERE id = ?
+         AND tenant_id = ?
+         AND organization_id = ?
+       LIMIT 1`,
+    [stageId, scope.tenantId, scope.organizationId],
+  )
+  if (rows.length === 0) {
+    throw new BulkDealsPreflightError(
+      'pipeline_stage_not_found',
+      `Pipeline stage ${stageId} does not exist in this tenant`,
+    )
+  }
+}
+
+const BULK_CACHE_ALIASES = ['customers.deals']
+
+function buildCommandContext(
+  scope: CustomersDealsBulkScope,
+  container: AwilixContainer,
+): CommandRuntimeContext {
+  return {
+    container,
+    auth: null,
+    organizationScope: {
+      selectedId: scope.organizationId,
+      filterIds: [scope.organizationId],
+      allowedIds: [scope.organizationId],
+      tenantId: scope.tenantId,
+    },
+    selectedOrganizationId: scope.organizationId,
+    organizationIds: [scope.organizationId],
+  }
+}
+
+async function runBulkDealUpdate(params: {
+  container: AwilixContainer
+  progressJobId: string
+  ids: string[]
+  scope: CustomersDealsBulkScope
+  cacheSource: string
+  buildBody: (id: string) => Record<string, unknown>
+  logTag: string
+}): Promise<CustomersDealsBulkSummary> {
+  const { container, progressJobId, ids, scope, cacheSource, buildBody, logTag } = params
+  const commandBus = container.resolve('commandBus') as CommandBus
+  const progressService = container.resolve('progressService') as ProgressService
+  const progressContext: ProgressServiceContext = {
+    tenantId: scope.tenantId,
+    organizationId: scope.organizationId,
+    userId: scope.userId,
+  }
+
+  await progressService.startJob(progressJobId, progressContext)
+  await progressService.updateProgress(
+    progressJobId,
+    { totalCount: ids.length, processedCount: 0 },
+    progressContext,
+  )
+
+  const commandContext = buildCommandContext(scope, container)
+  const updatedIds = new Set<string>()
+  const failedItems: CustomersDealsBulkFailedItem[] = []
+  let affectedCount = 0
+
+  for (const [index, id] of ids.entries()) {
+    try {
+      // `customers.deals.update` parses its input with `parseWithCustomFields(dealUpdateSchema, rawInput)`
+      // and reads `parsed.id` at the top level (see commands/deals.ts). Wrapping the body in
+      // `{ body: ... }` made `id` undefined and every per-deal call ZodError'd in the bulk
+      // worker, so the job completed with affectedCount=0 in CI (TC-CRM-068/069).
+      await commandBus.execute<Record<string, unknown>, { dealId: string }>(
+        'customers.deals.update',
+        {
+          input: buildBody(id),
+          ctx: commandContext,
+          skipCacheInvalidation: true,
+        },
+      )
+      affectedCount += 1
+      updatedIds.add(id)
+    } catch (error) {
+      const message = error instanceof Error ? error.message : String(error)
+      failedItems.push({ id, message })
+      console.warn(`[${logTag}] failed to update deal`, { jobId: progressJobId, id, error })
+    }
+
+    await progressService.updateProgress(
+      progressJobId,
+      { totalCount: ids.length, processedCount: index + 1 },
+      progressContext,
+    )
+  }
+
+  await runWithCacheTenant(scope.tenantId, async () => {
+    for (const id of updatedIds) {
+      await invalidateCrudCache(
+        container,
+        'customers.deal',
+        { id, organizationId: scope.organizationId, tenantId: scope.tenantId },
+        scope.tenantId,
+        cacheSource,
+        BULK_CACHE_ALIASES,
+      )
+    }
+  })
+
+  const summary: CustomersDealsBulkSummary = {
+    affectedCount,
+    failedCount: failedItems.length,
+    failedItems,
+  }
+  await progressService.completeJob(progressJobId, { resultSummary: summary }, progressContext)
+  return summary
+}
+
+export async function bulkUpdateDealStageWithProgress(params: {
+  container: AwilixContainer
+  progressJobId: string
+  ids: string[]
+  pipelineStageId: string
+  scope: CustomersDealsBulkScope
+}): Promise<CustomersDealsBulkSummary> {
+  // Pre-flight check: verify the target stage exists in the caller's tenant scope before
+  // doing N per-deal command calls. An invalid stage would otherwise produce N identical
+  // failures in `runBulkDealUpdate` and a noisy `failedItems` list.
+  const em = params.container.resolve('em') as CoreEntityManager
+  await verifyPipelineStageExists(em, params.pipelineStageId, params.scope)
+  return runBulkDealUpdate({
+    container: params.container,
+    progressJobId: params.progressJobId,
+    ids: params.ids,
+    scope: params.scope,
+    cacheSource: 'bulk-update-stage:customers.deals',
+    logTag: 'customers.deals.bulk-update-stage',
+    buildBody: (id) => ({ id, pipelineStageId: params.pipelineStageId }),
+  })
+}
+
+export async function bulkUpdateDealOwnerWithProgress(params: {
+  container: AwilixContainer
+  progressJobId: string
+  ids: string[]
+  ownerUserId: string | null
+  scope: CustomersDealsBulkScope
+}): Promise<CustomersDealsBulkSummary> {
+  return runBulkDealUpdate({
+    container: params.container,
+    progressJobId: params.progressJobId,
+    ids: params.ids,
+    scope: params.scope,
+    cacheSource: 'bulk-update-owner:customers.deals',
+    logTag: 'customers.deals.bulk-update-owner',
+    buildBody: (id) => ({ id, ownerUserId: params.ownerUserId }),
+  })
+}

package/src/modules/customers/lib/kysely.ts

@@ -0,0 +1,60 @@
+import type { Kysely } from 'kysely'
+
+/**
+ * Narrow Kysely schema for the customers-module tables used by the kanban helpers
+ * (`stuckDeals`, `enrichers`). Defining the schema locally keeps the queries strongly
+ * typed without forcing a project-wide DB schema declaration. Add columns/tables here
+ * when new customer-module queries need typed access.
+ */
+export interface CustomerKyselyDb {
+  customer_settings: {
+    organization_id: string
+    tenant_id: string
+    stuck_threshold_days: number | string | null
+  }
+  customer_deals: {
+    id: string
+    organization_id: string
+    tenant_id: string
+    deleted_at: Date | string | null
+    created_at: Date | string | null
+  }
+  customer_deal_stage_transitions: {
+    deal_id: string
+    organization_id: string
+    tenant_id: string
+    deleted_at: Date | string | null
+    transitioned_at: Date | string | null
+  }
+  customer_interactions: {
+    deal_id: string | null
+    organization_id: string
+    tenant_id: string
+    deleted_at: Date | string | null
+    status: string | null
+  }
+}
+
+export type CustomerKysely = Kysely<CustomerKyselyDb>
+
+/**
+ * Narrows an EntityManager-like value to a MikroORM v7 PG EntityManager and returns its
+ * Kysely client, or `null` when the value doesn't expose `getKysely`.
+ *
+ * MikroORM v7's `@mikro-orm/postgresql` EntityManager ships `getKysely<TDb>()`, but the
+ * shared `EnricherContext` types `em` as `unknown` to keep the contract DB-agnostic. The
+ * kanban helpers (`stuckDeals`, `enrichers`) both need the typed client — this helper
+ * centralizes the runtime check so neither call site has to repeat `(em as any).getKysely`.
+ *
+ * Returns `null` (rather than throwing) on purpose: callers fall back to a sensible default
+ * (empty stuck-id list, un-enriched records) when the env doesn't have Kysely available
+ * (e.g. unit tests with a stub EntityManager).
+ */
+export function resolveKyselyClient<TDb = CustomerKyselyDb>(em: unknown): Kysely<TDb> | null {
+  if (em == null || typeof em !== 'object') return null
+  const candidate = (em as { getKysely?: unknown }).getKysely
+  if (typeof candidate !== 'function') return null
+  const db = (candidate as () => unknown).call(em)
+  if (db == null) return null
+  return db as Kysely<TDb>
+}

package/src/modules/customers/lib/stuckDeals.ts

@@ -0,0 +1,88 @@
+import type { EntityManager } from '@mikro-orm/postgresql'
+import type { CustomerKysely } from './kysely'
+import { resolveKyselyClient } from './kysely'
+
+/**
+ * Default number of days a deal can sit in a stage before it counts as "stuck".
+ * Tenants can override by writing a row into `customer_settings.stuck_threshold_days`.
+ */
+export const STUCK_DEFAULT_THRESHOLD_DAYS = 14
+const DAY_MS = 24 * 60 * 60 * 1000
+
+/**
+ * Resolves the configured stuck-threshold for the tenant scope. Falls back to
+ * `STUCK_DEFAULT_THRESHOLD_DAYS` when no setting row is present or the value is invalid.
+ */
+export async function fetchStuckThresholdDays(
+  db: CustomerKysely,
+  organizationId: string,
+  tenantId: string,
+): Promise<number> {
+  const row = await db
+    .selectFrom('customer_settings')
+    .select(['stuck_threshold_days'])
+    .where('organization_id', '=', organizationId)
+    .where('tenant_id', '=', tenantId)
+    .executeTakeFirst()
+  const raw = row?.stuck_threshold_days
+  const value = typeof raw === 'number' ? raw : typeof raw === 'string' ? Number(raw) : null
+  if (value !== null && Number.isFinite(value) && value > 0) return value
+  return STUCK_DEFAULT_THRESHOLD_DAYS
+}
+
+/**
+ * Returns the set of deal IDs (in scope) that are currently considered "stuck":
+ *  - deals whose last stage transition was earlier than (now - threshold), OR
+ *  - deals that never transitioned but were created earlier than (now - threshold).
+ *
+ * The list endpoint and the lane-aggregate endpoint MUST share this query so the kanban
+ * lane headers, lane counts, and the rendered cards agree on which deals count as stuck.
+ */
+export async function fetchStuckDealIds(
+  em: EntityManager,
+  organizationId: string,
+  tenantId: string,
+): Promise<string[]> {
+  const db = resolveKyselyClient(em)
+  if (!db) return []
+
+  const threshold = await fetchStuckThresholdDays(db, organizationId, tenantId)
+  const cutoff = new Date(Date.now() - threshold * DAY_MS)
+
+  const oldTransitionRows = await db
+    .selectFrom('customer_deal_stage_transitions')
+    .select(['deal_id'])
+    .select((eb) => eb.fn.max('transitioned_at').as('last_transition'))
+    .where('organization_id', '=', organizationId)
+    .where('tenant_id', '=', tenantId)
+    .where('deleted_at', 'is', null)
+    .groupBy('deal_id')
+    .having((eb) => eb(eb.fn.max('transitioned_at'), '<', cutoff))
+    .execute()
+
+  const transitionedDealIds = await db
+    .selectFrom('customer_deal_stage_transitions')
+    .select(['deal_id'])
+    .distinct()
+    .where('organization_id', '=', organizationId)
+    .where('tenant_id', '=', tenantId)
+    .where('deleted_at', 'is', null)
+    .execute()
+  const transitionedSet = new Set(transitionedDealIds.map((r) => r.deal_id))
+
+  const oldUntransitionedDeals = await db
+    .selectFrom('customer_deals')
+    .select(['id'])
+    .where('organization_id', '=', organizationId)
+    .where('tenant_id', '=', tenantId)
+    .where('deleted_at', 'is', null)
+    .where('created_at', '<', cutoff)
+    .execute()
+
+  const result = new Set<string>()
+  oldTransitionRows.forEach((row) => result.add(row.deal_id))
+  oldUntransitionedDeals.forEach((row) => {
+    if (!transitionedSet.has(row.id)) result.add(row.id)
+  })
+  return Array.from(result)
+}

package/src/modules/customers/migrations/.snapshot-open-mercato.json

@@ -5485,6 +5485,22 @@
           "enumItems": [],
           "mappedType": "uuid"
         },
+        "stuck_threshold_days": {
+          "name": "stuck_threshold_days",
+          "type": "int",
+          "unsigned": false,
+          "autoincrement": false,
+          "primary": false,
+          "nullable": false,
+          "unique": false,
+          "length": null,
+          "precision": null,
+          "scale": null,
+          "default": "14",
+          "comment": null,
+          "enumItems": [],
+          "mappedType": "integer"
+        },
         "tenant_id": {
           "name": "tenant_id",
           "type": "uuid",

package/src/modules/customers/migrations/Migration20260513203311_customers.ts

@@ -0,0 +1,13 @@
+import { Migration } from '@mikro-orm/migrations';
+
+export class Migration20260513203311_customers extends Migration {
+
+  override up(): void | Promise<void> {
+    this.addSql(`alter table "customer_settings" add "stuck_threshold_days" int not null default 14;`);
+  }
+
+  override down(): void | Promise<void> {
+    this.addSql(`alter table "customer_settings" drop column "stuck_threshold_days";`);
+  }
+
+}

package/src/modules/customers/migrations/Migration20260519120000_pipeline_stage_color_tones.ts

@@ -0,0 +1,71 @@
+import { Migration } from '@mikro-orm/migrations';
+
+/**
+ * Migrate `customer_dictionary_entries.color` for `kind = 'pipeline_stage'` rows from the
+ * legacy hex chip values stored by AddStageDialog to canonical semantic tone identifiers
+ * matching Lane.tsx's `ACCENT_TONE_CLASS` map.
+ *
+ * Before this migration:
+ *   AddStageDialog stored a hex value like '#16a34a' / '#f59e0b' / '#dc2626' / '#2563eb' /
+ *   '#6b7280' / '#7c3aed', and Lane.tsx implicitly fell through to gray on every other hex
+ *   because no explicit hex→tone map existed at render time.
+ *
+ * After this migration:
+ *   `color` stores one of: 'success', 'warning', 'info', 'error', 'neutral', 'brand',
+ *   'pink', '', or NULL. Lane.tsx now reads the value directly as a tone identifier.
+ *
+ * Unknown / unmappable hex values collapse to 'neutral'. Forward-only — reverting tones to
+ * the original hex is lossy and not supported. See `.ai/specs/2026-05-19-customers-deals-kanban-ux-review-fixes.md`.
+ */
+export class Migration20260519120000_pipeline_stage_color_tones extends Migration {
+  override up(): void | Promise<void> {
+    this.addSql(`
+      update "customer_dictionary_entries"
+      set "color" = case lower("color")
+        when '#16a34a' then 'success'
+        when '#22c55e' then 'success'
+        when '#15803d' then 'success'
+        when '#10b981' then 'success'
+        when '#059669' then 'success'
+        when '#f59e0b' then 'warning'
+        when '#eab308' then 'warning'
+        when '#d97706' then 'warning'
+        when '#f97316' then 'warning'
+        when '#ea580c' then 'warning'
+        when '#dc2626' then 'error'
+        when '#ef4444' then 'error'
+        when '#b91c1c' then 'error'
+        when '#991b1b' then 'error'
+        when '#2563eb' then 'info'
+        when '#3b82f6' then 'info'
+        when '#0ea5e9' then 'info'
+        when '#1d4ed8' then 'info'
+        when '#6366f1' then 'info'
+        when '#6b7280' then 'neutral'
+        when '#9ca3af' then 'neutral'
+        when '#4b5563' then 'neutral'
+        when '#374151' then 'neutral'
+        when '#1f2937' then 'neutral'
+        when '#7c3aed' then 'brand'
+        when '#8b5cf6' then 'brand'
+        when '#a855f7' then 'brand'
+        when '#9333ea' then 'brand'
+        when '#ec4899' then 'pink'
+        when '#f472b6' then 'pink'
+        when '#db2777' then 'pink'
+        when '#be185d' then 'pink'
+        when '' then ''
+        else 'neutral'
+      end
+      where "kind" = 'pipeline_stage'
+        and "color" is not null;
+    `);
+  }
+
+  override down(): void | Promise<void> {
+    // Forward-only migration. Reverting tone identifiers to their original hex values is
+    // lossy (we only kept the closest tone, not the source hex) and would not restore the
+    // pre-migration state. Operators wanting to change a stage color should reopen the
+    // AddStageDialog tone picker.
+  }
+}

package/src/modules/customers/workers/deals-bulk-update-owner.ts

@@ -0,0 +1,46 @@
+import type { JobContext, QueuedJob, WorkerMeta } from '@open-mercato/queue'
+import { createRequestContainer } from '@open-mercato/shared/lib/di/container'
+import type { ProgressService } from '../../progress/lib/progressService'
+import {
+  CUSTOMERS_DEALS_BULK_UPDATE_OWNER_QUEUE,
+  bulkUpdateDealOwnerWithProgress,
+  type CustomersDealsBulkUpdateOwnerJobPayload,
+} from '../lib/bulkDeals'
+
+export const metadata: WorkerMeta = {
+  queue: CUSTOMERS_DEALS_BULK_UPDATE_OWNER_QUEUE,
+  id: 'customers:deals-bulk-update-owner',
+  concurrency: 1,
+}
+
+export default async function handle(
+  job: QueuedJob<CustomersDealsBulkUpdateOwnerJobPayload>,
+  _ctx: JobContext,
+): Promise<void> {
+  const container = await createRequestContainer()
+
+  try {
+    await bulkUpdateDealOwnerWithProgress({
+      container,
+      progressJobId: job.payload.progressJobId,
+      ids: job.payload.ids,
+      ownerUserId: job.payload.ownerUserId,
+      scope: job.payload.scope,
+    })
+  } catch (error) {
+    const progressService = container.resolve('progressService') as ProgressService
+    await progressService.failJob(
+      job.payload.progressJobId,
+      {
+        errorMessage:
+          error instanceof Error ? error.message : 'Bulk deal owner update failed',
+      },
+      {
+        tenantId: job.payload.scope.tenantId,
+        organizationId: job.payload.scope.organizationId,
+        userId: job.payload.scope.userId,
+      },
+    )
+    throw error
+  }
+}

package/src/modules/customers/workers/deals-bulk-update-stage.ts

@@ -0,0 +1,46 @@
+import type { JobContext, QueuedJob, WorkerMeta } from '@open-mercato/queue'
+import { createRequestContainer } from '@open-mercato/shared/lib/di/container'
+import type { ProgressService } from '../../progress/lib/progressService'
+import {
+  CUSTOMERS_DEALS_BULK_UPDATE_STAGE_QUEUE,
+  bulkUpdateDealStageWithProgress,
+  type CustomersDealsBulkUpdateStageJobPayload,
+} from '../lib/bulkDeals'
+
+export const metadata: WorkerMeta = {
+  queue: CUSTOMERS_DEALS_BULK_UPDATE_STAGE_QUEUE,
+  id: 'customers:deals-bulk-update-stage',
+  concurrency: 1,
+}
+
+export default async function handle(
+  job: QueuedJob<CustomersDealsBulkUpdateStageJobPayload>,
+  _ctx: JobContext,
+): Promise<void> {
+  const container = await createRequestContainer()
+
+  try {
+    await bulkUpdateDealStageWithProgress({
+      container,
+      progressJobId: job.payload.progressJobId,
+      ids: job.payload.ids,
+      pipelineStageId: job.payload.pipelineStageId,
+      scope: job.payload.scope,
+    })
+  } catch (error) {
+    const progressService = container.resolve('progressService') as ProgressService
+    await progressService.failJob(
+      job.payload.progressJobId,
+      {
+        errorMessage:
+          error instanceof Error ? error.message : 'Bulk deal stage update failed',
+      },
+      {
+        tenantId: job.payload.scope.tenantId,
+        organizationId: job.payload.scope.organizationId,
+        userId: job.payload.scope.userId,
+      },
+    )
+    throw error
+  }
+}