@open-agent-toolkit/cli 0.0.10

package/assets/skills/oat-project-subagent-implement/tests/test-reconcile.sh

@@ -0,0 +1,254 @@
+#!/usr/bin/env bash
+# Test: Parallel worktree execution and reconciliation
+#
+# Validates that reconcile.sh correctly merges two non-conflicting unit
+# branches into an orchestration branch in deterministic order.
+#
+# Creates a temporary git repo with simulated parallel unit branches,
+# then runs reconcile.sh to merge them.
+#
+# Usage: bash tests/test-reconcile.sh
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+PASS=0
+FAIL=0
+
+assert_contains() {
+  local label="$1" output="$2" expected="$3"
+  if echo "$output" | grep -qF -- "$expected"; then
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $label — expected to contain: $expected"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+# ─── Setup Temporary Git Repo ──────────────────────────────────────────────
+TMPDIR=$(mktemp -d)
+trap 'rm -rf "$TMPDIR"' EXIT
+
+cd "$TMPDIR"
+git init -b orchestration-branch
+git config user.email "test@test.com"
+git config user.name "Test"
+
+# Create initial commit on orchestration branch
+echo '{ "name": "test-project" }' > package.json
+cat > .npmrc <<'NPMRC'
+# placeholder
+NPMRC
+git add .
+git commit -m "initial commit"
+
+# ─── Create Unit Branch p01 (non-conflicting files) ───────────────────────
+git checkout -b "project/p01"
+mkdir -p src/models
+echo 'export const User = { id: 1, name: "test" };' > src/models/user.ts
+echo 'test("user", () => {});' > src/models/user.test.ts
+git add .
+git commit -m "feat(p01-t01): create user model"
+
+echo 'export const Settings = { key: "theme" };' > src/models/settings.ts
+git add .
+git commit -m "feat(p01-t02): create settings model"
+
+# ─── Create Unit Branch p02 (non-conflicting files) ───────────────────────
+git checkout orchestration-branch
+git checkout -b "project/p02"
+mkdir -p src/routes
+echo 'export const userRoute = "/api/user";' > src/routes/user.ts
+echo 'test("user route", () => {});' > src/routes/user.test.ts
+git add .
+git commit -m "feat(p02-t01): create user API endpoint"
+
+echo 'export const settingsRoute = "/api/settings";' > src/routes/settings.ts
+git add .
+git commit -m "feat(p02-t02): create settings API endpoint"
+
+# ─── Return to orchestration branch ───────────────────────────────────────
+git checkout orchestration-branch
+
+echo "=== Test: Reconcile Two Non-Conflicting Unit Branches ==="
+echo ""
+
+# ─── Run Reconcile ────────────────────────────────────────────────────────
+# Note: reconcile.sh runs pnpm test/lint/type-check for integration verification.
+# In this test repo those commands don't exist, so they'll "fail" but
+# the merge itself should succeed. We override by creating stub scripts.
+cat > run-checks.sh <<'STUB'
+#!/bin/bash
+exit 0
+STUB
+chmod +x run-checks.sh
+
+# Create package.json with stub test/lint/type-check scripts
+cat > package.json <<'PKG'
+{
+  "name": "test-project",
+  "scripts": {
+    "test": "exit 0",
+    "lint": "exit 0",
+    "type-check": "exit 0"
+  }
+}
+PKG
+git add .
+git commit -m "chore: add stub scripts for integration verification"
+
+# Capture reconcile output (need to handle pnpm not being in PATH for stubs)
+# Override pnpm with a shim
+mkdir -p "$TMPDIR/bin"
+cat > "$TMPDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+exit 0
+SHIM
+chmod +x "$TMPDIR/bin/pnpm"
+export PATH="$TMPDIR/bin:$PATH"
+
+RECONCILE_OUTPUT=$(bash "$SKILL_DIR/scripts/reconcile.sh" orchestration-branch "project/p01" "project/p02" 2>&1)
+
+echo "$RECONCILE_OUTPUT"
+echo ""
+
+# ─── Assertions ───────────────────────────────────────────────────────────
+echo "--- Assertions ---"
+assert_contains "has reconcile_manifest marker" "$RECONCILE_OUTPUT" "--- reconcile_manifest ---"
+assert_contains "orchestration_branch correct" "$RECONCILE_OUTPUT" "orchestration_branch: orchestration-branch"
+assert_contains "unit_count is 2" "$RECONCILE_OUTPUT" "unit_count: 2"
+assert_contains "p01 merged first (order 1)" "$RECONCILE_OUTPUT" "order: 1"
+assert_contains "p02 merged second (order 2)" "$RECONCILE_OUTPUT" "order: 2"
+assert_contains "p01 result clean" "$RECONCILE_OUTPUT" "result: clean"
+assert_contains "merged count is 2" "$RECONCILE_OUTPUT" "merged: 2"
+assert_contains "conflicts is 0" "$RECONCILE_OUTPUT" "conflicts: 0"
+assert_contains "reverted is 0" "$RECONCILE_OUTPUT" "reverted: 0"
+
+# Verify files exist on orchestration branch after merge
+git checkout orchestration-branch 2>/dev/null
+if [[ -f src/models/user.ts && -f src/routes/user.ts ]]; then
+  echo "  PASS: both unit files present after reconciliation"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: missing files after reconciliation"
+  FAIL=$((FAIL + 1))
+fi
+
+# Verify deterministic ordering (p01 before p02)
+MERGE_LOG=$(git log --oneline --all | head -20)
+if echo "$MERGE_LOG" | grep -q "merge(p01)"; then
+  echo "  PASS: p01 merge commit present"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: p01 merge commit not found"
+  FAIL=$((FAIL + 1))
+fi
+
+if echo "$MERGE_LOG" | grep -q "merge(p02)"; then
+  echo "  PASS: p02 merge commit present"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: p02 merge commit not found"
+  FAIL=$((FAIL + 1))
+fi
+
+# ─── Test 2: Failing Integration Rollback ─────────────────────────────
+echo ""
+echo "=== Test 2: Failing Integration Rollback ==="
+echo ""
+
+# Create a fresh temp repo for the rollback test
+TMPDIR2=$(mktemp -d)
+SHIMDIR2=$(mktemp -d)
+# Update trap to clean both
+trap 'rm -rf "$TMPDIR" "$TMPDIR2" "$SHIMDIR2"' EXIT
+
+cd "$TMPDIR2"
+git init -b orchestration-branch
+git config user.email "test@test.com"
+git config user.name "Test"
+
+# Initial commit
+echo '{ "name": "rollback-test" }' > package.json
+git add .
+git commit -m "initial commit"
+
+# Record the initial HEAD (should match post-rollback)
+INITIAL_SHA=$(git rev-parse HEAD)
+
+# Create a unit branch with a new file
+git checkout -b "project/p01"
+echo 'export const Broken = true;' > broken-feature.ts
+git add .
+git commit -m "feat(p01): add broken feature"
+git checkout orchestration-branch
+
+# Create pnpm shim OUTSIDE git repo that fails on 'test'
+mkdir -p "$SHIMDIR2/bin"
+cat > "$SHIMDIR2/bin/pnpm" <<'SHIM'
+#!/bin/bash
+case "$1" in
+  test) exit 1 ;;
+  *) exit 0 ;;
+esac
+SHIM
+chmod +x "$SHIMDIR2/bin/pnpm"
+export PATH="$SHIMDIR2/bin:$PATH"
+
+ROLLBACK_OUTPUT=$(bash "$SKILL_DIR/scripts/reconcile.sh" orchestration-branch "project/p01" 2>&1)
+
+echo "$ROLLBACK_OUTPUT"
+echo ""
+echo "--- Assertions ---"
+
+# The merge should be reverted
+assert_contains "result is reverted" "$ROLLBACK_OUTPUT" "result: reverted"
+assert_contains "integration verdict fail" "$ROLLBACK_OUTPUT" "verdict: fail"
+assert_contains "reverted count is 1" "$ROLLBACK_OUTPUT" "reverted: 1"
+assert_contains "merged count is 0" "$ROLLBACK_OUTPUT" "merged: 0"
+
+# The merged file should NOT exist after rollback
+if [[ ! -f "$TMPDIR2/broken-feature.ts" ]]; then
+  echo "  PASS: merged file absent after rollback"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: merged file still present after rollback"
+  FAIL=$((FAIL + 1))
+fi
+
+# HEAD should match pre-merge state
+POST_ROLLBACK_SHA=$(git rev-parse HEAD)
+if [[ "$POST_ROLLBACK_SHA" == "$INITIAL_SHA" ]]; then
+  echo "  PASS: HEAD matches pre-merge SHA after rollback"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: HEAD ($POST_ROLLBACK_SHA) does not match pre-merge ($INITIAL_SHA)"
+  FAIL=$((FAIL + 1))
+fi
+
+# Verify file content integrity: package.json should have original content
+ROLLBACK_PKG=$(cat "$TMPDIR2/package.json")
+if [[ "$ROLLBACK_PKG" == '{ "name": "rollback-test" }' ]]; then
+  echo "  PASS: package.json content restored after rollback"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: package.json content differs after rollback: $ROLLBACK_PKG"
+  FAIL=$((FAIL + 1))
+fi
+
+# Restore PATH for subsequent tests
+export PATH="${PATH#$SHIMDIR2/bin:}"
+
+echo ""
+echo "=== Results ==="
+echo "Passed: $PASS"
+echo "Failed: $FAIL"
+
+if [[ $FAIL -gt 0 ]]; then
+  echo "OVERALL: FAIL"
+  exit 1
+else
+  echo "OVERALL: PASS"
+fi

package/assets/skills/oat-project-subagent-implement/tests/test-review-gate.sh

@@ -0,0 +1,220 @@
+#!/usr/bin/env bash
+# Test: Autonomous review gate blocks failed units
+#
+# Validates that review-gate.sh correctly:
+# 1. Passes units with clean state
+# 2. Fails units with failing tests (spec compliance)
+# 3. Fails units with lint errors (code quality)
+# 4. Produces correct verdicts and fix-loop hints
+#
+# Usage: bash tests/test-review-gate.sh
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+PASS=0
+FAIL=0
+
+assert_contains() {
+  local label="$1" output="$2" expected="$3"
+  if echo "$output" | grep -qF -- "$expected"; then
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $label — expected to contain: $expected"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+assert_not_contains() {
+  local label="$1" output="$2" unexpected="$3"
+  if echo "$output" | grep -qF -- "$unexpected"; then
+    echo "  FAIL: $label — should NOT contain: $unexpected"
+    FAIL=$((FAIL + 1))
+  else
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  fi
+}
+
+# ─── Setup Temporary Git Repo ──────────────────────────────────────────────
+TMPDIR=$(mktemp -d)
+SHIMDIR=$(mktemp -d)
+trap 'rm -rf "$TMPDIR" "$SHIMDIR"' EXIT
+
+cd "$TMPDIR"
+git init -b test-branch
+git config user.email "test@test.com"
+git config user.name "Test"
+
+echo '{ "name": "test" }' > package.json
+git add .
+git commit -m "initial"
+
+# ─── Test 1: Passing Unit (clean state) ───────────────────────────────────
+echo "=== Test 1: Passing Unit (all checks pass) ==="
+echo ""
+
+# Create pnpm shim OUTSIDE the git repo so git status stays clean
+mkdir -p "$SHIMDIR/bin"
+cat > "$SHIMDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+exit 0
+SHIM
+chmod +x "$SHIMDIR/bin/pnpm"
+export PATH="$SHIMDIR/bin:$PATH"
+
+PASS_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 2>&1)
+
+echo "--- Output ---"
+echo "$PASS_OUTPUT" | head -20
+echo ""
+echo "--- Assertions ---"
+assert_contains "spec verdict pass" "$PASS_OUTPUT" "spec_verdict: pass"
+assert_contains "quality verdict pass" "$PASS_OUTPUT" "quality_verdict: pass"
+assert_contains "overall pass" "$PASS_OUTPUT" "overall: pass"
+assert_contains "eligible for merge" "$PASS_OUTPUT" "disposition: eligible_for_merge"
+assert_contains "finalize action" "$PASS_OUTPUT" "action: finalize"
+
+echo ""
+
+# ─── Test 2: Failing Tests (spec compliance failure) ──────────────────────
+echo "=== Test 2: Failing Tests (spec compliance failure) ==="
+echo ""
+
+# Override pnpm test to fail
+cat > "$SHIMDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+case "$1" in
+  test) exit 1 ;;
+  *) exit 0 ;;
+esac
+SHIM
+chmod +x "$SHIMDIR/bin/pnpm"
+
+FAIL_TEST_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 2>&1)
+
+echo "--- Output ---"
+echo "$FAIL_TEST_OUTPUT" | head -20
+echo ""
+echo "--- Assertions ---"
+assert_contains "tests fail" "$FAIL_TEST_OUTPUT" "tests: fail"
+assert_contains "spec verdict fail" "$FAIL_TEST_OUTPUT" "spec_verdict: fail"
+assert_contains "overall fail" "$FAIL_TEST_OUTPUT" "overall: fail"
+assert_contains "needs fix or exclude" "$FAIL_TEST_OUTPUT" "disposition: needs_fix_or_exclude"
+assert_contains "retry action (under limit)" "$FAIL_TEST_OUTPUT" "action: retry"
+assert_contains "next retry count" "$FAIL_TEST_OUTPUT" "next_retry_count: 1"
+# Code quality stage should NOT run when spec fails
+assert_not_contains "quality stage skipped" "$FAIL_TEST_OUTPUT" "quality_verdict: pass"
+
+echo ""
+
+# ─── Test 3: Lint Failure (code quality failure) ──────────────────────────
+echo "=== Test 3: Lint Failure (code quality failure, spec passes) ==="
+echo ""
+
+# Override pnpm lint to fail, but test passes
+cat > "$SHIMDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+case "$1" in
+  lint) exit 1 ;;
+  *) exit 0 ;;
+esac
+SHIM
+chmod +x "$SHIMDIR/bin/pnpm"
+
+FAIL_LINT_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 2>&1)
+
+echo "--- Output ---"
+echo "$FAIL_LINT_OUTPUT" | head -25
+echo ""
+echo "--- Assertions ---"
+assert_contains "spec verdict pass" "$FAIL_LINT_OUTPUT" "spec_verdict: pass"
+assert_contains "lint fail" "$FAIL_LINT_OUTPUT" "lint: fail"
+assert_contains "quality verdict fail" "$FAIL_LINT_OUTPUT" "quality_verdict: fail"
+assert_contains "overall fail" "$FAIL_LINT_OUTPUT" "overall: fail"
+assert_contains "retry action (under limit)" "$FAIL_LINT_OUTPUT" "action: retry"
+
+echo ""
+
+# ─── Test 4: Uncommitted Changes (git clean failure) ─────────────────────
+echo "=== Test 4: Uncommitted Changes (git clean failure) ==="
+echo ""
+
+# Restore passing pnpm but leave uncommitted file
+cat > "$SHIMDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+exit 0
+SHIM
+chmod +x "$SHIMDIR/bin/pnpm"
+
+echo "dirty" > "$TMPDIR/uncommitted.txt"
+
+DIRTY_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 2>&1)
+
+echo "--- Output ---"
+echo "$DIRTY_OUTPUT" | head -20
+echo ""
+echo "--- Assertions ---"
+assert_contains "git clean fail" "$DIRTY_OUTPUT" "git_clean: fail"
+assert_contains "spec verdict fail" "$DIRTY_OUTPUT" "spec_verdict: fail"
+assert_contains "overall fail" "$DIRTY_OUTPUT" "overall: fail"
+
+# Clean up
+rm -f "$TMPDIR/uncommitted.txt"
+
+echo ""
+
+# ─── Test 5: Retry at limit (dispatch_fix terminal) ──────────────────
+echo "=== Test 5: Retry at limit (dispatch_fix terminal) ==="
+echo ""
+
+# Failing pnpm test, retry_count == retry_limit
+cat > "$SHIMDIR/bin/pnpm" <<'SHIM'
+#!/bin/bash
+case "$1" in
+  test) exit 1 ;;
+  *) exit 0 ;;
+esac
+SHIM
+chmod +x "$SHIMDIR/bin/pnpm"
+
+AT_LIMIT_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 --retry-count 2 2>&1)
+
+echo "--- Output ---"
+echo "$AT_LIMIT_OUTPUT" | head -25
+echo ""
+echo "--- Assertions ---"
+assert_contains "overall fail" "$AT_LIMIT_OUTPUT" "overall: fail"
+assert_contains "retry_count is 2" "$AT_LIMIT_OUTPUT" "retry_count: 2"
+assert_contains "dispatch_fix at limit" "$AT_LIMIT_OUTPUT" "action: dispatch_fix"
+assert_not_contains "no next_retry_count at limit" "$AT_LIMIT_OUTPUT" "next_retry_count:"
+
+echo ""
+
+# ─── Test 6: Retry under limit (retry with next count) ───────────────
+echo "=== Test 6: Retry under limit (retry with next count) ==="
+echo ""
+
+UNDER_LIMIT_OUTPUT=$(bash "$SKILL_DIR/scripts/review-gate.sh" "test-branch" "$TMPDIR" --retry-limit 2 --retry-count 1 2>&1)
+
+echo "--- Output ---"
+echo "$UNDER_LIMIT_OUTPUT" | head -25
+echo ""
+echo "--- Assertions ---"
+assert_contains "retry_count is 1" "$UNDER_LIMIT_OUTPUT" "retry_count: 1"
+assert_contains "action is retry" "$UNDER_LIMIT_OUTPUT" "action: retry"
+assert_contains "next_retry_count is 2" "$UNDER_LIMIT_OUTPUT" "next_retry_count: 2"
+
+echo ""
+echo "=== Results ==="
+echo "Passed: $PASS"
+echo "Failed: $FAIL"
+
+if [[ $FAIL -gt 0 ]]; then
+  echo "OVERALL: FAIL"
+  exit 1
+else
+  echo "OVERALL: PASS"
+fi