@open-agent-toolkit/cli 0.0.10

package/assets/skills/oat-project-subagent-implement/tests/fixtures/sample-plan.md

@@ -0,0 +1,234 @@
+---
+oat_status: complete
+oat_ready_for: oat-project-implement
+oat_blockers: []
+oat_last_updated: 2026-02-17
+oat_phase: plan
+oat_phase_status: complete
+oat_plan_hill_phases: ['p04']
+oat_plan_source: test
+oat_generated: false
+---
+
+# Implementation Plan: Sample Multi-Phase Project
+
+> Test fixture for orchestration validation.
+
+**Goal:** Validate orchestration dispatch, review, and reconcile logic.
+
+**Commit Convention:** `feat({scope}): {description}`
+
+## Planning Checklist
+
+- [x] Confirmed HiLL checkpoints with user
+- [x] Set `oat_plan_hill_phases` in frontmatter
+
+---
+
+## Phase 1: Data Models
+
+### Task p01-t01: Create user model
+
+**Files:**
+
+- Create: `src/models/user.ts`
+- Create: `src/models/user.test.ts`
+
+**Step 1: Define acceptance criteria (RED)**
+
+Run: `test -f src/models/user.ts && echo "exists"`
+Expected: File does not exist yet
+
+**Step 2: Implement (GREEN)**
+
+Create user model with id, name, email fields.
+
+**Step 3: Verify**
+
+Run: `pnpm test`
+Expected: Tests pass
+
+**Step 4: Commit**
+
+```bash
+git add src/models/
+git commit -m "feat(p01-t01): create user model"
+```
+
+---
+
+### Task p01-t02: Create settings model
+
+**Files:**
+
+- Create: `src/models/settings.ts`
+- Create: `src/models/settings.test.ts`
+
+**Step 1: Define acceptance criteria (RED)**
+
+Run: `test -f src/models/settings.ts && echo "exists"`
+Expected: File does not exist yet
+
+**Step 2: Implement (GREEN)**
+
+Create settings model with key, value, scope fields.
+
+**Step 3: Verify**
+
+Run: `pnpm test`
+Expected: Tests pass
+
+**Step 4: Commit**
+
+```bash
+git add src/models/
+git commit -m "feat(p01-t02): create settings model"
+```
+
+---
+
+## Phase 2: API Routes
+
+### Task p02-t01: Create user API endpoint
+
+**Files:**
+
+- Create: `src/routes/user.ts`
+- Create: `src/routes/user.test.ts`
+
+**Step 1: Define acceptance criteria (RED)**
+
+Run: `test -f src/routes/user.ts && echo "exists"`
+Expected: File does not exist yet
+
+**Step 2: Implement (GREEN)**
+
+Create GET/POST endpoints for user CRUD.
+
+**Step 3: Verify**
+
+Run: `pnpm test`
+Expected: Tests pass
+
+**Step 4: Commit**
+
+```bash
+git add src/routes/
+git commit -m "feat(p02-t01): create user API endpoint"
+```
+
+---
+
+### Task p02-t02: Create settings API endpoint
+
+**Files:**
+
+- Create: `src/routes/settings.ts`
+- Create: `src/routes/settings.test.ts`
+
+**Step 1: Define acceptance criteria (RED)**
+
+Run: `test -f src/routes/settings.ts && echo "exists"`
+Expected: File does not exist yet
+
+**Step 2: Implement (GREEN)**
+
+Create GET/PUT endpoints for settings management.
+
+**Step 3: Verify**
+
+Run: `pnpm test`
+Expected: Tests pass
+
+**Step 4: Commit**
+
+```bash
+git add src/routes/
+git commit -m "feat(p02-t02): create settings API endpoint"
+```
+
+---
+
+## Phase 3: Business Logic
+
+### Task p03-t01: Implement user validation rules
+
+**Files:**
+
+- Create: `src/validation/user.ts`
+- Create: `src/validation/user.test.ts`
+
+**Step 1: Implement (GREEN)**
+
+Create email and name validation.
+
+**Step 2: Verify**
+
+Run: `pnpm test`
+Expected: Tests pass
+
+**Step 3: Commit**
+
+```bash
+git add src/validation/
+git commit -m "feat(p03-t01): implement user validation rules"
+```
+
+---
+
+## Phase 4: Integration
+
+### Task p04-t01: Wire models to routes with validation
+
+**Files:**
+
+- Modify: `src/routes/user.ts`
+- Modify: `src/models/user.ts`
+- Modify: `src/validation/user.ts`
+
+**Step 1: Implement (GREEN)**
+
+Connect user model, route, and validation into integrated flow.
+
+**Step 2: Verify**
+
+Run: `pnpm test`
+Expected: All integration tests pass
+
+**Step 3: Commit**
+
+```bash
+git add src/
+git commit -m "feat(p04-t01): wire models to routes with validation"
+```
+
+---
+
+## Reviews
+
+| Scope | Type | Status  | Date | Artifact |
+| ----- | ---- | ------- | ---- | -------- |
+| p01   | code | pending | -    | -        |
+| p02   | code | pending | -    | -        |
+| p03   | code | pending | -    | -        |
+| p04   | code | pending | -    | -        |
+| final | code | pending | -    | -        |
+
+---
+
+## Implementation Complete
+
+**Summary:**
+
+- Phase 1: 2 tasks - Data models
+- Phase 2: 2 tasks - API routes
+- Phase 3: 1 task - Business logic
+- Phase 4: 1 task - Integration
+
+**Total: 6 tasks**
+
+---
+
+## References
+
+- Design: N/A (test fixture)

package/assets/skills/oat-project-subagent-implement/tests/test-dry-run.sh

@@ -0,0 +1,126 @@
+#!/usr/bin/env bash
+# Test: Dry-run orchestration on sample multi-phase plan
+#
+# Validates that dispatch.sh correctly parses a sample plan and produces
+# a well-formed dispatch manifest at both phase-level and task-level granularity.
+#
+# Usage: bash tests/test-dry-run.sh
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+FIXTURES_DIR="$SCRIPT_DIR/fixtures"
+PLAN_PATH="$FIXTURES_DIR/sample-plan.md"
+PROJECT_PATH="$FIXTURES_DIR"
+
+PASS=0
+FAIL=0
+
+assert_contains() {
+  local label="$1" output="$2" expected="$3"
+  if echo "$output" | grep -qF -- "$expected"; then
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $label — expected to contain: $expected"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+assert_not_contains() {
+  local label="$1" output="$2" unexpected="$3"
+  if echo "$output" | grep -qF -- "$unexpected"; then
+    echo "  FAIL: $label — should NOT contain: $unexpected"
+    FAIL=$((FAIL + 1))
+  else
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  fi
+}
+
+assert_line_count() {
+  local label="$1" output="$2" pattern="$3" expected="$4"
+  local actual
+  actual=$(echo "$output" | grep -c "$pattern" || true)
+  if [[ "$actual" -eq "$expected" ]]; then
+    echo "  PASS: $label (count=$actual)"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $label — expected $expected occurrences of '$pattern', got $actual"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+echo "=== Test: Dry-Run Dispatch (Phase-Level) ==="
+echo ""
+
+PHASE_OUTPUT=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$PLAN_PATH" "$PROJECT_PATH" "test-branch" --unit-granularity phase 2>&1)
+
+echo "--- Phase-level manifest ---"
+assert_contains "has dispatch_manifest marker" "$PHASE_OUTPUT" "--- dispatch_manifest ---"
+assert_contains "orchestration_branch is test-branch" "$PHASE_OUTPUT" "orchestration_branch: test-branch"
+assert_contains "unit_granularity is phase" "$PHASE_OUTPUT" "unit_granularity: phase"
+assert_contains "has log_path" "$PHASE_OUTPUT" "log_path:"
+assert_line_count "identifies 4 phases" "$PHASE_OUTPUT" "type: phase" 4
+assert_contains "phase p01 present" "$PHASE_OUTPUT" 'unit_id: "p01"'
+assert_contains "phase p02 present" "$PHASE_OUTPUT" 'unit_id: "p02"'
+assert_contains "phase p03 present" "$PHASE_OUTPUT" 'unit_id: "p03"'
+assert_contains "phase p04 present" "$PHASE_OUTPUT" 'unit_id: "p04"'
+assert_contains "HiLL checkpoints extracted" "$PHASE_OUTPUT" "hill_checkpoints:"
+assert_contains "branch naming pattern" "$PHASE_OUTPUT" "branch_naming:"
+
+echo ""
+echo "=== Test: Dry-Run Dispatch (Task-Level) ==="
+echo ""
+
+TASK_OUTPUT=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$PLAN_PATH" "$PROJECT_PATH" "test-branch" --unit-granularity task 2>&1)
+
+echo "--- Task-level manifest ---"
+assert_contains "unit_granularity is task" "$TASK_OUTPUT" "unit_granularity: task"
+assert_line_count "identifies 6 tasks" "$TASK_OUTPUT" "type: task" 6
+assert_contains "task p01-t01 present" "$TASK_OUTPUT" 'unit_id: "p01-t01"'
+assert_contains "task p01-t02 present" "$TASK_OUTPUT" 'unit_id: "p01-t02"'
+assert_contains "task p02-t01 present" "$TASK_OUTPUT" 'unit_id: "p02-t01"'
+assert_contains "task p02-t02 present" "$TASK_OUTPUT" 'unit_id: "p02-t02"'
+assert_contains "task p03-t01 present" "$TASK_OUTPUT" 'unit_id: "p03-t01"'
+assert_contains "task p04-t01 present" "$TASK_OUTPUT" 'unit_id: "p04-t01"'
+assert_contains "branch naming examples" "$TASK_OUTPUT" "examples:"
+
+echo ""
+echo "=== Test: Manifest YAML Structure ==="
+echo ""
+
+# Phase-level: tasks: should be block sequence header (no [])
+# When tasks are present, should NOT have "tasks: []" followed by list items
+assert_not_contains "no inline empty array before tasks" "$PHASE_OUTPUT" "tasks: []"
+
+# tasks: header (block sequence) should appear for each phase
+assert_line_count "tasks: header per phase" "$PHASE_OUTPUT" "    tasks:" 4
+
+# Task items should be indented under tasks:
+assert_contains "task item indented under phase" "$PHASE_OUTPUT" '      - "p01-t01"'
+
+# Manifest delimiters: open and close markers are present and properly structured
+assert_contains "manifest open marker" "$PHASE_OUTPUT" "--- dispatch_manifest ---"
+# Closing delimiter: should end with bare "---" (from dispatch.sh line after hill_checkpoints)
+LAST_DASHES=$(echo "$PHASE_OUTPUT" | grep -c '^---$' || true)
+if [[ "$LAST_DASHES" -ge 1 ]]; then
+  echo "  PASS: manifest closing delimiter present"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: manifest closing delimiter missing"
+  FAIL=$((FAIL + 1))
+fi
+
+echo ""
+echo "=== Results ==="
+echo "Passed: $PASS"
+echo "Failed: $FAIL"
+
+if [[ $FAIL -gt 0 ]]; then
+  echo "OVERALL: FAIL"
+  exit 1
+else
+  echo "OVERALL: PASS"
+fi

package/assets/skills/oat-project-subagent-implement/tests/test-hill-checkpoint.sh

@@ -0,0 +1,127 @@
+#!/usr/bin/env bash
+# Test: HiLL checkpoint behavior
+#
+# Validates that dispatch.sh correctly extracts oat_plan_hill_phases from
+# plan frontmatter and that the orchestrator can determine checkpoint boundaries.
+#
+# Scenarios:
+# 1. Plan with HiLL at p04 — all phases run, pause after p04 completes
+# 2. Plan with HiLL at p02 — p01-p02 run, pause after p02 completes
+# 3. Plan with no HiLL — default behavior (pause after every phase)
+#
+# Usage: bash tests/test-hill-checkpoint.sh
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
+FIXTURES_DIR="$SCRIPT_DIR/fixtures"
+PASS=0
+FAIL=0
+
+assert_contains() {
+  local label="$1" output="$2" expected="$3"
+  if echo "$output" | grep -qF -- "$expected"; then
+    echo "  PASS: $label"
+    PASS=$((PASS + 1))
+  else
+    echo "  FAIL: $label — expected to contain: $expected"
+    FAIL=$((FAIL + 1))
+  fi
+}
+
+# ─── Test 1: HiLL at p04 ──────────────────────────────────────────────────
+echo "=== Test 1: HiLL checkpoint at p04 ==="
+echo ""
+
+OUTPUT_1=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$FIXTURES_DIR/sample-plan.md" "$FIXTURES_DIR" "test-branch" 2>&1)
+
+# Extract HiLL checkpoints line
+HIL_LINE_1=$(echo "$OUTPUT_1" | grep "hill_checkpoints:")
+assert_contains "extracts hill_checkpoints" "$HIL_LINE_1" "hill_checkpoints:"
+# The sample-plan.md has oat_plan_hill_phases: ['p04']
+assert_contains "contains p04 checkpoint" "$HIL_LINE_1" "p04"
+
+echo ""
+
+# ─── Test 2: HiLL at p02 (modified fixture) ───────────────────────────────
+echo "=== Test 2: HiLL checkpoint at p02 ==="
+echo ""
+
+# Create a modified fixture with HiLL at p02
+TMPDIR=$(mktemp -d)
+trap 'rm -rf "$TMPDIR"' EXIT
+
+sed -E "s|oat_plan_hill_phases: \[[^]]*\]|oat_plan_hill_phases: ['p02']|" "$FIXTURES_DIR/sample-plan.md" > "$TMPDIR/plan-hil-p02.md"
+
+OUTPUT_2=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$TMPDIR/plan-hil-p02.md" "$TMPDIR" "test-branch" 2>&1)
+
+HIL_LINE_2=$(echo "$OUTPUT_2" | grep "hill_checkpoints:")
+assert_contains "extracts p02 checkpoint" "$HIL_LINE_2" "p02"
+
+echo ""
+
+# ─── Test 3: No HiLL phases (empty) ───────────────────────────────────────
+echo "=== Test 3: No HiLL phases (empty array) ==="
+echo ""
+
+sed -E "s|oat_plan_hill_phases: \[[^]]*\]|oat_plan_hill_phases: []|" "$FIXTURES_DIR/sample-plan.md" > "$TMPDIR/plan-no-hil.md"
+
+OUTPUT_3=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$TMPDIR/plan-no-hil.md" "$TMPDIR" "test-branch" 2>&1)
+
+HIL_LINE_3=$(echo "$OUTPUT_3" | grep "hill_checkpoints:")
+assert_contains "extracts empty hill_checkpoints" "$HIL_LINE_3" "hill_checkpoints: []"
+
+echo ""
+
+# ─── Test 4: Validate partition logic (script-level) ─────────────────────
+echo "=== Test 4: Validate checkpoint partition logic ==="
+echo ""
+
+# Parse the dispatch manifest from Test 1 and verify phase ordering
+# The sample plan has 4 phases. With HiLL at p04:
+# Run 1: p01, p02, p03, p04 (all run through checkpoint)
+# Pause: after p04 completes (end of implementation)
+
+# Verify all 4 phases are identified in the manifest
+PHASE_COUNT=$(echo "$OUTPUT_1" | grep -c "type: phase" || true)
+if [[ "$PHASE_COUNT" -eq 4 ]]; then
+  echo "  PASS: all 4 phases identified in manifest"
+  PASS=$((PASS + 1))
+else
+  echo "  FAIL: expected 4 phases, got $PHASE_COUNT"
+  FAIL=$((FAIL + 1))
+fi
+
+# Verify checkpoint info allows orchestrator to partition
+# The orchestrator reads hill_checkpoints and pauses after completing p04
+assert_contains "p01 is in pre-checkpoint run" "$OUTPUT_1" 'unit_id: "p01"'
+assert_contains "p02 is in pre-checkpoint run" "$OUTPUT_1" 'unit_id: "p02"'
+assert_contains "p03 is in pre-checkpoint run" "$OUTPUT_1" 'unit_id: "p03"'
+assert_contains "p04 is identified for post-checkpoint" "$OUTPUT_1" 'unit_id: "p04"'
+
+echo ""
+
+# ─── Test 5: Multiple HiLL checkpoints ────────────────────────────────────
+echo "=== Test 5: Multiple HiLL checkpoints ==="
+echo ""
+
+sed -E "s|oat_plan_hill_phases: \[[^]]*\]|oat_plan_hill_phases: ['p02', 'p04']|" "$FIXTURES_DIR/sample-plan.md" > "$TMPDIR/plan-multi-hil.md"
+
+OUTPUT_5=$(bash "$SKILL_DIR/scripts/dispatch.sh" "$TMPDIR/plan-multi-hil.md" "$TMPDIR" "test-branch" 2>&1)
+
+HIL_LINE_5=$(echo "$OUTPUT_5" | grep "hill_checkpoints:")
+assert_contains "extracts multiple checkpoints" "$HIL_LINE_5" "p02"
+assert_contains "includes second checkpoint" "$HIL_LINE_5" "p04"
+
+echo ""
+echo "=== Results ==="
+echo "Passed: $PASS"
+echo "Failed: $FAIL"
+
+if [[ $FAIL -gt 0 ]]; then
+  echo "OVERALL: FAIL"
+  exit 1
+else
+  echo "OVERALL: PASS"
+fi