@ontrails/warden 1.0.0-beta.13 → 1.0.0-beta.15

package/src/rules/valid-detour-refs.ts

@@ -1,187 +0,0 @@
-import { collectTrailIds } from './specs.js';
-import type {
-  ProjectAwareWardenRule,
-  ProjectContext,
-  WardenDiagnostic,
-} from './types.js';
-
-interface BraceState {
-  depth: number;
-  found: boolean;
-}
-
-const trackBraces = (line: string, state: BraceState): void => {
-  for (const ch of line) {
-    if (ch === '{') {
-      state.depth += 1;
-      state.found = true;
-    }
-    if (ch === '}') {
-      state.depth -= 1;
-    }
-  }
-};
-
-const collectArrayText = (lines: readonly string[], start: number): string => {
-  let text = '';
-  for (let k = start; k < lines.length && k < start + 20; k += 1) {
-    const line = lines[k];
-    if (!line) {
-      continue;
-    }
-    text += `${line}\n`;
-    if (text.includes(']')) {
-      break;
-    }
-  }
-  return text;
-};
-
-const findMissingDetourTargets = (
-  text: string,
-  knownIds: ReadonlySet<string>
-): string[] => {
-  const missing: string[] = [];
-  for (const m of text.matchAll(/target\s*:\s*["'`]([^"'`]+)["'`]/g)) {
-    const [, id] = m;
-    if (id && !knownIds.has(id)) {
-      missing.push(id);
-    }
-  }
-  return missing;
-};
-
-const findMissingPlainDetours = (
-  text: string,
-  knownIds: ReadonlySet<string>
-): string[] => {
-  const missing: string[] = [];
-  const cleaned = text.replaceAll(/target\s*:\s*["'`][^"'`]+["'`]/g, '');
-  for (const m of cleaned.matchAll(/["'`]([^"'`]+)["'`]/g)) {
-    const [, id] = m;
-    if (id && id.includes('.') && !knownIds.has(id)) {
-      missing.push(id);
-    }
-  }
-  return missing;
-};
-
-const findAllMissingDetours = (
-  text: string,
-  knownIds: ReadonlySet<string>
-): string[] => [
-  ...findMissingDetourTargets(text, knownIds),
-  ...findMissingPlainDetours(text, knownIds),
-];
-
-const addMissingDetourDiagnostics = (
-  specLine: string,
-  j: number,
-  lines: readonly string[],
-  trailId: string,
-  lineNum: number,
-  filePath: string,
-  knownIds: ReadonlySet<string>,
-  diagnostics: WardenDiagnostic[]
-): void => {
-  if (!/\bdetours\s*:/.test(specLine)) {
-    return;
-  }
-  for (const targetId of findAllMissingDetours(
-    collectArrayText(lines, j),
-    knownIds
-  )) {
-    diagnostics.push({
-      filePath,
-      line: lineNum,
-      message: `Trail "${trailId}" has detour targeting "${targetId}" which is not defined.`,
-      rule: 'valid-detour-refs',
-      severity: 'error',
-    });
-  }
-};
-
-const scanTrailDetours = (
-  lines: readonly string[],
-  startIndex: number,
-  trailId: string,
-  filePath: string,
-  knownIds: ReadonlySet<string>,
-  diagnostics: WardenDiagnostic[]
-): void => {
-  const braceState: BraceState = { depth: 0, found: false };
-  for (let j = startIndex; j < lines.length && j < startIndex + 200; j += 1) {
-    const specLine = lines[j];
-    if (!specLine) {
-      continue;
-    }
-    trackBraces(specLine, braceState);
-    addMissingDetourDiagnostics(
-      specLine,
-      j,
-      lines,
-      trailId,
-      startIndex + 1,
-      filePath,
-      knownIds,
-      diagnostics
-    );
-    if (braceState.found && braceState.depth <= 0) {
-      break;
-    }
-  }
-};
-
-const processLine = (
-  line: string,
-  i: number,
-  lines: readonly string[],
-  filePath: string,
-  knownIds: ReadonlySet<string>,
-  diagnostics: WardenDiagnostic[]
-): void => {
-  const trailMatch = line.match(/\btrail\s*\(\s*["'`]([^"'`]+)["'`]/);
-  if (!trailMatch) {
-    return;
-  }
-  const [, trailId] = trailMatch;
-  if (!trailId) {
-    return;
-  }
-  scanTrailDetours(lines, i, trailId, filePath, knownIds, diagnostics);
-};
-
-const checkDetourRefs = (
-  sourceCode: string,
-  filePath: string,
-  knownIds: ReadonlySet<string>
-): readonly WardenDiagnostic[] => {
-  const diagnostics: WardenDiagnostic[] = [];
-  const lines = sourceCode.split('\n');
-  for (let i = 0; i < lines.length; i += 1) {
-    const line = lines[i];
-    if (line) {
-      processLine(line, i, lines, filePath, knownIds, diagnostics);
-    }
-  }
-  return diagnostics;
-};
-
-/**
- * Checks that all trail IDs referenced in `detours` declarations exist.
- */
-export const validDetourRefs: ProjectAwareWardenRule = {
-  check(sourceCode: string, filePath: string): readonly WardenDiagnostic[] {
-    return checkDetourRefs(sourceCode, filePath, collectTrailIds(sourceCode));
-  },
-  checkWithContext(
-    sourceCode: string,
-    filePath: string,
-    context: ProjectContext
-  ): readonly WardenDiagnostic[] {
-    return checkDetourRefs(sourceCode, filePath, context.knownTrailIds);
-  },
-  description: 'Ensure all detour target trail IDs reference defined trails.',
-  name: 'valid-detour-refs',
-  severity: 'error',
-};

package/src/trails/no-throw-in-detour-target.trail.ts

@@ -1,20 +0,0 @@
-import { noThrowInDetourTarget } from '../rules/no-throw-in-detour-target.js';
-import { wrapRule } from './wrap-rule.js';
-
-export const noThrowInDetourTargetTrail = wrapRule({
-  examples: [
-    {
-      expected: { diagnostics: [] },
-      input: {
-        filePath: 'clean.ts',
-        sourceCode: `trail("entity.fallback", {
-  blaze: async (input, ctx) => {
-    return Result.ok({ recovered: true });
-  }
-})`,
-      },
-      name: 'Detour target without throw',
-    },
-  ],
-  rule: noThrowInDetourTarget,
-});

package/src/trails/valid-detour-refs.trail.ts

@@ -1,24 +0,0 @@
-import { validDetourRefs } from '../rules/valid-detour-refs.js';
-import { wrapRule } from './wrap-rule.js';
-
-export const validDetourRefsTrail = wrapRule({
-  examples: [
-    {
-      expected: { diagnostics: [] },
-      input: {
-        filePath: 'clean.ts',
-        knownTrailIds: ['entity.fallback', 'entity.show'],
-        sourceCode: `trail("entity.fallback", {
-  blaze: async (input, ctx) => Result.ok(data)
-})
-
-trail("entity.show", {
-  detours: [{ target: "entity.fallback" }],
-  blaze: async (input, ctx) => Result.ok(data)
-})`,
-      },
-      name: 'Valid detour target reference',
-    },
-  ],
-  rule: validDetourRefs,
-});