@ontrails/warden 1.0.0-beta.13 → 1.0.0-beta.15

package/dist/trails/service-exists.trail.js

@@ -1,29 +0,0 @@
-import { provisionExists } from '../rules/service-exists.js';
-import { wrapRule } from './wrap-rule.js';
-export const provisionExistsTrail = wrapRule({
-    examples: [
-        {
-            expected: { diagnostics: [] },
-            input: {
-                filePath: 'clean.ts',
-                knownProvisionIds: ['db.main'],
-                knownTrailIds: ['entity.show'],
-                sourceCode: `const db = provision("db.main", {
-  create: () => Result.ok({ source: "factory" }),
-});
-
-trail("entity.show", {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok(db.from(ctx));
-  }
-})`,
-            },
-            name: 'Declared provisions resolve to known project provisions',
-        },
-    ],
-    rule: provisionExists,
-});
-/** Backward-compatible alias while the migration is in flight. */
-export const serviceExistsTrail = provisionExistsTrail;
-//# sourceMappingURL=service-exists.trail.js.map

package/dist/trails/service-exists.trail.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"service-exists.trail.js","sourceRoot":"","sources":["../../src/trails/service-exists.trail.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAC7D,OAAO,EAAE,QAAQ,EAAE,MAAM,gBAAgB,CAAC;AAE1C,MAAM,CAAC,MAAM,oBAAoB,GAAG,QAAQ,CAAC;IAC3C,QAAQ,EAAE;QACR;YACE,QAAQ,EAAE,EAAE,WAAW,EAAE,EAAE,EAAE;YAC7B,KAAK,EAAE;gBACL,QAAQ,EAAE,UAAU;gBACpB,iBAAiB,EAAE,CAAC,SAAS,CAAC;gBAC9B,aAAa,EAAE,CAAC,aAAa,CAAC;gBAC9B,UAAU,EAAE;;;;;;;;;GASjB;aACI;YACD,IAAI,EAAE,yDAAyD;SAChE;KACF;IACD,IAAI,EAAE,eAAe;CACtB,CAAC,CAAC;AAEH,kEAAkE;AAClE,MAAM,CAAC,MAAM,kBAAkB,GAAG,oBAAoB,CAAC"}

package/src/__tests__/no-throw-in-detour-target.test.ts

@@ -1,78 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { noThrowInDetourTarget } from '../rules/no-throw-in-detour-target.js';
-
-const TEST_FILE = 'test.ts';
-
-describe('no-throw-in-detour-target', () => {
-  test('flags throw inside a detour target implementation', () => {
-    const code = `
-trail("entity.show", {
-  detours: { NotFoundError: ["entity.fallback"] },
-  blaze: async (input, ctx) => Result.ok({ id: "123" })
-})
-
-trail("entity.fallback", {
-  blaze: async (input, ctx) => {
-    throw new Error("boom");
-  }
-})`;
-
-    const diagnostics = noThrowInDetourTarget.check(code, TEST_FILE);
-
-    expect(diagnostics.length).toBe(1);
-    expect(diagnostics[0]?.rule).toBe('no-throw-in-detour-target');
-    expect(diagnostics[0]?.severity).toBe('error');
-  });
-
-  test('allows throw in implementations that are not detour targets', () => {
-    const code = `
-trail("entity.show", {
-  blaze: async (input, ctx) => {
-    throw new Error("boom");
-  }
-})`;
-
-    const diagnostics = noThrowInDetourTarget.check(code, TEST_FILE);
-
-    expect(diagnostics.length).toBe(0);
-  });
-
-  test('flags concise detour target implementations that throw inline', () => {
-    const code = `
-trail("entity.show", {
-  detours: { NotFoundError: ["entity.fallback"] },
-  blaze: async (input, ctx) => Result.ok({ id: "123" })
-})
-
-trail("entity.fallback", {
-  blaze: async (input, ctx) => { throw new Error("boom"); }
-})`;
-
-    const diagnostics = noThrowInDetourTarget.check(code, TEST_FILE);
-
-    expect(diagnostics.length).toBe(1);
-    expect(diagnostics[0]?.message).toContain('entity.fallback');
-  });
-
-  test('uses project context when the detour target is defined in another file', () => {
-    const code = `
-trail("entity.fallback", {
-  blaze: async (input, ctx) => {
-    throw new Error("boom");
-  }
-})`;
-
-    const diagnostics = noThrowInDetourTarget.checkWithContext(
-      code,
-      TEST_FILE,
-      {
-        detourTargetTrailIds: new Set(['entity.fallback']),
-        knownTrailIds: new Set(['entity.show', 'entity.fallback']),
-      }
-    );
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('no-throw-in-detour-target');
-  });
-});

package/src/__tests__/provision-declarations.test.ts

@@ -1,318 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { provisionDeclarations } from '../rules/provision-declarations.js';
-
-const TEST_FILE = 'test.ts';
-
-describe('provision-declarations', () => {
-  describe('clean cases', () => {
-    test('declared provisions match provision.from(ctx) usage', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('local helper named provision() is not treated as ctx lookup', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const provision = (id: string) => id;
-    return Result.ok({
-      resolved: provision('db.main'),
-      source: db.from(ctx).source,
-    });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('declared provisions match ctx.provision() usage', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const resolved = ctx.provision('db.main');
-    return Result.ok(resolved);
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('recognizes destructured provision() calls', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    const { provision } = ctx;
-    return Result.ok(provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-
-    test('recognizes ctx.provision(db) lookups by declared provision object', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision(db));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('error cases', () => {
-    test('provision.from(ctx) without a declaration produces an error', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.rule).toBe('provision-declarations');
-      expect(diagnostics[0]?.message).toContain('db.from(ctx)');
-      expect(diagnostics[0]?.message).toContain('not declared in provisions');
-    });
-
-    test('ctx.provision() without a declaration produces an error', () => {
-      const code = `
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain("ctx.provision('db.main')");
-    });
-
-    test('unresolved imported provision declarations do not suppress lookup diagnostics', () => {
-      const code = `
-import { Result, trail } from '@ontrails/core';
-import { db } from './provisions';
-
-// const db = provision('db.main', {
-//   create: () => Result.ok({ source: 'factory' }),
-// });
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain("ctx.provision('db.main')");
-    });
-
-    test('ctx.provision(db) without a declaration produces an error', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision(db));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('error');
-      expect(diagnostics[0]?.message).toContain('ctx.provision(db)');
-    });
-  });
-
-  describe('warn cases', () => {
-    test('declared but unused provision produces a warning', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async () => {
-    return Result.ok({ ok: true });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(1);
-      expect(diagnostics[0]?.severity).toBe('warn');
-      expect(diagnostics[0]?.rule).toBe('provision-declarations');
-      expect(diagnostics[0]?.message).toContain("'db' declared in provisions");
-      expect(diagnostics[0]?.message).toContain('never used');
-    });
-  });
-
-  describe('single-object overload', () => {
-    test('recognizes trail({ id, provisions, blaze }) form', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail({
-  id: 'entity.show',
-  provisions: [db],
-  blaze: async (_input, ctx) => {
-    return Result.ok({ source: db.from(ctx).source });
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('context parameter naming', () => {
-    test('recognizes database.from(context) when second param is named context', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const database = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [database],
-  blaze: async (_input, context) => {
-    return Result.ok(database.from(context));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  describe('nested run false positives', () => {
-    test('meta.run does not trigger false positives', () => {
-      const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  meta: { blaze: async () => ctx.provision('phantom') },
-  blaze: async (_input, ctx) => {
-    return Result.ok(db.from(ctx));
-  },
-});
-`;
-
-      const diagnostics = provisionDeclarations.check(code, TEST_FILE);
-
-      expect(diagnostics.length).toBe(0);
-    });
-  });
-
-  test('skips test files', () => {
-    const code = `
-trail('entity.show', {
-  blaze: async (_input, ctx) => {
-    return Result.ok(ctx.provision('db.main'));
-  },
-});
-`;
-
-    expect(provisionDeclarations.check(code, 'entity.test.ts')).toEqual([]);
-  });
-});

package/src/__tests__/provision-exists.test.ts

@@ -1,122 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { provisionExists } from '../rules/provision-exists.js';
-
-const TEST_FILE = 'entity.ts';
-
-describe('provision-exists', () => {
-  test('passes when a locally declared provision exists', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-import type { Provision } from '@ontrails/core';
-
-const db: Provision<{ source: string }> = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    expect(provisionExists.check(code, TEST_FILE)).toEqual([]);
-  });
-
-  test('ignores commented-out provision declarations when resolving local ids', () => {
-    const code = `
-import { Result, trail } from '@ontrails/core';
-
-trail('entity.show', {
-  provisions: ['db.main'],
-  blaze: async (_input, ctx) => Result.ok(ctx.provision('db.main')),
-});
-
-// const db = provision('db.main', {
-//   create: () => Result.ok({ source: 'factory' }),
-// });
-`;
-
-    const diagnostics = provisionExists.check(code, TEST_FILE);
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('provision-exists');
-    expect(diagnostics[0]?.message).toContain('db.main');
-  });
-
-  test('flags a declared provision missing from project context', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    const diagnostics = provisionExists.checkWithContext(code, TEST_FILE, {
-      knownProvisionIds: new Set(['db.other']),
-      knownTrailIds: new Set(['entity.show']),
-    });
-
-    expect(diagnostics).toHaveLength(1);
-    expect(diagnostics[0]?.rule).toBe('provision-exists');
-    expect(diagnostics[0]?.message).toContain('db.main');
-  });
-
-  test('passes when project context includes the declared provision', () => {
-    const code = `
-import { Result, provision, trail } from '@ontrails/core';
-
-const db = provision('db.main', {
-  create: () => Result.ok({ source: 'factory' }),
-});
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    const diagnostics = provisionExists.checkWithContext(code, TEST_FILE, {
-      knownProvisionIds: new Set(['db.main']),
-      knownTrailIds: new Set(['entity.show']),
-    });
-
-    expect(diagnostics).toEqual([]);
-  });
-
-  test('skips unresolved imported provisions instead of guessing', () => {
-    const code = `
-import { trail } from '@ontrails/core';
-import { db } from './provisions';
-
-trail('entity.show', {
-  provisions: [db],
-  blaze: async (_input, ctx) => Result.ok(db.from(ctx)),
-});
-`;
-
-    expect(
-      provisionExists.checkWithContext(code, TEST_FILE, {
-        knownProvisionIds: new Set(['db.main']),
-        knownTrailIds: new Set(['entity.show']),
-      })
-    ).toEqual([]);
-  });
-
-  test('skips test files', () => {
-    const code = `
-trail('entity.show', {
-  provisions: ['db.main'],
-  blaze: async (_input, ctx) => Result.ok(ctx.provision('db.main')),
-});
-`;
-
-    expect(provisionExists.check(code, 'entity.test.ts')).toEqual([]);
-  });
-});

package/src/rules/no-throw-in-detour-target.ts

@@ -1,150 +0,0 @@
-/**
- * Flags throws in implementations that are used as detour targets.
- *
- * Uses AST parsing for accurate detection of detour target IDs and
- * throw statements within those trail implementations.
- */
-
-import {
-  findBlazeBodies,
-  findTrailDefinitions,
-  offsetToLine,
-  parse,
-  walk,
-} from './ast.js';
-import { isTestFile } from './scan.js';
-import type {
-  ProjectAwareWardenRule,
-  ProjectContext,
-  WardenDiagnostic,
-} from './types.js';
-
-interface AstNode {
-  readonly type: string;
-  readonly start: number;
-  readonly end: number;
-  readonly [key: string]: unknown;
-}
-
-/** Collect all trail IDs referenced as detour targets in the AST. */
-const collectDetourTargets = (ast: AstNode): ReadonlySet<string> => {
-  const targets = new Set<string>();
-
-  walk(ast, (node) => {
-    if (
-      node.type !== 'Property' ||
-      node.key?.name !== 'detours' ||
-      !node.value
-    ) {
-      return;
-    }
-
-    walk(node.value as AstNode, (inner) => {
-      if (inner.type === 'Literal' || inner.type === 'StringLiteral') {
-        const { value } = inner as unknown as { value?: unknown };
-        if (typeof value === 'string' && value.includes('.')) {
-          targets.add(value);
-        }
-      }
-    });
-  });
-
-  return targets;
-};
-
-/** Find throws in implementation bodies of targeted trails. */
-const findThrowsInTargetedTrails = (
-  ast: AstNode,
-  sourceCode: string,
-  filePath: string,
-  detourTargets: ReadonlySet<string>
-): WardenDiagnostic[] => {
-  const diagnostics: WardenDiagnostic[] = [];
-
-  for (const def of findTrailDefinitions(ast)) {
-    if (!detourTargets.has(def.id)) {
-      continue;
-    }
-
-    for (const body of findBlazeBodies(def.config as AstNode)) {
-      walk(body, (node) => {
-        if (node.type === 'ThrowStatement') {
-          diagnostics.push({
-            filePath,
-            line: offsetToLine(sourceCode, node.start),
-            message: `Trail "${def.id}" is a detour target and must not throw. Use Result.err() instead.`,
-            rule: 'no-throw-in-detour-target',
-            severity: 'error',
-          });
-        }
-      });
-    }
-  }
-
-  return diagnostics;
-};
-
-const checkThrowInDetourTargets = (
-  sourceCode: string,
-  filePath: string,
-  detourTargets: ReadonlySet<string>
-): readonly WardenDiagnostic[] => {
-  if (isTestFile(filePath)) {
-    return [];
-  }
-
-  const ast = parse(filePath, sourceCode);
-  if (!ast) {
-    return [];
-  }
-
-  return findThrowsInTargetedTrails(
-    ast as AstNode,
-    sourceCode,
-    filePath,
-    detourTargets
-  );
-};
-
-/**
- * Flags throws in implementations that are used as detour targets.
- */
-export const noThrowInDetourTarget: ProjectAwareWardenRule = {
-  check(sourceCode: string, filePath: string): readonly WardenDiagnostic[] {
-    const ast = parse(filePath, sourceCode);
-    if (!ast) {
-      return [];
-    }
-    return checkThrowInDetourTargets(
-      sourceCode,
-      filePath,
-      collectDetourTargets(ast as AstNode)
-    );
-  },
-  checkWithContext(
-    sourceCode: string,
-    filePath: string,
-    context: ProjectContext
-  ): readonly WardenDiagnostic[] {
-    if (context.detourTargetTrailIds) {
-      return checkThrowInDetourTargets(
-        sourceCode,
-        filePath,
-        context.detourTargetTrailIds
-      );
-    }
-    const ast = parse(filePath, sourceCode);
-    if (!ast) {
-      return [];
-    }
-    return checkThrowInDetourTargets(
-      sourceCode,
-      filePath,
-      collectDetourTargets(ast as AstNode)
-    );
-  },
-  description:
-    'Disallow throw statements inside implementations that are referenced as detour targets.',
-  name: 'no-throw-in-detour-target',
-  severity: 'error',
-};