@ontrails/core 1.0.0-beta.3 → 1.0.0-beta.30

package/src/__tests__/trail.test.ts

@@ -1,179 +0,0 @@
-import { describe, test, expect } from 'bun:test';
-
-import { z } from 'zod';
-
-import { Result } from '../result';
-import { trail } from '../trail';
-import type { TrailContext } from '../types';
-
-const stubCtx: TrailContext = {
-  requestId: 'test-123',
-  signal: AbortSignal.timeout(5000),
-};
-
-describe('trail()', () => {
-  const inputSchema = z.object({ name: z.string() });
-  const outputSchema = z.object({ greeting: z.string() });
-
-  const greet = trail('greet', {
-    description: 'Greet someone',
-    implementation: (input) => Result.ok({ greeting: `Hello, ${input.name}!` }),
-    input: inputSchema,
-    output: outputSchema,
-  });
-
-  describe('basics', () => {
-    test('returns correct id', () => {
-      expect(greet.id).toBe('greet');
-    });
-
-    test("returns kind 'trail'", () => {
-      expect(greet.kind).toBe('trail');
-    });
-
-    test('preserves input schema', () => {
-      const parsed = greet.input.safeParse({ name: 'World' });
-      expect(parsed.success).toBe(true);
-
-      const bad = greet.input.safeParse({ name: 42 });
-      expect(bad.success).toBe(false);
-    });
-
-    test('output schema is optional', () => {
-      const minimal = trail('noop', {
-        implementation: () => Result.ok(),
-        input: z.object({}),
-      });
-      expect(minimal.output).toBeUndefined();
-    });
-
-    test('implementation is callable', async () => {
-      const result = await greet.implementation({ name: 'World' }, stubCtx);
-      expect(result.isOk()).toBe(true);
-      expect(result.unwrap()).toEqual({ greeting: 'Hello, World!' });
-    });
-  });
-
-  describe('metadata', () => {
-    test('examples are stored', () => {
-      const withExamples = trail('echo', {
-        examples: [
-          { error: 'ValidationError', input: { text: '' }, name: 'error-case' },
-          { expected: { text: 'hi' }, input: { text: 'hi' }, name: 'basic' },
-        ],
-        implementation: (input) => Result.ok({ text: input.text }),
-        input: z.object({ text: z.string() }),
-      });
-      expect(withExamples.examples).toHaveLength(2);
-      const first = withExamples.examples?.[0];
-      expect(first?.name).toBe('error-case');
-      const second = withExamples.examples?.[1];
-      expect(second?.name).toBe('basic');
-    });
-
-    test('markers are stored', () => {
-      const withMarkers = trail('tagged', {
-        implementation: () => Result.ok(),
-        input: z.object({}),
-        markers: { domain: 'billing', tier: 1 },
-      });
-      expect(withMarkers.markers).toEqual({ domain: 'billing', tier: 1 });
-    });
-
-    test('detours are stored', () => {
-      const withDetours = trail('orchestrator', {
-        detours: {
-          onFailure: ['alert'],
-          onSuccess: ['notify', 'audit'],
-        },
-        implementation: () => Result.ok(),
-        input: z.object({}),
-      });
-      expect(withDetours.detours).toEqual({
-        onFailure: ['alert'],
-        onSuccess: ['notify', 'audit'],
-      });
-    });
-  });
-
-  describe('boolean flags', () => {
-    test('boolean flags default to undefined', () => {
-      const minimal = trail('bare', {
-        implementation: () => Result.ok(),
-        input: z.object({}),
-      });
-      expect(minimal.readOnly).toBeUndefined();
-      expect(minimal.destructive).toBeUndefined();
-      expect(minimal.idempotent).toBeUndefined();
-    });
-
-    test('boolean flags are preserved when set', () => {
-      const withFlags = trail('flagged', {
-        destructive: false,
-        idempotent: true,
-        implementation: () => Result.ok(),
-        input: z.object({}),
-        readOnly: true,
-      });
-      expect(withFlags.readOnly).toBe(true);
-      expect(withFlags.destructive).toBe(false);
-      expect(withFlags.idempotent).toBe(true);
-    });
-  });
-
-  describe('single-object overload', () => {
-    test('accepts spec with id property', () => {
-      const t = trail({
-        id: 'entity.show',
-        implementation: (input: { name: string }, _ctx: TrailContext) =>
-          Result.ok({ greeting: `Hi, ${input.name}` }),
-        input: inputSchema,
-      });
-      expect(t.id).toBe('entity.show');
-      expect(t.kind).toBe('trail');
-    });
-
-    test('preserves all spec fields', () => {
-      const t = trail({
-        description: 'A full trail',
-        destructive: false,
-        examples: [{ input: { name: 'World' }, name: 'test' }],
-        id: 'full',
-        implementation: (input: { name: string }, _ctx: TrailContext) =>
-          Result.ok({ greeting: `Hi, ${input.name}` }),
-        input: inputSchema,
-        output: outputSchema,
-        readOnly: true,
-      });
-      expect(t.description).toBe('A full trail');
-      expect(t.readOnly).toBe(true);
-      expect(t.examples).toHaveLength(1);
-    });
-
-    test('implementation is callable', async () => {
-      const t = trail({
-        id: 'callable',
-        implementation: (input: { x: number }) => Result.ok(input.x * 2),
-        input: z.object({ x: z.number() }),
-      });
-      const result = await t.implementation({ x: 5 }, stubCtx);
-      expect(result.isOk()).toBe(true);
-      expect(result.unwrap()).toBe(10);
-    });
-
-    test('sync implementations are normalized to an awaitable runtime function', async () => {
-      const t = trail('normalized', {
-        implementation: (input: { value: number }) =>
-          Result.ok(input.value + 1),
-        input: z.object({ value: z.number() }),
-      });
-
-      const promise = t.implementation({ value: 2 }, stubCtx);
-      expect(promise).toBeInstanceOf(Promise);
-
-      const result = await promise;
-      expect(result.isOk()).toBe(true);
-      expect(result.unwrap()).toBe(3);
-    });
-  });
-});

package/src/__tests__/validate-topo.test.ts

@@ -1,280 +0,0 @@
-import { describe, expect, test } from 'bun:test';
-
-import { z } from 'zod';
-
-import { Result } from '../result.js';
-import { topo } from '../topo.js';
-import type { TopoIssue } from '../validate-topo.js';
-import { validateTopo } from '../validate-topo.js';
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-// oxlint-disable-next-line require-await -- satisfies async interface
-const noop = async () => Result.ok();
-
-const mockTrail = (
-  id: string,
-  overrides?: {
-    examples?: readonly {
-      name: string;
-      input: unknown;
-      expected?: unknown;
-      error?: string;
-    }[];
-    output?: z.ZodType;
-  }
-) => ({
-  id,
-  implementation: noop,
-  input: z.object({ name: z.string() }),
-  kind: 'trail' as const,
-  ...overrides,
-});
-
-const mockHike = (id: string, follows: readonly string[]) => ({
-  follows,
-  id,
-  implementation: noop,
-  input: z.object({ q: z.string() }),
-  kind: 'hike' as const,
-});
-
-const mockEvent = (id: string, from?: readonly string[]) => ({
-  from,
-  id,
-  kind: 'event' as const,
-  payload: z.object({ data: z.string() }),
-});
-
-/** Extract issues from a failed validateTopo result. */
-const extractIssues = (result: Result<void, Error>): TopoIssue[] => {
-  if (result.isOk()) {
-    return [];
-  }
-  const ctx = (result.error as { context?: { issues?: TopoIssue[] } }).context;
-  return (ctx?.issues ?? []) as TopoIssue[];
-};
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-describe('validateTopo', () => {
-  test('valid topo passes', () => {
-    const app = topo('app', {
-      add: mockTrail('entity.add'),
-      onboard: mockHike('entity.onboard', ['entity.add']),
-      updated: mockEvent('entity.updated', ['entity.add']),
-    });
-
-    const result = validateTopo(app);
-    expect(result.isOk()).toBe(true);
-  });
-
-  describe('hike follows', () => {
-    test('hike following non-existent trail fails', () => {
-      const app = topo('app', {
-        onboard: mockHike('entity.onboard', ['entity.missing']),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues).toHaveLength(1);
-      expect(issues[0]?.rule).toBe('follows-exist');
-      expect(issues[0]?.message).toContain('entity.missing');
-    });
-
-    test('hike following itself fails', () => {
-      const app = topo('app', {
-        loop: mockHike('entity.loop', ['entity.loop']),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues.some((i) => i.rule === 'no-self-follow')).toBe(true);
-    });
-
-    test('two-node cycle (a→b→a) is detected', () => {
-      const app = topo('app', {
-        a: mockHike('a', ['b']),
-        b: mockHike('b', ['a']),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      const cycleIssues = issues.filter((i) => i.rule === 'follow-cycle');
-      expect(cycleIssues.length).toBeGreaterThanOrEqual(1);
-      expect(cycleIssues[0]?.message).toContain('Cycle detected');
-    });
-
-    test('three-node cycle (a→b→c→a) is detected', () => {
-      const app = topo('app', {
-        a: mockHike('a', ['b']),
-        b: mockHike('b', ['c']),
-        c: mockHike('c', ['a']),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      const cycleIssues = issues.filter((i) => i.rule === 'follow-cycle');
-      expect(cycleIssues.length).toBeGreaterThanOrEqual(1);
-      expect(cycleIssues[0]?.message).toContain('Cycle detected');
-    });
-
-    test('valid DAG with shared targets is not flagged', () => {
-      const app = topo('app', {
-        a: mockHike('a', ['c']),
-        b: mockHike('b', ['c']),
-        c: mockHike('c', []),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isOk()).toBe(true);
-    });
-  });
-
-  describe('example validation', () => {
-    test('example with invalid input fails', () => {
-      const app = topo('app', {
-        show: mockTrail('entity.show', {
-          examples: [{ input: { name: 123 }, name: 'Bad input' }],
-        }),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues).toHaveLength(1);
-      expect(issues[0]?.rule).toBe('example-input-valid');
-      expect(issues[0]?.message).toContain('Bad input');
-    });
-
-    test('example with expected output but no output schema warns', () => {
-      const app = topo('app', {
-        show: mockTrail('entity.show', {
-          examples: [
-            {
-              expected: { result: 'ok' },
-              input: { name: 'test' },
-              name: 'Has expected',
-            },
-          ],
-        }),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues).toHaveLength(1);
-      expect(issues[0]?.rule).toBe('output-schema-present');
-    });
-
-    test('ValidationError example with invalid input is allowed', () => {
-      const app = topo('app', {
-        show: mockTrail('entity.show', {
-          examples: [
-            {
-              error: 'ValidationError',
-              input: { name: 123 },
-              name: 'Error case',
-            },
-          ],
-        }),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isOk()).toBe(true);
-    });
-
-    test('NotFoundError example with invalid input fails', () => {
-      const app = topo('app', {
-        show: mockTrail('entity.show', {
-          examples: [
-            {
-              error: 'NotFoundError',
-              input: { name: 123 },
-              name: 'Not found case',
-            },
-          ],
-        }),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues).toHaveLength(1);
-      expect(issues[0]?.rule).toBe('example-input-valid');
-    });
-
-    test('NotFoundError example with valid input passes', () => {
-      const app = topo('app', {
-        show: mockTrail('entity.show', {
-          examples: [
-            {
-              error: 'NotFoundError',
-              input: { name: 'test' },
-              name: 'Not found case',
-            },
-          ],
-        }),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isOk()).toBe(true);
-    });
-  });
-
-  describe('event origins', () => {
-    test('event with non-existent origin fails', () => {
-      const app = topo('app', {
-        updated: mockEvent('entity.updated', ['entity.ghost']),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isErr()).toBe(true);
-
-      const issues = extractIssues(result);
-      expect(issues).toHaveLength(1);
-      expect(issues[0]?.rule).toBe('event-origin-exists');
-      expect(issues[0]?.message).toContain('entity.ghost');
-    });
-
-    test('event without origins is accepted', () => {
-      const app = topo('app', {
-        updated: mockEvent('entity.updated'),
-      });
-
-      const result = validateTopo(app);
-      expect(result.isOk()).toBe(true);
-    });
-  });
-
-  test('collects multiple issues', () => {
-    const app = topo('app', {
-      broken: mockHike('entity.broken', ['entity.missing']),
-      show: mockTrail('entity.show', {
-        examples: [{ input: { name: 123 }, name: 'Bad' }],
-      }),
-      updated: mockEvent('entity.updated', ['entity.ghost']),
-    });
-
-    const result = validateTopo(app);
-    expect(result.isErr()).toBe(true);
-
-    const issues = extractIssues(result);
-    expect(issues).toHaveLength(3);
-  });
-});