@ontrails/core 1.0.0-beta.3 → 1.0.0-beta.30

package/src/__tests__/serialization.test.ts

@@ -1,401 +0,0 @@
-import { describe, test, expect } from 'bun:test';
-
-import {
-  ValidationError,
-  AmbiguousError,
-  AssertionError,
-  NetworkError,
-  RateLimitError,
-  InternalError,
-  TimeoutError,
-  NotFoundError,
-  AlreadyExistsError,
-  ConflictError,
-  PermissionError,
-  AuthError,
-  CancelledError,
-} from '../errors.js';
-import {
-  serializeError,
-  deserializeError,
-  safeStringify,
-} from '../serialization.js';
-import { Result } from '../result.js';
-import type { SerializedError } from '../serialization.js';
-
-// ---------------------------------------------------------------------------
-// serializeError
-// ---------------------------------------------------------------------------
-
-describe('serializeError', () => {
-  test('serializes a plain Error', () => {
-    const err = new Error('boom');
-    const serialized = serializeError(err);
-    expect(serialized.name).toBe('Error');
-    expect(serialized.message).toBe('boom');
-    expect(serialized.stack).toBeDefined();
-    expect(serialized.category).toBeUndefined();
-    expect(serialized.retryable).toBeUndefined();
-  });
-
-  test('serializes a TrailsError with category', () => {
-    const err = new NetworkError('disconnected');
-    const serialized = serializeError(err);
-    expect(serialized.name).toBe('NetworkError');
-    expect(serialized.message).toBe('disconnected');
-    expect(serialized.category).toBe('network');
-    expect(serialized.retryable).toBe(true);
-  });
-
-  test('serializes context', () => {
-    const err = new ValidationError('bad input', {
-      context: { field: 'email' },
-    });
-    const serialized = serializeError(err);
-    expect(serialized.context).toEqual({ field: 'email' });
-  });
-
-  test('serializes RateLimitError.retryAfter', () => {
-    const err = new RateLimitError('slow down', { retryAfter: 30 });
-    const serialized = serializeError(err);
-    expect(serialized.retryAfter).toBe(30);
-  });
-
-  test('retryAfter is undefined for non-RateLimitError', () => {
-    const err = new TimeoutError('timed out');
-    const serialized = serializeError(err);
-    expect(serialized.retryAfter).toBeUndefined();
-  });
-});
-
-// ---------------------------------------------------------------------------
-// deserializeError
-// ---------------------------------------------------------------------------
-
-describe('deserializeError', () => {
-  test('reconstructs a validation error', () => {
-    const data: SerializedError = {
-      category: 'validation',
-      message: 'bad input',
-      name: 'ValidationError',
-      retryable: false,
-    };
-    const err = deserializeError(data);
-    expect(err).toBeInstanceOf(ValidationError);
-    expect(err.message).toBe('bad input');
-    expect(err.category).toBe('validation');
-  });
-
-  test('reconstructs a rate limit error with retryAfter', () => {
-    const data: SerializedError = {
-      category: 'rate_limit',
-      message: 'slow down',
-      name: 'RateLimitError',
-      retryAfter: 60,
-      retryable: true,
-    };
-    const err = deserializeError(data);
-    expect(err).toBeInstanceOf(RateLimitError);
-    expect((err as RateLimitError).retryAfter).toBe(60);
-  });
-
-  test('restores stack trace', () => {
-    const data: SerializedError = {
-      category: 'internal',
-      message: 'oops',
-      name: 'InternalError',
-      stack: 'Error: oops\n    at test.ts:1:1',
-    };
-    const err = deserializeError(data);
-    expect(err.stack).toBe('Error: oops\n    at test.ts:1:1');
-  });
-
-  test('restores context', () => {
-    const data: SerializedError = {
-      category: 'auth',
-      context: { endpoint: '/api/secret' },
-      message: 'unauthorized',
-      name: 'AuthError',
-    };
-    const err = deserializeError(data);
-    expect(err.context).toEqual({ endpoint: '/api/secret' });
-  });
-
-  test('defaults to InternalError when category is missing', () => {
-    const data: SerializedError = {
-      message: 'unknown',
-      name: 'SomeError',
-    };
-    const err = deserializeError(data);
-    expect(err).toBeInstanceOf(InternalError);
-    expect(err.category).toBe('internal');
-  });
-
-  test('round-trips through serialize/deserialize', () => {
-    const original = new NotFoundError('missing resource', {
-      context: { id: 'abc' },
-    });
-    const serialized = serializeError(original);
-    const restored = deserializeError(serialized);
-    expect(restored).toBeInstanceOf(NotFoundError);
-    expect(restored.message).toBe('missing resource');
-    expect(restored.context).toEqual({ id: 'abc' });
-    expect(restored.category).toBe('not_found');
-  });
-
-  test('handles all error categories', () => {
-    const categories = [
-      'validation',
-      'not_found',
-      'conflict',
-      'permission',
-      'timeout',
-      'rate_limit',
-      'network',
-      'internal',
-      'auth',
-      'cancelled',
-    ] as const;
-
-    for (const category of categories) {
-      const data: SerializedError = {
-        category,
-        message: 'test',
-        name: 'Test',
-      };
-      const err = deserializeError(data);
-      expect(err.category).toBe(category);
-    }
-  });
-
-  describe('round-trips all subclasses by name', () => {
-    const subclasses = [
-      { Ctor: ValidationError, category: 'validation' },
-      { Ctor: AmbiguousError, category: 'validation' },
-      { Ctor: AssertionError, category: 'internal' },
-      { Ctor: NotFoundError, category: 'not_found' },
-      { Ctor: AlreadyExistsError, category: 'conflict' },
-      { Ctor: ConflictError, category: 'conflict' },
-      { Ctor: PermissionError, category: 'permission' },
-      { Ctor: TimeoutError, category: 'timeout' },
-      { Ctor: NetworkError, category: 'network' },
-      { Ctor: InternalError, category: 'internal' },
-      { Ctor: AuthError, category: 'auth' },
-      { Ctor: CancelledError, category: 'cancelled' },
-    ] as const;
-
-    test.each(subclasses)(
-      '$Ctor.name round-trips with correct identity',
-      ({ Ctor, category }) => {
-        const original = new Ctor(`test ${Ctor.name}`, {
-          context: { key: 'value' },
-        });
-        const serialized = serializeError(original);
-        const restored = deserializeError(serialized);
-
-        expect(restored).toBeInstanceOf(Ctor);
-        expect(restored.constructor.name).toBe(Ctor.name);
-        expect(restored.name).toBe(Ctor.name);
-        expect(restored.category).toBe(category);
-        expect(restored.message).toBe(`test ${Ctor.name}`);
-        expect(restored.context).toEqual({ key: 'value' });
-      }
-    );
-
-    test('RateLimitError round-trips with retryAfter', () => {
-      const original = new RateLimitError('slow down', {
-        context: { endpoint: '/api' },
-        retryAfter: 42,
-      });
-      const serialized = serializeError(original);
-      const restored = deserializeError(serialized);
-
-      expect(restored).toBeInstanceOf(RateLimitError);
-      expect(restored.constructor.name).toBe('RateLimitError');
-      expect((restored as RateLimitError).retryAfter).toBe(42);
-      expect(restored.context).toEqual({ endpoint: '/api' });
-    });
-
-    test('falls back to category when name is unknown', () => {
-      const data: SerializedError = {
-        category: 'conflict',
-        message: 'custom error',
-        name: 'CustomConflictError',
-      };
-      const err = deserializeError(data);
-      expect(err).toBeInstanceOf(ConflictError);
-      expect(err.category).toBe('conflict');
-    });
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Result.fromJson
-// ---------------------------------------------------------------------------
-
-describe('Result.fromJson (safeParse)', () => {
-  test('parses valid JSON', () => {
-    const result = Result.fromJson('{"key": "value"}');
-    expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toEqual({ key: 'value' });
-  });
-
-  test('parses JSON arrays', () => {
-    const result = Result.fromJson('[1, 2, 3]');
-    expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toEqual([1, 2, 3]);
-  });
-
-  test('parses JSON primitives', () => {
-    expect(Result.fromJson('"hello"').unwrap()).toBe('hello');
-    expect(Result.fromJson('42').unwrap()).toBe(42);
-    expect(Result.fromJson('true').unwrap()).toBe(true);
-    expect(Result.fromJson('null').unwrap()).toBe(null);
-  });
-
-  test('returns ValidationError for invalid JSON', () => {
-    const result = Result.fromJson('not json');
-    expect(result.isErr()).toBe(true);
-    const err = result as unknown as { error: ValidationError };
-    expect(err.error).toBeInstanceOf(ValidationError);
-    expect(err.error.message).toBe('Invalid JSON');
-  });
-
-  test('includes truncated input in context', () => {
-    const result = Result.fromJson('{bad}');
-    expect(result.isErr()).toBe(true);
-    const err = result as unknown as { error: ValidationError };
-    expect(err.error.context).toBeDefined();
-    expect(err.error.context?.['input']).toBe('{bad}');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Result.toJson
-// ---------------------------------------------------------------------------
-
-describe('Result.toJson (safeStringify)', () => {
-  test('stringifies objects', () => {
-    const result = Result.toJson({ key: 'value' });
-    expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBe('{"key":"value"}');
-  });
-
-  test('stringifies arrays', () => {
-    const result = Result.toJson([1, 2, 3]);
-    expect(result.isOk()).toBe(true);
-    expect(result.unwrap()).toBe('[1,2,3]');
-  });
-
-  test('stringifies primitives', () => {
-    expect(Result.toJson('hello').unwrap()).toBe('"hello"');
-    expect(Result.toJson(42).unwrap()).toBe('42');
-    expect(Result.toJson(true).unwrap()).toBe('true');
-    expect(Result.toJson(null).unwrap()).toBe('null');
-  });
-
-  test('handles circular references gracefully', () => {
-    const obj: Record<string, unknown> = { a: 1 };
-    obj['self'] = obj;
-    const result = Result.toJson(obj);
-    expect(result.isOk()).toBe(true);
-    const ok = result as unknown as { value: string };
-    const parsed = JSON.parse(ok.value) as Record<string, unknown>;
-    expect(parsed['a']).toBe(1);
-    expect(parsed['self']).toBe('[Circular]');
-  });
-
-  test('serializes shared references in a DAG without marking as circular', () => {
-    const shared = { x: 1 };
-    const obj = { a: shared, b: shared };
-    const result = Result.toJson(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<string, unknown>;
-    expect(parsed['a']).toEqual({ x: 1 });
-    expect(parsed['b']).toEqual({ x: 1 });
-  });
-
-  test('detects deep circular references', () => {
-    const inner: Record<string, unknown> = { value: 'deep' };
-    const obj: Record<string, unknown> = { child: { nested: inner } };
-    inner['back'] = obj;
-    const result = Result.toJson(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<string, unknown>;
-    const child = parsed['child'] as Record<string, unknown>;
-    const nested = child['nested'] as Record<string, unknown>;
-    expect(nested['value']).toBe('deep');
-    expect(nested['back']).toBe('[Circular]');
-  });
-
-  test('handles shared ref used in sibling subtrees of a DAG', () => {
-    const shared = { id: 42 };
-    const obj = {
-      left: { extra: 'l', ref: shared },
-      right: { extra: 'r', ref: shared },
-    };
-    const result = Result.toJson(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<
-      string,
-      Record<string, unknown>
-    >;
-    expect(parsed['left']?.['ref']).toEqual({ id: 42 });
-    expect(parsed['right']?.['ref']).toEqual({ id: 42 });
-  });
-});
-
-// ---------------------------------------------------------------------------
-// safeStringify (shared DAG / circular detection)
-// ---------------------------------------------------------------------------
-
-describe('safeStringify', () => {
-  test('serializes shared references in a DAG without marking as circular', () => {
-    const shared = { x: 1 };
-    const obj = { a: shared, b: shared };
-    const result = safeStringify(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<string, unknown>;
-    expect(parsed['a']).toEqual({ x: 1 });
-    expect(parsed['b']).toEqual({ x: 1 });
-  });
-
-  test('detects true circular references', () => {
-    const obj: Record<string, unknown> = { a: 1 };
-    obj['self'] = obj;
-    const result = safeStringify(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<string, unknown>;
-    expect(parsed['a']).toBe(1);
-    expect(parsed['self']).toBe('[Circular]');
-  });
-
-  test('detects deep circular references', () => {
-    const inner: Record<string, unknown> = { value: 'deep' };
-    const obj: Record<string, unknown> = { child: { nested: inner } };
-    inner['back'] = obj;
-    const result = safeStringify(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<string, unknown>;
-    const child = parsed['child'] as Record<string, unknown>;
-    const nested = child['nested'] as Record<string, unknown>;
-    expect(nested['value']).toBe('deep');
-    expect(nested['back']).toBe('[Circular]');
-  });
-
-  test('handles shared ref used in sibling subtrees of a DAG', () => {
-    const shared = { id: 42 };
-    const obj = {
-      left: { extra: 'l', ref: shared },
-      right: { extra: 'r', ref: shared },
-    };
-    const result = safeStringify(obj);
-    expect(result.isOk()).toBe(true);
-    const parsed = JSON.parse(result.unwrap()) as Record<
-      string,
-      Record<string, unknown>
-    >;
-    expect(parsed['left']?.['ref']).toEqual({ id: 42 });
-    expect(parsed['right']?.['ref']).toEqual({ id: 42 });
-  });
-});

package/src/__tests__/topo.test.ts

@@ -1,220 +0,0 @@
-import { describe, test, expect } from 'bun:test';
-
-import { z } from 'zod';
-
-import { ValidationError } from '../errors.js';
-import { Result } from '../result.js';
-import { topo } from '../topo.js';
-
-// ---------------------------------------------------------------------------
-// Mock factories
-// ---------------------------------------------------------------------------
-
-// oxlint-disable-next-line require-await -- satisfies async interface without needing await
-const noop = async () => Result.ok();
-
-const mockTrail = (id: string) => ({
-  id,
-  implementation: noop,
-  input: z.object({ x: z.number() }),
-  kind: 'trail' as const,
-  output: z.object({ y: z.number() }),
-});
-
-const mockHike = (id: string) => ({
-  follows: [] as readonly string[],
-  id,
-  implementation: noop,
-  input: z.object({ q: z.string() }),
-  kind: 'hike' as const,
-  output: z.object({ r: z.string() }),
-  path: `/${id}`,
-});
-
-const mockEvent = (id: string) => ({
-  id,
-  kind: 'event' as const,
-  payload: z.object({ payload: z.string() }),
-});
-
-// ---------------------------------------------------------------------------
-// topo()
-// ---------------------------------------------------------------------------
-
-describe('topo', () => {
-  describe('collection', () => {
-    test('returns Topo with name', () => {
-      const t = topo('my-app');
-      expect(t.name).toBe('my-app');
-    });
-
-    test('collects trails from modules', () => {
-      const mod = { myTrail: mockTrail('create-user') };
-      const t = topo('app', mod);
-
-      expect(t.trails.size).toBe(1);
-      expect(t.trails.get('create-user')).toBe(mod.myTrail);
-    });
-
-    test('auto-scans exports by kind discriminant', () => {
-      const mod = {
-        event1: mockEvent('e1'),
-        hike1: mockHike('r1'),
-        trail1: mockTrail('t1'),
-      };
-      const t = topo('app', mod);
-
-      expect(t.trails.size).toBe(1);
-      expect(t.hikes.size).toBe(1);
-      expect(t.events.size).toBe(1);
-    });
-
-    test('collects from multiple modules', () => {
-      const mod1 = { a: mockTrail('t1') };
-      const mod2 = { b: mockTrail('t2'), c: mockHike('r1') };
-      const t = topo('app', mod1, mod2);
-
-      expect(t.trails.size).toBe(2);
-      expect(t.hikes.size).toBe(1);
-    });
-
-    test('non-trail exports are silently ignored', () => {
-      const mod = {
-        config: { port: 3000 },
-        helper: () => 'not a trail',
-        name: 'some-string',
-        nothing: null,
-        num: 42,
-        trail1: mockTrail('t1'),
-        undef: undefined,
-      };
-      const t = topo('app', mod);
-
-      expect(t.trails.size).toBe(1);
-      expect(t.hikes.size).toBe(0);
-      expect(t.events.size).toBe(0);
-    });
-
-    test('allows different IDs across trails and hikes', () => {
-      const mod = { h: mockHike('hike-1'), t: mockTrail('trail-1') };
-      const t = topo('app', mod);
-
-      expect(t.trails.size).toBe(1);
-      expect(t.hikes.size).toBe(1);
-    });
-  });
-
-  describe('duplicate rejection', () => {
-    test('rejects duplicate trail IDs', () => {
-      const mod1 = { a: mockTrail('dup') };
-      const mod2 = { b: mockTrail('dup') };
-
-      expect(() => topo('app', mod1, mod2)).toThrow(ValidationError);
-      expect(() => topo('app', mod1, mod2)).toThrow(
-        'Duplicate trail ID: "dup"'
-      );
-    });
-
-    test('rejects duplicate hike IDs', () => {
-      const mod1 = { a: mockHike('dup') };
-      const mod2 = { b: mockHike('dup') };
-
-      expect(() => topo('app', mod1, mod2)).toThrow(ValidationError);
-      expect(() => topo('app', mod1, mod2)).toThrow('Duplicate hike ID: "dup"');
-    });
-
-    test('rejects duplicate event IDs', () => {
-      const mod1 = { a: mockEvent('dup') };
-      const mod2 = { b: mockEvent('dup') };
-
-      expect(() => topo('app', mod1, mod2)).toThrow(ValidationError);
-      expect(() => topo('app', mod1, mod2)).toThrow(
-        'Duplicate event ID: "dup"'
-      );
-    });
-
-    test('rejects a hike whose ID collides with an existing trail', () => {
-      const modTrail = { a: mockTrail('shared-id') };
-      const modHike = { b: mockHike('shared-id') };
-
-      expect(() => topo('app', modTrail, modHike)).toThrow(ValidationError);
-      expect(() => topo('app', modTrail, modHike)).toThrow(
-        /ID collision.*hike "shared-id".*trail/
-      );
-    });
-
-    test('rejects a trail whose ID collides with an existing hike', () => {
-      const modHike = { a: mockHike('shared-id') };
-      const modTrail = { b: mockTrail('shared-id') };
-
-      expect(() => topo('app', modHike, modTrail)).toThrow(ValidationError);
-      expect(() => topo('app', modHike, modTrail)).toThrow(
-        /ID collision.*trail "shared-id".*hike/
-      );
-    });
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Topo
-// ---------------------------------------------------------------------------
-
-describe('Topo', () => {
-  const mod = {
-    e1: mockEvent('event-1'),
-    h1: mockHike('hike-1'),
-    t1: mockTrail('trail-1'),
-    t2: mockTrail('trail-2'),
-  };
-
-  // Build once for the describe block
-  const app = topo('app', mod);
-
-  describe('get()', () => {
-    test('retrieves trail by ID', () => {
-      expect(app.get('trail-1')).toBe(mod.t1);
-    });
-
-    test('retrieves hike by ID', () => {
-      expect(app.get('hike-1')).toBe(mod.h1);
-    });
-
-    test('returns undefined for unknown ID', () => {
-      expect(app.get('nope')).toBeUndefined();
-    });
-  });
-
-  describe('has()', () => {
-    test('returns true for known trail', () => {
-      expect(app.has('trail-1')).toBe(true);
-    });
-
-    test('returns true for known hike', () => {
-      expect(app.has('hike-1')).toBe(true);
-    });
-
-    test('returns false for unknown ID', () => {
-      expect(app.has('nope')).toBe(false);
-    });
-
-    test('returns false for event ID (events are not trails/hikes)', () => {
-      expect(app.has('event-1')).toBe(false);
-    });
-  });
-
-  describe('listing', () => {
-    test('list() returns all trails and hikes', () => {
-      const items = app.list();
-      expect(items).toHaveLength(3);
-      expect(items).toContain(mod.t1);
-      expect(items).toContain(mod.t2);
-      expect(items).toContain(mod.h1);
-    });
-
-    test('listEvents() returns all events', () => {
-      const items = app.listEvents();
-      expect(items).toHaveLength(1);
-      expect(items).toContain(mod.e1);
-    });
-  });
-});