@oneuptime/common 13.0.8 → 14.0.1

package/Server/API/TeamComplianceAPI.ts

@@ -1,158 +0,0 @@
-import UserMiddleware from "../Middleware/UserAuthorization";
-import TeamComplianceService, {
-  TeamComplianceStatus,
-  UserComplianceStatus,
-} from "../Services/TeamComplianceService";
-import {
-  ExpressRequest,
-  ExpressResponse,
-  NextFunction,
-} from "../Utils/Express";
-import Response from "../Utils/Response";
-import BaseAPI from "./BaseAPI";
-import CommonAPI from "./CommonAPI";
-import DatabaseCommonInteractionProps from "../../Types/BaseDatabase/DatabaseCommonInteractionProps";
-import ObjectID from "../../Types/ObjectID";
-import Team from "../../Models/DatabaseModels/Team";
-import TeamService, {
-  Service as TeamServiceType,
-} from "../Services/TeamService";
-import ComplianceRuleType from "../../Types/Team/ComplianceRuleType";
-
-/*
- * `/team/compliance-status/:teamId` - who on this team cannot be paged, and why.
- *
- * AUTHORISATION, and why it is written out here rather than assumed.
- *
- * This route is mounted with UserMiddleware.getUserMiddleware, and that
- * middleware is not an authorisation gate: it admits an unauthenticated request
- * as UserType.Public and calls next(), and the tenant id it attaches is read
- * from the caller-supplied `tenantid` header before any authorisation runs.
- * Everything underneath then reads with `isRoot: true`, because a compliance
- * page necessarily reports on people the reader may not be permitted to read
- * individually. The handler is therefore the only gate that exists.
- *
- * Until this change the handler checked only that the header carried SOME
- * project id, so anyone at all could send a `tenantid` and a team id and be told
- * which of that team's responders are unreachable, by name and email. That is a
- * roster of who to phone during an outage and who will never pick up, and it
- * predates Phase 2 - it is not a regression introduced by the readiness work,
- * but the readiness work rebuilt this service, so it is closed here.
- *
- * Two assertions now, in this order:
- *
- *   1. the caller is a logged-in member of the project they named
- *      (CommonAPI.assertAuthenticatedProjectMember), and
- *   2. the team in the path belongs to that same project - otherwise a member of
- *      project A reads project B's roster simply by sending their own header
- *      alongside a borrowed team id.
- *
- * TeamComplianceService scopes its own team read to the project as well, and the
- * duplication is deliberate for the same reason OnCallReadinessAPI duplicates
- * its service's guards: the service's scoping answers "no such team" (a 400),
- * whereas a member of project A reaching for project B's team id is an
- * authorisation failure and should be answered as one - and an endpoint's
- * authorisation should be legible in the endpoint, not inferred from what some
- * service happens to do today. The wording of the refusal is identical to the
- * one a nonexistent team gets, so the route cannot be used to enumerate team ids
- * across tenants.
- */
-export default class TeamComplianceAPI extends BaseAPI<Team, TeamServiceType> {
-  public constructor() {
-    super(Team, TeamService);
-
-    // Get team compliance status
-    this.router.get(
-      `${new this.entityType().getCrudApiPath()?.toString()}/compliance-status/:teamId`,
-      UserMiddleware.getUserMiddleware,
-      async (req: ExpressRequest, res: ExpressResponse, next: NextFunction) => {
-        try {
-          const databaseProps: DatabaseCommonInteractionProps =
-            await CommonAPI.getDatabaseCommonInteractionProps(req);
-
-          const projectId: ObjectID =
-            CommonAPI.assertAuthenticatedProjectMember(databaseProps);
-
-          /*
-           * ObjectID's constructor accepts any string, so an unparseable path
-           * segment would otherwise travel all the way to a query that matches
-           * nothing and be reported as "this team does not exist" rather than as
-           * "you sent nonsense". The guard this replaces was `if (!teamId)`,
-           * which could never fire: `new ObjectID(...)` is always truthy, so a
-           * malformed id was accepted silently.
-           */
-          const rawTeamId: string = (req.params["teamId"] as string) || "";
-          ObjectID.validateUUID(rawTeamId);
-          const teamId: ObjectID = new ObjectID(rawTeamId);
-
-          /*
-           * The team id arrives from the caller and everything downstream reads
-           * as root, so the team's OWN projectId - not the header - is what has
-           * to agree with the project the caller was authorised for.
-           */
-          const team: Team | null = await TeamService.findOneById({
-            id: teamId,
-            select: {
-              projectId: true,
-            },
-            props: {
-              isRoot: true,
-            },
-          });
-
-          CommonAPI.assertResourceBelongsToProject({
-            resourceProjectId: team?.projectId,
-            projectId: projectId,
-          });
-
-          const complianceStatus: TeamComplianceStatus =
-            await TeamComplianceService.getTeamComplianceStatus(
-              teamId,
-              projectId,
-            );
-
-          // Convert ObjectIDs to strings for JSON response
-          const responseData: {
-            teamId: string;
-            teamName: string;
-            complianceSettings: Array<{
-              ruleType: ComplianceRuleType;
-              enabled: boolean;
-            }>;
-            userComplianceStatuses: Array<{
-              userId: string;
-              userName: string;
-              userEmail: string;
-              userProfilePictureId: string | undefined;
-              isCompliant: boolean;
-              nonCompliantRules: Array<{
-                ruleType: ComplianceRuleType;
-                reason: string;
-              }>;
-            }>;
-          } = {
-            teamId: complianceStatus.teamId.toString(),
-            teamName: complianceStatus.teamName,
-            complianceSettings: complianceStatus.complianceSettings,
-            userComplianceStatuses: complianceStatus.userComplianceStatuses.map(
-              (user: UserComplianceStatus) => {
-                return {
-                  userId: user.userId.toString(),
-                  userName: user.userName,
-                  userEmail: user.userEmail,
-                  userProfilePictureId: user.userProfilePictureId?.toString(),
-                  isCompliant: user.isCompliant,
-                  nonCompliantRules: user.nonCompliantRules,
-                };
-              },
-            ),
-          };
-
-          return Response.sendJsonObjectResponse(req, res, responseData);
-        } catch (e) {
-          next(e);
-        }
-      },
-    );
-  }
-}

package/Server/Middleware/SCIMAuthorization.ts

@@ -1,141 +0,0 @@
-import ProjectSCIMService from "../Services/ProjectSCIMService";
-import StatusPageSCIMService from "../Services/StatusPageSCIMService";
-import {
-  ExpressRequest,
-  ExpressResponse,
-  NextFunction,
-  OneUptimeRequest,
-} from "../Utils/Express";
-import ObjectID from "../../Types/ObjectID";
-import ProjectSCIM from "../../Models/DatabaseModels/ProjectSCIM";
-import StatusPageSCIM from "../../Models/DatabaseModels/StatusPageSCIM";
-import NotAuthorizedException from "../../Types/Exception/NotAuthorizedException";
-import BadRequestException from "../../Types/Exception/BadRequestException";
-import CaptureSpan from "../Utils/Telemetry/CaptureSpan";
-import SpanUtil from "../Utils/Telemetry/SpanUtil";
-import logger, { getLogAttributesFromRequest } from "../Utils/Logger";
-
-export default class SCIMMiddleware {
-  @CaptureSpan()
-  public static async isAuthorizedSCIMRequest(
-    req: ExpressRequest,
-    _res: ExpressResponse,
-    next: NextFunction,
-  ): Promise<void> {
-    try {
-      const oneuptimeRequest: OneUptimeRequest = req as OneUptimeRequest;
-
-      // Extract SCIM ID from URL path (could be project or status page)
-      const scimId: string | undefined =
-        req.params["projectScimId"] || req.params["statusPageScimId"];
-      if (!scimId) {
-        throw new BadRequestException("SCIM ID is required");
-      }
-
-      // Extract bearer token from Authorization header
-      let bearerToken: string | undefined;
-      if (req.headers?.["authorization"]) {
-        const authHeader: string = req.headers["authorization"] as string;
-        if (authHeader.startsWith("Bearer ")) {
-          bearerToken = authHeader.substring(7);
-        }
-      }
-
-      logger.debug(
-        `SCIM Authorization: scimId=${scimId}, bearerToken=${
-          bearerToken ? "***" : "missing"
-        }`,
-        getLogAttributesFromRequest(req as OneUptimeRequest),
-      );
-
-      if (!bearerToken) {
-        throw new NotAuthorizedException(
-          "Bearer token is required for SCIM authentication",
-        );
-      }
-
-      // Try to find Project SCIM configuration first
-      const projectScimConfig: ProjectSCIM | null =
-        await ProjectSCIMService.findOneBy({
-          query: {
-            _id: new ObjectID(scimId),
-            bearerToken: bearerToken,
-          },
-          select: {
-            _id: true,
-            projectId: true,
-            autoProvisionUsers: true,
-            autoDeprovisionUsers: true,
-            enablePushGroups: true,
-            teams: {
-              _id: true,
-              name: true,
-            },
-          },
-          props: {
-            isRoot: true,
-          },
-        });
-
-      if (projectScimConfig) {
-        // Store Project SCIM configuration
-        oneuptimeRequest.bearerTokenData = {
-          scimConfig: projectScimConfig,
-          projectId: projectScimConfig.projectId,
-          projectScimId: new ObjectID(scimId),
-          type: "project-scim",
-        };
-        return next();
-      }
-
-      // If not found, try Status Page SCIM configuration
-      const statusPageScimConfig: StatusPageSCIM | null =
-        await StatusPageSCIMService.findOneBy({
-          query: {
-            _id: new ObjectID(scimId),
-            bearerToken: bearerToken,
-          },
-          select: {
-            _id: true,
-            projectId: true,
-            statusPageId: true,
-            autoProvisionUsers: true,
-            autoDeprovisionUsers: true,
-          },
-          props: {
-            isRoot: true,
-          },
-        });
-
-      if (statusPageScimConfig) {
-        // Store Status Page SCIM configuration
-        oneuptimeRequest.bearerTokenData = {
-          scimConfig: statusPageScimConfig,
-          projectId: statusPageScimConfig.projectId,
-          statusPageId: statusPageScimConfig.statusPageId,
-          statusPageScimId: new ObjectID(scimId),
-          type: "status-page-scim",
-        };
-        return next();
-      }
-
-      // If neither found, throw error
-      throw new NotAuthorizedException(
-        "Invalid bearer token or SCIM configuration not found",
-      );
-    } catch (err) {
-      /*
-       * Record on THIS middleware's own @CaptureSpan span before handing the
-       * error to Express. The decorator sees a normal return (we call
-       * next(err) rather than rethrowing — Express 4 does not catch a
-       * rejection from an async middleware), so its recorder never runs and
-       * without this the error is invisible on the span it actually belongs
-       * to. Goes through SpanUtil so the event is typed by class name rather
-       * than by HTTP status, and so a rejected credential produces a `fault`
-       * event instead of an Issue.
-       */
-      SpanUtil.recordExceptionOnCurrentSpan(err);
-      return next(err);
-    }
-  }
-}