@oneuptime/common 13.0.8 → 14.0.1

package/Tests/Utils/Slo/SloMonitorRuleCriteria.test.ts

@@ -1,5 +1,6 @@
 import FilterCondition from "../../../Types/Filter/FilterCondition";
 import ObjectID from "../../../Types/ObjectID";
+import MonitorType from "../../../Types/Monitor/MonitorType";
 import RuleCriteria, {
   RULE_CRITERIA_LEGACY_NEVER_MATCH_PATTERN,
   RULE_CRITERIA_SCHEMA_VERSION,
@@ -385,3 +386,111 @@ describe("getSloMonitorRuleCriteriaKey", () => {
     );
   });
 });
+
+describe("SLO monitor type criteria descriptions", () => {
+  test.each(["", "Invalid monitor type"])(
+    "describes an invalid legacy monitor type as matching no monitors: %p",
+    (monitorType: string) => {
+      expect(
+        describeSloMonitorRuleCriteria({
+          rule: {
+            monitorType: monitorType as MonitorType,
+            monitorNamePattern: ".*",
+          },
+        }),
+      ).toBe(SLO_MONITOR_RULE_INVALID_CRITERIA_DESCRIPTION);
+    },
+  );
+
+  test.each([
+    { operator: RuleCriteriaOperator.Equals, value: "Invalid monitor type" },
+    { operator: RuleCriteriaOperator.NotEquals, value: "" },
+    { operator: RuleCriteriaOperator.Contains, value: MonitorType.API },
+    { operator: RuleCriteriaOperator.HasAnyOf, value: [MonitorType.API] },
+  ])(
+    "describes invalid type criteria as matching no monitors: %p",
+    (filter: Pick<RuleCriteriaFilter, "operator" | "value">) => {
+      expect(
+        describeSloMonitorRuleCriteria({
+          rule: {
+            criteria: criteria(FilterCondition.Any, [
+              { field: "monitorType", ...filter },
+            ]),
+          },
+        }),
+      ).toBe(SLO_MONITOR_RULE_INVALID_CRITERIA_DESCRIPTION);
+    },
+  );
+
+  test.each([RuleCriteriaOperator.Equals, RuleCriteriaOperator.NotEquals])(
+    "describes configured monitor type %s without looking up labels",
+    (operator: RuleCriteriaOperator) => {
+      const rule: SloMonitorRuleCriteriaCarrier = {
+        criteria: criteria(FilterCondition.All, [
+          { field: "monitorType", operator, value: MonitorType.API },
+          {
+            field: "monitorNamePattern",
+            operator: RuleCriteriaOperator.DoesNotMatchPattern,
+            value: "^staging-",
+          },
+        ]),
+        monitorType: MonitorType.Website,
+      };
+      expect(describeSloMonitorRuleCriteria({ rule })).toBe(
+        `Type ${SLO_MONITOR_RULE_OPERATOR_PHRASES[operator]} "API" AND Name does not match pattern "^staging-"`,
+      );
+      expect(getSloMonitorRuleLabelIds(rule)).toEqual([]);
+    },
+  );
+
+  test("describes a legacy monitor type combined with other attributes", () => {
+    expect(
+      describeSloMonitorRuleCriteria({
+        rule: {
+          monitorType: MonitorType.Website,
+          monitorLabels: [{ _id: PRODUCTION_LABEL_ID, name: "Production" }],
+          monitorNamePattern: "^checkout-",
+        },
+      }),
+    ).toBe(
+      'Labels has any of "Production" AND Type is "Website" AND Name matches pattern "^checkout-"',
+    );
+  });
+
+  test("describes a type-only legacy rule as a configured condition", () => {
+    expect(
+      describeSloMonitorRuleCriteria({
+        rule: { monitorType: MonitorType.API },
+      }),
+    ).toBe('Type is "API"');
+  });
+
+  test("detects changes to legacy monitor types for audit and feed updates", () => {
+    const apiKey: string = getSloMonitorRuleCriteriaKey({
+      monitorType: MonitorType.API,
+    });
+    expect(apiKey).not.toBe(
+      getSloMonitorRuleCriteriaKey({ monitorType: MonitorType.Website }),
+    );
+    expect(apiKey).not.toBe(getSloMonitorRuleCriteriaKey({}));
+    expect(getSloMonitorRuleCriteriaKey({ monitorType: null })).toBe(
+      getSloMonitorRuleCriteriaKey({}),
+    );
+  });
+
+  test("ignores legacy monitor type shadows for configured rule identity", () => {
+    const configured: RuleCriteria = criteria(FilterCondition.All, [
+      {
+        field: "monitorType",
+        operator: RuleCriteriaOperator.Equals,
+        value: MonitorType.API,
+      },
+    ]);
+    expect(
+      getSloMonitorRuleCriteriaKey({
+        criteria: configured,
+        monitorType: MonitorType.Website,
+      }),
+    ).toBe(getSloMonitorRuleCriteriaKey({ criteria: configured }));
+  });
+});

package/Tests/Utils/Slo/SloOverviewText.test.ts

@@ -5,6 +5,7 @@ import SloWindowType from "../../../Types/ServiceLevelObjective/SloWindowType";
 import {
   getSliTypeText,
   getSloAtRiskText,
+  getSloBudgetRemainingText,
   getSloDowntimeStatusesText,
   getSloHeadline,
   getSloMonitorCountText,
@@ -79,6 +80,69 @@ describe("getSloTargetText", () => {
   });
 });
 
+describe("getSloBudgetRemainingText", () => {
+  test.each([-99882.8, -120, -0.001, -Number.MIN_VALUE, -Number.MAX_VALUE])(
+    "explains a %p%% remaining budget as exceeded, even if it rounds to zero",
+    (percentage: number) => {
+      expect(getSloBudgetRemainingText(percentage)).toBe("Budget exceeded");
+    },
+  );
+
+  test.each([0, -0])(
+    "distinguishes an exactly exhausted %p%% budget from an overage",
+    (percentage: number) => {
+      expect(getSloBudgetRemainingText(percentage)).toBe("No budget left");
+    },
+  );
+
+  test.each([Number.MIN_VALUE, 0.001, 0.049, 0.05, 0.0999])(
+    "keeps a small positive %p%% budget distinct from no budget left",
+    (percentage: number) => {
+      expect(getSloBudgetRemainingText(percentage)).toBe("<0.1%");
+    },
+  );
+
+  test.each([
+    [0.1, "0.1%"],
+    [0.14, "0.1%"],
+    [0.15, "0.2%"],
+    [15, "15%"],
+    [20, "20%"],
+    [62.5, "62.5%"],
+    [62.56, "62.6%"],
+    [100, "100%"],
+  ])(
+    "shows a positive %p%% remainder as %s without unnecessary decimal places",
+    (percentage: number, expected: string) => {
+      expect(getSloBudgetRemainingText(percentage)).toBe(expected);
+    },
+  );
+
+  test.each([100.01, 150, Number.MAX_VALUE])(
+    "never claims more than a full budget when the input is %p%%",
+    (percentage: number) => {
+      expect(getSloBudgetRemainingText(percentage)).toBe("100%");
+    },
+  );
+
+  test.each([
+    ["missing", undefined],
+    ["null", null],
+    ["NaN", Number.NaN],
+    ["positive infinity", Number.POSITIVE_INFINITY],
+    ["negative infinity", Number.NEGATIVE_INFINITY],
+    ["numeric string", "62.5" as unknown as number],
+    ["negative numeric string", "-99882.8" as unknown as number],
+    ["true", true as unknown as number],
+    ["false", false as unknown as number],
+  ])(
+    "makes no budget claim for %s data",
+    (_label: string, percentage: number | null | undefined) => {
+      expect(getSloBudgetRemainingText(percentage)).toBeNull();
+    },
+  );
+});
+
 describe("getSloMonitorCountText", () => {
   test.each([
     [0, "No monitors"],

package/Tests/Utils/StatusPage/UptimeDailyAggregateUtil.test.ts

@@ -0,0 +1,248 @@
+import ObjectID from "../../../Types/ObjectID";
+import { JSONObject } from "../../../Types/JSON";
+import {
+  UptimeDailyAggregate,
+  UptimeDayBucket,
+} from "../../../Types/StatusPage/UptimeDailyAggregate";
+import UptimeDailyAggregateUtil from "../../../Utils/StatusPage/UptimeDailyAggregateUtil";
+import { describe, expect, test } from "@jest/globals";
+
+/*
+ * WHAT THIS FILE IS DEFENDING
+ *
+ * The wire format for the uptime aggregate, which replaced shipping raw
+ * MonitorStatusTimeline rows to the status page.
+ *
+ * Two properties matter more than the round trip itself:
+ *
+ * 1. It must be SMALL. The rows it replaces serialize to ~431 bytes each,
+ *    almost entirely typed-JSON envelopes, so one real status page's 254,550
+ *    matching rows came to ~105 MB. If this format ever grows envelopes it
+ *    gives that back.
+ *
+ * 2. Parsing must be TOTAL. A status page that cannot read its aggregate has
+ *    to fall back to "no data", which is honest. What it must never do is
+ *    fall back to something that looks like uptime.
+ */
+
+const MONITOR_A: string = "11111111-1111-4111-8111-111111111111";
+const STATUS_UP: string = "aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa";
+
+function sample(): UptimeDailyAggregate {
+  return {
+    monitors: [
+      {
+        monitorId: new ObjectID(MONITOR_A),
+        buckets: [
+          {
+            bucketStart: new Date("2026-07-01T00:00:00.000Z"),
+            bucketEnd: new Date("2026-07-02T00:00:00.000Z"),
+            daySeconds: 86400,
+            coveredSeconds: 86400,
+            statusDurations: [
+              {
+                monitorStatusId: new ObjectID(STATUS_UP),
+                seconds: 86400,
+              },
+            ],
+          },
+          {
+            bucketStart: new Date("2026-07-02T00:00:00.000Z"),
+            bucketEnd: new Date("2026-07-03T00:00:00.000Z"),
+            daySeconds: 86400,
+            coveredSeconds: 0,
+            statusDurations: [],
+          },
+        ],
+      },
+    ],
+    isComplete: true,
+    completeFrom: null,
+  };
+}
+
+describe("UptimeDailyAggregateUtil", () => {
+  describe("round trip", () => {
+    test("survives toJSON -> fromJSON unchanged", () => {
+      const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON(
+        UptimeDailyAggregateUtil.toJSON(sample()),
+      );
+
+      expect(parsed.monitors).toHaveLength(1);
+      expect(parsed.monitors[0]!.monitorId.toString()).toBe(MONITOR_A);
+      expect(parsed.monitors[0]!.buckets).toHaveLength(2);
+
+      const first: UptimeDayBucket = parsed.monitors[0]!.buckets[0]!;
+
+      expect(first.coveredSeconds).toBe(86400);
+      expect(first.daySeconds).toBe(86400);
+      expect(first.bucketStart.toISOString()).toBe("2026-07-01T00:00:00.000Z");
+      expect(first.statusDurations[0]!.monitorStatusId.toString()).toBe(
+        STATUS_UP,
+      );
+    });
+
+    test("a no-data day survives as a no-data day", () => {
+      /*
+       * The single most important thing to preserve. If coverage were lost in
+       * transit the client would treat the day as ordinary and paint it with
+       * the operator's colour - which is the bug this whole change removes.
+       */
+      const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON(
+        UptimeDailyAggregateUtil.toJSON(sample()),
+      );
+
+      expect(parsed.monitors[0]!.buckets[1]!.coveredSeconds).toBe(0);
+      expect(parsed.monitors[0]!.buckets[1]!.statusDurations).toHaveLength(0);
+    });
+  });
+
+  describe("the wire format stays small", () => {
+    test("dates and ids are plain strings, not typed-JSON envelopes", () => {
+      const json: JSONObject = UptimeDailyAggregateUtil.toJSON(sample());
+      const encoded: string = JSON.stringify(json);
+
+      expect(encoded).not.toContain("_type");
+      expect(encoded).toContain("2026-07-01T00:00:00.000Z");
+      expect(encoded).toContain(MONITOR_A);
+    });
+
+    test("a 90-day, 50-monitor page stays far below the row payload it replaces", () => {
+      /*
+       * The rows this replaces were ~431 bytes each and a real page matched
+       * 254,550 of them (~105 MB). This asserts the replacement is bounded by
+       * structure rather than by how much a monitor flaps.
+       */
+      const aggregate: UptimeDailyAggregate = {
+        monitors: [],
+        isComplete: true,
+        completeFrom: null,
+      };
+
+      for (let m: number = 0; m < 50; m++) {
+        const buckets: Array<UptimeDayBucket> = [];
+
+        for (let d: number = 0; d < 90; d++) {
+          const start: Date = new Date(
+            Date.UTC(2026, 3, 1) + d * 24 * 60 * 60 * 1000,
+          );
+
+          buckets.push({
+            bucketStart: start,
+            bucketEnd: new Date(start.getTime() + 86400000),
+            daySeconds: 86400,
+            coveredSeconds: 86400,
+            statusDurations: [
+              { monitorStatusId: new ObjectID(STATUS_UP), seconds: 86000 },
+              { monitorStatusId: new ObjectID(MONITOR_A), seconds: 400 },
+            ],
+          });
+        }
+
+        aggregate.monitors.push({
+          monitorId: new ObjectID(
+            `${MONITOR_A.slice(0, -2)}${m % 10}${m % 10}`,
+          ),
+          buckets,
+        });
+      }
+
+      const bytes: number = JSON.stringify(
+        UptimeDailyAggregateUtil.toJSON(aggregate),
+      ).length;
+
+      // Comfortably under a megabyte for the largest page the product allows.
+      expect(bytes).toBeLessThan(1_500_000);
+    });
+  });
+
+  describe("parsing is total", () => {
+    test.each([
+      ["null", null],
+      ["undefined", undefined],
+      ["an empty object", {}],
+      ["monitors not an array", { monitors: "nope" }],
+    ])(
+      "%s yields an empty aggregate rather than throwing",
+      (_name: string, input: unknown) => {
+        expect(() => {
+          return UptimeDailyAggregateUtil.fromJSON(input as JSONObject);
+        }).not.toThrow();
+
+        const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON(
+          input as JSONObject,
+        );
+
+        expect(parsed.monitors).toHaveLength(0);
+      },
+    );
+
+    test("a bucket with an unparseable date is dropped, not turned into coverage", () => {
+      const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON({
+        monitors: [
+          {
+            monitorId: MONITOR_A,
+            buckets: [
+              {
+                bucketStart: "not-a-date",
+                bucketEnd: "also-not",
+                daySeconds: 1,
+              },
+            ],
+          },
+        ],
+        weird: true,
+      } as unknown as JSONObject);
+
+      expect(parsed.monitors[0]!.buckets).toHaveLength(0);
+    });
+
+    test("a missing isComplete means complete, not incomplete", () => {
+      /*
+       * An older server has no cap in this path either. Defaulting to
+       * incomplete would grey out every bar on a perfectly healthy page.
+       */
+      const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON({
+        monitors: [],
+      } as unknown as JSONObject);
+
+      expect(parsed.isComplete).toBe(true);
+    });
+
+    test("an explicit isComplete false is honoured", () => {
+      const parsed: UptimeDailyAggregate = UptimeDailyAggregateUtil.fromJSON({
+        monitors: [],
+        isComplete: false,
+        completeFrom: "2026-07-05T00:00:00.000Z",
+      } as unknown as JSONObject);
+
+      expect(parsed.isComplete).toBe(false);
+      expect(parsed.completeFrom?.toISOString()).toBe(
+        "2026-07-05T00:00:00.000Z",
+      );
+    });
+  });
+
+  describe("getBucketsForMonitor", () => {
+    test("returns that monitor's buckets", () => {
+      expect(
+        UptimeDailyAggregateUtil.getBucketsForMonitor(sample(), MONITOR_A),
+      ).toHaveLength(2);
+    });
+
+    test("returns empty for a monitor that is not in the aggregate", () => {
+      expect(
+        UptimeDailyAggregateUtil.getBucketsForMonitor(
+          sample(),
+          "99999999-9999-4999-8999-999999999999",
+        ),
+      ).toHaveLength(0);
+    });
+
+    test("returns empty rather than throwing when there is no aggregate", () => {
+      expect(
+        UptimeDailyAggregateUtil.getBucketsForMonitor(null, MONITOR_A),
+      ).toHaveLength(0);
+    });
+  });
+});

package/Types/API/Hostname.ts

@@ -3,6 +3,8 @@ import BadDataException from "../Exception/BadDataException";
 import { JSONObject, ObjectType } from "../JSON";
 import Port from "../Port";
 import Typeof from "../Typeof";
+import HostAddressUtil from "../../Utils/HostAddressUtil";
+import IP from "../IP/IP";
 import { FindOperator } from "typeorm";
 
 /*
@@ -22,10 +24,26 @@ const HOST_REGEX: RegExp =
  */
 const USER_INFO_REGEX: RegExp = /^[^@/?#\s[\]]*$/;
 
-const IPV6_CHARS_REGEX: RegExp = /^[0-9a-fA-F:.]+$/;
-
 const PORT_REGEX: RegExp = /^\d{1,5}$/;
 
+/*
+ * The authority spellings of an IPv6 host: bracketed ("[::1]", "[::1]:8080")
+ * or bare. Two or more colons cannot be a "host:port", so every colon in a
+ * bare value belongs to the address itself.
+ *
+ * This only decides which SHAPE a value has. Whether what it holds is really
+ * an address is IP.isIP's job, and isValid below asks it -- the old code
+ * settled for a "[0-9a-fA-F:.]+" charset, which called "::::" and
+ * "1.2.3.4.5.6" valid hosts and then handed them to a socket.
+ */
+function isIPv6Authority(authority: string): boolean {
+  return authority.startsWith("[") || (authority.match(/:/g) || []).length > 1;
+}
+
+function isIPv6Address(value: string): boolean {
+  return Boolean(value) && IP.isIP(value) && new IP(value).isIPv6();
+}
+
 export default class Hostname extends DatabaseProperty {
   private _route: string = "";
   public get hostname(): string {
@@ -104,15 +122,15 @@ export default class Hostname extends DatabaseProperty {
       /^\[([0-9a-fA-F:.]+)\](?::(\d{1,5}))?$/,
     );
     if (bracketedIpv6Match) {
-      return true;
+      return isIPv6Address(bracketedIpv6Match[1] as string);
     }
 
     /*
      * Unbracketed IPv6 literal. Two or more colons cannot be a "host:port",
      * so the colons must be part of the address itself.
      */
-    if ((authority.match(/:/g) || []).length > 1) {
-      return IPV6_CHARS_REGEX.test(authority);
+    if (isIPv6Authority(authority)) {
+      return isIPv6Address(authority);
     }
 
     const colonIndex: number = authority.indexOf(":");
@@ -158,28 +176,57 @@ export default class Hostname extends DatabaseProperty {
     throw new BadDataException("Invalid JSON: " + JSON.stringify(json));
   }
 
+  /*
+   * The authority form. An IPv6 host is BRACKETED once a port is appended,
+   * because "2001:db8::1" + ":179" is not an ambiguous-looking string — it is
+   * "2001:db8::1:179", which net.isIP() accepts as a different, perfectly
+   * valid address. Anything that read this back (or showed it to an operator)
+   * was therefore pointed at a host nobody configured.
+   *
+   * Without a port the host is returned exactly as it is held, brackets and
+   * all. A bracketed value came from a URL authority and has to go back into
+   * one — dropping the brackets there would make URL.toString() emit
+   * "https://2001:db8::1/", which no URL parser accepts.
+   */
   public override toString(): string {
-    let hostname: string = this.hostname;
-
-    if (this.port) {
-      hostname += ":" + this.port.toString();
+    if (!this.port) {
+      return this.hostname;
     }
 
-    return hostname;
+    return HostAddressUtil.formatHostAndPort({
+      host: this.hostname,
+      port: this.port.toString(),
+    });
   }
 
+  /*
+   * Reads a stored host, which may carry a ":port".
+   *
+   * IPv6 literals are handed to fromAuthority instead of being split, because
+   * splitting on the first colon is meaningless for an address that is made
+   * of colons: "2001:518:2800:9::2" used to come back as host "2001" with
+   * port 518 — and because 518 is a legal port number NOTHING threw. A
+   * monitor saved from the dashboard therefore silently pointed at a host
+   * called "2001", and the address the operator typed was simply gone.
+   *
+   * DNS names and IPv4 literals keep the original behaviour exactly: neither
+   * can contain two colons, so neither can reach the new branch.
+   */
   public static fromString(hostname: string | Hostname): Hostname {
     if (hostname instanceof Hostname) {
       hostname = hostname.toString();
     }
 
-    if (hostname.includes(":")) {
-      return new Hostname(
-        hostname.split(":")[0] as string,
-        hostname.split(":")[1],
-      );
+    const value: string = (hostname || "").trim();
+
+    if (isIPv6Authority(value)) {
+      return Hostname.fromAuthority(value);
+    }
+
+    if (value.includes(":")) {
+      return new Hostname(value.split(":")[0] as string, value.split(":")[1]);
     }
-    return new Hostname(hostname);
+    return new Hostname(value);
   }
 
   /*

package/Types/API/Route.ts

@@ -7,13 +7,30 @@ import { FindOperator } from "typeorm";
 export default class Route extends DatabaseProperty {
   private static readonly SCHEME_PREFIX: RegExp = /^[a-zA-Z][a-zA-Z\d+.-]*:/;
 
+  /*
+   * True when the value, read on its own as a relative reference, would start
+   * with a scheme (RFC 3986 4.2): "javascript:alert(1)", but equally
+   * "bot123:ABC/sendMessage". Route refuses such values so a scheme can never
+   * reach a navigation sink; URL uses this to know when a path it parsed has
+   * to keep its leading "/".
+   */
+  public static hasSchemePrefix(route: string): boolean {
+    return Route.SCHEME_PREFIX.test(route);
+  }
+
   private static validateRoute(route: string): void {
-    if (Route.SCHEME_PREFIX.test(route)) {
+    if (Route.hasSchemePrefix(route)) {
       throw new BadDataException(`Invalid route: ${route}`);
     }
 
+    /*
+     * RFC 3986 path characters: unreserved (which includes "~"), sub-delims,
+     * ":" and "@", plus "/", "?", "#", "[", "]" and "%" for the rest of a
+     * path-and-query. "~" was missing, so "https://example.com/~user" could
+     * not be parsed at all.
+     */
     const matchRouteCharacters: RegExp =
-      /^[a-zA-Z_\d\-!#$%&'()*+,./:;=?@[\]]*$/;
+      /^[a-zA-Z_\d\-!#$%&'()*+,./:;=?@[\]~]*$/;
 
     if (route && !matchRouteCharacters.test(route)) {
       throw new BadDataException(`Invalid route: ${route}`);

package/Types/API/URL.ts

@@ -459,7 +459,26 @@ export default class URL extends DatabaseProperty {
     const path: string = pathSegments.join("/");
 
     if (path || fragment) {
-      route = new Route(path + fragment);
+      /*
+       * The route is held without the "/" that separates it from the
+       * authority ("api/v1/items"), and toString puts it back. Dropping it is
+       * only harmless while the first segment has no ":" — once it does, the
+       * bare path reads as a scheme ("bot123:ABC/sendMessage" is scheme
+       * "bot123", RFC 3986 4.2) and Route rejects it. Telegram puts the bot
+       * token, which always contains a ":", in exactly that segment, so every
+       * https://api.telegram.org/bot<token>/... URL failed to parse — which
+       * broke the Telegram workflow component, the API components, and the
+       * SSRF check on every sandboxed axios call to Telegram.
+       *
+       * Keep the "/" for those paths only. It is the path as written, it
+       * cannot be read as a scheme, and toString produces the same string
+       * either way; every path that parsed before parses to the same Route.
+       */
+      const routeValue: string = path + fragment;
+
+      route = new Route(
+        Route.hasSchemePrefix(routeValue) ? "/" + routeValue : routeValue,
+      );
     }
 
     const queryString: string = URL.queryStringOf(url);
@@ -535,8 +554,13 @@ export default class URL extends DatabaseProperty {
   }
 
   public addRoute(route: Route | string): URL {
+    /*
+     * A string goes to Route.addRoute as-is, which prefixes the "/" before
+     * validating. Wrapping it in a Route first validated the bare form, so
+     * addRoute("bot123:ABC/sendMessage") threw for the same reason as above.
+     */
     if (typeof route === Typeof.String) {
-      this.route.addRoute(new Route(route.toString()));
+      this.route.addRoute(route.toString());
     }
 
     if (route instanceof Route) {