@oneuptime/common 13.0.7 → 14.0.0

package/Tests/App/Dashboard/OnboardingSsoEmptyState.test.tsx

@@ -0,0 +1,185 @@
+import "@testing-library/jest-dom";
+import {
+  act,
+  cleanup,
+  fireEvent,
+  render,
+  screen,
+} from "@testing-library/react";
+import React, { ReactElement, useEffect } from "react";
+import {
+  afterEach,
+  beforeEach,
+  describe,
+  expect,
+  jest,
+  test,
+} from "@jest/globals";
+import ProjectUtil from "../../../UI/Utils/Project";
+import Navigation from "../../../UI/Utils/Navigation";
+import ObjectID from "../../../Types/ObjectID";
+import Route from "../../../Types/API/Route";
+import URL from "../../../Types/API/URL";
+import OnboardingSsoPage from "../../../../App/FeatureSet/Dashboard/src/Pages/Onboarding/SSO";
+import PageMap from "../../../../App/FeatureSet/Dashboard/src/Utils/PageMap";
+import RouteMap from "../../../../App/FeatureSet/Dashboard/src/Utils/RouteMap";
+import { getJestSpyOn } from "../../Spy";
+
+/*
+ * Dashboard > project SSO sign-in (Onboarding/SSO): where a user lands when a
+ * project requires SSO. It lists the project's providers from
+ * /project-sso/:projectId/sso-list.
+ *
+ * That list is empty when the project has no enabled provider - and always on
+ * the Community Edition, where SSO login is part of the Enterprise Edition and
+ * the server lists no providers. The page must then explain why and offer a
+ * way back to sign-in, rather than a dead end.
+ */
+
+type ProviderRow = { _id: string; name: string };
+
+interface ProviderListProps {
+  id: string;
+  overrideFetchApiUrl: URL;
+  noItemsMessage: string;
+  onListLoaded?: (list: Array<ProviderRow>) => void;
+  onSelectChange?: (list: Array<ProviderRow>) => void;
+}
+
+let providersForTest: Array<ProviderRow> = [];
+
+/*
+ * The real ModelList fetches over HTTP; this stand-in "loads" the configured
+ * providers the same way (onListLoaded after mount) and renders them.
+ */
+jest.mock("../../../UI/Components/ModelList/ModelList", () => {
+  return {
+    __esModule: true,
+    default: (props: ProviderListProps): ReactElement => {
+      useEffect(() => {
+        props.onListLoaded?.(providersForTest);
+      }, []);
+
+      return (
+        <div
+          data-testid={props.id}
+          data-fetch-url={props.overrideFetchApiUrl.toString()}
+        >
+          {providersForTest.length === 0 ? (
+            <p>{props.noItemsMessage}</p>
+          ) : (
+            providersForTest.map((provider: ProviderRow) => {
+              return (
+                <button
+                  key={provider._id}
+                  onClick={() => {
+                    props.onSelectChange?.([provider]);
+                  }}
+                >
+                  {provider.name}
+                </button>
+              );
+            })
+          )}
+        </div>
+      );
+    },
+  };
+});
+
+jest.mock("../../../UI/Components/Page/Page", () => {
+  const react: typeof React = jest.requireActual("react") as typeof React;
+
+  return {
+    __esModule: true,
+    default: (props: { children?: React.ReactNode }) => {
+      return react.createElement("div", null, props.children);
+    },
+  };
+});
+
+const PROJECT_ID: ObjectID = new ObjectID(
+  "11111111-1111-4111-8111-111111111111",
+);
+
+const renderPage: () => Promise<void> = async (): Promise<void> => {
+  await act(async () => {
+    render(
+      <OnboardingSsoPage
+        pageRoute={new Route("/dashboard/project/sso")}
+        currentProject={null}
+        hasPaymentMethod={false}
+      />,
+    );
+  });
+};
+
+describe("Dashboard project SSO sign-in page", () => {
+  beforeEach(() => {
+    providersForTest = [];
+    getJestSpyOn(ProjectUtil, "getCurrentProjectId").mockReturnValue(
+      PROJECT_ID,
+    );
+  });
+
+  afterEach(() => {
+    cleanup();
+    jest.restoreAllMocks();
+  });
+
+  test("with no provider (always the case on the Community Edition) it explains why and links back to sign-in", async () => {
+    await renderPage();
+
+    const help: HTMLElement = await screen.findByTestId(
+      "sso-no-providers-help",
+    );
+
+    expect(help).toHaveTextContent(
+      "This project has no single sign-on provider you can use to log in.",
+    );
+    expect(help).toHaveTextContent(
+      "Single sign-on is part of the OneUptime Enterprise Edition",
+    );
+    expect(help).toHaveTextContent(
+      "sign in with your email and password instead",
+    );
+
+    const backToSignIn: HTMLElement = screen.getByText("Back to sign in");
+
+    expect(backToSignIn.closest("a")).toHaveAttribute(
+      "href",
+      RouteMap[PageMap.LOGOUT]!.toString(),
+    );
+  });
+
+  test("with providers it lists them, shows no help text, and signs in with the chosen one", async () => {
+    providersForTest = [
+      { _id: "22222222-2222-4222-8222-222222222222", name: "Okta" },
+    ];
+    const navigate: ReturnType<typeof getJestSpyOn> = getJestSpyOn(
+      Navigation,
+      "navigate",
+    ).mockImplementation(() => {});
+
+    await renderPage();
+
+    expect(
+      screen.queryByTestId("sso-no-providers-help"),
+    ).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByText("Okta"));
+
+    expect(navigate).toHaveBeenCalledTimes(1);
+    expect(String(navigate.mock.calls[0]![0])).toContain(
+      `/sso/${PROJECT_ID.toString()}/22222222-2222-4222-8222-222222222222`,
+    );
+  });
+
+  test("lists providers from the project's sso-list endpoint", async () => {
+    await renderPage();
+
+    expect(
+      screen.getByTestId("sso-list").getAttribute("data-fetch-url"),
+    ).toContain(`/project-sso/${PROJECT_ID.toString()}/sso-list`);
+  });
+});

package/Tests/App/Dashboard/PayAsYouGoConsentGate.test.tsx

@@ -311,38 +311,46 @@ describe("Pay as you go creation notices", () => {
   });
 
   describe("creating a telemetry ingestion key off the Free plan", () => {
-    it("asks for nothing extra on a paid plan", async () => {
-      getJestSpyOn(ProjectUtil, "getCurrentPlan").mockReturnValue(
-        PlanType.Growth,
-      );
-
-      renderIngestionKeyForm();
-
-      await userEvent.type(
-        await screen.findByTestId(
-          "ingestion-key-name",
-          {},
-          { timeout: WAIT_TIMEOUT },
-        ),
-        "Production",
-      );
+    it.each([PlanType.Growth, PlanType.Scale, PlanType.Enterprise])(
+      "creates a key on the %s plan without checking for a payment method",
+      async (plan: PlanType) => {
+        getJestSpyOn(ProjectUtil, "getCurrentPlan").mockReturnValue(plan);
+        jest
+          .spyOn(BaseAPI, "get")
+          .mockResolvedValue({ data: { isAllowed: false } } as any);
+
+        renderIngestionKeyForm();
+
+        await userEvent.type(
+          await screen.findByTestId(
+            "ingestion-key-name",
+            {},
+            { timeout: WAIT_TIMEOUT },
+          ),
+          "Production",
+        );
 
-      expect(
-        screen.queryByTestId("telemetry-pay-as-you-go-consent"),
-      ).not.toBeInTheDocument();
-      expect(
-        screen.queryByRole("region", { name: "Telemetry pricing" }),
-      ).not.toBeInTheDocument();
+        expect(
+          screen.queryByTestId("telemetry-pay-as-you-go-consent"),
+        ).not.toBeInTheDocument();
+        expect(
+          screen.queryByRole("region", { name: "Telemetry pricing" }),
+        ).not.toBeInTheDocument();
+        expect(
+          screen.queryByText(/Add a payment method/),
+        ).not.toBeInTheDocument();
 
-      await userEvent.click(screen.getByText("Create Ingestion Key"));
+        await userEvent.click(screen.getByText("Create Ingestion Key"));
 
-      await waitFor(
-        () => {
-          expect(createOrUpdateMock).toHaveBeenCalled();
-        },
-        { timeout: WAIT_TIMEOUT },
-      );
-    });
+        await waitFor(
+          () => {
+            expect(createOrUpdateMock).toHaveBeenCalledTimes(1);
+          },
+          { timeout: WAIT_TIMEOUT },
+        );
+        expect(BaseAPI.get).not.toHaveBeenCalled();
+      },
+    );
 
     it("asks for nothing extra on a self-hosted install", async () => {
       config.billingEnabled = false;
@@ -411,21 +419,29 @@ describe("Pay as you go creation notices", () => {
   });
 
   describe("creating a monitor off the Free plan", () => {
-    it("advances without a warning or acknowledgement on a paid plan", async () => {
-      getJestSpyOn(ProjectUtil, "getCurrentPlan").mockReturnValue(
-        PlanType.Growth,
-      );
-      renderMonitorPage(MonitorType.Website);
+    it.each([PlanType.Growth, PlanType.Scale, PlanType.Enterprise])(
+      "advances on the %s plan without a payment method or billing warning",
+      async (plan: PlanType) => {
+        getJestSpyOn(ProjectUtil, "getCurrentPlan").mockReturnValue(plan);
+        jest
+          .spyOn(BaseAPI, "get")
+          .mockResolvedValue({ data: { isAllowed: false } } as any);
+        renderMonitorPage(MonitorType.Website);
 
-      await advanceMonitorInfo();
+        await advanceMonitorInfo();
 
-      expect(
-        screen.queryByTestId("monitor-pay-as-you-go-card"),
-      ).not.toBeInTheDocument();
-      expect(
-        screen.queryByTestId("monitor-pay-as-you-go-consent"),
-      ).not.toBeInTheDocument();
-    });
+        expect(
+          screen.queryByTestId("monitor-pay-as-you-go-card"),
+        ).not.toBeInTheDocument();
+        expect(
+          screen.queryByTestId("monitor-pay-as-you-go-consent"),
+        ).not.toBeInTheDocument();
+        expect(
+          screen.queryByText(/Add a payment method/),
+        ).not.toBeInTheDocument();
+        expect(BaseAPI.get).not.toHaveBeenCalled();
+      },
+    );
 
     it("advances without a warning or acknowledgement on a self-hosted install", async () => {
       config.billingEnabled = false;

package/Tests/App/Dashboard/PayAsYouGoNotices.test.tsx

@@ -759,18 +759,55 @@ describe("Pay as you go notices", () => {
       expect(container).toBeEmptyDOMElement();
     });
 
-    it("renders nothing off the Free plan", () => {
-      setPlan(PlanType.Growth);
+    it("keeps a Free plan batch locked when no payment method is available", async () => {
+      const onChange: MockFunction = getJestMockFunction();
+      jest
+        .spyOn(BaseAPI, "get")
+        .mockResolvedValue({ data: { isAllowed: false } } as any);
 
-      const { container }: { container: HTMLElement } = render(
+      render(
         <MonitorBatchPayAsYouGoConsent
           monitorTypes={[MonitorType.Kubernetes]}
           value={false}
-          onChange={() => {}}
+          onChange={onChange as (value: boolean) => void}
         />,
       );
 
-      expect(container).toBeEmptyDOMElement();
+      expect(
+        await screen.findByText(/Add a payment method before using/),
+      ).toBeInTheDocument();
+      const consent: HTMLElement = screen.getByTestId(
+        "monitor-batch-pay-as-you-go-consent",
+      );
+      expect(consent).toBeDisabled();
+      await userEvent.click(consent);
+      expect(onChange).not.toHaveBeenCalled();
+      expect(BaseAPI.get).toHaveBeenCalledTimes(1);
     });
+
+    it.each([PlanType.Growth, PlanType.Scale, PlanType.Enterprise])(
+      "does not check or require a payment method for a %s plan batch",
+      (plan: PlanType) => {
+        setPlan(plan);
+        jest
+          .spyOn(BaseAPI, "get")
+          .mockResolvedValue({ data: { isAllowed: false } } as any);
+
+        const { container }: { container: HTMLElement } = render(
+          <MonitorBatchPayAsYouGoConsent
+            monitorTypes={[
+              MonitorType.Kubernetes,
+              MonitorType.Website,
+              MonitorType.Manual,
+            ]}
+            value={false}
+            onChange={() => {}}
+          />,
+        );
+
+        expect(container).toBeEmptyDOMElement();
+        expect(BaseAPI.get).not.toHaveBeenCalled();
+      },
+    );
   });
 });

package/Tests/App/Dashboard/ResourceAuditLogsSideMenus.test.tsx

@@ -92,8 +92,9 @@ interface ResourceAuditMenuCase {
   name: string;
   menu: () => ReactElement;
   auditPage: PageMap;
+  auditSection: string;
   sections: Array<string>;
-  advancedLinks: Array<ExpectedLink>;
+  auditSectionLinks: Array<ExpectedLink>;
 }
 
 const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
@@ -103,6 +104,7 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       return <IncidentSideMenu modelId={MODEL_ID} />;
     },
     auditPage: PageMap.INCIDENT_VIEW_AUDIT_LOGS,
+    auditSection: "Advanced",
     sections: [
       "Overview",
       "Investigation",
@@ -111,7 +113,7 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       "Notes",
       "Advanced",
     ],
-    advancedLinks: [
+    auditSectionLinks: [
       {
         title: "Custom Fields",
         page: PageMap.INCIDENT_VIEW_CUSTOM_FIELDS,
@@ -129,8 +131,9 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       );
     },
     auditPage: PageMap.MONITOR_VIEW_AUDIT_LOGS,
+    auditSection: "Advanced",
     sections: ["Overview", "Activity", "Configuration", "Advanced"],
-    advancedLinks: [
+    auditSectionLinks: [
       { title: "Owners", page: PageMap.MONITOR_VIEW_OWNERS },
       { title: "Custom Fields", page: PageMap.MONITOR_VIEW_CUSTOM_FIELDS },
       { title: "Settings", page: PageMap.MONITOR_VIEW_SETTINGS },
@@ -144,8 +147,9 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       return <SloSideMenu modelId={MODEL_ID} />;
     },
     auditPage: PageMap.SLO_VIEW_AUDIT_LOGS,
-    sections: ["SLO", "Advanced"],
-    advancedLinks: [
+    auditSection: "Management",
+    sections: ["Overview", "Activity", "Configuration", "Management"],
+    auditSectionLinks: [
       { title: "Owners", page: PageMap.SLO_VIEW_OWNERS },
       { title: "Settings", page: PageMap.SLO_VIEW_SETTINGS },
       { title: "Audit Logs", page: PageMap.SLO_VIEW_AUDIT_LOGS },
@@ -158,6 +162,7 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       return <StatusPageSideMenu modelId={MODEL_ID} />;
     },
     auditPage: PageMap.STATUS_PAGE_VIEW_AUDIT_LOGS,
+    auditSection: "Advanced",
     sections: [
       "Basic",
       "Resources",
@@ -168,7 +173,7 @@ const RESOURCE_CASES: Array<ResourceAuditMenuCase> = [
       "AI",
       "Advanced",
     ],
-    advancedLinks: [
+    auditSectionLinks: [
       { title: "Embedded Status", page: PageMap.STATUS_PAGE_VIEW_EMBEDDED },
       { title: "Reports", page: PageMap.STATUS_PAGE_VIEW_REPORTS },
       {
@@ -228,11 +233,11 @@ describe.each(RESOURCE_CASES)(
       expect(sectionTitlesInOrder()).not.toContain("Settings");
     });
 
-    test("keeps every Advanced destination in the expected order", async () => {
+    test("keeps every destination in the audit section in the expected order", async () => {
       await renderAuditPage(resource);
 
-      expect(linksIn("Advanced")).toEqual(
-        resource.advancedLinks.map((link: ExpectedLink): MenuLink => {
+      expect(linksIn(resource.auditSection)).toEqual(
+        resource.auditSectionLinks.map((link: ExpectedLink): MenuLink => {
           return {
             title: link.title,
             href: resourceRoute(link.page),
@@ -259,25 +264,29 @@ describe.each(RESOURCE_CASES)(
       });
     });
 
-    test("marks Audit Logs active and expands Advanced", async () => {
+    test("marks Audit Logs active and expands its section", async () => {
       const auditPath: string = await renderAuditPage(resource);
       const auditLogAnchor: HTMLAnchorElement | undefined = Array.from(
-        sectionRoot("Advanced").querySelectorAll<HTMLAnchorElement>("a"),
+        sectionRoot(resource.auditSection).querySelectorAll<HTMLAnchorElement>(
+          "a",
+        ),
       ).find((anchor: HTMLAnchorElement): boolean => {
         return anchor.getAttribute("href") === auditPath;
       });
 
       expect(auditLogAnchor).toBeDefined();
       expect(auditLogAnchor).toHaveClass("bg-indigo-50", "text-indigo-700");
-      expect(isExpanded("Advanced")).toBe(true);
+      expect(isExpanded(resource.auditSection)).toBe(true);
     });
 
-    test("names Audit Logs as an Advanced page in the mobile summary", async () => {
+    test("names the Audit Logs section in the mobile summary", async () => {
       setViewportWidth(MOBILE_WIDTH);
 
       await renderAuditPage(resource);
 
-      expect(mobileSummaryText()).toContain("Advanced / Audit Logs");
+      expect(mobileSummaryText()).toContain(
+        `${resource.auditSection} / Audit Logs`,
+      );
     });
 
     test("retains a visible label and icon for every destination", async () => {
@@ -296,20 +305,18 @@ describe.each(RESOURCE_CASES)(
 );
 
 /*
- * The SLO section follows what an SLO is made of: the monitors it measures
- * and the rules that attach them, its burn-rate rules and metrics, what it
- * raised, then its feed. Charts is deliberately absent - its history lives in
- * Metrics, and its route only survives for bookmarks.
+ * SLO performance and activity precede configuration. Charts remains absent:
+ * its history lives in Metrics, and its route only survives for bookmarks.
  */
 const SLO_SECTION_LINKS: Array<ExpectedLink> = [
   { title: "Overview", page: PageMap.SLO_VIEW },
-  { title: "Monitors", page: PageMap.SLO_VIEW_MONITORS },
-  { title: "Monitor Rules", page: PageMap.SLO_VIEW_MONITOR_RULES },
-  { title: "Burn Rate Rules", page: PageMap.SLO_VIEW_BURN_RATE_RULES },
   { title: "Metrics", page: PageMap.SLO_VIEW_METRICS },
-  { title: "Alerts", page: PageMap.SLO_VIEW_ALERTS },
   { title: "Incidents", page: PageMap.SLO_VIEW_INCIDENTS },
+  { title: "Alerts", page: PageMap.SLO_VIEW_ALERTS },
   { title: "Feed", page: PageMap.SLO_VIEW_FEED },
+  { title: "Monitors", page: PageMap.SLO_VIEW_MONITORS },
+  { title: "Monitor Rules", page: PageMap.SLO_VIEW_MONITOR_RULES },
+  { title: "Burn Rate Rules", page: PageMap.SLO_VIEW_BURN_RATE_RULES },
 ];
 
 describe("SLO resource menu", () => {
@@ -324,7 +331,11 @@ describe("SLO resource menu", () => {
 
     await renderAuditPage(slo!);
 
-    expect(linksIn("SLO")).toEqual(
+    expect([
+      ...linksIn("Overview"),
+      ...linksIn("Activity"),
+      ...linksIn("Configuration"),
+    ]).toEqual(
       SLO_SECTION_LINKS.map((link: ExpectedLink): MenuLink => {
         return {
           title: link.title,