@oneuptime/common 13.0.4 → 13.0.6

package/Server/Utils/AI/Toolbox/SloTools.ts

@@ -1,5 +1,14 @@
+import Label from "../../../../Models/DatabaseModels/Label";
 import ServiceLevelObjective from "../../../../Models/DatabaseModels/ServiceLevelObjective";
 import ServiceLevelObjectiveBurnRateRule from "../../../../Models/DatabaseModels/ServiceLevelObjectiveBurnRateRule";
+import ServiceLevelObjectiveMonitorRule from "../../../../Models/DatabaseModels/ServiceLevelObjectiveMonitorRule";
+import {
+  describeSloMonitorRuleCriteria,
+  getSloMonitorRuleLabelIds,
+} from "../../../../Utils/Slo/SloMonitorRuleCriteria";
+import LabelService from "../../../Services/LabelService";
+import ServiceLevelObjectiveMonitorRuleService from "../../../Services/ServiceLevelObjectiveMonitorRuleService";
+import NotAuthorizedException from "../../../../Types/Exception/NotAuthorizedException";
 import { JSONObject } from "../../../../Types/JSON";
 import ObjectID from "../../../../Types/ObjectID";
 import Permission from "../../../../Types/Permission";
@@ -48,6 +57,34 @@ const resolveReadPermissions: () => Array<Permission> =
 const COMPLIANCE_NOTE: string =
   "Note: compliance figures (currentSliPercentage, errorBudgetRemaining*, currentBurnRate, sloStatus) are the platform's persisted values from the last worker evaluation (see lastEvaluatedAt) — not recomputed live. Rows without these fields have not been evaluated yet.\n";
 
+/*
+ * An archived SLO is retired: hidden from the SLO list and skipped by the
+ * evaluation worker, so every compliance figure on its row is frozen at the
+ * moment it was archived. Without this the model would report a months-old
+ * "Healthy" as the SLO's current state.
+ */
+const ARCHIVED_NOTE: string =
+  "Note: this SLO is archived — it is hidden from the SLO list and is no longer evaluated, so its compliance figures are frozen as of its last evaluation before it was archived (see archivedAt). Unarchive it in the dashboard to resume measuring.\n";
+
+/*
+ * The one-word state a person sees in the SLO list, with the same precedence
+ * the list's Status column uses: Archived, then Disabled, then the persisted
+ * status. A disabled or archived SLO keeps its last status column, and
+ * reporting that stale value would claim a live measurement that is not
+ * happening.
+ */
+function describeLifecycleStatus(slo: ServiceLevelObjective): string {
+  if (slo.isArchived === true) {
+    return "Archived";
+  }
+
+  if (slo.isEnabled === false) {
+    return "Disabled";
+  }
+
+  return slo.sloStatus || "";
+}
+
 function joinNames(items: Array<{ name?: string }> | undefined): string {
   return (items || [])
     .map((item: { name?: string }) => {
@@ -59,6 +96,19 @@ function joinNames(items: Array<{ name?: string }> | undefined): string {
     .join(", ");
 }
 
+/*
+ * Whether a burn-rate title or description template will actually be used.
+ * The template renderer treats a blank or whitespace-only template as unset
+ * and falls back to the default text, so this does too.
+ */
+function hasBurnRateTemplate(template: string | undefined): boolean {
+  return typeof template === "string" && template.trim() !== "";
+}
+
+function countOf(items: Array<unknown> | undefined): number {
+  return (items || []).length;
+}
+
 // "Rolling 30d" / "Calendar Month" — compact window description for one row.
 function describeWindow(slo: ServiceLevelObjective): string {
   if (slo.windowType === SloWindowType.CalendarMonth) {
@@ -75,17 +125,128 @@ function formatPercent(value: number | undefined | null): string {
   return `${Math.round(value * 100) / 100}%`;
 }
 
+/*
+ * The two rule tables have their own read permissions
+ * (ReadServiceLevelObjectiveMonitorRule, ReadServiceLevelObjectiveBurnRateRule),
+ * separate from ReadServiceLevelObjective, which gates this tool. A custom role
+ * can read SLOs without being able to read one or both rule tables. Every
+ * custom role created before monitor rules shipped is in that position, since
+ * it cannot hold a permission that did not exist yet. For such a caller the
+ * rule read throws NotAuthorizedException. Letting that escape fails the whole
+ * tool call, and the model loses the SLO definition it was allowed to see. So
+ * a denied rule read is reported as "not visible" and the rest is returned.
+ *
+ * Only a permission denial is absorbed. Any other failure (a lost database
+ * connection, a bad query) still fails the call, so it is never presented as
+ * "this SLO has no rules".
+ */
+interface ChildRowsRead<T> {
+  rows: Array<T>;
+  isPermitted: boolean;
+}
+
+async function readChildRowsIfPermitted<T>(
+  read: () => Promise<Array<T>>,
+): Promise<ChildRowsRead<T>> {
+  try {
+    return {
+      rows: await read(),
+      isPermitted: true,
+    };
+  } catch (error) {
+    if (error instanceof NotAuthorizedException) {
+      return {
+        rows: [],
+        isPermitted: false,
+      };
+    }
+
+    throw error;
+  }
+}
+
+/*
+ * Travels with the result when a rule table was not readable. Without it the
+ * model would read the missing rows as "this SLO has no rules" and tell the
+ * user so.
+ */
+const MONITOR_RULES_NOT_VISIBLE_NOTE: string =
+  "Note: this SLO's monitor rules are left out because the current user does not have permission to read SLO Monitor Rules (ReadServiceLevelObjectiveMonitorRule). Do not conclude that the SLO has no monitor rules; say which permission is missing if the user asks about them.\n";
+
+const BURN_RATE_RULES_NOT_VISIBLE_NOTE: string =
+  "Note: this SLO's burn-rate rules are left out because the current user does not have permission to read SLO Burn Rate Rules (ReadServiceLevelObjectiveBurnRateRule). Do not conclude that the SLO has no burn-rate rules; say which permission is missing if the user asks about them.\n";
+
+const NOT_VISIBLE_WIDGET_VALUE: string = "not visible to you";
+
+/*
+ * Label names for the monitor rule descriptions. Legacy rules carry their
+ * label names in the select already; rules on configurable criteria store
+ * only label ids, so those are looked up - under the user's own props, so a
+ * label the user cannot read stays unnamed. A lookup that fails degrades to
+ * "an unknown label" in the description rather than failing the whole tool.
+ */
+async function resolveMonitorRuleLabelNames(data: {
+  monitorRules: Array<ServiceLevelObjectiveMonitorRule>;
+  ctx: ToolContext;
+}): Promise<Map<string, string>> {
+  const labelNameById: Map<string, string> = new Map<string, string>();
+  const unnamedLabelIds: Set<string> = new Set<string>();
+
+  for (const monitorRule of data.monitorRules) {
+    for (const label of monitorRule.monitorLabels || []) {
+      if (label.id && label.name) {
+        labelNameById.set(label.id.toString(), label.name);
+      }
+    }
+
+    for (const labelId of getSloMonitorRuleLabelIds(monitorRule)) {
+      if (!labelNameById.has(labelId) && ObjectID.isValidUUID(labelId)) {
+        unnamedLabelIds.add(labelId);
+      }
+    }
+  }
+
+  if (unnamedLabelIds.size === 0) {
+    return labelNameById;
+  }
+
+  try {
+    const labels: Array<Label> = await LabelService.findBy({
+      query: {
+        _id: QueryHelper.any(Array.from(unnamedLabelIds)),
+      },
+      select: {
+        _id: true,
+        name: true,
+      },
+      limit: unnamedLabelIds.size,
+      skip: 0,
+      props: data.ctx.props,
+    });
+
+    for (const label of labels) {
+      if (label.id && label.name) {
+        labelNameById.set(label.id.toString(), label.name);
+      }
+    }
+  } catch {
+    // Described as unknown labels instead; see above.
+  }
+
+  return labelNameById;
+}
+
 export const QuerySlosTool: ObservabilityTool = {
   name: "query_slos",
   description:
-    "List Service Level Objectives (SLOs) in this project: what each one measures (monitor uptime or a metric SLI), its target percentage, compliance window, attached monitors, and the latest persisted compliance status — current SLI %, error budget remaining and burn rate as computed by the platform at its last evaluation (this tool never recomputes compliance live). Pass sloId (an SLO ID from this tool's own list results) to get one SLO's full definition plus its burn-rate rules, their thresholds, and whether each raises an alert, declares an incident, or both. Use query_alerts to see alerts those burn-rate rules raised, query_incidents for the incidents they declared, and query_monitors for the current status of an SLO's monitors.",
+    "List Service Level Objectives (SLOs) in this project: what each one measures (monitor uptime or a metric SLI), its target percentage, compliance window, attached monitors, and the latest persisted compliance status — current SLI %, error budget remaining and burn rate as computed by the platform at its last evaluation (this tool never recomputes compliance live). Pass sloId (an SLO ID from this tool's own list results) to get one SLO's full definition plus its burn-rate rules, their thresholds, whether each raises an alert, declares an incident, or both, and what each output is created with (custom title/description templates, label and owner counts, private and auto-resolve settings, and whether the SLO's owners are added). Use query_alerts to see alerts those burn-rate rules raised, query_incidents for the incidents they declared, and query_monitors for the current status of an SLO's monitors. Archived SLOs (retired: hidden from the SLO list and no longer evaluated) are left out of lists unless includeArchived is true; looking one up by sloId still works and says it is archived.",
   inputSchema: {
     type: "object",
     properties: {
       sloId: {
         type: "string",
         description:
-          "Get one SLO by its ID — includes the full definition (SLI type, downtime statuses, monitor labels, at-risk threshold, error budget seconds) and its burn-rate rules with thresholds, windows, and what each rule declares when it fires.",
+          "Get one SLO by its ID — includes the full definition (SLI type, downtime statuses, at-risk threshold, error budget seconds), its monitor rules (which monitors each rule attaches, and whether it is enabled), and its burn-rate rules with thresholds, windows, and what each rule declares when it fires.",
       },
       sloStatus: {
         type: "string",
@@ -93,6 +254,11 @@ export const QuerySlosTool: ObservabilityTool = {
         description:
           "Only list SLOs currently in this status (e.g. 'At Risk' or 'Budget Exhausted' to find SLOs in trouble).",
       },
+      includeArchived: {
+        type: "boolean",
+        description:
+          "Also list archived SLOs (default false). Archived SLOs are retired — hidden from the SLO list and no longer evaluated — so their compliance figures are frozen. Only set this when the user asks about archived or retired SLOs.",
+      },
       nameSearch: {
         type: "string",
         description: "Filter SLOs whose name contains this text.",
@@ -126,6 +292,8 @@ export const QuerySlosTool: ObservabilityTool = {
             name: true,
             description: true,
             isEnabled: true,
+            isArchived: true,
+            archivedAt: true,
             sliType: true,
             multiMonitorMode: true,
             metricQueryConfig: true,
@@ -145,9 +313,6 @@ export const QuerySlosTool: ObservabilityTool = {
               _id: true,
               name: true,
             },
-            monitorLabels: {
-              name: true,
-            },
             downtimeMonitorStatuses: {
               name: true,
             },
@@ -167,6 +332,8 @@ export const QuerySlosTool: ObservabilityTool = {
           name: slo.name,
           description: slo.description,
           isEnabled: slo.isEnabled,
+          isArchived: slo.isArchived,
+          archivedAt: slo.archivedAt,
           sliType: slo.sliType,
           multiMonitorMode: slo.multiMonitorMode,
           metricQueryConfig: slo.metricQueryConfig,
@@ -182,58 +349,176 @@ export const QuerySlosTool: ObservabilityTool = {
           currentBurnRate: slo.currentBurnRate,
           lastEvaluatedAt: slo.lastEvaluatedAt,
           monitors: joinNames(slo.monitors) || undefined,
-          autoAttachMonitorLabels: joinNames(slo.monitorLabels) || undefined,
           downtimeMonitorStatuses:
             joinNames(slo.downtimeMonitorStatuses) || undefined,
           labels: joinNames(slo.labels) || undefined,
         });
       }
 
+      /*
+       * Monitor rules decide which of those monitors the SLO measures, so the
+       * model can explain why a monitor is (or is not) on it. Fetched only
+       * when the SLO itself is visible - the rule table is OwnedThrough the
+       * SLO, exactly like the burn-rate rules below. A caller who may read
+       * the SLO but not its monitor rules still gets the SLO; see
+       * readChildRowsIfPermitted.
+       */
+      let monitorRules: Array<ServiceLevelObjectiveMonitorRule> = [];
+      let areMonitorRulesVisible: boolean = true;
+
+      if (slo) {
+        const monitorRulesRead: ChildRowsRead<ServiceLevelObjectiveMonitorRule> =
+          await readChildRowsIfPermitted<ServiceLevelObjectiveMonitorRule>(
+            (): Promise<Array<ServiceLevelObjectiveMonitorRule>> => {
+              return ServiceLevelObjectiveMonitorRuleService.findBy({
+                query: {
+                  serviceLevelObjectiveId: sloId,
+                },
+                select: {
+                  _id: true,
+                  name: true,
+                  isEnabled: true,
+                  monitorLabels: {
+                    _id: true,
+                    name: true,
+                  },
+                  monitorNamePattern: true,
+                  monitorDescriptionPattern: true,
+                  criteria: true,
+                },
+                sort: {
+                  name: SortOrder.Ascending,
+                },
+                limit: 25,
+                skip: 0,
+                props: ctx.props,
+              });
+            },
+          );
+
+        monitorRules = monitorRulesRead.rows;
+        areMonitorRulesVisible = monitorRulesRead.isPermitted;
+      }
+
+      const monitorRuleLabelNameById: Map<string, string> =
+        await resolveMonitorRuleLabelNames({
+          monitorRules: monitorRules,
+          ctx: ctx,
+        });
+
+      for (const monitorRule of monitorRules) {
+        rows.push({
+          record: "monitorRule",
+          id: monitorRule.id?.toString(),
+          name: monitorRule.name,
+          // A NOT NULL column that defaults to true; absent reads as enabled.
+          isEnabled: monitorRule.isEnabled !== false,
+          matches: describeSloMonitorRuleCriteria({
+            rule: monitorRule,
+            labelNameById: monitorRuleLabelNameById,
+          }),
+        });
+      }
+
       /*
        * Burn-rate rules are only fetched when the SLO itself is visible to
        * the user — the rule table is OwnedThrough the SLO, so this also
-       * avoids leaking rule names for an SLO the user cannot read.
+       * avoids leaking rule names for an SLO the user cannot read. Same
+       * degradation as the monitor rules above when the rule table is not
+       * readable.
        */
       let rules: Array<ServiceLevelObjectiveBurnRateRule> = [];
+      let areBurnRateRulesVisible: boolean = true;
 
       if (slo) {
-        rules = await ServiceLevelObjectiveBurnRateRuleService.findBy({
-          query: {
-            serviceLevelObjectiveId: sloId,
-          },
-          select: {
-            _id: true,
-            name: true,
-            isEnabled: true,
-            burnRateThreshold: true,
-            longWindowInMinutes: true,
-            shortWindowInMinutes: true,
-            minimumSampleCount: true,
-            refireSuppressionMinutes: true,
-            shouldCreateAlert: true,
-            alertSeverity: {
-              name: true,
-            },
-            shouldCreateIncident: true,
-            incidentSeverity: {
-              name: true,
+        const burnRateRulesRead: ChildRowsRead<ServiceLevelObjectiveBurnRateRule> =
+          await readChildRowsIfPermitted<ServiceLevelObjectiveBurnRateRule>(
+            (): Promise<Array<ServiceLevelObjectiveBurnRateRule>> => {
+              return ServiceLevelObjectiveBurnRateRuleService.findBy({
+                query: {
+                  serviceLevelObjectiveId: sloId,
+                },
+                select: {
+                  _id: true,
+                  name: true,
+                  isEnabled: true,
+                  burnRateThreshold: true,
+                  longWindowInMinutes: true,
+                  shortWindowInMinutes: true,
+                  minimumSampleCount: true,
+                  refireSuppressionMinutes: true,
+                  shouldCreateAlert: true,
+                  alertSeverity: {
+                    name: true,
+                  },
+                  shouldCreateIncident: true,
+                  incidentSeverity: {
+                    name: true,
+                  },
+                  /*
+                   * The options each output is created with. Remediation notes and
+                   * on-call policies are left out: they do not change what the
+                   * alert or incident is, and remediation notes are the longest
+                   * text on the row. The many-to-many lists select ids only - they
+                   * are reported as counts - so no label, team or user row is
+                   * loaded for them.
+                   */
+                  alertTitleTemplate: true,
+                  alertDescriptionTemplate: true,
+                  isAlertPrivate: true,
+                  autoResolveAlert: true,
+                  alertLabels: {
+                    _id: true,
+                  },
+                  alertOwnerTeams: {
+                    _id: true,
+                  },
+                  alertOwnerUsers: {
+                    _id: true,
+                  },
+                  incidentTitleTemplate: true,
+                  incidentDescriptionTemplate: true,
+                  isIncidentPrivate: true,
+                  autoResolveIncident: true,
+                  incidentLabels: {
+                    _id: true,
+                  },
+                  incidentOwnerTeams: {
+                    _id: true,
+                  },
+                  incidentOwnerUsers: {
+                    _id: true,
+                  },
+                  addSloOwnersAsOwners: true,
+                  lastAlertCreatedAt: true,
+                  lastAlertResolvedAt: true,
+                  lastIncidentCreatedAt: true,
+                  lastIncidentResolvedAt: true,
+                },
+                sort: {
+                  burnRateThreshold: SortOrder.Descending,
+                },
+                limit: 25,
+                skip: 0,
+                props: ctx.props,
+              });
             },
-            lastAlertCreatedAt: true,
-            lastAlertResolvedAt: true,
-            lastIncidentCreatedAt: true,
-            lastIncidentResolvedAt: true,
-          },
-          sort: {
-            burnRateThreshold: SortOrder.Descending,
-          },
-          limit: 25,
-          skip: 0,
-          props: ctx.props,
-        });
+          );
+
+        rules = burnRateRulesRead.rows;
+        areBurnRateRulesVisible = burnRateRulesRead.isPermitted;
       }
 
       for (const rule of rules) {
-        rows.push({
+        /*
+         * Read with the model's own defaults so a rule written before
+         * incidents existed reports "creates an alert" rather than a blank
+         * the model would have to guess at.
+         */
+        const createsAlert: boolean = rule.shouldCreateAlert !== false;
+        const createsIncident: boolean = rule.shouldCreateIncident === true;
+
+        const row: JSONObject = {
           record: "burnRateRule",
           id: rule.id?.toString(),
           name: rule.name,
@@ -243,20 +528,60 @@ export const QuerySlosTool: ObservabilityTool = {
           shortWindowInMinutes: rule.shortWindowInMinutes,
           minimumSampleCount: rule.minimumSampleCount,
           refireSuppressionMinutes: rule.refireSuppressionMinutes,
-          /*
-           * Read with the model's own defaults so a rule written before
-           * incidents existed reports "creates an alert" rather than a blank
-           * the model would have to guess at.
-           */
-          createsAlert: rule.shouldCreateAlert !== false,
+          createsAlert: createsAlert,
           alertSeverity: rule.alertSeverity?.name,
-          createsIncident: rule.shouldCreateIncident === true,
+          createsIncident: createsIncident,
           incidentSeverity: rule.incidentSeverity?.name,
           lastAlertCreatedAt: rule.lastAlertCreatedAt,
           lastAlertResolvedAt: rule.lastAlertResolvedAt,
           lastIncidentCreatedAt: rule.lastIncidentCreatedAt,
           lastIncidentResolvedAt: rule.lastIncidentResolvedAt,
-        });
+        };
+
+        /*
+         * What each output is created with, reported only for an output the
+         * rule produces: every rule carries autoResolveIncident=true as a
+         * column default, and handing that to the model for an alert-only
+         * rule would read as if it declared incidents. The flags use the
+         * defaults the worker applies (`!== false` for auto-resolve,
+         * `=== true` for private and addSloOwnersAsOwners). Templates are
+         * reported as set or not rather than inlined - free text that would
+         * crowd out the rows around it - and labels and owners as counts,
+         * since only their ids are selected.
+         */
+        if (createsAlert) {
+          row["hasAlertTitleTemplate"] = hasBurnRateTemplate(
+            rule.alertTitleTemplate,
+          );
+          row["hasAlertDescriptionTemplate"] = hasBurnRateTemplate(
+            rule.alertDescriptionTemplate,
+          );
+          row["alertLabelCount"] = countOf(rule.alertLabels);
+          row["alertOwnerTeamCount"] = countOf(rule.alertOwnerTeams);
+          row["alertOwnerUserCount"] = countOf(rule.alertOwnerUsers);
+          row["isAlertPrivate"] = rule.isAlertPrivate === true;
+          row["autoResolveAlert"] = rule.autoResolveAlert !== false;
+        }
+
+        if (createsIncident) {
+          row["hasIncidentTitleTemplate"] = hasBurnRateTemplate(
+            rule.incidentTitleTemplate,
+          );
+          row["hasIncidentDescriptionTemplate"] = hasBurnRateTemplate(
+            rule.incidentDescriptionTemplate,
+          );
+          row["incidentLabelCount"] = countOf(rule.incidentLabels);
+          row["incidentOwnerTeamCount"] = countOf(rule.incidentOwnerTeams);
+          row["incidentOwnerUserCount"] = countOf(rule.incidentOwnerUsers);
+          row["isIncidentPrivate"] = rule.isIncidentPrivate === true;
+          row["autoResolveIncident"] = rule.autoResolveIncident !== false;
+        }
+
+        if (createsAlert || createsIncident) {
+          row["addSloOwnersAsOwners"] = rule.addSloOwnersAsOwners === true;
+        }
+
+        rows.push(row);
       }
 
       const serialized: SerializedResult =
@@ -265,7 +590,7 @@ export const QuerySlosTool: ObservabilityTool = {
       return {
         dataForLlm:
           rows.length > 0
-            ? `${COMPLIANCE_NOTE}${serialized.text}`
+            ? `${slo?.isArchived === true ? ARCHIVED_NOTE : ""}${areMonitorRulesVisible ? "" : MONITOR_RULES_NOT_VISIBLE_NOTE}${areBurnRateRulesVisible ? "" : BURN_RATE_RULES_NOT_VISIBLE_NOTE}${COMPLIANCE_NOTE}${serialized.text}`
             : serialized.text,
         rowCount: serialized.rowCount,
         citationLabel: `SLO ${slo?.name || sloId.toString()}`,
@@ -288,7 +613,7 @@ export const QuerySlosTool: ObservabilityTool = {
                 },
                 { label: "Window", value: describeWindow(slo) },
                 { label: "SLI type", value: slo.sliType || "" },
-                { label: "Status", value: slo.sloStatus || "" },
+                { label: "Status", value: describeLifecycleStatus(slo) },
                 {
                   label: "Current SLI",
                   value: formatPercent(slo.currentSliPercentage),
@@ -306,7 +631,31 @@ export const QuerySlosTool: ObservabilityTool = {
                       : "not evaluated yet",
                 },
                 { label: "Monitors", value: joinNames(slo.monitors) || "none" },
-                { label: "Burn-rate rules", value: String(rules.length) },
+                {
+                  label: "Monitor rules",
+                  /*
+                   * Not "none" when the rules could not be read: that would
+                   * claim the monitors are picked by hand.
+                   */
+                  value: !areMonitorRulesVisible
+                    ? NOT_VISIBLE_WIDGET_VALUE
+                    : monitorRules.length === 0
+                      ? "none - monitors are picked by hand"
+                      : `${
+                          monitorRules.filter(
+                            (monitorRule: ServiceLevelObjectiveMonitorRule) => {
+                              return monitorRule.isEnabled !== false;
+                            },
+                          ).length
+                        } of ${monitorRules.length} enabled`,
+                },
+                {
+                  label: "Burn-rate rules",
+                  // Not "0" when the rules could not be read.
+                  value: areBurnRateRulesVisible
+                    ? String(rules.length)
+                    : NOT_VISIBLE_WIDGET_VALUE,
+                },
               ],
               link: {
                 type: AIChatCitationTargetType.SloView,
@@ -359,7 +708,20 @@ export const QuerySlosTool: ObservabilityTool = {
       max: 500,
     });
 
+    /*
+     * Archived SLOs are left out by default, matching the SLO list a person
+     * sees: "which SLOs are at risk?" must not surface a retired SLO whose
+     * status froze months ago. Asked explicitly, they are included — and each
+     * one is flagged on its row. The filter goes on the shared query, so the
+     * total below counts exactly the set being paged.
+     */
+    const includeArchived: boolean =
+      ToolArgs.getBoolean(args, "includeArchived") === true;
+
     const query: Query<ServiceLevelObjective> = {};
+    if (!includeArchived) {
+      query.isArchived = false;
+    }
     if (statusFilter) {
       query.sloStatus = statusFilter;
     }
@@ -374,6 +736,7 @@ export const QuerySlosTool: ObservabilityTool = {
           _id: true,
           name: true,
           isEnabled: true,
+          isArchived: true,
           sliType: true,
           targetPercentage: true,
           windowType: true,
@@ -407,6 +770,8 @@ export const QuerySlosTool: ObservabilityTool = {
         id: slo.id?.toString(),
         name: slo.name,
         isEnabled: slo.isEnabled,
+        // only archived rows carry the flag; the serializer drops undefined.
+        isArchived: slo.isArchived === true ? true : undefined,
         sliType: slo.sliType,
         targetPercentage: slo.targetPercentage,
         window: describeWindow(slo),

package/Server/Utils/AI/Toolbox/TimelineTools.ts

@@ -117,6 +117,13 @@ const keepNewestChronological: (
   return newestFirst.slice(0, limit).reverse();
 };
 
+// "1 entry" / "12 entries", for the citation label a responder reads.
+export const formatTimelineEntryCount: (count: number) => string = (
+  count: number,
+): string => {
+  return `${count} ${count === 1 ? "entry" : "entries"}`;
+};
+
 const timelineWidgetColumns: Array<AIChatWidgetColumn> = [
   { key: "at", title: "When", type: "date" },
   { key: "type", title: "Type" },
@@ -368,7 +375,7 @@ export const GetIncidentTimelineTool: ObservabilityTool = {
     return {
       dataForLlm: dataForLlm,
       rowCount: serialized.rowCount,
-      citationLabel: `Incident ${incidentLabel} timeline (${serialized.rowCount} entries)`,
+      citationLabel: `Incident ${incidentLabel} timeline (${formatTimelineEntryCount(serialized.rowCount)})`,
       citationTarget: {
         type: AIChatCitationTargetType.IncidentView,
         params: { incidentId: incidentId.toString() },
@@ -590,7 +597,7 @@ export const GetAlertTimelineTool: ObservabilityTool = {
     return {
       dataForLlm: dataForLlm,
       rowCount: serialized.rowCount,
-      citationLabel: `Alert ${alertLabel} timeline (${serialized.rowCount} entries)`,
+      citationLabel: `Alert ${alertLabel} timeline (${formatTimelineEntryCount(serialized.rowCount)})`,
       citationTarget: {
         type: AIChatCitationTargetType.AlertView,
         params: { alertId: alertId.toString() },