@onerjs/core 8.30.8 → 8.30.9

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@onerjs/core",
-    "version": "8.30.8",
+    "version": "8.30.9",
     "main": "index.js",
     "module": "index.js",
     "types": "index.d.ts",

package/scene.d.ts

@@ -169,8 +169,6 @@ export declare class Scene implements IAnimatable, IClipPlanesHolder, IAssetCont
      */
     autoClearDepthAndStencil: boolean;
     private _clearColor;
-    private _tempVect3;
-    private _tempVect4;
     /**
      * Observable triggered when the performance priority is changed
      */
@@ -834,7 +832,7 @@ export declare class Scene implements IAnimatable, IClipPlanesHolder, IAssetCont
      * @param effect The effect to be bound
      * @param variableName name of the shader variable that will hold the eye position
      * @param isVector3 true to indicates that variableName is a Vector3 and not a Vector4
-     * @returns the computed eye position
+     * @returns the computed eye position in a temp vector, caller can copy values as needed
      */
     bindEyePosition(effect: Nullable<Effect>, variableName?: string, isVector3?: boolean): Vector4;
     /**

package/scene.js

@@ -4,7 +4,7 @@ import { Observable } from "./Misc/observable.js";
 import { SmartArrayNoDuplicate, SmartArray } from "./Misc/smartArray.js";
 import { StringDictionary } from "./Misc/stringDictionary.js";
 import { Tags } from "./Misc/tags.js";
-import { Vector3, Vector4, Matrix, TmpVectors } from "./Maths/math.vector.js";
+import { Vector3, Vector4, Matrix } from "./Maths/math.vector.js";
 import { ImageProcessingConfiguration } from "./Materials/imageProcessingConfiguration.js";
 import { UniformBuffer } from "./Materials/uniformBuffer.js";
 import { PickingInfo } from "./Collisions/pickingInfo.js";
@@ -30,6 +30,9 @@ import { Logger } from "./Misc/logger.js";
 import { RegisterClass } from "./Misc/typeStore.js";
 import { FrameGraphObjectRendererTask } from "./FrameGraph/Tasks/Rendering/objectRendererTask.js";
 import { _RetryWithInterval } from "./Misc/timingTools.js";
+// Defining Temps for the file to avoid misuse of shared TmpVectors
+const TempVect1 = new Vector4();
+const TempVect2 = new Vector4();
 /**
  * Define how the scene should favor performance over ease of use
  */
@@ -366,21 +369,21 @@ export class Scene {
      * Gets the current eye position in order of forcedViewPosition, activeCamera world position, Vector3.ZeroReadOnly
      */
     get _eyePosition() {
-        return this._forcedViewPosition ?? this.activeCamera?.getWorldMatrix().getTranslationToRef(this._tempVect3) ?? Vector3.ZeroReadOnly;
+        return this._forcedViewPosition ?? this.activeCamera?.globalPosition ?? Vector3.ZeroReadOnly;
     }
     /**
      * Bind the current view position to an effect.
      * @param effect The effect to be bound
      * @param variableName name of the shader variable that will hold the eye position
      * @param isVector3 true to indicates that variableName is a Vector3 and not a Vector4
-     * @returns the computed eye position
+     * @returns the computed eye position in a temp vector, caller can copy values as needed
      */
     bindEyePosition(effect, variableName = "vEyePosition", isVector3 = false) {
         const eyePosition = this._eyePosition;
         const invertNormal = this.useRightHandedSystem === (this._mirroredCameraPosition != null);
         const offset = this.floatingOriginOffset;
-        const eyePos = this._tempVect4.set(eyePosition.x, eyePosition.y, eyePosition.z, invertNormal ? -1 : 1);
-        const offsetEyePos = eyePos.subtractFromFloatsToRef(offset.x, offset.y, offset.z, 0, TmpVectors.Vector4[1]);
+        const eyePos = TempVect1.set(eyePosition.x, eyePosition.y, eyePosition.z, invertNormal ? -1 : 1);
+        const offsetEyePos = eyePos.subtractFromFloatsToRef(offset.x, offset.y, offset.z, 0, TempVect2);
         if (effect) {
             if (isVector3) {
                 effect.setFloat3(variableName, offsetEyePos.x, offsetEyePos.y, offsetEyePos.z);
@@ -687,8 +690,6 @@ export class Scene {
          */
         this.autoClearDepthAndStencil = true;
         this._clearColor = new Color4(0.2, 0.2, 0.3, 1.0);
-        this._tempVect3 = new Vector3();
-        this._tempVect4 = new Vector4();
         /**
          * Observable triggered when the performance priority is changed
          */