@onekeyfe/hd-transport-react-native 1.2.2-alpha.104 → 1.2.2-alpha.106

package/src/index.ts

@@ -47,6 +47,7 @@ import {
   getInfosForServiceUuid,
   isSameBleUuid,
 } from './constants';
+import { isNativeBleDisconnectError, toBleDisconnectHardwareError } from './bleNativeDisconnect';
 import {
   isBleStaleBondHardwareError,
   isNativeBleStaleBondError,
@@ -76,6 +77,8 @@ const { check, ProtocolV1, parseConfigure } = transport;
 const Log = bleLogger;
 
 const transportCache: Record<string, BleTransport> = {};
+// ble-plx shares one manager across transport instances in this JS runtime.
+let bleManagerResetPromise: Promise<void> | undefined;
 const FIRMWARE_UPLOAD_WRITE_BURST_SIZE = Platform.OS === 'ios' ? 4 : 5;
 const FIRMWARE_UPLOAD_WRITE_PAUSE_MS = Platform.OS === 'ios' ? 8 : 10;
 const FIRMWARE_UPLOAD_WRITE_FLUSH_DELAY_MS = Platform.OS === 'ios' ? 24 : 30;
@@ -168,6 +171,23 @@ const isWedgedWriteError = (error: unknown): boolean =>
   (error as { errorCode?: unknown })?.errorCode === HardwareErrorCode.BleWriteCharacteristicError &&
   typeof (error as { message?: unknown })?.message === 'string' &&
   (error as { message: string }).message.startsWith(WEDGED_WRITE_MESSAGE);
+const shouldRethrowProtocolProbeError = (error: unknown): boolean => {
+  const code = (error as { errorCode?: unknown })?.errorCode;
+  // Bonding and GATT failures are not evidence of a protocol mismatch. Preserve
+  // them instead of probing another protocol on an unusable connection.
+  // Native PLX disconnects (errorCode 201 / iOS 7) must match before they are
+  // mapped: Protocol V2 writes rethrow them unchanged unless normalized first.
+  return (
+    isBleStaleBondHardwareError(error) ||
+    isNativeBleDisconnectError(error) ||
+    code === HardwareErrorCode.BleDeviceNotBonded ||
+    code === HardwareErrorCode.BleDeviceBondedCanceled ||
+    code === HardwareErrorCode.BleDeviceDisconnected ||
+    code === HardwareErrorCode.BleCharacteristicNotifyError ||
+    code === HardwareErrorCode.BleCharacteristicNotifyChangeFailure ||
+    code === HardwareErrorCode.BleWriteCharacteristicError
+  );
+};
 /** Consecutive wedged writes on one device before the BLE manager itself is recreated. */
 export const BLE_WRITE_TIMEOUT_MANAGER_RESET_THRESHOLD = 2;
 const DEVICE_SCAN_TIMEOUT_MS = 3000;
@@ -450,6 +470,10 @@ export default class ReactNativeBleTransport {
   /** Serializes transport lifecycle changes for the same physical device. */
   private lifecycleOperations: Map<string, Promise<void>> = new Map();
 
+  private stopPromise?: Promise<void>;
+
+  private scanCleanups = new Set<() => Promise<void>>();
+
   constructor(options: TransportOptions) {
     this.scanTimeout = options.scanTimeout ?? DEVICE_SCAN_TIMEOUT_MS;
   }
@@ -485,10 +509,34 @@ export default class ReactNativeBleTransport {
     // empty
   }
 
-  getPlxManager(): Promise<BlePlxManager> {
-    if (this.blePlxManager) return Promise.resolve(this.blePlxManager);
-    this.blePlxManager = new BlePlxManager();
-    return Promise.resolve(this.blePlxManager);
+  async getPlxManager(): Promise<BlePlxManager> {
+    while (bleManagerResetPromise) {
+      await this.waitForManagerReset();
+    }
+    if (this.stopped) throw ERRORS.TypedError(HardwareErrorCode.BleDeviceDisconnected);
+    if (!this.blePlxManager) this.blePlxManager = new BlePlxManager();
+    return this.blePlxManager;
+  }
+
+  private async waitForManagerReset(): Promise<void> {
+    if (!bleManagerResetPromise) return;
+    let timeout: ReturnType<typeof setTimeout> | undefined;
+    try {
+      await Promise.race([
+        bleManagerResetPromise,
+        new Promise<never>((_, reject) => {
+          timeout = setTimeout(
+            () => reject(this.createWedgedBleSetupError()),
+            BLE_CONNECT_TIMEOUT_MS
+          );
+        }),
+      ]);
+    } catch {
+      // A timeout or failed destroy is not permission to reuse the old singleton.
+      throw this.createWedgedBleSetupError();
+    } finally {
+      if (timeout) clearTimeout(timeout);
+    }
   }
 
   async resolveCharacteristics(device: Device): Promise<ResolvedBleCharacteristics> {
@@ -677,35 +725,58 @@ export default class ReactNativeBleTransport {
    * @returns
    */
   async enumerate() {
-    // eslint-disable-next-line no-async-promise-executor
-    return new Promise<IOneKeyDevice[]>(async (resolve, reject) => {
-      const deviceList: IOneKeyDevice[] = [];
-      const blePlxManager = await this.getPlxManager();
-      try {
-        await subscribeBleOn(blePlxManager);
-      } catch (error) {
-        Log?.debug('subscribeBleOn error: ', error);
-        reject(error);
-        return;
-      }
-
-      if (Platform.OS === 'android' && Platform.Version >= 31) {
-        Log?.debug('requesting permissions, please wait...');
+    const scanStartedAt = Date.now();
+    let firstDeviceMs: number | undefined;
+    const blePlxManager = await this.getPlxManager();
+    await subscribeBleOn(blePlxManager);
+    if (Platform.OS === 'android' && Platform.Version >= 31) {
+      Log?.debug('requesting permissions, please wait...');
 
-        const resultConnect = await PermissionsAndroid.requestMultiple([
-          PermissionsAndroid.PERMISSIONS.BLUETOOTH_CONNECT,
-          PermissionsAndroid.PERMISSIONS.BLUETOOTH_SCAN,
-        ]);
+      const resultConnect = await PermissionsAndroid.requestMultiple([
+        PermissionsAndroid.PERMISSIONS.BLUETOOTH_CONNECT,
+        PermissionsAndroid.PERMISSIONS.BLUETOOTH_SCAN,
+      ]);
 
-        Log?.debug('requesting permissions, result: ', resultConnect);
-        if (
-          resultConnect[PermissionsAndroid.PERMISSIONS.BLUETOOTH_CONNECT] !== 'granted' ||
-          resultConnect[PermissionsAndroid.PERMISSIONS.BLUETOOTH_SCAN] !== 'granted'
-        ) {
-          reject(ERRORS.TypedError(HardwareErrorCode.BlePermissionError));
-          return;
-        }
+      Log?.debug('requesting permissions, result: ', resultConnect);
+      if (
+        resultConnect[PermissionsAndroid.PERMISSIONS.BLUETOOTH_CONNECT] !== 'granted' ||
+        resultConnect[PermissionsAndroid.PERMISSIONS.BLUETOOTH_SCAN] !== 'granted'
+      ) {
+        throw ERRORS.TypedError(HardwareErrorCode.BlePermissionError);
       }
+    }
+
+    if (this.stopped) throw ERRORS.TypedError(HardwareErrorCode.BleDeviceDisconnected);
+    return new Promise<IOneKeyDevice[]>((resolve, reject) => {
+      const deviceList: IOneKeyDevice[] = [];
+      let finished = false;
+      let scanCleanup: Promise<void> | undefined;
+      const finishScan = (error?: unknown) => {
+        if (scanCleanup) return scanCleanup;
+        finished = true;
+        clearScanTimer();
+        scanCleanup = this.runNativeTeardown('scan', blePlxManager, async () => {
+          await blePlxManager.stopDeviceScan();
+        }).then(() => {
+          this.scanCleanups.delete(cancelScan);
+          if (error) reject(error);
+          else resolve(deviceList);
+        });
+        return scanCleanup;
+      };
+      const cancelScan = () =>
+        finishScan(ERRORS.TypedError(HardwareErrorCode.BleDeviceDisconnected));
+      this.scanCleanups.add(cancelScan);
+
+      const clearScanTimer = timer.timeout(() => {
+        Log?.debug('[ReactNativeBleTransport] scan completed', {
+          elapsedMs: Date.now() - scanStartedAt,
+          firstDeviceMs,
+          deviceCount: deviceList.length,
+          scanWindowMs: this.scanTimeout,
+        });
+        finishScan();
+      }, this.scanTimeout);
 
       blePlxManager.startDeviceScan(
         getBluetoothServiceUuids(),
@@ -721,18 +792,17 @@ export default class ReactNativeBleTransport {
                 error.errorCode
               )
             ) {
-              reject(ERRORS.TypedError(HardwareErrorCode.BlePermissionError));
+              finishScan(ERRORS.TypedError(HardwareErrorCode.BlePermissionError));
             } else if (error.errorCode === BleErrorCode.BluetoothUnauthorized) {
-              reject(ERRORS.TypedError(HardwareErrorCode.BleLocationError));
+              finishScan(ERRORS.TypedError(HardwareErrorCode.BleLocationError));
             } else if (error.errorCode === BleErrorCode.LocationServicesDisabled) {
-              reject(ERRORS.TypedError(HardwareErrorCode.BleLocationServicesDisabled));
+              finishScan(ERRORS.TypedError(HardwareErrorCode.BleLocationServicesDisabled));
             } else if (error.errorCode === BleErrorCode.ScanStartFailed) {
               // Android Bluetooth will report an error when the search frequency is too fast,
               // then nothing is processed and an empty array of devices is returned.
               // Then the next search will be back to normal
-              timer.timeout(() => {}, this.scanTimeout);
             } else {
-              reject(ERRORS.TypedError(HardwareErrorCode.BleScanError, error.reason ?? ''));
+              finishScan(ERRORS.TypedError(HardwareErrorCode.BleScanError, error.reason ?? ''));
             }
             return;
           }
@@ -764,6 +834,7 @@ export default class ReactNativeBleTransport {
         }
       );
 
+      if (finished) return;
       getConnectedDeviceIds(Platform.OS === 'ios' ? getBluetoothServiceUuids() : []).then(
         devices => {
           for (const device of devices) {
@@ -783,11 +854,13 @@ export default class ReactNativeBleTransport {
               addDevice(device as unknown as Device);
             }
           }
-        }
+        },
+        error => Log?.debug('search connected peripheral failed:', error)
       );
 
       const addDevice = (device: Device) => {
-        if (deviceList.every(d => d.id !== device.id)) {
+        if (!finished && deviceList.every(d => d.id !== device.id)) {
+          firstDeviceMs ??= Date.now() - scanStartedAt;
           const displayName = getDeviceDisplayName(device) ?? 'Unknown BLE Device';
 
           deviceList.push({
@@ -802,11 +875,6 @@ export default class ReactNativeBleTransport {
           });
         }
       };
-
-      timer.timeout(() => {
-        blePlxManager.stopDeviceScan();
-        resolve(deviceList);
-      }, this.scanTimeout);
     });
   }
 
@@ -894,6 +962,7 @@ export default class ReactNativeBleTransport {
   }
 
   private async acquireUnlocked(input: FirmwareInstallBleAcquireInput) {
+    if (this.stopped) throw ERRORS.TypedError(HardwareErrorCode.BleDeviceDisconnected);
     const { uuid, forceCleanRunPromise, expectedProtocol, skipProtocolProbe } = input;
     const shouldMapProtocolV2StaleBond = expectedProtocol
       ? expectedProtocol === 'V2'
@@ -1170,7 +1239,7 @@ export default class ReactNativeBleTransport {
       this.attachDisconnectSubscription(currentTransport, currentTransport.device, uuid);
       return { uuid, protocolType };
     } catch (error) {
-      if (isBleStaleBondHardwareError(error)) {
+      if (isBleStaleBondHardwareError(error) || shouldRethrowProtocolProbeError(error)) {
         await this.disconnectUnlocked(uuid);
       } else {
         await this.releaseUnlocked(uuid, true);
@@ -1703,7 +1772,34 @@ export default class ReactNativeBleTransport {
   }
 
   stop() {
+    if (this.stopPromise) return this.stopPromise;
     this.stopped = true;
+    const deviceIds = new Set([
+      ...this.monitorTokens.keys(),
+      ...this.sessionProtocols.keys(),
+      ...this.lifecycleOperations.keys(),
+      ...(this.runPromiseDeviceId ? [this.runPromiseDeviceId] : []),
+    ]);
+    const scans = Array.from(this.scanCleanups, cleanup => cleanup());
+    this.androidPriorityResetTimers.forEach(timeout => clearTimeout(timeout));
+    this.androidPriorityResetTimers.clear();
+    this.androidHighPriorityDevices.clear();
+    const error = ERRORS.TypedError(HardwareErrorCode.BleDeviceDisconnected);
+    this.runPromise?.reject(error);
+    this.runPromise = null;
+    this.runPromiseDeviceId = null;
+    deviceIds.forEach(uuid => this.rejectProtocolV2Frames(uuid, error));
+    // Release only this transport's endpoints; other connectors may share ble-plx.
+    this.stopPromise = Promise.all([
+      ...scans,
+      ...Array.from(deviceIds, uuid => this.disconnect(uuid)),
+    ]).then(async () => {
+      await this.protocolV2Links.invalidateAllLinks('React Native BLE transport stopped');
+      await this.waitForManagerReset();
+      this.blePlxManager = undefined;
+      this.emitter = undefined;
+    });
+    return this.stopPromise;
   }
 
   async disconnect(session: string) {
@@ -1855,17 +1951,26 @@ export default class ReactNativeBleTransport {
     }
   }
 
-  cancel() {
+  async cancel() {
     Log?.debug('transport-react-native transport cancel');
-    if (this.runPromise) {
-      // this.runPromise.reject(new Error('Transport_CallCanceled'));
+    const pending = this.runPromise;
+    const deviceId = this.runPromiseDeviceId;
+    if (pending) {
+      pending.reject(ERRORS.TypedError(HardwareErrorCode.CallQueueActionCancelled));
+      if (this.runPromise === pending) {
+        this.runPromise = null;
+        this.runPromiseDeviceId = null;
+      }
+      // A V1 read cannot be safely reused after abandoning its response.
+      // Drain native teardown before DeviceCommands releases the operation.
+      if (deviceId) await this.disconnect(deviceId);
     }
-    this.runPromise = null;
-    this.runPromiseDeviceId = null;
   }
 
   /** Run a native connect under the JS backstop budget. */
   private async connectWithTimeout<T>(uuid: string, connect: () => Promise<T>): Promise<T> {
+    const startedAt = Date.now();
+    let succeeded = false;
     let timer: ReturnType<typeof setTimeout> | undefined;
     let timedOut = false;
     const pending = connect();
@@ -1887,6 +1992,7 @@ export default class ReactNativeBleTransport {
           }, BLE_CONNECT_TIMEOUT_MS);
         }),
       ]);
+      succeeded = true;
       return result;
     } catch (error) {
       if (timedOut || isNativeOperationTimeoutError(error)) {
@@ -1901,6 +2007,12 @@ export default class ReactNativeBleTransport {
       throw error;
     } finally {
       if (timer) clearTimeout(timer);
+      Log?.debug('[ReactNativeBleTransport] connect completed', {
+        connectIdSuffix: uuid.slice(-8),
+        elapsedMs: Date.now() - startedAt,
+        succeeded,
+        backstopExpired: timedOut,
+      });
     }
   }
 
@@ -1909,6 +2021,8 @@ export default class ReactNativeBleTransport {
     uuid: string,
     device: Device
   ): Promise<ResolvedBleCharacteristics> {
+    const startedAt = Date.now();
+    let succeeded = false;
     let timer: ReturnType<typeof setTimeout> | undefined;
     let timedOut = false;
     const pending = this.resolveCharacteristics(device);
@@ -1929,6 +2043,7 @@ export default class ReactNativeBleTransport {
         }),
       ]);
       this.connectionSetupTimeoutCounts.delete(uuid);
+      succeeded = true;
       return result;
     } catch (error) {
       if (timedOut || isNativeOperationTimeoutError(error)) {
@@ -1943,6 +2058,12 @@ export default class ReactNativeBleTransport {
       throw error;
     } finally {
       if (timer) clearTimeout(timer);
+      Log?.debug('[ReactNativeBleTransport] GATT setup completed', {
+        connectIdSuffix: uuid.slice(-8),
+        elapsedMs: Date.now() - startedAt,
+        succeeded,
+        backstopExpired: timedOut,
+      });
     }
   }
 
@@ -2086,6 +2207,7 @@ export default class ReactNativeBleTransport {
   }
 
   private resetPlxManager() {
+    if (bleManagerResetPromise) return;
     const manager = this.blePlxManager;
     this.blePlxManager = undefined;
     const reason = 'React Native BLE manager reset';
@@ -2132,11 +2254,21 @@ export default class ReactNativeBleTransport {
     this.connectionSetupTimeoutCounts.clear();
     this.monitorTokens.clear();
     this.protocolV2Assemblers.clear();
+    let reset: Promise<void>;
     try {
-      manager?.destroy();
+      reset = Promise.resolve(manager?.destroy());
     } catch (error) {
-      Log?.debug('[ReactNativeBleTransport] BLE manager destroy failed (ignored):', error);
+      reset = Promise.reject(error);
     }
+    bleManagerResetPromise = reset;
+    reset.then(
+      () => {
+        if (bleManagerResetPromise === reset) bleManagerResetPromise = undefined;
+      },
+      error => {
+        Log?.error('[ReactNativeBleTransport] BLE manager destroy failed:', error);
+      }
+    );
   }
 
   private createProtocolMismatchError(expected: ProtocolType) {
@@ -2339,9 +2471,7 @@ export default class ReactNativeBleTransport {
     } catch (error) {
       this.clearProbeProtocol(uuid, 'V1');
       Log?.debug('[ReactNativeBleTransport] Protocol V1 GetFeatures probe failed:', error);
-      // A wedged write already dropped the link, so probing another protocol on it
-      // would only fail against a torn-down transport: surface the real cause.
-      if (isWedgedWriteError(error)) {
+      if (shouldRethrowProtocolProbeError(error)) {
         throw error;
       }
       return false;
@@ -2366,7 +2496,7 @@ export default class ReactNativeBleTransport {
         this.protocolV2Assemblers.get(uuid)?.reset();
         this.resetProtocolV2Frames(uuid);
       },
-      shouldRethrow: isBleStaleBondHardwareError,
+      shouldRethrow: shouldRethrowProtocolProbeError,
     });
     if (!detected) {
       this.clearProbeProtocol(uuid, 'V2');
@@ -2513,6 +2643,9 @@ export default class ReactNativeBleTransport {
           this.rememberStaleBondError(uuid, bondError);
           throw bondError;
         }
+        if (isNativeBleDisconnectError(error)) {
+          throw toBleDisconnectHardwareError(error);
+        }
         if (
           getFirmwareUploadWriteRetryType(error) !== 'congested' ||
           attempt >= FIRMWARE_UPLOAD_WRITE_MAX_RETRIES