@onekeyfe/hd-transport-react-native 1.2.2-alpha.104 → 1.2.2-alpha.106

package/src/__tests__/connectTimeout.test.ts

@@ -1,6 +1,6 @@
 import { EventEmitter } from 'events';
-import { BleErrorCode } from 'react-native-ble-plx';
-import { HardwareErrorCode } from '@onekeyfe/hd-shared';
+import { BleErrorCode, BleManager } from 'react-native-ble-plx';
+import { HardwareErrorCode, createDeferred } from '@onekeyfe/hd-shared';
 
 import ReactNativeBleTransport, {
   BLE_CONNECT_TIMEOUT_MANAGER_RESET_THRESHOLD,
@@ -131,6 +131,59 @@ describe('BLE connect timeout', () => {
     jest.restoreAllMocks();
   });
 
+  test('waits for singleton destruction before creating the next manager', async () => {
+    const { transport, bleManager } = createHarness(() => Promise.resolve());
+    const destruction = createDeferred<void>();
+    Object.assign(bleManager, { destroy: jest.fn(() => destruction.promise) });
+    const createManager = jest.mocked(BleManager);
+    createManager.mockClear();
+    (transport as unknown as { resetPlxManager(): void }).resetPlxManager();
+    const first = transport.getPlxManager();
+    const second = transport.getPlxManager();
+    await flush();
+    expect(createManager).not.toHaveBeenCalled();
+    destruction.resolve();
+    expect(await first).toBe(await second);
+    expect(createManager).toHaveBeenCalledTimes(1);
+  });
+
+  test('does not reuse a manager after asynchronous destruction fails', async () => {
+    const { bleManager } = createHarness(() => Promise.resolve());
+    let transport!: ReactNativeBleTransport;
+    jest.isolateModules(() => {
+      const { default: Transport } = jest.requireActual<typeof import('../index')>('../index');
+      transport = new Transport({});
+    });
+    transport.blePlxManager = bleManager as never;
+    const destruction = createDeferred<void>();
+    Object.assign(bleManager, { destroy: jest.fn(() => destruction.promise) });
+    (transport as unknown as { resetPlxManager(): void }).resetPlxManager();
+    const result = transport.getPlxManager();
+    const failure = expect(result).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.PollingTimeout,
+    });
+    destruction.reject(new Error('Native destruction failed'));
+    await failure;
+  });
+
+  test('bounds reset waiting without letting a new transport bypass unfinished destruction', async () => {
+    const { transport, bleManager } = createHarness(() => Promise.resolve());
+    const destruction = createDeferred<void>();
+    Object.assign(bleManager, { destroy: jest.fn(() => destruction.promise) });
+    const createManager = jest.mocked(BleManager);
+    createManager.mockClear();
+    (transport as unknown as { resetPlxManager(): void }).resetPlxManager();
+    const nextTransport = new ReactNativeBleTransport({});
+    const result = nextTransport.getPlxManager().catch(error => error);
+    await flush();
+    jest.advanceTimersByTime(BLE_CONNECT_TIMEOUT_MS);
+    await expect(result).resolves.toMatchObject({ errorCode: HardwareErrorCode.PollingTimeout });
+    expect(createManager).not.toHaveBeenCalled();
+    destruction.resolve();
+    await nextTransport.getPlxManager();
+    expect(createManager).toHaveBeenCalledTimes(1);
+  });
+
   test('a native connect that never settles is bounded instead of blocking forever', async () => {
     // iOS applies its own connect timeout on a serial queue; when that queue is busy
     // the timeout never fires and acquire() blocks until the app-level 60s timeout.
@@ -155,6 +208,61 @@ describe('BLE connect timeout', () => {
     expect(errors[0]?.errorCode).toBe(HardwareErrorCode.BleConnectedError);
   });
 
+  test('stop drains its scan and removes the timer before another transport scans', async () => {
+    const { transport, bleManager } = createHarness(() => Promise.resolve());
+    const nativeStop = createDeferred<void>();
+    bleManager.stopDeviceScan.mockImplementation(() => nativeStop.promise);
+    const scanned = transport.enumerate().catch(error => error);
+    await flush();
+    await flush();
+    expect(bleManager.startDeviceScan).toHaveBeenCalledTimes(1);
+    const stopping = transport.stop();
+    expect(transport.stop()).toBe(stopping);
+    let stopped = false;
+    stopping.then(() => {
+      stopped = true;
+    });
+    await flush();
+    expect(stopped).toBe(false);
+    nativeStop.resolve();
+    await stopping;
+    await expect(scanned).resolves.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceDisconnected,
+    });
+    jest.advanceTimersByTime(transport.scanTimeout);
+    await flush();
+    expect(bleManager.stopDeviceScan).toHaveBeenCalledTimes(1);
+    await expect(transport.getPlxManager()).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceDisconnected,
+    });
+  });
+
+  test('stop rejects a pending read and waits for native disconnection without destroying the shared manager', async () => {
+    const { transport, bleManager } = createHarness(() => Promise.resolve());
+    const nativeDisconnect = createDeferred<void>();
+    bleManager.cancelDeviceConnection.mockImplementation(() => nativeDisconnect.promise);
+    const destroy = jest.fn();
+    Object.assign(bleManager, { destroy });
+    const read = createDeferred<void>();
+    transport.runPromise = read;
+    Object.assign(transport, { runPromiseDeviceId: UUID });
+    const readResult = read.promise.catch(error => error);
+    let stopped = false;
+    const stopping = transport.stop().then(() => {
+      stopped = true;
+    });
+    await flush();
+    await expect(readResult).resolves.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceDisconnected,
+    });
+    expect(stopped).toBe(false);
+    nativeDisconnect.resolve();
+    await advanceUntil(() => stopped, 1000);
+    await stopping;
+    expect(bleManager.cancelDeviceConnection).toHaveBeenCalledWith(UUID);
+    expect(destroy).not.toHaveBeenCalled();
+  });
+
   test('the connect budget leaves generous headroom over a healthy connect', () => {
     // Healthy connects finish in ~2-3s (the native budget is 3s); this backstop only
     // fires when the native timeout itself fails to.

package/src/__tests__/protocolV2Link.test.ts

@@ -4,7 +4,7 @@ import transportPackage, {
   ProtocolV2,
   TRANSPORT_EVENT,
 } from '@onekeyfe/hd-transport';
-import { HardwareErrorCode, createDeferred } from '@onekeyfe/hd-shared';
+import { ERRORS, HardwareErrorCode, createDeferred } from '@onekeyfe/hd-shared';
 
 import ReactNativeBleTransport, {
   BLE_NATIVE_TEARDOWN_TIMEOUT_MS,
@@ -28,7 +28,7 @@ jest.mock('react-native-ble-plx', () => ({
   BleError: class BleError extends Error {},
   BleErrorCode: {
     DeviceAlreadyConnected: 203,
-    DeviceDisconnected: 205,
+    DeviceDisconnected: 201,
     DeviceMTUChangeFailed: 206,
     OperationCancelled: 2,
     CharacteristicNotFound: 404,
@@ -830,6 +830,116 @@ describe('ReactNativeBleTransport Protocol V2 link lifecycle', () => {
     BLE_NATIVE_TEARDOWN_TIMEOUT_MS + 5_000
   );
 
+  test('preserves the unpaired error when iOS disconnects during the first V1 probe', async () => {
+    const { transport, uuid, writeCharacteristic } = createHarness({ deviceName: 'Neo Test' });
+    writeCharacteristic.writeWithResponse.mockRejectedValueOnce({
+      errorCode: 201,
+      iosErrorCode: 7,
+      reason: 'The specified device has disconnected from us.',
+    });
+    const probeProtocolV2 = jest.spyOn(transport as any, 'probeProtocolV2');
+
+    await expect(transport.acquire({ uuid })).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceNotBonded,
+    });
+
+    expect(probeProtocolV2).not.toHaveBeenCalled();
+    expect(writeCharacteristic.writeWithResponse).toHaveBeenCalledTimes(1);
+    expect(transport.getProtocolType(uuid)).toBeUndefined();
+  });
+
+  test('preserves a native iOS disconnect during an expected Protocol V2 probe', async () => {
+    const { transport, uuid, writeCharacteristic, bleManager } = createHarness({
+      deviceName: 'Neo Test',
+    });
+    const nativeDisconnect = {
+      errorCode: 201,
+      iosErrorCode: 7,
+      reason: 'The specified device has disconnected from us.',
+    };
+    writeCharacteristic.writeWithoutResponse.mockRejectedValueOnce(nativeDisconnect);
+    const probeProtocolV1 = jest.spyOn(transport as any, 'probeProtocolV1');
+
+    await expect(transport.acquire({ uuid, expectedProtocol: 'V2' })).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceDisconnected,
+    });
+
+    expect(probeProtocolV1).not.toHaveBeenCalled();
+    expect(writeCharacteristic.writeWithoutResponse).toHaveBeenCalledTimes(1);
+    expect(bleManager.cancelDeviceConnection).toHaveBeenCalledWith(uuid);
+    expect(transport.getProtocolType(uuid)).toBeUndefined();
+  });
+
+  test('preserves a native iOS disconnect during a V2-first probe without falling back to V1', async () => {
+    const { transport, uuid, writeCharacteristic } = createHarness({ deviceName: 'Neo Test' });
+    writeCharacteristic.writeWithoutResponse.mockRejectedValueOnce({
+      errorCode: 201,
+      iosErrorCode: 7,
+      reason: 'The specified device has disconnected from us.',
+    });
+    const probeProtocolV1 = jest.spyOn(transport as any, 'probeProtocolV1');
+
+    await expect(transport.acquire({ uuid, protocolHint: 'V2' })).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.BleDeviceDisconnected,
+    });
+
+    expect(probeProtocolV1).not.toHaveBeenCalled();
+    expect(writeCharacteristic.writeWithoutResponse).toHaveBeenCalledTimes(1);
+    expect(transport.getProtocolType(uuid)).toBeUndefined();
+  });
+
+  test.each(['V1', 'V2'] as const)(
+    'preserves terminal BLE failures from the %s probe without trying another protocol',
+    async protocol => {
+      for (const errorCode of [
+        HardwareErrorCode.BleDeviceNotBonded,
+        HardwareErrorCode.BleDeviceBondedCanceled,
+        HardwareErrorCode.BlePeerRemovedPairingInformation,
+        HardwareErrorCode.BleDeviceDisconnected,
+        HardwareErrorCode.BleCharacteristicNotifyError,
+        HardwareErrorCode.BleCharacteristicNotifyChangeFailure,
+        HardwareErrorCode.BleWriteCharacteristicError,
+      ]) {
+        const { transport, uuid } = createHarness();
+        const error = ERRORS.TypedError(errorCode);
+        const call = jest
+          .spyOn(transport as any, protocol === 'V1' ? 'callProtocolV1' : 'callProtocolV2')
+          .mockRejectedValue(error);
+        const otherProbe = jest.spyOn(
+          transport as any,
+          protocol === 'V1' ? 'probeProtocolV2' : 'probeProtocolV1'
+        );
+
+        await expect(transport.acquire({ uuid, protocolHint: protocol })).rejects.toBe(error);
+
+        expect(call).toHaveBeenCalledTimes(1);
+        expect(otherProbe).not.toHaveBeenCalled();
+        expect(transport.getProtocolType(uuid)).toBeUndefined();
+      }
+    }
+  );
+
+  test.each(['V1', 'V2'] as const)(
+    'still falls back after a silent %s probe timeout',
+    async protocol => {
+      const { transport, uuid } = createHarness();
+      jest
+        .spyOn(transport as any, protocol === 'V1' ? 'callProtocolV1' : 'callProtocolV2')
+        .mockRejectedValue(ERRORS.TypedError(HardwareErrorCode.BleTimeoutError));
+      const otherProbe = jest
+        .spyOn(transport as any, protocol === 'V1' ? 'probeProtocolV2' : 'probeProtocolV1')
+        .mockResolvedValue(true);
+
+      await expect(transport.acquire({ uuid, protocolHint: protocol })).resolves.toEqual({
+        uuid,
+        protocolType: protocol === 'V1' ? 'V2' : 'V1',
+      });
+
+      expect(otherProbe).toHaveBeenCalledTimes(1);
+      await transport.release(uuid, true);
+    }
+  );
+
   test('falls back to the other active probe on iOS when protocol metadata is absent', async () => {
     const { transport, uuid } = createHarness({ deviceName: 'OneKey' });
     const probeProtocolV1 = jest

package/src/__tests__/staleCallTimeout.test.ts

@@ -56,6 +56,34 @@ function createHarness() {
 }
 
 describe('Protocol V1 stale call timeout', () => {
+  test('settles a cancelled read and waits for native teardown before completing cancel', async () => {
+    const { t, disconnectSpy } = createHarness();
+    let finishDisconnect!: () => void;
+    disconnectSpy.mockImplementationOnce(
+      () =>
+        new Promise<void>(resolve => {
+          finishDisconnect = resolve;
+        })
+    );
+    const call = t.call(UUID, 'Initialize', {}, { timeoutMs: 25000 });
+    const result = call.catch(error => error);
+    await flush();
+    let cancelled = false;
+    const cleanup = t.cancel().then(() => {
+      cancelled = true;
+    });
+    await flush();
+    expect(await result).toMatchObject({ errorCode: HardwareErrorCode.CallQueueActionCancelled });
+    expect(t.runPromise).toBeNull();
+    expect(disconnectSpy).toHaveBeenCalledWith(UUID);
+    expect(cancelled).toBe(false);
+    finishDisconnect();
+    await cleanup;
+    jest.advanceTimersByTime(25000);
+    await flush();
+    expect(disconnectSpy).toHaveBeenCalledTimes(1);
+  });
+
   beforeAll(() => {
     jest.useFakeTimers({ doNotFake: ['setImmediate', 'performance'] });
   });
@@ -172,24 +200,25 @@ describe('Protocol V1 stale call timeout', () => {
     expect(secondErrors).toHaveLength(1);
   });
 
-  test('orphan timer left behind by cancel() must not disconnect the transport', async () => {
+  test('a cancelled read cannot disconnect a later transport when its old deadline passes', async () => {
     const { t, disconnectSpy } = createHarness();
 
-    // cancel() nulls the ownership slot without settling the deferred, so the
-    // call's response timer stays armed (reachable via DeviceCommands.dispose).
     const errors: Array<{ errorCode?: unknown }> = [];
     const p = t.call(UUID, 'GetFeatures', {}, { timeoutMs: 5000 });
     p.catch(e => errors.push(e));
     await flush();
 
-    t.cancel();
+    await t.cancel();
+    await flush();
+    expect(disconnectSpy).toHaveBeenCalledTimes(1);
+    disconnectSpy.mockClear();
 
     jest.advanceTimersByTime(5000);
     await flush();
 
     expect(disconnectSpy).not.toHaveBeenCalled();
     expect(errors).toHaveLength(1);
-    expect(errors[0]?.errorCode).toBe(HardwareErrorCode.BleTimeoutError);
+    expect(errors[0]?.errorCode).toBe(HardwareErrorCode.CallQueueActionCancelled);
   });
 
   test('timeout on the active call still disconnects the transport', async () => {

package/src/bleNativeDisconnect.ts

@@ -0,0 +1,40 @@
+import { ERRORS, HardwareErrorCode } from '@onekeyfe/hd-shared';
+
+const BLE_PLX_DEVICE_DISCONNECTED = 201;
+const IOS_PERIPHERAL_DISCONNECTED = 7;
+
+type NativeBleErrorFields = {
+  errorCode?: unknown;
+  iosErrorCode?: unknown;
+  reason?: unknown;
+  message?: unknown;
+};
+
+const nativeErrorText = (error: NativeBleErrorFields) =>
+  [error.reason, error.message]
+    .filter((value): value is string => typeof value === 'string')
+    .join(' ');
+
+export const isNativeBleDisconnectError = (error: unknown): boolean => {
+  if (!error || typeof error !== 'object') {
+    return false;
+  }
+
+  const nativeError = error as NativeBleErrorFields;
+  return (
+    nativeError.errorCode === BLE_PLX_DEVICE_DISCONNECTED ||
+    nativeError.iosErrorCode === IOS_PERIPHERAL_DISCONNECTED
+  );
+};
+
+export const toBleDisconnectHardwareError = (error: unknown) => {
+  if ((error as { errorCode?: unknown })?.errorCode === HardwareErrorCode.BleDeviceDisconnected) {
+    return error as Error;
+  }
+
+  const nativeError = (error ?? {}) as NativeBleErrorFields;
+  return ERRORS.TypedError(
+    HardwareErrorCode.BleDeviceDisconnected,
+    nativeErrorText(nativeError) || undefined
+  );
+};