@oh-my-pi/pi-coding-agent 4.2.3 → 4.3.1

package/src/discovery/codex.ts

@@ -29,6 +29,7 @@ import { slashCommandCapability } from "../capability/slash-command";
 import type { CustomTool } from "../capability/tool";
 import { toolCapability } from "../capability/tool";
 import type { LoadContext, LoadResult } from "../capability/types";
+import { logger } from "../core/logger";
 import {
 	createSourceMeta,
 	discoverExtensionModulePaths,
@@ -117,7 +118,8 @@ async function loadTomlConfig(_ctx: LoadContext, path: string): Promise<Record<s
 
 	try {
 		return parseToml(content) as Record<string, unknown>;
-	} catch (_err) {
+	} catch (error) {
+		logger.warn("Failed to parse TOML config", { path, error: String(error) });
 		return null;
 	}
 }

package/src/discovery/helpers.ts

@@ -2,11 +2,38 @@
  * Shared helpers for discovery providers.
  */
 
+import { homedir } from "node:os";
 import { join, resolve } from "node:path";
+import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import { parse as parseYAML } from "yaml";
 import { readDirEntries, readFile } from "../capability/fs";
 import type { Skill, SkillFrontmatter } from "../capability/skill";
 import type { LoadContext, LoadResult, SourceMeta } from "../capability/types";
+import { logger } from "../core/logger";
+
+const VALID_THINKING_LEVELS: readonly string[] = ["off", "minimal", "low", "medium", "high", "xhigh"];
+const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
+
+/**
+ * Normalize unicode spaces to regular spaces.
+ */
+export function normalizeUnicodeSpaces(str: string): string {
+	return str.replace(UNICODE_SPACES, " ");
+}
+
+/**
+ * Expand ~ to home directory and normalize unicode spaces.
+ */
+export function expandPath(p: string): string {
+	const normalized = normalizeUnicodeSpaces(p);
+	if (normalized.startsWith("~/")) {
+		return join(homedir(), normalized.slice(2));
+	}
+	if (normalized.startsWith("~")) {
+		return join(homedir(), normalized.slice(1));
+	}
+	return normalized;
+}
 
 /**
  * Standard paths for each config source.
@@ -117,14 +144,108 @@ export function parseFrontmatter(content: string): {
 	const body = normalized.slice(endIndex + 4).trim();
 
 	try {
-		const frontmatter = parseYAML(raw) as Record<string, unknown> | null;
+		// Replace tabs with spaces for YAML compatibility, use failsafe mode for robustness
+		const frontmatter = parseYAML(raw.replaceAll("\t", "  "), { compat: "failsafe" }) as Record<
+			string,
+			unknown
+		> | null;
 		return { frontmatter: frontmatter ?? {}, body, raw };
-	} catch {
-		// Fallback to empty frontmatter on parse error
+	} catch (error) {
+		logger.warn("Failed to parse YAML frontmatter", { error: String(error) });
 		return { frontmatter: {}, body, raw };
 	}
 }
 
+/**
+ * Parse thinking level from frontmatter.
+ * Supports keys: thinkingLevel, thinking-level, thinking
+ */
+export function parseThinkingLevel(frontmatter: Record<string, unknown>): ThinkingLevel | undefined {
+	const raw = frontmatter.thinkingLevel ?? frontmatter["thinking-level"] ?? frontmatter.thinking;
+	if (typeof raw === "string" && VALID_THINKING_LEVELS.includes(raw)) {
+		return raw as ThinkingLevel;
+	}
+	return undefined;
+}
+
+/**
+ * Parse a comma-separated string into an array of trimmed, non-empty strings.
+ */
+export function parseCSV(value: string): string[] {
+	return value
+		.split(",")
+		.map((s) => s.trim())
+		.filter(Boolean);
+}
+
+/**
+ * Parse a value that may be an array of strings or a comma-separated string.
+ * Returns undefined if the result would be empty.
+ */
+export function parseArrayOrCSV(value: unknown): string[] | undefined {
+	if (Array.isArray(value)) {
+		const filtered = value.filter((item): item is string => typeof item === "string");
+		return filtered.length > 0 ? filtered : undefined;
+	}
+	if (typeof value === "string") {
+		const parsed = parseCSV(value);
+		return parsed.length > 0 ? parsed : undefined;
+	}
+	return undefined;
+}
+
+/** Parsed agent fields from frontmatter (excludes source/filePath/systemPrompt) */
+export interface ParsedAgentFields {
+	name: string;
+	description: string;
+	tools?: string[];
+	spawns?: string[] | "*";
+	model?: string;
+	output?: unknown;
+	thinkingLevel?: ThinkingLevel;
+}
+
+/**
+ * Parse agent fields from frontmatter.
+ * Returns null if required fields (name, description) are missing.
+ */
+export function parseAgentFields(frontmatter: Record<string, unknown>): ParsedAgentFields | null {
+	const name = typeof frontmatter.name === "string" ? frontmatter.name : undefined;
+	const description = typeof frontmatter.description === "string" ? frontmatter.description : undefined;
+
+	if (!name || !description) {
+		return null;
+	}
+
+	const tools = parseArrayOrCSV(frontmatter.tools);
+
+	// Parse spawns field (array, "*", or CSV)
+	let spawns: string[] | "*" | undefined;
+	if (frontmatter.spawns === "*") {
+		spawns = "*";
+	} else if (typeof frontmatter.spawns === "string") {
+		const trimmed = frontmatter.spawns.trim();
+		if (trimmed === "*") {
+			spawns = "*";
+		} else {
+			spawns = parseArrayOrCSV(trimmed);
+		}
+	} else {
+		spawns = parseArrayOrCSV(frontmatter.spawns);
+	}
+
+	// Backward compat: infer spawns: "*" when tools includes "task"
+	if (spawns === undefined && tools?.includes("task")) {
+		spawns = "*";
+	}
+
+	const output = frontmatter.output !== undefined ? frontmatter.output : undefined;
+	const model = typeof frontmatter.model === "string" ? frontmatter.model : undefined;
+	const thinkingLevel = parseThinkingLevel(frontmatter);
+
+	return { name, description, tools, spawns, model, output, thinkingLevel };
+}
+
 export async function loadSkillsFromDir(
 	_ctx: LoadContext,
 	options: {

package/src/migrations.ts

@@ -8,6 +8,7 @@ import chalk from "chalk";
 import { getAgentDbPath, getAgentDir, getBinDir } from "./config";
 import { AgentStorage } from "./core/agent-storage";
 import type { AuthCredential } from "./core/auth-storage";
+import { logger } from "./core/logger";
 
 /**
  * Migrate PI_* environment variables to OMP_* equivalents.
@@ -55,8 +56,8 @@ export function migrateAuthToAgentDb(): string[] {
 				providers.push(provider);
 			}
 			renameSync(oauthPath, `${oauthPath}.migrated`);
-		} catch {
-			// Skip on error
+		} catch (error) {
+			logger.warn("Failed to migrate oauth.json", { path: oauthPath, error: String(error) });
 		}
 	}
 
@@ -75,8 +76,8 @@ export function migrateAuthToAgentDb(): string[] {
 				delete settings.apiKeys;
 				writeFileSync(settingsPath, JSON.stringify(settings, null, 2));
 			}
-		} catch {
-			// Skip on error
+		} catch (error) {
+			logger.warn("Failed to migrate settings.json apiKeys", { path: settingsPath, error: String(error) });
 		}
 	}
 
@@ -105,7 +106,8 @@ export function migrateSessionsFromAgentRoot(): void {
 		files = readdirSync(agentDir)
 			.filter((f) => f.endsWith(".jsonl"))
 			.map((f) => join(agentDir, f));
-	} catch {
+	} catch (error) {
+		logger.warn("Failed to read agent directory for session migration", { path: agentDir, error: String(error) });
 		return;
 	}
 
@@ -137,8 +139,8 @@ export function migrateSessionsFromAgentRoot(): void {
 			if (existsSync(newPath)) continue; // Skip if target exists
 
 			renameSync(file, newPath);
-		} catch {
-			// Skip files that can't be migrated
+		} catch (error) {
+			logger.warn("Failed to migrate session file", { path: file, error: String(error) });
 		}
 	}
 }
@@ -168,8 +170,8 @@ function migrateToolsToBin(): void {
 				try {
 					renameSync(oldPath, newPath);
 					movedAny = true;
-				} catch {
-					// Ignore errors
+				} catch (error) {
+					logger.warn("Failed to migrate binary", { from: oldPath, to: newPath, error: String(error) });
 				}
 			} else {
 				// Target exists, just delete the old one

package/src/modes/interactive/components/extensions/state-manager.ts

@@ -13,6 +13,7 @@ import type { Skill } from "../../../../capability/skill";
 import type { SlashCommand } from "../../../../capability/slash-command";
 import type { CustomTool } from "../../../../capability/tool";
 import type { SourceMeta } from "../../../../capability/types";
+import { logger } from "../../../../core/logger";
 import {
 	disableProvider,
 	enableProvider,
@@ -105,8 +106,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: (s) => s.frontmatter?.description,
 			getTrigger: (s) => s.frontmatter?.globs?.join(", "),
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load skills capability", { error: String(error) });
 	}
 
 	// Load rules
@@ -116,8 +117,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: (r) => r.description,
 			getTrigger: (r) => r.globs?.join(", ") || (r.alwaysApply ? "always" : undefined),
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load rules capability", { error: String(error) });
 	}
 
 	// Load custom tools
@@ -126,8 +127,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 		addItems(tools.all, "tool", {
 			getDescription: (t) => t.description,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load tools capability", { error: String(error) });
 	}
 
 	// Load extension modules
@@ -135,8 +136,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 		const modules = await loadCapability<ExtensionModule>("extension-modules", loadOpts);
 		const nativeModules = modules.all.filter((module) => module._source.provider === "native");
 		addItems(nativeModules, "extension-module");
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load extension-modules capability", { error: String(error) });
 	}
 
 	// Load MCP servers
@@ -178,8 +179,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: server,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load mcps capability", { error: String(error) });
 	}
 
 	// Load prompts
@@ -189,8 +190,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: () => undefined,
 			getTrigger: (p) => `/prompts:${p.name}`,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load prompts capability", { error: String(error) });
 	}
 
 	// Load slash commands
@@ -200,8 +201,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: () => undefined,
 			getTrigger: (c) => `/${c.name}`,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load slash-commands capability", { error: String(error) });
 	}
 
 	// Load hooks
@@ -243,8 +244,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: hook,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load hooks capability", { error: String(error) });
 	}
 
 	// Load context files
@@ -288,8 +289,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: file,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load context-files capability", { error: String(error) });
 	}
 
 	return extensions;

package/src/prompts/agents/frontmatter.md

@@ -3,5 +3,6 @@ name: {{name}}
 description: {{description}}
 {{#if spawns}}spawns: {{spawns}}
 {{/if}}{{#if model}}model: {{model}}
+{{/if}}{{#if thinkingLevel}}thinkingLevel: {{thinkingLevel}}
 {{/if}}---
 {{body}}

package/src/prompts/agents/reviewer.md

@@ -4,6 +4,33 @@ description: Code review specialist for quality and security analysis
 tools: read, grep, find, ls, bash, report_finding
 spawns: explore, task
 model: pi/slow, gpt-5.2-codex, gpt-5.2, codex, gpt
+output:
+  properties:
+    overall_correctness:
+      enum: [correct, incorrect]
+    explanation:
+      type: string
+    confidence:
+      type: number
+  optionalProperties:
+    findings:
+      elements:
+        properties:
+          title:
+            type: string
+          body:
+            type: string
+          priority:
+            type: number
+          confidence:
+            type: number
+          file_path:
+            type: string
+          line_start:
+            type: number
+          line_end:
+            type: number
+  required: [overall_correctness, explanation, confidence]
 ---
 
 You are a senior engineer reviewing a proposed code change. Your goal: identify bugs that the author would want to fix before merging.
@@ -64,11 +91,12 @@ Each `report_finding` requires:
 - `file_path`: Absolute path
 - `line_start`, `line_end`: Range ≤10 lines, must overlap the diff
 
-Final `complete` call:
+Final `complete` call (payload goes under `data`):
 
-- `overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
-- `explanation`: 1-3 sentences
-- `confidence`: 0.0-1.0
+- `data.overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
+- `data.explanation`: Plain text, 1-3 sentences summarizing your verdict. Do NOT include JSON, do NOT repeat findings here (they're already captured via `report_finding`).
+- `data.confidence`: 0.0-1.0
+- `data.findings`: Optional; MUST omit (it is populated from `report_finding` calls)
 
 Correctness judgment ignores non-blocking issues (style, docs, nits).
 

package/src/prompts/tools/task.md

@@ -12,12 +12,14 @@ If you discussed requirements, plans, schemas, or decisions with the user, you M
 ## Available Agents
 
 {{#list agents prefix="- " join="\n"}}
-{{name}}: {{description}} (Tools: {{default (join tools ", ") "All tools"}})
+{{name}}: {{description}} (Tools: {{default (join tools ", ") "All tools"}}{{#if output}}, Output: structured{{/if}})
 {{/list}}
 {{#if moreAgents}}
   ...and {{moreAgents}} more agents
 {{/if}}
 
+Agents with "Output: structured" have a fixed schema enforced via frontmatter; your `output` parameter will be ignored for these agents.
+
 ## When NOT to Use
 
 - Reading a specific file path → Use Read tool instead