@oh-my-pi/pi-coding-agent 4.2.3 → 4.3.1

package/src/core/tools/edit-diff.ts

@@ -49,9 +49,9 @@ function countLeadingWhitespace(line: string): number {
 		const char = line[i];
 		if (char === " " || char === "\t") {
 			count++;
-			continue;
+		} else {
+			break;
 		}
-		break;
 	}
 	return count;
 }
@@ -80,15 +80,16 @@ function computeRelativeIndentDepths(lines: string[]): number[] {
 	});
 }
 
-function normalizeLinesForMatch(lines: string[]): string[] {
-	const indentDepths = computeRelativeIndentDepths(lines);
+function normalizeLinesForMatch(lines: string[], includeDepth = true): string[] {
+	const indentDepths = includeDepth ? computeRelativeIndentDepths(lines) : null;
 	return lines.map((line, index) => {
 		const trimmed = line.trim();
+		const prefix = indentDepths ? `${indentDepths[index]}|` : "|";
 		if (trimmed.length === 0) {
-			return `${indentDepths[index]}|`;
+			return prefix;
 		}
 		const collapsed = trimmed.replace(/[ \t]+/g, " ");
-		return `${indentDepths[index]}|${collapsed}`;
+		return `${prefix}${collapsed}`;
 	});
 }
 
@@ -148,22 +149,14 @@ function computeLineOffsets(lines: string[]): number[] {
 	return offsets;
 }
 
-function findBestFuzzyMatch(
-	content: string,
-	target: string,
+function findBestFuzzyMatchCore(
+	contentLines: string[],
+	targetLines: string[],
+	offsets: number[],
 	threshold: number,
+	includeDepth: boolean,
 ): { best?: EditMatch; aboveThresholdCount: number } {
-	const contentLines = content.split("\n");
-	const targetLines = target.split("\n");
-	if (targetLines.length === 0 || target.length === 0) {
-		return { aboveThresholdCount: 0 };
-	}
-	if (targetLines.length > contentLines.length) {
-		return { aboveThresholdCount: 0 };
-	}
-
-	const targetNormalized = normalizeLinesForMatch(targetLines);
-	const offsets = computeLineOffsets(contentLines);
+	const targetNormalized = normalizeLinesForMatch(targetLines, includeDepth);
 
 	let best: EditMatch | undefined;
 	let bestScore = -1;
@@ -171,7 +164,7 @@ function findBestFuzzyMatch(
 
 	for (let start = 0; start <= contentLines.length - targetLines.length; start++) {
 		const windowLines = contentLines.slice(start, start + targetLines.length);
-		const windowNormalized = normalizeLinesForMatch(windowLines);
+		const windowNormalized = normalizeLinesForMatch(windowLines, includeDepth);
 		let score = 0;
 		for (let i = 0; i < targetLines.length; i++) {
 			score += similarityScore(targetNormalized[i], windowNormalized[i]);
@@ -196,6 +189,36 @@ function findBestFuzzyMatch(
 	return { best, aboveThresholdCount };
 }
 
+const FALLBACK_THRESHOLD = 0.8;
+
+function findBestFuzzyMatch(
+	content: string,
+	target: string,
+	threshold: number,
+): { best?: EditMatch; aboveThresholdCount: number } {
+	const contentLines = content.split("\n");
+	const targetLines = target.split("\n");
+	if (targetLines.length === 0 || target.length === 0) {
+		return { aboveThresholdCount: 0 };
+	}
+	if (targetLines.length > contentLines.length) {
+		return { aboveThresholdCount: 0 };
+	}
+
+	const offsets = computeLineOffsets(contentLines);
+
+	let result = findBestFuzzyMatchCore(contentLines, targetLines, offsets, threshold, true);
+
+	if (result.best && result.best.confidence < threshold && result.best.confidence >= FALLBACK_THRESHOLD) {
+		const noDepthResult = findBestFuzzyMatchCore(contentLines, targetLines, offsets, threshold, false);
+		if (noDepthResult.best && noDepthResult.best.confidence > result.best.confidence) {
+			result = noDepthResult;
+		}
+	}
+
+	return result;
+}
+
 export function findEditMatch(
 	content: string,
 	target: string,

package/src/core/tools/exa/mcp-client.ts

@@ -292,8 +292,8 @@ export async function fetchMCPToolSchema(
 			mcpSchemaCache.set(cacheKey, tool);
 			return tool;
 		}
-	} catch {
-		// Fall through to return null
+	} catch (error) {
+		logger.warn("Failed to fetch MCP tool schema", { mcpToolName, isWebsetsTool, error: String(error) });
 	}
 	return null;
 }

package/src/core/tools/task/agents.ts

@@ -4,6 +4,7 @@
  * Agents are embedded at build time via Bun's import with { type: "text" }.
  */
 
+import { parseAgentFields, parseFrontmatter } from "../../../discovery/helpers";
 import exploreMd from "../../../prompts/agents/explore.md" with { type: "text" };
 // Embed agent markdown files at build time
 import agentFrontmatterTemplate from "../../../prompts/agents/frontmatter.md" with { type: "text" };
@@ -18,6 +19,7 @@ interface AgentFrontmatter {
 	description: string;
 	spawns?: string;
 	model?: string;
+	thinkingLevel?: string;
 }
 
 interface EmbeddedAgentDef {
@@ -71,80 +73,19 @@ const EMBEDDED_AGENTS: { name: string; content: string }[] = EMBEDDED_AGENT_DEFS
 	content: buildAgentContent(def),
 }));
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
-}
-
 /**
  * Parse an agent from embedded content.
  */
 function parseAgent(fileName: string, content: string, source: AgentSource): AgentDefinition | null {
 	const { frontmatter, body } = parseFrontmatter(content);
+	const fields = parseAgentFields(frontmatter);
 
-	if (!frontmatter.name || !frontmatter.description) {
+	if (!fields) {
 		return null;
 	}
 
-	const tools = frontmatter.tools
-		?.split(",")
-		.map((t) => t.trim())
-		.filter(Boolean);
-
-	// Parse spawns field
-	let spawns: string[] | "*" | undefined;
-	if (frontmatter.spawns !== undefined) {
-		const spawnsRaw = frontmatter.spawns.trim();
-		if (spawnsRaw === "*") {
-			spawns = "*";
-		} else if (spawnsRaw) {
-			spawns = spawnsRaw
-				.split(",")
-				.map((s) => s.trim())
-				.filter(Boolean);
-			if (spawns.length === 0) spawns = undefined;
-		}
-	}
-
-	// Backward compat: infer spawns: "*" when tools includes "task"
-	if (spawns === undefined && tools?.includes("task")) {
-		spawns = "*";
-	}
-
 	return {
-		name: frontmatter.name,
-		description: frontmatter.description,
-		tools: tools && tools.length > 0 ? tools : undefined,
-		spawns,
-		model: frontmatter.model,
+		...fields,
 		systemPrompt: body,
 		source,
 		filePath: `embedded:${fileName}`,

package/src/core/tools/task/commands.ts

@@ -7,6 +7,7 @@
 import * as path from "node:path";
 import { type SlashCommand, slashCommandCapability } from "../../../capability/slash-command";
 import { loadCapability } from "../../../discovery";
+import { parseFrontmatter } from "../../../discovery/helpers";
 
 // Embed command markdown files at build time
 import initMd from "../../../prompts/agents/init.md" with { type: "text" };
@@ -27,37 +28,10 @@ export interface WorkflowCommand {
 	filePath: string;
 }
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
+/** Extract string value from frontmatter field */
+function getString(frontmatter: Record<string, unknown>, key: string): string {
+	const value = frontmatter[key];
+	return typeof value === "string" ? value : "";
 }
 
 /** Cache for bundled commands */
@@ -79,7 +53,7 @@ export function loadBundledCommands(): WorkflowCommand[] {
 
 		commands.push({
 			name: cmdName,
-			description: frontmatter.description || "",
+			description: getString(frontmatter, "description"),
 			instructions: body,
 			source: "bundled",
 			filePath: `embedded:${name}`,
@@ -115,7 +89,7 @@ export async function discoverCommands(cwd: string): Promise<WorkflowCommand[]>
 
 		commands.push({
 			name: cmd.name,
-			description: frontmatter.description || "",
+			description: getString(frontmatter, "description"),
 			instructions: body,
 			source,
 			filePath: cmd.path,

package/src/core/tools/task/discovery.ts

@@ -15,6 +15,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { findAllNearestProjectConfigDirs, getConfigDirs } from "../../../config";
+import { parseAgentFields, parseFrontmatter } from "../../../discovery/helpers";
 import { loadBundledAgents } from "./agents";
 import type { AgentDefinition, AgentSource } from "./types";
 
@@ -24,40 +25,6 @@ export interface DiscoveryResult {
 	projectAgentsDir: string | null;
 }
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			// Strip quotes
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
-}
-
 /**
  * Load agents from a directory.
  */
@@ -95,43 +62,14 @@ function loadAgentsFromDir(dir: string, source: AgentSource): AgentDefinition[]
 		}
 
 		const { frontmatter, body } = parseFrontmatter(content);
+		const fields = parseAgentFields(frontmatter);
 
-		// Require name and description
-		if (!frontmatter.name || !frontmatter.description) {
+		if (!fields) {
 			continue;
 		}
 
-		const tools = frontmatter.tools
-			?.split(",")
-			.map((t) => t.trim())
-			.filter(Boolean);
-
-		// Parse spawns field
-		let spawns: string[] | "*" | undefined;
-		if (frontmatter.spawns !== undefined) {
-			const spawnsRaw = frontmatter.spawns.trim();
-			if (spawnsRaw === "*") {
-				spawns = "*";
-			} else if (spawnsRaw) {
-				spawns = spawnsRaw
-					.split(",")
-					.map((s) => s.trim())
-					.filter(Boolean);
-				if (spawns.length === 0) spawns = undefined;
-			}
-		}
-
-		// Backward compat: infer spawns: "*" when tools includes "task"
-		if (spawns === undefined && tools?.includes("task")) {
-			spawns = "*";
-		}
-
 		agents.push({
-			name: frontmatter.name,
-			description: frontmatter.description,
-			tools: tools && tools.length > 0 ? tools : undefined,
-			spawns,
-			model: frontmatter.model,
+			...fields,
 			systemPrompt: body,
 			source,
 			filePath,

package/src/core/tools/task/executor.ts

@@ -4,7 +4,7 @@
  * Runs each subagent in a Bun Worker and forwards AgentEvents for progress tracking.
  */
 
-import type { AgentEvent } from "@oh-my-pi/pi-agent-core";
+import type { AgentEvent, ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import type { AuthStorage } from "../../auth-storage";
 import type { EventBus } from "../../event-bus";
 import { callTool } from "../../mcp/client";
@@ -18,6 +18,7 @@ import {
 	type AgentProgress,
 	MAX_OUTPUT_BYTES,
 	MAX_OUTPUT_LINES,
+	type ReviewFinding,
 	type SingleResult,
 	TASK_SUBAGENT_EVENT_CHANNEL,
 	TASK_SUBAGENT_PROGRESS_CHANNEL,
@@ -39,6 +40,7 @@ export interface ExecutorOptions {
 	taskId: string;
 	context?: string;
 	modelOverride?: string;
+	thinkingLevel?: ThinkingLevel;
 	outputSchema?: unknown;
 	enableLsp?: boolean;
 	signal?: AbortSignal;
@@ -183,8 +185,20 @@ function extractMCPToolMetadata(mcpManager: MCPManager): MCPToolMetadata[] {
  * Run a single agent in a worker.
  */
 export async function runSubprocess(options: ExecutorOptions): Promise<SingleResult> {
-	const { cwd, agent, task, index, taskId, context, modelOverride, outputSchema, enableLsp, signal, onProgress } =
-		options;
+	const {
+		cwd,
+		agent,
+		task,
+		index,
+		taskId,
+		context,
+		modelOverride,
+		thinkingLevel,
+		outputSchema,
+		enableLsp,
+		signal,
+		onProgress,
+	} = options;
 	const startTime = Date.now();
 
 	// Initialize progress
@@ -578,6 +592,7 @@ export async function runSubprocess(options: ExecutorOptions): Promise<SingleRes
 			task: fullTask,
 			systemPrompt: agent.systemPrompt,
 			model: resolvedModel,
+			thinkingLevel,
 			toolNames,
 			outputSchema,
 			sessionFile,
@@ -751,6 +766,20 @@ export async function runSubprocess(options: ExecutorOptions): Promise<SingleRes
 					// Not valid JSON, keep as string
 				}
 			}
+			// Special case: merge report_finding data into review output for parent visibility
+			const reportFindings = progress.extractedToolData?.report_finding as ReviewFinding[] | undefined;
+			if (
+				Array.isArray(reportFindings) &&
+				reportFindings.length > 0 &&
+				completeData &&
+				typeof completeData === "object" &&
+				!Array.isArray(completeData)
+			) {
+				const record = completeData as Record<string, unknown>;
+				if (!("findings" in record)) {
+					completeData = { ...record, findings: reportFindings };
+				}
+			}
 			try {
 				rawOutput = JSON.stringify(completeData, null, 2) ?? "null";
 			} catch (err) {

package/src/core/tools/task/index.ts

@@ -156,6 +156,11 @@ export async function createTaskTool(
 			const shouldInheritSessionModel = model === undefined && isDefaultModelAlias(agent.model);
 			const sessionModel = shouldInheritSessionModel ? session.getActiveModelString?.() : undefined;
 			const modelOverride = model ?? sessionModel ?? session.getModelString?.();
+			const thinkingLevelOverride = agent.thinkingLevel;
+
+			// Output schema priority: agent frontmatter > params > inherited from parent session
+			const schemaOverridden = outputSchema !== undefined && agent.output !== undefined;
+			const effectiveOutputSchema = agent.output ?? outputSchema ?? session.outputSchema;
 
 			// Handle empty or missing tasks
 			if (!params.tasks || params.tasks.length === 0) {
@@ -345,7 +350,8 @@ export async function createTaskTool(
 							taskId: task.taskId,
 							context: undefined, // Already prepended above
 							modelOverride,
-							outputSchema,
+							thinkingLevel: thinkingLevelOverride,
+							outputSchema: effectiveOutputSchema,
 							sessionFile,
 							persistArtifacts: !!artifactsDir,
 							artifactsDir: effectiveArtifactsDir,
@@ -399,9 +405,12 @@ export async function createTaskTool(
 				const outputIds = results.map((r) => r.taskId);
 				const outputHint =
 					outputIds.length > 0 ? `\n\nUse output tool for full logs: output ids ${outputIds.join(", ")}` : "";
+				const schemaNote = schemaOverridden
+					? `\n\nNote: Agent '${agentName}' has a fixed output schema; your 'output' parameter was ignored.\nRequired schema: ${JSON.stringify(agent.output)}`
+					: "";
 				const summary = `${successCount}/${results.length} succeeded [${formatDuration(
 					totalDuration,
-				)}]\n\n${summaries.join("\n\n---\n\n")}${outputHint}`;
+				)}]\n\n${summaries.join("\n\n---\n\n")}${outputHint}${schemaNote}`;
 
 				// Cleanup temp directory if used
 				if (tempArtifactsDir) {

package/src/core/tools/task/render.ts

@@ -369,18 +369,28 @@ function renderAgentProgress(
 		}
 
 		for (const [toolName, dataArray] of Object.entries(progress.extractedToolData)) {
+			// Handle report_finding with tree formatting
+			if (toolName === "report_finding" && (dataArray as ReportFindingDetails[]).length > 0) {
+				const findings = dataArray as ReportFindingDetails[];
+				lines.push(`${continuePrefix}${formatFindingSummary(findings, theme)}`);
+				lines.push(...renderFindings(findings, continuePrefix, expanded, theme));
+				continue;
+			}
+
 			const handler = subprocessToolRegistry.getHandler(toolName);
 			if (handler?.renderInline) {
-				// Show last few items inline
-				const recentData = (dataArray as unknown[]).slice(-3);
+				const displayCount = expanded ? (dataArray as unknown[]).length : 3;
+				const recentData = (dataArray as unknown[]).slice(-displayCount);
 				for (const data of recentData) {
 					const component = handler.renderInline(data, theme);
 					if (component instanceof Text) {
 						lines.push(`${continuePrefix}${component.getText()}`);
 					}
 				}
-				if (dataArray.length > 3) {
-					lines.push(`${continuePrefix}${theme.fg("dim", formatMoreItems(dataArray.length - 3, "item", theme))}`);
+				if ((dataArray as unknown[]).length > displayCount) {
+					lines.push(
+						`${continuePrefix}${theme.fg("dim", formatMoreItems((dataArray as unknown[]).length - displayCount, "item", theme))}`,
+					);
 				}
 			}
 		}
@@ -436,7 +446,6 @@ function renderReviewResult(
 	lines.push(`${continuePrefix}${formatFindingSummary(findings, theme)}`);
 
 	if (findings.length > 0) {
-		lines.push(`${continuePrefix}`); // Spacing
 		lines.push(...renderFindings(findings, continuePrefix, expanded, theme));
 	}
 
@@ -453,11 +462,14 @@ function renderFindings(
 	theme: Theme,
 ): string[] {
 	const lines: string[] = [];
-	const displayCount = expanded ? findings.length : Math.min(3, findings.length);
+
+	// Sort by priority (lower = more severe) when collapsed to show most important first
+	const sortedFindings = expanded ? findings : [...findings].sort((a, b) => a.priority - b.priority);
+	const displayCount = expanded ? sortedFindings.length : Math.min(3, sortedFindings.length);
 
 	for (let i = 0; i < displayCount; i++) {
-		const finding = findings[i];
-		const isLastFinding = i === displayCount - 1 && (expanded || findings.length <= 3);
+		const finding = sortedFindings[i];
+		const isLastFinding = i === displayCount - 1 && (expanded || sortedFindings.length <= 3);
 		const findingPrefix = isLastFinding ? theme.tree.last : theme.tree.branch;
 		const findingContinue = isLastFinding ? "   " : `${theme.tree.vertical}  `;
 
@@ -538,14 +550,12 @@ function renderAgentResult(result: SingleResult, isLast: boolean, expanded: bool
 		return lines;
 	}
 	if (reportFindingData && reportFindingData.length > 0) {
-		lines.push(
-			`${continuePrefix}${theme.fg("warning", theme.status.warning)} ${theme.fg(
-				"dim",
-				"Review summary missing (complete not called)",
-			)}`,
-		);
+		const hasCompleteData = completeData && completeData.length > 0;
+		const message = hasCompleteData
+			? "Review verdict missing expected fields"
+			: "Review incomplete (complete not called)";
+		lines.push(`${continuePrefix}${theme.fg("warning", theme.status.warning)} ${theme.fg("dim", message)}`);
 		lines.push(`${continuePrefix}${formatFindingSummary(reportFindingData, theme)}`);
-		lines.push(`${continuePrefix}`); // Spacing
 		lines.push(...renderFindings(reportFindingData, continuePrefix, expanded, theme));
 		return lines;
 	}

package/src/core/tools/task/types.ts

@@ -1,3 +1,4 @@
+import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import type { Usage } from "@oh-my-pi/pi-ai";
 import { type Static, Type } from "@sinclair/typebox";
 
@@ -106,6 +107,8 @@ export interface AgentDefinition {
 	tools?: string[];
 	spawns?: string[] | "*";
 	model?: string;
+	thinkingLevel?: ThinkingLevel;
+	output?: unknown;
 	source: AgentSource;
 	filePath?: string;
 }

package/src/core/tools/task/worker-protocol.ts

@@ -1,4 +1,4 @@
-import type { AgentEvent } from "@oh-my-pi/pi-agent-core";
+import type { AgentEvent, ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import type { SerializedAuthStorage } from "../../auth-storage";
 import type { SerializedModelRegistry } from "../../model-registry";
 
@@ -43,6 +43,7 @@ export interface SubagentWorkerStartPayload {
 	task: string;
 	systemPrompt: string;
 	model?: string;
+	thinkingLevel?: ThinkingLevel;
 	toolNames?: string[];
 	outputSchema?: unknown;
 	enableLsp?: boolean;

package/src/core/tools/task/worker.ts

@@ -287,7 +287,8 @@ async function runTask(runState: RunState, payload: SubagentWorkerStartPayload):
 		const mcpProxyTools = payload.mcpTools?.map(createMCPProxyTool) ?? [];
 
 		// Resolve model override (equivalent to CLI's parseModelPattern with --model)
-		const { model, thinkingLevel } = resolveModelOverride(payload.model, modelRegistry);
+		const { model, thinkingLevel: modelThinkingLevel } = resolveModelOverride(payload.model, modelRegistry);
+		const thinkingLevel = modelThinkingLevel ?? payload.thinkingLevel;
 
 		// Create session manager (equivalent to CLI's --session or --no-session)
 		const sessionManager = payload.sessionFile

package/src/core/tools/web-scrapers/huggingface.ts

@@ -379,7 +379,7 @@ export const handleHuggingFace: SpecialHandler = async (url: string, timeout: nu
 			default:
 				return null;
 		}
-	} catch (_err) {
+	} catch {
 		return null;
 	}
 };

package/src/core/tools/web-scrapers/readthedocs.ts

@@ -95,7 +95,7 @@ export const handleReadTheDocs: SpecialHandler = async (
 				content = sourceResult.content;
 				notes.push(`Fetched raw source from ${sourceUrl}`);
 			}
-		} catch (_err) {
+		} catch {
 			// Ignore errors, fall back to HTML
 		}
 	}

package/src/core/tools/web-scrapers/types.ts

@@ -170,7 +170,7 @@ export async function loadPage(url: string, options: LoadPageOptions = {}): Prom
 			}
 
 			return { content, contentType, finalUrl, ok: true, status: response.status };
-		} catch (_err) {
+		} catch {
 			if (signal?.aborted) {
 				return { content: "", contentType: "", finalUrl: url, ok: false };
 			}

package/src/core/tools/web-search/auth.ts

@@ -14,6 +14,7 @@ import { buildBetaHeader, claudeCodeHeaders, claudeCodeVersion } from "@oh-my-pi
 import { getAgentDbPath, getConfigDirPaths } from "../../../config";
 import { AgentStorage } from "../../agent-storage";
 import type { AuthCredential, AuthCredentialEntry, AuthStorageData } from "../../auth-storage";
+import { logger } from "../../logger";
 import { migrateJsonStorage } from "../../storage-migration";
 import type { AnthropicAuthConfig, AnthropicOAuthCredential, ModelsJson } from "./types";
 
@@ -48,8 +49,8 @@ async function parseEnvFile(filePath: string): Promise<Record<string, string>> {
 
 			result[key] = value;
 		}
-	} catch {
-		// Ignore read errors
+	} catch (error) {
+		logger.warn("Failed to read .env file", { path: filePath, error: String(error) });
 	}
 	return result;
 }
@@ -82,7 +83,8 @@ async function readJson<T>(filePath: string): Promise<T | null> {
 		if (!(await file.exists())) return null;
 		const content = await file.text();
 		return JSON.parse(content) as T;
-	} catch {
+	} catch (error) {
+		logger.warn("Failed to parse JSON file", { path: filePath, error: String(error) });
 		return null;
 	}
 }