@oh-my-pi/pi-coding-agent 17.1.5 → 17.1.7

package/src/ssh/__tests__/file-transfer-posix-guard.test.ts

@@ -1,105 +0,0 @@
-import { afterEach, describe, expect, it, vi } from "bun:test";
-import type { SSHConnectionTarget } from "../connection-manager";
-import * as connectionManager from "../connection-manager";
-import { listRemoteDir, readRemoteFile, statRemotePath, writeRemoteFile } from "../file-transfer";
-
-describe("ssh file-transfer POSIX guard", () => {
-	afterEach(() => {
-		vi.restoreAllMocks();
-	});
-
-	it("rejects a confirmed Windows remote before running any POSIX command", async () => {
-		// Stub BOTH the connection and the host-info probe so the guard is reached
-		// without opening a real SSH connection and before any command is spawned.
-		const ensureConnectionSpy = vi.spyOn(connectionManager, "ensureConnection").mockResolvedValue(undefined);
-		const ensureHostInfoSpy = vi.spyOn(connectionManager, "ensureHostInfo").mockResolvedValue({
-			version: 4,
-			os: "windows",
-			shell: "powershell",
-			compatEnabled: false,
-		});
-		const target: SSHConnectionTarget = { name: "winbox", host: "winbox" };
-		await expect(readRemoteFile(target, "C:/x.txt", { maxBytes: 1024 })).rejects.toThrow(/Windows host/);
-		await expect(writeRemoteFile(target, "C:/x.txt", new Uint8Array([1]), {})).rejects.toThrow(/Windows host/);
-		// Prove the guard ran through the stubbed transport rather than failing early
-		// for an unrelated reason (e.g. a future import refactor bypassing the mocks).
-		expect(ensureConnectionSpy).toHaveBeenCalled();
-		expect(ensureHostInfoSpy).toHaveBeenCalled();
-	});
-
-	it("rejects a non-Windows remote with no verified transferShell", async () => {
-		// No transferShell means the capability probe never confirmed any of
-		// sh/bash/zsh works. The guard refuses regardless of `shell` because the
-		// real ssh:// contract is "did we verify a POSIX shell works", not
-		// "what name did the login shell self-report" (#3719).
-		vi.spyOn(connectionManager, "ensureConnection").mockResolvedValue(undefined);
-		vi.spyOn(connectionManager, "ensureHostInfo").mockResolvedValue({
-			version: 4,
-			os: "linux",
-			shell: "unknown",
-			compatEnabled: false,
-		});
-		const target: SSHConnectionTarget = { name: "noshell", host: "noshell" };
-		await expect(readRemoteFile(target, "/etc/hosts", { maxBytes: 1024 })).rejects.toThrow(/no verified POSIX shell/);
-		await expect(writeRemoteFile(target, "/tmp/x", new Uint8Array([1]), {})).rejects.toThrow(
-			/no verified POSIX shell/,
-		);
-	});
-
-	it("dispatches transfer commands through the verified transferShell, not the login shell", async () => {
-		// The bug fix: if the login shell is fish/csh/tcsh, the legacy guard
-		// would refuse the host — but allowing it isn't enough on its own.
-		// OpenSSH still hands our snippets to `$SHELL -c`, so a fish login
-		// shell would choke on `if [ … ]; then …`. Every transfer command
-		// must be wrapped in `<transferShell> -c '…'` to force parsing
-		// under the shell we verified can run it (#3719).
-		vi.spyOn(connectionManager, "ensureConnection").mockResolvedValue(undefined);
-		vi.spyOn(connectionManager, "ensureHostInfo").mockResolvedValue({
-			version: 4,
-			os: "linux",
-			// Login shell is fish; only `transferShell` indicates a working POSIX shell.
-			shell: "unknown",
-			transferShell: "bash",
-			compatEnabled: false,
-		});
-		const buildSpy = vi
-			.spyOn(connectionManager, "buildRemoteCommand")
-			.mockRejectedValue(new Error("stop-before-spawn"));
-		const target: SSHConnectionTarget = { name: "fishbox", host: "fishbox" };
-
-		await expect(readRemoteFile(target, "/etc/hosts", { maxBytes: 1024 })).rejects.toThrow(/stop-before-spawn/);
-		await expect(writeRemoteFile(target, "/tmp/x", new Uint8Array([1]), {})).rejects.toThrow(/stop-before-spawn/);
-		await expect(statRemotePath(target, "/etc/hosts")).rejects.toThrow(/stop-before-spawn/);
-		await expect(listRemoteDir(target, "/etc")).rejects.toThrow(/stop-before-spawn/);
-
-		// Each dispatch must start with `bash -c '…'` and embed the original
-		// POSIX snippet inside the quoted command. Read also drops `-n`
-		// (allowStdin: true) because cat-staging needs stdin streaming.
-		const dispatches = buildSpy.mock.calls.map(call => call[1] as string);
-		expect(dispatches[0]).toMatch(/^bash -c '.*head -c 1025/);
-		expect(dispatches[1]).toMatch(/^bash -c '.*cat > /);
-		expect(buildSpy.mock.calls[1]?.[2]).toMatchObject({ allowStdin: true });
-		expect(dispatches[2]).toMatch(/^bash -c '.*if \[ -d /);
-		expect(dispatches[3]).toMatch(/^bash -c '.*LC_ALL=C ls -1Ap /);
-	});
-
-	it("uses sh -c when transferShell is sh (the most universal POSIX fallback)", async () => {
-		// Belt-and-suspenders: the common happy path with a sh-family login
-		// shell still routes through `sh -c` to keep one dispatch shape.
-		vi.spyOn(connectionManager, "ensureConnection").mockResolvedValue(undefined);
-		vi.spyOn(connectionManager, "ensureHostInfo").mockResolvedValue({
-			version: 4,
-			os: "linux",
-			shell: "sh",
-			transferShell: "sh",
-			compatEnabled: false,
-		});
-		const buildSpy = vi
-			.spyOn(connectionManager, "buildRemoteCommand")
-			.mockRejectedValue(new Error("stop-before-spawn"));
-		const target: SSHConnectionTarget = { name: "shbox", host: "shbox" };
-
-		await expect(readRemoteFile(target, "/etc/hosts", { maxBytes: 1024 })).rejects.toThrow(/stop-before-spawn/);
-		expect(buildSpy.mock.calls[0]?.[1]).toMatch(/^sh -c '.*head -c 1025/);
-	});
-});

package/src/ssh/__tests__/sshfs-mount.test.ts

@@ -1,13 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import * as path from "node:path";
-import { isMounted } from "../sshfs-mount";
-
-describe("isMounted", () => {
-	it("detects a macOS mount point when mountpoint is unavailable", async () => {
-		const parentPath = import.meta.dir;
-		const mountPath = path.join(parentPath, "mounted");
-		const stat = async (filePath: string) => ({ dev: filePath === mountPath ? 2 : 1 });
-
-		await expect(isMounted(mountPath, { platform: "darwin", stat, which: () => null })).resolves.toBe(true);
-	});
-});

package/src/system-prompt.test.ts

@@ -1,236 +0,0 @@
-import { describe, expect, it, spyOn } from "bun:test";
-import * as fs from "node:fs/promises";
-import * as os from "node:os";
-import * as path from "node:path";
-import { buildSystemPrompt } from "./system-prompt";
-
-interface ProbeRunResult {
-	elapsedMs: number;
-	childElapsedMs: number;
-	cached: unknown;
-	count: number;
-}
-
-async function runProbeScenario(options: {
-	runs: number;
-	sleepSeconds?: number;
-	holdStdoutOpen?: boolean;
-	descendantHoldsStdout?: boolean;
-	validOutput?: string;
-}): Promise<ProbeRunResult> {
-	const tempRoot = await fs.mkdtemp(path.join(os.tmpdir(), "omp-gpu-probe-"));
-	try {
-		const binDir = path.join(tempRoot, "bin");
-		const cacheRoot = path.join(tempRoot, "cache");
-		const probeCountPath = path.join(tempRoot, "probe-count");
-		await fs.mkdir(binDir, { recursive: true });
-		await fs.mkdir(path.join(cacheRoot, "omp"), { recursive: true });
-		const lspciPath = path.join(binDir, "lspci");
-		await Bun.write(
-			lspciPath,
-			'#!/usr/bin/env sh\nprintf x >> "$OMP_GPU_PROBE_COUNT"\nif [ -n "$OMP_GPU_PROBE_VALID_OUTPUT" ]; then printf "%s\\n" "$OMP_GPU_PROBE_VALID_OUTPUT"; fi\nif [ "$OMP_GPU_PROBE_DESCENDANT_HOLDS_STDOUT" = "true" ]; then sleep "$OMP_GPU_PROBE_SLEEP" & exit 0; fi\nif [ "$OMP_GPU_PROBE_HOLD_STDOUT_OPEN" = "true" ]; then sleep "$OMP_GPU_PROBE_SLEEP" & wait "$!"; fi\nif [ -n "$OMP_GPU_PROBE_SLEEP" ]; then exec sleep "$OMP_GPU_PROBE_SLEEP"; fi\nexit 0\n',
-		);
-		await fs.chmod(lspciPath, 0o755);
-
-		const scenarioPath = path.join(tempRoot, "scenario.ts");
-		await Bun.write(
-			scenarioPath,
-			`import { getGpuCachePath, refreshDirsFromEnv } from ${JSON.stringify(path.resolve(import.meta.dir, "../../utils/src/index.ts"))};
-import { buildSystemPrompt } from ${JSON.stringify(path.join(import.meta.dir, "system-prompt.ts"))};
-
-refreshDirsFromEnv();
-const buildOptions = {
-	contextFiles: [],
-	skills: [],
-	toolNames: [],
-	workspaceTree: {
-		rootPath: process.cwd(),
-		rendered: "",
-		truncated: false,
-		totalLines: 0,
-		agentsMdFiles: [],
-	},
-	activeRepoContext: null,
-};
-const startedAt = performance.now();
-for (let index = 0; index < Number(process.env.OMP_GPU_PROBE_RUNS ?? "1"); index += 1) {
-	await buildSystemPrompt(buildOptions);
-}
-const cacheFile = Bun.file(getGpuCachePath());
-const cached = await cacheFile.exists() ? await cacheFile.json() : null;
-const countFile = Bun.file(process.env.OMP_GPU_PROBE_COUNT ?? "");
-const count = await countFile.exists() ? (await countFile.text()).length : 0;
-console.log(JSON.stringify({ elapsedMs: Math.round(performance.now() - startedAt), cached, count }));
-`,
-		);
-
-		const env: Record<string, string | undefined> = {
-			...process.env,
-			PATH: `${binDir}:${process.env.PATH ?? ""}`,
-			XDG_CACHE_HOME: cacheRoot,
-			OMP_GPU_PROBE_COUNT: probeCountPath,
-			OMP_GPU_PROBE_RUNS: String(options.runs),
-		};
-		// Strip inherited dirs-resolver overrides so XDG_CACHE_HOME above wins and
-		// the test cannot touch the developer/CI profile's real gpu_cache.json.
-		for (const key of ["PI_CODING_AGENT_DIR", "OMP_PROFILE", "PI_PROFILE", "PI_CONFIG_DIR"]) {
-			delete env[key];
-		}
-		if (options.sleepSeconds === undefined) {
-			delete env.OMP_GPU_PROBE_SLEEP;
-		} else {
-			env.OMP_GPU_PROBE_SLEEP = String(options.sleepSeconds);
-		}
-		if (options.holdStdoutOpen) {
-			env.OMP_GPU_PROBE_HOLD_STDOUT_OPEN = "true";
-		} else {
-			delete env.OMP_GPU_PROBE_HOLD_STDOUT_OPEN;
-		}
-		if (options.descendantHoldsStdout) {
-			env.OMP_GPU_PROBE_DESCENDANT_HOLDS_STDOUT = "true";
-		} else {
-			delete env.OMP_GPU_PROBE_DESCENDANT_HOLDS_STDOUT;
-		}
-		if (options.validOutput !== undefined) {
-			env.OMP_GPU_PROBE_VALID_OUTPUT = options.validOutput;
-		} else {
-			delete env.OMP_GPU_PROBE_VALID_OUTPUT;
-		}
-
-		const childStartedAt = performance.now();
-		const child = Bun.spawn([process.execPath, scenarioPath], { stdout: "pipe", stderr: "pipe", env });
-		const [stdout, stderr, exitCode] = await Promise.all([
-			new Response(child.stdout).text(),
-			new Response(child.stderr).text(),
-			child.exited,
-		]);
-		const childElapsedMs = Math.round(performance.now() - childStartedAt);
-		if (exitCode !== 0) {
-			throw new Error(`GPU probe scenario failed with exit ${exitCode}: ${stderr}`);
-		}
-		return { ...JSON.parse(stdout.trim()), childElapsedMs };
-	} finally {
-		await fs.rm(tempRoot, { recursive: true, force: true });
-	}
-}
-
-describe.skipIf(process.platform !== "linux")("system prompt GPU probe", () => {
-	it("caches empty GPU probe results", async () => {
-		const result = await runProbeScenario({ runs: 2 });
-
-		expect(result.cached).toEqual({ gpu: null });
-		expect(result.count).toBe(1);
-	}, 15_000);
-
-	it("kills the GPU probe at the prep deadline", async () => {
-		const result = await runProbeScenario({ runs: 1, sleepSeconds: 12, holdStdoutOpen: true });
-
-		expect(result.cached).toEqual({ gpu: null });
-		// Probe is SIGKILLed at ~4.5s and the drain wait is bounded, so in-child
-		// time sits near the deadline; waiting on the descendant would push it
-		// past the 12s sleep.
-		expect(result.elapsedMs).toBeLessThan(6500);
-		// Codex#3838: the child process MUST exit shortly after the deadline, not
-		// linger until a descendant holding stdout (sleep 12) exits on its own.
-		// The bound over in-child time budgets bun spawn/startup on loaded runners
-		// while staying far below the descendant's 12s exit.
-		expect(result.childElapsedMs).toBeLessThan(9000);
-	}, 20_000);
-
-	it("does not wait on stdout held by a descendant after a successful probe", async () => {
-		const result = await runProbeScenario({ runs: 1, sleepSeconds: 8, descendantHoldsStdout: true });
-
-		expect(result.cached).toEqual({ gpu: null });
-		// Probe exits 0 immediately but leaves a backgrounded sleep holding the stdout
-		// pipe. The success path MUST bound the drain wait, not block until sleep exits.
-		expect(result.elapsedMs).toBeLessThan(2000);
-		// Budgets bun spawn/startup overhead; blocking on the descendant would
-		// take at least the 8s sleep.
-		expect(result.childElapsedMs).toBeLessThan(5000);
-	}, 20_000);
-
-	it("keeps probe output captured before a descendant delays EOF", async () => {
-		const result = await runProbeScenario({
-			runs: 1,
-			sleepSeconds: 8,
-			descendantHoldsStdout: true,
-			validOutput: "00:02.0 VGA compatible controller: NVIDIA TestGPU",
-		});
-
-		// Probe exited 0 with valid output before bg sleep held stdout open.
-		// Captured stdout MUST be cached, not discarded as if the probe failed.
-		expect(result.cached).toEqual({ gpu: "02.0 VGA compatible controller: NVIDIA TestGPU" });
-		expect(result.elapsedMs).toBeLessThan(2000);
-		// Budgets bun spawn/startup overhead; blocking on the descendant would
-		// take at least the 8s sleep.
-		expect(result.childElapsedMs).toBeLessThan(5000);
-	}, 20_000);
-});
-
-describe.skipIf(process.platform !== "linux")("system prompt CPU model", () => {
-	it("does not call os.cpus while building the workstation block", async () => {
-		const cpus = spyOn(os, "cpus").mockImplementation(() => [
-			{
-				model: "Synthetic Slow CPU",
-				speed: 0,
-				times: { user: 0, nice: 0, sys: 0, idle: 0, irq: 0 },
-			},
-		]);
-		try {
-			await buildSystemPrompt({
-				resolvedCustomPrompt: "Base prompt",
-				contextFiles: [],
-				skills: [],
-				rules: [],
-				workspaceTree: {
-					rootPath: import.meta.dir,
-					rendered: "",
-					truncated: false,
-					totalLines: 0,
-					agentsMdFiles: [],
-				},
-				activeRepoContext: null,
-			});
-
-			expect(cpus).not.toHaveBeenCalled();
-		} finally {
-			cpus.mockRestore();
-		}
-	});
-});
-
-describe("non-Linux system prompt CPU model", () => {
-	it("includes the model returned by os.cpus", async () => {
-		const originalPlatform = process.platform;
-		Object.defineProperty(process, "platform", { value: "darwin" });
-		const cpus = spyOn(os, "cpus").mockImplementation(() => [
-			{
-				model: "Synthetic Non-Linux CPU",
-				speed: 0,
-				times: { user: 0, nice: 0, sys: 0, idle: 0, irq: 0 },
-			},
-		]);
-		try {
-			const systemPrompt = await buildSystemPrompt({
-				resolvedCustomPrompt: "Base prompt",
-				contextFiles: [],
-				skills: [],
-				rules: [],
-				workspaceTree: {
-					rootPath: import.meta.dir,
-					rendered: "",
-					truncated: false,
-					totalLines: 0,
-					agentsMdFiles: [],
-				},
-				activeRepoContext: null,
-			});
-
-			expect(cpus).toHaveBeenCalledTimes(1);
-			expect(systemPrompt.systemPrompt.join("\n")).toContain("- CPU: Synthetic Non-Linux CPU");
-		} finally {
-			cpus.mockRestore();
-			Object.defineProperty(process, "platform", { value: originalPlatform });
-		}
-	});
-});

package/src/task/render.test.ts

@@ -1,290 +0,0 @@
-import { afterEach, beforeAll, describe, expect, it } from "bun:test";
-import { Settings } from "../config/settings";
-import { getThemeByName, setThemeInstance, type Theme } from "../modes/theme/theme";
-import { renderResult } from "./render";
-import { taskToolRenderer } from "./renderer";
-import type { AgentProgress, SingleResult, TaskToolDetails } from "./types";
-
-const strip = (lines: readonly string[]): string =>
-	lines
-		.join("\n")
-		.replace(/\x1b\]8;[^\x1b\x07]*(?:\x07|\x1b\\)/g, "")
-		.replace(/\x1b\[[0-9;]*m/g, "");
-
-const originalRowsDescriptor = Object.getOwnPropertyDescriptor(process.stdout, "rows");
-
-function setViewportRows(rows: number): void {
-	Object.defineProperty(process.stdout, "rows", { configurable: true, value: rows });
-}
-
-function restoreViewportRows(): void {
-	if (originalRowsDescriptor) {
-		Object.defineProperty(process.stdout, "rows", originalRowsDescriptor);
-		return;
-	}
-	Reflect.deleteProperty(process.stdout, "rows");
-}
-
-function makeProgress(recentOutput: string[]): AgentProgress {
-	return {
-		index: 0,
-		id: "NoisySubagent",
-		agent: "task",
-		agentSource: "bundled",
-		status: "running",
-		task: "produce noisy output",
-		recentTools: [],
-		recentOutput,
-		toolCount: 1,
-		requests: 1,
-		tokens: 0,
-		cost: 0,
-		durationMs: 0,
-	};
-}
-
-function makeParentWithNestedProgress(childCount: number): AgentProgress {
-	const children = Array.from(
-		{ length: childCount },
-		(_, index): AgentProgress => ({
-			...makeProgress([]),
-			index,
-			id: `Nested${index + 1}`,
-			task: `nested child ${index + 1}`,
-		}),
-	);
-	return {
-		...makeProgress([]),
-		id: "Parent",
-		task: "parent task",
-		inflightTaskDetails: {
-			projectAgentsDir: null,
-			results: [],
-			totalDurationMs: 1,
-			progress: children,
-		},
-	};
-}
-
-function makeSingleResult(index: number, overrides?: Partial<SingleResult>): SingleResult {
-	return {
-		index,
-		id: `Done${index + 1}`,
-		agent: "task",
-		agentSource: "bundled",
-		task: `finished child ${index + 1}`,
-		exitCode: 0,
-		output: "ok",
-		stderr: "",
-		truncated: false,
-		durationMs: 5,
-		tokens: 0,
-		requests: 1,
-		...overrides,
-	};
-}
-
-function makeParentWithNestedResults(childCount: number): TaskToolDetails {
-	const nested: TaskToolDetails = {
-		projectAgentsDir: null,
-		// Failure on the LAST child in display order (equal durations, index tiebreak):
-		// a plain head-of-list pick would elide it, so its visibility proves the
-		// failure-first selection of `selectCollapsedResults`.
-		results: Array.from({ length: childCount }, (_, index) =>
-			makeSingleResult(index, index === childCount - 1 ? { exitCode: 1, error: "boom" } : undefined),
-		),
-		totalDurationMs: 1,
-	};
-	const parent = makeSingleResult(0, { id: "Parent", extractedToolData: { task: [nested] } });
-	return { projectAgentsDir: null, results: [parent], totalDurationMs: 1 };
-}
-
-function renderResultText(details: TaskToolDetails, expanded: boolean, uiTheme: Theme): string {
-	const component = renderResult(
-		{ content: [{ type: "text", text: "Ran 1 agent" }], details },
-		{ expanded, isPartial: false },
-		uiTheme,
-	);
-	return strip(component.render(120));
-}
-
-function renderProgressText(progress: AgentProgress, expanded: boolean, uiTheme: Theme): string {
-	const details: TaskToolDetails = {
-		projectAgentsDir: null,
-		results: [],
-		totalDurationMs: 1,
-		progress: [progress],
-	};
-	const component = renderResult(
-		{ content: [{ type: "text", text: "Running 1 agent..." }], details },
-		{ expanded, isPartial: true },
-		uiTheme,
-	);
-	return strip(component.render(120));
-}
-
-describe("task live progress rendering", () => {
-	let uiTheme: Theme;
-
-	beforeAll(async () => {
-		await Settings.init({ inMemory: true });
-		const loaded = await getThemeByName("dark");
-		if (!loaded) throw new Error("theme unavailable");
-		uiTheme = loaded;
-		setThemeInstance(uiTheme);
-	});
-
-	afterEach(() => {
-		restoreViewportRows();
-	});
-
-	it("caps subagent recent output with the viewport budget instead of a fixed six lines", () => {
-		setViewportRows(40);
-		const chronological = Array.from({ length: 8 }, (_, index) => `line ${index + 1}`);
-		const text = renderProgressText(makeProgress([...chronological].reverse()), true, uiTheme);
-
-		expect(text).toContain("line 1");
-		expect(text).toContain("line 8");
-		expect(text).not.toContain("more lines");
-	});
-
-	it("keeps the newest subagent output when the viewport cap truncates", () => {
-		setViewportRows(24);
-		const chronological = Array.from({ length: 8 }, (_, index) => `line ${index + 1}`);
-		const text = renderProgressText(makeProgress([...chronological].reverse()), true, uiTheme);
-
-		expect(text).toContain("… 3 earlier lines");
-		expect(text).not.toContain("line 1");
-		expect(text).not.toContain("line 3");
-		expect(text).toContain("line 4");
-		expect(text).toContain("line 8");
-	});
-
-	it("strips bash footer notices from expanded subagent recent output", () => {
-		setViewportRows(40);
-		const chronological = [
-			"line 1",
-			"line 2",
-			"line 3",
-			"line 4",
-			"line 5",
-			"line 6",
-			"Wall time: 0.03 seconds",
-			"[raw output: artifact://123]",
-		];
-		const progress = makeProgress([...chronological].reverse());
-
-		const expandedText = renderProgressText(progress, true, uiTheme);
-		expect(expandedText).toContain("line 1");
-		expect(expandedText).toContain("line 6");
-		expect(expandedText).not.toContain("Wall time:");
-		expect(expandedText).not.toContain("raw output:");
-
-		const collapsedText = renderProgressText(progress, false, uiTheme);
-		expect(collapsedText).not.toContain("line 1");
-		expect(collapsedText).not.toContain("raw output:");
-	});
-	it("sanitizes control sequences from expanded subagent recent output", () => {
-		setViewportRows(40);
-		const progress = makeProgress(["safe after \x1b[2Kclear", "raw\rprompt"]);
-
-		const text = renderProgressText(progress, true, uiTheme);
-
-		expect(text).toContain("safe after clear");
-		expect(text).toContain("rawprompt");
-		expect(text).not.toContain("\x1b[2K");
-		expect(text).not.toContain("\r");
-	});
-	it("sanitizes control sequences from finalized subagent results", () => {
-		const output = JSON.stringify({ "\x1b[2Kkey": "safe value" });
-		const details: TaskToolDetails = {
-			projectAgentsDir: null,
-			results: [
-				makeSingleResult(0, {
-					id: "Final\x1b[2KAgent",
-					description: "description\rtext",
-					aborted: true,
-					abortReason: "aborted \x1b[2Kreason",
-					output,
-				}),
-			],
-			totalDurationMs: 1,
-		};
-
-		const text = renderResultText(details, true, uiTheme);
-
-		expect(text).toContain("FinalAgent");
-		expect(text).toContain("descriptiontext");
-		expect(text).toContain("aborted reason");
-		expect(text).toContain("key");
-		expect(text).not.toContain("\x1b[2K");
-		expect(text).not.toContain("\r");
-	});
-
-	it("caps collapsed nested task progress at four rows plus an elision line", () => {
-		setViewportRows(40);
-		const text = renderProgressText(makeParentWithNestedProgress(6), false, uiTheme);
-
-		expect(text).not.toContain("Nested1");
-		expect(text).not.toContain("Nested2");
-		expect(text).toContain("Nested3");
-		expect(text).toContain("Nested4");
-		expect(text).toContain("Nested5");
-		expect(text).toContain("Nested6");
-		expect(text).toContain("2 more agents");
-	});
-
-	it("shows every nested task progress row when expanded", () => {
-		setViewportRows(40);
-		const text = renderProgressText(makeParentWithNestedProgress(6), true, uiTheme);
-
-		for (let index = 1; index <= 6; index++) {
-			expect(text).toContain(`Nested${index}`);
-		}
-		expect(text).not.toContain("more agents");
-	});
-
-	it("caps collapsed finalized nested task results and keeps the failed child visible", () => {
-		setViewportRows(40);
-		const text = renderResultText(makeParentWithNestedResults(6), false, uiTheme);
-
-		expect(text).toContain("Done6"); // failed child wins a slot despite sorting last
-		expect(text).toContain("2 more agents");
-		const visibleChildren = [1, 2, 3, 4, 5, 6].filter(index => text.includes(`Done${index}`));
-		expect(visibleChildren).toHaveLength(4);
-	});
-
-	it("shows every finalized nested task result when expanded", () => {
-		setViewportRows(40);
-		const text = renderResultText(makeParentWithNestedResults(6), true, uiTheme);
-
-		for (let index = 1; index <= 6; index++) {
-			expect(text).toContain(`Done${index}`);
-		}
-		expect(text).not.toContain("more agents");
-	});
-
-	it("does not request spinner ticks for static partial progress", () => {
-		expect("animatedPartialResult" in taskToolRenderer).toBe(false);
-	});
-
-	it("renders running progress identically across spinner frames", () => {
-		const progress = makeProgress([]);
-		const details: TaskToolDetails = {
-			projectAgentsDir: null,
-			results: [],
-			totalDurationMs: 1,
-			progress: [progress],
-		};
-		const render = (spinnerFrame: number) =>
-			strip(
-				renderResult(
-					{ content: [{ type: "text", text: "Running 1 agent..." }], details },
-					{ expanded: false, isPartial: true, spinnerFrame },
-					uiTheme,
-				).render(120),
-			);
-
-		expect(render(0)).toBe(render(1));
-	});
-});