@oh-my-pi/pi-coding-agent 17.1.5 → 17.1.7

package/src/modes/components/__tests__/move-overlay.test.ts

@@ -1,252 +0,0 @@
-import { afterEach, beforeAll, beforeEach, describe, expect, it, spyOn } from "bun:test";
-import * as fs from "node:fs";
-import * as fsp from "node:fs/promises";
-import * as os from "node:os";
-import * as path from "node:path";
-import { visibleWidth } from "@oh-my-pi/pi-tui";
-import { Settings } from "../../../config/settings";
-import { getThemeByName, setThemeInstance, type Theme } from "../../theme/theme";
-import { MoveOverlay, type MoveOverlayResult, resolveExistingDirectory, resolveMovePath } from "../move-overlay";
-
-// Strip SGR colors so assertions see visible text only.
-const stripAnsi = (text: string): string => text.replace(/\x1b\[[0-9;]*m/g, "");
-const strip = (lines: readonly string[]): string => lines.map(stripAnsi).join("\n");
-
-describe("resolveMovePath", () => {
-	it("expands ~ to homedir", () => {
-		expect(resolveMovePath("~", "/anywhere")).toBe(os.homedir());
-	});
-	it("expands ~/sub to homedir/sub", () => {
-		expect(resolveMovePath("~/foo", "/anywhere")).toBe(path.join(os.homedir(), "foo"));
-	});
-	it("resolves relative paths against cwd", () => {
-		expect(resolveMovePath("foo/bar", "/parent")).toBe(path.resolve("/parent", "foo/bar"));
-	});
-	it("passes absolute paths through (normalized)", () => {
-		expect(resolveMovePath("/abs/path", "/anywhere")).toBe(path.normalize("/abs/path"));
-	});
-});
-
-describe("resolveExistingDirectory", () => {
-	let tmp: string;
-
-	beforeEach(async () => {
-		tmp = await fsp.mkdtemp(path.join(os.tmpdir(), "omp-move-resolve-"));
-	});
-	afterEach(async () => {
-		await fsp.rm(tmp, { recursive: true, force: true });
-	});
-
-	it("returns the resolved path for an existing directory", () => {
-		const sub = path.join(tmp, "sub");
-		fs.mkdirSync(sub);
-		expect(resolveExistingDirectory(sub, "/anywhere")).toBe(path.resolve(sub));
-	});
-	it("returns null for a non-existent path", () => {
-		expect(resolveExistingDirectory(path.join(tmp, "nope"), "/anywhere")).toBeNull();
-	});
-	it("returns null for a file (not a directory)", () => {
-		const file = path.join(tmp, "file.txt");
-		fs.writeFileSync(file, "x");
-		expect(resolveExistingDirectory(file, "/anywhere")).toBeNull();
-	});
-});
-
-describe("MoveOverlay", () => {
-	let tmp: string;
-	let cwd: string;
-	let uiTheme: Theme;
-
-	beforeAll(async () => {
-		await Settings.init({ inMemory: true });
-		const loaded = await getThemeByName("dark");
-		if (!loaded) throw new Error("theme unavailable");
-		uiTheme = loaded;
-		setThemeInstance(uiTheme);
-	});
-
-	beforeEach(async () => {
-		tmp = await fsp.mkdtemp(path.join(os.tmpdir(), "omp-move-overlay-"));
-		cwd = tmp;
-		fs.mkdirSync(path.join(tmp, "alpha"));
-		fs.mkdirSync(path.join(tmp, "beta"));
-		fs.mkdirSync(path.join(tmp, ".hidden"));
-		fs.writeFileSync(path.join(tmp, "file.txt"), "x");
-	});
-	afterEach(async () => {
-		await fsp.rm(tmp, { recursive: true, force: true });
-	});
-
-	it("renders a box with a title and input prompt", () => {
-		const overlay = new MoveOverlay(cwd, () => {});
-		const text = strip(overlay.render(80));
-		expect(text).toContain("Move to directory");
-		expect(text).toContain("Path:");
-	});
-
-	it("renders every frame row at the assigned overlay width", () => {
-		const overlay = new MoveOverlay(cwd, () => {});
-		const lines = overlay.render(72);
-		const plainLines = lines.map(stripAnsi);
-
-		expect(lines.map(line => visibleWidth(line))).toEqual(Array(lines.length).fill(72));
-		expect(plainLines[0]!.endsWith(uiTheme.boxRound.topRight)).toBe(true);
-		expect(plainLines.at(-1)!.endsWith(uiTheme.boxRound.bottomRight)).toBe(true);
-		for (const line of plainLines.slice(1, -1)) {
-			expect(line.endsWith(uiTheme.boxRound.vertical)).toBe(true);
-		}
-	});
-
-	it("lists child directories (excluding hidden and files) on empty input", () => {
-		const overlay = new MoveOverlay(cwd, () => {});
-		const text = strip(overlay.render(80));
-		expect(text).toContain("alpha/");
-		expect(text).toContain("beta/");
-		expect(text).not.toContain(".hidden/");
-		expect(text).not.toContain("file.txt");
-	});
-
-	it("filters results as the user types", () => {
-		const overlay = new MoveOverlay(cwd, () => {});
-		overlay.handleInput("a");
-		overlay.handleInput("l");
-		const text = strip(overlay.render(80));
-		expect(text).toContain("alpha/");
-		expect(text).not.toContain("beta/");
-	});
-
-	it("shows dot directories after a dot prefix is typed", () => {
-		const overlay = new MoveOverlay(cwd, () => {});
-		overlay.handleInput(".");
-		const text = strip(overlay.render(80));
-		expect(text).toContain(".hidden/");
-	});
-
-	it("accepts bracketed paste and multi-byte input while filtering controls", () => {
-		let result: MoveOverlayResult | undefined;
-		const overlay = new MoveOverlay(cwd, r => {
-			result = r;
-		});
-		overlay.handleInput("\x1b[200~new\nø\x1b[201~");
-		overlay.handleInput("\r");
-		expect(result).toBeDefined();
-		expect(result!.directory).toBe("newø");
-	});
-
-	it("calls done with undefined on Escape", () => {
-		let result: MoveOverlayResult | undefined = "sentinel" as unknown as MoveOverlayResult;
-		const overlay = new MoveOverlay(cwd, r => {
-			result = r;
-		});
-		overlay.handleInput("\x1b");
-		expect(result).toBeUndefined();
-	});
-
-	it("calls done with the highlighted directory on Enter", () => {
-		let result: MoveOverlayResult | undefined;
-		const overlay = new MoveOverlay(cwd, r => {
-			result = r;
-		});
-		// First result should be "alpha/" (sorted alphabetically).
-		overlay.handleInput("\r");
-		expect(result).toBeDefined();
-		expect(result!.directory).toBe(path.join(cwd, "alpha"));
-	});
-
-	it("calls done with the typed path on Enter when no results match", () => {
-		let result: MoveOverlayResult | undefined;
-		const overlay = new MoveOverlay(cwd, r => {
-			result = r;
-		});
-		// Type a path that won't match any directory in cwd.
-		overlay.handleInput("z");
-		overlay.handleInput("z");
-		overlay.handleInput("\r");
-		expect(result).toBeDefined();
-		expect(result!.directory).toBe("zz");
-	});
-
-	it("Tab accepts the highlighted suggestion into the input", () => {
-		let result: MoveOverlayResult | undefined;
-		const overlay = new MoveOverlay(cwd, r => {
-			result = r;
-		});
-		overlay.handleInput("\t");
-		// After tab, the input should be the full path of the first result.
-		// Press Enter to confirm — the result should be the alpha directory.
-		overlay.handleInput("\r");
-		expect(result).toBeDefined();
-		expect(result!.directory).toBe(path.join(cwd, "alpha"));
-	});
-
-	it("does not stat every directory entry per keystroke", async () => {
-		// Regression: `readDirCached` used to cache names and re-`statSync` every
-		// entry per keystroke. Populate with mostly files so the old code path
-		// would have stat'd all of them; the fix classifies via `Dirent` and only
-		// falls back to `statSync` on symlink entries.
-		const bulk = await fsp.mkdtemp(path.join(os.tmpdir(), "omp-move-overlay-bulk-"));
-		try {
-			for (let i = 0; i < 60; i++) {
-				fs.writeFileSync(path.join(bulk, `f_${String(i).padStart(3, "0")}.txt`), "x");
-			}
-			for (let i = 0; i < 10; i++) fs.mkdirSync(path.join(bulk, `sub_${i}`));
-
-			const statSpy = spyOn(fs, "statSync");
-			try {
-				const overlay = new MoveOverlay(bulk, () => {});
-				statSpy.mockClear();
-				overlay.handleInput("s");
-				overlay.handleInput("u");
-				overlay.handleInput("b");
-				// Each keystroke may `statSync` at most once — the
-				// `resolveExistingDirectory` probe on the typed prefix. Entries
-				// are classified via `Dirent`, not one stat apiece.
-				expect(statSpy.mock.calls.length).toBeLessThanOrEqual(3);
-			} finally {
-				statSpy.mockRestore();
-			}
-		} finally {
-			await fsp.rm(bulk, { recursive: true, force: true });
-		}
-	});
-
-	it("classifies unknown-type Dirents via statSync fallback", async () => {
-		// Regression: filesystems that report UV_DIRENT_UNKNOWN return Dirents
-		// whose isDirectory()/isFile()/isSymbolicLink() all report false. Those
-		// entries must fall back to statSync so /move still lists real
-		// directories on NFS/FUSE/older SMB.
-		const unknownFs = await fsp.mkdtemp(path.join(os.tmpdir(), "omp-move-overlay-unknown-"));
-		try {
-			const realDir = path.join(unknownFs, "real-dir");
-			const realFile = path.join(unknownFs, "real-file.txt");
-			fs.mkdirSync(realDir);
-			fs.writeFileSync(realFile, "x");
-
-			const fakeDirent = (name: string): fs.Dirent =>
-				({
-					name,
-					isDirectory: () => false,
-					isFile: () => false,
-					isSymbolicLink: () => false,
-					isBlockDevice: () => false,
-					isCharacterDevice: () => false,
-					isFIFO: () => false,
-					isSocket: () => false,
-				}) as fs.Dirent;
-			const readdirSpy = spyOn(fs, "readdirSync").mockReturnValue([
-				fakeDirent("real-dir"),
-				fakeDirent("real-file.txt"),
-			] as never);
-			try {
-				const overlay = new MoveOverlay(unknownFs, () => {});
-				const text = strip(overlay.render(80));
-				expect(text).toContain("real-dir/");
-				expect(text).not.toContain("real-file.txt");
-			} finally {
-				readdirSpy.mockRestore();
-			}
-		} finally {
-			await fsp.rm(unknownFs, { recursive: true, force: true });
-		}
-	});
-});

package/src/modes/components/__tests__/pause-screen.test.ts

@@ -1,143 +0,0 @@
-import { afterEach, beforeAll, describe, expect, it } from "bun:test";
-import { agentPauseGate } from "@oh-my-pi/pi-agent-core";
-import type { Component } from "@oh-my-pi/pi-tui";
-import { Settings } from "../../../config/settings";
-import { getThemeByName, setThemeInstance } from "../../theme/theme";
-import { PauseScreenComponent, type PauseScreenHost, renderPauseScreen, runPauseScreen } from "../pause-screen";
-
-// Strip SGR colors so assertions see visible text only.
-const stripAnsi = (text: string): string => text.replace(/\x1b\[[0-9;]*m/g, "");
-
-interface FakeHost {
-	host: PauseScreenHost;
-	shown: Component[];
-	statuses: string[];
-	hiddenCount(): number;
-}
-
-function makeHost(rows = 24): FakeHost {
-	const shown: Component[] = [];
-	const statuses: string[] = [];
-	let hidden = 0;
-	const host: PauseScreenHost = {
-		ui: {
-			showOverlay(component) {
-				shown.push(component);
-				return {
-					hide: () => {
-						hidden++;
-					},
-					setHidden() {},
-					isHidden: () => false,
-				};
-			},
-			setFocus() {},
-			requestRender() {},
-			terminal: { rows },
-		},
-		showStatus(message) {
-			statuses.push(message);
-		},
-	};
-	return { host, shown, statuses, hiddenCount: () => hidden };
-}
-
-describe("pause screen", () => {
-	beforeAll(async () => {
-		await Settings.init({ inMemory: true });
-		const loaded = await getThemeByName("dark");
-		if (!loaded) throw new Error("theme unavailable");
-		setThemeInstance(loaded);
-	});
-
-	afterEach(() => {
-		// The gate is process-global: never leak an engaged pause into other files.
-		agentPauseGate.resume();
-	});
-
-	describe("renderPauseScreen", () => {
-		it("paints exactly the requested rows with title, explainer, clock, and hint", () => {
-			const lines = renderPauseScreen(80, 24, 65_000);
-			expect(lines.length).toBe(24);
-			const text = lines.map(stripAnsi).join("\n");
-			expect(text).toContain("P A U S E D");
-			expect(text).toContain("Main agent, subagents, and advisor");
-			expect(text).toContain("paused for 1:05");
-			expect(text).toContain("esc · enter · space — resume");
-			expect(text).toContain("█".repeat(5));
-		});
-
-		it("drops to the compact card on small terminals", () => {
-			const lines = renderPauseScreen(40, 10, 3_000);
-			expect(lines.length).toBe(10);
-			const text = lines.map(stripAnsi).join("\n");
-			expect(text).toContain("▌▌ P A U S E D");
-			expect(text).toContain("paused for 0:03");
-			expect(text).toContain("esc to resume");
-			expect(text).not.toContain("█".repeat(5)); // no room for the big glyph
-		});
-
-		it("rolls the clock into hours past 60 minutes", () => {
-			const text = renderPauseScreen(80, 24, 3_725_000).map(stripAnsi).join("\n");
-			expect(text).toContain("paused for 1:02:05");
-		});
-
-		it("displays the session name when provided in full mode", () => {
-			const lines = renderPauseScreen(80, 24, 65_000, "My Awesome Session");
-			const text = lines.map(stripAnsi).join("\n");
-			expect(text).toContain("My Awesome Session");
-			expect(text).toContain("P A U S E D");
-		});
-
-		it("displays the session name when provided in compact mode", () => {
-			const lines = renderPauseScreen(40, 10, 3_000, "Compact Session Title");
-			const text = lines.map(stripAnsi).join("\n");
-			expect(text).toContain("Compact Session Title");
-			expect(text).toContain("▌▌ P A U S E D");
-		});
-	});
-
-	describe("runPauseScreen", () => {
-		it("engages the gate for the screen's lifetime and releases it on escape", async () => {
-			const { host, shown, statuses, hiddenCount } = makeHost();
-			expect(agentPauseGate.paused).toBe(false);
-
-			const run = runPauseScreen(host);
-			await Bun.sleep(1);
-			expect(agentPauseGate.paused).toBe(true);
-			expect(shown.length).toBe(1);
-
-			const component = shown[0];
-			expect(component).toBeInstanceOf(PauseScreenComponent);
-			if (component instanceof PauseScreenComponent) {
-				component.handleInput("\x1b"); // escape → resume
-			}
-			await run;
-
-			expect(agentPauseGate.paused).toBe(false);
-			expect(hiddenCount()).toBe(1);
-			expect(statuses.some(message => message.includes("Resumed after"))).toBe(true);
-		});
-
-		it("treats ctrl+c as resume, never as abort-and-stay-paused", async () => {
-			const { host, shown } = makeHost();
-			const run = runPauseScreen(host);
-			await Bun.sleep(1);
-
-			const component = shown[0];
-			if (component instanceof PauseScreenComponent) {
-				component.handleInput("\x03"); // ctrl+c
-			}
-			await run;
-			expect(agentPauseGate.paused).toBe(false);
-		});
-
-		it("is a no-op when the gate is already engaged elsewhere", async () => {
-			agentPauseGate.pause();
-			const { host, shown } = makeHost();
-			await runPauseScreen(host); // must resolve immediately, not park
-			expect(shown.length).toBe(0);
-			expect(agentPauseGate.paused).toBe(true); // foreign pause not stolen
-		});
-	});
-});

package/src/modes/components/__tests__/skill-message.test.ts

@@ -1,94 +0,0 @@
-import { beforeAll, describe, expect, it } from "bun:test";
-import * as os from "node:os";
-import * as path from "node:path";
-import { Settings } from "../../../config/settings";
-import type { CustomMessage, SkillPromptDetails } from "../../../session/messages";
-import { getThemeByName, setThemeInstance, type Theme } from "../../theme/theme";
-import { SkillMessageComponent } from "../skill-message";
-
-// Drop SGR colors and OSC 8 hyperlink wrappers so assertions see the visible text only.
-const strip = (lines: readonly string[]): string =>
-	lines
-		.join("\n")
-		.replace(/\x1b\]8;[^\x1b\x07]*(?:\x07|\x1b\\)/g, "")
-		.replace(/\x1b\[[0-9;]*m/g, "");
-
-function makeMessage(
-	details: SkillPromptDetails,
-	content = "Use the atomic-commit workflow.",
-): CustomMessage<SkillPromptDetails> {
-	return { role: "custom", customType: "skill-prompt", content, display: true, details, timestamp: Date.now() };
-}
-
-describe("SkillMessageComponent", () => {
-	let uiTheme: Theme;
-
-	beforeAll(async () => {
-		await Settings.init({ inMemory: true });
-		const loaded = await getThemeByName("dark");
-		if (!loaded) throw new Error("theme unavailable");
-		uiTheme = loaded;
-		setThemeInstance(uiTheme);
-	});
-
-	const skillPath = path.join(os.homedir(), ".agent/skills/atomic-commit/SKILL.md");
-
-	it("renders a compact, outlined card instead of the archaic key:value dump", () => {
-		const component = new SkillMessageComponent(
-			makeMessage({ name: "atomic-commit", path: skillPath, lineCount: 88 }),
-		);
-		const text = strip(component.render(80));
-
-		// New look: an icon-tagged "skill" header with the name and a single meta line.
-		expect(text).toContain("skill");
-		expect(text).toContain("atomic-commit");
-		expect(text).toContain("skill atomic-commit");
-		expect(text).not.toContain("skill  atomic-commit");
-		expect(text).toContain("88 lines");
-
-		// The card is drawn with an outline.
-		expect(text).toContain(uiTheme.boxRound.topLeft);
-		expect(text).toContain(uiTheme.boxRound.bottomRight);
-
-		// Path is home-shortened and never leaks the absolute home dir.
-		expect(text).toContain("~/.agent/skills/atomic-commit/SKILL.md");
-		expect(text).not.toContain(os.homedir());
-
-		// The old archaic framing is gone.
-		expect(text).not.toContain("[skill]");
-		expect(text).not.toContain("Skill:");
-		expect(text).not.toContain("Path:");
-		expect(text).not.toContain("Prompt:");
-	});
-
-	it("flattens multi-line args onto the single-line header", () => {
-		const component = new SkillMessageComponent(
-			makeMessage({ name: "atomic-commit", path: skillPath, lineCount: 88, args: "stage all\nthen split" }),
-		);
-		const text = strip(component.render(80));
-		// Whitespace (including the newline) collapsed to single spaces so the header can't break.
-		expect(text).toContain("stage all then split");
-		expect(text).not.toContain("stage all\nthen split");
-	});
-
-	it("uses a singular unit for a one-line prompt", () => {
-		const component = new SkillMessageComponent(makeMessage({ name: "tiny", path: skillPath, lineCount: 1 }));
-		const text = strip(component.render(80));
-		expect(text).toContain("1 line");
-		expect(text).not.toContain("1 lines");
-	});
-
-	it("reveals the prompt body under a calm subheader only when expanded", () => {
-		const details: SkillPromptDetails = { name: "atomic-commit", path: skillPath, lineCount: 88 };
-		const body = "Step one: stage hunks.";
-
-		const collapsed = new SkillMessageComponent(makeMessage(details, body));
-		expect(strip(collapsed.render(80))).not.toContain(body);
-
-		const expanded = new SkillMessageComponent(makeMessage(details, body));
-		expanded.setExpanded(true);
-		const text = strip(expanded.render(80));
-		expect(text).toContain("prompt");
-		expect(text).toContain(body);
-	});
-});

package/src/modes/components/custom-editor-plugin-ctor.test.ts

@@ -1,36 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { ProcessTerminal, TUI } from "@oh-my-pi/pi-tui";
-import { getEditorTheme, initTheme } from "../theme/theme";
-import { CustomEditor } from "./custom-editor";
-
-/**
- * Regression for issue #4766: plugins written against upstream pi subclass
- * `CustomEditor`/`Editor` and forward `super(tui, theme, keybindings)`. omp's
- * `setEditorComponent` factory contract advertises exactly that arg order, so
- * the base constructor must resolve the real theme by shape (not position) or
- * every render throws `undefined is not an object (evaluating
- * 'this.#theme.symbols.boxRound')`.
- */
-describe("CustomEditor upstream-pi constructor compatibility (#4766)", () => {
-	it("renders when constructed as (tui, theme, keybindings)", async () => {
-		await initTheme();
-		const tui = new TUI(new ProcessTerminal());
-		const editor = new CustomEditor(tui, getEditorTheme(), {});
-		editor.setText("run this workflow");
-		expect(() => editor.render(80)).not.toThrow();
-		// The rounded border glyphs from the resolved theme must reach the frame.
-		const frame = editor.render(80).join("\n");
-		expect(frame).toContain(getEditorTheme().symbols.boxRound.horizontal);
-		// The leading TUI is captured so plugin overrides calling
-		// `this.tui.requestRender()` keep working.
-		expect(editor.tui).toBe(tui);
-	});
-
-	it("still accepts omp's own (theme) constructor", async () => {
-		await initTheme();
-		const editor = new CustomEditor(getEditorTheme());
-		editor.setText("hello");
-		expect(() => editor.render(80)).not.toThrow();
-		expect(editor.tui).toBeUndefined();
-	});
-});