@odoo/o-spreadsheet 17.1.4 → 17.1.7

package/dist/o-spreadsheet.iife.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.4
- * @date 2024-02-09T13:09:13.430Z
- * @hash 16d3ece
+ * @version 17.1.7
+ * @date 2024-03-12T07:56:10.783Z
+ * @hash 3a9f334
  */
 
 (function (exports, owl) {
@@ -452,8 +452,8 @@
    * If the given item does not exist in the dictionary, it creates one with a new id.
    */
   function getItemId(item, itemsDic) {
-      for (let [key, value] of Object.entries(itemsDic)) {
-          if (deepEquals(value, item)) {
+      for (const key in itemsDic) {
+          if (deepEquals(itemsDic[key], item)) {
               return parseInt(key, 10);
           }
       }
@@ -552,11 +552,13 @@
       if (typeof o1 !== "object")
           return o1 === o2;
       // Objects can have different keys if the values are undefined
-      const keys = new Set();
-      Object.keys(o1).forEach((key) => keys.add(key));
-      Object.keys(o2).forEach((key) => keys.add(key));
-      for (let key of keys) {
-          if (typeof o1[key] !== typeof o1[key])
+      for (const key in o2) {
+          if (!(key in o1) && o2[key] !== undefined) {
+              return false;
+          }
+      }
+      for (const key in o1) {
+          if (typeof o1[key] !== typeof o2[key])
               return false;
           if (typeof o1[key] === "object") {
               if (!deepEquals(o1[key], o2[key]))
@@ -626,18 +628,18 @@
       return true;
   }
   class JetSet extends Set {
-      add(...iterable) {
+      addMany(iterable) {
           for (const element of iterable) {
               super.add(element);
           }
           return this;
       }
-      delete(...iterable) {
-          let deleted = false;
+      deleteMany(iterable) {
+          let wasDeleted = false;
           for (const element of iterable) {
-              deleted ||= super.delete(element);
+              wasDeleted ||= super.delete(element);
           }
-          return deleted;
+          return wasDeleted;
       }
   }
   /**
@@ -1935,7 +1937,7 @@
        * Static helper which returns a successful DispatchResult
        */
       static get Success() {
-          return new DispatchResult();
+          return SUCCESS;
       }
       get isSuccessful() {
           return this.reasons.length === 0;
@@ -1948,6 +1950,7 @@
           return this.reasons.includes(reason);
       }
   }
+  const SUCCESS = new DispatchResult();
   exports.CommandResult = void 0;
   (function (CommandResult) {
       CommandResult["Success"] = "Success";
@@ -6096,8 +6099,10 @@
           if (x === cell) {
               found = true;
           }
-          const cellValue = evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
-          if (filter(cellValue)) {
+          const cellValue = x?.isFormula
+              ? undefined
+              : evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
+          if (cellValue && filter(cellValue)) {
               group.push(cellValue);
           }
           else {
@@ -6321,11 +6326,14 @@
    * Transform CSS properties into a CSS string.
    */
   function cssPropertiesToCss(attributes) {
-      const str = Object.entries(attributes)
-          .filter(([attName, attValue]) => attValue !== undefined)
-          .map(([attName, attValue]) => `${attName}:${attValue};`)
-          .join(" ");
-      return str;
+      let styleStr = "";
+      for (const attName in attributes) {
+          if (!attributes[attName]) {
+              continue;
+          }
+          styleStr += `${attName}:${attributes[attName]}; `;
+      }
+      return styleStr;
   }
   function getElementMargins(el) {
       const style = window.getComputedStyle(el);
@@ -7654,6 +7662,9 @@
       if (locale.formulaArgSeparator === locale.decimalSeparator) {
           return false;
       }
+      if (locale.thousandsSeparator === locale.decimalSeparator) {
+          return false;
+      }
       try {
           formatValue(1, { locale, format: "#,##0.00" });
           formatValue(1, { locale, format: locale.dateFormat });
@@ -7744,7 +7755,7 @@
       if (locale.decimalSeparator === "." || !isNumber(content, locale)) {
           return content;
       }
-      return content.replace(locale.decimalSeparator, ".");
+      return content.replace(locale.thousandsSeparator, "").replace(locale.decimalSeparator, ".");
   }
   /**
    * Change a content string from the given locale to its canonical form (en_US locale). Also convert date string.
@@ -10839,6 +10850,12 @@
       let { col, row } = env.model.getters.getActivePosition();
       env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
   };
+  const INSERT_LINK_NAME = (env) => {
+      const sheetId = env.model.getters.getActiveSheetId();
+      const { col, row } = env.model.getters.getActivePosition();
+      const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+      return cell && cell.link ? _t("Edit link") : _t("Insert link");
+  };
   //------------------------------------------------------------------------------
   // Filters action
   //------------------------------------------------------------------------------
@@ -13040,6 +13057,18 @@
       },
       isExported: true,
   };
+  // -----------------------------------------------------------------------------
+  // INT
+  // -----------------------------------------------------------------------------
+  const INT = {
+      description: _t("Rounds a number down to the nearest integer that is less than or equal to it."),
+      args: [arg("value (number)", _t("The number to round down to the nearest integer."))],
+      returns: ["NUMBER"],
+      compute: function (value) {
+          return Math.floor(toNumber(value, this.locale));
+      },
+      isExported: true,
+  };
 
   var math = /*#__PURE__*/Object.freeze({
     __proto__: null,
@@ -13073,6 +13102,7 @@
     FLOOR: FLOOR,
     FLOOR_MATH: FLOOR_MATH,
     FLOOR_PRECISE: FLOOR_PRECISE,
+    INT: INT,
     ISEVEN: ISEVEN,
     ISODD: ISODD,
     ISO_CEILING: ISO_CEILING,
@@ -18599,10 +18629,11 @@
   const DEFAULT_MATCH_MODE = 0;
   const DEFAULT_SEARCH_MODE = 1;
   const DEFAULT_ABSOLUTE_RELATIVE_MODE = 1;
-  function assertAvailable(variable, searchKey) {
-      if (variable === undefined) {
-          throw new NotAvailableError(_t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)));
-      }
+  function valueNotAvailable(searchKey) {
+      return {
+          value: CellErrorType.NotAvailable,
+          message: _t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)),
+      };
   }
   // -----------------------------------------------------------------------------
   // ADDRESS
@@ -18699,7 +18730,9 @@
               ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range.length, getValueFromRange)
               : linearSearch(range, searchKey, "strict", range.length, getValueFromRange);
           const col = range[colIndex];
-          assertAvailable(col, searchKey?.value);
+          if (col === undefined) {
+              return valueNotAvailable(searchKey);
+          }
           return col[_index - 1];
       },
       isExported: true,
@@ -18756,11 +18789,11 @@
               : (range, index) => range[index][0].value;
           const rangeLength = verticalSearch ? nbRow : nbCol;
           const index = dichotomicSearch(searchArray, searchKey, "nextSmaller", "asc", rangeLength, getElement);
-          if (index === -1)
-              assertAvailable(undefined, searchKey?.value);
-          verticalSearch
-              ? assertAvailable(searchArray[0][index], searchKey?.value)
-              : assertAvailable(searchArray[index][nbRow - 1], searchKey?.value);
+          if (index === -1 ||
+              (verticalSearch && searchArray[0][index] === undefined) ||
+              (!verticalSearch && searchArray[index][nbRow - 1] === undefined)) {
+              return valueNotAvailable(searchKey);
+          }
           if (resultRange === undefined) {
               return verticalSearch ? searchArray[nbCol - 1][index] : searchArray[index][nbRow - 1];
           }
@@ -18810,7 +18843,10 @@
                   index = dichotomicSearch(range, searchKey, "nextGreater", "desc", rangeLen, getElement);
                   break;
           }
-          assertAvailable(nbCol === 1 ? range[0][index] : range[index], searchKey);
+          if ((nbCol === 1 && range[0][index] === undefined) ||
+              (nbCol !== 1 && range[index] === undefined)) {
+              return valueNotAvailable(searchKey);
+          }
           return index + 1;
       },
       isExported: true,
@@ -18869,7 +18905,9 @@
               ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range[0].length, getValueFromRange)
               : linearSearch(range, searchKey, "strict", range[0].length, getValueFromRange);
           const value = range[_index - 1][rowIndex];
-          assertAvailable(value, searchKey);
+          if (value === undefined) {
+              return valueNotAvailable(searchKey);
+          }
           return value;
       },
       isExported: true,
@@ -18919,7 +18957,9 @@
                   ? returnRange.map((col) => [col[index]])
                   : [returnRange[index]];
           }
-          assertAvailable(defaultValue, searchKey);
+          if (defaultValue === undefined) {
+              return valueNotAvailable(searchKey);
+          }
           return [[defaultValue]];
       },
       isExported: true,
@@ -19691,8 +19731,7 @@
   function addErrorHandling(compute, functionName) {
       return function (...args) {
           try {
-              const computeFormula = compute.bind(this);
-              return computeFormula(...args);
+              return compute.apply(this, args);
           }
           catch (e) {
               return handleError(e, functionName);
@@ -19726,8 +19765,7 @@
   }
   function addResultHandling(compute) {
       return function (...args) {
-          const computeResult = compute.bind(this);
-          const result = computeResult(...args);
+          const result = compute.apply(this, args);
           if (!isMatrix(result)) {
               if (typeof result === "object" && result !== null && "value" in result) {
                   return result;
@@ -20083,7 +20121,7 @@
   })
       .add("insert_link", {
       ...insertLink,
-      name: _t("Insert link"),
+      name: INSERT_LINK_NAME,
       sequence: 150,
       separator: true,
   });
@@ -21694,7 +21732,7 @@
               ? existingSelectionRanges
               : this.props.ranges().map((xc, id) => ({
                   xc,
-                  id,
+                  id: id + 1,
                   isFocused: false,
               }));
           return ranges.map((range) => ({
@@ -26526,6 +26564,17 @@
           onValueSelected: Function,
           onValueHovered: Function,
       };
+      autoCompleteListRef = owl.useRef("autoCompleteList");
+      setup() {
+          owl.useEffect(() => {
+              const selectedIndex = this.props.selectedIndex;
+              if (selectedIndex === undefined) {
+                  return;
+              }
+              const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+              selectedElement?.scrollIntoView?.({ block: "nearest" });
+          }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+      }
   }
 
   class ContentEditableHelper {
@@ -26970,6 +27019,7 @@
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -27027,7 +27077,10 @@
           if (this.props.delimitation && this.props.rect) {
               const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
               const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+              assistantStyle["max-height"] = `${remainingHeight}px`;
               if (cellY > remainingHeight) {
+                  const availableSpaceAbove = cellY;
+                  assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                   // render top
                   // We compensate 2 px of margin on the assistant style + 1px for design reasons
                   assistantStyle.top = `-3px`;
@@ -27719,7 +27772,11 @@
           }
       }
       updateCellReferenceVisibility() {
-          if (this.isCellReferenceVisible || this.env.model.getters.getEditionMode() === "inactive") {
+          if (this.env.model.getters.getEditionMode() === "inactive") {
+              this.isCellReferenceVisible = false;
+              return;
+          }
+          if (this.isCellReferenceVisible) {
               return;
           }
           const sheetId = this.env.model.getters.getActiveSheetId();
@@ -27748,19 +27805,21 @@
           slots: Object,
       };
       get iconStyle() {
-          const x = this.getIconHorizontalPosition();
-          const y = this.getIconVerticalPosition();
+          const cellPosition = this.props.cellPosition;
+          const merge = this.env.model.getters.getMerge(cellPosition);
+          const zone = merge || positionToZone(cellPosition);
+          const rect = this.env.model.getters.getVisibleRectWithoutHeaders(zone);
+          const x = this.getIconHorizontalPosition(rect, cellPosition);
+          const y = this.getIconVerticalPosition(rect, cellPosition);
           return cssPropertiesToCss({
               top: `${y + (this.props.offset?.y || 0)}px`,
               left: `${x + (this.props.offset?.x || 0)}px`,
           });
       }
-      getIconVerticalPosition() {
-          const { sheetId, row } = this.props.cellPosition;
-          const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-          const start = this.env.model.getters.getRowDimensionsInViewport(sheetId, row).start;
-          const end = this.env.model.getters.getRowDimensionsInViewport(sheetId, merge ? merge.bottom : row).end;
-          const cell = this.env.model.getters.getCell(this.props.cellPosition);
+      getIconVerticalPosition(rect, cellPosition) {
+          const start = rect.y;
+          const end = rect.y + rect.height;
+          const cell = this.env.model.getters.getCell(cellPosition);
           const align = this.props.verticalAlign || cell?.style?.verticalAlign || DEFAULT_VERTICAL_ALIGN;
           switch (align) {
               case "bottom":
@@ -27772,13 +27831,11 @@
                   return end - GRID_ICON_EDGE_LENGTH - centeringOffset;
           }
       }
-      getIconHorizontalPosition() {
-          const { sheetId, col } = this.props.cellPosition;
-          const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-          const start = this.env.model.getters.getColDimensionsInViewport(sheetId, col).start;
-          const end = this.env.model.getters.getColDimensionsInViewport(sheetId, merge ? merge.right : col).end;
-          const cell = this.env.model.getters.getCell(this.props.cellPosition);
-          const evaluatedCell = this.env.model.getters.getEvaluatedCell(this.props.cellPosition);
+      getIconHorizontalPosition(rect, cellPosition) {
+          const start = rect.x;
+          const end = rect.x + rect.width;
+          const cell = this.env.model.getters.getCell(cellPosition);
+          const evaluatedCell = this.env.model.getters.getEvaluatedCell(cellPosition);
           const align = this.props.horizontalAlign || cell?.style?.align || evaluatedCell.defaultAlign;
           switch (align) {
               case "right":
@@ -27862,6 +27919,8 @@
     height: ${CHECKBOX_WIDTH}px;
     accent-color: #808080;
     margin: ${MARGIN}px;
+    /** required to prevent the checkbox position to be sensible to the font-size (affects Firefox) */
+    position: absolute;
   }
 `;
   class DataValidationCheckbox extends owl.Component {
@@ -27880,7 +27939,7 @@
       }
       get isDisabled() {
           const cell = this.env.model.getters.getCell(this.props.cellPosition);
-          return !!cell?.isFormula;
+          return this.env.model.getters.isReadonly() || !!cell?.isFormula;
       }
   }
 
@@ -27920,12 +27979,17 @@
       static props = {};
       static components = { GridCellIcon, DataValidationCheckbox, DataValidationListIcon };
       get checkBoxCellPositions() {
-          return this.env.model.getters.getDataValidationCheckBoxCellPositions();
+          return this.env.model.getters
+              .getVisibleCellPositions()
+              .filter(this.env.model.getters.isCellValidCheckbox);
       }
       get listIconsCellPositions() {
-          return this.env.model.getters.isReadonly()
-              ? []
-              : this.env.model.getters.getDataValidationListCellsPositions();
+          if (this.env.model.getters.isReadonly()) {
+              return [];
+          }
+          return this.env.model.getters
+              .getVisibleCellPositions()
+              .filter(this.env.model.getters.cellHasListDataValidationIcon);
       }
   }
 
@@ -34287,29 +34351,12 @@
           from: 12,
           to: 12.5,
           applyMigration(data) {
-              for (let sheet of data.sheets || []) {
-                  let knownDataFilterZones = [];
-                  for (let filterTable of sheet.filterTables || []) {
-                      const zone = toZone(filterTable.range);
-                      // See commit message for the details
-                      const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
-                      if (intersectZoneIndex !== -1) {
-                          knownDataFilterZones[intersectZoneIndex] = zone;
-                      }
-                      else {
-                          knownDataFilterZones.push(zone);
-                      }
-                  }
-                  sheet.filterTables = knownDataFilterZones.map((zone) => ({
-                      range: zoneToXc(zone),
-                  }));
-              }
-              return data;
+              return fixOverlappingFilters(data);
           },
       },
       {
           description: "Change Border description structure",
-          from: 12,
+          from: 12.5,
           to: 13,
           applyMigration(data) {
               for (const borderId in data.borders) {
@@ -34340,6 +34387,14 @@
               return data;
           },
       },
+      {
+          description: "Fix datafilter duplication (post saas-16.4)",
+          from: 14,
+          to: 14.5,
+          applyMigration(data) {
+              return fixOverlappingFilters(data);
+          },
+      },
   ];
   /**
    * This function is used to repair faulty data independently of the migration.
@@ -34497,6 +34552,26 @@
       }
       return messages;
   }
+  function fixOverlappingFilters(data) {
+      for (let sheet of data.sheets || []) {
+          let knownDataFilterZones = [];
+          for (let filterTable of sheet.filterTables || []) {
+              const zone = toZone(filterTable.range);
+              // See commit message of https://github.com/odoo/o-spreadsheet/pull/3632 of more details
+              const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+              if (intersectZoneIndex !== -1) {
+                  knownDataFilterZones[intersectZoneIndex] = zone;
+              }
+              else {
+                  knownDataFilterZones.push(zone);
+              }
+          }
+          sheet.filterTables = knownDataFilterZones.map((zone) => ({
+              range: zoneToXc(zone),
+          }));
+      }
+      return data;
+  }
   // -----------------------------------------------------------------------------
   // Helpers
   // -----------------------------------------------------------------------------
@@ -35146,22 +35221,7 @@
           }
       }
       export(data) {
-          // Borders
-          let borderId = 0;
           const borders = {};
-          /**
-           * Get the id of the given border. If the border does not exist, it creates
-           * one.
-           */
-          function getBorderId(border) {
-              for (let [key, value] of Object.entries(borders)) {
-                  if (deepEquals(value, border)) {
-                      return parseInt(key, 10);
-                  }
-              }
-              borders[++borderId] = border;
-              return borderId;
-          }
           for (let sheet of data.sheets) {
               for (let col = 0; col < sheet.colNumber; col++) {
                   for (let row = 0; row < sheet.rowNumber; row++) {
@@ -35169,7 +35229,7 @@
                       if (border) {
                           const xc = toXC(col, row);
                           const cell = sheet.cells[xc];
-                          const borderId = getBorderId(border);
+                          const borderId = getItemId(border, borders);
                           if (cell) {
                               cell.border = borderId;
                           }
@@ -35958,9 +36018,9 @@
       allowDispatch(cmd) {
           switch (cmd.type) {
               case "UPDATE_CELL":
-                  return this.checkCellOutOfSheet(cmd);
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
               case "CLEAR_CELL":
-                  return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                  return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
               default:
                   return "Success" /* CommandResult.Success */;
           }
@@ -36110,8 +36170,8 @@
       }
       removeDefaultStyleValues(style) {
           const cleanedStyle = { ...style };
-          for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-              if (cleanedStyle[property] === defaultValue) {
+          for (const property in DEFAULT_STYLE) {
+              if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                   delete cleanedStyle[property];
               }
           }
@@ -36267,10 +36327,7 @@
           else {
               style = before ? before.style : undefined;
           }
-          const locale = this.getters.getLocale();
-          let format = ("format" in after ? after.format : before && before.format) ||
-              detectDateFormat(afterContent, locale) ||
-              detectNumberFormat(afterContent);
+          const format = "format" in after ? after.format : before && before.format;
           /* Read the following IF as:
            * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
            * - the command says the new content is empty and has no border/format/style
@@ -36311,6 +36368,7 @@
       }
       createLiteralCell(id, content, format, style) {
           const locale = this.getters.getLocale();
+          format = format || detectDateFormat(content, locale) || detectNumberFormat(content);
           if (format !== PLAIN_TEXT_FORMAT && !isEvaluationError(content)) {
               content = toString(parseLiteral(content, locale));
           }
@@ -36383,6 +36441,18 @@
           }
           return "Success" /* CommandResult.Success */;
       }
+      checkUselessUpdateCell(cmd) {
+          const cell = this.getters.getCell(cmd);
+          const hasContent = "content" in cmd || "formula" in cmd;
+          const hasStyle = "style" in cmd;
+          const hasFormat = "format" in cmd;
+          if ((!hasContent || cell?.content === cmd.content) &&
+              (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+              (!hasFormat || cell?.format === cmd.format)) {
+              return "NoChanges" /* CommandResult.NoChanges */;
+          }
+          return "Success" /* CommandResult.Success */;
+      }
   }
   class FormulaCellWithDependencies {
       id;
@@ -39023,7 +39093,6 @@
           "getNumberHeaders",
           "getGridLinesVisibility",
           "getNextSheetName",
-          "isEmpty",
           "getSheetSize",
           "getSheetZone",
           "getPaneDivisions",
@@ -39398,14 +39467,6 @@
       // ---------------------------------------------------------------------------
       // Row/Col manipulation
       // ---------------------------------------------------------------------------
-      /**
-       * Check if a zone only contains empty cells
-       */
-      isEmpty(sheetId, zone) {
-          return positions(zone)
-              .map(({ col, row }) => this.getCell({ sheetId, col, row }))
-              .every((cell) => !cell || cell.content === "");
-      }
       getCommandZones(cmd) {
           const zones = [];
           if ("zone" in cmd) {
@@ -41167,7 +41228,15 @@
           if (!this.rTrees[sheetId]) {
               return;
           }
-          this.rTrees[sheetId].remove(item, deepEquals);
+          this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+      }
+      rtreeItemComparer(left, right) {
+          return (left.data == right.data &&
+              left.boundingBox.sheetId === right.boundingBox.sheetId &&
+              left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+              left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+              left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+              left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
       }
   }
   /**
@@ -41245,7 +41314,7 @@
           const queue = Array.from(ranges).reverse();
           while (queue.length > 0) {
               const range = queue.pop();
-              visited.add(...this.encoder.encodeBoundingBox(range));
+              visited.addMany(this.encoder.encodeBoundingBox(range));
               const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
               for (const positionId of impactedPositionIds) {
                   if (!visited.has(positionId)) {
@@ -41253,7 +41322,7 @@
                   }
               }
           }
-          visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+          visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
           return visited;
       }
   }
@@ -41393,9 +41462,9 @@
           const cells = positions.map((p) => this.encoder.encode(p));
           const cellsToCompute = new JetSet(cells);
           const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-          cellsToCompute.add(...this.getCellsDependingOn(cells));
-          cellsToCompute.add(...arrayFormulasPositionIds);
-          cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+          cellsToCompute.addMany(this.getCellsDependingOn(cells));
+          cellsToCompute.addMany(arrayFormulasPositionIds);
+          cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
           this.evaluate(cellsToCompute);
       }
       getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -41409,7 +41478,7 @@
               }
               if (!content) {
                   // The previous content could have blocked some array formulas
-                  impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                  impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
               }
           }
           return impactedPositionIds;
@@ -41461,7 +41530,7 @@
           }
           const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
           const cells = new JetSet(arrayFormulas);
-          cells.add(...this.getCellsDependingOn(arrayFormulas));
+          cells.addMany(this.getCellsDependingOn(arrayFormulas));
           return cells;
       }
       nextPositionsToUpdate = new JetSet();
@@ -41512,7 +41581,7 @@
                   : evaluateLiteral(cell.content, localeFormat);
           }
           catch (e) {
-              return createEvaluatedCell(e.value, localeFormat, e.message);
+              return createEvaluatedCell(e?.value || CellErrorType.GenericError, localeFormat, e?.message || implementationErrorMessage);
           }
           finally {
               this.cellsBeingComputed.delete(cellId);
@@ -41599,7 +41668,7 @@
               this.setEvaluatedCell(positionId, evaluatedCell);
               // check if formula dependencies present in the spread zone
               // if so, they need to be recomputed
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
           };
       }
       invalidateSpreading(positionId) {
@@ -41614,8 +41683,8 @@
                   continue;
               }
               this.evaluatedCells.delete(child);
-              this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-              this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+              this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+              this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
           }
           this.spreadingRelations.removeNode(positionId);
       }
@@ -41846,6 +41915,7 @@
           "getEvaluatedCellsInZone",
           "getSpreadPositionsOf",
           "getArrayFormulaSpreadingOn",
+          "isEmpty",
       ];
       shouldRebuildDependenciesGraph = true;
       evaluator;
@@ -41951,6 +42021,14 @@
       getArrayFormulaSpreadingOn(position) {
           return this.evaluator.getArrayFormulaSpreadingOn(position);
       }
+      /**
+       * Check if a zone only contains empty cells
+       */
+      isEmpty(sheetId, zone) {
+          return positions(zone)
+              .map(({ col, row }) => this.getEvaluatedCell({ sheetId, col, row }))
+              .every((cell) => cell.type === CellValueType.empty);
+      }
       // ---------------------------------------------------------------------------
       // Export
       // ---------------------------------------------------------------------------
@@ -42598,8 +42676,6 @@
   class EvaluationDataValidationPlugin extends UIPlugin {
       static getters = [
           "getDataValidationInvalidCriterionValueMessage",
-          "getDataValidationCheckBoxCellPositions",
-          "getDataValidationListCellsPositions",
           "getInvalidDataValidationMessage",
           "getValidationResultForCellValue",
           "isCellValidCheckbox",
@@ -42663,19 +42739,6 @@
           const error = this.getRuleErrorForCellValue(cellValue, cellPosition, rule);
           return error ? { error, rule, isValid: false } : VALID_RESULT;
       }
-      getDataValidationCheckBoxCellPositions() {
-          const rules = this.getters
-              .getDataValidationRules(this.getters.getActiveSheetId())
-              .filter((rule) => rule.criterion.type === "isBoolean");
-          return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat()).filter((position) => this.isCellValidCheckbox(position));
-      }
-      getDataValidationListCellsPositions() {
-          const rules = this.getters
-              .getDataValidationRules(this.getters.getActiveSheetId())
-              .filter((rule) => (rule.criterion.type === "isValueInList" || rule.criterion.type === "isValueInRange") &&
-              rule.criterion.displayStyle === "arrow");
-          return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat());
-      }
       getValidationResultForCell(cellPosition) {
           const { col, row, sheetId } = cellPosition;
           if (!this.validationResults[sheetId]) {
@@ -45484,7 +45547,7 @@
       }
       finalize() {
           if (this.isSearchDirty) {
-              this.refreshSearch();
+              this.refreshSearch(false);
               this.isSearchDirty = false;
           }
       }
@@ -45528,10 +45591,10 @@
       /**
        * refresh the matches according to the current search options
        */
-      refreshSearch() {
+      refreshSearch(jumpToMatchSheet = true) {
           this.selectedMatchIndex = null;
           this.findMatches();
-          this.selectNextCell(Direction.current);
+          this.selectNextCell(Direction.current, jumpToMatchSheet);
       }
       /**
        * Updates the regex based on the current searchOptions and
@@ -45613,7 +45676,7 @@
        * It is also used to keep coherence between the selected searchMatch
        * and selectedMatchIndex.
        */
-      selectNextCell(indexChange) {
+      selectNextCell(indexChange, jumpToMatchSheet = true) {
           const matches = this.searchMatches;
           if (!matches.length) {
               this.selectedMatchIndex = null;
@@ -45639,11 +45702,13 @@
           this.selectedMatchIndex = nextIndex;
           const selectedMatch = matches[nextIndex];
           // Switch to the sheet where the match is located
-          if (this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
+          if (jumpToMatchSheet && this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
               this.dispatch("ACTIVATE_SHEET", {
                   sheetIdFrom: this.getters.getActiveSheetId(),
                   sheetIdTo: selectedMatch.sheetId,
               });
+              // We do not want to reset the selection at finalize in this case
+              this.isSearchDirty = false;
           }
           // we want grid selection to capture the selection stream
           this.selection.getBackToDefault();
@@ -46945,19 +47010,17 @@
                   break;
               case "FOCUS_RANGE":
               case "CHANGE_RANGE":
-                  if (cmd.id !== this.focusedInputId) {
-                      const input = this.inputs[cmd.id];
-                      const range = input.ranges.find((range) => range.id === cmd.rangeId);
-                      if (this.isRangeValid(range?.xc || "A1")) {
-                          const sheetId = this.getters.getActiveSheetId();
-                          const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
-                          this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
-                              handleEvent: input.handleEvent.bind(input),
-                              release: () => (this.focusedInputId = null),
-                          });
-                      }
-                      this.focusedInputId = cmd.id;
+                  const input = this.inputs[cmd.id];
+                  const range = input.ranges.find((range) => range.id === cmd.rangeId);
+                  if (range) {
+                      const sheetId = this.getters.getActiveSheetId();
+                      const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
+                      this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
+                          handleEvent: input.handleEvent.bind(input),
+                          release: () => (this.focusedInputId = null),
+                      });
                   }
+                  this.focusedInputId = cmd.id;
                   break;
           }
           this.currentInput?.handle(cmd);
@@ -47211,7 +47274,7 @@
           "getCellText",
           "getCellMultiLineText",
           "getContiguousZone",
-          "isCellEmpty",
+          "isEvaluatedCellEmpty",
       ];
       ctx = document.createElement("canvas").getContext("2d");
       // ---------------------------------------------------------------------------
@@ -47339,14 +47402,23 @@
           return zone;
       }
       /**
-       * Check if a cell is empty. If the cell is part of a merge,
-       * check if the merge containing the cell is empty.
+       * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+       * the check applies to the main cell of the merge.
        */
-      isCellEmpty(position) {
+      isEvaluatedCellEmpty(position) {
           const mainPosition = this.getters.getMainCellPosition(position);
           const cell = this.getters.getEvaluatedCell(mainPosition);
           return cell.type === CellValueType.empty;
       }
+      /**
+       * Checks if a cell is empty (i.e. does not have a content or a formula does not spread over it).
+       * If the cell is part of a merge, the check applies to the main cell of the merge.
+       */
+      isCellEmpty(position) {
+          const mainPosition = this.getters.getMainCellPosition(position);
+          return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
+              this.getters.getCell(mainPosition)?.content);
+      }
       getColMaxWidth(sheetId, index) {
           const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
           const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
@@ -50367,6 +50439,8 @@
           "getEdgeScrollRow",
           "getVisibleFigures",
           "getVisibleRect",
+          "getVisibleRectWithoutHeaders",
+          "getVisibleCellPositions",
           "getColRowOffsetInViewport",
           "getMainViewportCoordinates",
           "getActiveSheetScrollInfo",
@@ -50610,6 +50684,26 @@
           const viewports = this.getSubViewports(sheetId);
           return [...new Set(viewports.map((v) => range(v.top, v.bottom + 1)).flat())].filter((row) => !this.getters.isHeaderHidden(sheetId, "ROW", row));
       }
+      /**
+       * Get the positions of all the cells that are visible in the viewport, taking merges into account.
+       */
+      getVisibleCellPositions() {
+          const visibleCols = this.getSheetViewVisibleCols();
+          const visibleRows = this.getSheetViewVisibleRows();
+          const sheetId = this.getters.getActiveSheetId();
+          const positions = [];
+          for (const col of visibleCols) {
+              for (const row of visibleRows) {
+                  const position = { sheetId, col, row };
+                  const mainPosition = this.getters.getMainCellPosition(position);
+                  if (mainPosition.row !== row || mainPosition.col !== col) {
+                      continue;
+                  }
+                  positions.push(position);
+              }
+          }
+          return positions;
+      }
       /**
        * Return the main viewport maximum size relative to the client size.
        */
@@ -50729,6 +50823,13 @@
        * Computes the coordinates and size to draw the zone on the canvas
        */
       getVisibleRect(zone) {
+          const rect = this.getVisibleRectWithoutHeaders(zone);
+          return { ...rect, x: rect.x + this.gridOffsetX, y: rect.y + this.gridOffsetY };
+      }
+      /**
+       * Computes the coordinates and size to draw the zone without taking the grid offset into account
+       */
+      getVisibleRectWithoutHeaders(zone) {
           const sheetId = this.getters.getActiveSheetId();
           const viewportRects = this.getSubViewports(sheetId)
               .map((viewport) => viewport.getRect(zone))
@@ -50740,12 +50841,7 @@
           const y = Math.min(...viewportRects.map((rect) => rect.y));
           const width = Math.max(...viewportRects.map((rect) => rect.x + rect.width)) - x;
           const height = Math.max(...viewportRects.map((rect) => rect.y + rect.height)) - y;
-          return {
-              x: x + this.gridOffsetX,
-              y: y + this.gridOffsetY,
-              width,
-              height,
-          };
+          return { x, y, width, height };
       }
       /**
        * Returns the position of the MainViewport relatively to the start of the grid (without headers)
@@ -50969,13 +51065,8 @@
                   }
                   break;
               case "UPDATE_CELL":
-                  if ("content" in cmd || "format" in cmd) {
-                      this.headerPositions = {};
-                      this.isDirty = true;
-                  }
-                  else {
-                      this.headerPositions[cmd.sheetId] = this.computeHeaderPositionsOfSheet(cmd.sheetId);
-                  }
+                  this.headerPositions = {};
+                  this.isDirty = true;
                   break;
               case "UPDATE_FILTER":
               case "REMOVE_FILTER_TABLE":
@@ -54888,8 +54979,8 @@
           let currentPosition = startPosition;
           // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
           const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-          let mode = !this.getters.isCellEmpty({ ...currentPosition, sheetId }) &&
-              !this.getters.isCellEmpty({ ...nextCellPosition, sheetId })
+          let mode = !this.getters.isEvaluatedCellEmpty({ ...currentPosition, sheetId }) &&
+              !this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId })
               ? "endOfCluster"
               : "nextCluster";
           while (true) {
@@ -54899,7 +54990,7 @@
                   currentPosition.row === nextCellPosition.row) {
                   break;
               }
-              const isNextCellEmpty = this.getters.isCellEmpty({ ...nextCellPosition, sheetId });
+              const isNextCellEmpty = this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId });
               if (mode === "endOfCluster" && isNextCellEmpty) {
                   break;
               }
@@ -57184,9 +57275,9 @@
   exports.tokenize = tokenize;
 
 
-  __info__.version = "17.1.4";
-  __info__.date = "2024-02-09T13:09:13.430Z";
-  __info__.hash = "16d3ece";
+  __info__.version = "17.1.7";
+  __info__.date = "2024-03-12T07:56:10.783Z";
+  __info__.hash = "3a9f334";
 
 
 })(this.o_spreadsheet = this.o_spreadsheet || {}, owl);