@odoo/o-spreadsheet 17.1.4 → 17.1.7

package/dist/o-spreadsheet.esm.js

@@ -2,9 +2,9 @@
 /**
  * This file is generated by o-spreadsheet build tools. Do not edit it.
  * @see https://github.com/odoo/o-spreadsheet
- * @version 17.1.4
- * @date 2024-02-09T13:09:13.430Z
- * @hash 16d3ece
+ * @version 17.1.7
+ * @date 2024-03-12T07:56:10.783Z
+ * @hash 3a9f334
  */
 
 import { Component, useRef, onMounted, useEffect, onWillPatch, useState, onWillUpdateProps, onPatched, useComponent, useExternalListener, onWillUnmount, onWillStart, xml, useChildSubEnv, useSubEnv, markRaw } from '@odoo/owl';
@@ -451,8 +451,8 @@ function isObjectEmptyRecursive(argument) {
  * If the given item does not exist in the dictionary, it creates one with a new id.
  */
 function getItemId(item, itemsDic) {
-    for (let [key, value] of Object.entries(itemsDic)) {
-        if (deepEquals(value, item)) {
+    for (const key in itemsDic) {
+        if (deepEquals(itemsDic[key], item)) {
             return parseInt(key, 10);
         }
     }
@@ -551,11 +551,13 @@ function deepEquals(o1, o2) {
     if (typeof o1 !== "object")
         return o1 === o2;
     // Objects can have different keys if the values are undefined
-    const keys = new Set();
-    Object.keys(o1).forEach((key) => keys.add(key));
-    Object.keys(o2).forEach((key) => keys.add(key));
-    for (let key of keys) {
-        if (typeof o1[key] !== typeof o1[key])
+    for (const key in o2) {
+        if (!(key in o1) && o2[key] !== undefined) {
+            return false;
+        }
+    }
+    for (const key in o1) {
+        if (typeof o1[key] !== typeof o2[key])
             return false;
         if (typeof o1[key] === "object") {
             if (!deepEquals(o1[key], o2[key]))
@@ -625,18 +627,18 @@ function isConsecutive(iterable) {
     return true;
 }
 class JetSet extends Set {
-    add(...iterable) {
+    addMany(iterable) {
         for (const element of iterable) {
             super.add(element);
         }
         return this;
     }
-    delete(...iterable) {
-        let deleted = false;
+    deleteMany(iterable) {
+        let wasDeleted = false;
         for (const element of iterable) {
-            deleted ||= super.delete(element);
+            wasDeleted ||= super.delete(element);
         }
-        return deleted;
+        return wasDeleted;
     }
 }
 /**
@@ -1934,7 +1936,7 @@ class DispatchResult {
      * Static helper which returns a successful DispatchResult
      */
     static get Success() {
-        return new DispatchResult();
+        return SUCCESS;
     }
     get isSuccessful() {
         return this.reasons.length === 0;
@@ -1947,6 +1949,7 @@ class DispatchResult {
         return this.reasons.includes(reason);
     }
 }
+const SUCCESS = new DispatchResult();
 var CommandResult;
 (function (CommandResult) {
     CommandResult["Success"] = "Success";
@@ -6095,8 +6098,10 @@ function getGroup(cell, cells, filter) {
         if (x === cell) {
             found = true;
         }
-        const cellValue = evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
-        if (filter(cellValue)) {
+        const cellValue = x?.isFormula
+            ? undefined
+            : evaluateLiteral(x?.content, { locale: DEFAULT_LOCALE });
+        if (cellValue && filter(cellValue)) {
             group.push(cellValue);
         }
         else {
@@ -6320,11 +6325,14 @@ function cellTextStyleToCss(style) {
  * Transform CSS properties into a CSS string.
  */
 function cssPropertiesToCss(attributes) {
-    const str = Object.entries(attributes)
-        .filter(([attName, attValue]) => attValue !== undefined)
-        .map(([attName, attValue]) => `${attName}:${attValue};`)
-        .join(" ");
-    return str;
+    let styleStr = "";
+    for (const attName in attributes) {
+        if (!attributes[attName]) {
+            continue;
+        }
+        styleStr += `${attName}:${attributes[attName]}; `;
+    }
+    return styleStr;
 }
 function getElementMargins(el) {
     const style = window.getComputedStyle(el);
@@ -7653,6 +7661,9 @@ function isValidLocale(locale) {
     if (locale.formulaArgSeparator === locale.decimalSeparator) {
         return false;
     }
+    if (locale.thousandsSeparator === locale.decimalSeparator) {
+        return false;
+    }
     try {
         formatValue(1, { locale, format: "#,##0.00" });
         formatValue(1, { locale, format: locale.dateFormat });
@@ -7743,7 +7754,7 @@ function canonicalizeNumberLiteral(content, locale) {
     if (locale.decimalSeparator === "." || !isNumber(content, locale)) {
         return content;
     }
-    return content.replace(locale.decimalSeparator, ".");
+    return content.replace(locale.thousandsSeparator, "").replace(locale.decimalSeparator, ".");
 }
 /**
  * Change a content string from the given locale to its canonical form (en_US locale). Also convert date string.
@@ -10838,6 +10849,12 @@ const INSERT_LINK = (env) => {
     let { col, row } = env.model.getters.getActivePosition();
     env.model.dispatch("OPEN_CELL_POPOVER", { col, row, popoverType: "LinkEditor" });
 };
+const INSERT_LINK_NAME = (env) => {
+    const sheetId = env.model.getters.getActiveSheetId();
+    const { col, row } = env.model.getters.getActivePosition();
+    const cell = env.model.getters.getEvaluatedCell({ sheetId, col, row });
+    return cell && cell.link ? _t("Edit link") : _t("Insert link");
+};
 //------------------------------------------------------------------------------
 // Filters action
 //------------------------------------------------------------------------------
@@ -13039,6 +13056,18 @@ const TRUNC = {
     },
     isExported: true,
 };
+// -----------------------------------------------------------------------------
+// INT
+// -----------------------------------------------------------------------------
+const INT = {
+    description: _t("Rounds a number down to the nearest integer that is less than or equal to it."),
+    args: [arg("value (number)", _t("The number to round down to the nearest integer."))],
+    returns: ["NUMBER"],
+    compute: function (value) {
+        return Math.floor(toNumber(value, this.locale));
+    },
+    isExported: true,
+};
 
 var math = /*#__PURE__*/Object.freeze({
   __proto__: null,
@@ -13072,6 +13101,7 @@ var math = /*#__PURE__*/Object.freeze({
   FLOOR: FLOOR,
   FLOOR_MATH: FLOOR_MATH,
   FLOOR_PRECISE: FLOOR_PRECISE,
+  INT: INT,
   ISEVEN: ISEVEN,
   ISODD: ISODD,
   ISO_CEILING: ISO_CEILING,
@@ -18598,10 +18628,11 @@ const DEFAULT_IS_SORTED = true;
 const DEFAULT_MATCH_MODE = 0;
 const DEFAULT_SEARCH_MODE = 1;
 const DEFAULT_ABSOLUTE_RELATIVE_MODE = 1;
-function assertAvailable(variable, searchKey) {
-    if (variable === undefined) {
-        throw new NotAvailableError(_t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)));
-    }
+function valueNotAvailable(searchKey) {
+    return {
+        value: CellErrorType.NotAvailable,
+        message: _t("Did not find value '%s' in [[FUNCTION_NAME]] evaluation.", toString(searchKey)),
+    };
 }
 // -----------------------------------------------------------------------------
 // ADDRESS
@@ -18698,7 +18729,9 @@ const HLOOKUP = {
             ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range.length, getValueFromRange)
             : linearSearch(range, searchKey, "strict", range.length, getValueFromRange);
         const col = range[colIndex];
-        assertAvailable(col, searchKey?.value);
+        if (col === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return col[_index - 1];
     },
     isExported: true,
@@ -18755,11 +18788,11 @@ const LOOKUP = {
             : (range, index) => range[index][0].value;
         const rangeLength = verticalSearch ? nbRow : nbCol;
         const index = dichotomicSearch(searchArray, searchKey, "nextSmaller", "asc", rangeLength, getElement);
-        if (index === -1)
-            assertAvailable(undefined, searchKey?.value);
-        verticalSearch
-            ? assertAvailable(searchArray[0][index], searchKey?.value)
-            : assertAvailable(searchArray[index][nbRow - 1], searchKey?.value);
+        if (index === -1 ||
+            (verticalSearch && searchArray[0][index] === undefined) ||
+            (!verticalSearch && searchArray[index][nbRow - 1] === undefined)) {
+            return valueNotAvailable(searchKey);
+        }
         if (resultRange === undefined) {
             return verticalSearch ? searchArray[nbCol - 1][index] : searchArray[index][nbRow - 1];
         }
@@ -18809,7 +18842,10 @@ const MATCH = {
                 index = dichotomicSearch(range, searchKey, "nextGreater", "desc", rangeLen, getElement);
                 break;
         }
-        assertAvailable(nbCol === 1 ? range[0][index] : range[index], searchKey);
+        if ((nbCol === 1 && range[0][index] === undefined) ||
+            (nbCol !== 1 && range[index] === undefined)) {
+            return valueNotAvailable(searchKey);
+        }
         return index + 1;
     },
     isExported: true,
@@ -18868,7 +18904,9 @@ const VLOOKUP = {
             ? dichotomicSearch(range, searchKey, "nextSmaller", "asc", range[0].length, getValueFromRange)
             : linearSearch(range, searchKey, "strict", range[0].length, getValueFromRange);
         const value = range[_index - 1][rowIndex];
-        assertAvailable(value, searchKey);
+        if (value === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return value;
     },
     isExported: true,
@@ -18918,7 +18956,9 @@ const XLOOKUP = {
                 ? returnRange.map((col) => [col[index]])
                 : [returnRange[index]];
         }
-        assertAvailable(defaultValue, searchKey);
+        if (defaultValue === undefined) {
+            return valueNotAvailable(searchKey);
+        }
         return [[defaultValue]];
     },
     isExported: true,
@@ -19690,8 +19730,7 @@ class FunctionRegistry extends Registry {
 function addErrorHandling(compute, functionName) {
     return function (...args) {
         try {
-            const computeFormula = compute.bind(this);
-            return computeFormula(...args);
+            return compute.apply(this, args);
         }
         catch (e) {
             return handleError(e, functionName);
@@ -19725,8 +19764,7 @@ function hasStringMessage(obj) {
 }
 function addResultHandling(compute) {
     return function (...args) {
-        const computeResult = compute.bind(this);
-        const result = computeResult(...args);
+        const result = compute.apply(this, args);
         if (!isMatrix(result)) {
             if (typeof result === "object" && result !== null && "value" in result) {
                 return result;
@@ -20082,7 +20120,7 @@ cellMenuRegistry
 })
     .add("insert_link", {
     ...insertLink,
-    name: _t("Insert link"),
+    name: INSERT_LINK_NAME,
     sequence: 150,
     separator: true,
 });
@@ -21693,7 +21731,7 @@ class SelectionInput extends Component {
             ? existingSelectionRanges
             : this.props.ranges().map((xc, id) => ({
                 xc,
-                id,
+                id: id + 1,
                 isFocused: false,
             }));
         return ranges.map((range) => ({
@@ -26525,6 +26563,17 @@ class TextValueProvider extends Component {
         onValueSelected: Function,
         onValueHovered: Function,
     };
+    autoCompleteListRef = useRef("autoCompleteList");
+    setup() {
+        useEffect(() => {
+            const selectedIndex = this.props.selectedIndex;
+            if (selectedIndex === undefined) {
+                return;
+            }
+            const selectedElement = this.autoCompleteListRef.el?.children[selectedIndex];
+            selectedElement?.scrollIntoView?.({ block: "nearest" });
+        }, () => [this.props.selectedIndex, this.autoCompleteListRef.el]);
+    }
 }
 
 class ContentEditableHelper {
@@ -26969,6 +27018,7 @@ css /* scss */ `
       position: absolute;
       margin: 1px 4px;
       pointer-events: none;
+      overflow: auto;
 
       .o-semi-bold {
         /** FIXME: to remove in favor of Bootstrap
@@ -27026,7 +27076,10 @@ class Composer extends Component {
         if (this.props.delimitation && this.props.rect) {
             const { x: cellX, y: cellY, height: cellHeight } = this.props.rect;
             const remainingHeight = this.props.delimitation.height - (cellY + cellHeight);
+            assistantStyle["max-height"] = `${remainingHeight}px`;
             if (cellY > remainingHeight) {
+                const availableSpaceAbove = cellY;
+                assistantStyle["max-height"] = `${availableSpaceAbove}px`;
                 // render top
                 // We compensate 2 px of margin on the assistant style + 1px for design reasons
                 assistantStyle.top = `-3px`;
@@ -27718,7 +27771,11 @@ class GridComposer extends Component {
         }
     }
     updateCellReferenceVisibility() {
-        if (this.isCellReferenceVisible || this.env.model.getters.getEditionMode() === "inactive") {
+        if (this.env.model.getters.getEditionMode() === "inactive") {
+            this.isCellReferenceVisible = false;
+            return;
+        }
+        if (this.isCellReferenceVisible) {
             return;
         }
         const sheetId = this.env.model.getters.getActiveSheetId();
@@ -27747,19 +27804,21 @@ class GridCellIcon extends Component {
         slots: Object,
     };
     get iconStyle() {
-        const x = this.getIconHorizontalPosition();
-        const y = this.getIconVerticalPosition();
+        const cellPosition = this.props.cellPosition;
+        const merge = this.env.model.getters.getMerge(cellPosition);
+        const zone = merge || positionToZone(cellPosition);
+        const rect = this.env.model.getters.getVisibleRectWithoutHeaders(zone);
+        const x = this.getIconHorizontalPosition(rect, cellPosition);
+        const y = this.getIconVerticalPosition(rect, cellPosition);
         return cssPropertiesToCss({
             top: `${y + (this.props.offset?.y || 0)}px`,
             left: `${x + (this.props.offset?.x || 0)}px`,
         });
     }
-    getIconVerticalPosition() {
-        const { sheetId, row } = this.props.cellPosition;
-        const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-        const start = this.env.model.getters.getRowDimensionsInViewport(sheetId, row).start;
-        const end = this.env.model.getters.getRowDimensionsInViewport(sheetId, merge ? merge.bottom : row).end;
-        const cell = this.env.model.getters.getCell(this.props.cellPosition);
+    getIconVerticalPosition(rect, cellPosition) {
+        const start = rect.y;
+        const end = rect.y + rect.height;
+        const cell = this.env.model.getters.getCell(cellPosition);
         const align = this.props.verticalAlign || cell?.style?.verticalAlign || DEFAULT_VERTICAL_ALIGN;
         switch (align) {
             case "bottom":
@@ -27771,13 +27830,11 @@ class GridCellIcon extends Component {
                 return end - GRID_ICON_EDGE_LENGTH - centeringOffset;
         }
     }
-    getIconHorizontalPosition() {
-        const { sheetId, col } = this.props.cellPosition;
-        const merge = this.env.model.getters.getMerge(this.props.cellPosition);
-        const start = this.env.model.getters.getColDimensionsInViewport(sheetId, col).start;
-        const end = this.env.model.getters.getColDimensionsInViewport(sheetId, merge ? merge.right : col).end;
-        const cell = this.env.model.getters.getCell(this.props.cellPosition);
-        const evaluatedCell = this.env.model.getters.getEvaluatedCell(this.props.cellPosition);
+    getIconHorizontalPosition(rect, cellPosition) {
+        const start = rect.x;
+        const end = rect.x + rect.width;
+        const cell = this.env.model.getters.getCell(cellPosition);
+        const evaluatedCell = this.env.model.getters.getEvaluatedCell(cellPosition);
         const align = this.props.horizontalAlign || cell?.style?.align || evaluatedCell.defaultAlign;
         switch (align) {
             case "right":
@@ -27861,6 +27918,8 @@ css /* scss */ `
     height: ${CHECKBOX_WIDTH}px;
     accent-color: #808080;
     margin: ${MARGIN}px;
+    /** required to prevent the checkbox position to be sensible to the font-size (affects Firefox) */
+    position: absolute;
   }
 `;
 class DataValidationCheckbox extends Component {
@@ -27879,7 +27938,7 @@ class DataValidationCheckbox extends Component {
     }
     get isDisabled() {
         const cell = this.env.model.getters.getCell(this.props.cellPosition);
-        return !!cell?.isFormula;
+        return this.env.model.getters.isReadonly() || !!cell?.isFormula;
     }
 }
 
@@ -27919,12 +27978,17 @@ class DataValidationOverlay extends Component {
     static props = {};
     static components = { GridCellIcon, DataValidationCheckbox, DataValidationListIcon };
     get checkBoxCellPositions() {
-        return this.env.model.getters.getDataValidationCheckBoxCellPositions();
+        return this.env.model.getters
+            .getVisibleCellPositions()
+            .filter(this.env.model.getters.isCellValidCheckbox);
     }
     get listIconsCellPositions() {
-        return this.env.model.getters.isReadonly()
-            ? []
-            : this.env.model.getters.getDataValidationListCellsPositions();
+        if (this.env.model.getters.isReadonly()) {
+            return [];
+        }
+        return this.env.model.getters
+            .getVisibleCellPositions()
+            .filter(this.env.model.getters.cellHasListDataValidationIcon);
     }
 }
 
@@ -34286,29 +34350,12 @@ const MIGRATIONS = [
         from: 12,
         to: 12.5,
         applyMigration(data) {
-            for (let sheet of data.sheets || []) {
-                let knownDataFilterZones = [];
-                for (let filterTable of sheet.filterTables || []) {
-                    const zone = toZone(filterTable.range);
-                    // See commit message for the details
-                    const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
-                    if (intersectZoneIndex !== -1) {
-                        knownDataFilterZones[intersectZoneIndex] = zone;
-                    }
-                    else {
-                        knownDataFilterZones.push(zone);
-                    }
-                }
-                sheet.filterTables = knownDataFilterZones.map((zone) => ({
-                    range: zoneToXc(zone),
-                }));
-            }
-            return data;
+            return fixOverlappingFilters(data);
         },
     },
     {
         description: "Change Border description structure",
-        from: 12,
+        from: 12.5,
         to: 13,
         applyMigration(data) {
             for (const borderId in data.borders) {
@@ -34339,6 +34386,14 @@ const MIGRATIONS = [
             return data;
         },
     },
+    {
+        description: "Fix datafilter duplication (post saas-16.4)",
+        from: 14,
+        to: 14.5,
+        applyMigration(data) {
+            return fixOverlappingFilters(data);
+        },
+    },
 ];
 /**
  * This function is used to repair faulty data independently of the migration.
@@ -34496,6 +34551,26 @@ function fixChartDefinitions(data, initialMessages) {
     }
     return messages;
 }
+function fixOverlappingFilters(data) {
+    for (let sheet of data.sheets || []) {
+        let knownDataFilterZones = [];
+        for (let filterTable of sheet.filterTables || []) {
+            const zone = toZone(filterTable.range);
+            // See commit message of https://github.com/odoo/o-spreadsheet/pull/3632 of more details
+            const intersectZoneIndex = knownDataFilterZones.findIndex((knownZone) => overlap(knownZone, zone));
+            if (intersectZoneIndex !== -1) {
+                knownDataFilterZones[intersectZoneIndex] = zone;
+            }
+            else {
+                knownDataFilterZones.push(zone);
+            }
+        }
+        sheet.filterTables = knownDataFilterZones.map((zone) => ({
+            range: zoneToXc(zone),
+        }));
+    }
+    return data;
+}
 // -----------------------------------------------------------------------------
 // Helpers
 // -----------------------------------------------------------------------------
@@ -35145,22 +35220,7 @@ class BordersPlugin extends CorePlugin {
         }
     }
     export(data) {
-        // Borders
-        let borderId = 0;
         const borders = {};
-        /**
-         * Get the id of the given border. If the border does not exist, it creates
-         * one.
-         */
-        function getBorderId(border) {
-            for (let [key, value] of Object.entries(borders)) {
-                if (deepEquals(value, border)) {
-                    return parseInt(key, 10);
-                }
-            }
-            borders[++borderId] = border;
-            return borderId;
-        }
         for (let sheet of data.sheets) {
             for (let col = 0; col < sheet.colNumber; col++) {
                 for (let row = 0; row < sheet.rowNumber; row++) {
@@ -35168,7 +35228,7 @@ class BordersPlugin extends CorePlugin {
                     if (border) {
                         const xc = toXC(col, row);
                         const cell = sheet.cells[xc];
-                        const borderId = getBorderId(border);
+                        const borderId = getItemId(border, borders);
                         if (cell) {
                             cell.border = borderId;
                         }
@@ -35957,9 +36017,9 @@ class CellPlugin extends CorePlugin {
     allowDispatch(cmd) {
         switch (cmd.type) {
             case "UPDATE_CELL":
-                return this.checkCellOutOfSheet(cmd);
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessUpdateCell);
             case "CLEAR_CELL":
-                return this.checkValidations(cmd, this.chainValidations(this.checkCellOutOfSheet, this.checkUselessClearCell));
+                return this.checkValidations(cmd, this.checkCellOutOfSheet, this.checkUselessClearCell);
             default:
                 return "Success" /* CommandResult.Success */;
         }
@@ -36109,8 +36169,8 @@ class CellPlugin extends CorePlugin {
     }
     removeDefaultStyleValues(style) {
         const cleanedStyle = { ...style };
-        for (const [property, defaultValue] of Object.entries(DEFAULT_STYLE)) {
-            if (cleanedStyle[property] === defaultValue) {
+        for (const property in DEFAULT_STYLE) {
+            if (cleanedStyle[property] === DEFAULT_STYLE[property]) {
                 delete cleanedStyle[property];
             }
         }
@@ -36266,10 +36326,7 @@ class CellPlugin extends CorePlugin {
         else {
             style = before ? before.style : undefined;
         }
-        const locale = this.getters.getLocale();
-        let format = ("format" in after ? after.format : before && before.format) ||
-            detectDateFormat(afterContent, locale) ||
-            detectNumberFormat(afterContent);
+        const format = "format" in after ? after.format : before && before.format;
         /* Read the following IF as:
          * we need to remove the cell if it is completely empty, but we can know if it completely empty if:
          * - the command says the new content is empty and has no border/format/style
@@ -36310,6 +36367,7 @@ class CellPlugin extends CorePlugin {
     }
     createLiteralCell(id, content, format, style) {
         const locale = this.getters.getLocale();
+        format = format || detectDateFormat(content, locale) || detectNumberFormat(content);
         if (format !== PLAIN_TEXT_FORMAT && !isEvaluationError(content)) {
             content = toString(parseLiteral(content, locale));
         }
@@ -36382,6 +36440,18 @@ class CellPlugin extends CorePlugin {
         }
         return "Success" /* CommandResult.Success */;
     }
+    checkUselessUpdateCell(cmd) {
+        const cell = this.getters.getCell(cmd);
+        const hasContent = "content" in cmd || "formula" in cmd;
+        const hasStyle = "style" in cmd;
+        const hasFormat = "format" in cmd;
+        if ((!hasContent || cell?.content === cmd.content) &&
+            (!hasStyle || deepEquals(cell?.style, cmd.style)) &&
+            (!hasFormat || cell?.format === cmd.format)) {
+            return "NoChanges" /* CommandResult.NoChanges */;
+        }
+        return "Success" /* CommandResult.Success */;
+    }
 }
 class FormulaCellWithDependencies {
     id;
@@ -39022,7 +39092,6 @@ class SheetPlugin extends CorePlugin {
         "getNumberHeaders",
         "getGridLinesVisibility",
         "getNextSheetName",
-        "isEmpty",
         "getSheetSize",
         "getSheetZone",
         "getPaneDivisions",
@@ -39397,14 +39466,6 @@ class SheetPlugin extends CorePlugin {
     // ---------------------------------------------------------------------------
     // Row/Col manipulation
     // ---------------------------------------------------------------------------
-    /**
-     * Check if a zone only contains empty cells
-     */
-    isEmpty(sheetId, zone) {
-        return positions(zone)
-            .map(({ col, row }) => this.getCell({ sheetId, col, row }))
-            .every((cell) => !cell || cell.content === "");
-    }
     getCommandZones(cmd) {
         const zones = [];
         if ("zone" in cmd) {
@@ -41166,7 +41227,15 @@ class SpreadsheetRTree {
         if (!this.rTrees[sheetId]) {
             return;
         }
-        this.rTrees[sheetId].remove(item, deepEquals);
+        this.rTrees[sheetId].remove(item, this.rtreeItemComparer);
+    }
+    rtreeItemComparer(left, right) {
+        return (left.data == right.data &&
+            left.boundingBox.sheetId === right.boundingBox.sheetId &&
+            left.boundingBox?.zone.left === right.boundingBox.zone.left &&
+            left.boundingBox?.zone.top === right.boundingBox.zone.top &&
+            left.boundingBox?.zone.right === right.boundingBox.zone.right &&
+            left.boundingBox?.zone.bottom === right.boundingBox.zone.bottom);
     }
 }
 /**
@@ -41244,7 +41313,7 @@ class FormulaDependencyGraph {
         const queue = Array.from(ranges).reverse();
         while (queue.length > 0) {
             const range = queue.pop();
-            visited.add(...this.encoder.encodeBoundingBox(range));
+            visited.addMany(this.encoder.encodeBoundingBox(range));
             const impactedPositionIds = this.rTree.search(range).map((dep) => dep.data);
             for (const positionId of impactedPositionIds) {
                 if (!visited.has(positionId)) {
@@ -41252,7 +41321,7 @@ class FormulaDependencyGraph {
                 }
             }
         }
-        visited.delete(...ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
+        visited.deleteMany(ranges.flatMap((r) => this.encoder.encodeBoundingBox(r)));
         return visited;
     }
 }
@@ -41392,9 +41461,9 @@ class Evaluator {
         const cells = positions.map((p) => this.encoder.encode(p));
         const cellsToCompute = new JetSet(cells);
         const arrayFormulasPositionIds = this.getArrayFormulasImpactedByChangesOf(cells);
-        cellsToCompute.add(...this.getCellsDependingOn(cells));
-        cellsToCompute.add(...arrayFormulasPositionIds);
-        cellsToCompute.add(...this.getCellsDependingOn(arrayFormulasPositionIds));
+        cellsToCompute.addMany(this.getCellsDependingOn(cells));
+        cellsToCompute.addMany(arrayFormulasPositionIds);
+        cellsToCompute.addMany(this.getCellsDependingOn(arrayFormulasPositionIds));
         this.evaluate(cellsToCompute);
     }
     getArrayFormulasImpactedByChangesOf(positionIds) {
@@ -41408,7 +41477,7 @@ class Evaluator {
             }
             if (!content) {
                 // The previous content could have blocked some array formulas
-                impactedPositionIds.add(...this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
+                impactedPositionIds.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(positionId));
             }
         }
         return impactedPositionIds;
@@ -41460,7 +41529,7 @@ class Evaluator {
         }
         const arrayFormulas = this.spreadingRelations.getFormulaPositionsSpreadingOn(positionId);
         const cells = new JetSet(arrayFormulas);
-        cells.add(...this.getCellsDependingOn(arrayFormulas));
+        cells.addMany(this.getCellsDependingOn(arrayFormulas));
         return cells;
     }
     nextPositionsToUpdate = new JetSet();
@@ -41511,7 +41580,7 @@ class Evaluator {
                 : evaluateLiteral(cell.content, localeFormat);
         }
         catch (e) {
-            return createEvaluatedCell(e.value, localeFormat, e.message);
+            return createEvaluatedCell(e?.value || CellErrorType.GenericError, localeFormat, e?.message || implementationErrorMessage);
         }
         finally {
             this.cellsBeingComputed.delete(cellId);
@@ -41598,7 +41667,7 @@ class Evaluator {
             this.setEvaluatedCell(positionId, evaluatedCell);
             // check if formula dependencies present in the spread zone
             // if so, they need to be recomputed
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([positionId]));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([positionId]));
         };
     }
     invalidateSpreading(positionId) {
@@ -41613,8 +41682,8 @@ class Evaluator {
                 continue;
             }
             this.evaluatedCells.delete(child);
-            this.nextPositionsToUpdate.add(...this.getCellsDependingOn([child]));
-            this.nextPositionsToUpdate.add(...this.getArrayFormulasBlockedByOrSpreadingOn(child));
+            this.nextPositionsToUpdate.addMany(this.getCellsDependingOn([child]));
+            this.nextPositionsToUpdate.addMany(this.getArrayFormulasBlockedByOrSpreadingOn(child));
         }
         this.spreadingRelations.removeNode(positionId);
     }
@@ -41845,6 +41914,7 @@ class EvaluationPlugin extends UIPlugin {
         "getEvaluatedCellsInZone",
         "getSpreadPositionsOf",
         "getArrayFormulaSpreadingOn",
+        "isEmpty",
     ];
     shouldRebuildDependenciesGraph = true;
     evaluator;
@@ -41950,6 +42020,14 @@ class EvaluationPlugin extends UIPlugin {
     getArrayFormulaSpreadingOn(position) {
         return this.evaluator.getArrayFormulaSpreadingOn(position);
     }
+    /**
+     * Check if a zone only contains empty cells
+     */
+    isEmpty(sheetId, zone) {
+        return positions(zone)
+            .map(({ col, row }) => this.getEvaluatedCell({ sheetId, col, row }))
+            .every((cell) => cell.type === CellValueType.empty);
+    }
     // ---------------------------------------------------------------------------
     // Export
     // ---------------------------------------------------------------------------
@@ -42597,8 +42675,6 @@ const VALID_RESULT = { isValid: true };
 class EvaluationDataValidationPlugin extends UIPlugin {
     static getters = [
         "getDataValidationInvalidCriterionValueMessage",
-        "getDataValidationCheckBoxCellPositions",
-        "getDataValidationListCellsPositions",
         "getInvalidDataValidationMessage",
         "getValidationResultForCellValue",
         "isCellValidCheckbox",
@@ -42662,19 +42738,6 @@ class EvaluationDataValidationPlugin extends UIPlugin {
         const error = this.getRuleErrorForCellValue(cellValue, cellPosition, rule);
         return error ? { error, rule, isValid: false } : VALID_RESULT;
     }
-    getDataValidationCheckBoxCellPositions() {
-        const rules = this.getters
-            .getDataValidationRules(this.getters.getActiveSheetId())
-            .filter((rule) => rule.criterion.type === "isBoolean");
-        return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat()).filter((position) => this.isCellValidCheckbox(position));
-    }
-    getDataValidationListCellsPositions() {
-        const rules = this.getters
-            .getDataValidationRules(this.getters.getActiveSheetId())
-            .filter((rule) => (rule.criterion.type === "isValueInList" || rule.criterion.type === "isValueInRange") &&
-            rule.criterion.displayStyle === "arrow");
-        return getCellPositionsInRanges(rules.map((rule) => rule.ranges).flat());
-    }
     getValidationResultForCell(cellPosition) {
         const { col, row, sheetId } = cellPosition;
         if (!this.validationResults[sheetId]) {
@@ -45483,7 +45546,7 @@ class FindAndReplacePlugin extends UIPlugin {
     }
     finalize() {
         if (this.isSearchDirty) {
-            this.refreshSearch();
+            this.refreshSearch(false);
             this.isSearchDirty = false;
         }
     }
@@ -45527,10 +45590,10 @@ class FindAndReplacePlugin extends UIPlugin {
     /**
      * refresh the matches according to the current search options
      */
-    refreshSearch() {
+    refreshSearch(jumpToMatchSheet = true) {
         this.selectedMatchIndex = null;
         this.findMatches();
-        this.selectNextCell(Direction.current);
+        this.selectNextCell(Direction.current, jumpToMatchSheet);
     }
     /**
      * Updates the regex based on the current searchOptions and
@@ -45612,7 +45675,7 @@ class FindAndReplacePlugin extends UIPlugin {
      * It is also used to keep coherence between the selected searchMatch
      * and selectedMatchIndex.
      */
-    selectNextCell(indexChange) {
+    selectNextCell(indexChange, jumpToMatchSheet = true) {
         const matches = this.searchMatches;
         if (!matches.length) {
             this.selectedMatchIndex = null;
@@ -45638,11 +45701,13 @@ class FindAndReplacePlugin extends UIPlugin {
         this.selectedMatchIndex = nextIndex;
         const selectedMatch = matches[nextIndex];
         // Switch to the sheet where the match is located
-        if (this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
+        if (jumpToMatchSheet && this.getters.getActiveSheetId() !== selectedMatch.sheetId) {
             this.dispatch("ACTIVATE_SHEET", {
                 sheetIdFrom: this.getters.getActiveSheetId(),
                 sheetIdTo: selectedMatch.sheetId,
             });
+            // We do not want to reset the selection at finalize in this case
+            this.isSearchDirty = false;
         }
         // we want grid selection to capture the selection stream
         this.selection.getBackToDefault();
@@ -46944,19 +47009,17 @@ class SelectionInputsManagerPlugin extends UIPlugin {
                 break;
             case "FOCUS_RANGE":
             case "CHANGE_RANGE":
-                if (cmd.id !== this.focusedInputId) {
-                    const input = this.inputs[cmd.id];
-                    const range = input.ranges.find((range) => range.id === cmd.rangeId);
-                    if (this.isRangeValid(range?.xc || "A1")) {
-                        const sheetId = this.getters.getActiveSheetId();
-                        const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
-                        this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
-                            handleEvent: input.handleEvent.bind(input),
-                            release: () => (this.focusedInputId = null),
-                        });
-                    }
-                    this.focusedInputId = cmd.id;
+                const input = this.inputs[cmd.id];
+                const range = input.ranges.find((range) => range.id === cmd.rangeId);
+                if (range) {
+                    const sheetId = this.getters.getActiveSheetId();
+                    const zone = this.getters.getRangeFromSheetXC(sheetId, range?.xc || "A1").zone;
+                    this.selection.capture(input, { cell: { col: zone.left, row: zone.top }, zone }, {
+                        handleEvent: input.handleEvent.bind(input),
+                        release: () => (this.focusedInputId = null),
+                    });
                 }
+                this.focusedInputId = cmd.id;
                 break;
         }
         this.currentInput?.handle(cmd);
@@ -47210,7 +47273,7 @@ class SheetUIPlugin extends UIPlugin {
         "getCellText",
         "getCellMultiLineText",
         "getContiguousZone",
-        "isCellEmpty",
+        "isEvaluatedCellEmpty",
     ];
     ctx = document.createElement("canvas").getContext("2d");
     // ---------------------------------------------------------------------------
@@ -47338,14 +47401,23 @@ class SheetUIPlugin extends UIPlugin {
         return zone;
     }
     /**
-     * Check if a cell is empty. If the cell is part of a merge,
-     * check if the merge containing the cell is empty.
+     * Checks if a cell evaluated value is empty. If the cell is part of a merge,
+     * the check applies to the main cell of the merge.
      */
-    isCellEmpty(position) {
+    isEvaluatedCellEmpty(position) {
         const mainPosition = this.getters.getMainCellPosition(position);
         const cell = this.getters.getEvaluatedCell(mainPosition);
         return cell.type === CellValueType.empty;
     }
+    /**
+     * Checks if a cell is empty (i.e. does not have a content or a formula does not spread over it).
+     * If the cell is part of a merge, the check applies to the main cell of the merge.
+     */
+    isCellEmpty(position) {
+        const mainPosition = this.getters.getMainCellPosition(position);
+        return !(this.getters.getCorrespondingFormulaCell(mainPosition) ||
+            this.getters.getCell(mainPosition)?.content);
+    }
     getColMaxWidth(sheetId, index) {
         const cellsPositions = positions(this.getters.getColsZone(sheetId, index, index));
         const sizes = cellsPositions.map((position) => this.getCellWidth({ sheetId, ...position }));
@@ -50366,6 +50438,8 @@ class SheetViewPlugin extends UIPlugin {
         "getEdgeScrollRow",
         "getVisibleFigures",
         "getVisibleRect",
+        "getVisibleRectWithoutHeaders",
+        "getVisibleCellPositions",
         "getColRowOffsetInViewport",
         "getMainViewportCoordinates",
         "getActiveSheetScrollInfo",
@@ -50609,6 +50683,26 @@ class SheetViewPlugin extends UIPlugin {
         const viewports = this.getSubViewports(sheetId);
         return [...new Set(viewports.map((v) => range(v.top, v.bottom + 1)).flat())].filter((row) => !this.getters.isHeaderHidden(sheetId, "ROW", row));
     }
+    /**
+     * Get the positions of all the cells that are visible in the viewport, taking merges into account.
+     */
+    getVisibleCellPositions() {
+        const visibleCols = this.getSheetViewVisibleCols();
+        const visibleRows = this.getSheetViewVisibleRows();
+        const sheetId = this.getters.getActiveSheetId();
+        const positions = [];
+        for (const col of visibleCols) {
+            for (const row of visibleRows) {
+                const position = { sheetId, col, row };
+                const mainPosition = this.getters.getMainCellPosition(position);
+                if (mainPosition.row !== row || mainPosition.col !== col) {
+                    continue;
+                }
+                positions.push(position);
+            }
+        }
+        return positions;
+    }
     /**
      * Return the main viewport maximum size relative to the client size.
      */
@@ -50728,6 +50822,13 @@ class SheetViewPlugin extends UIPlugin {
      * Computes the coordinates and size to draw the zone on the canvas
      */
     getVisibleRect(zone) {
+        const rect = this.getVisibleRectWithoutHeaders(zone);
+        return { ...rect, x: rect.x + this.gridOffsetX, y: rect.y + this.gridOffsetY };
+    }
+    /**
+     * Computes the coordinates and size to draw the zone without taking the grid offset into account
+     */
+    getVisibleRectWithoutHeaders(zone) {
         const sheetId = this.getters.getActiveSheetId();
         const viewportRects = this.getSubViewports(sheetId)
             .map((viewport) => viewport.getRect(zone))
@@ -50739,12 +50840,7 @@ class SheetViewPlugin extends UIPlugin {
         const y = Math.min(...viewportRects.map((rect) => rect.y));
         const width = Math.max(...viewportRects.map((rect) => rect.x + rect.width)) - x;
         const height = Math.max(...viewportRects.map((rect) => rect.y + rect.height)) - y;
-        return {
-            x: x + this.gridOffsetX,
-            y: y + this.gridOffsetY,
-            width,
-            height,
-        };
+        return { x, y, width, height };
     }
     /**
      * Returns the position of the MainViewport relatively to the start of the grid (without headers)
@@ -50968,13 +51064,8 @@ class HeaderPositionsUIPlugin extends UIPlugin {
                 }
                 break;
             case "UPDATE_CELL":
-                if ("content" in cmd || "format" in cmd) {
-                    this.headerPositions = {};
-                    this.isDirty = true;
-                }
-                else {
-                    this.headerPositions[cmd.sheetId] = this.computeHeaderPositionsOfSheet(cmd.sheetId);
-                }
+                this.headerPositions = {};
+                this.isDirty = true;
                 break;
             case "UPDATE_FILTER":
             case "REMOVE_FILTER_TABLE":
@@ -54887,8 +54978,8 @@ class SelectionStreamProcessorImpl {
         let currentPosition = startPosition;
         // If both the current cell and the next cell are not empty, we want to go to the end of the cluster
         const nextCellPosition = this.getNextCellPosition(startPosition, dim, dir);
-        let mode = !this.getters.isCellEmpty({ ...currentPosition, sheetId }) &&
-            !this.getters.isCellEmpty({ ...nextCellPosition, sheetId })
+        let mode = !this.getters.isEvaluatedCellEmpty({ ...currentPosition, sheetId }) &&
+            !this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId })
             ? "endOfCluster"
             : "nextCluster";
         while (true) {
@@ -54898,7 +54989,7 @@ class SelectionStreamProcessorImpl {
                 currentPosition.row === nextCellPosition.row) {
                 break;
             }
-            const isNextCellEmpty = this.getters.isCellEmpty({ ...nextCellPosition, sheetId });
+            const isNextCellEmpty = this.getters.isEvaluatedCellEmpty({ ...nextCellPosition, sheetId });
             if (mode === "endOfCluster" && isNextCellEmpty) {
                 break;
             }
@@ -57147,6 +57238,6 @@ const constants = {
 export { AbstractChart, CellErrorType, CommandResult, CorePlugin, DispatchResult, EvaluationError, Model, Registry, Revision, SPREADSHEET_DIMENSIONS, Spreadsheet, UIPlugin, __info__, addFunction, astToFormula, compile, compileTokens, components, constants, convertAstNodes, coreTypes, findCellInNewZone, functionCache, helpers, hooks, invalidateCFEvaluationCommands, invalidateDependenciesCommands, invalidateEvaluationCommands, iterateAstNodes, links, load, parse, parseTokens, readonlyAllowedCommands, registries, setDefaultSheetViewSize, setTranslationMethod, tokenize };
 
 
-__info__.version = "17.1.4";
-__info__.date = "2024-02-09T13:09:13.430Z";
-__info__.hash = "16d3ece";
+__info__.version = "17.1.7";
+__info__.date = "2024-03-12T07:56:10.783Z";
+__info__.hash = "3a9f334";