@o3co/create-auth-provider 0.15.0 → 0.17.0-rc.1

package/templates/standalone/src/__tests__/oidc-federation-config-module.test.mts

@@ -14,14 +14,15 @@
  * limitations under the License.
  */
 
-import type { AppConfig } from "@o3co/auth-provider-core";
-import { makeValidAppConfig } from "@o3co/auth-provider-core/testing";
+import { coreConfigForTests, makeValidAppConfig } from "@o3co/auth-provider-core/testing";
 import { describe, expect, it } from "vitest";
 import { buildModules } from "../buildModules.mjs";
+import type { Switches } from "../configPath.mjs";
 import { oidcFederationConfigModule } from "../modules.mjs";
+import { inProcessAdapters } from "./library-references.fixture.mjs";
 
 /**
- * #524: the scaffold turns every enabled `federations.<name>` of type
+ * The scaffold turns every enabled `core.federations.<name>` of type
  * `oidc` into one instance of the generic OIDC federation module, fed by a
  * single config bridge. A deployment adds an IdP with configuration only.
  */
@@ -40,45 +41,46 @@ const okta = {
 	callbackURL: "https://auth.test/session/oauth/federation/okta/callback",
 };
 
-/** Core's valid fixture, with the federations under test and every adapter on memory. */
-const configWith = (federations: Record<string, unknown>): AppConfig => {
-	const base = makeValidAppConfig();
-	return {
-		...base,
-		federations,
-		oauth: { ...base.oauth, code: { adapter: "memory" } },
-	} as unknown as AppConfig;
-};
+/** Core's valid fixture, with the federations under test and every store in process. */
+const configWith = (federations: Record<string, unknown>): Switches =>
+	({
+		...makeValidAppConfig(),
+		...coreConfigForTests({ declaredAbsent: ["auditSink"], federations: federations as never }),
+		adapters: inProcessAdapters(),
+		mfaMode: "off",
+	}) as unknown as Switches;
 
-describe("oidcFederationConfigModule (#524)", () => {
+describe("oidcFederationConfigModule", () => {
 	it("has the scaffold's module name and reads config", () => {
-		expect(oidcFederationConfigModule.name).toBe("standalone:oidc-federation-config");
+		expect(oidcFederationConfigModule.name).toBe("oidc-federation-config");
 		expect(oidcFederationConfigModule.requires).toEqual(["config"]);
 	});
 
 	it("reads every enabled oidc section into the slot, keyed by federation name", () => {
 		const out = bridge({
 			config: {
-				federations: {
-					okta: { enabled: true, type: "oidc", ...okta },
-					keycloak: {
-						enabled: true,
-						type: "oidc",
-						clientUrl: "https://app.test/",
-						oidc: {
-							issuer: "https://kc.test/realms/dev",
-							clientId: "kc-client",
-							clientSecret: "kc-secret",
-							callbackURL: "https://auth.test/session/oauth/federation/keycloak/callback",
+				core: {
+					federations: {
+						okta: { enabled: true, type: "oidc", ...okta },
+						keycloak: {
+							enabled: true,
+							type: "oidc",
+							clientUrl: "https://app.test/",
+							oidc: {
+								issuer: "https://kc.test/realms/dev",
+								clientId: "kc-client",
+								clientSecret: "kc-secret",
+								callbackURL: "https://auth.test/session/oauth/federation/keycloak/callback",
+							},
 						},
+						google: {
+							enabled: true,
+							clientId: "g",
+							clientSecret: "s",
+							callbackURL: "https://auth.test/g",
+						},
+						paused: { enabled: false, type: "oidc", ...okta },
 					},
-					google: {
-						enabled: true,
-						clientId: "g",
-						clientSecret: "s",
-						callbackURL: "https://auth.test/g",
-					},
-					paused: { enabled: false, type: "oidc", ...okta },
 				},
 			},
 		});
@@ -93,17 +95,21 @@ describe("oidcFederationConfigModule (#524)", () => {
 	it("refuses a malformed section at boot, naming the field", () => {
 		const { issuer: _dropped, ...noIssuer } = okta;
 		expect(() =>
-			bridge({ config: { federations: { okta: { enabled: true, type: "oidc", ...noIssuer } } } }),
-		).toThrow(/federations\.okta\.issuer/);
+			bridge({
+				config: { core: { federations: { okta: { enabled: true, type: "oidc", ...noIssuer } } } },
+			}),
+		).toThrow(/core\.federations\.okta\.issuer/);
 	});
 
 	it("is an empty slot when no section is of type oidc", () => {
-		expect(bridge({ config: { federations: { google: { enabled: false } } } })).toEqual({});
+		expect(bridge({ config: { core: { federations: { google: { enabled: false } } } } })).toEqual(
+			{},
+		);
 	});
 });
 
-describe("buildModules gating for OIDC federations (#524)", () => {
-	it("lists one federation:oidc:<name> per enabled section, plus the bridge once", () => {
+describe("buildModules gating for OIDC federations", () => {
+	it("lists one federation-oidc-<name> per enabled section, plus the bridge once", () => {
 		const names = buildModules(
 			configWith({
 				okta: { enabled: true, type: "oidc", ...okta },
@@ -111,10 +117,10 @@ describe("buildModules gating for OIDC federations (#524)", () => {
 				google: { enabled: false },
 			}),
 		).map((m) => m.name);
-		expect(names).toContain("federation:oidc:okta");
-		expect(names).toContain("federation:oidc:keycloak");
-		expect(names.filter((n) => n === "standalone:oidc-federation-config")).toHaveLength(1);
-		expect(names).not.toContain("federation:google");
+		expect(names).toContain("federation-oidc-okta");
+		expect(names).toContain("federation-oidc-keycloak");
+		expect(names.filter((n) => n === "oidc-federation-config")).toHaveLength(1);
+		expect(names).not.toContain("federation-google");
 	});
 
 	it("a google section of type oidc is the generic provider, not the built-in Google pair", () => {
@@ -123,16 +129,16 @@ describe("buildModules gating for OIDC federations (#524)", () => {
 		const names = buildModules(
 			configWith({ google: { enabled: true, type: "oidc", ...okta } }),
 		).map((m) => m.name);
-		expect(names).toContain("federation:oidc:google");
-		expect(names).not.toContain("federation:google");
-		expect(names).not.toContain("standalone:google-federation-config");
+		expect(names).toContain("federation-oidc-google");
+		expect(names).not.toContain("federation-google");
+		expect(names).not.toContain("google-federation-config");
 	});
 
 	it("lists nothing OIDC when no section is enabled (the shipped default)", () => {
 		const names = buildModules(
 			configWith({ google: { enabled: false }, oidc: { enabled: false, type: "oidc" } }),
 		).map((m) => m.name);
-		expect(names.some((n) => n.startsWith("federation:oidc:"))).toBe(false);
-		expect(names).not.toContain("standalone:oidc-federation-config");
+		expect(names.some((n) => n.startsWith("federation-oidc-"))).toBe(false);
+		expect(names).not.toContain("oidc-federation-config");
 	});
 });