@nx/react-native 19.2.0-canary.20240604-0594deb → 19.2.0-rc.0

package/src/executors/storybook/storybook.impl.ts

@@ -1,93 +0,0 @@
-import { join, relative, resolve, dirname } from 'path';
-import { ExecutorContext, logger, readJsonFile } from '@nx/devkit';
-import { fileExists } from '@nx/workspace/src/utilities/fileutils';
-import * as chalk from 'chalk';
-import { sync as globSync } from 'glob';
-
-import { ReactNativeStorybookOptions } from './schema';
-import {
-  displayNewlyAddedDepsMessage,
-  syncDeps,
-} from '../sync-deps/sync-deps.impl';
-import { writeFileSync } from 'fs-extra';
-import { PackageJson } from 'nx/src/utils/package-json';
-
-/**
- * TODO (@xiongemi): remove this function in v20.
- * @deprecated Going to use the default react storybook target. Use @nx/react:storybook executor instead.
- */
-export default async function* reactNativeStorybookExecutor(
-  options: ReactNativeStorybookOptions,
-  context: ExecutorContext
-): AsyncGenerator<{ success: boolean }> {
-  const { syncDeps: isSyncDepsEnabled = true } = options;
-
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-  logger.info(
-    `${chalk.bold.cyan(
-      'info'
-    )} To see your Storybook stories on the device, you should start your mobile app for the <platform> of your choice (typically ios or android).`
-  );
-
-  // add storybook addons to app's package.json
-  const packageJsonPath = join(context.root, projectRoot, 'package.json');
-  const workspacePackageJsonPath = join(context.root, 'package.json');
-
-  const workspacePackageJson = readJsonFile<PackageJson>(
-    workspacePackageJsonPath
-  );
-  const projectPackageJson = readJsonFile<PackageJson>(packageJsonPath);
-
-  if (isSyncDepsEnabled && fileExists(packageJsonPath))
-    displayNewlyAddedDepsMessage(
-      context.projectName,
-      await syncDeps(
-        context.projectName,
-        projectPackageJson,
-        packageJsonPath,
-        workspacePackageJson,
-        context.projectGraph,
-        [
-          `@storybook/react-native`,
-          '@storybook/addon-ondevice-actions',
-          '@storybook/addon-ondevice-backgrounds',
-          '@storybook/addon-ondevice-controls',
-          '@storybook/addon-ondevice-notes',
-          '@react-native-async-storage/async-storage',
-          'react-native-safe-area-context',
-        ]
-      )
-    );
-
-  runCliStorybook(context.root, options);
-  yield { success: true };
-}
-
-export function runCliStorybook(
-  workspaceRoot: string,
-  options: ReactNativeStorybookOptions
-) {
-  const storiesFiles: string[] = options.searchDir.flatMap((dir) => {
-    const storyFilePaths: string[] = globSync(join(dir, options.pattern));
-
-    return storyFilePaths.map((storyFilePath) => {
-      const loaderPath: string = resolve(dirname(options.outputFile));
-      return relative(loaderPath, storyFilePath);
-    });
-  });
-
-  if (storiesFiles.length === 0) {
-    logger.warn(`${chalk.bold.yellow('warn')} No stories found.`);
-  }
-
-  const newContents = `// Auto-generated file created by nx
-// DO NOT EDIT.
-export function loadStories() {
-  return [
-    ${storiesFiles.map((story) => `require('${story}')`).join(',\n')}
-  ];
-}`;
-
-  writeFileSync(join(workspaceRoot, options.outputFile), newContents);
-}

package/src/executors/sync-deps/sync-deps.impl.ts

@@ -1,140 +0,0 @@
-import { join } from 'path';
-import * as chalk from 'chalk';
-import {
-  ExecutorContext,
-  ProjectGraph,
-  logger,
-  readCachedProjectGraph,
-  readJsonFile,
-  writeJsonFile,
-} from '@nx/devkit';
-
-import { ReactNativeSyncDepsOptions } from './schema';
-import { findAllNpmDependencies } from '../../utils/find-all-npm-dependencies';
-import { PackageJson } from 'nx/src/utils/package-json';
-
-export interface ReactNativeSyncDepsOutput {
-  success: boolean;
-}
-
-export default async function* syncDepsExecutor(
-  options: ReactNativeSyncDepsOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeSyncDepsOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  const workspacePackageJsonPath = join(context.root, 'package.json');
-  const projectPackageJsonPath = join(
-    context.root,
-    projectRoot,
-    'package.json'
-  );
-
-  const workspacePackageJson = readJsonFile(workspacePackageJsonPath);
-  const projectPackageJson = readJsonFile(projectPackageJsonPath);
-  displayNewlyAddedDepsMessage(
-    context.projectName,
-    await syncDeps(
-      context.projectName,
-      projectPackageJson,
-      projectPackageJsonPath,
-      workspacePackageJson,
-      context.projectGraph,
-      typeof options.include === 'string'
-        ? options.include.split(',')
-        : options.include,
-      typeof options.exclude === 'string'
-        ? options.exclude.split(',')
-        : options.exclude,
-      options.all
-    )
-  );
-
-  yield { success: true };
-}
-
-export async function syncDeps(
-  projectName: string,
-  projectPackageJson: PackageJson,
-  projectPackageJsonPath: string,
-  workspacePackageJson: PackageJson,
-  projectGraph: ProjectGraph = readCachedProjectGraph(),
-  include: string[] = [],
-  exclude: string[] = [],
-  all: boolean = false
-): Promise<string[]> {
-  let npmDeps = all
-    ? Object.keys(workspacePackageJson.dependencies || {})
-    : findAllNpmDependencies(projectGraph, projectName);
-  let npmDevdeps = all
-    ? Object.keys(workspacePackageJson.devDependencies || {})
-    : [];
-
-  const newDeps = [];
-  let updated = false;
-
-  if (!projectPackageJson.dependencies) {
-    projectPackageJson.dependencies = {};
-    updated = true;
-  }
-
-  if (include && include.length) {
-    npmDeps.push(...include);
-  }
-  if (exclude && exclude.length) {
-    npmDeps = npmDeps.filter((dep) => !exclude.includes(dep));
-  }
-
-  if (!projectPackageJson.devDependencies) {
-    projectPackageJson.devDependencies = {};
-  }
-  if (!projectPackageJson.dependencies) {
-    projectPackageJson.dependencies = {};
-  }
-
-  npmDeps.forEach((dep) => {
-    if (
-      !projectPackageJson.dependencies[dep] &&
-      !projectPackageJson.devDependencies[dep]
-    ) {
-      projectPackageJson.dependencies[dep] = '*';
-      newDeps.push(dep);
-      updated = true;
-    }
-  });
-  npmDevdeps.forEach((dep) => {
-    if (
-      !projectPackageJson.dependencies[dep] &&
-      !projectPackageJson.devDependencies[dep]
-    ) {
-      projectPackageJson.devDependencies[dep] = '*';
-      newDeps.push(dep);
-      updated = true;
-    }
-  });
-
-  if (updated) {
-    writeJsonFile(projectPackageJsonPath, projectPackageJson);
-  }
-
-  return newDeps;
-}
-
-export function displayNewlyAddedDepsMessage(
-  projectName: string,
-  deps: string[]
-) {
-  if (deps.length > 0) {
-    logger.info(`${chalk.bold.cyan(
-      'info'
-    )} Added entries to 'package.json' for '${projectName}' (for autolink):
-  ${deps.map((d) => chalk.bold.cyan(`"${d}": "*"`)).join('\n  ')}`);
-  } else {
-    logger.info(
-      `${chalk.bold.cyan(
-        'info'
-      )} Dependencies for '${projectName}' are up to date! No changes made.`
-    );
-  }
-}

package/src/executors/upgrade/upgrade.impl.ts

@@ -1,64 +0,0 @@
-import { ExecutorContext } from '@nx/devkit';
-import { resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-
-import { UpgradeExecutorSchema } from './schema';
-
-export interface ReactNativeUpgradeOutput {
-  success: boolean;
-}
-
-/**
- * This executor is equivalent to `npx react-native upgrade`.
- * https://github.com/react-native-community/cli/blob/main/packages/cli/src/commands/upgrade/upgrade.ts
- */
-export default async function* upgradeExecutor(
-  options: UpgradeExecutorSchema,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeUpgradeOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  await runCliUpgrade(context.root, projectRoot);
-  yield { success: true };
-}
-
-export function runCliUpgrade(
-  workspaceRoot: string,
-  projectRoot: string
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['upgrade'],
-      {
-        stdio: 'inherit',
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: process.env,
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}

package/src/generators/application/application.spec.ts

@@ -1,260 +0,0 @@
-import 'nx/src/internal-testing-utils/mock-project-graph';
-
-import {
-  Tree,
-  getProjects,
-  readJson,
-  readProjectConfiguration,
-} from '@nx/devkit';
-import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
-import { Linter } from '@nx/eslint';
-import { reactNativeApplicationGenerator } from './application';
-
-describe('app', () => {
-  let appTree: Tree;
-
-  beforeEach(() => {
-    appTree = createTreeWithEmptyWorkspace();
-    appTree.write('.gitignore', '');
-  });
-
-  it('should update configuration', async () => {
-    await reactNativeApplicationGenerator(appTree, {
-      name: 'my-app',
-      displayName: 'myApp',
-      linter: Linter.EsLint,
-      e2eTestRunner: 'none',
-      install: false,
-      projectNameAndRootFormat: 'as-provided',
-      unitTestRunner: 'none',
-      bundler: 'vite',
-    });
-    const projects = getProjects(appTree);
-
-    expect(projects.get('my-app').root).toEqual('my-app');
-  });
-
-  it('should update nx.json', async () => {
-    await reactNativeApplicationGenerator(appTree, {
-      name: 'my-app',
-      displayName: 'myApp',
-      tags: 'one,two',
-      linter: Linter.EsLint,
-      e2eTestRunner: 'none',
-      install: false,
-      projectNameAndRootFormat: 'as-provided',
-      unitTestRunner: 'none',
-      bundler: 'vite',
-    });
-
-    const projectConfiguration = readProjectConfiguration(appTree, 'my-app');
-    expect(projectConfiguration).toMatchObject({
-      tags: ['one', 'two'],
-    });
-  });
-
-  it('should generate files', async () => {
-    await reactNativeApplicationGenerator(appTree, {
-      name: 'my-app',
-      displayName: 'myApp',
-      linter: Linter.EsLint,
-      e2eTestRunner: 'none',
-      install: false,
-      projectNameAndRootFormat: 'as-provided',
-      unitTestRunner: 'jest',
-      bundler: 'vite',
-    });
-    expect(appTree.exists('my-app/src/app/App.tsx')).toBeTruthy();
-    expect(appTree.exists('my-app/src/main.tsx')).toBeTruthy();
-
-    const tsconfig = readJson(appTree, 'my-app/tsconfig.json');
-    expect(tsconfig.extends).toEqual('../tsconfig.base.json');
-
-    expect(appTree.exists('my-app/.eslintrc.json')).toBe(true);
-    expect(appTree.read('my-app/jest.config.ts', 'utf-8'))
-      .toMatchInlineSnapshot(`
-      "module.exports = {
-        displayName: 'my-app',
-        preset: 'react-native',
-        resolver: '@nx/jest/plugins/resolver',
-        moduleFileExtensions: ['ts', 'js', 'html', 'tsx', 'jsx'],
-        setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
-        moduleNameMapper: {
-          '\\\\.svg$': '@nx/react-native/plugins/jest/svg-mock',
-        },
-        transform: {
-          '^.+.(js|ts|tsx)$': [
-            'babel-jest',
-            {
-              configFile: __dirname + '/.babelrc.js',
-            },
-          ],
-          '^.+.(bmp|gif|jpg|jpeg|mp4|png|psd|svg|webp)$': require.resolve(
-            'react-native/jest/assetFileTransformer.js'
-          ),
-        },
-        coverageDirectory: '../coverage/my-app',
-      };
-      "
-    `);
-  });
-
-  it('should generate targets', async () => {
-    await reactNativeApplicationGenerator(appTree, {
-      name: 'my-app',
-      displayName: 'myApp',
-      linter: Linter.EsLint,
-      e2eTestRunner: 'none',
-      install: false,
-      projectNameAndRootFormat: 'as-provided',
-      unitTestRunner: 'jest',
-      bundler: 'vite',
-    });
-
-    expect(appTree.exists('my-app/jest.config.ts')).toBeTruthy();
-  });
-
-  it('should extend from root tsconfig.json when no tsconfig.base.json', async () => {
-    appTree.rename('tsconfig.base.json', 'tsconfig.json');
-
-    await reactNativeApplicationGenerator(appTree, {
-      name: 'my-app',
-      displayName: 'myApp',
-      linter: Linter.EsLint,
-      e2eTestRunner: 'none',
-      install: false,
-      projectNameAndRootFormat: 'as-provided',
-      unitTestRunner: 'none',
-      bundler: 'vite',
-    });
-
-    const tsconfig = readJson(appTree, 'my-app/tsconfig.json');
-    expect(tsconfig.extends).toEqual('../tsconfig.json');
-  });
-
-  describe('detox', () => {
-    it('should create e2e app with directory', async () => {
-      await reactNativeApplicationGenerator(appTree, {
-        name: 'my-app',
-        directory: 'my-dir',
-        linter: Linter.EsLint,
-        e2eTestRunner: 'detox',
-        install: false,
-        projectNameAndRootFormat: 'as-provided',
-        bundler: 'vite',
-        unitTestRunner: 'none',
-      });
-
-      const projects = getProjects(appTree);
-      expect(projects.get('my-app').root).toEqual('my-dir');
-
-      expect(appTree.exists('my-dir-e2e/.detoxrc.json')).toBeTruthy();
-      const detoxrc = appTree.read('my-dir-e2e/.detoxrc.json', 'utf-8');
-      // Strip trailing commas
-      const detoxrcJson = JSON.parse(
-        detoxrc.replace(/(?<=(true|false|null|["\d}\]])\s*),(?=\s*[}\]])/g, '')
-      );
-      expect(detoxrcJson.apps).toEqual({
-        'android.debug': {
-          binaryPath:
-            '../my-dir/android/app/build/outputs/apk/debug/app-debug.apk',
-          build:
-            'cd ../my-dir/android && ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug',
-          type: 'android.apk',
-        },
-        'android.release': {
-          binaryPath:
-            '../my-dir/android/app/build/outputs/apk/release/app-release.apk',
-          build:
-            'cd ../my-dir/android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release',
-          type: 'android.apk',
-        },
-        'ios.debug': {
-          binaryPath:
-            '../my-dir/ios/build/Build/Products/Debug-iphonesimulator/MyApp.app',
-          build:
-            "cd ../my-dir/ios && xcodebuild -workspace MyApp.xcworkspace -scheme MyApp -configuration Debug -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14' -derivedDataPath ./build -quiet",
-          type: 'ios.app',
-        },
-        'ios.release': {
-          binaryPath:
-            '../my-dir/ios/build/Build/Products/Release-iphonesimulator/MyApp.app',
-          build:
-            "cd ../my-dir/ios && xcodebuild -workspace MyApp.xcworkspace -scheme MyApp -configuration Release -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14' -derivedDataPath ./build -quiet",
-          type: 'ios.app',
-        },
-      });
-    });
-
-    it('should create e2e app without directory', async () => {
-      await reactNativeApplicationGenerator(appTree, {
-        name: 'my-app',
-        linter: Linter.EsLint,
-        e2eTestRunner: 'detox',
-        install: false,
-        projectNameAndRootFormat: 'as-provided',
-        bundler: 'vite',
-        unitTestRunner: 'none',
-      });
-
-      const projects = getProjects(appTree);
-      expect(projects.get('my-app').root).toEqual('my-app');
-
-      const detoxrc = appTree.read('my-app-e2e/.detoxrc.json', 'utf-8');
-      // Strip trailing commas
-      const detoxrcJson = JSON.parse(
-        detoxrc.replace(/(?<=(true|false|null|["\d}\]])\s*),(?=\s*[}\]])/g, '')
-      );
-      expect(detoxrcJson.apps).toEqual({
-        'android.debug': {
-          binaryPath:
-            '../my-app/android/app/build/outputs/apk/debug/app-debug.apk',
-          build:
-            'cd ../my-app/android && ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug',
-          type: 'android.apk',
-        },
-        'android.release': {
-          binaryPath:
-            '../my-app/android/app/build/outputs/apk/release/app-release.apk',
-          build:
-            'cd ../my-app/android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release',
-          type: 'android.apk',
-        },
-        'ios.debug': {
-          binaryPath:
-            '../my-app/ios/build/Build/Products/Debug-iphonesimulator/MyApp.app',
-          build:
-            "cd ../my-app/ios && xcodebuild -workspace MyApp.xcworkspace -scheme MyApp -configuration Debug -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14' -derivedDataPath ./build -quiet",
-          type: 'ios.app',
-        },
-        'ios.release': {
-          binaryPath:
-            '../my-app/ios/build/Build/Products/Release-iphonesimulator/MyApp.app',
-          build:
-            "cd ../my-app/ios && xcodebuild -workspace MyApp.xcworkspace -scheme MyApp -configuration Release -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 14' -derivedDataPath ./build -quiet",
-          type: 'ios.app',
-        },
-      });
-    });
-  });
-
-  describe('--skipPackageJson', () => {
-    it('should not add or update dependencies when true', async () => {
-      const packageJsonBefore = readJson(appTree, 'package.json');
-
-      await reactNativeApplicationGenerator(appTree, {
-        name: 'my-app',
-        displayName: 'myApp',
-        linter: Linter.EsLint,
-        e2eTestRunner: 'none',
-        install: false,
-        skipPackageJson: true,
-        projectNameAndRootFormat: 'as-provided',
-        unitTestRunner: 'none',
-        bundler: 'webpack',
-      });
-
-      expect(readJson(appTree, 'package.json')).toEqual(packageJsonBefore);
-    });
-  });
-});