@nx/react-native 19.2.0-canary.20240604-0594deb → 19.2.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nx/react-native",
-  "version": "19.2.0-canary.20240604-0594deb",
+  "version": "19.2.0-rc.0",
   "private": false,
   "description": "The Nx Plugin for React Native contains generators for managing React Native applications and libraries within an Nx workspace. It provides: \n\n-Integration with libraries such as Jest, Detox, and Storybook.\n-Scaffolding for creating buildable libraries that can be published to npm.\n-Utilities for automatic workspace refactoring.",
   "keywords": [
@@ -37,13 +37,13 @@
     "node-fetch": "^2.6.7",
     "tsconfig-paths": "^4.1.2",
     "tslib": "^2.3.0",
-    "@nx/devkit": "19.2.0-canary.20240604-0594deb",
-    "@nx/jest": "19.2.0-canary.20240604-0594deb",
-    "@nx/js": "19.2.0-canary.20240604-0594deb",
-    "@nx/eslint": "19.2.0-canary.20240604-0594deb",
-    "@nx/react": "19.2.0-canary.20240604-0594deb",
-    "@nx/workspace": "19.2.0-canary.20240604-0594deb",
-    "@nrwl/react-native": "19.2.0-canary.20240604-0594deb"
+    "@nx/devkit": "19.2.0-rc.0",
+    "@nx/jest": "19.2.0-rc.0",
+    "@nx/js": "19.2.0-rc.0",
+    "@nx/eslint": "19.2.0-rc.0",
+    "@nx/react": "19.2.0-rc.0",
+    "@nx/workspace": "19.2.0-rc.0",
+    "@nrwl/react-native": "19.2.0-rc.0"
   },
   "executors": "./executors.json",
   "ng-update": {

package/plugins/plugin.js

@@ -9,7 +9,7 @@ const fs_1 = require("fs");
 const calculate_hash_for_create_nodes_1 = require("@nx/devkit/src/utils/calculate-hash-for-create-nodes");
 const cache_directory_1 = require("nx/src/utils/cache-directory");
 const config_utils_1 = require("@nx/devkit/src/utils/config-utils");
-const cachePath = (0, path_1.join)(cache_directory_1.projectGraphCacheDirectory, 'react-native.hash');
+const cachePath = (0, path_1.join)(cache_directory_1.workspaceDataDirectory, 'react-native.hash');
 const targetsCache = readTargetsCache();
 function readTargetsCache() {
     return (0, fs_1.existsSync)(cachePath) ? (0, devkit_1.readJsonFile)(cachePath) : {};

package/project.json

@@ -16,7 +16,7 @@
           },
           {
             "input": "packages/react-native/src",
-            "glob": "**/*.!(ts)",
+            "glob": "**/!(*.ts)",
             "output": "/src"
           },
           {

package/src/executors/build-android/build-android.impl.ts

@@ -1,69 +0,0 @@
-import { ExecutorContext } from '@nx/devkit';
-import { join, resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-import { ReactNativeBuildAndroidOptions } from './schema';
-import { chmodAndroidGradlewFiles } from '../../utils/chmod-android-gradle-files';
-import { getCliOptions } from '../../utils/get-cli-options';
-
-export interface ReactNativeBuildOutput {
-  success: boolean;
-}
-
-export default async function* buildAndroidExecutor(
-  options: ReactNativeBuildAndroidOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeBuildOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-  chmodAndroidGradlewFiles(join(context.root, projectRoot, 'android'));
-
-  await runCliBuild(context.root, projectRoot, options);
-  yield { success: true };
-}
-
-function runCliBuild(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeBuildAndroidOptions
-) {
-  return new Promise<ChildProcess>((res, reject) => {
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['build-android', ...createBuildAndroidOptions(options)],
-      {
-        stdio: 'inherit',
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        res(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}
-
-const startOptions = ['port', 'resetCache'];
-
-function createBuildAndroidOptions(options: ReactNativeBuildAndroidOptions) {
-  return getCliOptions<ReactNativeBuildAndroidOptions>(options, startOptions);
-}

package/src/executors/build-ios/build-ios.impl.ts

@@ -1,77 +0,0 @@
-import { ExecutorContext } from '@nx/devkit';
-import { resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-import { platform } from 'os';
-
-import { ReactNativeBuildIosOptions } from './schema';
-import { getCliOptions } from '../../utils/get-cli-options';
-
-export interface ReactNativeBuildIosOutput {
-  success: boolean;
-}
-
-export default async function* buildIosExecutor(
-  options: ReactNativeBuildIosOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeBuildIosOutput> {
-  if (platform() !== 'darwin') {
-    throw new Error(`The run-ios build requires Mac to run`);
-  }
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  await runCliBuildIOS(context.root, projectRoot, options);
-  return { success: true };
-}
-
-function runCliBuildIOS(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeBuildIosOptions
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      [
-        'build-ios',
-        ...createBuildIOSOptions(options),
-        ...(process.env.NX_VERBOSE_LOGGING === 'true' ? ['--verbose'] : []),
-      ],
-      {
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}
-
-const startOptions = ['port', 'resetCache'];
-
-function createBuildIOSOptions(options: ReactNativeBuildIosOptions) {
-  return getCliOptions<ReactNativeBuildIosOptions>(options, startOptions, [
-    'buildFolder',
-  ]);
-}

package/src/executors/bundle/bundle.impl.ts

@@ -1,77 +0,0 @@
-import { createDirectory } from '@nx/workspace/src/utilities/fileutils';
-import { names, ExecutorContext } from '@nx/devkit';
-import { dirname, join, resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-
-import { ReactNativeBundleOptions } from './schema';
-
-export interface ReactNativeBundleOutput {
-  success: boolean;
-}
-
-export default async function* bundleExecutor(
-  options: ReactNativeBundleOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeBundleOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  options.bundleOutput = join(context.root, options.bundleOutput);
-
-  createDirectory(dirname(options.bundleOutput));
-
-  await runCliBuild(context.root, projectRoot, options);
-  yield { success: true };
-}
-
-function runCliBuild(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeBundleOptions
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    const cliOptions = createBundleOptions(options);
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['bundle', ...cliOptions],
-      {
-        stdio: 'inherit',
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: process.env,
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}
-
-function createBundleOptions(options: ReactNativeBundleOptions) {
-  return Object.keys(options).reduce((acc, _k) => {
-    const v = options[_k];
-    const k = names(_k).fileName;
-    if (v === undefined) return acc;
-    acc.push(`--${k}`, v);
-    return acc;
-  }, []);
-}

package/src/executors/ensure-symlink/ensure-symlink.impl.ts

@@ -1,22 +0,0 @@
-import { ExecutorContext } from '@nx/devkit';
-import { ensureNodeModulesSymlink } from '../../utils/ensure-node-modules-symlink';
-
-export interface ReactNativeEnsureSymlinkOutput {
-  success: boolean;
-}
-
-/**
- * TODO (@xiongemi): remove this function in v20.
- * @deprecated It is no longer needed for react native 73.
- */
-export default async function* ensureSymlinkExecutor(
-  _,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeEnsureSymlinkOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  ensureNodeModulesSymlink(context.root, projectRoot);
-
-  yield { success: true };
-}

package/src/executors/pod-install/pod-install.impl.ts

@@ -1,21 +0,0 @@
-import { join } from 'path';
-import { ExecutorContext } from '@nx/devkit';
-
-import { runPodInstall } from '../../utils/pod-install-task';
-import { ReactNativePodInstallOptions } from './schema';
-
-export interface ReactNativePodInstallOutput {
-  success: boolean;
-}
-
-export default async function* podInstall(
-  options: ReactNativePodInstallOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativePodInstallOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-  const iosDirectory = join(context.root, projectRoot, 'ios');
-  await runPodInstall(iosDirectory, true, options)();
-
-  yield { success: true };
-}

package/src/executors/run-android/run-android.impl.ts

@@ -1,94 +0,0 @@
-import { ExecutorContext } from '@nx/devkit';
-import { join, resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-
-import { ReactNativeRunAndroidOptions } from './schema';
-import { runCliStart } from '../start/start.impl';
-import { chmodAndroidGradlewFiles } from '../../utils/chmod-android-gradle-files';
-import { getCliOptions } from '../../utils/get-cli-options';
-
-export interface ReactNativeRunAndroidOutput {
-  success: boolean;
-}
-
-let childProcess: ChildProcess;
-
-export default async function* runAndroidExecutor(
-  options: ReactNativeRunAndroidOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeRunAndroidOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-  chmodAndroidGradlewFiles(join(context.root, projectRoot, 'android'));
-
-  const tasks = [runCliRunAndroid(context.root, projectRoot, options)];
-
-  if (options.mode !== 'Release') {
-    tasks.push(
-      runCliStart(context.root, projectRoot, {
-        port: options.port,
-        resetCache: options.resetCache,
-        interactive: true,
-      })
-    );
-  }
-
-  await Promise.all(tasks);
-
-  yield { success: true };
-}
-
-function runCliRunAndroid(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeRunAndroidOptions
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    /**
-     * Call the react native cli with option `--no-packager`
-     * Not passing '--packager' due to cli will launch start command from the project root
-     */
-    childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['run-android', ...createRunAndroidOptions(options), '--no-packager'],
-      {
-        stdio: 'inherit',
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}
-
-const startOptions = ['port', 'resetCache'];
-
-function createRunAndroidOptions(options: ReactNativeRunAndroidOptions) {
-  return getCliOptions<ReactNativeRunAndroidOptions>(options, startOptions, [
-    'appId',
-    'appIdSuffix',
-    'deviceId',
-  ]);
-}

package/src/executors/run-ios/run-ios.impl.ts

@@ -1,92 +0,0 @@
-import { ExecutorContext, GeneratorCallback, workspaceRoot } from '@nx/devkit';
-import { resolve as pathResolve } from 'path';
-import { ChildProcess, fork } from 'child_process';
-import { platform } from 'os';
-
-import { runCliStart } from '../start/start.impl';
-import { getCliOptions } from '../../utils/get-cli-options';
-
-import { ReactNativeRunIosOptions } from './schema';
-export interface ReactNativeRunIosOutput {
-  success: boolean;
-}
-
-export default async function* runIosExecutor(
-  options: ReactNativeRunIosOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeRunIosOutput> {
-  if (platform() !== 'darwin') {
-    throw new Error(`The run-ios build requires Mac to run`);
-  }
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  const tasks = [runCliRunIOS(context.root, projectRoot, options)];
-
-  if (options.mode !== 'Release') {
-    tasks.push(
-      runCliStart(context.root, projectRoot, {
-        port: options.port,
-        resetCache: options.resetCache,
-        interactive: true,
-      })
-    );
-  }
-
-  await Promise.all(tasks);
-
-  yield { success: true };
-}
-
-function runCliRunIOS(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeRunIosOptions
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    /**
-     * Call the react native cli with option `--no-packager`
-     * Not passing '--packager' due to cli will launch start command from the project root
-     */
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['run-ios', ...createRunIOSOptions(options), '--no-packager'],
-      {
-        stdio: 'inherit',
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-      }
-    );
-
-    /**
-     * Ensure the child process is killed when the parent exits
-     */
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-  });
-}
-
-const startOptions = ['port', 'resetCache'];
-
-function createRunIOSOptions(options: ReactNativeRunIosOptions) {
-  return getCliOptions<ReactNativeRunIosOptions>(options, startOptions, [
-    'buildFolder',
-  ]);
-}

package/src/executors/start/start.impl.ts

@@ -1,111 +0,0 @@
-import { ExecutorContext, logger } from '@nx/devkit';
-import { ChildProcess, fork } from 'child_process';
-import { resolve as pathResolve } from 'path';
-import { isPackagerRunning } from './lib/is-packager-running';
-import { ReactNativeStartOptions } from './schema';
-
-export interface ReactNativeStartOutput {
-  port?: number;
-  success: boolean;
-}
-
-export default async function* startExecutor(
-  options: ReactNativeStartOptions,
-  context: ExecutorContext
-): AsyncGenerator<ReactNativeStartOutput> {
-  const projectRoot =
-    context.projectsConfigurations.projects[context.projectName].root;
-
-  await runCliStart(context.root, projectRoot, options);
-
-  yield {
-    port: options.port,
-    success: true,
-  };
-}
-
-/*
- * Starts the JS bundler and checks for "running" status before notifying
- * that packager has started.
- */
-export async function runCliStart(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeStartOptions
-): Promise<ChildProcess> {
-  const result = await isPackagerRunning(options.port);
-  if (result === 'running') {
-    logger.info(`JS server already running on port ${options.port}.`);
-  } else if (result === 'unrecognized') {
-    logger.warn('JS server not recognized.');
-  } else {
-    // result === 'not_running'
-    logger.info('Starting JS server...');
-
-    try {
-      return await startAsync(workspaceRoot, projectRoot, options);
-    } catch (error) {
-      logger.error(
-        `Failed to start the packager server. Error details: ${
-          error.message ?? error
-        }`
-      );
-      throw error;
-    }
-  }
-}
-
-function startAsync(
-  workspaceRoot: string,
-  projectRoot: string,
-  options: ReactNativeStartOptions
-): Promise<ChildProcess> {
-  return new Promise<ChildProcess>((resolve, reject) => {
-    const childProcess = fork(
-      require.resolve('react-native/cli.js'),
-      ['start', ...createStartOptions(options)],
-      {
-        cwd: pathResolve(workspaceRoot, projectRoot),
-        env: process.env,
-        stdio: 'inherit',
-      }
-    );
-
-    childProcess.on('error', (err) => {
-      reject(err);
-    });
-    childProcess.on('exit', (code) => {
-      if (code === 0) {
-        resolve(childProcess);
-      } else {
-        reject(code);
-      }
-    });
-
-    const processExitListener = (signal?: number | NodeJS.Signals) => () => {
-      childProcess.kill(signal);
-      process.exit();
-    };
-    process.once('exit', (signal) => childProcess.kill(signal));
-    process.once('SIGTERM', processExitListener);
-    process.once('SIGINT', processExitListener);
-    process.once('SIGQUIT', processExitListener);
-  });
-}
-
-function createStartOptions(options) {
-  return Object.keys(options).reduce((acc, k) => {
-    if (k === 'resetCache') {
-      if (options[k] === true) {
-        acc.push(`--reset-cache`);
-      }
-    } else if (k === 'interactive') {
-      if (options[k] === false) {
-        acc.push(`--no-interactive`);
-      }
-    } else {
-      acc.push(`--${k}`, options[k]);
-    }
-    return acc;
-  }, []);
-}