@nielspeter/eess-ts 0.2.0 → 0.4.0

package/dist/smells/inconsistent-siblings.js

@@ -1,12 +1,17 @@
-import picomatch from 'picomatch';
-import path from 'node:path';
+import { groupFilesByFolder, inertElement, inertMessage, partitionByPattern, } from './sibling-files.js';
+import { selectionMemo } from '@nielspeter/eess';
 import { SmellBuilder } from './smell-builder.js';
-import { collectFunctions } from '../models/arch-function.js';
-import { searchFunctionBody } from '../helpers/body-traversal.js';
 /** Majority threshold — flag when >= 60% of siblings match but a file doesn't. */
 const MAJORITY_THRESHOLD = 0.6;
 /** Test file patterns for ignoreTests(). */
-const TEST_PATTERNS = ['**/*.test.ts', '**/*.spec.ts', '**/__tests__/**'];
+const selectionOf = selectionMemo();
+/**
+ * 0102: diagnostic-first. N ships false (diagnose previews, check passes); the
+ * flip release sets true (check fails). Not a warn-first migration — a
+ * warning is invisible in a test run (bug 0024) and trains suppression.
+ * The N+1 flip is tracked in plan 0105.
+ */
+const INERT_FINDING_EMIT = false;
 export class InconsistentSiblingsBuilder extends SmellBuilder {
     _pattern;
     constructor(project) {
@@ -14,40 +19,98 @@ export class InconsistentSiblingsBuilder extends SmellBuilder {
     }
     /** The pattern that most siblings should follow. */
     forPattern(matcher) {
-        this._pattern = matcher;
-        return this;
-    }
-    /** Check if a source file contains any function matching the pattern. */
-    fileMatchesPattern(sf, pattern) {
-        for (const fn of collectFunctions(sf)) {
-            const body = fn.getBody();
-            if (!body)
-                continue;
-            const lineCount = body.getText().split('\n').length;
-            if (lineCount < this._minLines)
+        const next = this.copy();
+        next._pattern = matcher;
+        return next;
+    }
+    /**
+     * Sibling files in folders large enough to be compared — plan 0096, and the
+     * ONE method both readers call.
+     *
+     * The `>= 2` threshold lives HERE rather than in `detect()`'s loop, which is
+     * what makes this a shared derivation instead of two that agree by luck.
+     * Filtering before the caller's sort is safe: `groupFilesByFolder()` returns
+     * insertion order and `detect()` sorts by folder name, a total order, so
+     * removing entries cannot reorder the survivors.
+     */
+    selected() {
+        return selectionOf(this, () => [...groupFilesByFolder(this.scope()).entries()].filter(([, files]) => files.length >= 2));
+    }
+    /**
+     * Units this detector examined — plan 0096: sibling files in folders large
+     * enough to be compared.
+     *
+     * Counted in units ITERATED, never in pattern matches: a tripwire that
+     * examines every sibling and matches none has non-empty evidence, which is the
+     * 0.34.0 carve-out this must not break.
+     */
+    examinedUnits() {
+        return this.selected().reduce((total, [, files]) => total + files.length, 0);
+    }
+    /**
+     * Pure recomputation of the corpus split — never accumulated on `this`. It is
+     * the SINGLE source the finding's message, the gate, and the diagnostic preview
+     * all read, so the preview and the finding cannot diverge, and calling it twice
+     * cannot double-count (each call recomputes). Mirrors `examinedUnits()`: one
+     * derivation, not an instance field.
+     *
+     * `canFireSoon` is true when any folder is at or within ONE edit of a majority —
+     * such a folder can fire, so it is not inert even though it does not fire today.
+     *
+     * The GUARD lives here, not at the emit site. A preview read through this
+     * accessor can then never report on a rule that can fire: a healthy control
+     * (majority present, `editsToMajority <= 1`) gets `canFireSoon = true`, and the
+     * hook below returns the empty string for it. The check-time emit and the
+     * diagnostic preview share this one predicate by construction.
+     */
+    inertAssessment(pattern) {
+        let matching = 0;
+        let total = 0;
+        let canFireSoon = false;
+        const folders = [];
+        for (const [folder, files] of this.selected()) {
+            const { matching: m, nonMatching } = partitionByPattern(files, pattern, this._minLines);
+            const t = m.length + nonMatching.length;
+            // Unreachable today: selected() already filters to files.length >= 2
+            // and partitionByPattern drops nothing, so t always equals a folder's
+            // file count and is never 0 here. Kept as future-proofing against a
+            // change to selected(), not a live branch.
+            if (t === 0)
                 continue;
-            if (searchFunctionBody(fn, pattern).found)
-                return true;
-        }
-        return false;
-    }
-    /** Partition files into matching and non-matching based on the pattern. */
-    partitionByPattern(files, pattern) {
-        const matching = [];
-        const nonMatching = [];
-        for (const sf of files) {
-            if (this.fileMatchesPattern(sf, pattern)) {
-                matching.push(sf);
-            }
-            else {
-                nonMatching.push(sf);
-            }
+            matching += m.length;
+            total += t;
+            folders.push({ folder, matching: m, nonMatching });
+            // A folder at or within one edit of a majority is a live tripwire. Latched
+            // regardless of nonMatching===0: a fully-conforming majority folder is one
+            // divergent file away from firing, so it must suppress the inert finding.
+            //
+            // KNOWN LIMIT, conservative direction only (review: architect): for t=2,
+            // m=1 this reads editsToMajority = ceil(1.2) - 1 = 1 <= 1 and latches —
+            // but the only available edit (adopting the second file) yields m=2,
+            // nonMatching=0, which still cannot fire; a THIRD file would be needed.
+            // A two-file folder with one match (e.g. an index.ts plus one impl) is
+            // an ordinary shape, so this latch is reachable in practice, not a
+            // corner case. Never a false POSITIVE (a rule that can genuinely fire
+            // soon is never reported inert) — only a false latch that keeps a
+            // genuinely-inert corpus silent, and it is OR'd across every folder in
+            // scope, so one such folder anywhere suppresses the whole rule's inert
+            // finding. Not fixed here: the arithmetic is a documented approximation
+            // of "close to firing", not a precise one, and narrowing it is a
+            // separate, non-urgent piece of work.
+            const editsToMajority = Math.ceil(MAJORITY_THRESHOLD * t) - m.length;
+            if (editsToMajority <= 1)
+                canFireSoon = true;
         }
-        return { matching, nonMatching };
+        return { matching, total, canFireSoon, folders };
     }
     /** Build violations for non-matching files in a folder where the majority matches. */
-    buildFolderViolations(args) {
-        const { folder, matching, nonMatching, ruleDescription, patternDesc } = args;
+    /**
+     * The two description strings travel together as one `describe` — adjacent
+     * positional strings are the transposition the parameter cap guards against,
+     * and these two read alike.
+     */
+    buildFolderViolations(folder, matching, nonMatching, describe) {
+        const { rule: ruleDescription, pattern: patternDesc } = describe;
         const total = matching.length + nonMatching.length;
         const violations = [];
         for (const sf of nonMatching) {
@@ -58,78 +121,217 @@ export class InconsistentSiblingsBuilder extends SmellBuilder {
                 line: 1,
                 message: `${String(matching.length)} of ${String(total)} files in ${folder} use ${patternDesc}, ` +
                     `but ${sf.getBaseName()} does not`,
+                // The message states the population ("3 of 5"), which is a fact about
+                // the folder rather than about this file: adding one unrelated sibling
+                // rewrites it, and every already-accepted finding in the folder loses
+                // its identity. The finding itself is "this file, in this folder, does
+                // not follow this pattern" — that, and only that, is the identity.
+                identity: `inconsistent-sibling::${sf.getFilePath()}::${patternDesc}`,
                 because: this._reason,
             });
         }
         return violations;
     }
+    /**
+     * Whether this rule states an assertion at all — the assertion gate's question.
+     *
+     * True once a condition has been added.
+     *
+     * Overrides the `TerminalBuilder` default (`true`), whose JSDoc carries the
+     * contract and the reason this is public rather than protected.
+     */
+    assertsSomething() {
+        return this._pattern !== undefined;
+    }
+    /**
+     * Named by id or by what the detector checks — the inherited version says
+     * 'unnamed'. Uses `describe()` rather than a call-site locator for the same
+     * reason as `SliceRuleBuilder`: `explain --format agent` reads this field.
+     */
+    /**
+     * This detector counts sibling FILES, not function bodies — plan 0099.
+     *
+     * It inherited `SmellBuilder`'s noun while `examinedUnits()` sums
+     * `files.length`, so the message read "examined 0 function bodies" for a
+     * file-counting detector: the category error this plan exists to remove, in the
+     * family sitting directly under the override.
+     */
+    examinedUnitNoun() {
+        return 'sibling files';
+    }
+    /**
+     * A structural description of this rule without executing it — what `explain`
+     * prints and what the ADR/citation gates read.
+     */
+    describeRule() {
+        return {
+            ...super.describeRule(),
+            rule: this._metadata?.id ?? this.describe(),
+        };
+    }
+    /**
+     * The remedy for this builder's assertion-less state, as one string.
+     *
+     * One channel, so `diagnose()`'s advice and the finding's own message cannot
+     * disagree. Overrides `TerminalBuilder`'s generic text with wording specific to
+     * what this builder is missing.
+     */
+    assertionAdvice() {
+        return ('this detector has no pattern, so it detects nothing and can never fail. Add ' +
+            '.forPattern(...), or use smells.duplicateBodies() for patternless duplicate detection.');
+    }
+    /** The file-selection facts `sibling-files.ts` needs, stated as a value. */
+    scope() {
+        return {
+            project: this.project,
+            folders: this._folders,
+            ignorePaths: this._ignorePaths,
+            ignoreTests: this._ignoreTests,
+            minLines: this._minLines,
+            pattern: this._pattern,
+        };
+    }
     detect() {
-        if (!this._pattern)
+        // Unreachable at runtime as of 0.23.0: the assertion gate reports a
+        // patternless detector as a configuration finding before `detect()` is
+        // called (bug 0019), so `_pattern` is always set by the time we get here.
+        // The branch stays only because strict null checks need the narrowing —
+        // hence the local, which the rest of the method reads instead of the field.
+        // Do not treat it as the answer to "what happens with no pattern": the loud
+        // answer is the gate, and if this ever returns `[]` again the gate is gone.
+        const pattern = this._pattern;
+        if (!pattern)
             return [];
-        const filesByFolder = this.groupFilesByFolder();
         const ruleDescription = this.describe();
-        const patternDesc = this._pattern.description;
-        const folderEntries = [...filesByFolder.entries()];
-        if (this._groupByFolder) {
-            folderEntries.sort((a, b) => a[0].localeCompare(b[0]));
-        }
+        const patternDesc = pattern.description;
         const violations = [];
-        for (const [folder, files] of folderEntries) {
-            if (files.length < 2)
-                continue;
-            const { matching, nonMatching } = this.partitionByPattern(files, this._pattern);
+        // ONE assessment — the single partition walk. It returns the aggregate
+        // (matching/total/canFireSoon) AND the per-folder partitions; detect() uses
+        // both. Do NOT call partitionByPattern again below: the searchFunctionBody
+        // walk is the dominant cost and must run once per check().
+        const a = this.inertAssessment(pattern);
+        // Preserves groupByFolder()'s existing violation-ordering contract for
+        // THIS family (review: testing — an earlier version of this comment cited
+        // tests/integration/coverage-gaps.test.ts's "groupByFolder produces
+        // violations sorted by directory" row, which covers duplicateBodies and
+        // asserts only `.toThrow()`, not order, for either family; the real guard
+        // for inconsistentSiblings is
+        // "groupByFolder() sorts violations across folders" below). Sorting the
+        // returned folder array is O(k log k) on folder COUNT, not a second AST
+        // walk: inertAssessment()'s searchFunctionBody pass already ran once,
+        // above, and this sort touches only its already-computed output.
+        const folders = this._groupByFolder
+            ? [...a.folders].sort((x, y) => x.folder.localeCompare(y.folder))
+            : a.folders;
+        for (const { folder, matching, nonMatching } of folders) {
             const total = matching.length + nonMatching.length;
-            if (total === 0)
-                continue;
             if (matching.length / total < MAJORITY_THRESHOLD)
                 continue;
             if (nonMatching.length === 0)
                 continue;
-            violations.push(...this.buildFolderViolations({
-                folder,
-                matching,
-                nonMatching,
-                ruleDescription,
-                patternDesc,
+            violations.push(...this.buildFolderViolations(folder, matching, nonMatching, {
+                rule: ruleDescription,
+                pattern: patternDesc,
             }));
         }
+        // The adequacy floor, VERSION-GATED and SHARED-SOURCE. NOT a floor extension —
+        // the real floor fires at violations===0 && examined===0; this fires at
+        // violations===0 && examined>0 && no folder is within one edit of a majority.
+        // The guard lives in the shared advice function, not here: the emit and the
+        // diagnostic preview are the same derivation, so the preview can never report
+        // on a rule that can fire. detect() passes the assessment it ALREADY computed
+        // (no second partition walk); the empty-string return means "not inert".
+        const advice = this.inertAdviceFor(a);
+        if (violations.length === 0 && this.inertEmitEnabled() && advice !== '') {
+            return [this.inertViolation(advice), ...violations];
+        }
         return violations;
     }
+    /**
+     * The `DiagnosableRule` hook — public, no-arg, exactly the shape the
+     * interface requires. Recomputes `inertAssessment()` fresh, so `diagnose()`
+     * on a builder that never ran `check()` still gets truthful numbers.
+     */
+    inertAdvice() {
+        const pattern = this._pattern;
+        if (!pattern)
+            return '';
+        return this.inertAdviceFor(this.inertAssessment(pattern));
+    }
+    /**
+     * THE single derivation for both surfaces, and the guard. Returns the empty
+     * string unless the rule is genuinely inert (`matching > 0 && !canFireSoon &&
+     * !declaresEmpty()`), so a healthy control (majority present, within one edit
+     * of one, or declared empty) gets `''` and diagnose() reports nothing for it.
+     * Both `inertAdvice()` above and `detect()`'s emit call this with an
+     * `Assessment` — the SAME guard and the SAME message either way, so the
+     * preview and the finding cannot diverge.
+     *
+     * `!this.declaresEmpty()` lives HERE, not only in `inertEmitEnabled()` (review:
+     * architect) — a declared-empty rule reports its expiry, not the inert finding,
+     * on BOTH surfaces, so `diagnose()`'s preview and `check()`'s eventual failure
+     * name the same cause for the same rule state. Before this fix the two clauses
+     * were split across two functions and only the emit path read the declaration,
+     * so a rule carrying `.expectEmpty()` could preview one cause via `diagnose()`
+     * and fail with a different one via `check()` — the exact drift this shared-
+     * derivation design exists to make impossible "by construction".
+     */
+    inertAdviceFor(a) {
+        if (a.matching === 0 || a.canFireSoon || this.declaresEmpty())
+            return ''; // the GUARD lives here
+        return inertMessage(a, this._pattern?.description ?? 'unknown pattern');
+    }
+    inertViolation(advice) {
+        return {
+            rule: this.describe(),
+            ruleId: this._metadata?.id,
+            element: inertElement(this.scope()),
+            file: '',
+            line: 0,
+            message: advice,
+            // Its own remedy, never the author's (bug 0021): the message IS the remedy.
+            suggestion: advice,
+            because: this._reason,
+            // Adequacy finding: the rule enforces nothing, which is not a severity the
+            // author grades (ADR-009 rule 1). Config-level: no file to attribute, so it
+            // must survive diff/baseline or the guard re-greens under standard CI.
+            bypassFilters: true,
+            // No `identity` set, deliberately, NOT an oversight (review: architect
+            // flagged the gap; this is why it stays a gap): `bypassFilters: true`
+            // means baseline/diff never read one today, so setting one buys nothing
+            // yet — and `message` embeds the population count ("examined N... only
+            // M of them"), which ADR-009 rule 4 forbids putting in an identity (a
+            // count rots). If `bypassFilters` is ever relaxed for this family, an
+            // `identity` has to be added HERE, population-free, before that ships —
+            // this comment is the tripwire for that future change, not a promise
+            // the coupling is already handled.
+        };
+    }
+    /**
+     * The pure version gate — nothing else. The `_expectEmpty` precedence
+     * (`!this.declaresEmpty()`) moved into `inertAdviceFor()` above, so it applies
+     * identically to `diagnose()`'s preview and to this emit path; this function's
+     * only job is "has the N+1 release happened yet."
+     *
+     * `INERT_FINDING_EMIT` is deliberately a bare, non-exported module `const` —
+     * not an env var, constructor option, or per-project override. The
+     * `bypassFilters: true` / unsuppressable design above depends on there being
+     * no configuration surface a future contributor could "helpfully" expose,
+     * which would undermine it silently.
+     *
+     * `protected`, not `private` — a test-only subclass overrides this to exercise
+     * the emit path (`inertViolation()`, `inertElement()`, the `detect()` branch
+     * that pushes them) before the N+1 flip ships, so that path is not shipped
+     * with zero test coverage merely because the real gate is off today (review:
+     * testing). See `tests/smells/inconsistent-siblings.test.ts`'s
+     * `EmittingSiblings` subclass.
+     */
+    inertEmitEnabled() {
+        return INERT_FINDING_EMIT;
+    }
     describe() {
         const pattern = this._pattern?.description ?? 'unknown pattern';
         return `Sibling files should consistently use ${pattern}`;
     }
-    /** Group source files by parent folder, applying all filters. */
-    groupFilesByFolder() {
-        const sourceFiles = this.project.getSourceFiles();
-        const folderMatchers = this._folders.map((g) => picomatch(g));
-        const ignoreMatchers = this._ignorePaths.map((g) => picomatch(g));
-        const testMatchers = this._ignoreTests ? TEST_PATTERNS.map((g) => picomatch(g)) : [];
-        const groups = new Map();
-        for (const sf of sourceFiles) {
-            const filePath = sf.getFilePath();
-            // Folder filter: if folders specified, file must match at least one
-            if (folderMatchers.length > 0 && !folderMatchers.some((m) => m(filePath))) {
-                continue;
-            }
-            // Ignore paths filter
-            if (ignoreMatchers.some((m) => m(filePath))) {
-                continue;
-            }
-            // Test file filter
-            if (testMatchers.some((m) => m(filePath))) {
-                continue;
-            }
-            const folder = path.dirname(filePath);
-            const existing = groups.get(folder);
-            if (existing) {
-                existing.push(sf);
-            }
-            else {
-                groups.set(folder, [sf]);
-            }
-        }
-        return groups;
-    }
 }
 //# sourceMappingURL=inconsistent-siblings.js.map

package/dist/smells/inconsistent-siblings.js.map

@@ -1 +1 @@
-{"version":3,"file":"inconsistent-siblings.js","sourceRoot":"","sources":["../../src/smells/inconsistent-siblings.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,WAAW,CAAA;AACjC,OAAO,IAAI,MAAM,WAAW,CAAA;AAE5B,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AACjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,4BAA4B,CAAA;AAC7D,OAAO,EAAE,kBAAkB,EAAE,MAAM,8BAA8B,CAAA;AAKjE,kFAAkF;AAClF,MAAM,kBAAkB,GAAG,GAAG,CAAA;AAE9B,4CAA4C;AAC5C,MAAM,aAAa,GAAG,CAAC,cAAc,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAA;AAEzE,MAAM,OAAO,2BAA4B,SAAQ,YAAY;IACnD,QAAQ,CAAoB;IAEpC,YAAY,OAAoB;QAC9B,KAAK,CAAC,OAAO,CAAC,CAAA;IAChB,CAAC;IAED,oDAAoD;IACpD,UAAU,CAAC,OAA0B;QACnC,IAAI,CAAC,QAAQ,GAAG,OAAO,CAAA;QACvB,OAAO,IAAI,CAAA;IACb,CAAC;IAED,yEAAyE;IACjE,kBAAkB,CAAC,EAAc,EAAE,OAA0B;QACnE,KAAK,MAAM,EAAE,IAAI,gBAAgB,CAAC,EAAE,CAAC,EAAE,CAAC;YACtC,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAA;YACzB,IAAI,CAAC,IAAI;gBAAE,SAAQ;YAEnB,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAA;YACnD,IAAI,SAAS,GAAG,IAAI,CAAC,SAAS;gBAAE,SAAQ;YAExC,IAAI,kBAAkB,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC,KAAK;gBAAE,OAAO,IAAI,CAAA;QACxD,CAAC;QACD,OAAO,KAAK,CAAA;IACd,CAAC;IAED,2EAA2E;IACnE,kBAAkB,CACxB,KAAmB,EACnB,OAA0B;QAE1B,MAAM,QAAQ,GAAiB,EAAE,CAAA;QACjC,MAAM,WAAW,GAAiB,EAAE,CAAA;QACpC,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;YACvB,IAAI,IAAI,CAAC,kBAAkB,CAAC,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBACzC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;YACnB,CAAC;iBAAM,CAAC;gBACN,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;YACtB,CAAC;QACH,CAAC;QACD,OAAO,EAAE,QAAQ,EAAE,WAAW,EAAE,CAAA;IAClC,CAAC;IAED,sFAAsF;IAC9E,qBAAqB,CAAC,IAM7B;QACC,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE,eAAe,EAAE,WAAW,EAAE,GAAG,IAAI,CAAA;QAC5E,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,GAAG,WAAW,CAAC,MAAM,CAAA;QAClD,MAAM,UAAU,GAAoB,EAAE,CAAA;QACtC,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;YAC7B,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,eAAe;gBACrB,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE;gBACzB,IAAI,EAAE,EAAE,CAAC,WAAW,EAAE;gBACtB,IAAI,EAAE,CAAC;gBACP,OAAO,EACL,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,OAAO,MAAM,CAAC,KAAK,CAAC,aAAa,MAAM,QAAQ,WAAW,IAAI;oBACxF,OAAO,EAAE,CAAC,WAAW,EAAE,WAAW;gBACpC,OAAO,EAAE,IAAI,CAAC,OAAO;aACtB,CAAC,CAAA;QACJ,CAAC;QACD,OAAO,UAAU,CAAA;IACnB,CAAC;IAES,MAAM;QACd,IAAI,CAAC,IAAI,CAAC,QAAQ;YAAE,OAAO,EAAE,CAAA;QAE7B,MAAM,aAAa,GAAG,IAAI,CAAC,kBAAkB,EAAE,CAAA;QAC/C,MAAM,eAAe,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QACvC,MAAM,WAAW,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAA;QAE7C,MAAM,aAAa,GAAG,CAAC,GAAG,aAAa,CAAC,OAAO,EAAE,CAAC,CAAA;QAClD,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YACxB,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAA;QACxD,CAAC;QAED,MAAM,UAAU,GAAoB,EAAE,CAAA;QAEtC,KAAK,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,aAAa,EAAE,CAAC;YAC5C,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;gBAAE,SAAQ;YAE9B,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE,GAAG,IAAI,CAAC,kBAAkB,CAAC,KAAK,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAA;YAC/E,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,GAAG,WAAW,CAAC,MAAM,CAAA;YAClD,IAAI,KAAK,KAAK,CAAC;gBAAE,SAAQ;YACzB,IAAI,QAAQ,CAAC,MAAM,GAAG,KAAK,GAAG,kBAAkB;gBAAE,SAAQ;YAC1D,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC;gBAAE,SAAQ;YAEtC,UAAU,CAAC,IAAI,CACb,GAAG,IAAI,CAAC,qBAAqB,CAAC;gBAC5B,MAAM;gBACN,QAAQ;gBACR,WAAW;gBACX,eAAe;gBACf,WAAW;aACZ,CAAC,CACH,CAAA;QACH,CAAC;QAED,OAAO,UAAU,CAAA;IACnB,CAAC;IAES,QAAQ;QAChB,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,EAAE,WAAW,IAAI,iBAAiB,CAAA;QAC/D,OAAO,yCAAyC,OAAO,EAAE,CAAA;IAC3D,CAAC;IAED,iEAAiE;IACzD,kBAAkB;QACxB,MAAM,WAAW,GAAG,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,CAAA;QACjD,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QAC7D,MAAM,cAAc,GAAG,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QACjE,MAAM,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAA;QAEpF,MAAM,MAAM,GAAG,IAAI,GAAG,EAAwB,CAAA;QAE9C,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;YAC7B,MAAM,QAAQ,GAAG,EAAE,CAAC,WAAW,EAAE,CAAA;YAEjC,oEAAoE;YACpE,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBAC1E,SAAQ;YACV,CAAC;YAED,sBAAsB;YACtB,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBAC5C,SAAQ;YACV,CAAC;YAED,mBAAmB;YACnB,IAAI,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBAC1C,SAAQ;YACV,CAAC;YAED,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAA;YACrC,MAAM,QAAQ,GAAG,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,CAAA;YACnC,IAAI,QAAQ,EAAE,CAAC;gBACb,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;YACnB,CAAC;iBAAM,CAAC;gBACN,MAAM,CAAC,GAAG,CAAC,MAAM,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;YAC1B,CAAC;QACH,CAAC;QAED,OAAO,MAAM,CAAA;IACf,CAAC;CACF"}
+{"version":3,"file":"inconsistent-siblings.js","sourceRoot":"","sources":["../../src/smells/inconsistent-siblings.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,kBAAkB,EAClB,YAAY,EACZ,YAAY,EACZ,kBAAkB,GACnB,MAAM,oBAAoB,CAAA;AAI3B,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AAChD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AAKjD,kFAAkF;AAClF,MAAM,kBAAkB,GAAG,GAAG,CAAA;AAE9B,4CAA4C;AAE5C,MAAM,WAAW,GAAG,aAAa,EAA0B,CAAA;AAE3D;;;;;GAKG;AACH,MAAM,kBAAkB,GAAG,KAAK,CAAA;AAUhC,MAAM,OAAO,2BAA4B,SAAQ,YAAY;IACnD,QAAQ,CAAoB;IAEpC,YAAY,OAAoB;QAC9B,KAAK,CAAC,OAAO,CAAC,CAAA;IAChB,CAAC;IAED,oDAAoD;IACpD,UAAU,CAAC,OAA0B;QACnC,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,CAAA;QACxB,IAAI,CAAC,QAAQ,GAAG,OAAO,CAAA;QACvB,OAAO,IAAI,CAAA;IACb,CAAC;IAED;;;;;;;;;OASG;IACK,QAAQ;QACd,OAAO,WAAW,CAAC,IAAI,EAAE,GAAG,EAAE,CAC5B,CAAC,GAAG,kBAAkB,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,IAAI,CAAC,CAAC,CACzF,CAAA;IACH,CAAC;IAED;;;;;;;OAOG;IACH,aAAa;QACX,OAAO,IAAI,CAAC,QAAQ,EAAE,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,CAAC,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,KAAK,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,CAAA;IAC9E,CAAC;IAED;;;;;;;;;;;;;;;OAeG;IACK,eAAe,CAAC,OAA0B;QAChD,IAAI,QAAQ,GAAG,CAAC,CAAA;QAChB,IAAI,KAAK,GAAG,CAAC,CAAA;QACb,IAAI,WAAW,GAAG,KAAK,CAAA;QACvB,MAAM,OAAO,GAA0B,EAAE,CAAA;QACzC,KAAK,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,IAAI,CAAC,QAAQ,EAAE,EAAE,CAAC;YAC9C,MAAM,EAAE,QAAQ,EAAE,CAAC,EAAE,WAAW,EAAE,GAAG,kBAAkB,CAAC,KAAK,EAAE,OAAO,EAAE,IAAI,CAAC,SAAS,CAAC,CAAA;YACvF,MAAM,CAAC,GAAG,CAAC,CAAC,MAAM,GAAG,WAAW,CAAC,MAAM,CAAA;YACvC,qEAAqE;YACrE,sEAAsE;YACtE,oEAAoE;YACpE,2CAA2C;YAC3C,IAAI,CAAC,KAAK,CAAC;gBAAE,SAAQ;YACrB,QAAQ,IAAI,CAAC,CAAC,MAAM,CAAA;YACpB,KAAK,IAAI,CAAC,CAAA;YACV,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,EAAE,WAAW,EAAE,CAAC,CAAA;YAClD,2EAA2E;YAC3E,2EAA2E;YAC3E,0EAA0E;YAC1E,EAAE;YACF,yEAAyE;YACzE,wEAAwE;YACxE,qEAAqE;YACrE,wEAAwE;YACxE,uEAAuE;YACvE,mEAAmE;YACnE,sEAAsE;YACtE,kEAAkE;YAClE,uEAAuE;YACvE,uEAAuE;YACvE,wEAAwE;YACxE,iEAAiE;YACjE,sCAAsC;YACtC,MAAM,eAAe,GAAG,IAAI,CAAC,IAAI,CAAC,kBAAkB,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;YACpE,IAAI,eAAe,IAAI,CAAC;gBAAE,WAAW,GAAG,IAAI,CAAA;QAC9C,CAAC;QACD,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,WAAW,EAAE,OAAO,EAAE,CAAA;IAClD,CAAC;IAED,sFAAsF;IACtF;;;;OAIG;IACK,qBAAqB,CAC3B,MAAc,EACd,QAAsB,EACtB,WAAyB,EACzB,QAA2C;QAE3C,MAAM,EAAE,IAAI,EAAE,eAAe,EAAE,OAAO,EAAE,WAAW,EAAE,GAAG,QAAQ,CAAA;QAChE,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,GAAG,WAAW,CAAC,MAAM,CAAA;QAClD,MAAM,UAAU,GAAoB,EAAE,CAAA;QACtC,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;YAC7B,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,eAAe;gBACrB,OAAO,EAAE,EAAE,CAAC,WAAW,EAAE;gBACzB,IAAI,EAAE,EAAE,CAAC,WAAW,EAAE;gBACtB,IAAI,EAAE,CAAC;gBACP,OAAO,EACL,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,OAAO,MAAM,CAAC,KAAK,CAAC,aAAa,MAAM,QAAQ,WAAW,IAAI;oBACxF,OAAO,EAAE,CAAC,WAAW,EAAE,WAAW;gBACpC,sEAAsE;gBACtE,uEAAuE;gBACvE,sEAAsE;gBACtE,uEAAuE;gBACvE,mEAAmE;gBACnE,QAAQ,EAAE,yBAAyB,EAAE,CAAC,WAAW,EAAE,KAAK,WAAW,EAAE;gBACrE,OAAO,EAAE,IAAI,CAAC,OAAO;aACtB,CAAC,CAAA;QACJ,CAAC;QACD,OAAO,UAAU,CAAA;IACnB,CAAC;IAED;;;;;;;OAOG;IACM,gBAAgB;QACvB,OAAO,IAAI,CAAC,QAAQ,KAAK,SAAS,CAAA;IACpC,CAAC;IAED;;;;OAIG;IACH;;;;;;;OAOG;IACgB,gBAAgB;QACjC,OAAO,eAAe,CAAA;IACxB,CAAC;IAED;;;OAGG;IACM,YAAY;QACnB,OAAO;YACL,GAAG,KAAK,CAAC,YAAY,EAAE;YACvB,IAAI,EAAE,IAAI,CAAC,SAAS,EAAE,EAAE,IAAI,IAAI,CAAC,QAAQ,EAAE;SAC5C,CAAA;IACH,CAAC;IAED;;;;;;OAMG;IACM,eAAe;QACtB,OAAO,CACL,8EAA8E;YAC9E,wFAAwF,CACzF,CAAA;IACH,CAAC;IAED,4EAA4E;IACpE,KAAK;QACX,OAAO;YACL,OAAO,EAAE,IAAI,CAAC,OAAO;YACrB,OAAO,EAAE,IAAI,CAAC,QAAQ;YACtB,WAAW,EAAE,IAAI,CAAC,YAAY;YAC9B,WAAW,EAAE,IAAI,CAAC,YAAY;YAC9B,QAAQ,EAAE,IAAI,CAAC,SAAS;YACxB,OAAO,EAAE,IAAI,CAAC,QAAQ;SACvB,CAAA;IACH,CAAC;IAES,MAAM;QACd,oEAAoE;QACpE,uEAAuE;QACvE,0EAA0E;QAC1E,wEAAwE;QACxE,4EAA4E;QAC5E,4EAA4E;QAC5E,4EAA4E;QAC5E,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAA;QAC7B,IAAI,CAAC,OAAO;YAAE,OAAO,EAAE,CAAA;QAEvB,MAAM,eAAe,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QACvC,MAAM,WAAW,GAAG,OAAO,CAAC,WAAW,CAAA;QACvC,MAAM,UAAU,GAAoB,EAAE,CAAA;QAEtC,uEAAuE;QACvE,4EAA4E;QAC5E,2EAA2E;QAC3E,2DAA2D;QAC3D,MAAM,CAAC,GAAG,IAAI,CAAC,eAAe,CAAC,OAAO,CAAC,CAAA;QAEvC,uEAAuE;QACvE,0EAA0E;QAC1E,oEAAoE;QACpE,wEAAwE;QACxE,0EAA0E;QAC1E,8BAA8B;QAC9B,wEAAwE;QACxE,wEAAwE;QACxE,sEAAsE;QACtE,iEAAiE;QACjE,MAAM,OAAO,GAAG,IAAI,CAAC,cAAc;YACjC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;YACjE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAA;QAEb,KAAK,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE,IAAI,OAAO,EAAE,CAAC;YACxD,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,GAAG,WAAW,CAAC,MAAM,CAAA;YAClD,IAAI,QAAQ,CAAC,MAAM,GAAG,KAAK,GAAG,kBAAkB;gBAAE,SAAQ;YAC1D,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC;gBAAE,SAAQ;YAEtC,UAAU,CAAC,IAAI,CACb,GAAG,IAAI,CAAC,qBAAqB,CAAC,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE;gBAC3D,IAAI,EAAE,eAAe;gBACrB,OAAO,EAAE,WAAW;aACrB,CAAC,CACH,CAAA;QACH,CAAC;QAED,+EAA+E;QAC/E,wEAAwE;QACxE,8EAA8E;QAC9E,4EAA4E;QAC5E,8EAA8E;QAC9E,8EAA8E;QAC9E,yEAAyE;QACzE,MAAM,MAAM,GAAG,IAAI,CAAC,cAAc,CAAC,CAAC,CAAC,CAAA;QACrC,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,gBAAgB,EAAE,IAAI,MAAM,KAAK,EAAE,EAAE,CAAC;YACxE,OAAO,CAAC,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,EAAE,GAAG,UAAU,CAAC,CAAA;QACrD,CAAC;QACD,OAAO,UAAU,CAAA;IACnB,CAAC;IAED;;;;OAIG;IACH,WAAW;QACT,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAA;QAC7B,IAAI,CAAC,OAAO;YAAE,OAAO,EAAE,CAAA;QACvB,OAAO,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,eAAe,CAAC,OAAO,CAAC,CAAC,CAAA;IAC3D,CAAC;IAED;;;;;;;;;;;;;;;;;OAiBG;IACK,cAAc,CAAC,CAAa;QAClC,IAAI,CAAC,CAAC,QAAQ,KAAK,CAAC,IAAI,CAAC,CAAC,WAAW,IAAI,IAAI,CAAC,aAAa,EAAE;YAAE,OAAO,EAAE,CAAA,CAAC,uBAAuB;QAChG,OAAO,YAAY,CAAC,CAAC,EAAE,IAAI,CAAC,QAAQ,EAAE,WAAW,IAAI,iBAAiB,CAAC,CAAA;IACzE,CAAC;IAEO,cAAc,CAAC,MAAc;QACnC,OAAO;YACL,IAAI,EAAE,IAAI,CAAC,QAAQ,EAAE;YACrB,MAAM,EAAE,IAAI,CAAC,SAAS,EAAE,EAAE;YAC1B,OAAO,EAAE,YAAY,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC;YACnC,IAAI,EAAE,EAAE;YACR,IAAI,EAAE,CAAC;YACP,OAAO,EAAE,MAAM;YACf,4EAA4E;YAC5E,UAAU,EAAE,MAAM;YAClB,OAAO,EAAE,IAAI,CAAC,OAAO;YACrB,2EAA2E;YAC3E,4EAA4E;YAC5E,uEAAuE;YACvE,aAAa,EAAE,IAAI;YACnB,uEAAuE;YACvE,sEAAsE;YACtE,wEAAwE;YACxE,uEAAuE;YACvE,sEAAsE;YACtE,sEAAsE;YACtE,wEAAwE;YACxE,qEAAqE;YACrE,mCAAmC;SACpC,CAAA;IACH,CAAC;IAED;;;;;;;;;;;;;;;;;;OAkBG;IACO,gBAAgB;QACxB,OAAO,kBAAkB,CAAA;IAC3B,CAAC;IAES,QAAQ;QAChB,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,EAAE,WAAW,IAAI,iBAAiB,CAAA;QAC/D,OAAO,yCAAyC,OAAO,EAAE,CAAA;IAC3D,CAAC;CACF"}

package/dist/smells/sibling-files.d.ts

@@ -0,0 +1,47 @@
+import type { SourceFile } from 'ts-morph';
+import type { ArchProject } from '../core/project.js';
+import type { ExpressionMatcher } from '../helpers/matchers.js';
+/**
+ * Which files the sibling detector looks at, and how they are grouped.
+ *
+ * Separated from the builder because selecting and grouping files is not
+ * detecting inconsistency — the builder collects a fluent configuration and
+ * hands it here. The scope arrives as a value rather than being read off a
+ * builder, so the grouping is callable and testable without one.
+ */
+export interface SiblingScope {
+    readonly project: ArchProject;
+    readonly folders: readonly string[];
+    readonly ignorePaths: readonly string[];
+    readonly ignoreTests: boolean;
+    readonly minLines: number;
+    readonly pattern: ExpressionMatcher | undefined;
+}
+/** Partition files into matching and non-matching based on the pattern. */
+export declare function partitionByPattern(files: SourceFile[], pattern: ExpressionMatcher, minLines: number): {
+    matching: SourceFile[];
+    nonMatching: SourceFile[];
+};
+/** Group source files by parent folder, applying all filters. */
+export declare function groupFilesByFolder(scope: SiblingScope): Map<string, SourceFile[]>;
+/** Single source of the inert message. Pure — takes the assessment, returns text. */
+export declare function inertMessage(a: {
+    matching: number;
+    total: number;
+}, patternDesc: string): string;
+/**
+ * Dedupe key for the inert finding. `dedupeConfigFindings` keys on
+ * `${file} ${ruleId ?? rule} ${element}`; `file` is always `''` here and
+ * `rule`/`ruleId` fall back to `describe()`, which is scope-blind (reads
+ * `_pattern` only). So without a scope-aware `element`, two same-pattern/
+ * different-scope inert detectors with no explicit `.rule({id})` would
+ * collapse into one finding under `checkAll`.
+ *
+ * Folds in every field `groupFilesByFolder()`/`fileMatchesPattern()` read to
+ * decide what's examined — `_folders`, `_ignorePaths`, `_ignoreTests`,
+ * `_minLines` — sorted so option order cannot split one semantic scope into
+ * two keys. Two rules with identical scope correctly collapse to one finding
+ * (one edit fixes both); two rules differing in ANY of these stay distinct.
+ */
+export declare function inertElement(scope: SiblingScope): string;
+//# sourceMappingURL=sibling-files.d.ts.map

package/dist/smells/sibling-files.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"sibling-files.d.ts","sourceRoot":"","sources":["../../src/smells/sibling-files.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAE1C,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AACrD,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAA;AAO/D;;;;;;;GAOG;AACH,MAAM,WAAW,YAAY;IAC3B,QAAQ,CAAC,OAAO,EAAE,WAAW,CAAA;IAC7B,QAAQ,CAAC,OAAO,EAAE,SAAS,MAAM,EAAE,CAAA;IACnC,QAAQ,CAAC,WAAW,EAAE,SAAS,MAAM,EAAE,CAAA;IACvC,QAAQ,CAAC,WAAW,EAAE,OAAO,CAAA;IAC7B,QAAQ,CAAC,QAAQ,EAAE,MAAM,CAAA;IACzB,QAAQ,CAAC,OAAO,EAAE,iBAAiB,GAAG,SAAS,CAAA;CAChD;AAsBD,2EAA2E;AAC3E,wBAAgB,kBAAkB,CAChC,KAAK,EAAE,UAAU,EAAE,EACnB,OAAO,EAAE,iBAAiB,EAC1B,QAAQ,EAAE,MAAM,GACf;IAAE,QAAQ,EAAE,UAAU,EAAE,CAAC;IAAC,WAAW,EAAE,UAAU,EAAE,CAAA;CAAE,CAWvD;AAED,iEAAiE;AACjE,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,YAAY,GAAG,GAAG,CAAC,MAAM,EAAE,UAAU,EAAE,CAAC,CAoCjF;AAED,qFAAqF;AACrF,wBAAgB,YAAY,CAAC,CAAC,EAAE;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,EAAE,WAAW,EAAE,MAAM,GAAG,MAAM,CAWhG;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,YAAY,GAAG,MAAM,CAKxD"}

package/dist/smells/sibling-files.js

@@ -0,0 +1,104 @@
+import path from 'node:path';
+import picomatch from 'picomatch';
+import { collectFunctions } from '../models/arch-function.js';
+import { searchFunctionBody } from '../helpers/body-traversal.js';
+/** Paths treated as tests when `.ignoreTests()` is on. */
+const TEST_PATTERNS = ['**/*.test.ts', '**/*.spec.ts', '**/__tests__/**'];
+/** Check if a source file contains any function matching the pattern. */
+function fileMatchesPattern(sf, pattern, minLines) {
+    // Detectors scan for a property of the code, not a user-declared subject
+    // set, so they always include object-literal functions. `functions()`
+    // keeps that opt-in because widening a selector silently changes every
+    // existing rule; a detector has no such contract to break, and a
+    // duplicated arrow under an object key — a resolver, a route handler, a
+    // reducer case — is exactly the copy-paste rot this exists to find.
+    for (const fn of collectFunctions(sf, { includeObjectLiteralFunctions: true })) {
+        const body = fn.getBody();
+        if (!body)
+            continue;
+        const lineCount = body.getText().split('\n').length;
+        if (lineCount < minLines)
+            continue;
+        if (searchFunctionBody(fn, pattern).found)
+            return true;
+    }
+    return false;
+}
+/** Partition files into matching and non-matching based on the pattern. */
+export function partitionByPattern(files, pattern, minLines) {
+    const matching = [];
+    const nonMatching = [];
+    for (const sf of files) {
+        if (fileMatchesPattern(sf, pattern, minLines)) {
+            matching.push(sf);
+        }
+        else {
+            nonMatching.push(sf);
+        }
+    }
+    return { matching, nonMatching };
+}
+/** Group source files by parent folder, applying all filters. */
+export function groupFilesByFolder(scope) {
+    const sourceFiles = scope.project.getSourceFiles();
+    const folderMatchers = scope.folders.map((g) => picomatch(g));
+    const ignoreMatchers = scope.ignorePaths.map((g) => picomatch(g));
+    const testMatchers = scope.ignoreTests ? TEST_PATTERNS.map((g) => picomatch(g)) : [];
+    const groups = new Map();
+    for (const sf of sourceFiles) {
+        const filePath = sf.getFilePath();
+        // Folder filter: if folders specified, file must match at least one
+        if (folderMatchers.length > 0 && !folderMatchers.some((m) => m(filePath))) {
+            continue;
+        }
+        // Ignore paths filter
+        if (ignoreMatchers.some((m) => m(filePath))) {
+            continue;
+        }
+        // Test file filter
+        if (testMatchers.some((m) => m(filePath))) {
+            continue;
+        }
+        const folder = path.dirname(filePath);
+        const existing = groups.get(folder);
+        if (existing) {
+            existing.push(sf);
+        }
+        else {
+            groups.set(folder, [sf]);
+        }
+    }
+    return groups;
+}
+/** Single source of the inert message. Pure — takes the assessment, returns text. */
+export function inertMessage(a, patternDesc) {
+    return (`This detector examined ${String(a.total)} sibling files, but only ${String(a.matching)} of them ` +
+        `hold the pattern '${patternDesc}', and no folder is within an edit of a majority — so as written it ` +
+        `cannot produce a finding today. It reports a file that diverges from what its siblings do; with no ` +
+        `majority reachable by adopting files, there is no divergence to report. ` +
+        `If this rule asserts a convention the codebase is still adopting, replace it with ` +
+        `crossProject().side(...).beComplete(), which fails the day a file falls short — until adoption is ` +
+        `complete, so expect that red. If the intent is to police divergence rather than the convention itself, ` +
+        `widen the folder so a majority forms, or choose a pattern the sibling files already share.`);
+}
+/**
+ * Dedupe key for the inert finding. `dedupeConfigFindings` keys on
+ * `${file} ${ruleId ?? rule} ${element}`; `file` is always `''` here and
+ * `rule`/`ruleId` fall back to `describe()`, which is scope-blind (reads
+ * `_pattern` only). So without a scope-aware `element`, two same-pattern/
+ * different-scope inert detectors with no explicit `.rule({id})` would
+ * collapse into one finding under `checkAll`.
+ *
+ * Folds in every field `groupFilesByFolder()`/`fileMatchesPattern()` read to
+ * decide what's examined — `_folders`, `_ignorePaths`, `_ignoreTests`,
+ * `_minLines` — sorted so option order cannot split one semantic scope into
+ * two keys. Two rules with identical scope correctly collapse to one finding
+ * (one edit fixes both); two rules differing in ANY of these stay distinct.
+ */
+export function inertElement(scope) {
+    const patternDesc = scope.pattern?.description ?? 'unknown pattern';
+    const folders = [...scope.folders].sort().join('|');
+    const ignorePaths = [...scope.ignorePaths].sort().join('|');
+    return `inert:${patternDesc}:${folders}:${ignorePaths}:${String(scope.ignoreTests)}:${String(scope.minLines)}`;
+}
+//# sourceMappingURL=sibling-files.js.map

package/dist/smells/sibling-files.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"sibling-files.js","sourceRoot":"","sources":["../../src/smells/sibling-files.ts"],"names":[],"mappings":"AAAA,OAAO,IAAI,MAAM,WAAW,CAAA;AAE5B,OAAO,SAAS,MAAM,WAAW,CAAA;AAGjC,OAAO,EAAE,gBAAgB,EAAE,MAAM,4BAA4B,CAAA;AAC7D,OAAO,EAAE,kBAAkB,EAAE,MAAM,8BAA8B,CAAA;AAEjE,0DAA0D;AAC1D,MAAM,aAAa,GAAG,CAAC,cAAc,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAA;AAmBzE,yEAAyE;AACzE,SAAS,kBAAkB,CAAC,EAAc,EAAE,OAA0B,EAAE,QAAgB;IACtF,yEAAyE;IACzE,sEAAsE;IACtE,uEAAuE;IACvE,iEAAiE;IACjE,wEAAwE;IACxE,oEAAoE;IACpE,KAAK,MAAM,EAAE,IAAI,gBAAgB,CAAC,EAAE,EAAE,EAAE,6BAA6B,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;QAC/E,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAA;QACzB,IAAI,CAAC,IAAI;YAAE,SAAQ;QAEnB,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAA;QACnD,IAAI,SAAS,GAAG,QAAQ;YAAE,SAAQ;QAElC,IAAI,kBAAkB,CAAC,EAAE,EAAE,OAAO,CAAC,CAAC,KAAK;YAAE,OAAO,IAAI,CAAA;IACxD,CAAC;IACD,OAAO,KAAK,CAAA;AACd,CAAC;AAED,2EAA2E;AAC3E,MAAM,UAAU,kBAAkB,CAChC,KAAmB,EACnB,OAA0B,EAC1B,QAAgB;IAEhB,MAAM,QAAQ,GAAiB,EAAE,CAAA;IACjC,MAAM,WAAW,GAAiB,EAAE,CAAA;IACpC,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;QACvB,IAAI,kBAAkB,CAAC,EAAE,EAAE,OAAO,EAAE,QAAQ,CAAC,EAAE,CAAC;YAC9C,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACnB,CAAC;aAAM,CAAC;YACN,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACtB,CAAC;IACH,CAAC;IACD,OAAO,EAAE,QAAQ,EAAE,WAAW,EAAE,CAAA;AAClC,CAAC;AAED,iEAAiE;AACjE,MAAM,UAAU,kBAAkB,CAAC,KAAmB;IACpD,MAAM,WAAW,GAAG,KAAK,CAAC,OAAO,CAAC,cAAc,EAAE,CAAA;IAClD,MAAM,cAAc,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;IAC7D,MAAM,cAAc,GAAG,KAAK,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;IACjE,MAAM,YAAY,GAAG,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAA;IAEpF,MAAM,MAAM,GAAG,IAAI,GAAG,EAAwB,CAAA;IAE9C,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;QAC7B,MAAM,QAAQ,GAAG,EAAE,CAAC,WAAW,EAAE,CAAA;QAEjC,oEAAoE;QACpE,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;YAC1E,SAAQ;QACV,CAAC;QAED,sBAAsB;QACtB,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;YAC5C,SAAQ;QACV,CAAC;QAED,mBAAmB;QACnB,IAAI,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;YAC1C,SAAQ;QACV,CAAC;QAED,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAA;QACrC,MAAM,QAAQ,GAAG,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC,CAAA;QACnC,IAAI,QAAQ,EAAE,CAAC;YACb,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACnB,CAAC;aAAM,CAAC;YACN,MAAM,CAAC,GAAG,CAAC,MAAM,EAAE,CAAC,EAAE,CAAC,CAAC,CAAA;QAC1B,CAAC;IACH,CAAC;IAED,OAAO,MAAM,CAAA;AACf,CAAC;AAED,qFAAqF;AACrF,MAAM,UAAU,YAAY,CAAC,CAAsC,EAAE,WAAmB;IACtF,OAAO,CACL,0BAA0B,MAAM,CAAC,CAAC,CAAC,KAAK,CAAC,4BAA4B,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,WAAW;QAClG,qBAAqB,WAAW,sEAAsE;QACtG,qGAAqG;QACrG,0EAA0E;QAC1E,oFAAoF;QACpF,oGAAoG;QACpG,yGAAyG;QACzG,4FAA4F,CAC7F,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,YAAY,CAAC,KAAmB;IAC9C,MAAM,WAAW,GAAG,KAAK,CAAC,OAAO,EAAE,WAAW,IAAI,iBAAiB,CAAA;IACnE,MAAM,OAAO,GAAG,CAAC,GAAG,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IACnD,MAAM,WAAW,GAAG,CAAC,GAAG,KAAK,CAAC,WAAW,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IAC3D,OAAO,SAAS,WAAW,IAAI,OAAO,IAAI,WAAW,IAAI,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAA;AAChH,CAAC"}