@nielspeter/eess-ts 0.2.0 → 0.4.0

package/dist/smells/duplicate-bodies.js

@@ -1,37 +1,101 @@
 import picomatch from 'picomatch';
 import path from 'node:path';
+import { selectionMemo } from '@nielspeter/eess';
 import { SmellBuilder } from './smell-builder.js';
 import { collectFunctions } from '../models/arch-function.js';
-import { buildFingerprint, computeSimilarity } from './fingerprint.js';
+import { fingerprintAll, findSimilarPairs } from './similar-pairs.js';
+import { relativeToRoot } from '../core/project-relative.js';
 /** Test file patterns for ignoreTests(). */
 const TEST_PATTERNS = ['**/*.test.ts', '**/*.spec.ts', '**/__tests__/**'];
+const selectionOf = selectionMemo();
 export class DuplicateBodiesBuilder extends SmellBuilder {
     _minSimilarity = 0.85;
+    _minDistinctVocabulary = 8;
     constructor(project) {
         super(project);
     }
     /** Set the AST similarity threshold. Default: 0.85. */
     withMinSimilarity(threshold) {
-        this._minSimilarity = threshold;
-        return this;
+        const next = this.copy();
+        next._minSimilarity = threshold;
+        return next;
+    }
+    /**
+     * Minimum count of distinct identifier/literal text either body must carry
+     * before a pair is even compared — not raw line count, and not similarity.
+     * Two bodies can share a syntactic shape for no reason other than the shape
+     * being mandated (a wither, a getter, a boilerplate skeleton); below this
+     * threshold a "match" carries no information about what the code actually
+     * does. Default: 8 — see plan 0103's Phase 0 triage for how it was chosen.
+     * Tune down for a codebase with terser naming than this default assumes;
+     * tune up if short, low-vocabulary bodies keep surfacing as noise.
+     */
+    minDistinctVocabulary(n) {
+        const next = this.copy();
+        next._minDistinctVocabulary = n;
+        return next;
+    }
+    /**
+     * Named by id or by what the detector checks — the inherited version returns
+     * the sentinel `'unnamed'`, and `inconsistent-siblings.ts` already carries this
+     * override for that reason.
+     *
+     * It became load-bearing in plan 0099: the floor makes an over-filtered
+     * detector FAIL, and `dedupeConfigFindings` keys on `(file, ruleId ?? rule,
+     * element)`. With `file: ''` and `'unnamed'` in both other slots, three
+     * genuinely different detectors — different similarity, different
+     * `ignorePaths` — collapsed into one finding claiming they were "one option"
+     * and "one edit". Two were silently discarded and the survivor said
+     * `Rule: unnamed`.
+     */
+    describeRule() {
+        return {
+            ...super.describeRule(),
+            rule: this._metadata?.id ?? this.describe(),
+        };
     }
     detect() {
-        const functions = this.collectFilteredFunctions();
-        const fingerprinted = this.fingerprintAll(functions);
-        const pairs = this.findSimilarPairs(fingerprinted);
+        const functions = this.selected();
+        const fingerprinted = fingerprintAll(functions);
+        const pairs = findSimilarPairs(fingerprinted, this._minSimilarity, this._minDistinctVocabulary);
         return this.buildViolations(pairs);
     }
     describe() {
         const scope = this._folders.length > 0 ? this._folders.join(', ') : 'all files';
-        return `No duplicate function bodies in ${scope} (similarity >= ${String(this._minSimilarity)})`;
+        // EVERY narrowing that distinguishes two instances, not just similarity.
+        //
+        // This is the `Rule:` line a reader sees, and since plan 0099 it is also the
+        // dedupe identity for a detector with no `.rule({ id })`. Rendering only
+        // folders and similarity meant three detectors differing in `minLines` shared
+        // one key: measured, 3 findings collapsed to 1 claiming they were "one edit",
+        // and fixing the surviving threshold left the other two dead and green.
+        const filters = [
+            `minLines >= ${String(this._minLines)}`,
+            `minDistinctVocabulary >= ${String(this._minDistinctVocabulary)}`,
+        ];
+        if (this._ignorePaths.length > 0)
+            filters.push(`ignoring ${this._ignorePaths.join(', ')}`);
+        if (this._ignoreTests)
+            filters.push('ignoring tests');
+        return (`No duplicate function bodies in ${scope} ` +
+            `(similarity >= ${String(this._minSimilarity)}, ${filters.join(', ')})`);
     }
     /** Check if a file path passes all glob-based filters. */
-    passesFileFilters(filePath, folderMatchers, ignoreMatchers, testMatchers) {
-        if (folderMatchers.length > 0 && !folderMatchers.some((m) => m(filePath)))
+    /**
+     * The three matcher sets travel together as one `filters` — they are one
+     * configuration, and four positional `picomatch.Matcher[]` arguments in a row
+     * are exactly the transposition risk the parameter cap exists to prevent.
+     */
+    passesFileFilters(filePath, filters, fromRoot) {
+        const { folderMatchers, ignoreMatchers, testMatchers } = filters;
+        // Both forms, for every set — bug 0036. A project-relative `inFolder()` or
+        // `ignorePaths()` glob could never match an absolute path.
+        const hits = (ms) => ms.some((m) => m(filePath)) || (fromRoot !== undefined && ms.some((m) => m(fromRoot)));
+        if (folderMatchers.length > 0 && !hits(folderMatchers))
             return false;
-        if (ignoreMatchers.some((m) => m(filePath)))
+        if (hits(ignoreMatchers))
             return false;
-        if (testMatchers.some((m) => m(filePath)))
+        if (hits(testMatchers))
             return false;
         return true;
     }
@@ -44,6 +108,27 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
         return lineCount >= this._minLines;
     }
     /** Collect all functions matching folder/path/test filters. */
+    /**
+     * Bodies entering pairwise comparison — plan 0096, and the ONE method both
+     * readers call.
+     *
+     * The seam is AFTER `minLines` and the path filters: a project can load 300
+     * files while every body sits under the threshold, and the count that notices
+     * has to be taken where the comparison receives its input, not where the files
+     * were read.
+     *
+     * No fingerprinting to count. `meetsMinLines` already returns false for a
+     * bodyless function, so `fingerprintAll(xs).length === xs.length` **always** —
+     * fingerprinting to answer "is it zero" is a full AST pass of dead work on
+     * what becomes the hot path of every consumer's `diagnose()` call.
+     */
+    selected() {
+        return selectionOf(this, () => this.collectFilteredFunctions());
+    }
+    /** Units this detector examined — plan 0096. */
+    examinedUnits() {
+        return this.selected().length;
+    }
     collectFilteredFunctions() {
         const sourceFiles = this.project.getSourceFiles();
         const folderMatchers = this._folders.map((g) => picomatch(g));
@@ -51,10 +136,16 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
         const testMatchers = this._ignoreTests ? TEST_PATTERNS.map((g) => picomatch(g)) : [];
         const allFunctions = [];
         for (const sf of sourceFiles) {
-            if (!this.passesFileFilters(sf.getFilePath(), folderMatchers, ignoreMatchers, testMatchers)) {
+            if (!this.passesFileFilters(sf.getFilePath(), { folderMatchers, ignoreMatchers, testMatchers }, relativeToRoot(sf, sf.getFilePath(), this.project.tsConfigPath))) {
                 continue;
             }
-            for (const fn of collectFunctions(sf)) {
+            // Detectors scan for a property of the code, not a user-declared subject
+            // set, so they always include object-literal functions. `functions()`
+            // keeps that opt-in because widening a selector silently changes every
+            // existing rule; a detector has no such contract to break, and a
+            // duplicated arrow under an object key — a resolver, a route handler, a
+            // reducer case — is exactly the copy-paste rot this exists to find.
+            for (const fn of collectFunctions(sf, { includeObjectLiteralFunctions: true })) {
                 if (this.meetsMinLines(fn)) {
                     allFunctions.push(fn);
                 }
@@ -62,53 +153,27 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
         }
         return allFunctions;
     }
-    /** Build fingerprints for all collected functions. */
-    fingerprintAll(functions) {
-        const result = [];
-        for (const fn of functions) {
-            const body = fn.getBody();
-            if (!body)
-                continue;
-            result.push({ fn, fingerprint: buildFingerprint(body) });
-        }
-        return result;
-    }
-    /** Compare all pairs of fingerprints, collect those above threshold. */
-    findSimilarPairs(items) {
-        const pairs = [];
-        for (let i = 0; i < items.length; i++) {
-            for (let j = i + 1; j < items.length; j++) {
-                const a = items[i];
-                const b = items[j];
-                if (!a || !b)
-                    continue;
-                // Fast rejection: if node counts differ too much, similarity cannot reach threshold
-                const maxCount = Math.max(a.fingerprint.nodeCount, b.fingerprint.nodeCount);
-                const minCount = Math.min(a.fingerprint.nodeCount, b.fingerprint.nodeCount);
-                if (maxCount > 0 && minCount / maxCount < this._minSimilarity) {
-                    continue;
-                }
-                const similarity = computeSimilarity(a.fingerprint, b.fingerprint);
-                if (similarity >= this._minSimilarity) {
-                    pairs.push({ a: a.fn, b: b.fn, similarity });
-                }
-            }
-        }
-        return pairs;
-    }
     /** Build violations from similar pairs. */
+    /**
+     * Report order: by folder when `.groupByFolder()` asked for it, otherwise the
+     * order the pairs were found in.
+     *
+     * Extracted from {@link buildViolations} so that method is the violation
+     * shape and nothing else — presentation order is a separate decision.
+     */
+    orderedPairs(pairs) {
+        if (!this._groupByFolder)
+            return pairs;
+        return [...pairs].sort((x, y) => {
+            const folderA = path.dirname(x.a.getSourceFile().getFilePath());
+            const folderB = path.dirname(y.a.getSourceFile().getFilePath());
+            return folderA.localeCompare(folderB);
+        });
+    }
     buildViolations(pairs) {
         const ruleDescription = this.describe();
         const violations = [];
-        // Optionally sort pairs by folder for grouped output
-        const sortedPairs = this._groupByFolder
-            ? [...pairs].sort((x, y) => {
-                const folderA = path.dirname(x.a.getSourceFile().getFilePath());
-                const folderB = path.dirname(y.a.getSourceFile().getFilePath());
-                return folderA.localeCompare(folderB);
-            })
-            : pairs;
-        for (const pair of sortedPairs) {
+        for (const pair of this.orderedPairs(pairs)) {
             const nameA = pair.a.getName() ?? '<anonymous>';
             const fileA = pair.a.getSourceFile().getFilePath();
             const lineA = pair.a.getStartLineNumber();
@@ -122,6 +187,22 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
                 file: fileA,
                 line: lineA,
                 message: `${nameA} (${fileA}:${String(lineA)}) is ${String(pct)}% similar to ${nameB} (${fileB}:${String(lineB)})`,
+                // Which endpoint is "a" comes from the source-file walk order, which is
+                // a property of the filesystem: the same pair reports A→B on one
+                // machine and B→A on another, and the reported message alone would
+                // give them different identities. Sort the endpoints so the pair reads
+                // the same either way. Qualified by path — a bare function name is not
+                // unique across files — and without the similarity percentage, which
+                // drifts as either body is edited.
+                //
+                // Limitation: two anonymous functions in one file share an endpoint
+                // (`<file>#<anonymous>`) and so share an identity. Nothing stable
+                // distinguishes them — a line number would, and that is the coordinate
+                // dependence being removed. Measured at 0 collisions over 1006 findings
+                // on a real codebase; the collision guard in
+                // `tests/integration/baseline-portability.test.ts` is what would catch
+                // it becoming common.
+                identity: `duplicate-pair::${[`${fileA}#${nameA}`, `${fileB}#${nameB}`].sort().join('::')}`,
                 because: this._reason,
             });
         }

package/dist/smells/duplicate-bodies.js.map

@@ -1 +1 @@
-{"version":3,"file":"duplicate-bodies.js","sourceRoot":"","sources":["../../src/smells/duplicate-bodies.ts"],"names":[],"mappings":"AAAA,OAAO,SAAS,MAAM,WAAW,CAAA;AACjC,OAAO,IAAI,MAAM,WAAW,CAAA;AAC5B,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AACjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,4BAA4B,CAAA;AAC7D,OAAO,EAAE,gBAAgB,EAAE,iBAAiB,EAAE,MAAM,kBAAkB,CAAA;AAYtE,4CAA4C;AAC5C,MAAM,aAAa,GAAG,CAAC,cAAc,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAA;AAEzE,MAAM,OAAO,sBAAuB,SAAQ,YAAY;IAC9C,cAAc,GAAG,IAAI,CAAA;IAE7B,YAAY,OAAoB;QAC9B,KAAK,CAAC,OAAO,CAAC,CAAA;IAChB,CAAC;IAED,uDAAuD;IACvD,iBAAiB,CAAC,SAAiB;QACjC,IAAI,CAAC,cAAc,GAAG,SAAS,CAAA;QAC/B,OAAO,IAAI,CAAA;IACb,CAAC;IAES,MAAM;QACd,MAAM,SAAS,GAAG,IAAI,CAAC,wBAAwB,EAAE,CAAA;QACjD,MAAM,aAAa,GAAG,IAAI,CAAC,cAAc,CAAC,SAAS,CAAC,CAAA;QACpD,MAAM,KAAK,GAAG,IAAI,CAAC,gBAAgB,CAAC,aAAa,CAAC,CAAA;QAClD,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,CAAA;IACpC,CAAC;IAES,QAAQ;QAChB,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,CAAA;QAC/E,OAAO,mCAAmC,KAAK,mBAAmB,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,GAAG,CAAA;IAClG,CAAC;IAED,0DAA0D;IAClD,iBAAiB,CACvB,QAAgB,EAChB,cAAmC,EACnC,cAAmC,EACnC,YAAiC;QAEjC,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;YAAE,OAAO,KAAK,CAAA;QACvF,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;YAAE,OAAO,KAAK,CAAA;QACzD,IAAI,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;YAAE,OAAO,KAAK,CAAA;QACvD,OAAO,IAAI,CAAA;IACb,CAAC;IAED,6DAA6D;IACrD,aAAa,CAAC,EAAgB;QACpC,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAA;QACzB,IAAI,CAAC,IAAI;YAAE,OAAO,KAAK,CAAA;QACvB,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAA;QACnD,OAAO,SAAS,IAAI,IAAI,CAAC,SAAS,CAAA;IACpC,CAAC;IAED,+DAA+D;IACvD,wBAAwB;QAC9B,MAAM,WAAW,GAAG,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,CAAA;QACjD,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QAC7D,MAAM,cAAc,GAAG,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QACjE,MAAM,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAA;QAEpF,MAAM,YAAY,GAAmB,EAAE,CAAA;QAEvC,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;YAC7B,IAAI,CAAC,IAAI,CAAC,iBAAiB,CAAC,EAAE,CAAC,WAAW,EAAE,EAAE,cAAc,EAAE,cAAc,EAAE,YAAY,CAAC,EAAE,CAAC;gBAC5F,SAAQ;YACV,CAAC;YAED,KAAK,MAAM,EAAE,IAAI,gBAAgB,CAAC,EAAE,CAAC,EAAE,CAAC;gBACtC,IAAI,IAAI,CAAC,aAAa,CAAC,EAAE,CAAC,EAAE,CAAC;oBAC3B,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;gBACvB,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,YAAY,CAAA;IACrB,CAAC;IAED,sDAAsD;IAC9C,cAAc,CAAC,SAAyB;QAC9C,MAAM,MAAM,GAA4B,EAAE,CAAA;QAC1C,KAAK,MAAM,EAAE,IAAI,SAAS,EAAE,CAAC;YAC3B,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAA;YACzB,IAAI,CAAC,IAAI;gBAAE,SAAQ;YACnB,MAAM,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,WAAW,EAAE,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QAC1D,CAAC;QACD,OAAO,MAAM,CAAA;IACf,CAAC;IAED,wEAAwE;IAChE,gBAAgB,CACtB,KAA8B;QAE9B,MAAM,KAAK,GAAoE,EAAE,CAAA;QAEjF,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,KAAK,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBAC1C,MAAM,CAAC,GAAG,KAAK,CAAC,CAAC,CAAC,CAAA;gBAClB,MAAM,CAAC,GAAG,KAAK,CAAC,CAAC,CAAC,CAAA;gBAClB,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC;oBAAE,SAAQ;gBACtB,oFAAoF;gBACpF,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,WAAW,CAAC,SAAS,EAAE,CAAC,CAAC,WAAW,CAAC,SAAS,CAAC,CAAA;gBAC3E,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,WAAW,CAAC,SAAS,EAAE,CAAC,CAAC,WAAW,CAAC,SAAS,CAAC,CAAA;gBAC3E,IAAI,QAAQ,GAAG,CAAC,IAAI,QAAQ,GAAG,QAAQ,GAAG,IAAI,CAAC,cAAc,EAAE,CAAC;oBAC9D,SAAQ;gBACV,CAAC;gBACD,MAAM,UAAU,GAAG,iBAAiB,CAAC,CAAC,CAAC,WAAW,EAAE,CAAC,CAAC,WAAW,CAAC,CAAA;gBAClE,IAAI,UAAU,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;oBACtC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC,EAAE,EAAE,UAAU,EAAE,CAAC,CAAA;gBAC9C,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,KAAK,CAAA;IACd,CAAC;IAED,2CAA2C;IACnC,eAAe,CACrB,KAAsE;QAEtE,MAAM,eAAe,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QACvC,MAAM,UAAU,GAAoB,EAAE,CAAA;QAEtC,qDAAqD;QACrD,MAAM,WAAW,GAAG,IAAI,CAAC,cAAc;YACrC,CAAC,CAAC,CAAC,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;gBACvB,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;gBAC/D,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;gBAC/D,OAAO,OAAO,CAAC,aAAa,CAAC,OAAO,CAAC,CAAA;YACvC,CAAC,CAAC;YACJ,CAAC,CAAC,KAAK,CAAA;QAET,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;YAC/B,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;YAC/C,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAA;YAClD,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,kBAAkB,EAAE,CAAA;YAEzC,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;YAC/C,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAA;YAClD,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,kBAAkB,EAAE,CAAA;YAEzC,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,GAAG,GAAG,CAAC,CAAA;YAE7C,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,eAAe;gBACrB,OAAO,EAAE,KAAK;gBACd,IAAI,EAAE,KAAK;gBACX,IAAI,EAAE,KAAK;gBACX,OAAO,EAAE,GAAG,KAAK,KAAK,KAAK,IAAI,MAAM,CAAC,KAAK,CAAC,QAAQ,MAAM,CAAC,GAAG,CAAC,gBAAgB,KAAK,KAAK,KAAK,IAAI,MAAM,CAAC,KAAK,CAAC,GAAG;gBAClH,OAAO,EAAE,IAAI,CAAC,OAAO;aACtB,CAAC,CAAA;QACJ,CAAC;QAED,OAAO,UAAU,CAAA;IACnB,CAAC;CACF"}
+{"version":3,"file":"duplicate-bodies.js","sourceRoot":"","sources":["../../src/smells/duplicate-bodies.ts"],"names":[],"mappings":"AACA,OAAO,SAAS,MAAM,WAAW,CAAA;AACjC,OAAO,IAAI,MAAM,WAAW,CAAA;AAC5B,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AAChD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AACjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,4BAA4B,CAAA;AAC7D,OAAO,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,oBAAoB,CAAA;AAKrE,OAAO,EAAE,cAAc,EAAE,MAAM,6BAA6B,CAAA;AAE5D,4CAA4C;AAC5C,MAAM,aAAa,GAAG,CAAC,cAAc,EAAE,cAAc,EAAE,iBAAiB,CAAC,CAAA;AAEzE,MAAM,WAAW,GAAG,aAAa,EAAgB,CAAA;AAEjD,MAAM,OAAO,sBAAuB,SAAQ,YAAY;IAC9C,cAAc,GAAG,IAAI,CAAA;IACrB,sBAAsB,GAAG,CAAC,CAAA;IAElC,YAAY,OAAoB;QAC9B,KAAK,CAAC,OAAO,CAAC,CAAA;IAChB,CAAC;IAED,uDAAuD;IACvD,iBAAiB,CAAC,SAAiB;QACjC,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,CAAA;QACxB,IAAI,CAAC,cAAc,GAAG,SAAS,CAAA;QAC/B,OAAO,IAAI,CAAA;IACb,CAAC;IAED;;;;;;;;;OASG;IACH,qBAAqB,CAAC,CAAS;QAC7B,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,EAAE,CAAA;QACxB,IAAI,CAAC,sBAAsB,GAAG,CAAC,CAAA;QAC/B,OAAO,IAAI,CAAA;IACb,CAAC;IAED;;;;;;;;;;;;OAYG;IACM,YAAY;QACnB,OAAO;YACL,GAAG,KAAK,CAAC,YAAY,EAAE;YACvB,IAAI,EAAE,IAAI,CAAC,SAAS,EAAE,EAAE,IAAI,IAAI,CAAC,QAAQ,EAAE;SAC5C,CAAA;IACH,CAAC;IAES,MAAM;QACd,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QACjC,MAAM,aAAa,GAAG,cAAc,CAAC,SAAS,CAAC,CAAA;QAC/C,MAAM,KAAK,GAAG,gBAAgB,CAAC,aAAa,EAAE,IAAI,CAAC,cAAc,EAAE,IAAI,CAAC,sBAAsB,CAAC,CAAA;QAC/F,OAAO,IAAI,CAAC,eAAe,CAAC,KAAK,CAAC,CAAA;IACpC,CAAC;IAES,QAAQ;QAChB,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,CAAA;QAC/E,yEAAyE;QACzE,EAAE;QACF,6EAA6E;QAC7E,yEAAyE;QACzE,8EAA8E;QAC9E,8EAA8E;QAC9E,wEAAwE;QACxE,MAAM,OAAO,GAAG;YACd,eAAe,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE;YACvC,4BAA4B,MAAM,CAAC,IAAI,CAAC,sBAAsB,CAAC,EAAE;SAClE,CAAA;QACD,IAAI,IAAI,CAAC,YAAY,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,CAAC,IAAI,CAAC,YAAY,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QAC1F,IAAI,IAAI,CAAC,YAAY;YAAE,OAAO,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAA;QACrD,OAAO,CACL,mCAAmC,KAAK,GAAG;YAC3C,kBAAkB,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,KAAK,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CACxE,CAAA;IACH,CAAC;IAED,0DAA0D;IAC1D;;;;OAIG;IACK,iBAAiB,CACvB,QAAgB,EAChB,OAIC,EACD,QAAiB;QAEjB,MAAM,EAAE,cAAc,EAAE,cAAc,EAAE,YAAY,EAAE,GAAG,OAAO,CAAA;QAChE,2EAA2E;QAC3E,2DAA2D;QAC3D,MAAM,IAAI,GAAG,CAAC,EAAuB,EAAW,EAAE,CAChD,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,QAAQ,KAAK,SAAS,IAAI,EAAE,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAA;QACxF,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC;YAAE,OAAO,KAAK,CAAA;QACpE,IAAI,IAAI,CAAC,cAAc,CAAC;YAAE,OAAO,KAAK,CAAA;QACtC,IAAI,IAAI,CAAC,YAAY,CAAC;YAAE,OAAO,KAAK,CAAA;QACpC,OAAO,IAAI,CAAA;IACb,CAAC;IAED,6DAA6D;IACrD,aAAa,CAAC,EAAgB;QACpC,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAA;QACzB,IAAI,CAAC,IAAI;YAAE,OAAO,KAAK,CAAA;QACvB,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAA;QACnD,OAAO,SAAS,IAAI,IAAI,CAAC,SAAS,CAAA;IACpC,CAAC;IAED,+DAA+D;IAC/D;;;;;;;;;;;;;OAaG;IACK,QAAQ;QACd,OAAO,WAAW,CAAC,IAAI,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,wBAAwB,EAAE,CAAC,CAAA;IACjE,CAAC;IAED,gDAAgD;IAChD,aAAa;QACX,OAAO,IAAI,CAAC,QAAQ,EAAE,CAAC,MAAM,CAAA;IAC/B,CAAC;IAEO,wBAAwB;QAC9B,MAAM,WAAW,GAAG,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,CAAA;QACjD,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QAC7D,MAAM,cAAc,GAAG,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAA;QACjE,MAAM,YAAY,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAA;QAEpF,MAAM,YAAY,GAAmB,EAAE,CAAA;QAEvC,KAAK,MAAM,EAAE,IAAI,WAAW,EAAE,CAAC;YAC7B,IACE,CAAC,IAAI,CAAC,iBAAiB,CACrB,EAAE,CAAC,WAAW,EAAE,EAChB,EAAE,cAAc,EAAE,cAAc,EAAE,YAAY,EAAE,EAChD,cAAc,CAAC,EAAE,EAAE,EAAE,CAAC,WAAW,EAAE,EAAE,IAAI,CAAC,OAAO,CAAC,YAAY,CAAC,CAChE,EACD,CAAC;gBACD,SAAQ;YACV,CAAC;YAED,yEAAyE;YACzE,sEAAsE;YACtE,uEAAuE;YACvE,iEAAiE;YACjE,wEAAwE;YACxE,oEAAoE;YACpE,KAAK,MAAM,EAAE,IAAI,gBAAgB,CAAC,EAAE,EAAE,EAAE,6BAA6B,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;gBAC/E,IAAI,IAAI,CAAC,aAAa,CAAC,EAAE,CAAC,EAAE,CAAC;oBAC3B,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;gBACvB,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,YAAY,CAAA;IACrB,CAAC;IAED,2CAA2C;IAC3C;;;;;;OAMG;IACK,YAAY,CAAC,KAAoB;QACvC,IAAI,CAAC,IAAI,CAAC,cAAc;YAAE,OAAO,KAAK,CAAA;QACtC,OAAO,CAAC,GAAG,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;YAC9B,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;YAC/D,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;YAC/D,OAAO,OAAO,CAAC,aAAa,CAAC,OAAO,CAAC,CAAA;QACvC,CAAC,CAAC,CAAA;IACJ,CAAC;IAEO,eAAe,CAAC,KAAoB;QAC1C,MAAM,eAAe,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QACvC,MAAM,UAAU,GAAoB,EAAE,CAAA;QAEtC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,EAAE,CAAC;YAC5C,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;YAC/C,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAA;YAClD,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,kBAAkB,EAAE,CAAA;YAEzC,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;YAC/C,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAA;YAClD,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,kBAAkB,EAAE,CAAA;YAEzC,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,GAAG,GAAG,CAAC,CAAA;YAE7C,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,eAAe;gBACrB,OAAO,EAAE,KAAK;gBACd,IAAI,EAAE,KAAK;gBACX,IAAI,EAAE,KAAK;gBACX,OAAO,EAAE,GAAG,KAAK,KAAK,KAAK,IAAI,MAAM,CAAC,KAAK,CAAC,QAAQ,MAAM,CAAC,GAAG,CAAC,gBAAgB,KAAK,KAAK,KAAK,IAAI,MAAM,CAAC,KAAK,CAAC,GAAG;gBAClH,wEAAwE;gBACxE,iEAAiE;gBACjE,mEAAmE;gBACnE,uEAAuE;gBACvE,uEAAuE;gBACvE,qEAAqE;gBACrE,mCAAmC;gBACnC,EAAE;gBACF,oEAAoE;gBACpE,kEAAkE;gBAClE,uEAAuE;gBACvE,wEAAwE;gBACxE,6CAA6C;gBAC7C,uEAAuE;gBACvE,sBAAsB;gBACtB,QAAQ,EAAE,mBAAmB,CAAC,GAAG,KAAK,IAAI,KAAK,EAAE,EAAE,GAAG,KAAK,IAAI,KAAK,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;gBAC3F,OAAO,EAAE,IAAI,CAAC,OAAO;aACtB,CAAC,CAAA;QACJ,CAAC;QAED,OAAO,UAAU,CAAA;IACnB,CAAC;CACF"}

package/dist/smells/fingerprint.d.ts

@@ -1,4 +1,4 @@
-import { type SyntaxKind, type Node } from 'ts-morph';
+import { SyntaxKind, type Node } from 'ts-morph';
 /**
  * Structural fingerprint of a function body.
  * Captures the shape (node kinds, call targets) while ignoring
@@ -11,6 +11,13 @@ export interface Fingerprint {
     readonly calls: readonly string[];
     /** Total AST node count (for line-count filtering) */
     readonly nodeCount: number;
+    /**
+     * Count of DISTINCT identifier/literal texts in the body — the vocabulary
+     * a body actually carries, as opposed to its punctuation/keyword shape.
+     * Plan 0103's floor reads this; `computeSimilarity()` does not — see that
+     * function's own docs for why.
+     */
+    readonly distinctVocabulary: number;
 }
 /**
  * Build a structural fingerprint from a function body AST node.

package/dist/smells/fingerprint.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"fingerprint.d.ts","sourceRoot":"","sources":["../../src/smells/fingerprint.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,UAAU,EAAE,KAAK,IAAI,EAAqB,MAAM,UAAU,CAAA;AAExE;;;;GAIG;AACH,MAAM,WAAW,WAAW;IAC1B,wDAAwD;IACxD,QAAQ,CAAC,KAAK,EAAE,SAAS,UAAU,EAAE,CAAA;IACrC,uEAAuE;IACvE,QAAQ,CAAC,KAAK,EAAE,SAAS,MAAM,EAAE,CAAA;IACjC,sDAAsD;IACtD,QAAQ,CAAC,SAAS,EAAE,MAAM,CAAA;CAC3B;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,IAAI,GAAG,WAAW,CAYxD;AAED;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,WAAW,EAAE,CAAC,EAAE,WAAW,GAAG,MAAM,CAMxE"}
+{"version":3,"file":"fingerprint.d.ts","sourceRoot":"","sources":["../../src/smells/fingerprint.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,KAAK,IAAI,EAAqB,MAAM,UAAU,CAAA;AAgBnE;;;;GAIG;AACH,MAAM,WAAW,WAAW;IAC1B,wDAAwD;IACxD,QAAQ,CAAC,KAAK,EAAE,SAAS,UAAU,EAAE,CAAA;IACrC,uEAAuE;IACvE,QAAQ,CAAC,KAAK,EAAE,SAAS,MAAM,EAAE,CAAA;IACjC,sDAAsD;IACtD,QAAQ,CAAC,SAAS,EAAE,MAAM,CAAA;IAC1B;;;;;OAKG;IACH,QAAQ,CAAC,kBAAkB,EAAE,MAAM,CAAA;CACpC;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,IAAI,GAAG,WAAW,CAiBxD;AAED;;;;GAIG;AACH,wBAAgB,iBAAiB,CAAC,CAAC,EAAE,WAAW,EAAE,CAAC,EAAE,WAAW,GAAG,MAAM,CAMxE"}

package/dist/smells/fingerprint.js

@@ -1,4 +1,17 @@
-import { Node as NodeClass } from 'ts-morph';
+import { SyntaxKind, Node as NodeClass } from 'ts-morph';
+// Deliberately not exhaustive over every text-bearing kind — `TemplateHead`/
+// `TemplateMiddle`/`TemplateTail` (interpolated templates), `BigIntLiteral` and
+// `RegularExpressionLiteral` are omitted. Every omission UNDERcounts vocabulary,
+// which only makes the floor (plan 0103) more conservative — fewer pairs
+// compared, never a false positive from a body that reads as emptier than it
+// is. Widen this set if a real interpolated-template-heavy corpus needs it.
+const TEXT_KINDS = new Set([
+    SyntaxKind.Identifier,
+    SyntaxKind.PrivateIdentifier,
+    SyntaxKind.StringLiteral,
+    SyntaxKind.NoSubstitutionTemplateLiteral,
+    SyntaxKind.NumericLiteral,
+]);
 /**
  * Build a structural fingerprint from a function body AST node.
  * Walks all descendants, records their SyntaxKind in order,
@@ -7,13 +20,18 @@ import { Node as NodeClass } from 'ts-morph';
 export function buildFingerprint(body) {
     const kinds = [];
     const calls = [];
+    const distinct = new Set();
     for (const node of body.getDescendants()) {
-        kinds.push(node.getKind());
+        const kind = node.getKind();
+        kinds.push(kind);
         if (NodeClass.isCallExpression(node)) {
             calls.push(node.getExpression().getText().replace(/\?\./g, '.'));
         }
+        if (TEXT_KINDS.has(kind)) {
+            distinct.add(node.getText());
+        }
     }
-    return { kinds, calls, nodeCount: kinds.length };
+    return { kinds, calls, nodeCount: kinds.length, distinctVocabulary: distinct.size };
 }
 /**
  * Compute similarity between two fingerprints.

package/dist/smells/fingerprint.js.map

@@ -1 +1 @@
-{"version":3,"file":"fingerprint.js","sourceRoot":"","sources":["../../src/smells/fingerprint.ts"],"names":[],"mappings":"AAAA,OAAO,EAA8B,IAAI,IAAI,SAAS,EAAE,MAAM,UAAU,CAAA;AAgBxE;;;;GAIG;AACH,MAAM,UAAU,gBAAgB,CAAC,IAAU;IACzC,MAAM,KAAK,GAAiB,EAAE,CAAA;IAC9B,MAAM,KAAK,GAAa,EAAE,CAAA;IAE1B,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,cAAc,EAAE,EAAE,CAAC;QACzC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAA;QAC1B,IAAI,SAAS,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,GAAG,CAAC,CAAC,CAAA;QAClE,CAAC;IACH,CAAC;IAED,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,CAAC,MAAM,EAAE,CAAA;AAClD,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,iBAAiB,CAAC,CAAc,EAAE,CAAc;IAC9D,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,GAAG,CAAA;IAC5D,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,GAAG,CAAA;IAE5D,MAAM,GAAG,GAAG,SAAS,CAAC,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC,KAAK,CAAC,CAAA;IACvC,OAAO,GAAG,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;AACvD,CAAC;AAED,oEAAoE;AACpE,SAAS,SAAS,CAAC,CAAoB,EAAE,CAAoB;IAC3D,MAAM,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;IAClB,MAAM,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;IAClB,IAAI,IAAI,GAAG,IAAI,KAAK,CAAS,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAC3C,IAAI,IAAI,GAAG,IAAI,KAAK,CAAS,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAE3C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAA;YACjC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;YAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAA;YACjC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAA;QAChF,CAAC;QACD,CAAC;QAAA,CAAC,IAAI,EAAE,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;QAC5B,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACd,CAAC;IAED,OAAO,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;AACrB,CAAC"}
+{"version":3,"file":"fingerprint.js","sourceRoot":"","sources":["../../src/smells/fingerprint.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAa,IAAI,IAAI,SAAS,EAAE,MAAM,UAAU,CAAA;AAEnE,6EAA6E;AAC7E,gFAAgF;AAChF,iFAAiF;AACjF,yEAAyE;AACzE,6EAA6E;AAC7E,4EAA4E;AAC5E,MAAM,UAAU,GAAG,IAAI,GAAG,CAAa;IACrC,UAAU,CAAC,UAAU;IACrB,UAAU,CAAC,iBAAiB;IAC5B,UAAU,CAAC,aAAa;IACxB,UAAU,CAAC,6BAA6B;IACxC,UAAU,CAAC,cAAc;CAC1B,CAAC,CAAA;AAuBF;;;;GAIG;AACH,MAAM,UAAU,gBAAgB,CAAC,IAAU;IACzC,MAAM,KAAK,GAAiB,EAAE,CAAA;IAC9B,MAAM,KAAK,GAAa,EAAE,CAAA;IAC1B,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAA;IAElC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,cAAc,EAAE,EAAE,CAAC;QACzC,MAAM,IAAI,GAAG,IAAI,CAAC,OAAO,EAAE,CAAA;QAC3B,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QAChB,IAAI,SAAS,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YACrC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC,OAAO,EAAE,GAAG,CAAC,CAAC,CAAA;QAClE,CAAC;QACD,IAAI,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACzB,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAA;QAC9B,CAAC;IACH,CAAC;IAED,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,SAAS,EAAE,KAAK,CAAC,MAAM,EAAE,kBAAkB,EAAE,QAAQ,CAAC,IAAI,EAAE,CAAA;AACrF,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,iBAAiB,CAAC,CAAc,EAAE,CAAc;IAC9D,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,GAAG,CAAA;IAC5D,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,GAAG,CAAA;IAE5D,MAAM,GAAG,GAAG,SAAS,CAAC,CAAC,CAAC,KAAK,EAAE,CAAC,CAAC,KAAK,CAAC,CAAA;IACvC,OAAO,GAAG,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAA;AACvD,CAAC;AAED,oEAAoE;AACpE,SAAS,SAAS,CAAC,CAAoB,EAAE,CAAoB;IAC3D,MAAM,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;IAClB,MAAM,CAAC,GAAG,CAAC,CAAC,MAAM,CAAA;IAClB,IAAI,IAAI,GAAG,IAAI,KAAK,CAAS,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAC3C,IAAI,IAAI,GAAG,IAAI,KAAK,CAAS,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAE3C,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAA;YACjC,MAAM,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;YAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAA;YACjC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAA;QAChF,CAAC;QACD,CAAC;QAAA,CAAC,IAAI,EAAE,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,CAAC,CAAA;QAC5B,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IACd,CAAC;IAED,OAAO,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;AACrB,CAAC"}

package/dist/smells/inconsistent-siblings.d.ts

@@ -1,21 +1,142 @@
+import type { RuleDescription } from '@nielspeter/eess';
 import { SmellBuilder } from './smell-builder.js';
 import type { ExpressionMatcher } from '../helpers/matchers.js';
-import type { ArchViolation } from '../core/violation.js';
+import type { ArchViolation } from '@nielspeter/eess';
 import type { ArchProject } from '../core/project.js';
 export declare class InconsistentSiblingsBuilder extends SmellBuilder {
     private _pattern?;
     constructor(project: ArchProject);
     /** The pattern that most siblings should follow. */
     forPattern(matcher: ExpressionMatcher): this;
-    /** Check if a source file contains any function matching the pattern. */
-    private fileMatchesPattern;
-    /** Partition files into matching and non-matching based on the pattern. */
-    private partitionByPattern;
+    /**
+     * Sibling files in folders large enough to be compared — plan 0096, and the
+     * ONE method both readers call.
+     *
+     * The `>= 2` threshold lives HERE rather than in `detect()`'s loop, which is
+     * what makes this a shared derivation instead of two that agree by luck.
+     * Filtering before the caller's sort is safe: `groupFilesByFolder()` returns
+     * insertion order and `detect()` sorts by folder name, a total order, so
+     * removing entries cannot reorder the survivors.
+     */
+    private selected;
+    /**
+     * Units this detector examined — plan 0096: sibling files in folders large
+     * enough to be compared.
+     *
+     * Counted in units ITERATED, never in pattern matches: a tripwire that
+     * examines every sibling and matches none has non-empty evidence, which is the
+     * 0.34.0 carve-out this must not break.
+     */
+    examinedUnits(): number;
+    /**
+     * Pure recomputation of the corpus split — never accumulated on `this`. It is
+     * the SINGLE source the finding's message, the gate, and the diagnostic preview
+     * all read, so the preview and the finding cannot diverge, and calling it twice
+     * cannot double-count (each call recomputes). Mirrors `examinedUnits()`: one
+     * derivation, not an instance field.
+     *
+     * `canFireSoon` is true when any folder is at or within ONE edit of a majority —
+     * such a folder can fire, so it is not inert even though it does not fire today.
+     *
+     * The GUARD lives here, not at the emit site. A preview read through this
+     * accessor can then never report on a rule that can fire: a healthy control
+     * (majority present, `editsToMajority <= 1`) gets `canFireSoon = true`, and the
+     * hook below returns the empty string for it. The check-time emit and the
+     * diagnostic preview share this one predicate by construction.
+     */
+    private inertAssessment;
     /** Build violations for non-matching files in a folder where the majority matches. */
+    /**
+     * The two description strings travel together as one `describe` — adjacent
+     * positional strings are the transposition the parameter cap guards against,
+     * and these two read alike.
+     */
     private buildFolderViolations;
+    /**
+     * Whether this rule states an assertion at all — the assertion gate's question.
+     *
+     * True once a condition has been added.
+     *
+     * Overrides the `TerminalBuilder` default (`true`), whose JSDoc carries the
+     * contract and the reason this is public rather than protected.
+     */
+    assertsSomething(): boolean;
+    /**
+     * Named by id or by what the detector checks — the inherited version says
+     * 'unnamed'. Uses `describe()` rather than a call-site locator for the same
+     * reason as `SliceRuleBuilder`: `explain --format agent` reads this field.
+     */
+    /**
+     * This detector counts sibling FILES, not function bodies — plan 0099.
+     *
+     * It inherited `SmellBuilder`'s noun while `examinedUnits()` sums
+     * `files.length`, so the message read "examined 0 function bodies" for a
+     * file-counting detector: the category error this plan exists to remove, in the
+     * family sitting directly under the override.
+     */
+    protected examinedUnitNoun(): string;
+    /**
+     * A structural description of this rule without executing it — what `explain`
+     * prints and what the ADR/citation gates read.
+     */
+    describeRule(): RuleDescription;
+    /**
+     * The remedy for this builder's assertion-less state, as one string.
+     *
+     * One channel, so `diagnose()`'s advice and the finding's own message cannot
+     * disagree. Overrides `TerminalBuilder`'s generic text with wording specific to
+     * what this builder is missing.
+     */
+    assertionAdvice(): string;
+    /** The file-selection facts `sibling-files.ts` needs, stated as a value. */
+    private scope;
     protected detect(): ArchViolation[];
+    /**
+     * The `DiagnosableRule` hook — public, no-arg, exactly the shape the
+     * interface requires. Recomputes `inertAssessment()` fresh, so `diagnose()`
+     * on a builder that never ran `check()` still gets truthful numbers.
+     */
+    inertAdvice(): string;
+    /**
+     * THE single derivation for both surfaces, and the guard. Returns the empty
+     * string unless the rule is genuinely inert (`matching > 0 && !canFireSoon &&
+     * !declaresEmpty()`), so a healthy control (majority present, within one edit
+     * of one, or declared empty) gets `''` and diagnose() reports nothing for it.
+     * Both `inertAdvice()` above and `detect()`'s emit call this with an
+     * `Assessment` — the SAME guard and the SAME message either way, so the
+     * preview and the finding cannot diverge.
+     *
+     * `!this.declaresEmpty()` lives HERE, not only in `inertEmitEnabled()` (review:
+     * architect) — a declared-empty rule reports its expiry, not the inert finding,
+     * on BOTH surfaces, so `diagnose()`'s preview and `check()`'s eventual failure
+     * name the same cause for the same rule state. Before this fix the two clauses
+     * were split across two functions and only the emit path read the declaration,
+     * so a rule carrying `.expectEmpty()` could preview one cause via `diagnose()`
+     * and fail with a different one via `check()` — the exact drift this shared-
+     * derivation design exists to make impossible "by construction".
+     */
+    private inertAdviceFor;
+    private inertViolation;
+    /**
+     * The pure version gate — nothing else. The `_expectEmpty` precedence
+     * (`!this.declaresEmpty()`) moved into `inertAdviceFor()` above, so it applies
+     * identically to `diagnose()`'s preview and to this emit path; this function's
+     * only job is "has the N+1 release happened yet."
+     *
+     * `INERT_FINDING_EMIT` is deliberately a bare, non-exported module `const` —
+     * not an env var, constructor option, or per-project override. The
+     * `bypassFilters: true` / unsuppressable design above depends on there being
+     * no configuration surface a future contributor could "helpfully" expose,
+     * which would undermine it silently.
+     *
+     * `protected`, not `private` — a test-only subclass overrides this to exercise
+     * the emit path (`inertViolation()`, `inertElement()`, the `detect()` branch
+     * that pushes them) before the N+1 flip ships, so that path is not shipped
+     * with zero test coverage merely because the real gate is off today (review:
+     * testing). See `tests/smells/inconsistent-siblings.test.ts`'s
+     * `EmittingSiblings` subclass.
+     */
+    protected inertEmitEnabled(): boolean;
     protected describe(): string;
-    /** Group source files by parent folder, applying all filters. */
-    private groupFilesByFolder;
 }
 //# sourceMappingURL=inconsistent-siblings.d.ts.map

package/dist/smells/inconsistent-siblings.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"inconsistent-siblings.d.ts","sourceRoot":"","sources":["../../src/smells/inconsistent-siblings.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AAGjD,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAA;AAC/D,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,sBAAsB,CAAA;AACzD,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AAQrD,qBAAa,2BAA4B,SAAQ,YAAY;IAC3D,OAAO,CAAC,QAAQ,CAAC,CAAmB;gBAExB,OAAO,EAAE,WAAW;IAIhC,oDAAoD;IACpD,UAAU,CAAC,OAAO,EAAE,iBAAiB,GAAG,IAAI;IAK5C,yEAAyE;IACzE,OAAO,CAAC,kBAAkB;IAa1B,2EAA2E;IAC3E,OAAO,CAAC,kBAAkB;IAgB1B,sFAAsF;IACtF,OAAO,CAAC,qBAAqB;IAyB7B,SAAS,CAAC,MAAM,IAAI,aAAa,EAAE;IAqCnC,SAAS,CAAC,QAAQ,IAAI,MAAM;IAK5B,iEAAiE;IACjE,OAAO,CAAC,kBAAkB;CAqC3B"}
+{"version":3,"file":"inconsistent-siblings.d.ts","sourceRoot":"","sources":["../../src/smells/inconsistent-siblings.ts"],"names":[],"mappings":"AAOA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAGvD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AACjD,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAA;AAC/D,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AACrD,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AAyBrD,qBAAa,2BAA4B,SAAQ,YAAY;IAC3D,OAAO,CAAC,QAAQ,CAAC,CAAmB;gBAExB,OAAO,EAAE,WAAW;IAIhC,oDAAoD;IACpD,UAAU,CAAC,OAAO,EAAE,iBAAiB,GAAG,IAAI;IAM5C;;;;;;;;;OASG;IACH,OAAO,CAAC,QAAQ;IAMhB;;;;;;;OAOG;IACH,aAAa,IAAI,MAAM;IAIvB;;;;;;;;;;;;;;;OAeG;IACH,OAAO,CAAC,eAAe;IAuCvB,sFAAsF;IACtF;;;;OAIG;IACH,OAAO,CAAC,qBAAqB;IA8B7B;;;;;;;OAOG;IACM,gBAAgB,IAAI,OAAO;IAIpC;;;;OAIG;IACH;;;;;;;OAOG;cACgB,gBAAgB,IAAI,MAAM;IAI7C;;;OAGG;IACM,YAAY,IAAI,eAAe;IAOxC;;;;;;OAMG;IACM,eAAe,IAAI,MAAM;IAOlC,4EAA4E;IAC5E,OAAO,CAAC,KAAK;IAWb,SAAS,CAAC,MAAM,IAAI,aAAa,EAAE;IA8DnC;;;;OAIG;IACH,WAAW,IAAI,MAAM;IAMrB;;;;;;;;;;;;;;;;;OAiBG;IACH,OAAO,CAAC,cAAc;IAKtB,OAAO,CAAC,cAAc;IA2BtB;;;;;;;;;;;;;;;;;;OAkBG;IACH,SAAS,CAAC,gBAAgB,IAAI,OAAO;IAIrC,SAAS,CAAC,QAAQ,IAAI,MAAM;CAI7B"}