@ngocsangairvds/vsaf 5.1.4 → 5.1.6

package/skills/sdlc/review/prereq/step.md

@@ -0,0 +1,18 @@
+## Phase Entry Protocol
+
+```
+[REVIEW] [1/5] Checking prerequisites... ⏳
+```
+
+1. Input:
+   - `.vsaf/docs/features/{feature-name}/05-srs.md`
+   - Code diff on feature branch
+2. Check that SRS file exists
+3. Check that feature branch exists
+4. Read `.vsaf/docs/STATUS.md`
+5. Read `CONTEXT.md`
+6. Query `graph.json` for impact verification
+
+```
+[REVIEW] [1/5] Checking prerequisites... ✅
+```

package/skills/sdlc/review/verification/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-review-verification
+description: "Review 2/5 — system verification"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Review 2/5 — system verification
+
+@include(step.md)

package/skills/sdlc/review/verification/step.md

@@ -0,0 +1,16 @@
+### Step 2: System Verification
+
+```
+[REVIEW] [2/5] System verification — build, tests, scope... ⏳
+```
+
+Use `/superpowers:verification-before-completion`:
+- Build passes
+- All tests GREEN
+- No uncommitted files
+- Scope matches SRS
+Write to `08-review.md` §Verification.
+
+```
+[REVIEW] [2/5] System verification... ✅
+```

package/skills/sdlc/ship/commit/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-ship-commit
+description: "Ship 3/5 — merge strategy + commit"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Ship 3/5 — merge strategy + commit
+
+@include(step.md)

package/skills/sdlc/ship/commit/step.md

@@ -0,0 +1,23 @@
+### Step 3: Merge Strategy + Commit
+
+```
+[SHIP] [3/5] Commit source code + .vsaf/docs/... ⏳
+```
+
+Use `/superpowers:finishing-a-development-branch`:
+- Decide merge strategy (merge commit / squash / rebase)
+- Resolve conflicts if any
+- Verify final build passes
+
+**Commit scope — ONLY commit:**
+- Source code changes (implementation / fix)
+- `.vsaf/docs/` folder (artifacts, CONTEXT.md, KNOWLEDGE.md, STATUS.md)
+- `.gitignore` (if updated)
+
+**DO NOT commit:**
+- `graphify-out/` — local graph index
+- `.gitnexus/` — local code index
+
+```
+[SHIP] [3/5] Commit source code + .vsaf/docs/... ✅
+```

package/skills/sdlc/ship/gitignore/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-ship-gitignore
+description: "Ship 2/5 — .gitignore enforcement"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Ship 2/5 — .gitignore enforcement
+
+@include(step.md)

package/skills/sdlc/ship/gitignore/step.md

@@ -0,0 +1,22 @@
+### Step 2: .gitignore Enforcement
+
+```
+[SHIP] [2/5] Checking .gitignore — ensuring index files are not committed... ⏳
+```
+
+**MANDATORY** — MUST verify before committing:
+
+1. Check that `.gitignore` contains:
+   ```
+   graphify-out/
+   .gitnexus/
+   ```
+2. If MISSING → **AUTOMATICALLY add to `.gitignore`** and notify user
+3. Verify with `git status` — `graphify-out/` and `.gitnexus/` DO NOT appear in staged/unstaged files
+4. If they still appear → `git rm --cached -r graphify-out/ .gitnexus/` before committing
+
+⚠️ **ABSOLUTELY DO NOT commit `graphify-out/` or `.gitnexus/`** — these are local indexes, each machine builds its own.
+
+```
+[SHIP] [2/5] Checking .gitignore... ✅
+```

package/skills/sdlc/ship/pr/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-ship-pr
+description: "Ship 4/5 — push + PR"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Ship 4/5 — push + PR
+
+@include(step.md)

package/skills/sdlc/ship/pr/step.md

@@ -0,0 +1,34 @@
+### Step 4: Push + PR
+
+```
+[SHIP] [4/5] Push branch + create PR... ⏳
+```
+
+Generate PR description from review artifacts:
+- Read the review file from `{artifact-dir}` — summary, impact, test results
+- Create a structured PR description
+- Open PR (or suggest command if multi-repo)
+
+**Branch naming:** `feat/{feature-name}`
+
+**Single repo:**
+```bash
+git push -u origin {branch}
+gh pr create --title "{title}" --body "{description}"
+```
+
+**Multi-repo:**
+```
+For each repo with code changes:
+  cd {repo} && git push -u origin {branch}
+  gh pr create --title "{title}" --body "{description}"
+```
+
+**Add note to PR description:**
+```
+> **Note for reviewer:** After pulling the code, run `npx gitnexus analyze` and `/graphify` to re-index locally.
+```
+
+```
+[SHIP] [4/5] Push branch + create PR... ✅
+```

package/skills/sdlc/ship/prereq/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-ship-prereq
+description: "Ship 1/5 — prerequisites"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Ship 1/5 — prerequisites
+
+@include(step.md)

package/skills/sdlc/ship/prereq/step.md

@@ -0,0 +1,16 @@
+## Phase Entry Protocol
+
+```
+[SHIP] [1/5] Checking prerequisites... ⏳
+```
+
+1. Input: `.vsaf/docs/features/{feature-name}/08-review.md`
+2. Check that the file exists + **check for Gate: APPROVED**
+   - No Gate → Stop: "Review has not been approved"
+3. Check `.vsaf/docs/STATUS.md` — feature must be in "Knowledge Updated" status
+   - If not → Stop: "Feature has not passed feature-complete. Run `/sdlc-feature-complete` first."
+4. Read `CONTEXT.md`
+
+```
+[SHIP] [1/5] Checking prerequisites... ✅
+```

package/skills/sdlc/ship/report/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-ship-report
+description: "Ship 5/5 — ship report"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Ship 5/5 — ship report
+
+@include(step.md)

package/skills/sdlc/ship/report/step.md

@@ -0,0 +1,74 @@
+### Step 5: Ship Report
+
+```
+[SHIP] [5/5] Writing ship report... ⏳
+```
+
+Write file: `.vsaf/docs/features/{feature-name}/09-ship.md`
+
+```
+[SHIP] [5/5] Writing ship report... ✅
+```
+
+## Output
+
+```markdown
+# Ship Report: {feature-name}
+
+## PR
+- {repo}: PR #{number} — {url}
+
+## Merge Strategy
+{merge commit / squash / rebase}
+
+## Commit Scope
+- Source code: {N} files
+- .vsaf/docs/: {M} files (artifacts + knowledge)
+- Excluded: graphify-out/, .gitnexus/ (local index)
+
+## Final Status
+- Build: PASS
+- Tests: all GREEN
+- Review: APPROVED
+- Knowledge: UPDATED (feature-complete done)
+
+## Traceability
+US-001 → FR-001 → TC-001 → impl ✓
+US-002 → FR-002 → TC-003 → impl ✓
+
+## Post-pull Setup
+After pulling the code, run:
+- `npx gitnexus analyze` — re-index code
+- `/graphify` — rebuild knowledge graph
+```
+
+## Phase Exit Protocol
+
+Print PHASE REPORT:
+```
+═══════════════════════════════════════════
+  SHIP COMPLETE: {feature-name}
+═══════════════════════════════════════════
+  Phase: 9 (Ship — final phase)
+  
+  PR: #{number} — {url}
+  Commit: source code + .vsaf/docs/ only
+  Excluded: graphify-out/, .gitnexus/
+  
+  Phases completed: 1→2→3→4→5→6→7→8→9
+  Artifacts: .vsaf/docs/features/{feature-name}/ (9 files)
+  
+  Feature DONE.
+═══════════════════════════════════════════
+```
+
+Update `.vsaf/docs/STATUS.md` → move to "Completed Features".
+
+## Rules
+
+- DO NOT review code — that is the review phase's job
+- Only ship code that is APPROVED + knowledge UPDATED (feature-complete done)
+- PR description MUST be self-contained (reading the PR alone should be enough to understand the feature without reading artifacts)
+- **ABSOLUTELY DO NOT commit `graphify-out/` or `.gitnexus/`** — verify .gitignore first
+- **ONLY commit source code + `.vsaf/docs/`**
+- Add re-index note to PR description for team members

package/skills/sdlc/srs/interface/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-srs-interface
+description: "SRS 4/4 — interface verification + output"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# SRS 4/4 — interface verification + output
+
+@include(step.md)

package/skills/sdlc/srs/interface/step.md

@@ -0,0 +1,44 @@
+### Step 4: Interface Verification
+
+```
+[SRS] [4/4] Interface verification via GitNexus... ⏳
+```
+
+Use GitNexus `shape_check` — verify code structure matches SRS assumptions.
+Append results to `05-srs.md` §Interface Contracts.
+
+```
+[SRS] [4/4] Interface verification via GitNexus... ✅
+```
+
+## Gate
+
+Human must approve SRS. Write `## Gate: APPROVED` at the end of the file.
+
+**Automated mode (opt-in):** when the environment has `VSAF_CI=1` or `VSAF_AUTO_APPROVE=1`, write the Gate yourself as `## Gate: APPROVED (auto · VSAF_CI · rationale: <one line>)` and proceed — the one-line rationale is REQUIRED for audit. Without the env flag, a human must approve (default).
+
+## Output
+
+- `.vsaf/docs/features/{feature-name}/05-srs.md` — SRS document (v4 template format)
+- `.vsaf/docs/features/{feature-name}/05-srs-validation-report.md` — Validation report with scores
+
+## Phase Exit Protocol
+
+In PHASE REPORT:
+- Output files: `05-srs.md`, `05-srs-validation-report.md`
+- Validation score: {overall_score}% ({GO/CONDITIONAL GO/NO-GO})
+- Suggestions: [1] Phase 5 Test Design (`/sdlc-test-design`) [2] Save artifacts
+
+Update `.vsaf/docs/STATUS.md`.
+
+**Notify the user:**
+> Artifacts have been saved. If the session is interrupted, open a new session and run the next phase — data is safe.
+
+## Rules
+
+- Every FR/NFR MUST have a unique traceability ID
+- DO NOT use vague language: "should", "might", "optionally" → replace with "MUST", "MUST NOT"
+- All terms MUST exist in CONTEXT.md
+- Every FR MUST be testable (have clear pass/fail criteria)
+- SRS MUST follow the v4 template structure (12 sections)
+- ⛔ DO NOT modify `graphify-out/` or `.gitnexus/`

package/skills/sdlc/srs/prereq/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-srs-prereq
+description: "SRS 1/4 — input artifacts"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# SRS 1/4 — input artifacts
+
+@include(step.md)

package/skills/sdlc/srs/prereq/step.md

@@ -0,0 +1,19 @@
+## Phase Entry Protocol
+
+```
+[SRS] [1/4] Checking input artifacts... ⏳
+```
+
+1. Input:
+   - `.vsaf/docs/features/{feature-name}/02-prd.md`
+   - `.vsaf/docs/features/{feature-name}/03-adr.md`
+   - `.vsaf/docs/features/{feature-name}/04-epics.md`
+2. Verify 02-prd.md AND 03-adr.md exist (04-epics.md optional):
+   - Any required file missing → Ask: "File not found. Have you run Phase 2 (PRD) and Phase 3 (Architecture)?"
+3. Read `.vsaf/docs/STATUS.md`
+4. Read `CONTEXT.md`
+5. Query `graph.json` for code structure + business mapping (if exists)
+
+```
+[SRS] [1/4] Checking input artifacts... ✅
+```

package/skills/sdlc/srs/validate/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-srs-validate
+description: "SRS 3/4 — validate SRS"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# SRS 3/4 — validate SRS
+
+@include(step.md)

package/skills/sdlc/srs/validate/step.md

@@ -0,0 +1,23 @@
+### Step 3: Validate SRS
+
+```
+[SRS] [3/4] Validating SRS (8 dimensions)... ⏳
+```
+
+Use `/sdlc-validate-srs` — validate SRS across 8 dimensions with weighted scoring.
+
+- Scope: single file (`05-srs.md`)
+- Cross-validate against: `02-prd.md`, `03-adr.md`
+- Output: `.vsaf/docs/features/{feature-name}/05-srs-validation-report.md`
+
+**Decision handling:**
+
+| Validation Result | Action |
+|---|---|
+| **GO** (≥80%, no CRITICAL) | Print score summary, proceed to Step 4 |
+| **CONDITIONAL GO** (60-79% or HIGH findings) | Print warnings + finding summary. Ask user: "Proceed despite warnings? (Y/N)" |
+| **NO-GO** (<60% or CRITICAL findings) | **STOP.** Print CRITICAL findings. Ask user to fix 05-srs.md and re-run `/sdlc-srs` |
+
+```
+[SRS] [3/4] Validating SRS (8 dimensions)... ✅
+```

package/skills/sdlc/srs/write/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-srs-write
+description: "SRS 2/4 — write SRS"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# SRS 2/4 — write SRS
+
+@include(step.md)

package/skills/sdlc/srs/write/step.md

@@ -0,0 +1,19 @@
+### Step 2: Write SRS
+
+```
+[SRS] [2/4] Writing SRS from PRD + ADR + Epics... ⏳
+```
+
+Use `/sdlc-write-srs` — write SRS following the v4 template (12 sections) from PRD + Architecture + Epics.
+
+Input:
+- `02-prd.md` as PRD source
+- `03-adr.md` as architecture context
+- `04-epics.md` as epic breakdown (optional)
+- Figma link from `CONTEXT.md` (optional)
+
+Output: `.vsaf/docs/features/{feature-name}/05-srs.md`
+
+```
+[SRS] [2/4] Writing SRS from PRD + ADR + Epics... ✅
+```

package/skills/sdlc/test-design/boundary/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-test-design-boundary
+description: "Test Design 3/4 — boundary tests"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Test Design 3/4 — boundary tests
+
+@include(step.md)

package/skills/sdlc/test-design/boundary/step.md

@@ -0,0 +1,12 @@
+### Step 2: Boundary Tests
+
+```
+[TEST-DESIGN] [3/4] Boundary & edge case tests... ⏳
+```
+
+Use `/bmad-review-edge-case-hunter` — add boundary tests.
+Race conditions, null/empty, overflow, concurrent access.
+
+```
+[TEST-DESIGN] [3/4] Boundary & edge case tests... ✅
+```

package/skills/sdlc/test-design/cases/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-test-design-cases
+description: "Test Design 2/4 — generate test cases"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Test Design 2/4 — generate test cases
+
+@include(step.md)

package/skills/sdlc/test-design/cases/step.md

@@ -0,0 +1,22 @@
+### Step 1: Generate Test Cases
+
+```
+[TEST-DESIGN] [2/4] Generating test cases from SRS... ⏳
+```
+
+Use `/bmad-qa-generate-e2e-tests` — generate test cases from SRS FRs/NFRs.
+
+For each requirement, ensure ≥1 test case with:
+
+1. **Unique ID** — TC-001 (sequential)
+2. **Traceability** — TC → FR/NFR → PRD user story (US-xxx)
+3. **Type** — unit / integration / e2e (based on requirement scope)
+4. **Precondition** — system state before test
+5. **Steps** — exact actions to execute
+6. **Expected result** — concrete, verifiable outcome (not "should work")
+
+Prioritize: happy path first, then error paths, then edge cases.
+
+```
+[TEST-DESIGN] [2/4] Generating test cases from SRS... ✅
+```

package/skills/sdlc/test-design/coverage/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-test-design-coverage
+description: "Test Design 4/4 — coverage map + output"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Test Design 4/4 — coverage map + output
+
+@include(step.md)

package/skills/sdlc/test-design/coverage/step.md

@@ -0,0 +1,63 @@
+### Step 3: Coverage Map
+
+```
+[TEST-DESIGN] [4/4] Coverage mapping via GitNexus... ⏳
+```
+
+Use GitNexus `detect_changes` — predict files that will be modified.
+Map test cases → files requiring coverage.
+
+```
+[TEST-DESIGN] [4/4] Coverage mapping via GitNexus... ✅
+```
+
+## Output
+
+Write file: `.vsaf/docs/features/{feature-name}/06-testcases.md`
+
+```markdown
+# Test Cases: {feature-name}
+
+## TC-001 → FR-001 → US-003
+- Type: unit
+- File target: src/user/user.service.ts
+- Precondition: ...
+- Steps: ...
+- Expected: ...
+
+## TC-002 → FR-001 (edge case: empty input)
+- Type: unit
+- Precondition: ...
+- Steps: ...
+- Expected: ...
+
+## Coverage Map
+- src/user/user.service.ts → TC-001, TC-002
+- src/user/user.controller.ts → TC-005, TC-006
+
+## Traceability Matrix
+| FR/NFR | Test Cases | Coverage |
+|--------|-----------|----------|
+| FR-001 | TC-001, TC-002 | ✓ |
+| FR-002 | TC-003 | ✓ |
+| NFR-001 | TC-010 | ✓ |
+```
+
+## Phase Exit Protocol
+
+In PHASE REPORT:
+- Output files: `.vsaf/docs/features/{feature-name}/06-testcases.md`
+- Suggestions: [1] Phase 6 Implementation (`/sdlc-implement`) [2] Save artifacts
+
+Update `.vsaf/docs/STATUS.md`.
+
+**Notify the user:**
+> Artifacts have been saved. If the session is interrupted, open a new session and run the next phase — data is safe.
+
+## Rules
+
+- Test cases derive from SRS (spec), NEVER from code
+- Every FR/NFR MUST have ≥1 test case
+- Traceability chain is mandatory: TC → FR → US
+- DO NOT read source code when writing test cases
+- ⛔ DO NOT modify `graphify-out/` or `.gitnexus/`

package/skills/sdlc/test-design/prereq/SKILL.md

@@ -0,0 +1,10 @@
+---
+name: sdlc-test-design-prereq
+description: "Test Design 1/4 — input artifacts"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Test Design 1/4 — input artifacts
+
+@include(step.md)

package/skills/sdlc/test-design/prereq/step.md

@@ -0,0 +1,15 @@
+## Phase Entry Protocol
+
+```
+[TEST-DESIGN] [1/4] Checking input artifacts... ⏳
+```
+
+1. Input: `.vsaf/docs/features/{feature-name}/05-srs.md`
+2. Verify file exists + **check Gate: APPROVED**
+   - No Gate → Stop: "SRS has not been approved"
+3. Read `.vsaf/docs/STATUS.md`
+4. Read `CONTEXT.md`
+
+```
+[TEST-DESIGN] [1/4] Checking input artifacts... ✅
+```

package/{skills/sdlc/workflows → workflows/sdlc}/hotfix-tdd.yaml

@@ -4,7 +4,8 @@ description: "Sub-flow: Hotfix Implement (TDD) → Test Gate"
 nodes:
   - id: implement
     description: "Implement — TDD (RED → GREEN → REFACTOR), SonarQube-in-loop"
-    command: sdlc-hotfix-implement
+    bash: |
+      vsaf run sdlc/sdlc-hotfix-implement $ARGUMENTS
     depends_on: []
 
   - id: test-gate

package/{skills/sdlc/workflows → workflows/sdlc}/hotfix.yaml

@@ -4,18 +4,21 @@ description: "Hotfix — Analyze → PRD → Implement (TDD) → Ship"
 nodes:
   - id: analyze
     description: "Analyze — grill user, GitNexus impact, root cause, blast radius"
-    command: sdlc-hotfix-analyze
+    bash: |
+      vsaf run sdlc/sdlc-hotfix-analyze $ARGUMENTS
     workspace: false
 
   - id: prd
     description: "PRD — fix requirements, acceptance criteria, scope boundary"
-    command: sdlc-hotfix-prd
+    bash: |
+      vsaf run sdlc/sdlc-hotfix-prd $ARGUMENTS
     depends_on: [analyze]
     workspace: false
 
   - id: implement
     description: "Implement — TDD (RED → GREEN → REFACTOR), SonarQube-in-loop"
-    command: sdlc-hotfix-implement
+    bash: |
+      vsaf run sdlc/sdlc-hotfix-implement $ARGUMENTS
     depends_on: [prd]
 
   - id: test-gate
@@ -30,6 +33,7 @@ nodes:
 
   - id: ship
     description: "Ship — commit, PR on hotfix branch"
-    command: sdlc-hotfix-ship
+    bash: |
+      vsaf run sdlc/sdlc-hotfix-ship $ARGUMENTS
     depends_on: [test-gate]
     workspace: false