@ngocsangairvds/vsaf 5.1.4 → 5.1.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (217) hide show
  1. package/package.json +1 -1
  2. package/packages/cli/dist/adapters/antigravity.d.ts.map +1 -1
  3. package/packages/cli/dist/adapters/antigravity.js +7 -2
  4. package/packages/cli/dist/adapters/antigravity.js.map +1 -1
  5. package/packages/cli/dist/adapters/codex.js +1 -1
  6. package/packages/cli/dist/adapters/codex.js.map +1 -1
  7. package/packages/cli/dist/adapters/cursor.js +1 -1
  8. package/packages/cli/dist/adapters/cursor.js.map +1 -1
  9. package/packages/cli/dist/commands/install.d.ts.map +1 -1
  10. package/packages/cli/dist/commands/install.js +21 -1
  11. package/packages/cli/dist/commands/install.js.map +1 -1
  12. package/packages/cli/dist/commands/skill.d.ts.map +1 -1
  13. package/packages/cli/dist/commands/skill.js +5 -2
  14. package/packages/cli/dist/commands/skill.js.map +1 -1
  15. package/skills/sdlc/architecture/current-state/SKILL.md +10 -0
  16. package/skills/sdlc/architecture/current-state/step.md +13 -0
  17. package/skills/sdlc/architecture/decision/SKILL.md +10 -0
  18. package/skills/sdlc/architecture/decision/step.md +21 -0
  19. package/skills/sdlc/architecture/epics/SKILL.md +10 -0
  20. package/skills/sdlc/architecture/epics/step.md +34 -0
  21. package/skills/sdlc/architecture/grill/SKILL.md +10 -0
  22. package/skills/sdlc/architecture/grill/step.md +26 -0
  23. package/skills/sdlc/architecture/prereq/SKILL.md +10 -0
  24. package/skills/sdlc/architecture/prereq/step.md +16 -0
  25. package/skills/sdlc/architecture/readiness/SKILL.md +10 -0
  26. package/skills/sdlc/architecture/readiness/step.md +76 -0
  27. package/skills/sdlc/complete/context/SKILL.md +10 -0
  28. package/skills/sdlc/complete/context/step.md +14 -0
  29. package/skills/sdlc/complete/knowledge/SKILL.md +10 -0
  30. package/skills/sdlc/complete/knowledge/step.md +22 -0
  31. package/skills/sdlc/complete/prereq/SKILL.md +10 -0
  32. package/skills/sdlc/complete/prereq/step.md +16 -0
  33. package/skills/sdlc/complete/reindex/SKILL.md +10 -0
  34. package/skills/sdlc/complete/reindex/step.md +24 -0
  35. package/skills/sdlc/complete/status/SKILL.md +10 -0
  36. package/skills/sdlc/complete/status/step.md +52 -0
  37. package/skills/sdlc/discovery/brainstorm/SKILL.md +10 -0
  38. package/skills/sdlc/discovery/brainstorm/step.md +27 -0
  39. package/skills/sdlc/discovery/domain/SKILL.md +10 -0
  40. package/skills/sdlc/discovery/domain/step.md +13 -0
  41. package/skills/sdlc/discovery/grill/SKILL.md +10 -0
  42. package/skills/sdlc/discovery/grill/step.md +22 -0
  43. package/skills/sdlc/discovery/prereq/SKILL.md +10 -0
  44. package/skills/sdlc/discovery/prereq/step.md +16 -0
  45. package/skills/sdlc/discovery/prfaq/SKILL.md +10 -0
  46. package/skills/sdlc/discovery/prfaq/step.md +68 -0
  47. package/skills/sdlc/discovery/system/SKILL.md +10 -0
  48. package/skills/sdlc/discovery/system/step.md +19 -0
  49. package/skills/sdlc/hotfix/analyze/entry/SKILL.md +10 -0
  50. package/skills/sdlc/hotfix/analyze/entry/step.md +15 -0
  51. package/skills/sdlc/hotfix/analyze/exit/SKILL.md +10 -0
  52. package/skills/sdlc/hotfix/analyze/exit/step.md +19 -0
  53. package/skills/sdlc/hotfix/analyze/fix-strategy/SKILL.md +10 -0
  54. package/skills/sdlc/hotfix/analyze/fix-strategy/step.md +15 -0
  55. package/skills/sdlc/hotfix/analyze/gitnexus/SKILL.md +10 -0
  56. package/skills/sdlc/hotfix/analyze/gitnexus/step.md +17 -0
  57. package/skills/sdlc/hotfix/analyze/grill/SKILL.md +10 -0
  58. package/skills/sdlc/hotfix/analyze/grill/step.md +23 -0
  59. package/skills/sdlc/hotfix/analyze/reasoning/SKILL.md +10 -0
  60. package/skills/sdlc/hotfix/analyze/reasoning/step.md +29 -0
  61. package/skills/sdlc/hotfix/analyze/write/SKILL.md +10 -0
  62. package/skills/sdlc/hotfix/analyze/write/step.md +45 -0
  63. package/skills/sdlc/hotfix/implement/branch/SKILL.md +10 -0
  64. package/skills/sdlc/hotfix/implement/branch/step.md +15 -0
  65. package/skills/sdlc/hotfix/implement/entry/SKILL.md +10 -0
  66. package/skills/sdlc/hotfix/implement/entry/step.md +20 -0
  67. package/skills/sdlc/hotfix/implement/gate/SKILL.md +10 -0
  68. package/skills/sdlc/hotfix/implement/gate/step.md +104 -0
  69. package/skills/sdlc/hotfix/implement/impact/SKILL.md +10 -0
  70. package/skills/sdlc/hotfix/implement/impact/step.md +15 -0
  71. package/skills/sdlc/hotfix/implement/sonar/SKILL.md +10 -0
  72. package/skills/sdlc/hotfix/implement/sonar/step.md +27 -0
  73. package/skills/sdlc/hotfix/implement/tdd/SKILL.md +10 -0
  74. package/skills/sdlc/hotfix/implement/tdd/step.md +33 -0
  75. package/skills/sdlc/hotfix/implement/verify/SKILL.md +10 -0
  76. package/skills/sdlc/hotfix/implement/verify/step.md +27 -0
  77. package/skills/sdlc/hotfix/prd/entry/SKILL.md +10 -0
  78. package/skills/sdlc/hotfix/prd/entry/step.md +20 -0
  79. package/skills/sdlc/hotfix/prd/gate/SKILL.md +10 -0
  80. package/skills/sdlc/hotfix/prd/gate/step.md +32 -0
  81. package/skills/sdlc/hotfix/prd/requirements/SKILL.md +10 -0
  82. package/skills/sdlc/hotfix/prd/requirements/step.md +19 -0
  83. package/skills/sdlc/hotfix/prd/validate/SKILL.md +10 -0
  84. package/skills/sdlc/hotfix/prd/validate/step.md +19 -0
  85. package/skills/sdlc/hotfix/prd/write/SKILL.md +10 -0
  86. package/skills/sdlc/hotfix/prd/write/step.md +38 -0
  87. package/skills/sdlc/hotfix/review/entry/SKILL.md +10 -0
  88. package/skills/sdlc/hotfix/review/entry/step.md +13 -0
  89. package/skills/sdlc/hotfix/review/gate/SKILL.md +10 -0
  90. package/skills/sdlc/hotfix/review/gate/step.md +51 -0
  91. package/skills/sdlc/hotfix/review/impact/SKILL.md +10 -0
  92. package/skills/sdlc/hotfix/review/impact/step.md +22 -0
  93. package/skills/sdlc/hotfix/review/minimality/SKILL.md +10 -0
  94. package/skills/sdlc/hotfix/review/minimality/step.md +18 -0
  95. package/skills/sdlc/hotfix/review/test-quality/SKILL.md +10 -0
  96. package/skills/sdlc/hotfix/review/test-quality/step.md +16 -0
  97. package/skills/sdlc/hotfix/ship/commit-pr/SKILL.md +10 -0
  98. package/skills/sdlc/hotfix/ship/commit-pr/step.md +58 -0
  99. package/skills/sdlc/hotfix/ship/entry/SKILL.md +10 -0
  100. package/skills/sdlc/hotfix/ship/entry/step.md +20 -0
  101. package/skills/sdlc/hotfix/ship/exit/SKILL.md +10 -0
  102. package/skills/sdlc/hotfix/ship/exit/step.md +31 -0
  103. package/skills/sdlc/hotfix/ship/gitignore/SKILL.md +10 -0
  104. package/skills/sdlc/hotfix/ship/gitignore/step.md +22 -0
  105. package/skills/sdlc/hotfix/ship/report/SKILL.md +10 -0
  106. package/skills/sdlc/hotfix/ship/report/step.md +47 -0
  107. package/skills/sdlc/hotfix/ship/test-gate/SKILL.md +10 -0
  108. package/skills/sdlc/hotfix/ship/test-gate/step.md +17 -0
  109. package/skills/sdlc/implement/build-run/SKILL.md +10 -0
  110. package/skills/sdlc/implement/build-run/step.md +85 -0
  111. package/skills/sdlc/implement/checkpoint/SKILL.md +10 -0
  112. package/skills/sdlc/implement/checkpoint/step.md +20 -0
  113. package/skills/sdlc/implement/debug/SKILL.md +10 -0
  114. package/skills/sdlc/implement/debug/step.md +25 -0
  115. package/skills/sdlc/implement/impact/SKILL.md +10 -0
  116. package/skills/sdlc/implement/impact/step.md +12 -0
  117. package/skills/sdlc/implement/plan/SKILL.md +10 -0
  118. package/skills/sdlc/implement/plan/step.md +13 -0
  119. package/skills/sdlc/implement/prereq/SKILL.md +10 -0
  120. package/skills/sdlc/implement/prereq/step.md +21 -0
  121. package/skills/sdlc/implement/subagents/SKILL.md +10 -0
  122. package/skills/sdlc/implement/subagents/step.md +38 -0
  123. package/skills/sdlc/implement/tdd/SKILL.md +10 -0
  124. package/skills/sdlc/implement/tdd/step.md +24 -0
  125. package/skills/sdlc/init/SKILL.md +7 -0
  126. package/skills/sdlc/onboard-code/SKILL.md +7 -0
  127. package/skills/sdlc/onboard-docs/SKILL.md +7 -0
  128. package/skills/sdlc/pack.yaml +83 -16
  129. package/skills/sdlc/prd/blast-radius/SKILL.md +10 -0
  130. package/skills/sdlc/prd/blast-radius/step.md +76 -0
  131. package/skills/sdlc/prd/create/SKILL.md +10 -0
  132. package/skills/sdlc/prd/create/step.md +21 -0
  133. package/skills/sdlc/prd/elicitation/SKILL.md +10 -0
  134. package/skills/sdlc/prd/elicitation/step.md +12 -0
  135. package/skills/sdlc/prd/prereq/SKILL.md +10 -0
  136. package/skills/sdlc/prd/prereq/step.md +16 -0
  137. package/skills/sdlc/prd/validate/SKILL.md +10 -0
  138. package/skills/sdlc/prd/validate/step.md +24 -0
  139. package/skills/sdlc/review/code/SKILL.md +10 -0
  140. package/skills/sdlc/review/code/step.md +45 -0
  141. package/skills/sdlc/review/debate/SKILL.md +10 -0
  142. package/skills/sdlc/review/debate/step.md +84 -0
  143. package/skills/sdlc/review/impact/SKILL.md +10 -0
  144. package/skills/sdlc/review/impact/step.md +14 -0
  145. package/skills/sdlc/review/prereq/SKILL.md +10 -0
  146. package/skills/sdlc/review/prereq/step.md +18 -0
  147. package/skills/sdlc/review/verification/SKILL.md +10 -0
  148. package/skills/sdlc/review/verification/step.md +16 -0
  149. package/skills/sdlc/ship/commit/SKILL.md +10 -0
  150. package/skills/sdlc/ship/commit/step.md +23 -0
  151. package/skills/sdlc/ship/gitignore/SKILL.md +10 -0
  152. package/skills/sdlc/ship/gitignore/step.md +22 -0
  153. package/skills/sdlc/ship/pr/SKILL.md +10 -0
  154. package/skills/sdlc/ship/pr/step.md +34 -0
  155. package/skills/sdlc/ship/prereq/SKILL.md +10 -0
  156. package/skills/sdlc/ship/prereq/step.md +16 -0
  157. package/skills/sdlc/ship/report/SKILL.md +10 -0
  158. package/skills/sdlc/ship/report/step.md +74 -0
  159. package/skills/sdlc/srs/interface/SKILL.md +10 -0
  160. package/skills/sdlc/srs/interface/step.md +44 -0
  161. package/skills/sdlc/srs/prereq/SKILL.md +10 -0
  162. package/skills/sdlc/srs/prereq/step.md +19 -0
  163. package/skills/sdlc/srs/validate/SKILL.md +10 -0
  164. package/skills/sdlc/srs/validate/step.md +23 -0
  165. package/skills/sdlc/srs/write/SKILL.md +10 -0
  166. package/skills/sdlc/srs/write/step.md +19 -0
  167. package/skills/sdlc/test-design/boundary/SKILL.md +10 -0
  168. package/skills/sdlc/test-design/boundary/step.md +12 -0
  169. package/skills/sdlc/test-design/cases/SKILL.md +10 -0
  170. package/skills/sdlc/test-design/cases/step.md +22 -0
  171. package/skills/sdlc/test-design/coverage/SKILL.md +10 -0
  172. package/skills/sdlc/test-design/coverage/step.md +63 -0
  173. package/skills/sdlc/test-design/prereq/SKILL.md +10 -0
  174. package/skills/sdlc/test-design/prereq/step.md +15 -0
  175. package/{skills/sdlc/workflows → workflows/sdlc}/hotfix-tdd.yaml +2 -1
  176. package/{skills/sdlc/workflows → workflows/sdlc}/hotfix.yaml +8 -4
  177. package/workflows/sdlc/master-sdlc.yaml +64 -0
  178. package/workflows/sdlc/sdlc-architecture.yaml +43 -0
  179. package/workflows/sdlc/sdlc-build.yaml +51 -0
  180. package/workflows/sdlc/sdlc-design.yaml +61 -0
  181. package/workflows/sdlc/sdlc-discovery.yaml +43 -0
  182. package/workflows/sdlc/sdlc-feature-complete.yaml +36 -0
  183. package/workflows/sdlc/sdlc-hotfix-analyze.yaml +43 -0
  184. package/workflows/sdlc/sdlc-hotfix-implement.yaml +43 -0
  185. package/workflows/sdlc/sdlc-hotfix-prd.yaml +31 -0
  186. package/workflows/sdlc/sdlc-hotfix-review.yaml +31 -0
  187. package/workflows/sdlc/sdlc-hotfix-ship.yaml +37 -0
  188. package/workflows/sdlc/sdlc-implement.yaml +60 -0
  189. package/workflows/sdlc/sdlc-prd.yaml +36 -0
  190. package/workflows/sdlc/sdlc-qa.yaml +91 -0
  191. package/workflows/sdlc/sdlc-review.yaml +36 -0
  192. package/workflows/sdlc/sdlc-ship.yaml +36 -0
  193. package/workflows/sdlc/sdlc-srs.yaml +29 -0
  194. package/workflows/sdlc/sdlc-test-design.yaml +29 -0
  195. package/workflows/sdlc/sdlc-testcase.yaml +25 -0
  196. package/workflows/sdlc/sdlc-thinking.yaml +67 -0
  197. package/skills/sdlc/architecture/SKILL.md +0 -218
  198. package/skills/sdlc/discovery/SKILL.md +0 -197
  199. package/skills/sdlc/feature-complete/SKILL.md +0 -159
  200. package/skills/sdlc/hotfix-analyze/SKILL.md +0 -198
  201. package/skills/sdlc/hotfix-implement/SKILL.md +0 -272
  202. package/skills/sdlc/hotfix-prd/SKILL.md +0 -161
  203. package/skills/sdlc/hotfix-review/SKILL.md +0 -153
  204. package/skills/sdlc/hotfix-ship/SKILL.md +0 -221
  205. package/skills/sdlc/implement/SKILL.md +0 -264
  206. package/skills/sdlc/prd/SKILL.md +0 -182
  207. package/skills/sdlc/review/SKILL.md +0 -210
  208. package/skills/sdlc/ship/SKILL.md +0 -194
  209. package/skills/sdlc/srs/SKILL.md +0 -148
  210. package/skills/sdlc/test-design/SKILL.md +0 -132
  211. package/skills/sdlc/workflows/master-sdlc.yaml +0 -55
  212. package/skills/sdlc/workflows/sdlc-build.yaml +0 -18
  213. package/skills/sdlc/workflows/sdlc-design.yaml +0 -14
  214. package/skills/sdlc/workflows/sdlc-qa.yaml +0 -20
  215. package/skills/sdlc/workflows/sdlc-testcase.yaml +0 -8
  216. package/skills/sdlc/workflows/sdlc-thinking.yaml +0 -12
  217. /package/{skills/sdlc/workflows → workflows/sdlc}/onboarding.yaml +0 -0
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-analyze-reasoning
3
+ description: "Hotfix Analyze 4/6 — root cause reasoning"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Analyze 4/6 — root cause reasoning
9
+
10
+ @include(step.md)
@@ -0,0 +1,29 @@
1
+ ### Step 4: Deep Thinking — Root Cause Reasoning
2
+
3
+ ```
4
+ [HOTFIX-ANALYZE] [4/6] Deep thinking — reasoning about root cause... ⏳
5
+ ```
6
+
7
+ **Two approaches available — choose based on complexity:**
8
+
9
+ **Option A: Full approach** — Use `/superpowers:systematic-debugging` for complex, multi-layered bugs where you need structured hypothesis testing with instrumentation.
10
+
11
+ **Option B: Lean approach (mattpocock)** — Use `/diagnose` for focused bugs where the feedback loop is clear. `/diagnose` provides a disciplined 6-phase loop: build feedback loop → reproduce → hypothesise → instrument → fix → regression-test. Also use `/zoom-out` if the affected code area is unfamiliar.
12
+
13
+ Regardless of approach:
14
+
15
+ 1. **Read the actual source code** — do NOT rely only on GitNexus metadata. Open and read every file in the call chain identified in Step 3.
16
+ 2. **Form hypotheses** — based on symptoms + code reading, list 2-3 possible root causes
17
+ 3. **Evaluate each hypothesis:**
18
+ - Does it explain ALL symptoms from the bug report?
19
+ - Does it match the reproduction steps?
20
+ - Is it consistent with the code structure from GitNexus?
21
+ 4. **Eliminate** — rule out hypotheses that don't explain all symptoms
22
+ 5. **Conclude** — select the most likely root cause with specific file:line reference
23
+ 6. **Propose fix strategy** — minimal approach to fix the confirmed root cause
24
+
25
+ If no hypothesis explains all symptoms → the bug report may be incomplete. List what information is missing.
26
+
27
+ ```
28
+ [HOTFIX-ANALYZE] [4/6] Deep thinking — reasoning about root cause... ✅
29
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-analyze-write
3
+ description: "Hotfix Analyze 6/6 — write analysis"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Analyze 6/6 — write analysis
9
+
10
+ @include(step.md)
@@ -0,0 +1,45 @@
1
+ ### Step 6: Write Analysis
2
+
3
+ ```
4
+ [HOTFIX-ANALYZE] [6/6] Writing analysis document... ⏳
5
+ ```
6
+
7
+ Create directory `.vsaf/docs/hotfixes/{bug-id}/` if it doesn't exist.
8
+
9
+ Write file: `.vsaf/docs/hotfixes/{bug-id}/01-analysis.md`
10
+
11
+ ```markdown
12
+ # Bug Analysis: {bug-id}
13
+
14
+ ## Tester Report
15
+ {summary of bug report}
16
+
17
+ ## Symptoms
18
+ {symptoms observed}
19
+
20
+ ## Reproduction Steps
21
+ {reproduction steps}
22
+
23
+ ## Hypotheses
24
+ | # | Hypothesis | Explains all symptoms? | Verdict |
25
+ |---|-----------|----------------------|---------|
26
+ | 1 | {hypothesis} | {yes/no + why} | Eliminated / Selected |
27
+
28
+ ## Root Cause
29
+ {confirmed root cause — specific code defect with file:line references}
30
+
31
+ ## Affected Files
32
+ | File | Role | Severity |
33
+ |------|------|----------|
34
+ | {file} | {role in the bug} | Direct / Indirect |
35
+
36
+ ## Blast Radius
37
+ {what else could break}
38
+
39
+ ## Fix Strategy
40
+ {minimal fix approach — what to change and why}
41
+ ```
42
+
43
+ ```
44
+ [HOTFIX-ANALYZE] [6/6] Writing analysis document... ✅
45
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-branch
3
+ description: "Hotfix Implement 2/6 — branch setup"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 2/6 — branch setup
9
+
10
+ @include(step.md)
@@ -0,0 +1,15 @@
1
+ ### Step 2: Branch Setup
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [2/6] Creating hotfix branch... ⏳
5
+ ```
6
+
7
+ ```bash
8
+ git checkout -b hotfix/{bug-id}
9
+ ```
10
+
11
+ If branch already exists → switch to it.
12
+
13
+ ```
14
+ [HOTFIX-IMPL] [2/6] Creating hotfix branch... ✅
15
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-entry
3
+ description: "Hotfix Implement 1/6 — check input artifacts"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 1/6 — check input artifacts
9
+
10
+ @include(step.md)
@@ -0,0 +1,20 @@
1
+ ## Phase Entry Protocol
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [1/6] Checking input artifacts... ⏳
5
+ ```
6
+
7
+ 1. Input:
8
+ - `.vsaf/docs/hotfixes/{bug-id}/02-prd.md`
9
+ - `.vsaf/docs/hotfixes/{bug-id}/01-analysis.md`
10
+ 2. Verify BOTH files exist:
11
+ - Missing → Stop: "Run previous phases first."
12
+ 3. Check `02-prd.md` has `## Gate: APPROVED`
13
+ - No Gate → Stop: "PRD not approved. Get approval first."
14
+ 4. Extract from PRD: FRs, acceptance criteria, scope boundary
15
+ 5. Extract from analysis: root cause (file:line), affected files, fix strategy
16
+ 6. Read `CONTEXT.md`
17
+
18
+ ```
19
+ [HOTFIX-IMPL] [1/6] Checking input artifacts... ✅
20
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-gate
3
+ description: "Hotfix Implement — verification gate and output"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement — verification gate and output
9
+
10
+ @include(step.md)
@@ -0,0 +1,104 @@
1
+ ## Verification Gate
2
+
3
+ ⛔ **NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**
4
+
5
+ Before printing Phase Exit, you MUST pass ALL checks below. For each check: **run the command → read the full output → verify the claim matches the output.** Do NOT trust memory, do NOT trust previous runs, do NOT say "should pass."
6
+
7
+ | # | Check | Command to Run | Evidence Required | ❌ NOT Acceptable |
8
+ |---|-------|---------------|-------------------|-------------------|
9
+ | 1 | Build compiles | `mvn compile` / `npm run build` / equivalent | `BUILD SUCCESS` or `0 errors` in output | "It compiled earlier" |
10
+ | 2 | All tests pass | `npm test` / `mvn test` / equivalent | `X passed, 0 failed` in output | "Tests should still pass" |
11
+ | 3 | Regression test passes | Run specific test by name | Test name + PASS in output | "I wrote the test so it passes" |
12
+ | 4 | No new SonarQube issues | Check output from Step 4 | 0 blockers, 0 critical, 0 vulns | "Code looks clean" |
13
+ | 5 | GitNexus impact clean | Check output from Step 6 | Blast radius matches analysis | "Fix is minimal so it's fine" |
14
+ | 6 | Scope boundary held | `git diff --stat` | Changed files ⊆ files listed in analysis | "I only changed what was needed" |
15
+
16
+ **Red flags — if you catch yourself thinking any of these, STOP and run the command:**
17
+ - "It should work" → Run it and prove it
18
+ - "I'm confident" → Confidence ≠ evidence
19
+ - "I already checked" → Check again with fresh output
20
+ - "It's a small change so it's safe" → Small changes break big systems
21
+ - "The test passed during TDD" → TDD was minutes ago; verify NOW
22
+
23
+ **Procedure:**
24
+ 1. Run checks 1-6 sequentially
25
+ 2. For each: paste the **actual command output** (or key lines) into `03-impl-log.md` under a `## Verification Evidence` section
26
+ 3. If ANY check fails → fix → re-run ALL checks (not just the failed one)
27
+ 4. Only after ALL 6 checks show fresh passing evidence → proceed to Phase Exit
28
+
29
+ ## Output
30
+
31
+ Write file: `.vsaf/docs/hotfixes/{bug-id}/03-impl-log.md`
32
+
33
+ ```markdown
34
+ # Implementation Log: {bug-id}
35
+
36
+ ## Branch
37
+ `hotfix/{bug-id}`
38
+
39
+ ## TDD Cycles
40
+
41
+ ### FR-001: {title}
42
+ - RED: {test file}:{test name} — FAILED ✓
43
+ - GREEN: {changed files} — PASSED ✓
44
+ - REFACTOR: {what was cleaned}
45
+
46
+ ### FR-002: {title} (if applicable)
47
+ ...
48
+
49
+ ## Files Changed
50
+ | File | Change type | Lines |
51
+ |------|-------------|-------|
52
+ | {file} | Modified / Added | +{n} -{m} |
53
+
54
+ ## Test Results
55
+ - New tests: {count}
56
+ - Regression test: {test name} — PASS
57
+ - Full suite: {total} tests, all PASS
58
+
59
+ ## SonarQube
60
+ - Issues: 0
61
+ - Vulnerabilities: 0
62
+ - Duplication: {n}%
63
+
64
+ ## Build
65
+ - Compile: PASS
66
+ - Full test suite: PASS
67
+
68
+ ## Verification Evidence
69
+
70
+ | # | Check | Result | Evidence |
71
+ |---|-------|--------|----------|
72
+ | 1 | Build compiles | ✅ PASS | `{actual build output line}` |
73
+ | 2 | All tests pass | ✅ PASS | `{X} passed, 0 failed` |
74
+ | 3 | Regression test | ✅ PASS | `{test name} — PASSED` |
75
+ | 4 | SonarQube clean | ✅ PASS | 0 blocker, 0 critical, 0 vuln |
76
+ | 5 | Impact clean | ✅ PASS | Blast radius = {files}, matches analysis |
77
+ | 6 | Scope held | ✅ PASS | `git diff --stat`: {n} files changed, all within scope |
78
+ ```
79
+
80
+ ## Phase Exit Protocol
81
+
82
+ Print PHASE REPORT:
83
+ - Bug: {bug-id}
84
+ - Status: IMPLEMENTATION COMPLETED
85
+ - Branch: `hotfix/{bug-id}`
86
+ - Tests: {new} new, {total} total — all PASS
87
+ - Files changed: {count}
88
+ - Output: `.vsaf/docs/hotfixes/{bug-id}/03-impl-log.md`
89
+ - Next step: `/sdlc-hotfix-ship`
90
+
91
+ Update `.vsaf/docs/STATUS.md`.
92
+
93
+ > Artifacts saved. If the session is interrupted, open a new session and run the next phase — data is safe.
94
+
95
+ ## Rules
96
+
97
+ - ⛔ Do NOT write code without a failing test first (TDD)
98
+ - ⛔ Do NOT modify `graphify-out/` or `.gitnexus/`
99
+ - ⛔ Do NOT exceed scope boundary defined in PRD
100
+ - ⛔ Do NOT use subagent-driven development — hotfixes are sequential, focused
101
+ - Code MUST compile — hard gate, no exceptions
102
+ - Full test suite MUST pass — no regressions allowed
103
+ - If fix fails 3 times → STOP, escalate to user
104
+ - If scope drift detected → STOP, go back to PRD
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-impact
3
+ description: "Hotfix Implement 6/6 — impact verification"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 6/6 — impact verification
9
+
10
+ @include(step.md)
@@ -0,0 +1,15 @@
1
+ ### Step 6: Impact Verification
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [6/6] Impact verification via GitNexus... ⏳
5
+ ```
6
+
7
+ Use GitNexus `impact` — verify the fix did not break anything outside blast radius.
8
+
9
+ If unexpected impact detected → evaluate:
10
+ - Within scope boundary → OK, note in impl log
11
+ - Outside scope boundary → STOP, escalate to user
12
+
13
+ ```
14
+ [HOTFIX-IMPL] [6/6] Impact verification... ✅
15
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-sonar
3
+ description: "Hotfix Implement 4/6 — SonarQube self-check"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 4/6 — SonarQube self-check
9
+
10
+ @include(step.md)
@@ -0,0 +1,27 @@
1
+ ### Step 4: SonarQube Self-Check
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [4/6] SonarQube quality check... ⏳
5
+ ```
6
+
7
+ Apply DURING Step 3 (not after). After the fix is complete, final sweep.
8
+
9
+ > **Standard (single source of truth):** **`.claude/skills/_shared/sdlc/sonar-viettel/quality-gate.md`** — full gate, 357-rule parameters, and the importable `sonar-viettel-profile.xml` / `sonar-viettel-gate.json`. Phase 4 (`/sdlc-hotfix-review`) re-checks the same file. A hotfix applies the gate's **New Code** conditions on changed files.
10
+
11
+ | Metric | Threshold |
12
+ |--------|-----------|
13
+ | Issues / Blocker / Critical / Major | = 0 |
14
+ | Code Smells (new) | = 0 — stricter than the gate's ≤20 **by design**: a surgical 1–3 line fix has no excuse to add a smell, and `/sdlc-hotfix-review` rejects any new smell |
15
+ | Vulnerabilities | = 0 |
16
+ | Security Hotspots Reviewed | = 100% |
17
+ | Duplicated Lines (new) | ≤ 45% |
18
+ | Maintainability / Reliability / Security Rating | ≥ A |
19
+
20
+ **Honour the `sonar-viettel` parametrised rules in the changed code** — S107 (params), S3776 (complexity), S1192 (literals), S2068/S2077 (secrets/injection), S100/S101/S115 (naming). **Thresholds are authoritative in the profile XML** — derive them via the snippet in the shared `quality-gate.md`, do not hard-code numbers.
21
+
22
+ - If project has SonarQube → import the profile + gate from the shared folder, then run `sonar-scanner` incremental
23
+ - If not → Claude self-reviews changed files against the shared `quality-gate.md`
24
+
25
+ ```
26
+ [HOTFIX-IMPL] [4/6] SonarQube quality check... ✅
27
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-tdd
3
+ description: "Hotfix Implement 3/6 — TDD cycle"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 3/6 — TDD cycle
9
+
10
+ @include(step.md)
@@ -0,0 +1,33 @@
1
+ ### Step 3: TDD Cycle — `/tdd` Methodology
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [3/6] TDD cycle — RED → GREEN → REFACTOR... ⏳
5
+ ```
6
+
7
+ Use `/tdd` methodology — behavior-based, vertical slice:
8
+
9
+ **For each FR in the PRD:**
10
+
11
+ 1. **RED — Write failing test FIRST**
12
+ - Test the BEHAVIOR described in the acceptance criteria
13
+ - Test the PUBLIC INTERFACE, not internals
14
+ - Include the regression test: reproduce the original bug → MUST FAIL before fix
15
+ - Run test → confirm it FAILS (red)
16
+ - ⚠️ If test passes without code changes → the test is wrong or the bug is already fixed
17
+
18
+ 2. **GREEN — Write MINIMAL code to pass**
19
+ - Change ONLY what is needed to make the test pass
20
+ - Stay within the scope boundary from PRD
21
+ - Apply SonarQube rules while writing (see below)
22
+ - Run test → confirm it PASSES (green)
23
+
24
+ 3. **REFACTOR — Clean without changing behavior**
25
+ - Remove duplication introduced by the fix
26
+ - Improve naming if needed
27
+ - Run ALL tests → still green
28
+
29
+ **Repeat for each FR.** Typically 1-3 cycles for a hotfix.
30
+
31
+ ```
32
+ [HOTFIX-IMPL] [3/6] TDD cycle complete ✅
33
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-implement-verify
3
+ description: "Hotfix Implement 5/6 — build and test verification"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Implement 5/6 — build and test verification
9
+
10
+ @include(step.md)
@@ -0,0 +1,27 @@
1
+ ### Step 5: Build & Test Verification
2
+
3
+ ```
4
+ [HOTFIX-IMPL] [5/6] Build & test verification... ⏳
5
+ ```
6
+
7
+ **MANDATORY — hard gate:**
8
+
9
+ 1. **Compile**: Build entire project → 0 errors
10
+ - Java: `mvn compile` / `gradle build`
11
+ - Node: `npm run build` / `tsc --noEmit`
12
+ - Angular: `ng build`
13
+ - Go: `go build ./...`
14
+ - FAIL → fix immediately
15
+
16
+ 2. **Full test suite**: Run ALL tests (not just new ones)
17
+ - `npm test` / `mvn test` / equivalent
18
+ - ALL tests MUST pass — no regressions
19
+ - FAIL → use `/diagnose` to find the issue
20
+
21
+ 3. **Regression test confirmation**: The specific test from Step 3 RED phase → now PASSES
22
+
23
+ ⚠️ DO NOT exit if build fails or tests fail. This is a hard gate.
24
+
25
+ ```
26
+ [HOTFIX-IMPL] [5/6] Build & test verification... ✅
27
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-prd-entry
3
+ description: "Hotfix PRD 1/4 — check input artifacts"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix PRD 1/4 — check input artifacts
9
+
10
+ @include(step.md)
@@ -0,0 +1,20 @@
1
+ ## Phase Entry Protocol
2
+
3
+ ```
4
+ [HOTFIX-PRD] [1/4] Checking input artifacts... ⏳
5
+ ```
6
+
7
+ 1. Input: `.vsaf/docs/hotfixes/{bug-id}/01-analysis.md`
8
+ 2. Verify file exists:
9
+ - Does not exist → Stop: "Analysis not found. Run `/sdlc-hotfix-analyze` first."
10
+ 3. Read the analysis file — extract:
11
+ - Root cause (file:line)
12
+ - Blast radius
13
+ - Fix strategy (proposed in analyze phase)
14
+ - Affected files
15
+ 4. Read `.vsaf/docs/STATUS.md`
16
+ 5. Read `CONTEXT.md`
17
+
18
+ ```
19
+ [HOTFIX-PRD] [1/4] Checking input artifacts... ✅
20
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-prd-gate
3
+ description: "Hotfix PRD — gate and rules"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix PRD — gate and rules
9
+
10
+ @include(step.md)
@@ -0,0 +1,32 @@
1
+ ## Gate: {PENDING / APPROVED by {name} on {date}}
2
+ ```
3
+
4
+ ```
5
+ [HOTFIX-PRD] [4/4] Writing hotfix PRD... ✅
6
+ ```
7
+
8
+ ## Gate
9
+
10
+ Human must approve the PRD. Write `## Gate: APPROVED` at the end of the file.
11
+ Do NOT proceed to implementation without the Gate marker.
12
+
13
+ ## Phase Exit Protocol
14
+
15
+ Print PHASE REPORT:
16
+ - Bug: {bug-id}
17
+ - Status: PRD COMPLETED
18
+ - FRs: {count} functional requirements
19
+ - Output: `.vsaf/docs/hotfixes/{bug-id}/02-prd.md`
20
+ - Next step: `/sdlc-hotfix-implement`
21
+
22
+ Update `.vsaf/docs/STATUS.md`.
23
+
24
+ > Artifacts saved. If the session is interrupted, open a new session and run the next phase — data is safe.
25
+
26
+ ## Rules
27
+
28
+ - ⛔ Do NOT start a new grill session — analysis already has grill results
29
+ - ⛔ Do NOT modify `graphify-out/` or `.gitnexus/`
30
+ - ⛔ Do NOT add enhancements — hotfix scope only
31
+ - Scope MUST be minimal — fix root cause, add regression test, nothing more
32
+ - Every FR MUST be directly traceable to the root cause or blast radius
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-prd-requirements
3
+ description: "Hotfix PRD 2/4 — define fix requirements"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix PRD 2/4 — define fix requirements
9
+
10
+ @include(step.md)
@@ -0,0 +1,19 @@
1
+ ### Step 2: Define Fix Requirements
2
+
3
+ ```
4
+ [HOTFIX-PRD] [2/4] Defining fix requirements from analysis... ⏳
5
+ ```
6
+
7
+ Based on the analysis (NOT a new grill session — that already happened), define:
8
+
9
+ 1. **Fix Goal** — one sentence: what the fix achieves
10
+ 2. **Functional Requirements** — FR-001, FR-002... (typically 1-3 for a hotfix)
11
+ - Each FR traces to the root cause or blast radius item
12
+ 3. **Acceptance Criteria** — Given/When/Then for each FR
13
+ - MUST include a regression test criterion: "Given the fix is applied, When {original reproduction steps}, Then {expected behavior}"
14
+ 4. **Scope Boundary** — explicitly state what is OUT of scope (no refactoring, no enhancements)
15
+ 5. **Non-Functional Requirements** — only if relevant (performance regression, security)
16
+
17
+ ```
18
+ [HOTFIX-PRD] [2/4] Defining fix requirements... ✅
19
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-prd-validate
3
+ description: "Hotfix PRD 3/4 — validate and risk check"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix PRD 3/4 — validate and risk check
9
+
10
+ @include(step.md)
@@ -0,0 +1,19 @@
1
+ ### Step 3: Validate + Risk Check
2
+
3
+ ```
4
+ [HOTFIX-PRD] [3/4] Validating PRD... ⏳
5
+ ```
6
+
7
+ Use `/bmad-validate-prd` — validate:
8
+ - Every FR is testable
9
+ - Acceptance criteria are unambiguous
10
+ - Scope is minimal (hotfix, not enhancement)
11
+ - Fix addresses root cause, not just symptom
12
+
13
+ If FAIL → fix inline, re-validate.
14
+
15
+ Use GitNexus `impact` — confirm blast radius from analysis is still accurate.
16
+
17
+ ```
18
+ [HOTFIX-PRD] [3/4] Validating PRD... ✅
19
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-prd-write
3
+ description: "Hotfix PRD 4/4 — write PRD"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix PRD 4/4 — write PRD
9
+
10
+ @include(step.md)
@@ -0,0 +1,38 @@
1
+ ### Step 4: Write PRD
2
+
3
+ ```
4
+ [HOTFIX-PRD] [4/4] Writing hotfix PRD... ⏳
5
+ ```
6
+
7
+ Write file: `.vsaf/docs/hotfixes/{bug-id}/02-prd.md`
8
+
9
+ ```markdown
10
+ # Hotfix PRD: {bug-id}
11
+
12
+ ## Fix Goal
13
+ {one sentence}
14
+
15
+ ## Source
16
+ - Analysis: `01-analysis.md`
17
+ - Root cause: {file:line — summary}
18
+
19
+ ## Functional Requirements
20
+
21
+ ### FR-001: {title}
22
+ {description}
23
+
24
+ **Acceptance Criteria:**
25
+ - Given {context}, When {action}, Then {expected result}
26
+
27
+ ### FR-002: {title} (if needed)
28
+ ...
29
+
30
+ ## Non-Functional Requirements
31
+ {NFR-001 if applicable, otherwise "N/A — no NFR impact for this fix"}
32
+
33
+ ## Scope Boundary
34
+ **In scope:** {what will change}
35
+ **Out of scope:** {what will NOT change — no refactoring, no enhancements}
36
+
37
+ ## Blast Radius (confirmed)
38
+ {from GitNexus impact — files that may be affected}
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-review-entry
3
+ description: "Hotfix Review 1/4 — load context"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Review 1/4 — load context
9
+
10
+ @include(step.md)
@@ -0,0 +1,13 @@
1
+ ## Phase Entry Protocol
2
+
3
+ ```
4
+ [HOTFIX-REVIEW] [1/4] Loading context... ⏳
5
+ ```
6
+
7
+ 1. Read `.vsaf/docs/hotfixes/{bug-id}/01-analysis.md` — understand what was supposed to change
8
+ 2. Read `CONTEXT.md`
9
+ 3. Identify all files changed in the GREEN phase (use git diff or read the phase report)
10
+
11
+ ```
12
+ [HOTFIX-REVIEW] [1/4] Loading context... ✅
13
+ ```
@@ -0,0 +1,10 @@
1
+ ---
2
+ name: sdlc-hotfix-review-gate
3
+ description: "Hotfix Review — gate and rules"
4
+ version: 1.0.0
5
+ author: "@ngocsangairvds/vsaf"
6
+ ---
7
+
8
+ # Hotfix Review — gate and rules
9
+
10
+ @include(step.md)