@ngocsangairvds/vsaf 4.1.24 → 4.1.26

package/skills/sdlc/srs/SKILL.md

@@ -1,17 +1,17 @@
 ---
 name: srs
-description: Phase 4 — SRS via BMAD analyst + edge case hunter + GitNexus interface verification
-version: 1.0.0
+description: "Phase 4 — SRS via ba-write-srs template + ba-validate-srs 8-dimension validation + GitNexus interface verification"
+version: 2.0.0
 author: "@ngocsangairvds/vsaf"
 ---
 
 # Phase 4: SRS (Software Requirements Specification)
 
-You are a Senior Business Analyst. Your mission: write a detailed SRS with traceability, edge cases, and interface verification.
+You are a Senior Business Analyst. Your mission: write a detailed SRS using the v4 template, validate it across 8 quality dimensions, and verify interface contracts.
 
 ## Language Rule
 
-All output documents (05-srs.md) MUST be written in Vietnamese. Section headers, requirements, edge case descriptions, analysis — all in Vietnamese. Only keep English for: IDs (FR-001, NFR-001, EC-001), technical terms (API, database, endpoint), and code references (class names, method signatures).
+All output documents (05-srs.md) MUST be written in Vietnamese. Section headers, requirements, use cases, analysis — all in Vietnamese. Only keep English for: IDs (FR-001, NFR-001, UC-XX-01), technical terms (API, database, endpoint), and code references (class names, method signatures).
 
 ## Index Protection
 
@@ -20,71 +20,80 @@ All output documents (05-srs.md) MUST be written in Vietnamese. Section headers,
 ## Phase Entry Protocol
 
 ```
-[SRS] [1/3] Checking input artifacts... ⏳
+[SRS] [1/4] Checking input artifacts... ⏳
 ```
 
 1. Input:
    - `.vsaf/docs/features/{feature-name}/02-prd.md`
    - `.vsaf/docs/features/{feature-name}/03-adr.md`
    - `.vsaf/docs/features/{feature-name}/04-epics.md`
-2. Verify ALL 3 files exist:
-   - Any file missing → Ask: "File not found. Have you pulled it yet?"
+2. Verify 02-prd.md AND 03-adr.md exist (04-epics.md optional):
+   - Any required file missing → Ask: "File not found. Have you run Phase 2 (PRD) and Phase 3 (Architecture)?"
 3. Read `.vsaf/docs/STATUS.md`
 4. Read `CONTEXT.md`
-5. Query `graph.json` for code structure + business mapping
+5. Query `graph.json` for code structure + business mapping (if exists)
 
 ```
-[SRS] [1/3] Checking input artifacts... ✅
+[SRS] [1/4] Checking input artifacts... ✅
 ```
 
 ## Tasks
 
-### Step 1: Write SRS
+### Step 2: Write SRS
 
 ```
-[SRS] [2/3] Writing SRS from PRD + ADR... ⏳
+[SRS] [2/4] Writing SRS from PRD + ADR + Epics... ⏳
 ```
 
-Use `/bmad-agent-analyst` — analyze PRD + ADR to identify gaps, ambiguities, and missing requirements before writing the SRS.
+Use `/ba-write-srs` — write SRS following the v4 template (12 sections) from PRD + Architecture + Epics.
 
-Derive SRS from PRD + ADR + analyst findings. For each FR/NFR:
+Input:
+- `02-prd.md` as PRD source
+- `03-adr.md` as architecture context
+- `04-epics.md` as epic breakdown (optional)
+- Figma link from `CONTEXT.md` (optional)
 
-1. **Unique ID** — FR-001, NFR-001 (sequential, no gaps)
-2. **Traceability** — trace to PRD user story (US-xxx)
-3. **Input/Output spec** — `{class}.{method}({params}): {return}` or API contract
-4. **Constraints** — performance, security, data validation rules
-5. **Pre/Post conditions** — system state before and after execution
-
-Write to `05-srs.md`.
+Output: `.vsaf/docs/features/{feature-name}/05-srs.md`
 
 ```
-[SRS] [2/3] Writing SRS from PRD + ADR... ✅
+[SRS] [2/4] Writing SRS from PRD + ADR + Epics... ✅
 ```
 
-### Step 2: Edge Case Analysis
+### Step 3: Validate SRS
 
 ```
-[SRS] [2.5/3] Edge case analysis... ⏳
+[SRS] [3/4] Validating SRS (8 dimensions)... ⏳
 ```
 
-Use `/bmad-review-edge-case-hunter` — walk every boundary condition.
-Write to `05-srs.md` §Edge Cases.
+Use `/ba-validate-srs` — validate SRS across 8 dimensions with weighted scoring.
+
+- Scope: single file (`05-srs.md`)
+- Cross-validate against: `02-prd.md`, `03-adr.md`
+- Output: `.vsaf/docs/features/{feature-name}/05-srs-validation-report.md`
+
+**Decision handling:**
+
+| Validation Result | Action |
+|---|---|
+| **GO** (≥80%, no CRITICAL) | Print score summary, proceed to Step 4 |
+| **CONDITIONAL GO** (60-79% or HIGH findings) | Print warnings + finding summary. Ask user: "Proceed despite warnings? (Y/N)" |
+| **NO-GO** (<60% or CRITICAL findings) | **STOP.** Print CRITICAL findings. Ask user to fix 05-srs.md and re-run `/sdlc-srs` |
 
 ```
-[SRS] [2.5/3] Edge case analysis... ✅
+[SRS] [3/4] Validating SRS (8 dimensions)... ✅
 ```
 
-### Step 3: Interface Verification
+### Step 4: Interface Verification
 
 ```
-[SRS] [3/3] Interface verification via GitNexus... ⏳
+[SRS] [4/4] Interface verification via GitNexus... ⏳
 ```
 
 Use GitNexus `shape_check` — verify code structure matches SRS assumptions.
-Write to `05-srs.md` §Interface Contracts.
+Append results to `05-srs.md` §Interface Contracts.
 
 ```
-[SRS] [3/3] Interface verification via GitNexus... ✅
+[SRS] [4/4] Interface verification via GitNexus... ✅
 ```
 
 ## Gate
@@ -93,35 +102,14 @@ Human must approve SRS. Write `## Gate: APPROVED` at the end of the file.
 
 ## Output
 
-Write file: `.vsaf/docs/features/{feature-name}/05-srs.md`
-
-```markdown
-# SRS: {feature-name}
-
-## FR-001: {requirement}
-- Traces to: PRD §US-{id}
-- Interface: `{class}.{method}({params}): {return}`
-- Constraints: ...
-- Edge cases: EC-001, EC-002
-
-## FR-002: ...
-
-## NFR-001: ...
-
-## Edge Cases
-- EC-001: {boundary condition}
-- EC-002: {race condition / null / overflow}
-
-## Interface Contracts
-{GitNexus shape_check result}
-
-## Gate: {PENDING / APPROVED by {name} on {date}}
-```
+- `.vsaf/docs/features/{feature-name}/05-srs.md` — SRS document (v4 template format)
+- `.vsaf/docs/features/{feature-name}/05-srs-validation-report.md` — Validation report with scores
 
 ## Phase Exit Protocol
 
 In PHASE REPORT:
-- Output files: `.vsaf/docs/features/{feature-name}/05-srs.md`
+- Output files: `05-srs.md`, `05-srs-validation-report.md`
+- Validation score: {overall_score}% ({GO/CONDITIONAL GO/NO-GO})
 - Suggestions: [1] Phase 5 Test Design (`/sdlc-test-design`) [2] Save artifacts
 
 Update `.vsaf/docs/STATUS.md`.
@@ -135,4 +123,5 @@ Update `.vsaf/docs/STATUS.md`.
 - DO NOT use vague language: "should", "might", "optionally" → replace with "MUST", "MUST NOT"
 - All terms MUST exist in CONTEXT.md
 - Every FR MUST be testable (have clear pass/fail criteria)
+- SRS MUST follow the v4 template structure (12 sections)
 - ⛔ DO NOT modify `graphify-out/` or `.gitnexus/`

package/skills/vds-skill/install-deps.mjs

@@ -9,7 +9,7 @@
  *   node install-deps.mjs <projectPath> <packDir> [--force]
  *
  * What it does:
- *   1. Checks Python >= 3.14
+ *   1. Checks Python >= 3.12
  *   2. Ensures uv is installed
  *   3. Copies runtime to ~/.claude/vds-scripts/
  *   4. Runs uv sync
@@ -23,7 +23,25 @@ import { homedir } from 'os';
 
 const IS_WIN = process.platform === 'win32';
 const IS_MAC = process.platform === 'darwin';
-const PYTHON = IS_WIN ? 'python' : 'python3';
+
+let _resolvedPython;
+
+function resolvePython() {
+  if (_resolvedPython) return _resolvedPython;
+  const candidates = IS_WIN
+    ? ['python3', 'python', 'py']
+    : ['python3', 'python'];
+  for (const cmd of candidates) {
+    try {
+      const out = execSync(`${cmd} --version`, { encoding: 'utf-8', stdio: 'pipe' });
+      if (out.includes('Python')) { _resolvedPython = cmd; return cmd; }
+    } catch { /* not available */ }
+  }
+  _resolvedPython = IS_WIN ? 'python' : 'python3';
+  return _resolvedPython;
+}
+
+const PYTHON = resolvePython();
 const VDS_DIR = join(homedir(), '.claude', 'vds-scripts');
 const ENV_DIR = join(homedir(), '.vds');
 const ENV_FILE = join(ENV_DIR, '.env');
@@ -37,7 +55,7 @@ function log(icon, msg) {
   console.log(`  ${icon} ${msg}`);
 }
 
-// ── 1. Check Python >= 3.14 ──
+// ── 1. Check Python >= 3.12 ──
 
 function checkPython() {
   try {