@ngocsangairvds/vsaf 3.2.14 → 3.2.15

package/tools/vds-scripts/audit_orchestrator/tests/unit/test_dispatch_coordinator_phase158.py

@@ -1,402 +0,0 @@
-"""Tests for Phase 158 DispatchPlan and DispatchCoordinator (TSK-158.X4).
-
-Covers:
-- DispatchPlan frozen dataclass construction and defaults
-- DispatchCoordinator.dispatch() delegation to _dispatch_multi_profile_workflows
-- from_workflow_project() factory with dynamic max_concurrent scaling
-- from_auto_promote() factory with safety caps and --no-auto-parallel
-"""
-
-from __future__ import annotations
-
-from pathlib import Path
-from unittest.mock import patch
-
-import pytest
-from vds_audit_orchestrator.workflow_cmds import (
-    _MAX_AUTO_PROMOTE_CONCURRENT,
-    _MIN_ROWS_FOR_AUTO_PROMOTE,
-    DispatchCoordinator,
-    DispatchPlan,
-    ShardingMode,
-)
-
-# ── DispatchPlan construction ─────────────────────────────────────────
-
-
-class TestDispatchPlan:
-    def test_required_fields(self) -> None:
-        plan = DispatchPlan(
-            profiles=["p1", "p2"],
-            repos=[("repo-a", Path("/tmp/repo-a"))],
-            thread_id="t-1",
-            project_storage_key="proj-1",
-        )
-        assert plan.profiles == ["p1", "p2"]
-        assert plan.repos == [("repo-a", Path("/tmp/repo-a"))]
-        assert plan.thread_id == "t-1"
-        assert plan.project_storage_key == "proj-1"
-
-    def test_defaults(self) -> None:
-        plan = DispatchPlan(
-            profiles=["p1"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-        )
-        assert plan.max_concurrent == 16  # Phase 164+: default raised to 16
-        assert plan.failover is True
-        assert plan.row_sharded_dispatch is False
-        assert plan.strict_db_native is False
-        assert plan.sharding_mode == ShardingMode.ENSEMBLE
-        assert plan.extra_workflow_args == []
-
-    def test_frozen_immutability(self) -> None:
-        plan = DispatchPlan(
-            profiles=["p1"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-        )
-        with pytest.raises(AttributeError):
-            plan.max_concurrent = 99  # type: ignore[misc]
-
-
-# ── DispatchCoordinator.dispatch() ────────────────────────────────────
-
-
-class TestDispatchCoordinatorDispatch:
-    def test_dispatch_delegates_to_engine(self) -> None:
-        plan = DispatchPlan(
-            profiles=["p1", "p2"],
-            repos=[("repo-a", Path("/tmp/repo-a"))],
-            thread_id="t-1",
-            project_storage_key="proj-1",
-            max_concurrent=8,
-        )
-        coordinator = DispatchCoordinator(plan)
-        with patch(
-            "vds_audit_orchestrator.workflow_cmds._dispatch_multi_profile_workflows",
-            return_value={"status": "completed", "jobs_completed": 2},
-        ) as mock_dispatch:
-            result = coordinator.dispatch()
-
-        assert result["status"] == "completed"
-        mock_dispatch.assert_called_once()
-        call_kwargs = mock_dispatch.call_args.kwargs
-        assert call_kwargs["profiles"] == ["p1", "p2"]
-        assert call_kwargs["thread_id"] == "t-1"
-        assert call_kwargs["max_concurrent"] == 8
-
-    def test_dispatch_passes_all_plan_fields(self) -> None:
-        """Verify every DispatchPlan field is forwarded."""
-        plan = DispatchPlan(
-            profiles=["p1"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-            extra_workflow_args=["--ast-grep"],
-            failover=False,
-            strict_db_native=True,
-            dispatch_poll_seconds=2.0,
-        )
-        coordinator = DispatchCoordinator(plan)
-        with patch(
-            "vds_audit_orchestrator.workflow_cmds._dispatch_multi_profile_workflows",
-            return_value={},
-        ) as mock_dispatch:
-            coordinator.dispatch()
-
-        kw = mock_dispatch.call_args.kwargs
-        assert kw["extra_workflow_args"] == ["--ast-grep"]
-        assert kw["failover"] is False
-        assert kw["strict_db_native"] is True
-        assert kw["dispatch_poll_seconds"] == 2.0
-
-
-# ── from_workflow_project() factory ───────────────────────────────────
-
-
-class TestFromWorkflowProject:
-    def test_basic_construction(self) -> None:
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=["p1", "p2"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-        )
-        assert coordinator.plan.profiles == ["p1", "p2"]
-        assert coordinator.plan.sharding_mode == ShardingMode.ENSEMBLE
-
-    def test_dynamic_max_concurrent_scales_up(self) -> None:
-        """Phase 164+: default=16, 7 profiles → 16 > 7*2=14 → max(14,4)=14."""
-        profiles = [f"p{i}" for i in range(7)]
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=profiles,
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-        )
-        assert coordinator.plan.max_concurrent == 14  # max(2*7, 4) = 14
-
-    def test_dynamic_max_concurrent_caps_at_16(self) -> None:
-        """Phase 164+: 12 profiles with default=16 → 16 ≤ 24, no down-scale → 16."""
-        profiles = [f"p{i}" for i in range(12)]
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=profiles,
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-        )
-        assert coordinator.plan.max_concurrent == 16
-
-    def test_preserves_explicit_max_concurrent(self) -> None:
-        """When operator sets max_concurrent explicitly and profiles fit, keep it."""
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=["p1", "p2", "p3"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-            max_concurrent=4,
-        )
-        assert coordinator.plan.max_concurrent == 4
-
-    def test_sharding_mode_forwarded(self) -> None:
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=["p1"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-            sharding_mode=ShardingMode.HORIZONTAL,
-        )
-        assert coordinator.plan.sharding_mode == ShardingMode.HORIZONTAL
-
-
-# ── from_auto_promote() factory ───────────────────────────────────────
-
-
-class TestFromAutoPromote:
-    def test_basic_construction(self) -> None:
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=["p1", "p2"],
-            repo_path=Path("/tmp/repo-a"),
-            repo_key="repo-a",
-            thread_id="t-1",
-            project_storage_key="proj-1",
-            row_keys=["CL-1", "CL-2", "CL-3", "CL-4"],
-        )
-        plan = coordinator.plan
-        assert plan.repos == [("repo-a", Path("/tmp/repo-a"))]
-        assert plan.row_sharded_dispatch is True
-        assert plan.no_checklist_readiness_gate is True
-
-    def test_no_auto_parallel_in_extra_args(self) -> None:
-        """AC-158.1.2: --no-auto-parallel prevents recursive promotion."""
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=["p1", "p2"],
-            repo_path=Path("/tmp/r"),
-            repo_key="r",
-            thread_id="t",
-            project_storage_key="p",
-            row_keys=["CL-1", "CL-2", "CL-3"],
-        )
-        assert "--no-auto-parallel" in coordinator.plan.extra_workflow_args
-
-    def test_max_concurrent_capped_at_safety_limit(self) -> None:
-        """AC-158.5.1: max_concurrent capped at 16."""
-        profiles = [f"p{i}" for i in range(20)]
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=profiles,
-            repo_path=Path("/tmp/r"),
-            repo_key="r",
-            thread_id="t",
-            project_storage_key="p",
-            row_keys=[f"CL-{i}" for i in range(30)],
-        )
-        assert coordinator.plan.max_concurrent == _MAX_AUTO_PROMOTE_CONCURRENT
-        assert coordinator.plan.max_concurrent == 16
-
-    def test_explicit_max_concurrent_respected_within_cap(self) -> None:
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=["p1", "p2", "p3", "p4"],
-            repo_path=Path("/tmp/r"),
-            repo_key="r",
-            thread_id="t",
-            project_storage_key="p",
-            row_keys=[f"CL-{i}" for i in range(10)],
-            max_concurrent=3,
-        )
-        assert coordinator.plan.max_concurrent == 3
-
-    def test_extra_workflow_args_preserved(self) -> None:
-        """Extra args from caller are preserved alongside --no-auto-parallel."""
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=["p1", "p2"],
-            repo_path=Path("/tmp/r"),
-            repo_key="r",
-            thread_id="t",
-            project_storage_key="p",
-            row_keys=["CL-1", "CL-2", "CL-3"],
-            extra_workflow_args=["--ast-grep", "--knowledge-agent"],
-        )
-        args = coordinator.plan.extra_workflow_args
-        assert "--ast-grep" in args
-        assert "--knowledge-agent" in args
-        assert "--no-auto-parallel" in args
-
-    def test_single_repo_in_plan(self) -> None:
-        coordinator = DispatchCoordinator.from_auto_promote(
-            available_profiles=["p1"],
-            repo_path=Path("/tmp/my-repo"),
-            repo_key="my-repo",
-            thread_id="t",
-            project_storage_key="p",
-            row_keys=["CL-1"],
-        )
-        assert len(coordinator.plan.repos) == 1
-        assert coordinator.plan.repos[0] == ("my-repo", Path("/tmp/my-repo"))
-
-
-# ── Safety guard constant tests ───────────────────────────────────────
-
-
-class TestAutoPromoteSafetyConstants:
-    def test_max_auto_promote_concurrent_value(self) -> None:
-        assert _MAX_AUTO_PROMOTE_CONCURRENT == 16
-
-    def test_min_rows_for_auto_promote_value(self) -> None:
-        assert _MIN_ROWS_FOR_AUTO_PROMOTE == 3
-
-
-# ── TSK-158.12a: Coordinator regression — identical dispatch ──────────
-
-
-class TestCoordinatorRegressionIdenticalDispatch:
-    """Verify coordinator dispatch passes all parameters identically to the engine.
-
-    The refactored workflow_project() uses DispatchCoordinator.from_workflow_project()
-    which must produce identical calls to _dispatch_multi_profile_workflows().
-    """
-
-    def test_all_plan_fields_forwarded_to_engine(self) -> None:
-        """Every DispatchPlan field maps to a _dispatch_multi_profile_workflows kwarg."""
-        plan = DispatchPlan(
-            profiles=["p1", "p2"],
-            repos=[("repo-a", Path("/tmp/repo-a")), ("repo-b", Path("/tmp/repo-b"))],
-            thread_id="t-regress",
-            project_storage_key="proj-regress",
-            evidence_context_id="ctx-1",
-            sharding_mode=ShardingMode.HORIZONTAL,
-            state_dsn="postgresql://test",
-            max_concurrent=4,
-            checklist_page_id="12345",
-            checklist_profile="default",
-            canonical_checklist=True,
-            no_checklist_readiness_gate=True,
-            extra_workflow_args=["--ast-grep", "--knowledge-agent"],
-            timeout_seconds=3600,
-            failover=False,
-            circuit_breaker_threshold=5,
-            primary_profile="p1",
-            rescue_profiles=["p2"],
-            cascade_quality_threshold=4.0,
-            collect_profile_stats=True,
-            auto_routing_weights=(0.5, 0.3, 0.2),
-            incremental_upload_callback=None,
-            require_all_profiles=True,
-            repo_checklist_topology={"repo-a": {"page_id": "111"}},
-            resume=False,
-            dispatch_manifest_path=Path("/tmp/manifest.json"),
-            dispatch_progress_state_path=Path("/tmp/progress.json"),
-            row_sharded_default_all=True,
-            row_sharded_dispatch=True,
-            retry_budget=2,
-            retry_backoff_seconds=3.0,
-            allow_direct_analysis_fallback=False,
-            extra_target="CL-001,CL-002",
-            dispatch_poll_seconds=2.5,
-            scope_id="scope-1",
-            pruned_profiles=["p3"],
-            strict_db_native=True,
-            submission_stagger_ms=500,
-        )
-        coordinator = DispatchCoordinator(plan)
-
-        with patch(
-            "vds_audit_orchestrator.workflow_cmds._dispatch_multi_profile_workflows",
-            return_value={"status": "completed", "results": [], "completed": 2},
-        ) as mock_dispatch:
-            result = coordinator.dispatch()
-
-        assert result["status"] == "completed"
-        kw = mock_dispatch.call_args.kwargs
-
-        # Verify every plan field is forwarded
-        assert kw["profiles"] == ["p1", "p2"]
-        assert kw["repos"] == [("repo-a", Path("/tmp/repo-a")), ("repo-b", Path("/tmp/repo-b"))]
-        assert kw["thread_id"] == "t-regress"
-        assert kw["project_storage_key"] == "proj-regress"
-        assert kw["evidence_context_id"] == "ctx-1"
-        assert kw["sharding_mode"] == ShardingMode.HORIZONTAL
-        assert kw["state_dsn"] == "postgresql://test"
-        assert kw["max_concurrent"] == 4
-        assert kw["checklist_page_id"] == "12345"
-        assert kw["checklist_profile"] == "default"
-        assert kw["canonical_checklist"] is True
-        assert kw["no_checklist_readiness_gate"] is True
-        assert kw["extra_workflow_args"] == ["--ast-grep", "--knowledge-agent"]
-        assert kw["timeout_seconds"] == 3600
-        assert kw["failover"] is False
-        assert kw["circuit_breaker_threshold"] == 5
-        assert kw["primary_profile"] == "p1"
-        assert kw["rescue_profiles"] == ["p2"]
-        assert kw["cascade_quality_threshold"] == 4.0
-        assert kw["collect_profile_stats"] is True
-        assert kw["auto_routing_weights"] == (0.5, 0.3, 0.2)
-        assert kw["incremental_upload_callback"] is None
-        assert kw["require_all_profiles"] is True
-        assert kw["repo_checklist_topology"] == {"repo-a": {"page_id": "111"}}
-        assert kw["resume"] is False
-        assert kw["dispatch_manifest_path"] == Path("/tmp/manifest.json")
-        assert kw["dispatch_progress_state_path"] == Path("/tmp/progress.json")
-        assert kw["row_sharded_default_all"] is True
-        assert kw["row_sharded_dispatch"] is True
-        assert kw["retry_budget"] == 2
-        assert kw["retry_backoff_seconds"] == 3.0
-        assert kw["allow_direct_analysis_fallback"] is False
-        assert kw["extra_target"] == "CL-001,CL-002"
-        assert kw["dispatch_poll_seconds"] == 2.5
-        assert kw["scope_id"] == "scope-1"
-        assert kw["pruned_profiles"] == ["p3"]
-        assert kw["strict_db_native"] is True
-        assert kw["submission_stagger_ms"] == 500
-
-    def test_factory_produces_same_dispatch_as_direct_call(self) -> None:
-        """from_workflow_project() + dispatch() calls the engine identically to direct invocation."""
-        coordinator = DispatchCoordinator.from_workflow_project(
-            profiles=["p1", "p2"],
-            repos=[("r", Path("/tmp/r"))],
-            thread_id="t",
-            project_storage_key="p",
-            state_dsn="postgresql://test",
-            max_concurrent=4,
-            failover=True,
-            strict_db_native=True,
-        )
-
-        with patch(
-            "vds_audit_orchestrator.workflow_cmds._dispatch_multi_profile_workflows",
-            return_value={"status": "ok"},
-        ) as mock_dispatch:
-            coordinator.dispatch()
-
-        kw = mock_dispatch.call_args.kwargs
-        # Key fields preserved through factory → plan → dispatch
-        assert kw["profiles"] == ["p1", "p2"]
-        assert kw["state_dsn"] == "postgresql://test"
-        assert kw["max_concurrent"] == 4
-        assert kw["failover"] is True
-        assert kw["strict_db_native"] is True
-        # Defaults propagated correctly
-        assert kw["resume"] is True
-        assert kw["row_sharded_dispatch"] is False

package/tools/vds-scripts/audit_orchestrator/tests/unit/test_dispatch_job_identity_p167a.py

@@ -1,238 +0,0 @@
-"""Unit tests for P167-A: Profile-agnostic dispatch_job_id (FR-167.1).
-
-Verifies that dispatch_job_id is stable across profile changes for the same row,
-and that different rows or shard indices produce distinct hashes.
-"""
-
-from __future__ import annotations
-
-from vds_audit_orchestrator import workflow_cmds
-
-# ---------------------------------------------------------------------------
-# Helper
-# ---------------------------------------------------------------------------
-
-
-def _make_identity(
-    *,
-    thread_id: str = "phase167",
-    repo_key: str = "test-repo",
-    profile: str = "profile-a",
-    origin_profile: str | None = None,
-    stage: str = "default",
-    extra_target: str | None = None,
-    extra_prior_run_id: str | None = None,
-    row_shard_index: int | None = None,
-    row_shard_count: int | None = None,
-    checklist_page_id: str | None = None,
-    checklist_profile_id: str | None = None,
-) -> dict:
-    job: dict = {
-        "repo_key": repo_key,
-        "repo_path": f"/tmp/{repo_key}",
-        "profile": profile,
-        "stage": stage,
-    }
-    if origin_profile is not None:
-        job["origin_profile"] = origin_profile
-    if extra_target is not None:
-        job["extra_target"] = extra_target
-    if extra_prior_run_id is not None:
-        job["extra_prior_run_id"] = extra_prior_run_id
-    if row_shard_index is not None:
-        job["row_shard_index"] = row_shard_index
-    if row_shard_count is not None:
-        job["row_shard_count"] = row_shard_count
-    if checklist_page_id is not None:
-        job["job_checklist_page_id"] = checklist_page_id
-    if checklist_profile_id is not None:
-        job["job_checklist_profile"] = checklist_profile_id
-    return workflow_cmds._dispatch_job_identity_payload(thread_id=thread_id, job=job)
-
-
-# ---------------------------------------------------------------------------
-# TSK-167.1 / TSK-167.2 — profile-agnostic hash stability
-# ---------------------------------------------------------------------------
-
-
-class TestDispatchJobIdProfileAgnostic:
-    """FR-167.1: same row → same dispatch_job_id regardless of executing profile."""
-
-    def test_same_row_different_profiles_produce_same_hash(self) -> None:
-        """Primary assertion: profile change alone must not change dispatch_job_id."""
-        id_a = _make_identity(profile="profile-a")
-        id_b = _make_identity(profile="profile-b")
-
-        assert id_a["dispatch_job_id"] == id_b["dispatch_job_id"]
-
-    def test_same_row_different_origin_profile_produces_same_hash(self) -> None:
-        """origin_profile (fallback profile after failover) must not affect hash."""
-        id_normal = _make_identity(profile="profile-a", origin_profile="profile-a")
-        id_fallback = _make_identity(profile="profile-b", origin_profile="profile-a")
-
-        assert id_normal["dispatch_job_id"] == id_fallback["dispatch_job_id"]
-
-    def test_same_row_multiple_profiles_all_produce_same_hash(self) -> None:
-        """Three different profiles all map to the same identity for the same row."""
-        profiles = ["zai-openai", "claude-sonnet", "gpt-5.4", "gemini-pro"]
-        ids = [_make_identity(profile=p) for p in profiles]
-        hashes = {i["dispatch_job_id"] for i in ids}
-
-        assert len(hashes) == 1, f"Expected 1 unique hash, got {len(hashes)}: {hashes}"
-
-    def test_profile_still_present_in_returned_metadata(self) -> None:
-        """Profile info is still returned in the payload dict (not removed, just not hashed)."""
-        identity = _make_identity(profile="profile-b", origin_profile="profile-a")
-
-        assert identity["executed_profile"] == "profile-b"
-        assert identity["origin_profile"] == "profile-a"
-
-    def test_dispatch_job_id_is_16_hex_chars(self) -> None:
-        """dispatch_job_id must be a 16-char hex prefix of the SHA-256."""
-        identity = _make_identity()
-        djid = identity["dispatch_job_id"]
-
-        assert len(djid) == 16
-        assert all(c in "0123456789abcdef" for c in djid)
-
-
-# ---------------------------------------------------------------------------
-# TSK-167.2 — different row/shard still produces different hash
-# ---------------------------------------------------------------------------
-
-
-class TestDispatchJobIdRowDistinction:
-    """Different rows or shards must still produce different dispatch_job_ids."""
-
-    def test_different_repo_key_produces_different_hash(self) -> None:
-        id_a = _make_identity(repo_key="repo-alpha")
-        id_b = _make_identity(repo_key="repo-beta")
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-
-    def test_different_thread_id_produces_different_hash(self) -> None:
-        id_a = _make_identity(thread_id="phase167-run-1")
-        id_b = _make_identity(thread_id="phase167-run-2")
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-
-    def test_different_row_shard_index_produces_different_hash(self) -> None:
-        id_a = _make_identity(row_shard_index=0, row_shard_count=3)
-        id_b = _make_identity(row_shard_index=1, row_shard_count=3)
-        id_c = _make_identity(row_shard_index=2, row_shard_count=3)
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-        assert id_b["dispatch_job_id"] != id_c["dispatch_job_id"]
-        assert id_a["dispatch_job_id"] != id_c["dispatch_job_id"]
-
-    def test_different_extra_target_produces_different_hash(self) -> None:
-        id_a = _make_identity(extra_target="CL-001,CL-002")
-        id_b = _make_identity(extra_target="CL-003,CL-004")
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-
-    def test_different_stage_produces_different_hash(self) -> None:
-        id_a = _make_identity(stage="default")
-        id_b = _make_identity(stage="rescue")
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-
-    def test_different_checklist_page_produces_different_hash(self) -> None:
-        id_a = _make_identity(checklist_page_id="88722450")
-        id_b = _make_identity(checklist_page_id="88729031")
-
-        assert id_a["dispatch_job_id"] != id_b["dispatch_job_id"]
-
-    def test_with_and_without_row_shard_index_differ(self) -> None:
-        """Non-sharded vs shard-0 must differ (row_shard_index=None vs 0)."""
-        id_non_sharded = _make_identity(row_shard_index=None)
-        id_shard_zero = _make_identity(row_shard_index=0, row_shard_count=1)
-
-        assert id_non_sharded["dispatch_job_id"] != id_shard_zero["dispatch_job_id"]
-
-
-# ---------------------------------------------------------------------------
-# TSK-167.2 — lane_thread_id is still profile-derived (unchanged from P166)
-# ---------------------------------------------------------------------------
-
-
-class TestLaneThreadIdStillProfileDerived:
-    """lane_thread_id is still derived from profile (changed in TSK-167.4, not here)."""
-
-    def test_lane_thread_id_reflects_executing_profile(self) -> None:
-        id_a = _make_identity(profile="profile-a")
-        id_b = _make_identity(profile="profile-b")
-
-        assert id_a["lane_thread_id"] == "phase167-profile-a"
-        assert id_b["lane_thread_id"] == "phase167-profile-b"
-
-    def test_lane_thread_id_includes_shard_index(self) -> None:
-        identity = _make_identity(profile="profile-a", row_shard_index=2, row_shard_count=4)
-
-        assert identity["lane_thread_id"] == "phase167-profile-a-shard-2"
-
-    def test_same_row_different_profiles_have_different_lane_thread_ids(self) -> None:
-        """Different profiles → different lane_thread_ids, but same dispatch_job_id."""
-        id_a = _make_identity(profile="profile-a")
-        id_b = _make_identity(profile="profile-b")
-
-        assert id_a["dispatch_job_id"] == id_b["dispatch_job_id"]
-        assert id_a["lane_thread_id"] != id_b["lane_thread_id"]
-
-
-# ---------------------------------------------------------------------------
-# TSK-167.2 — full row-sharded scenario matching the spec example
-# ---------------------------------------------------------------------------
-
-
-class TestDispatchJobIdShardedResumeScenario:
-    """Simulate a failover scenario: row was dispatched on profile-a, retried on profile-b."""
-
-    def test_failover_row_retains_same_dispatch_job_id(self) -> None:
-        """
-        Real-world scenario: merchant-billing shard 0 was dispatched to zai-openai,
-        failed, and is being retried on claude-sonnet. The dispatch_job_id must be
-        the same so the resume deduplication identifies it as already-attempted.
-        """
-        base_job = {
-            "repo_key": "par-merchant-billing",
-            "thread_id": "phase167-test",
-            "stage": "row_sharded",
-            "extra_target": "CL-001,CL-004",
-            "row_shard_index": 0,
-            "row_shard_count": 2,
-            "job_checklist_page_id": "88722450",
-        }
-
-        id_original = workflow_cmds._dispatch_job_identity_payload(
-            thread_id="phase167-test",
-            job={**base_job, "profile": "zai-openai", "origin_profile": "zai-openai"},
-        )
-        id_retry = workflow_cmds._dispatch_job_identity_payload(
-            thread_id="phase167-test",
-            job={**base_job, "profile": "claude-sonnet", "origin_profile": "zai-openai"},
-        )
-
-        assert id_original["dispatch_job_id"] == id_retry["dispatch_job_id"]
-        # lane_thread_ids differ — they point at different profile queues
-        assert id_original["lane_thread_id"] != id_retry["lane_thread_id"]
-
-    def test_sibling_shard_still_gets_different_hash(self) -> None:
-        """Shard 1 of the same run must always differ from shard 0, regardless of profiles."""
-        base = {
-            "repo_key": "par-merchant-billing",
-            "stage": "row_sharded",
-            "extra_target": "CL-001,CL-004",
-            "row_shard_count": 2,
-        }
-
-        id_shard0_profile_a = workflow_cmds._dispatch_job_identity_payload(
-            thread_id="phase167-test",
-            job={**base, "row_shard_index": 0, "profile": "profile-a"},
-        )
-        id_shard1_profile_b = workflow_cmds._dispatch_job_identity_payload(
-            thread_id="phase167-test",
-            job={**base, "row_shard_index": 1, "profile": "profile-b"},
-        )
-
-        assert id_shard0_profile_a["dispatch_job_id"] != id_shard1_profile_b["dispatch_job_id"]