@ngocsangairvds/vsaf 3.2.14 → 3.2.15

package/tools/vds-scripts/audit_orchestrator/tests/unit/engine/test_shared_library_routing_phase123.py

@@ -1,279 +0,0 @@
-"""Phase 123 tests for shared-library routing promotion (TSK-123.3, TSK-123.4).
-
-Covers:
-- FR-123.2: Common-lib rows must route to the shared-library lane
-- DD-123.9: Guidance text must be threaded to the requirement classifier
-- AC-123.2.1: Guidance markers promote rows into shared_library tag
-- AC-123.2.3: Telemetry when shared-library routing is skipped
-- DD-123.7: Guidance-required shared/common-lib sources preserved in evidence refs
-"""
-
-from __future__ import annotations
-
-from dataclasses import dataclass
-from typing import Any
-
-import pytest
-from vds_audit_orchestrator.engine.requirement_analysis import (
-    _SHARED_LIBRARY_MARKERS,
-    RequirementAnalysisResult,
-    derive_code_search_strategy,
-)
-
-# ---------------------------------------------------------------------------
-# Helpers
-# ---------------------------------------------------------------------------
-
-
-def _req(**kwargs: Any) -> RequirementAnalysisResult:
-    analysis_mode = kwargs.pop("analysis_mode", "code_first")
-    return RequirementAnalysisResult(
-        analysis_mode=analysis_mode,
-        analysis_reason_codes=kwargs.pop("analysis_reason_codes", []),
-        required_anchor_modalities=kwargs.pop("required_anchor_modalities", ["code"]),
-        project_scope_required=kwargs.pop("project_scope_required", False),
-        execution_scope_class=kwargs.pop("execution_scope_class", "repo_local"),
-        generic_anchor_exemption=kwargs.pop("generic_anchor_exemption", False),
-        minimum_substantive_code_anchors=kwargs.pop("minimum_substantive_code_anchors", 0),
-        finalization_policy=kwargs.pop("finalization_policy", "default"),
-        heuristic_confidence=kwargs.pop("heuristic_confidence", 0.75),
-        classification_source=kwargs.pop("classification_source", "heuristic"),
-        content_fingerprint=kwargs.pop("content_fingerprint", ""),
-        classification_fingerprint=kwargs.pop("classification_fingerprint", ""),
-        nlp_exemplar_similarity=kwargs.pop("nlp_exemplar_similarity", 0.0),
-    )
-
-
-# ---------------------------------------------------------------------------
-# TSK-123.3: Shared-library marker detection in classifier
-# ---------------------------------------------------------------------------
-
-
-class TestSharedLibraryMarkerDetection:
-    """Verify _derive_code_search_strategy_cached produces shared_library tag."""
-
-    def test_guidance_with_common_repo_marker_promotes_shared_library(self) -> None:
-        """AC-123.2.1: 'common repo' in guidance activates shared_library lane."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Kiểm tra dependency management",
-            category="Architecture",
-            guidance_text="Kiểm tra common repo và shared library của dự án",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-        assert hint.scope_hint == "lib"  # Phase 133: shared-library markers now target LIB scope
-        assert hint.escalation_scope == "all"
-
-    def test_guidance_with_page_88724032_promotes_shared_library(self) -> None:
-        """AC-123.2.1: Explicit page ID 88724032 in guidance activates shared_library."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Check code quality standards",
-            category="Quality",
-            guidance_text="Tham khảo tài liệu tại pageId=88724032 để kiểm tra",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-
-    def test_guidance_with_sdk_nen_tang_promotes_shared_library(self) -> None:
-        """AC-123.2.1: Vietnamese 'SDK nền tảng' in guidance activates shared_library."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Kiểm tra tích hợp SDK",
-            category="Integration",
-            guidance_text="Kiểm tra SDK nền tảng được sử dụng đúng cách",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-
-    def test_guidance_with_repo_dung_chung_promotes_shared_library(self) -> None:
-        """AC-123.2.1: Vietnamese 'repo dùng chung' in guidance activates shared_library."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Dependency check",
-            category="Architecture",
-            guidance_text="Kiểm tra repo dùng chung của dự án",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-
-    def test_requirement_text_with_shared_library_marker(self) -> None:
-        """AC-123.2.1: Marker in requirement_text (not guidance) also works."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Check shared library integration and dependency management",
-            category="Architecture",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-
-    def test_no_shared_library_marker_falls_through(self) -> None:
-        """Rows without shared-library markers should NOT get shared_library tag."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Check logging configuration",
-            category="Observability",
-            guidance_text="Verify structured logging is enabled",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag != "shared_library"
-
-    def test_shared_library_hint_uses_multi_pass_strategy(self) -> None:
-        """Shared-library hint should use multi_pass strategy for broad search."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Generic requirement",
-            category="Architecture",
-            guidance_text="Kiểm tra thư viện dùng chung",
-        )
-        assert hint is not None
-        assert hint.strategy == "multi_pass"
-        assert "search_docs" in hint.preferred_tools
-
-    def test_shared_library_takes_priority_over_general_code(self) -> None:
-        """Shared-library markers should override general_code fallback."""
-        hint = derive_code_search_strategy(
-            _req(analysis_mode="code_first"),
-            requirement_text="Check code implementation",
-            category="Code",
-            guidance_text="Kiểm tra common lib được sử dụng đúng",
-        )
-        assert hint is not None
-        assert hint.requirement_type_tag == "shared_library"
-        # Should NOT fall through to general_code
-        assert hint.requirement_type_tag != "general_code"
-
-
-# ---------------------------------------------------------------------------
-# TSK-123.3: Guidance text threading (DD-123.9)
-# ---------------------------------------------------------------------------
-
-
-class TestGuidanceTextThreading:
-    """Verify guidance_text parameter is accepted and used by the classifier."""
-
-    def test_guidance_text_parameter_accepted(self) -> None:
-        """DD-123.9: derive_code_search_strategy accepts guidance_text kwarg."""
-        # Should not raise
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="test",
-            category="test",
-            guidance_text="some guidance",
-        )
-        assert hint is not None
-
-    def test_empty_guidance_text_is_safe(self) -> None:
-        """Empty guidance_text should not break the classifier."""
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Check code quality",
-            category="Quality",
-            guidance_text="",
-        )
-        assert hint is not None
-
-    def test_none_guidance_text_is_safe(self) -> None:
-        """None guidance_text should be handled gracefully."""
-        # The public API converts None to "" via str()
-        hint = derive_code_search_strategy(
-            _req(),
-            requirement_text="Check code quality",
-            category="Quality",
-            guidance_text=None,  # type: ignore[arg-type]
-        )
-        assert hint is not None
-
-
-# ---------------------------------------------------------------------------
-# TSK-123.3: Marker tuple completeness
-# ---------------------------------------------------------------------------
-
-
-class TestSharedLibraryMarkerCompleteness:
-    """Verify _SHARED_LIBRARY_MARKERS contains all required markers."""
-
-    @pytest.mark.parametrize(
-        "marker",
-        [
-            "shared library",
-            "common lib",
-            "common repo",
-            "dependency lib",
-            "sdk nền tảng",
-            "repo dùng chung",
-            "88724032",
-            "thư viện dùng chung",
-            "thư viện chung",
-        ],
-    )
-    def test_required_marker_present(self, marker: str) -> None:
-        """All spec-required markers must be in _SHARED_LIBRARY_MARKERS."""
-        assert marker in _SHARED_LIBRARY_MARKERS
-
-
-# ---------------------------------------------------------------------------
-# TSK-123.4: Evidence assembler shared-library labeling
-# ---------------------------------------------------------------------------
-
-
-class TestEvidenceAssemblerSharedLibraryLabeling:
-    """Verify shared-library knowledge refs get distinctive labels."""
-
-    def test_shared_library_knowledge_gets_label(self) -> None:
-        """DD-123.7: shared_library_documentation refs get [Shared-library knowledge] label."""
-        from vds_audit_orchestrator.engine.evidence_assembler import EvidenceAssembler
-
-        @dataclass
-        class FakeLoopResult:
-            trace_steps: list[Any]
-            cross_repo_evidence_refs: list[dict[str, Any]] | None = None
-            config_repo_companion_refs: list[dict[str, Any]] | None = None
-            prior_knowledge_refs: list[dict[str, Any]] | None = None
-
-        result = FakeLoopResult(
-            trace_steps=[],
-            prior_knowledge_refs=[
-                {
-                    "ref_type": "prior_knowledge",
-                    "ref_value": "knowledge:123",
-                    "excerpt": "Shared library documentation content",
-                    "knowledge_type": "shared_library_documentation",
-                    "confidence": 0.9,
-                },
-            ],
-        )
-        context, refs = EvidenceAssembler.extract_tool_first_evidence(result)
-        assert context is not None
-        assert "[Shared-library knowledge]" in context
-        assert "knowledge:123" in refs
-
-    def test_non_shared_library_knowledge_no_label(self) -> None:
-        """Non-shared-library knowledge refs should NOT get the special label."""
-        from vds_audit_orchestrator.engine.evidence_assembler import EvidenceAssembler
-
-        @dataclass
-        class FakeLoopResult:
-            trace_steps: list[Any]
-            cross_repo_evidence_refs: list[dict[str, Any]] | None = None
-            config_repo_companion_refs: list[dict[str, Any]] | None = None
-            prior_knowledge_refs: list[dict[str, Any]] | None = None
-
-        result = FakeLoopResult(
-            trace_steps=[],
-            prior_knowledge_refs=[
-                {
-                    "ref_type": "prior_knowledge",
-                    "ref_value": "knowledge:456",
-                    "excerpt": "Architecture pattern content",
-                    "knowledge_type": "architecture_pattern",
-                    "confidence": 0.8,
-                },
-            ],
-        )
-        context, refs = EvidenceAssembler.extract_tool_first_evidence(result)
-        assert context is not None
-        assert "[Shared-library knowledge]" not in context
-        assert "Architecture pattern content" in context
-        assert "knowledge:456" in refs

package/tools/vds-scripts/audit_orchestrator/tests/unit/engine/test_shared_resource_indexing_phase122.py

@@ -1,188 +0,0 @@
-"""Focused regression tests for Phase 122 shared-resource indexing (FR-122.4).
-
-Covers:
-- Shared-library crawl scope (TSK-122.16 / collectors/confluence_collector.py)
-- Planner retrieval path for shared_library_documentation (TSK-122.17)
-- Feature flag behavior (AC-122.4.4)
-- Verifier script (TSK-122.18)
-"""
-
-from __future__ import annotations
-
-import os
-import subprocess
-import sys
-from pathlib import Path
-from unittest.mock import patch
-
-from vds_audit_orchestrator.collectors.confluence_collector import (
-    _CEP_SHARED_LIBRARY_PAGE_ID,
-    _SHARED_RESOURCE_INDEXING_ENV,
-    get_shared_library_page_ids,
-    is_shared_resource_indexing_enabled,
-    persist_shared_library_knowledge,
-)
-from vds_audit_orchestrator.engine.tool_first_planner import ToolFirstPlanner
-
-# ---------------------------------------------------------------------------
-# TSK-122.16: Shared-library crawl scope tests
-# ---------------------------------------------------------------------------
-
-
-class TestSharedResourceIndexingFlag:
-    """Tests for is_shared_resource_indexing_enabled() and compatibility overrides."""
-
-    def test_defaults_to_true(self) -> None:
-        """AC-122.4.4: Defaults to true when config/env override is unset."""
-        with patch.dict(os.environ, {}, clear=False):
-            os.environ.pop(_SHARED_RESOURCE_INDEXING_ENV, None)
-            assert is_shared_resource_indexing_enabled() is True
-
-    def test_env_true_enables(self) -> None:
-        with patch.dict(os.environ, {_SHARED_RESOURCE_INDEXING_ENV: "true"}):
-            assert is_shared_resource_indexing_enabled() is True
-
-    def test_env_false_disables(self) -> None:
-        with patch.dict(os.environ, {_SHARED_RESOURCE_INDEXING_ENV: "false"}):
-            assert is_shared_resource_indexing_enabled() is False
-
-    def test_env_zero_disables(self) -> None:
-        with patch.dict(os.environ, {_SHARED_RESOURCE_INDEXING_ENV: "0"}):
-            assert is_shared_resource_indexing_enabled() is False
-
-    def test_features_config_default_true(self) -> None:
-        from vds_audit_orchestrator.config import FeaturesConfig
-
-        assert FeaturesConfig().shared_resource_indexing_enabled is True
-
-
-class TestGetSharedLibraryPageIds:
-    """Tests for get_shared_library_page_ids()."""
-
-    def test_returns_page_id_when_enabled(self) -> None:
-        """AC-122.4.1: Page 88724032 is included in crawl scope."""
-        with patch.dict(os.environ, {_SHARED_RESOURCE_INDEXING_ENV: "true"}):
-            page_ids = get_shared_library_page_ids()
-            assert _CEP_SHARED_LIBRARY_PAGE_ID in page_ids
-
-    def test_returns_empty_when_disabled(self) -> None:
-        with patch.dict(os.environ, {_SHARED_RESOURCE_INDEXING_ENV: "false"}):
-            page_ids = get_shared_library_page_ids()
-            assert page_ids == []
-
-    def test_page_id_is_correct(self) -> None:
-        """AC-122.4.1: Correct page ID for CEP shared-resource."""
-        assert _CEP_SHARED_LIBRARY_PAGE_ID == "88724032"
-
-
-class TestPersistSharedLibraryKnowledge:
-    """Tests for persist_shared_library_knowledge()."""
-
-    def test_skips_empty_content(self) -> None:
-        """Empty content should not be persisted."""
-        persist_shared_library_knowledge(
-            content="",
-            project_key="test-project",
-            source_run_id="run-1",
-            state_dsn="postgresql://localhost/test",
-        )
-        # No exception — just logs a warning and returns.
-
-    def test_skips_when_no_dsn(self) -> None:
-        """No DSN should not crash."""
-        persist_shared_library_knowledge(
-            content="Some shared library docs",
-            project_key="test-project",
-            source_run_id="run-1",
-            state_dsn=None,
-        )
-        # No exception — just logs a warning and returns.
-
-    def test_persists_with_correct_knowledge_type(self) -> None:
-        """AC-122.4.2: Verify function signature and knowledge_type contract."""
-        import inspect
-
-        sig = inspect.signature(persist_shared_library_knowledge)
-        params = list(sig.parameters.keys())
-        assert "content" in params
-        assert "project_key" in params
-        assert "source_run_id" in params
-        assert "state_dsn" in params
-        assert "page_id" in params
-
-        # Verify the function source contains the correct knowledge_type.
-        source = inspect.getsource(persist_shared_library_knowledge)
-        assert 'knowledge_type="shared_library_documentation"' in source
-
-    def test_persist_uses_default_page_id(self) -> None:
-        """Default page_id matches the CEP shared-library page."""
-        import inspect
-
-        sig = inspect.signature(persist_shared_library_knowledge)
-        page_id_param = sig.parameters["page_id"]
-        assert page_id_param.default == _CEP_SHARED_LIBRARY_PAGE_ID
-
-    def test_caps_content_at_8000_chars(self) -> None:
-        """Content is capped at 8000 chars for storage."""
-        import inspect
-
-        source = inspect.getsource(persist_shared_library_knowledge)
-        assert "content[:8000]" in source
-
-
-# ---------------------------------------------------------------------------
-# TSK-122.17: Planner retrieval path tests
-# ---------------------------------------------------------------------------
-
-
-class TestPlannerSharedLibraryRetrieval:
-    """Tests for shared_library_documentation in planner KNOWLEDGE_TYPE_BY_TAG."""
-
-    def test_shared_library_maps_to_shared_library_documentation(self) -> None:
-        """AC-122.4.3: Planner retrieval for shared/common dependency rows."""
-        assert ToolFirstPlanner.KNOWLEDGE_TYPE_BY_TAG["shared_library"] == "shared_library_documentation"
-
-    def test_shared_library_in_discovery_type_by_tag(self) -> None:
-        """shared_library is also in DISCOVERY_TYPE_BY_TAG."""
-        assert "shared_library" in ToolFirstPlanner.DISCOVERY_TYPE_BY_TAG
-
-
-# ---------------------------------------------------------------------------
-# TSK-122.18: Verifier script tests
-# ---------------------------------------------------------------------------
-
-
-class TestVerifierScript:
-    """Tests for verify_phase122_instruction_handling.py."""
-
-    def test_verifier_script_exists(self) -> None:
-        """Verifier script exists at expected path."""
-        script_path = Path(__file__).parent.parent.parent.parent / "scripts" / "verify_phase122_instruction_handling.py"
-        assert script_path.is_file(), f"Verifier script not found at {script_path}"
-
-    def test_verifier_runs_without_crash(self) -> None:
-        """Verifier script runs without crashing."""
-        script_path = Path(__file__).parent.parent.parent.parent / "scripts" / "verify_phase122_instruction_handling.py"
-        result = subprocess.run(
-            [sys.executable, str(script_path)],
-            capture_output=True,
-            text=True,
-            timeout=30,
-        )
-        # Verifier should succeed now that all Phase 122 packages are implementation gates.
-        assert result.returncode == 0
-        assert "Phase 122 Verification" in result.stdout
-
-    def test_verifier_p122d_gates_pass(self) -> None:
-        """All P122-D gates pass in the verifier."""
-        script_path = Path(__file__).parent.parent.parent.parent / "scripts" / "verify_phase122_instruction_handling.py"
-        result = subprocess.run(
-            [sys.executable, str(script_path)],
-            capture_output=True,
-            text=True,
-            timeout=30,
-        )
-        # All P122-D gates should pass.
-        for line in result.stdout.splitlines():
-            if "P122-D:" in line:
-                assert "[PASS]" in line, f"P122-D gate failed: {line}"

package/tools/vds-scripts/audit_orchestrator/tests/unit/engine/test_skill_recommendation.py

@@ -1,225 +0,0 @@
-from __future__ import annotations
-
-from vds_audit_orchestrator.engine.skill_recommendation import (
-    infer_skills_from_markers,
-    is_app_config_requirement,
-    is_dependency_cycle_requirement,
-    is_migration_script_requirement,
-    is_public_interface_boundary_requirement,
-    recommend_skills_deterministic,
-)
-
-
-def test_infer_skills_from_markers_prefers_circular_dependency_for_cl004_vietnamese_wording() -> None:
-    inferred = infer_skills_from_markers(
-        "3. Quản lý dependency/lib tập trung trên 1 project và độc lập trên các service/module",
-        "1. Decoupling||SourceCode Organization",
-    )
-
-    assert "circular-dependency-skill" in inferred
-
-
-def test_is_dependency_cycle_requirement_matches_cl004_vietnamese_wording() -> None:
-    interpretation = {
-        "skill_objectives": ["analyze_tooling_automation_guidance"],
-        "project_scope_required": True,
-        "row_key": "CL-004:row_3",
-    }
-
-    assert is_dependency_cycle_requirement(
-        "3. Quản lý dependency/lib tập trung trên 1 project và độc lập trên các service/module",
-        "1. Decoupling||SourceCode Organization",
-        interpretation,
-    )
-
-
-def test_is_dependency_cycle_requirement_does_not_match_non_cl004_shared_library_row_by_tag_alone() -> None:
-    interpretation = {
-        "row_key": "CL-003:row_2",
-        "project_scope_required": True,
-        "requirement_type_tag": "shared_library",
-        "skill_objectives": ["analyze_tooling_automation_guidance"],
-    }
-
-    assert not is_dependency_cycle_requirement(
-        "Centralized shared-library governance and reuse guidance across repos.",
-        "1. Decoupling||SourceCode Organization",
-        interpretation,
-    )
-
-
-def test_is_dependency_cycle_requirement_does_not_match_explicit_public_interface_row() -> None:
-    interpretation = {
-        "skill_objectives": [],
-        "project_scope_required": False,
-    }
-
-    assert not is_dependency_cycle_requirement(
-        "2. Explicit Public Interface: Cross-module call phải thông qua interface, API client, message contract.",
-        "1. Decoupling||SourceCode Organization",
-        interpretation,
-    )
-
-
-def test_is_public_interface_boundary_requirement_matches_cl002_wording() -> None:
-    interpretation = {
-        "skill_objectives": ["analyze_public_interface_boundaries"],
-        "project_scope_required": False,
-        "row_key": "CL-002:row_1",
-    }
-
-    assert is_public_interface_boundary_requirement(
-        "2. Explicit Public Interface: Cross-module call phải thông qua interface, API client, message contract.",
-        "1. Decoupling||SourceCode Organization",
-        interpretation,
-    )
-
-
-def test_recommend_skills_deterministic_returns_public_interface_skill_only_for_cl002() -> None:
-    result = recommend_skills_deterministic(
-        requirement_text=(
-            "2. Explicit Public Interface: Cross-module call phải thông qua interface, API client, "
-            "message contract. Không import concrete implementation từ module khác."
-        ),
-        requirement_category="1. Decoupling||SourceCode Organization",
-        interpretation={
-            "row_key": "CL-002:row_1",
-            "skill_objectives": ["analyze_public_interface_boundaries"],
-            "requirement_type_tag": "api_contract",
-        },
-        available_skill_names=[
-            "public-interface-boundary-skill",
-            "hexagonal-compliance-skill",
-            "research-skill",
-        ],
-        limit=3,
-    )
-
-    assert [item.skill_name for item in result.recommended_skills] == ["public-interface-boundary-skill"]
-
-
-def test_is_migration_script_requirement_matches_cl007_wording() -> None:
-    interpretation = {
-        "row_key": "CL-007:row_6",
-        "skill_objectives": ["analyze_migration_scripts"],
-        "requirement_type_tag": "migration",
-    }
-
-    assert is_migration_script_requirement(
-        "3. Có script migration dữ liệu độc lập (Liquibase/Flyway).",
-        "1. Decoupling||Tách biệt Database",
-        interpretation,
-    )
-
-
-def test_recommend_skills_deterministic_returns_migration_skill_only_for_cl007() -> None:
-    result = recommend_skills_deterministic(
-        requirement_text="3. Có script migration dữ liệu độc lập (Liquibase/Flyway).",
-        requirement_category="1. Decoupling||Tách biệt Database",
-        interpretation={
-            "row_key": "CL-007:row_6",
-            "requirement_type_tag": "migration",
-            "skill_objectives": ["analyze_migration_scripts"],
-        },
-        available_skill_names=[
-            "migration-script-detection-skill",
-            "vds-scripts-skill",
-            "research-skill",
-            "app-config-discovery-skill",
-        ],
-        limit=3,
-    )
-
-    assert [item.skill_name for item in result.recommended_skills] == ["migration-script-detection-skill"]
-
-
-def test_is_app_config_requirement_matches_cl006_pooling_requirement() -> None:
-    interpretation = {
-        "row_key": "CL-006:row_5",
-        "app_config_only": True,
-        "skill_objectives": [
-            "discover_app_config",
-            "resolve_environment_specific_config",
-            "analyze_datasource_isolation",
-        ],
-    }
-
-    assert is_app_config_requirement(
-        "2. Sử dụng Connection Pooling riêng biệt và có giới hạn (Limit). Kiểm tra repo app-config production.",
-        "1. Decoupling||Tách biệt Database",
-        interpretation,
-    )
-
-
-def test_recommend_skills_deterministic_returns_app_config_only_for_cl006() -> None:
-    result = recommend_skills_deterministic(
-        requirement_text=(
-            "2. Sử dụng Connection Pooling riêng biệt và có giới hạn (Limit). "
-            "Kiểm tra repo app-config theo đúng service và môi trường production."
-        ),
-        requirement_category="1. Decoupling||Tách biệt Database",
-        interpretation={
-            "row_key": "CL-006:row_5",
-            "app_config_only": True,
-            "skill_objectives": [
-                "discover_app_config",
-                "resolve_environment_specific_config",
-                "analyze_datasource_isolation",
-            ],
-        },
-        available_skill_names=[
-            "app-config-discovery-skill",
-            "research-skill",
-            "audit-orchestrator-skill",
-        ],
-        limit=3,
-    )
-
-    assert [item.skill_name for item in result.recommended_skills] == ["app-config-discovery-skill"]
-
-
-def test_is_app_config_requirement_matches_cl015_direct_database_shared_memory_requirement() -> None:
-    interpretation = {
-        "row_key": "CL-015:row_14",
-        "app_config_only": True,
-        "skill_objectives": [
-            "discover_app_config",
-            "resolve_environment_specific_config",
-            "analyze_datasource_isolation",
-            "compare_cross_service_config_separation",
-        ],
-    }
-
-    assert is_app_config_requirement(
-        "6. Không có tình trạng gọi trực tiếp vào Database hoặc Shared Memory của nhau.",
-        "1. Decoupling||Giao tiếp API/Message",
-        interpretation,
-    )
-
-
-def test_recommend_skills_deterministic_returns_app_config_only_for_cl015() -> None:
-    result = recommend_skills_deterministic(
-        requirement_text=(
-            "6. Không có tình trạng gọi trực tiếp vào Database hoặc Shared Memory của nhau. "
-            "Cần bám theo app-config và cấu hình theo từng service."
-        ),
-        requirement_category="1. Decoupling||Giao tiếp API/Message",
-        interpretation={
-            "row_key": "CL-015:row_14",
-            "app_config_only": True,
-            "skill_objectives": [
-                "discover_app_config",
-                "resolve_environment_specific_config",
-                "analyze_datasource_isolation",
-                "compare_cross_service_config_separation",
-            ],
-        },
-        available_skill_names=[
-            "app-config-discovery-skill",
-            "research-skill",
-            "audit-orchestrator-skill",
-        ],
-        limit=3,
-    )
-
-    assert [item.skill_name for item in result.recommended_skills] == ["app-config-discovery-skill"]