@nextclaw/ui 0.13.12 → 0.14.0

package/src/features/chat/pages/{ncp-chat-page.test.ts → __tests__/ncp-chat-page.test.ts}

@@ -1,16 +1,17 @@
 import { describe, expect, it } from 'vitest';
+import { RUNTIME_DEFAULT_MODEL_VALUE } from '@nextclaw/shared';
 import type { SessionEntryView, ThinkingLevel } from '@/shared/lib/api';
 import type { ChatModelOption } from '@/features/chat/types/chat-input.types';
 import {
   resolveRecentSessionPreferredValue,
   resolveSelectedModelValue,
   resolveSelectedThinkingLevelValue
-} from '@/features/chat/utils/chat-session-preference-governance.utils';
+} from '@/features/chat/features/session/utils/chat-session-preference-governance.utils';
 import {
-  buildNcpSendMetadata,
+  buildChatRunMetadata,
   shouldClearPendingProjectRootOverride
-} from '@/features/chat/pages/ncp-chat-page';
-import { filterModelOptionsBySessionType } from '@/features/chat/hooks/use-ncp-chat-page-data';
+} from '@/features/chat/features/session/utils/chat-run-metadata.utils';
+import { filterNcpChatModelOptionsBySessionType } from '@/features/chat/features/ncp/utils/ncp-chat-query-derived.utils';
 
 const modelOptions: ChatModelOption[] = [
   {
@@ -39,10 +40,10 @@ const modelOptions: ChatModelOption[] = [
   }
 ];
 
-describe('filterModelOptionsBySessionType', () => {
+describe('filterNcpChatModelOptionsBySessionType', () => {
   it('keeps the full model catalog when the session type does not publish a supportedModels whitelist', () => {
     expect(
-      filterModelOptionsBySessionType({
+      filterNcpChatModelOptionsBySessionType({
         modelOptions
       })
     ).toEqual(modelOptions);
@@ -50,7 +51,7 @@ describe('filterModelOptionsBySessionType', () => {
 
   it('keeps only session-type-supported models when the runtime publishes a filtered list', () => {
     expect(
-      filterModelOptionsBySessionType({
+      filterNcpChatModelOptionsBySessionType({
         modelOptions,
         supportedModels: ['anthropic/claude-sonnet-4']
       })
@@ -59,18 +60,54 @@ describe('filterModelOptionsBySessionType', () => {
 
   it('falls back to the full model catalog when the advertised models do not match the current catalog', () => {
     expect(
-      filterModelOptionsBySessionType({
+      filterNcpChatModelOptionsBySessionType({
         modelOptions,
         supportedModels: ['unknown/model']
       })
     ).toEqual(modelOptions);
   });
+
+  it('uses only the runtime default option when the session type owns model selection', () => {
+    expect(
+      filterNcpChatModelOptionsBySessionType({
+        modelOptions,
+        modelSelectionMode: 'runtime-default',
+        runtimeDefaultModelLabel: 'Runtime default',
+      })
+    ).toEqual([{
+      value: RUNTIME_DEFAULT_MODEL_VALUE,
+      modelLabel: 'Runtime default',
+      providerLabel: '',
+      isRuntimeDefault: true,
+      thinkingCapability: null,
+    }]);
+  });
+
+  it('adds the runtime default option beside supported models for optional runtime selection', () => {
+    expect(
+      filterNcpChatModelOptionsBySessionType({
+        modelOptions,
+        modelSelectionMode: 'optional',
+        runtimeDefaultModelLabel: 'Runtime default',
+        supportedModels: ['openai/gpt-5'],
+      })
+    ).toEqual([
+      {
+        value: RUNTIME_DEFAULT_MODEL_VALUE,
+        modelLabel: 'Runtime default',
+        providerLabel: '',
+        isRuntimeDefault: true,
+        thinkingCapability: null,
+      },
+      modelOptions[1],
+    ]);
+  });
 });
 
-describe('buildNcpSendMetadata', () => {
+describe('buildChatRunMetadata', () => {
   it('includes the project root in the first-message metadata when present', () => {
     expect(
-      buildNcpSendMetadata({
+      buildChatRunMetadata({
         agentId: 'engineer',
         sessionType: 'codex',
         projectRoot: ' /tmp/project-alpha ',
@@ -87,7 +124,7 @@ describe('buildNcpSendMetadata', () => {
 
   it('omits project_root when the input is blank', () => {
     expect(
-      buildNcpSendMetadata({
+      buildChatRunMetadata({
         projectRoot: '   ',
       }),
     ).not.toHaveProperty('project_root');
@@ -95,7 +132,7 @@ describe('buildNcpSendMetadata', () => {
 
   it('sends requested skill refs instead of legacy requested skill names', () => {
     expect(
-      buildNcpSendMetadata({
+      buildChatRunMetadata({
         requestedSkills: ['project:/tmp/project-alpha/.agents/skills/review'],
       }),
     ).toMatchObject({