@nextclaw/ui 0.13.12 → 0.14.0

package/src/features/chat/managers/{chat-session-list.manager.test.ts → __tests__/chat-session-list.manager.test.ts}

@@ -27,39 +27,45 @@ vi.mock('@/shared/lib/api', async (importOriginal) => {
   };
 });
 
-describe('ChatSessionListManager', () => {
-  beforeEach(() => {
-    window.localStorage.clear();
-    useChatSessionListStore.persist.setOptions({ storage: createLocalStoragePersistStorage() });
-    mocks.updateNcpSession.mockReset();
-    mocks.updateNcpSession.mockResolvedValue({});
-    useChatInputStore.setState({
-      snapshot: {
-        ...useChatInputStore.getState().snapshot,
-        defaultSessionType: 'native',
-        pendingSessionType: 'native',
-        pendingProjectRoot: null,
-        pendingProjectRootSessionKey: null
-      }
-    });
-    useChatSessionListStore.setState({
-      optimisticReadAtBySessionKey: {},
-      snapshot: {
-        ...useChatSessionListStore.getState().snapshot,
-        selectedSessionKey: 'session-1',
-        listMode: 'time-first'
-      }
-    });
-    useChatThreadStore.setState({
-      snapshot: {
-        ...useChatThreadStore.getState().snapshot,
-        workspacePanelParentKey: 'session-1',
-        activeWorkspacePanelKind: 'child-session',
-        activeChildSessionKey: 'child-session-1',
-        activeWorkspaceFileKey: null,
-      },
-    });
+function resetChatSessionListManagerState() {
+  window.localStorage.clear();
+  useChatSessionListStore.persist.setOptions({ storage: createLocalStoragePersistStorage() });
+  mocks.updateNcpSession.mockReset();
+  mocks.updateNcpSession.mockResolvedValue({});
+  useChatInputStore.setState({
+    snapshot: {
+      ...useChatInputStore.getState().snapshot,
+      defaultSessionType: 'native',
+      pendingSessionType: 'native',
+      pendingProjectRoot: null,
+      pendingProjectRootSessionKey: null
+    }
+  });
+  useChatSessionListStore.setState({
+    optimisticReadAtBySessionKey: {},
+    snapshot: {
+      ...useChatSessionListStore.getState().snapshot,
+      selectedSessionKey: 'session-1',
+      listMode: 'time-first'
+    }
   });
+  useChatThreadStore.setState({
+    snapshot: {
+      ...useChatThreadStore.getState().snapshot,
+      workspacePanelParentKey: 'session-1',
+      activeWorkspacePanelKind: 'child-session',
+      activeChildSessionKey: 'child-session-1',
+      activeWorkspaceFileKey: null,
+      workspaceNavigationHistory: [
+        { kind: 'child-session', key: 'child-session-1' },
+      ],
+      workspaceNavigationHistoryIndex: 0,
+    },
+  });
+}
+
+describe('ChatSessionListManager draft and selection flow', () => {
+  beforeEach(resetChatSessionListManagerState);
 
   it('applies the requested session type when creating a session', () => {
     const uiManager = {
@@ -68,14 +74,14 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.createSession('codex');
 
-    expect(streamActionsManager.resetStreamState).toHaveBeenCalledTimes(1);
+    expect(chatRunManager.clearRunState).toHaveBeenCalledTimes(1);
     expect(uiManager.navigateTo).toHaveBeenCalledWith('/chat/draft');
     expect(useChatSessionListStore.getState().snapshot.selectedSessionKey).toBeNull();
     expect(useChatThreadStore.getState().snapshot.sessionKey).toBeNull();
@@ -92,14 +98,14 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.startAgentDraftChat('researcher', 'codex');
 
-    expect(streamActionsManager.resetStreamState).toHaveBeenCalledTimes(1);
+    expect(chatRunManager.clearRunState).toHaveBeenCalledTimes(1);
     expect(uiManager.navigateTo).toHaveBeenCalledWith('/chat/draft');
     expect(useChatSessionListStore.getState().snapshot.selectedAgentId).toBe('researcher');
     expect(useChatSessionListStore.getState().snapshot.selectedSessionKey).toBeNull();
@@ -117,11 +123,11 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.createSession('native', '/tmp/project-alpha');
 
     expect(useChatInputStore.getState().snapshot.pendingProjectRoot).toBe('/tmp/project-alpha');
@@ -141,11 +147,11 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     const sessionKey = manager.ensureDraftSession('native');
 
     expect(sessionKey).toBeNull();
@@ -163,11 +169,11 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.createSession('native', '/tmp/project-alpha');
 
     expect(useChatSessionListStore.getState().snapshot.selectedSessionKey).toBeNull();
@@ -181,11 +187,11 @@ describe('ChatSessionListManager', () => {
       goToSession: vi.fn(),
       isAtChatRoot: vi.fn(() => true),
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
+    const chatRunManager = {
+      clearRunState: vi.fn()
     } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.selectSession('session-2');
 
     expect(uiManager.goToSession).toHaveBeenCalledWith('session-2');
@@ -195,12 +201,16 @@ describe('ChatSessionListManager', () => {
     expect(useChatThreadStore.getState().snapshot.activeChildSessionKey).toBe('child-session-1');
     expect(useChatThreadStore.getState().snapshot.activeWorkspaceFileKey).toBeNull();
   });
+});
+
+describe('ChatSessionListManager list preference and read state', () => {
+  beforeEach(resetChatSessionListManagerState);
 
   it('updates the sidebar list mode without touching other session list state', () => {
     const uiManager = {} as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {} as ConstructorParameters<typeof ChatSessionListManager>[1];
+    const chatRunManager = {} as ConstructorParameters<typeof ChatSessionListManager>[1];
 
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
+    const manager = new ChatSessionListManager(uiManager, chatRunManager);
     manager.setListMode('project-first');
 
     expect(useChatSessionListStore.getState().snapshot.listMode).toBe('project-first');
@@ -246,30 +256,44 @@ describe('ChatSessionListManager', () => {
     expect(mocks.updateNcpSession).not.toHaveBeenCalled();
   });
 
-  it('routes to the backend-materialized root session without duplicating route-owned selection state', () => {
-    useChatSessionListStore.setState({
-      snapshot: {
-        ...useChatSessionListStore.getState().snapshot,
-        selectedSessionKey: null,
-      }
+  it('marks a visible workspace child session as read through the session list owner', () => {
+    const manager = new ChatSessionListManager(
+      {} as ConstructorParameters<typeof ChatSessionListManager>[0],
+      {} as ConstructorParameters<typeof ChatSessionListManager>[1]
+    );
+
+    manager.markVisibleWorkspaceChildRead({
+      sessionKey: 'child-session-1',
+      lastMessageAt: '2026-04-10T10:00:00.000Z',
+      readAt: null,
+      runStatus: 'completed',
     });
-    const uiManager = {
-      goToChatRoot: vi.fn(),
-      goToSession: vi.fn(),
-      isAtChatRoot: vi.fn(() => true),
-    } as unknown as ConstructorParameters<typeof ChatSessionListManager>[0];
-    const streamActionsManager = {
-      resetStreamState: vi.fn()
-    } as unknown as ConstructorParameters<typeof ChatSessionListManager>[1];
-    const manager = new ChatSessionListManager(uiManager, streamActionsManager);
 
-    manager.ensureDraftSession('native');
-    manager.materializeRootSessionRoute('ncp-materialized-session');
+    expect(useChatSessionListStore.getState().optimisticReadAtBySessionKey['child-session-1']).toBe(
+      '2026-04-10T10:00:00.000Z'
+    );
+    expect(mocks.updateNcpSession).toHaveBeenCalledWith('child-session-1', {
+      uiReadAt: '2026-04-10T10:00:00.000Z'
+    });
+  });
 
-    expect(useChatSessionListStore.getState().snapshot.selectedSessionKey).toBeNull();
-    expect(useChatThreadStore.getState().snapshot.sessionKey).toBeNull();
-    expect(uiManager.goToSession).toHaveBeenCalledWith('ncp-materialized-session', { replace: true });
+  it('keeps running workspace child sessions unread until they settle', () => {
+    const manager = new ChatSessionListManager(
+      {} as ConstructorParameters<typeof ChatSessionListManager>[0],
+      {} as ConstructorParameters<typeof ChatSessionListManager>[1]
+    );
+
+    manager.markVisibleWorkspaceChildRead({
+      sessionKey: 'child-session-1',
+      lastMessageAt: '2026-04-10T10:00:00.000Z',
+      readAt: null,
+      runStatus: 'running',
+    });
+
+    expect(useChatSessionListStore.getState().optimisticReadAtBySessionKey['child-session-1']).toBeUndefined();
+    expect(mocks.updateNcpSession).not.toHaveBeenCalled();
   });
+
 });
 
 describe('ChatSessionListStore persistence', () => {

package/src/features/chat/managers/{chat-session-preference-sync.manager.test.ts → __tests__/chat-session-preference-sync.manager.test.ts}

@@ -1,6 +1,6 @@
 import { afterEach, describe, expect, it, vi } from 'vitest';
 import { updateNcpSession } from '@/shared/lib/api';
-import { ChatSessionPreferenceSync } from './chat-session-preference-sync.manager';
+import { ChatSessionPreferenceSync } from '../chat-session-preference-sync.manager';
 import { useChatInputStore } from '@/features/chat/stores/chat-input.store';
 import { useChatSessionListStore } from '@/features/chat/stores/chat-session-list.store';
 import { useChatThreadStore } from '@/features/chat/stores/chat-thread.store';