@needle-tools/engine 2.35.4-pre → 2.36.0-pre

package/src/engine/engine.ts

@@ -2,8 +2,8 @@ import * as engine_setup from "./engine_setup";
 import * as engine_scenetools from "./engine_scenetools";
 import "./tests/test_utils";
 import { RGBAColor } from "../engine-components/js-extensions/RGBAColor";
-import { makeErrorsVisibleForDevelopment } from "./debug/error_overlay";
 
+import { makeErrorsVisibleForDevelopment } from "./debug/debug_overlay";
 makeErrorsVisibleForDevelopment();
 
 const engine = {

package/src/engine/engine_element_loading.ts

@@ -45,7 +45,7 @@ export class EngineLoadingView implements ILoadingViewHandler {
                 if (el.classList.contains("loading")) {
                     if (!this._allowCustomLoadingElement) {
                         console.warn("Custom loading container is not allowed")
-                        // this.container.removeChild(el);
+                        this.container.removeChild(el);
                         continue;
                     }
                     this._loadingElement = this.createLoadingElement(el);

package/src/engine/engine_gameobject.ts

@@ -51,8 +51,19 @@ export class InstantiateOptions {
 //         main.processStart(Context.Current, go);
 // }
 
+const $isActive = Symbol("isActive");
+
 export function isActiveSelf(go: Object3D): boolean {
-    return go.visible || isUsingInstancing(go);
+    const visible = go.visible || isUsingInstancing(go);
+    if (go[$isActive] === undefined) {
+        go[$isActive] = visible;
+    }
+    return go[$isActive] && visible;
+}
+
+export function setActive(go:Object3D, active:boolean, setVisible = true){
+    go[$isActive] = active;
+    if(setVisible) go.visible = active;
 }
 
 export function isActiveInHierarchy(go: Object3D): boolean {
@@ -74,6 +85,7 @@ export function findByGuid(guid: string, hierarchy: THREE.Object3D): GameObject
 export function destroy(instance: Object3D | Component, recursive: boolean = true, isRoot: boolean = true) {
     const comp = instance as Component;
     if (comp.isComponent) {
+        comp.__internalDisable();
         comp.__internalDestroy();
         return;
     }
@@ -92,6 +104,7 @@ export function destroy(instance: Object3D | Component, recursive: boolean = tru
         let lastLength = components.length;
         for (let i = 0; i < components.length; i++) {
             const comp: Component = components[i];
+            comp.__internalDisable();
             comp.__internalDestroy();
             // if (comp.destroy) {
             //     if (debug) console.log("destroying", comp);
@@ -111,7 +124,7 @@ export function destroy(instance: Object3D | Component, recursive: boolean = tru
 
 export function foreachComponent(instance: THREE.Object3D, cb: (comp: Component) => any, recursive: boolean = true): any {
     if (!instance) return;
-    if(!instance.isObject3D){
+    if (!instance.isObject3D) {
         new Error("Expected Object3D but got " + instance);
     }
     if (instance.userData?.components) {
@@ -464,8 +477,8 @@ function resolveReferences(newObjectsMap: { [key: string]: NewGameObjectReferenc
 
 }
 
-function postProcessNewInstance(copy: THREE.Object3D, key: string, value : IComponent | Object3D, newObjectsMap: { [key: string]: NewGameObjectReferenceInfo }) {
-    if(value === null || value === undefined) return;
+function postProcessNewInstance(copy: THREE.Object3D, key: string, value: IComponent | Object3D, newObjectsMap: { [key: string]: NewGameObjectReferenceInfo }) {
+    if (value === null || value === undefined) return;
     if ((value as IComponent).isComponent === true) {
         const originalGameObjectReference = value["gameObject"];
         // console.log(key, value, originalGameObjectReference);

package/src/engine/engine_gltf_builtin_components.ts

@@ -13,11 +13,13 @@ import { SourceIdentifier } from "./engine_types";
 import { UIDProvider } from "./engine_types";
 import { addNewComponentInstance } from "./engine_components";
 import { getParam } from "./engine_utils";
+import { LogType, showBalloonMessage } from "./debug/debug";
+import { isLocalNetwork } from "./engine_networking_utils";
 
 
 const debug = debugExtension;
 const debugTypeStore = getParam("debugtypestore");
-if(debugTypeStore) console.log(TypeStore);
+if (debugTypeStore) console.log(TypeStore);
 
 export function writeBuiltinComponentData(comp: Component, context: SerializationContext): object | null {
 
@@ -172,6 +174,8 @@ async function onCreateBuiltinComponents(context: SerializationContext, obj: THR
             const unknown = unknownComponentsBuffer.join(", ");
             console.warn("unknown components: " + unknown);
             unknownComponentsBuffer.length = 0;
+            if (isLocalNetwork())
+                showBalloonMessage(`<strong>Unknown components in scene</strong>:\n\n${unknown}\n\nThis could mean you forgot to add a npmdef to your ExportInfo\n<a href="https://engine.needle.tools/docs/project_structure.html#creating-and-installing-a-npmdef" target="_blank">documentation</a>`, LogType.Warn);
         }
     }
 

package/src/engine/engine_mainloop_utils.ts

@@ -207,14 +207,16 @@ function removeFromArray(script: any, array: any[]) {
 const previousActiveMap: { [key: string]: boolean } = {};
 const previousActiveInHierarchyMap: { [key: string]: boolean } = {};
 
-export function updateIsActive() {
-    if (!Context.Current) {
+export function updateIsActive(obj? : Object3D) {
+    if(!obj) obj = Context.Current.scene;
+    if (!obj) {
         console.trace("Invalid call - no current context.");
         return;
     }
-    updateIsActiveInHierarchyRecursiveRuntime(Context.Current.scene, Context.Current.scene.visible, true);
+    updateIsActiveInHierarchyRecursiveRuntime(obj, isActiveSelf(obj), true);
 }
 
+
 function updateIsActiveInHierarchyRecursiveRuntime(go: THREE.Object3D, activeInHierarchy: boolean, allowEventCall: boolean) {
     let activeStateChanged: boolean = false;
 
@@ -247,6 +249,7 @@ function updateIsActiveInHierarchyRecursiveRuntime(go: THREE.Object3D, activeInH
         const prevActiveInHierarchy = previousActiveInHierarchyMap[go.uuid];
         if (prevActiveInHierarchy !== undefined) {
             if (prevActiveInHierarchy !== activeInHierarchy) {
+                // console.log("CHANGE", go.name, activeInHierarchy);
                 if (allowEventCall) {
                     perComponent(go, comp => {
                         if (activeInHierarchy) {
@@ -286,6 +289,7 @@ export function updateActiveInHierarchyWithoutEventCall(go: THREE.Object3D) {
         console.error("GO is null");
         return;
     }
+    previousActiveInHierarchyMap[go.uuid] = activeInHierarchy;
     go[constants.activeInHierarchyFieldName] = activeInHierarchy && foundScene;
 }