@nathapp/nax 0.27.1 → 0.29.0

package/test/unit/pipeline/stages/execution-merge-conflict.test.ts

@@ -1,218 +0,0 @@
-/**
- * Unit tests for merge-conflict trigger wiring in execution stage (TC-003)
- *
- * Covers:
- * - Agent output with CONFLICT + trigger enabled + chain aborts → fail
- * - Agent output with CONFLICT + trigger enabled + chain approves → continue
- * - Agent output with CONFLICT + trigger disabled → no trigger call
- * - Agent output without CONFLICT + trigger enabled → no trigger call
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-import type { NaxConfig } from "../../../../src/config";
-import { InteractionChain } from "../../../../src/interaction/chain";
-import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
-import { _executionDeps } from "../../../../src/pipeline/stages/execution";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import type { PRD, UserStory } from "../../../../src/prd";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Save originals for restoration
-// ─────────────────────────────────────────────────────────────────────────────
-
-const originalDetectMergeConflict = _executionDeps.detectMergeConflict;
-const originalCheckMergeConflict = _executionDeps.checkMergeConflict;
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-function makeChain(action: InteractionResponse["action"]): InteractionChain {
-  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
-  const plugin: InteractionPlugin = {
-    name: "test",
-    send: mock(async () => {}),
-    receive: mock(async (id: string): Promise<InteractionResponse> => ({
-      requestId: id,
-      action,
-      respondedBy: "user",
-      respondedAt: Date.now(),
-    })),
-  };
-  chain.register(plugin);
-  return chain;
-}
-
-function makeConfig(triggers: Record<string, unknown>): NaxConfig {
-  return {
-    autoMode: { defaultAgent: "test-agent" },
-    models: { fast: "claude-haiku-4-5", balanced: "claude-sonnet-4-5", powerful: "claude-opus-4-5" },
-    execution: {
-      sessionTimeoutSeconds: 60,
-      dangerouslySkipPermissions: false,
-      costLimit: 10,
-      maxIterations: 10,
-      rectification: { maxRetries: 3 },
-    },
-    interaction: {
-      plugin: "cli",
-      defaults: { timeout: 30000, fallback: "abort" as const },
-      triggers,
-    },
-  } as unknown as NaxConfig;
-}
-
-function makeStory(): UserStory {
-  return {
-    id: "US-001",
-    title: "Test Story",
-    description: "Test",
-    acceptanceCriteria: [],
-    tags: [],
-    dependencies: [],
-    status: "in-progress",
-    passes: false,
-    escalations: [],
-    attempts: 1,
-  };
-}
-
-function makePRD(): PRD {
-  return {
-    project: "test",
-    feature: "my-feature",
-    branchName: "test-branch",
-    createdAt: new Date().toISOString(),
-    updatedAt: new Date().toISOString(),
-    userStories: [makeStory()],
-  };
-}
-
-function makeSuccessfulAgent() {
-  return {
-    name: "test-agent",
-    capabilities: { supportedTiers: ["fast", "balanced", "powerful"] },
-    run: mock(async () => ({
-      success: true,
-      exitCode: 0,
-      output: "CONFLICT (content): Merge conflict in src/foo.ts",
-      stderr: "",
-      rateLimited: false,
-      durationMs: 100,
-      estimatedCost: 0.01,
-    })),
-  };
-}
-
-function makeCtx(config: NaxConfig, interaction?: InteractionChain): PipelineContext {
-  return {
-    config,
-    prd: makePRD(),
-    story: makeStory(),
-    stories: [makeStory()],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp/test",
-    prompt: "Do something",
-    hooks: {} as PipelineContext["hooks"],
-    interaction,
-  } as unknown as PipelineContext;
-}
-
-afterEach(() => {
-  mock.restore();
-  _executionDeps.detectMergeConflict = originalDetectMergeConflict;
-  _executionDeps.checkMergeConflict = originalCheckMergeConflict;
-  _executionDeps.getAgent = _executionDeps.getAgent; // restored via mock.restore()
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Merge conflict trigger tests (via _executionDeps injection)
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("executionStage — merge-conflict trigger", () => {
-  test("returns fail when conflict detected and trigger responds abort", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeSuccessfulAgent();
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.detectMergeConflict = mock(() => true);
-    _executionDeps.checkMergeConflict = mock(async () => false);
-
-    const config = makeConfig({ "merge-conflict": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("fail");
-    expect((result as { reason?: string }).reason).toContain("Merge conflict");
-    expect(_executionDeps.detectMergeConflict).toHaveBeenCalled();
-    expect(_executionDeps.checkMergeConflict).toHaveBeenCalledTimes(1);
-  });
-
-  test("returns continue when conflict detected but trigger approves", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeSuccessfulAgent();
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.detectMergeConflict = mock(() => true);
-    _executionDeps.checkMergeConflict = mock(async () => true);
-
-    const config = makeConfig({ "merge-conflict": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkMergeConflict).toHaveBeenCalledTimes(1);
-  });
-
-  test("does not call trigger when trigger is disabled", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeSuccessfulAgent();
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.detectMergeConflict = mock(() => true);
-    _executionDeps.checkMergeConflict = mock(async () => false);
-
-    const config = makeConfig({});
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
-  });
-
-  test("does not call trigger when no conflict detected", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeSuccessfulAgent();
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.detectMergeConflict = mock(() => false);
-    _executionDeps.checkMergeConflict = mock(async () => false);
-
-    const config = makeConfig({ "merge-conflict": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
-  });
-
-  test("does not call trigger when no interaction chain", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeSuccessfulAgent();
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.detectMergeConflict = mock(() => true);
-    _executionDeps.checkMergeConflict = mock(async () => false);
-
-    const config = makeConfig({ "merge-conflict": { enabled: true } });
-    const ctx = makeCtx(config); // no chain
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkMergeConflict).not.toHaveBeenCalled();
-  });
-});

package/test/unit/pipeline/stages/rectify.test.ts

@@ -1,101 +0,0 @@
-// RE-ARCH: keep
-import { describe, expect, test } from "bun:test";
-import { rectifyStage, _rectifyDeps } from "../../../../src/pipeline/stages/rectify";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import { DEFAULT_CONFIG } from "../../../../src/config";
-
-function makeCtx(overrides: Partial<PipelineContext> = {}): PipelineContext {
-  return {
-    config: {
-      ...DEFAULT_CONFIG,
-      execution: {
-        ...DEFAULT_CONFIG.execution,
-        rectification: { enabled: true, maxRetries: 3, abortOnIncreasingFailures: true, maxFailureSummaryChars: 2000 },
-      },
-      quality: {
-        ...DEFAULT_CONFIG.quality,
-        commands: { ...DEFAULT_CONFIG.quality.commands, test: "bun test" },
-      },
-    },
-    prd: { stories: [] } as any,
-    story: { id: "US-001", title: "t", status: "in-progress", acceptanceCriteria: [] } as any,
-    stories: [],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp",
-    hooks: {},
-    ...overrides,
-  };
-}
-
-function makeVerifyResult(success: boolean) {
-  return {
-    success,
-    status: success ? ("PASS" as const) : ("TEST_FAILURE" as const),
-    storyId: "US-001",
-    strategy: "scoped" as const,
-    passCount: success ? 10 : 8,
-    failCount: success ? 0 : 2,
-    totalCount: 10,
-    failures: [],
-    rawOutput: "(fail) foo > bar",
-    durationMs: 100,
-    countsTowardEscalation: !success,
-  };
-}
-
-describe("rectifyStage", () => {
-  test("disabled when verifyResult is undefined", () => {
-    expect(rectifyStage.enabled(makeCtx())).toBe(false);
-  });
-
-  test("disabled when verify passed", () => {
-    const ctx = makeCtx({ verifyResult: makeVerifyResult(true) });
-    expect(rectifyStage.enabled(ctx)).toBe(false);
-  });
-
-  test("disabled when rectification config disabled", () => {
-    const ctx = makeCtx({
-      verifyResult: makeVerifyResult(false),
-      config: {
-        ...DEFAULT_CONFIG,
-        execution: {
-          ...DEFAULT_CONFIG.execution,
-          rectification: { enabled: false, maxRetries: 3, abortOnIncreasingFailures: true, maxFailureSummaryChars: 2000 },
-        },
-      } as any,
-    });
-    expect(rectifyStage.enabled(ctx)).toBe(false);
-  });
-
-  test("enabled when verify failed and rectification enabled", () => {
-    const ctx = makeCtx({ verifyResult: makeVerifyResult(false) });
-    expect(rectifyStage.enabled(ctx)).toBe(true);
-  });
-
-  test("returns retry when rectification succeeds", async () => {
-    const saved = { ..._rectifyDeps };
-    _rectifyDeps.runRectificationLoop = async () => true;
-
-    const ctx = makeCtx({ verifyResult: makeVerifyResult(false) });
-    const result = await rectifyStage.execute(ctx);
-
-    Object.assign(_rectifyDeps, saved);
-
-    expect(result.action).toBe("retry");
-    if (result.action === "retry") expect(result.fromStage).toBe("verify");
-    // verifyResult should be cleared so verify re-runs fresh
-    expect(ctx.verifyResult).toBeUndefined();
-  });
-
-  test("returns escalate when rectification exhausted", async () => {
-    const saved = { ..._rectifyDeps };
-    _rectifyDeps.runRectificationLoop = async () => false;
-
-    const ctx = makeCtx({ verifyResult: makeVerifyResult(false) });
-    const result = await rectifyStage.execute(ctx);
-
-    Object.assign(_rectifyDeps, saved);
-
-    expect(result.action).toBe("escalate");
-  });
-});

package/test/unit/pipeline/stages/regression-stage.test.ts

@@ -1,69 +0,0 @@
-// RE-ARCH: keep
-import { describe, expect, test } from "bun:test";
-import { regressionStage, _regressionStageDeps } from "../../../../src/pipeline/stages/regression";
-import { makePassResult, makeFailResult } from "../../../../src/verification/orchestrator-types";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import { DEFAULT_CONFIG } from "../../../../src/config";
-
-function makeCtx(mode: "deferred" | "per-story" | "disabled" = "per-story"): PipelineContext {
-  return {
-    config: {
-      ...DEFAULT_CONFIG,
-      execution: {
-        ...DEFAULT_CONFIG.execution,
-        regressionGate: { enabled: true, mode, timeoutSeconds: 60, acceptOnTimeout: true },
-      },
-      quality: { ...DEFAULT_CONFIG.quality, commands: { test: "bun test" } },
-    } as any,
-    prd: { stories: [] } as any,
-    story: { id: "US-001", title: "t", status: "in-progress", acceptanceCriteria: [] } as any,
-    stories: [],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp",
-    hooks: {},
-  };
-}
-
-describe("regressionStage", () => {
-  test("disabled when mode is deferred", () => {
-    expect(regressionStage.enabled(makeCtx("deferred"))).toBe(false);
-  });
-
-  test("disabled when mode is disabled", () => {
-    expect(regressionStage.enabled(makeCtx("disabled"))).toBe(false);
-  });
-
-  test("enabled when mode is per-story", () => {
-    expect(regressionStage.enabled(makeCtx("per-story"))).toBe(true);
-  });
-
-  test("disabled when verifyResult is a failure", () => {
-    const ctx = makeCtx("per-story");
-    ctx.verifyResult = makeFailResult("US-001", "scoped", "TEST_FAILURE");
-    expect(regressionStage.enabled(ctx)).toBe(false);
-  });
-
-  test("returns continue when regression passes", async () => {
-    const saved = { ..._regressionStageDeps };
-    _regressionStageDeps.verifyRegression = async () => makePassResult("US-001", "regression");
-
-    const result = await regressionStage.execute(makeCtx("per-story"));
-
-    Object.assign(_regressionStageDeps, saved);
-
-    expect(result.action).toBe("continue");
-  });
-
-  test("returns escalate when regression fails", async () => {
-    const saved = { ..._regressionStageDeps };
-    _regressionStageDeps.verifyRegression = async () =>
-      makeFailResult("US-001", "regression", "TEST_FAILURE", { failCount: 3 });
-
-    const result = await regressionStage.execute(makeCtx("per-story"));
-
-    Object.assign(_regressionStageDeps, saved);
-
-    expect(result.action).toBe("escalate");
-    if (result.action === "escalate") expect(result.reason).toContain("3 test");
-  });
-});

package/test/unit/pipeline/stages/review.test.ts

@@ -1,201 +0,0 @@
-/**
- * Unit tests for security-review trigger wiring in review stage (TC-003)
- *
- * Covers:
- * - Plugin reviewer failure with no trigger → always fail
- * - Plugin reviewer failure + trigger abort → fail
- * - Plugin reviewer failure + trigger non-abort → escalate
- * - Built-in check failure → escalate (unchanged)
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-import type { NaxConfig } from "../../../../src/config";
-import { InteractionChain } from "../../../../src/interaction/chain";
-import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
-import { _reviewDeps, reviewStage } from "../../../../src/pipeline/stages/review";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import type { PRD, UserStory } from "../../../../src/prd";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-const originalCheckSecurityReview = _reviewDeps.checkSecurityReview;
-
-function makeChain(action: InteractionResponse["action"]): InteractionChain {
-  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
-  const plugin: InteractionPlugin = {
-    name: "test",
-    send: mock(async () => {}),
-    receive: mock(async (id: string): Promise<InteractionResponse> => ({
-      requestId: id,
-      action,
-      respondedBy: "user",
-      respondedAt: Date.now(),
-    })),
-  };
-  chain.register(plugin);
-  return chain;
-}
-
-function makeConfig(triggers: Record<string, unknown>): NaxConfig {
-  return {
-    review: { enabled: true },
-    interaction: {
-      plugin: "cli",
-      defaults: { timeout: 30000, fallback: "abort" as const },
-      triggers,
-    },
-  } as unknown as NaxConfig;
-}
-
-function makeStory(overrides?: Partial<UserStory>): UserStory {
-  return {
-    id: "US-001",
-    title: "Test Story",
-    description: "Test",
-    acceptanceCriteria: [],
-    tags: [],
-    dependencies: [],
-    status: "in-progress",
-    passes: false,
-    escalations: [],
-    attempts: 1,
-    ...overrides,
-  };
-}
-
-function makePRD(): PRD {
-  return {
-    project: "test",
-    feature: "my-feature",
-    branchName: "test-branch",
-    createdAt: new Date().toISOString(),
-    updatedAt: new Date().toISOString(),
-    userStories: [makeStory()],
-  };
-}
-
-function makeCtx(overrides: Partial<PipelineContext>): PipelineContext {
-  return {
-    config: makeConfig({}),
-    prd: makePRD(),
-    story: makeStory(),
-    stories: [makeStory()],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp/test",
-    hooks: {} as PipelineContext["hooks"],
-    ...overrides,
-  } as unknown as PipelineContext;
-}
-
-afterEach(() => {
-  mock.restore();
-  _reviewDeps.checkSecurityReview = originalCheckSecurityReview;
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Plugin reviewer failure — no trigger configured (today behavior)
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("reviewStage — plugin failure, no trigger", () => {
-  test("returns fail when plugin reviewer fails and trigger not enabled", async () => {
-    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep found issues", builtIn: { totalDurationMs: 0 } };
-    const orchestratorMock = mock(async () => reviewResult);
-    // biome-ignore lint/suspicious/noExplicitAny: test-only import override
-    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
-    const original = reviewOrchestrator.review;
-    reviewOrchestrator.review = orchestratorMock as typeof reviewOrchestrator.review;
-
-    const ctx = makeCtx({ config: makeConfig({}) });
-    const result = await reviewStage.execute(ctx);
-
-    expect(result.action).toBe("fail");
-    reviewOrchestrator.review = original;
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Plugin reviewer failure — trigger wired via _reviewDeps
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("reviewStage — security-review trigger via _reviewDeps", () => {
-  test("returns fail when trigger responds abort (checkSecurityReview returns false)", async () => {
-    _reviewDeps.checkSecurityReview = mock(async () => false);
-
-    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep critical", builtIn: { totalDurationMs: 0 } };
-    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
-    const original = reviewOrchestrator.review;
-    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
-
-    const chain = makeChain("abort");
-    const ctx = makeCtx({
-      config: makeConfig({ "security-review": { enabled: true } }),
-      interaction: chain,
-    });
-    const result = await reviewStage.execute(ctx);
-
-    expect(result.action).toBe("fail");
-    expect(_reviewDeps.checkSecurityReview).toHaveBeenCalledTimes(1);
-    reviewOrchestrator.review = original;
-  });
-
-  test("returns escalate when trigger responds non-abort (checkSecurityReview returns true)", async () => {
-    _reviewDeps.checkSecurityReview = mock(async () => true);
-
-    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep warning", builtIn: { totalDurationMs: 0 } };
-    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
-    const original = reviewOrchestrator.review;
-    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
-
-    const chain = makeChain("approve");
-    const ctx = makeCtx({
-      config: makeConfig({ "security-review": { enabled: true } }),
-      interaction: chain,
-    });
-    const result = await reviewStage.execute(ctx);
-
-    expect(result.action).toBe("escalate");
-    expect(_reviewDeps.checkSecurityReview).toHaveBeenCalledTimes(1);
-    reviewOrchestrator.review = original;
-  });
-
-  test("does not call trigger when no interaction chain present", async () => {
-    _reviewDeps.checkSecurityReview = mock(async () => true);
-
-    const reviewResult = { success: false, pluginFailed: true, failureReason: "semgrep error", builtIn: { totalDurationMs: 0 } };
-    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
-    const original = reviewOrchestrator.review;
-    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
-
-    const ctx = makeCtx({
-      config: makeConfig({ "security-review": { enabled: true } }),
-      // no interaction
-    });
-    const result = await reviewStage.execute(ctx);
-
-    expect(result.action).toBe("fail");
-    expect(_reviewDeps.checkSecurityReview).not.toHaveBeenCalled();
-    reviewOrchestrator.review = original;
-  });
-
-  test("built-in check failure still returns escalate (unchanged behavior)", async () => {
-    _reviewDeps.checkSecurityReview = mock(async () => false);
-
-    const reviewResult = { success: false, pluginFailed: false, failureReason: "lint failed", builtIn: { totalDurationMs: 0 } };
-    const { reviewOrchestrator } = await import("../../../../src/review/orchestrator");
-    const original = reviewOrchestrator.review;
-    reviewOrchestrator.review = mock(async () => reviewResult) as typeof reviewOrchestrator.review;
-
-    const ctx = makeCtx({
-      config: makeConfig({ "security-review": { enabled: true } }),
-      interaction: makeChain("abort"),
-    });
-    const result = await reviewStage.execute(ctx);
-
-    expect(result.action).toBe("escalate");
-    // security-review trigger should NOT fire for built-in check failures
-    expect(_reviewDeps.checkSecurityReview).not.toHaveBeenCalled();
-    reviewOrchestrator.review = original;
-  });
-});