@nathapp/nax 0.27.1 → 0.29.0

package/test/unit/agent-stderr-capture.test.ts

@@ -1,147 +0,0 @@
-// RE-ARCH: keep
-/**
- * Tests for stderr capture in agent result type
- *
- * Covers: AgentResult interface includes stderr field
- */
-
-import { describe, expect, it } from "bun:test";
-import type { AgentResult } from "../../src/agents/types";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Test fixtures
-// ─────────────────────────────────────────────────────────────────────────────
-
-function createAgentResult(overrides: Partial<AgentResult> = {}): AgentResult {
-  return {
-    success: false,
-    exitCode: 1,
-    output: "",
-    stderr: "",
-    rateLimited: false,
-    durationMs: 1000,
-    estimatedCost: 0.01,
-    ...overrides,
-  };
-}
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Tests for AgentResult interface
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("AgentResult stderr field", () => {
-  it("supports stderr field in AgentResult", () => {
-    const result = createAgentResult({
-      exitCode: 1,
-      stderr: "Error: 401 Unauthorized",
-    });
-
-    expect(result.stderr).toBe("Error: 401 Unauthorized");
-  });
-
-  it("supports empty stderr string", () => {
-    const result = createAgentResult({
-      stderr: "",
-    });
-
-    expect(result.stderr).toBe("");
-  });
-
-  it("supports undefined stderr for backward compatibility", () => {
-    const result: AgentResult = {
-      success: false,
-      exitCode: 1,
-      output: "output",
-      // stderr not provided
-      rateLimited: false,
-      durationMs: 1000,
-      estimatedCost: 0.01,
-    };
-
-    expect(result.stderr).toBeUndefined();
-  });
-
-  it("can store long error messages in stderr", () => {
-    const longStderr = "Error: ".padEnd(1000, "x");
-    const result = createAgentResult({
-      stderr: longStderr,
-    });
-
-    expect(result.stderr).toHaveLength(1000);
-    expect(result.stderr).toContain("Error:");
-  });
-
-  it("includes stderr in all failure scenarios", () => {
-    const scenarios = [
-      { exitCode: 1, stderr: "Generic error" },
-      { exitCode: 401, stderr: "Unauthorized" },
-      { exitCode: 500, stderr: "Internal server error" },
-      { exitCode: 124, stderr: "Timeout" },
-    ];
-
-    for (const scenario of scenarios) {
-      const result = createAgentResult({
-        exitCode: scenario.exitCode,
-        stderr: scenario.stderr,
-      });
-
-      expect(result.exitCode).toBe(scenario.exitCode);
-      expect(result.stderr).toBe(scenario.stderr);
-    }
-  });
-
-  it("preserves newlines in stderr", () => {
-    const multilineStderr = "Error: Something failed\nDetails: xyz\nContext: abc";
-    const result = createAgentResult({
-      stderr: multilineStderr,
-    });
-
-    expect(result.stderr).toContain("\n");
-    expect(result.stderr).toContain("Details:");
-  });
-
-  it("allows stderr with special characters", () => {
-    const specialStderr = 'Error: "quoted" with \\backslash and \t tab';
-    const result = createAgentResult({
-      stderr: specialStderr,
-    });
-
-    expect(result.stderr).toBe(specialStderr);
-  });
-
-  it("can be serialized to JSON", () => {
-    const result = createAgentResult({
-      exitCode: 401,
-      stderr: "401 Unauthorized: Invalid API key",
-    });
-
-    const json = JSON.stringify(result);
-    expect(json).toContain("401");
-    expect(json).toContain("Unauthorized");
-
-    const parsed = JSON.parse(json) as AgentResult;
-    expect(parsed.stderr).toBe("401 Unauthorized: Invalid API key");
-  });
-
-  it("maintains other fields when stderr is set", () => {
-    const result = createAgentResult({
-      success: false,
-      exitCode: 1,
-      output: "stdout output",
-      stderr: "stderr output",
-      rateLimited: false,
-      durationMs: 5000,
-      estimatedCost: 0.05,
-      pid: 12345,
-    });
-
-    expect(result.success).toBe(false);
-    expect(result.exitCode).toBe(1);
-    expect(result.output).toBe("stdout output");
-    expect(result.stderr).toBe("stderr output");
-    expect(result.rateLimited).toBe(false);
-    expect(result.durationMs).toBe(5000);
-    expect(result.estimatedCost).toBe(0.05);
-    expect(result.pid).toBe(12345);
-  });
-});

package/test/unit/agents/claude.test.ts

@@ -1,107 +0,0 @@
-// RE-ARCH: keep
-/**
- * Tests for ClaudeCodeAdapter.runOnce() timeout behavior
- *
- * Covers: US-001 - runOnce() SIGKILL follow-up after grace period
- * - SIGTERM is sent first on timeout
- * - PID is always unregistered in finally block, even if kill() throws
- */
-
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { existsSync, mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { ClaudeCodeAdapter, _runOnceDeps } from "../../../src/agents/claude";
-import type { AgentRunOptions } from "../../../src/agents/types";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Test adapter — overrides buildCommand to avoid requiring the claude binary
-// ─────────────────────────────────────────────────────────────────────────────
-
-class TestAdapter extends ClaudeCodeAdapter {
-  private readonly testCmd: string[];
-
-  constructor(cmd: string[]) {
-    super();
-    this.testCmd = cmd;
-  }
-
-  override buildCommand(_options: AgentRunOptions): string[] {
-    return this.testCmd;
-  }
-}
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-function makeRunOptions(workdir: string, timeoutSeconds: number): AgentRunOptions {
-  return {
-    workdir,
-    prompt: "test",
-    modelTier: "balanced",
-    modelDef: { provider: "anthropic", model: "claude-sonnet-4-5", env: {} },
-    timeoutSeconds,
-  };
-}
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Tests
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("runOnce() timeout behavior", () => {
-  let tempDir: string;
-  const origKillProc = _runOnceDeps.killProc;
-
-  beforeEach(() => {
-    tempDir = mkdtempSync(join(tmpdir(), "nax-claude-test-"));
-  });
-
-  afterEach(() => {
-    // Restore original killProc after each test
-    _runOnceDeps.killProc = origKillProc;
-    if (existsSync(tempDir)) {
-      rmSync(tempDir, { recursive: true });
-    }
-  });
-
-  test("timeout path sends SIGTERM to process first", async () => {
-    const sentSignals: string[] = [];
-
-    // Record signals sent but still kill the process so proc.exited resolves
-    _runOnceDeps.killProc = (proc, signal) => {
-      sentSignals.push(String(signal));
-      origKillProc(proc, signal);
-    };
-
-    // Long-running process: will be killed by the 100ms timeout
-    const adapter = new TestAdapter(["/bin/sh", "-c", "sleep 100"]);
-    const result = await adapter.run(makeRunOptions(tempDir, 0.1));
-
-    expect(result.exitCode).toBe(124); // timeout exit code
-    expect(sentSignals[0]).toBe("SIGTERM"); // SIGTERM sent first
-  });
-
-  test("timeout path: unregisters PID even if killProc throws", async () => {
-    // Override killProc to throw — simulates kill() failing (e.g., process already gone)
-    _runOnceDeps.killProc = (_proc, _signal) => {
-      throw new Error("kill failed");
-    };
-
-    // Use a short-lived process (0.5s) with a timeout that fires first (50ms).
-    // killProc throws (process not killed), so proc exits naturally at ~0.5s.
-    // The finally block must still call unregister regardless.
-    const adapter = new TestAdapter(["/bin/sh", "-c", "sleep 0.5"]);
-    const options = makeRunOptions(tempDir, 0.05); // 50ms timeout
-
-    // Should not throw — kill errors are caught internally
-    await adapter.run(options);
-
-    // PID must have been unregistered (file empty or absent)
-    const pidsFile = join(tempDir, ".nax-pids");
-    if (existsSync(pidsFile)) {
-      const content = await Bun.file(pidsFile).text();
-      expect(content.trim()).toBe("");
-    }
-  });
-});

package/test/unit/analyze-classifier.test.ts

@@ -1,216 +0,0 @@
-// RE-ARCH: keep
-/**
- * Tests for LLM Classifier
- */
-
-import { describe, expect, test } from "bun:test";
-import type { CodebaseScan } from "../../src/analyze";
-import { classifyStories } from "../../src/analyze/classifier";
-import { DEFAULT_CONFIG } from "../../src/config";
-import type { UserStory } from "../../src/prd";
-
-describe("classifyStories", () => {
-  const mockScan: CodebaseScan = {
-    fileTree: "src/\n├── index.ts\n└── utils/\n    └── helper.ts",
-    dependencies: { zod: "^4.0.0" },
-    devDependencies: { typescript: "^5.0.0" },
-    testPatterns: ["Test framework: bun:test", "Test directory: test/"],
-  };
-
-  const mockStories: UserStory[] = [
-    {
-      id: "US-001",
-      title: "Add input validation",
-      description: "Validate user inputs with Zod schemas",
-      acceptanceCriteria: ["Schema defined", "Validation works"],
-      tags: [],
-      dependencies: [],
-      status: "pending",
-      passes: false,
-      escalations: [],
-      attempts: 0,
-    },
-  ];
-
-  test("falls back to keyword matching when LLM disabled", async () => {
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: false,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    const result = await classifyStories(mockStories, mockScan, config);
-
-    expect(result.method).toBe("keyword-fallback");
-    expect(result.fallbackReason).toBe("LLM-enhanced analysis disabled in config");
-    expect(result.classifications).toHaveLength(1);
-    expect(result.classifications[0].storyId).toBe("US-001");
-  });
-
-  test("falls back to keyword matching when ANTHROPIC_API_KEY missing", async () => {
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: true,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    // Temporarily unset API key
-    const originalKey = process.env.ANTHROPIC_API_KEY;
-    delete process.env.ANTHROPIC_API_KEY;
-
-    try {
-      const result = await classifyStories(mockStories, mockScan, config);
-
-      expect(result.method).toBe("keyword-fallback");
-      expect(result.fallbackReason).toContain("ANTHROPIC_API_KEY");
-      expect(result.classifications).toHaveLength(1);
-    } finally {
-      // Restore API key
-      if (originalKey) {
-        process.env.ANTHROPIC_API_KEY = originalKey;
-      }
-    }
-  });
-
-  test("keyword fallback classification includes all required fields", async () => {
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: false,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    const result = await classifyStories(mockStories, mockScan, config);
-
-    const classification = result.classifications[0];
-    expect(classification.storyId).toBe("US-001");
-    expect(classification.complexity).toMatch(/simple|medium|complex|expert/);
-    expect(classification.contextFiles).toEqual([]);
-    expect(classification.reasoning).toContain("Keyword-based classification");
-    expect(typeof classification.estimatedLOC).toBe("number");
-    expect(classification.estimatedLOC).toBeGreaterThan(0);
-    expect(classification.risks).toEqual([]);
-  });
-
-  test("classifies simple stories correctly in keyword mode", async () => {
-    const simpleStory: UserStory = {
-      id: "US-002",
-      title: "Update button color",
-      description: "Change primary button to blue",
-      acceptanceCriteria: ["Button is blue"],
-      tags: [],
-      dependencies: [],
-      status: "pending",
-      passes: false,
-      escalations: [],
-      attempts: 0,
-    };
-
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: false,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    const result = await classifyStories([simpleStory], mockScan, config);
-
-    expect(result.classifications[0].complexity).toBe("simple");
-    expect(result.classifications[0].estimatedLOC).toBe(50); // Simple = 50 LOC
-  });
-
-  test("classifies complex stories correctly in keyword mode", async () => {
-    const complexStory: UserStory = {
-      id: "US-003",
-      title: "Add JWT authentication",
-      description: "Implement secure JWT authentication with refresh tokens",
-      acceptanceCriteria: [
-        "Token generation",
-        "Token validation",
-        "Refresh logic",
-        "Expiry handling",
-        "Secure storage",
-      ],
-      tags: ["security", "auth"],
-      dependencies: [],
-      status: "pending",
-      passes: false,
-      escalations: [],
-      attempts: 0,
-    };
-
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: false,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    const result = await classifyStories([complexStory], mockScan, config);
-
-    expect(result.classifications[0].complexity).toBe("complex");
-    expect(result.classifications[0].estimatedLOC).toBe(400); // Complex = 400 LOC
-  });
-
-  test("processes multiple stories", async () => {
-    const stories: UserStory[] = [
-      {
-        id: "US-001",
-        title: "Story 1",
-        description: "First story",
-        acceptanceCriteria: ["AC1"],
-        tags: [],
-        dependencies: [],
-        status: "pending",
-        passes: false,
-        escalations: [],
-        attempts: 0,
-      },
-      {
-        id: "US-002",
-        title: "Story 2",
-        description: "Second story",
-        acceptanceCriteria: ["AC2"],
-        tags: [],
-        dependencies: [],
-        status: "pending",
-        passes: false,
-        escalations: [],
-        attempts: 0,
-      },
-    ];
-
-    const config = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        llmEnhanced: false,
-        classifierModel: "fast" as const,
-        fallbackToKeywords: true,
-        maxCodebaseSummaryTokens: 5000,
-      },
-    };
-
-    const result = await classifyStories(stories, mockScan, config);
-
-    expect(result.classifications).toHaveLength(2);
-    expect(result.classifications[0].storyId).toBe("US-001");
-    expect(result.classifications[1].storyId).toBe("US-002");
-  });
-});

package/test/unit/analyze.test.ts

@@ -1,224 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { analyzeFeature } from "../../src/cli/analyze";
-import type { NaxConfig } from "../../src/config";
-import { DEFAULT_CONFIG } from "../../src/config/schema";
-
-describe("analyzeFeature", () => {
-  test("parses spec.md into user stories (LLM disabled, keyword fallback)", async () => {
-    const tmpDir = `/tmp/nax-analyze-${Date.now()}`;
-    await Bun.spawn(["mkdir", "-p", tmpDir], { stdout: "pipe" }).exited;
-
-    await Bun.write(
-      `${tmpDir}/spec.md`,
-      `# Feature: Auth System
-
-## US-001: Add login endpoint
-
-### Description
-Create a POST /auth/login endpoint that accepts email and password.
-
-### Acceptance Criteria
-- [ ] Endpoint returns JWT token on success
-- [ ] Returns 401 on invalid credentials
-- [ ] Rate limited to 5 attempts per minute
-
-Tags: security, auth
-Dependencies: US-000
-
-## US-002: Add logout endpoint
-
-### Description
-Create a POST /auth/logout endpoint.
-
-### Acceptance Criteria
-- [ ] Invalidates the current token
-- [ ] Returns 200 on success
-
-Dependencies: US-001
-`,
-    );
-
-    // Disable LLM for keyword-based classification
-    const config: NaxConfig = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        ...DEFAULT_CONFIG.analyze,
-        llmEnhanced: false,
-      },
-    };
-
-    const prd = await analyzeFeature({
-      featureDir: tmpDir,
-      featureName: "auth",
-      branchName: "feat/auth",
-      config,
-    });
-
-    expect(prd.feature).toBe("auth");
-    expect(prd.branchName).toBe("feat/auth");
-    expect(prd.userStories).toHaveLength(2);
-
-    const s1 = prd.userStories[0];
-    expect(s1.id).toBe("US-001");
-    expect(s1.title).toBe("Add login endpoint");
-    expect(s1.acceptanceCriteria).toHaveLength(3);
-    expect(s1.tags).toContain("security");
-    expect(s1.dependencies).toContain("US-000");
-
-    const s2 = prd.userStories[1];
-    expect(s2.id).toBe("US-002");
-    expect(s2.title).toBe("Add logout endpoint");
-    expect(s2.acceptanceCriteria).toHaveLength(2);
-    expect(s2.dependencies).toContain("US-001");
-
-    await Bun.spawn(["rm", "-rf", tmpDir], { stdout: "pipe" }).exited;
-  });
-
-  test("throws when spec.md is missing", async () => {
-    const tmpDir = `/tmp/nax-analyze-empty-${Date.now()}`;
-    await Bun.spawn(["mkdir", "-p", tmpDir], { stdout: "pipe" }).exited;
-
-    await expect(
-      analyzeFeature({
-        featureDir: tmpDir,
-        featureName: "test",
-        branchName: "feat/test",
-      }),
-    ).rejects.toThrow("spec.md not found");
-
-    await Bun.spawn(["rm", "-rf", tmpDir], { stdout: "pipe" }).exited;
-  });
-
-  test("warns but does not throw when story count exceeds maxStoriesPerFeature limit", async () => {
-    const tmpDir = `/tmp/nax-analyze-limit-${Date.now()}`;
-    await Bun.spawn(["mkdir", "-p", tmpDir], { stdout: "pipe" }).exited;
-
-    // Generate spec.md with 6 stories
-    const stories = Array.from(
-      { length: 6 },
-      (_, i) => `
-## US-${String(i + 1).padStart(3, "0")}: Story ${i + 1}
-
-### Description
-Description for story ${i + 1}
-
-### Acceptance Criteria
-- [ ] Criterion 1
-`,
-    ).join("\n");
-
-    await Bun.write(`${tmpDir}/spec.md`, `# Feature\n${stories}`);
-
-    // Create config with limit of 5 stories (LLM disabled)
-    const config: NaxConfig = {
-      ...DEFAULT_CONFIG,
-      execution: {
-        ...DEFAULT_CONFIG.execution,
-        maxStoriesPerFeature: 5,
-      },
-      analyze: {
-        ...DEFAULT_CONFIG.analyze,
-        llmEnhanced: false,
-      },
-    };
-
-    // Should warn but still succeed (no longer throws)
-    const prd = await analyzeFeature({
-      featureDir: tmpDir,
-      featureName: "test",
-      branchName: "feat/test",
-      config,
-    });
-
-    expect(prd.userStories.length).toBe(6);
-
-    await Bun.spawn(["rm", "-rf", tmpDir], { stdout: "pipe" }).exited;
-  });
-
-  test("allows story count at maxStoriesPerFeature limit", async () => {
-    const tmpDir = `/tmp/nax-analyze-ok-${Date.now()}`;
-    await Bun.spawn(["mkdir", "-p", tmpDir], { stdout: "pipe" }).exited;
-
-    // Generate spec.md with exactly 5 stories
-    const stories = Array.from(
-      { length: 5 },
-      (_, i) => `
-## US-${String(i + 1).padStart(3, "0")}: Story ${i + 1}
-
-### Description
-Description for story ${i + 1}
-
-### Acceptance Criteria
-- [ ] Criterion 1
-`,
-    ).join("\n");
-
-    await Bun.write(`${tmpDir}/spec.md`, `# Feature\n${stories}`);
-
-    // Create config with limit of 5 stories (LLM disabled)
-    const config: NaxConfig = {
-      ...DEFAULT_CONFIG,
-      execution: {
-        ...DEFAULT_CONFIG.execution,
-        maxStoriesPerFeature: 5,
-      },
-      analyze: {
-        ...DEFAULT_CONFIG.analyze,
-        llmEnhanced: false,
-      },
-    };
-
-    // Should NOT throw because 5 === 5
-    const prd = await analyzeFeature({
-      featureDir: tmpDir,
-      featureName: "test",
-      branchName: "feat/test",
-      config,
-    });
-    expect(prd.userStories).toHaveLength(5);
-
-    await Bun.spawn(["rm", "-rf", tmpDir], { stdout: "pipe" }).exited;
-  });
-
-  test("reads spec from explicit --from path", async () => {
-    const tmpDir = `/tmp/nax-analyze-from-${Date.now()}`;
-    await Bun.spawn(["mkdir", "-p", tmpDir], { stdout: "pipe" }).exited;
-
-    const customSpecPath = `${tmpDir}/custom-spec.md`;
-    await Bun.write(
-      customSpecPath,
-      `# Custom Spec
-
-## US-001: Custom story
-
-### Description
-A custom story from explicit path
-
-### Acceptance Criteria
-- [ ] Works with --from flag
-`,
-    );
-
-    const config: NaxConfig = {
-      ...DEFAULT_CONFIG,
-      analyze: {
-        ...DEFAULT_CONFIG.analyze,
-        llmEnhanced: false,
-      },
-    };
-
-    const prd = await analyzeFeature({
-      featureDir: tmpDir,
-      featureName: "custom",
-      branchName: "feat/custom",
-      config,
-      specPath: customSpecPath,
-    });
-
-    expect(prd.userStories).toHaveLength(1);
-    expect(prd.userStories[0].id).toBe("US-001");
-    expect(prd.userStories[0].title).toBe("Custom story");
-
-    await Bun.spawn(["rm", "-rf", tmpDir], { stdout: "pipe" }).exited;
-  });
-});