@mycadet/assistant 0.12.9 → 0.12.10

package/src/telemetry/__tests__/telemetry-event-fixtures.ts

@@ -1,282 +0,0 @@
-/**
- * Shared sample telemetry events for the wire-contract test suites
- * (`types.test.ts` and `telemetry-wire-validation.test.ts`).
- *
- * `wireEventSamples` holds exactly one daemon-typed, wire-valid sample per
- * generated wire event type — when the wire contract gains an event type,
- * add its sample here and both suites pick it up. The daemon-type
- * annotations are themselves part of the contract test: they compile-check
- * that realistic daemon values inhabit the hand-written override types.
- *
- * Imported by `*.test.ts` files only — never by the test preload — so
- * importing daemon types from `src/` is safe (AGENTS.md "Test machinery
- * isolation" scopes its no-`src/` rule to preload-time machinery). The
- * imports are type-only; this module has no runtime side effects.
- */
-import type {
-  AuthFallbackTelemetryEvent,
-  AvatarChangedTelemetryEvent,
-  ConfigSettingTelemetryEvent,
-  LifecycleTelemetryEvent,
-  LlmUsageTelemetryEvent,
-  OnboardingResearchTelemetryEvent,
-  OnboardingTelemetryEvent,
-  SkillLoadedTelemetryEvent,
-  ToolExecutedTelemetryEvent,
-  TurnTelemetryEvent,
-  TurnTrace,
-  WatchdogTelemetryEvent,
-} from "../types.js";
-
-const RECORDED_AT = 1_750_000_000_000;
-
-const llmUsage: LlmUsageTelemetryEvent = {
-  type: "llm_usage",
-  daemon_event_id: "evt-llm-usage-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  conversation_id: "conv-xyz",
-  conversation_type: "standard",
-  // Zero is legitimate here (wire bound is min(0)) — the wire schema must
-  // not reject it.
-  turn_index: 0,
-  parent_conversation_id: "conv-parent",
-  // Zero is legitimate (wire bound is min(0)): a subagent can be spawned
-  // before the parent's first real user turn.
-  parent_turn_index: 0,
-  subagent_role: "advisor",
-  subagent_spawn_mode: "advisor_consult",
-  provider: "anthropic",
-  model: "claude-fable-5",
-  input_tokens: 1200,
-  output_tokens: 340,
-  cache_creation_input_tokens: 256,
-  cache_read_input_tokens: 1024,
-  llm_call_count: 3,
-  raw_usage: {
-    input_tokens: 1200,
-    cache_creation: { ephemeral_5m_input_tokens: 256 },
-  },
-  actor: "user",
-  llm_call_site: "mainAgent",
-  inference_profile: "balanced",
-  inference_profile_source: "active",
-  cost: 0.0123,
-};
-
-const trace: TurnTrace = {
-  schema_version: 3,
-  messages: [
-    {
-      id: "msg-1",
-      role: "user",
-      created_at: RECORDED_AT - 5_000,
-      content: [{ type: "text", text: "What's on my calendar today?" }],
-      model: null,
-    },
-    {
-      id: "msg-2",
-      role: "assistant",
-      created_at: RECORDED_AT - 1_000,
-      content: [{ type: "text", text: "You have two meetings." }],
-      model: "claude-fable-5",
-    },
-  ],
-  tool_calls: [
-    {
-      id: "inv-1",
-      tool_name: "bash",
-      input: { command: "ls" },
-      result: "ok",
-      decision: "allow",
-      duration_ms: 42,
-      created_at: RECORDED_AT - 3_000,
-    },
-  ],
-  system_prompt: "You are a helpful assistant.",
-  tool_definitions: [
-    {
-      name: "bash",
-      description: "Run a shell command",
-      input_schema: { type: "object", properties: {} },
-    },
-  ],
-};
-
-/** Exported separately: both suites build negative `client`-bag cases on it. */
-export const turnEventSample: TurnTelemetryEvent = {
-  type: "turn",
-  daemon_event_id: "evt-turn-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  conversation_id: "conv-xyz",
-  conversation_type: "standard",
-  turn_index: 1,
-  interface_id: "web",
-  channel_id: "cadet",
-  client: {
-    browser_family: "chrome",
-    browser_version: "124",
-    os: "macos",
-    interface_version: "0.8.2",
-  },
-  outcome: "failed",
-  failure_code: "PROVIDER_RATE_LIMIT",
-  trace,
-};
-
-const lifecycle: LifecycleTelemetryEvent = {
-  type: "lifecycle",
-  daemon_event_id: "evt-lifecycle-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  event_name: "app_open",
-};
-
-const onboarding: OnboardingTelemetryEvent = {
-  type: "onboarding",
-  daemon_event_id: "evt-onboarding-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  screen: "tools",
-  tools: ["gmail", "calendar"],
-  tasks: ["email-triage"],
-  tone: "friendly",
-  google_connected: true,
-  google_scopes: ["https://www.googleapis.com/auth/gmail.readonly"],
-  ab_variant: "control",
-  session_id: "sess-123",
-  step_name: "select-tools",
-  step_index: 2,
-  completed_at: "2026-07-13T00:00:00Z",
-  funnel_version: "v2",
-  user_id: "user-123",
-};
-
-const authFallback: AuthFallbackTelemetryEvent = {
-  type: "auth_fallback",
-  daemon_event_id: "evt-auth-fallback-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  guard: "edge",
-  path: "/v1/conversations",
-  failure_kind: "missing_authorization",
-  count: 7,
-  window_start: RECORDED_AT - 300_000,
-  window_end: RECORDED_AT,
-};
-
-const toolExecuted: ToolExecutedTelemetryEvent = {
-  type: "tool_executed",
-  daemon_event_id: "evt-tool-executed-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  provider: "anthropic",
-  model: "claude-fable-5",
-  inference_profile: "balanced",
-  inference_profile_source: "call_site",
-  tool_name: "bash",
-  status: "fulfilled",
-  duration_ms: 42,
-  arg_bytes: 128,
-  result_bytes: 2048,
-  conversation_id: "conv-xyz",
-};
-
-const skillLoaded: SkillLoadedTelemetryEvent = {
-  type: "skill_loaded",
-  daemon_event_id: "evt-skill-loaded-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  provider: "anthropic",
-  model: "claude-fable-5",
-  inference_profile: "balanced",
-  inference_profile_source: "conversation",
-  skill_name: "plugin-builder",
-  skill_updated_at: "2026-06-01T00:00:00Z",
-  conversation_id: "conv-xyz",
-};
-
-const watchdog: WatchdogTelemetryEvent = {
-  type: "watchdog",
-  daemon_event_id: "evt-watchdog-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  check_name: "event_loop_blocked",
-  value: 1200,
-  detail: { reason: "gc", blocked_ms: 1200 },
-};
-
-const configSetting: ConfigSettingTelemetryEvent = {
-  type: "config_setting",
-  daemon_event_id: "evt-config-setting-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  config_key: "memory.enabled",
-  config_value: "true",
-};
-
-/**
- * `onboarding_research` sample. The daemon's type is richer than the wire
- * (structured `claims`/`suggestions`, closed `status`), so it is an `Overrides`
- * entry; the wire schema (opaque JSON arrays, size-bounded) still accepts it.
- */
-export const onboardingResearch: OnboardingResearchTelemetryEvent = {
-  type: "onboarding_research",
-  daemon_event_id: "evt-onboarding-research-1",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  conversation_id: "conv-xyz",
-  status: "done",
-  claims: [
-    {
-      claim: "Works on developer tooling",
-      confidence: "confident",
-      sources: ["https://example.com/profile"],
-    },
-  ],
-  claim_count: 1,
-  claims_confident: 1,
-  claims_maybe: 0,
-  claims_guessing: 0,
-  suggestions: [
-    {
-      suggestion: "Set up email triage",
-      prompt: "Help me triage my inbox",
-    },
-  ],
-  suggestion_count: 1,
-  plugins: ["gmail"],
-  installed_plugins: ["gmail", "calendar"],
-};
-
-const avatarChanged: AvatarChangedTelemetryEvent = {
-  type: "avatar_changed",
-  daemon_event_id: "evt-avatar-changed-001",
-  recorded_at: RECORDED_AT,
-  assistant_version: "1.2.3",
-  action: "set_character",
-  kind: "character",
-  previous_kind: "none",
-  body_shape: "blob",
-  eye_style: "curious",
-  color: "green",
-  accent_hex: "#4caf50",
-  accent_source: "palette",
-  client_os: "macos",
-};
-
-/** One daemon-typed, wire-valid sample per generated wire event type. */
-export const wireEventSamples = [
-  llmUsage,
-  turnEventSample,
-  lifecycle,
-  onboarding,
-  authFallback,
-  toolExecuted,
-  skillLoaded,
-  watchdog,
-  configSetting,
-  onboardingResearch,
-  avatarChanged,
-] as const;

package/src/telemetry/__tests__/watchdog-events-store.test.ts

@@ -1,71 +0,0 @@
-import { beforeEach, describe, expect, test } from "bun:test";
-
-import { APP_VERSION } from "../../version.js";
-import { recordWatchdogEvent } from "../watchdog-events-store.js";
-import {
-  pendingOutboxPayloads,
-  pendingOutboxRows,
-  resetOutboxTable,
-  setShareAnalytics,
-} from "./outbox-test-harness.js";
-
-describe("watchdog-events-store", () => {
-  beforeEach(() => {
-    setShareAnalytics(true);
-    resetOutboxTable();
-  });
-
-  test("honors the share_analytics opt-out (records nothing)", () => {
-    setShareAnalytics(false);
-    recordWatchdogEvent({ checkName: "event_loop_blocked", value: 60000 });
-    expect(pendingOutboxRows("watchdog", 10)).toHaveLength(0);
-  });
-
-  test("records the full wire event, with detail as a nested object", () => {
-    recordWatchdogEvent({
-      checkName: "event_loop_blocked",
-      value: 12345,
-      detail: { reason: "no_bytes_60s", threshold_ms: 5000 },
-    });
-
-    const rows = pendingOutboxRows("watchdog", 10);
-    expect(rows).toHaveLength(1);
-    const row = rows[0]!;
-    expect(row.id).toBeString();
-    expect(row.createdAt).toBeGreaterThan(0);
-    expect(JSON.parse(row.payload)).toEqual({
-      type: "watchdog",
-      daemon_event_id: row.id,
-      recorded_at: row.createdAt,
-      check_name: "event_loop_blocked",
-      value: 12345,
-      detail: { reason: "no_bytes_60s", threshold_ms: 5000 },
-      assistant_version: APP_VERSION,
-    });
-  });
-
-  test("omitted value and detail persist as null", () => {
-    recordWatchdogEvent({ checkName: "stream_idle" });
-
-    const payloads = pendingOutboxPayloads("watchdog");
-    expect(payloads).toHaveLength(1);
-    expect(payloads[0]).toMatchObject({
-      check_name: "stream_idle",
-      value: null,
-      detail: null,
-    });
-  });
-
-  test("explicit null value and detail persist as null", () => {
-    recordWatchdogEvent({
-      checkName: "restart",
-      value: null,
-      detail: null,
-    });
-
-    const payloads = pendingOutboxPayloads("watchdog");
-    expect(payloads).toHaveLength(1);
-    expect(payloads[0]?.value).toBeNull();
-    expect(payloads[0]?.detail).toBeNull();
-  });
-});

package/src/telemetry/activation-funnel.ts

@@ -1,172 +0,0 @@
-/**
- * Activation funnel vocabulary — the single source of truth for the
- * activation-rail telemetry funnel.
- *
- * The activation rail emits milestone ("funnel") events into the existing
- * onboarding telemetry substrate (`type: "onboarding"`). This module defines
- * the step vocabulary (step_name → step_index), the funnel version, the
- * cohort arm tag, and the deterministic `daemon_event_id` used for dbt-side
- * dedup. Downstream PRs (store, reporter, emit handler, turn hook) import
- * from here so the vocabulary is never duplicated.
- */
-
-/** Funnel version stamped on every activation event (per JARVIS-1033). */
-export const ACTIVATION_FUNNEL_VERSION = "activation_v1_2026_06";
-
-/**
- * Filename of the bootstrap template that drives the activation rail. The web
- * prechat-context sets this as `onboardingContext.bootstrapTemplate` (mirrored
- * there as `ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE`); the daemon recognizes it to
- * mark the conversation as an activation session. Single source of truth on the
- * daemon side so the literal isn't duplicated across modules.
- */
-export const ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE =
-  "BOOTSTRAP-ACTIVATION-RAIL.md";
-
-/**
- * Cohort arm tag for Stream-A emission. The daemon only runs the rail for
- * treatment users, so activation events are tagged with the treatment arm
- * name ("variant-a"), mirroring `pre-chat-onboarding-experiment-2026-06-06`.
- * Stream B later threads the assigned arm in place of this constant.
- */
-export const ACTIVATION_AB_VARIANT = "variant-a";
-
-/**
- * Activation funnel steps keyed by short id. `stepName` is the wire value
- * sent to telemetry; `stepIndex` is the 1-based ordinal position. This is
- * the single source of truth for the step vocabulary.
- */
-export const ACTIVATION_STEPS = {
-  moment1: { stepName: "activation_moment_1_complete", stepIndex: 1 },
-  moment2: { stepName: "activation_moment_2_complete", stepIndex: 2 },
-  moment3: { stepName: "activation_moment_3_complete", stepIndex: 3 },
-  firstWowExecuted: { stepName: "activation_first_wow_executed", stepIndex: 4 },
-  firstWowInteracted: {
-    stepName: "activation_first_wow_interacted",
-    stepIndex: 5,
-  },
-} as const;
-
-/** Union of valid activation step names. */
-export type ActivationStepName =
-  (typeof ACTIVATION_STEPS)[keyof typeof ACTIVATION_STEPS]["stepName"];
-
-/** step_name → step_index, derived once from the vocabulary. */
-const STEP_INDEX_BY_NAME = new Map<ActivationStepName, number>(
-  Object.values(ACTIVATION_STEPS).map((step) => [
-    step.stepName,
-    step.stepIndex,
-  ]),
-);
-
-/** Type guard: is `value` one of the known activation step names? */
-export function isActivationStepName(
-  value: string,
-): value is ActivationStepName {
-  return STEP_INDEX_BY_NAME.has(value as ActivationStepName);
-}
-
-/**
- * Model-facing activation-moment tokens. These are the values the model passes
- * as the optional `ui_show` `activation_moment` tag; the daemon maps each token
- * to its `ACTIVATION_STEPS[...].stepName` and records the milestone when the
- * tagged surface is committed. Kept short/stable so the schema enum is friendly
- * for the model — the canonical wire vocabulary stays `ActivationStepName`.
- */
-export type ActivationMomentParam =
-  | "moment_1"
-  | "moment_2"
-  | "moment_3"
-  | "first_wow_executed"
-  | "first_wow_interacted";
-
-/**
- * `ActivationMomentParam` token → canonical `ActivationStepName`, derived from
- * `ACTIVATION_STEPS` so the vocabulary stays single-sourced. The token order
- * mirrors `ACTIVATION_STEPS` (indices 1–5).
- */
-const STEP_NAME_BY_MOMENT_PARAM = {
-  moment_1: ACTIVATION_STEPS.moment1.stepName,
-  moment_2: ACTIVATION_STEPS.moment2.stepName,
-  moment_3: ACTIVATION_STEPS.moment3.stepName,
-  first_wow_executed: ACTIVATION_STEPS.firstWowExecuted.stepName,
-  first_wow_interacted: ACTIVATION_STEPS.firstWowInteracted.stepName,
-} as const satisfies Record<ActivationMomentParam, ActivationStepName>;
-
-/** The five valid model-facing moment tokens (e.g. for a schema enum). */
-export const ACTIVATION_MOMENT_PARAMS = Object.keys(
-  STEP_NAME_BY_MOMENT_PARAM,
-) as ActivationMomentParam[];
-
-/** Type guard: is `value` one of the model-facing activation-moment tokens? */
-export function isActivationMomentParam(
-  value: string,
-): value is ActivationMomentParam {
-  return Object.prototype.hasOwnProperty.call(STEP_NAME_BY_MOMENT_PARAM, value);
-}
-
-/** Map a model-facing moment token to its canonical activation step name. */
-export function activationStepNameForMomentParam(
-  param: ActivationMomentParam,
-): ActivationStepName {
-  return STEP_NAME_BY_MOMENT_PARAM[param];
-}
-
-/**
- * When each tagged moment is emitted relative to its `ui_show` surface:
- * - `"show"` — at surface render time. `first_wow_executed` is an *execution*
- *   signal: the rail's result/`work_result` surface is display-only and may
- *   receive no user commit, so a commit-time emit would never fire (and if the
- *   card has an action, deferring to the click would conflate "executed" with
- *   "interacted" and corrupt funnel timing).
- * - `"commit"` — on user commit/interaction. The other four moments represent
- *   resolving an intake, picking an offer/task, or clicking a result action —
- *   all genuine commit events.
- */
-export const ACTIVATION_MOMENT_EMIT_AT = {
-  moment_1: "commit",
-  moment_2: "commit",
-  moment_3: "commit",
-  first_wow_executed: "show",
-  first_wow_interacted: "commit",
-} as const satisfies Record<ActivationMomentParam, "show" | "commit">;
-
-/** True when the moment records at surface-render time rather than on commit. */
-export function activationMomentEmitsAtShow(
-  param: ActivationMomentParam,
-): boolean {
-  return ACTIVATION_MOMENT_EMIT_AT[param] === "show";
-}
-
-/** Look up the 1-based funnel index for a step name. */
-export function activationStepIndex(stepName: ActivationStepName): number {
-  // Non-null: ActivationStepName is derived from ACTIVATION_STEPS, so the map
-  // always contains the key.
-  return STEP_INDEX_BY_NAME.get(stepName)!;
-}
-
-/**
- * Deterministic `daemon_event_id` for an activation event. Keying on
- * `${funnel_version}:${sessionId}:${stepName}` lets the existing dbt
- * dedup (keyed on `daemon_event_id`, earliest-wins) collapse a moment that
- * fires more than once into a single row.
- *
- * `funnelVersion` defaults to the current `ACTIVATION_FUNNEL_VERSION` but
- * callers that have a per-row stored version (e.g. the telemetry reporter
- * flushing rows recorded under an older version) MUST pass the row's own
- * `funnel_version` so the id stays stable across a version bump — otherwise
- * queued/offline v1 rows would be keyed with the new binary's version and
- * stop collapsing with already-ingested v1 rows from the same session.
- *
- * `stepName` is a plain string rather than an `ActivationStepName`: every
- * funnel riding the onboarding substrate shares this keying (the live-voice
- * session funnel is the other one today), and the dedup property depends only
- * on the triple being stable per row, not on which funnel produced it.
- */
-export function buildActivationDaemonEventId(
-  sessionId: string,
-  stepName: string,
-  funnelVersion: string = ACTIVATION_FUNNEL_VERSION,
-): string {
-  return `${funnelVersion}:${sessionId}:${stepName}`;
-}

package/src/telemetry/config-setting-events-store.ts

@@ -1,40 +0,0 @@
-import { recordTelemetryEvent } from "./telemetry-events-outbox.js";
-
-/**
- * Server-side bounds from the cloud `ConfigSettingTelemetryEventSerializer`.
- * Values are clamped at record time so an oversize pair degrades to a
- * truncated event instead of a per-event ingest rejection.
- */
-const MAX_CONFIG_KEY_CHARS = 128;
-const MAX_CONFIG_VALUE_CHARS = 256;
-
-/**
- * Input for one `config_setting` telemetry event. Metadata only — emitters
- * must record an explicit allowlist of non-sensitive settings, never
- * free-form config content, paths, or credentials.
- */
-export interface ConfigSettingEventRecord {
-  /** Dotted config path, e.g. `"memory.enabled"`. */
-  configKey: string;
-  /** Effective value rendered as a string (`"true"` / `"false"` for booleans). */
-  configValue: string;
-}
-
-/**
- * Record a `config_setting` telemetry event, enqueued on the
- * `telemetry_events` outbox. Consent gating and degraded-mode behavior are
- * `recordTelemetryEvent`'s. Returns whether the event was persisted, so a
- * caller with its own dedupe memo (config-setting-snapshot.ts) only advances
- * the memo on a real write and keeps retrying while consent is off or the
- * telemetry DB is unavailable.
- */
-export function recordConfigSettingEvent(
-  record: ConfigSettingEventRecord,
-): boolean {
-  return (
-    recordTelemetryEvent("config_setting", {
-      config_key: record.configKey.slice(0, MAX_CONFIG_KEY_CHARS),
-      config_value: record.configValue.slice(0, MAX_CONFIG_VALUE_CHARS),
-    }) !== null
-  );
-}