@mycadet/assistant 0.12.9 → 0.12.10

package/src/calls/__tests__/call-controller.test.ts

@@ -23,7 +23,7 @@ mock.module(
 );
 
 // ── Config ──────────────────────────────────────────────────────────
-// These tests run against the real config loader. `loadConfig()` returns the
+// These tests run against the real config loader. `getConfig()` returns the
 // loader's live cached object, so tests set TTS/ingress fields by mutating it
 // in place; `beforeEach` restores the fields the tests touch. The workspace
 // config file itself is seeded once below (memory off, ingress base URL).
@@ -58,7 +58,7 @@ mock.module("../../config/cloud-speech-defaults.js", () => ({
   resolveEffectiveSpeechProviders: async (config?: {
     services: { stt: { provider: string }; tts: { provider: string } };
   }) => {
-    const services = (config ?? loadConfig()).services;
+    const services = (config ?? getConfig()).services;
     return { stt: services.stt.provider, tts: services.tts.provider };
   },
 }));
@@ -230,7 +230,7 @@ registerTestTtsProviders();
 import { resetDbForTesting } from "../../__tests__/db-test-helpers.js";
 import { createGuardianBinding } from "../../__tests__/helpers/create-guardian-binding.js";
 import { setConfig } from "../../__tests__/helpers/set-config.js";
-import { loadConfig } from "../../config/loader.js";
+import { getConfig } from "../../config/loader.js";
 import type {
   VoiceFrontModelConfig,
   VoiceProgressConfig,
@@ -432,7 +432,6 @@ function setupController(
 ) {
   ensureConversation("conv-ctrl-test");
   const session = createCallSession({
-    direction: "inbound",
     conversationId: "conv-ctrl-test",
     provider: "twilio",
     fromNumber: "+15551111111",
@@ -484,7 +483,6 @@ function setupControllerWithOrigin(task?: string) {
   ensureConversation("conv-ctrl-voice");
   ensureConversation("conv-ctrl-origin");
   const session = createCallSession({
-    direction: "inbound",
     conversationId: "conv-ctrl-voice",
     provider: "twilio",
     fromNumber: "+15551111111",
@@ -519,7 +517,7 @@ describe("call-controller", () => {
     mockEndCallListenWindowMs = 0;
     mockEndCallDrainMaxWaitMs = 15_000;
     // Reset TTS config to defaults so per-test mutations don't leak.
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "elevenlabs";
     cfg.services.tts.providers["fish-audio"].referenceId = "";
     cfg.ingress.publicBaseUrl = "https://generic.example.com";
@@ -2966,7 +2964,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: if synthesis fails before first chunk, falls back to text-token speech without sending play URL", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3016,7 +3014,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: a superseded run does not emit native fallback text", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3075,7 +3073,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: play URL uses public base URL", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.ingress.publicBaseUrl = "https://twilio.example.com/";
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
@@ -3119,7 +3117,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: stays 'processing' during synthesis latency until the play URL is sent", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3175,7 +3173,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: a superseded turn does not send a stale play URL", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3226,7 +3224,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: a turn error cancels the queued synthesis chain so no stale speech follows the recovery prompt", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3328,7 +3326,7 @@ describe("call-controller", () => {
   });
 
   test("Deepgram selected path resolves useSynthesizedPath to true", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "deepgram";
 
     const result = await resolveCallTtsProvider();
@@ -3338,7 +3336,7 @@ describe("call-controller", () => {
   });
 
   test("Deepgram synthesis failure does NOT fall back to native token TTS", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "deepgram";
 
     _resetTtsProviderOverridesForTests();
@@ -3386,7 +3384,7 @@ describe("call-controller", () => {
   });
 
   test("Fish Audio synthesis failure still falls back to native token TTS (unchanged behavior)", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-abc";
 
@@ -3439,7 +3437,7 @@ describe("call-controller", () => {
       onChunk: (chunk: Buffer) => void,
     ) => Promise<void>;
   }): { synthesizedTexts: string[] } {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -3548,7 +3546,7 @@ describe("call-controller", () => {
   function registerDeepgramRequestRecorder(): {
     requests: Array<{ voiceId?: string; language?: string }>;
   } {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "deepgram";
 
     _resetTtsProviderOverridesForTests();
@@ -3572,7 +3570,7 @@ describe("call-controller", () => {
   }
 
   test("synthesized provider: a configured languageVoices entry for the call language rides the request as voiceId", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.providers.deepgram.languageVoices = {
       hi: "aura-2-hindi-voice",
     };
@@ -3598,7 +3596,7 @@ describe("call-controller", () => {
   });
 
   test("synthesized provider: no voiceId when languageVoices has no entry for the call language", async () => {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.providers.deepgram.languageVoices = {
       hi: "aura-2-hindi-voice",
     };
@@ -3996,7 +3994,7 @@ describe("call-controller", () => {
     fishTexts: string[];
     fallbackTexts: string[];
   } {
-    const cfg = loadConfig();
+    const cfg = getConfig();
     cfg.services.tts.provider = "fish-audio";
     cfg.services.tts.providers["fish-audio"].referenceId = "fish-ref-123";
 
@@ -4186,7 +4184,7 @@ describe("call-controller", () => {
     test("returns fallback when the configured provider is not in the catalog", async () => {
       // The schema enum rejects unknown providers, so this state can only be
       // produced by mutating the loader's cached config directly.
-      const cfg = loadConfig();
+      const cfg = getConfig();
       (cfg.services.tts as { provider: string }).provider =
         "not-a-real-provider";
 
@@ -4197,7 +4195,7 @@ describe("call-controller", () => {
     });
 
     test("degrades fish-audio synthesized path when referenceId is missing", async () => {
-      const cfg = loadConfig();
+      const cfg = getConfig();
       cfg.services.tts.provider = "fish-audio";
       cfg.services.tts.providers["fish-audio"].referenceId = "";
 
@@ -4226,7 +4224,7 @@ describe("call-controller", () => {
     });
 
     test("returns synthesized path with deepgram provider", async () => {
-      const cfg = loadConfig();
+      const cfg = getConfig();
       cfg.services.tts.provider = "deepgram";
 
       const result = await resolveCallTtsProvider();
@@ -4239,7 +4237,7 @@ describe("call-controller", () => {
     test("Deepgram does not apply fish-audio referenceId gate", async () => {
       // Deepgram has no referenceId requirement. Verify the fish-audio
       // config gate does not apply to deepgram resolution.
-      const cfg = loadConfig();
+      const cfg = getConfig();
       cfg.services.tts.provider = "deepgram";
       // fish-audio referenceId left empty — should not affect deepgram.
       cfg.services.tts.providers["fish-audio"].referenceId = "";
@@ -5163,7 +5161,7 @@ describe("call-controller", () => {
     function endpointingConfig(
       overrides: Partial<VoiceFrontModelConfig> = {},
     ): VoiceFrontModelConfig {
-      return { ...loadConfig().voice.frontModel, ...overrides };
+      return { ...getConfig().voice.frontModel, ...overrides };
     }
 
     /**
@@ -5306,7 +5304,7 @@ describe("call-controller", () => {
       // A provider that has gone quiet past its commit window plus the
       // margin is gone, not slow, so the interim text is the only record of
       // what the caller said.
-      loadConfig().calls.voice.utteranceEndMs = 5;
+      getConfig().calls.voice.utteranceEndMs = 5;
       const { controller } = setupController(undefined, {
         frontModelConfig: endpointingConfig({ endpointExtensionMs: 20 }),
       });
@@ -5323,7 +5321,7 @@ describe("call-controller", () => {
 
     test("interim words re-arm the replay so it fires only once the caller stops", async () => {
       const { legs } = mockHoldingBridge();
-      loadConfig().calls.voice.utteranceEndMs = 5;
+      getConfig().calls.voice.utteranceEndMs = 5;
       const { controller } = setupController(undefined, {
         frontModelConfig: endpointingConfig({ endpointExtensionMs: 60 }),
       });

package/src/calls/active-call-lease.ts

@@ -9,8 +9,8 @@ import {
 } from "node:fs";
 import { dirname, join } from "node:path";
 
+import { getWorkspaceDir } from "../util/layout.js";
 import { getLogger } from "../util/logger.js";
-import { getWorkspaceDir } from "../util/platform.js";
 import { isTerminalState } from "./call-state-machine.js";
 import type { CallSession } from "./types.js";
 

package/src/calls/call-controller.ts

@@ -17,7 +17,7 @@ import {
   getRequestByPendingQuestionOrNull,
   listGuardianRequestDeliveriesOrEmpty,
 } from "../channels/gateway-guardian-requests.js";
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import type {
   VoiceFrontModelConfig,
   VoiceProgressConfig,
@@ -365,7 +365,7 @@ export class CallController {
       opts?.resolveSynthesisLanguage ??
       (() => resolveTelephonySynthesisLanguage());
     this.frontModelConfig =
-      opts?.frontModelConfig ?? loadConfig().voice.frontModel;
+      opts?.frontModelConfig ?? getConfig().voice.frontModel;
     this.progressConfig =
       opts?.progressConfig ?? this.frontModelConfig.progress;
     this.progressNarrator =
@@ -936,7 +936,7 @@ export class CallController {
     }
     return Math.max(
       extensionMs,
-      loadConfig().calls.voice.utteranceEndMs +
+      getConfig().calls.voice.utteranceEndMs +
         PROVIDER_FINAL_FALLBACK_MARGIN_MS,
     );
   }

package/src/calls/call-domain.ts

@@ -6,7 +6,7 @@
  */
 
 import { revokeScopedApprovalGrantsForContext } from "../approvals/scoped-approval-grants.js";
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import { VALID_CALLER_IDENTITY_MODES } from "../config/schema.js";
 import type { AssistantConfig } from "../config/types.js";
 import { resolveCallbackUrl } from "../inbound/cloud-callback-registration.js";
@@ -299,7 +299,6 @@ export async function createInboundVoiceSession(
   const session = createCallSession({
     conversationId: voiceConversationId,
     provider: "twilio",
-    direction: "inbound",
     fromNumber,
     toNumber,
   });
@@ -402,7 +401,7 @@ export async function startCall(
   let sessionId: string | null = null;
 
   try {
-    const config = loadConfig();
+    const config = getConfig();
 
     // Resolve which phone number to use as caller ID
     const identityResult = await resolveCallerIdentity(
@@ -439,7 +438,6 @@ export async function startCall(
     signal?.throwIfAborted();
 
     const session = createCallSession({
-      direction: "outbound",
       conversationId,
       provider: "twilio",
       fromNumber,
@@ -950,7 +948,7 @@ export async function startVerificationCall(
   let sessionId: string | null = null;
 
   try {
-    const config = loadConfig();
+    const config = getConfig();
     const provider = new TwilioVoiceProvider();
 
     // Resolve the assistant's Twilio number as the caller ID
@@ -978,7 +976,6 @@ export async function startVerificationCall(
     });
 
     const session = createCallSession({
-      direction: "outbound",
       conversationId,
       provider: "twilio",
       fromNumber: identityResult.fromNumber,
@@ -1083,7 +1080,7 @@ export async function startInviteCall(
   let sessionId: string | null = null;
 
   try {
-    const config = loadConfig();
+    const config = getConfig();
     const provider = new TwilioVoiceProvider();
 
     // Resolve the assistant's Twilio number as the caller ID
@@ -1112,7 +1109,6 @@ export async function startInviteCall(
     });
 
     const session = createCallSession({
-      direction: "outbound",
       conversationId,
       provider: "twilio",
       fromNumber: identityResult.fromNumber,

package/src/calls/call-store.ts

@@ -1,10 +1,6 @@
-import { and, desc, eq, like, notInArray, or } from "drizzle-orm";
+import { and, desc, eq, notInArray, or } from "drizzle-orm";
 import { v4 as uuid } from "uuid";
 
-import {
-  recordPhoneCallEnded,
-  recordPhoneCallStarted,
-} from "../onboarding/onboarding-events-store.js";
 import { getDb } from "../persistence/db-connection.js";
 import { rawChanges, rawRun } from "../persistence/raw-query.js";
 import {
@@ -12,16 +8,10 @@ import {
   callPendingQuestions,
   callSessions,
 } from "../persistence/schema/index.js";
-import {
-  type PhoneCallDirection,
-  phoneCallEndScreen,
-  phoneCallSilenceReason,
-  phoneCallStartScreen,
-} from "../telemetry/phone-call-funnel.js";
 import { getLogger } from "../util/logger.js";
 import { cast, createRowMapper } from "../util/row-mapper.js";
 import { syncActiveCallLeaseFromSession } from "./active-call-lease.js";
-import { isTerminalState, validateTransition } from "./call-state-machine.js";
+import { validateTransition } from "./call-state-machine.js";
 import type {
   CallEvent,
   CallEventType,
@@ -95,12 +85,6 @@ export function createCallSession(opts: {
   provider: string;
   fromNumber: string;
   toNumber: string;
-  /**
-   * Which way the call is being placed, for the funnel stamp. Stated rather
-   * than derived: a verification or invite call carries no task and is still
-   * outbound, so task presence is not a direction.
-   */
-  direction: PhoneCallDirection;
   task?: string;
   callMode?: string;
   verificationSessionId?: string;
@@ -138,14 +122,6 @@ export function createCallSession(opts: {
     updatedAt: now,
   };
   db.insert(callSessions).values(row).run();
-  // The call is attempted the moment its row exists, which is before the
-  // provider dials: a call that never connects is exactly the one the funnel
-  // needs to count. An outbound attempt the ingress preflight rejects never
-  // reaches here; see `telemetry/phone-call-funnel.ts`.
-  recordPhoneCallStarted({
-    callSessionId: row.id,
-    screen: phoneCallStartScreen(opts.direction, row.callMode),
-  });
   return { ...row, skipDisclosure };
 }
 
@@ -248,13 +224,6 @@ export function updateCallSession(
     .where(eq(callSessions.id, id))
     .run();
 
-  // Terminal states are immutable and the validator above rejects any write
-  // that follows one, so the first terminal transition to get here is the only
-  // one: the ended event needs no separate once-only latch.
-  if (updates.status && isTerminalState(updates.status)) {
-    recordCallEndedEvent(id, updates.status);
-  }
-
   opts?.beforeLeaseSync?.();
 
   if (shouldSyncActiveLease) {
@@ -269,35 +238,6 @@ export function updateCallSession(
   }
 }
 
-// ── Recovery queries ─────────────────────────────────────────────────
-
-/**
- * Whether the call's own event log holds an event of this type. Existence
- * only: the row itself is never read.
- */
-function hasCallEvent(
-  id: string,
-  eventType: CallEventType,
-  payloadContains?: string,
-): boolean {
-  const db = getDb();
-  const row = db
-    .select({ id: callEvents.id })
-    .from(callEvents)
-    .where(
-      and(
-        eq(callEvents.callSessionId, id),
-        eq(callEvents.eventType, eventType),
-        ...(payloadContains
-          ? [like(callEvents.payloadJson, `%${payloadContains}%`)]
-          : []),
-      ),
-    )
-    .limit(1)
-    .get();
-  return row !== undefined;
-}
-
 /**
  * Emit the call's funnel end event, classifying a call that never took a
  * caller turn by how far it got. Both signals come from the call's own event
@@ -310,20 +250,6 @@ function hasCallEvent(
  * an event type of its own would be the real fix, but that vocabulary is read
  * by other consumers and is not this change's to alter.
  */
-function recordCallEndedEvent(id: string, status: CallStatus): void {
-  const spoke = hasCallEvent(id, "caller_spoke", '"transcript"');
-  const silence = spoke
-    ? null
-    : phoneCallSilenceReason({
-        connected: hasCallEvent(id, "call_connected"),
-      });
-
-  recordPhoneCallEnded({
-    callSessionId: id,
-    screen: phoneCallEndScreen(status, silence),
-    outcome: status === "failed" ? "failed" : "completed",
-  });
-}
 
 /**
  * Returns all call sessions that are in a non-terminal state

package/src/calls/resolve-call-tts-provider.ts

@@ -8,7 +8,7 @@
  */
 
 import { resolveEffectiveSpeechProviders } from "../config/cloud-speech-defaults.js";
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import {
   getCatalogProvider,
   getTtsProvider,
@@ -101,7 +101,7 @@ export async function resolveCallTtsProvider(
   options?: ResolveCallTtsOptions,
 ): Promise<ResolvedCallTts> {
   try {
-    const config = loadConfig();
+    const config = getConfig();
     const effectiveProviderId = await effectiveTtsProviderId(config);
     const resolved = resolveTtsConfig(config, effectiveProviderId);
 
@@ -192,7 +192,7 @@ export async function resolveCallTtsProvider(
  * silent native path.
  */
 async function effectiveTtsProviderId(
-  config: ReturnType<typeof loadConfig>,
+  config: ReturnType<typeof getConfig>,
 ): Promise<TtsProviderId | undefined> {
   try {
     const { tts } = await resolveEffectiveSpeechProviders(config);

package/src/calls/twilio-config.ts

@@ -1,4 +1,4 @@
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
 import { ConfigError } from "../util/errors.js";
@@ -23,7 +23,7 @@ export interface TwilioConfig {
  */
 export function resolveTwilioPhoneNumber(): string {
   try {
-    const config = loadConfig();
+    const config = getConfig();
     if (config.twilio?.phoneNumber) {
       return config.twilio.phoneNumber;
     }
@@ -35,7 +35,7 @@ export function resolveTwilioPhoneNumber(): string {
 }
 
 export async function getTwilioConfig(): Promise<TwilioConfig> {
-  const accountSid = loadConfig().twilio?.accountSid || "";
+  const accountSid = getConfig().twilio?.accountSid || "";
   const authToken =
     (await getSecureKeyAsync(credentialKey("twilio", "auth_token"))) || "";
   const phoneNumber = resolveTwilioPhoneNumber();

package/src/calls/twilio-rest.ts

@@ -15,7 +15,7 @@ import {
   updatePhoneNumberWebhooks as updateTwilioPhoneNumberWebhooks,
 } from "@mycadet/twilio-client";
 
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
 import { ConfigError, ProviderError } from "../util/errors.js";
@@ -28,7 +28,7 @@ export interface TwilioCredentials {
 /** Resolve the Twilio Account SID from config. */
 function resolveAccountSid(): string | undefined {
   try {
-    const config = loadConfig();
+    const config = getConfig();
     return config.twilio?.accountSid || undefined;
   } catch {
     // Config may not be available during early startup

package/src/calls/voice-ingress-preflight.ts

@@ -1,5 +1,5 @@
 import { getIsCloud } from "../config/env-registry.js";
-import { loadConfig } from "../config/loader.js";
+import { getConfig } from "../config/loader.js";
 import type { AssistantConfig } from "../config/types.js";
 import { getPublicBaseUrl } from "../inbound/public-ingress-urls.js";
 import { resolveTelephonyCredentialReadiness } from "./telephony-credential-preflight.js";
@@ -31,7 +31,7 @@ function fail(error: string): VoiceIngressPreflightFailure {
 }
 
 export async function preflightVoiceIngress(): Promise<VoiceIngressPreflightResult> {
-  const ingressConfig = loadConfig();
+  const ingressConfig = getConfig();
 
   // The daemon performs both STT and TTS on the media-stream transport —
   // in every deployment mode, cloud-hosted included — so credential

package/src/cli/bundled-modules.ts

@@ -2,13 +2,11 @@ export interface BundledCliModules {
   configEnv: typeof import("../config/env.js");
   providerSecretCatalog: typeof import("../providers/provider-secret-catalog.js");
   pluginCatalogCache: typeof import("./lib/plugin-catalog-cache.js");
-  pluginCatalogLocal: typeof import("./lib/plugin-catalog-local.js");
   pluginDiff: typeof import("./lib/diff-plugin.js");
   pluginInspect: typeof import("./lib/inspect-plugin.js");
   pluginInstallGitHub: typeof import("./lib/install-from-github.js");
   pluginInstallPlatform: typeof import("./lib/install-from-cloud.js");
   pluginInstalled: typeof import("./lib/list-installed-plugins.js");
-  pluginPinHistory: typeof import("./lib/plugin-pin-history.js");
   pluginSearch: typeof import("./lib/search-plugins.js");
   pluginSurfaces: typeof import("./lib/plugin-surfaces.js");
   pluginUninstall: typeof import("./lib/uninstall-plugin.js");

package/src/cli/commands/__tests__/apps.test.ts

@@ -10,7 +10,7 @@ import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 import { mockIpc } from "../../../__tests__/requests-mock.js";
 import { createApp, getAppDirPath } from "../../../apps/app-store.js";
 import { writeAppSourceFingerprint } from "../../../apps/source-fingerprint.js";
-import { getWorkspacePluginsDir } from "../../../util/platform.js";
+import { getWorkspacePluginsDir } from "../../../util/layout.js";
 import { runCliCommand } from "./cli-test-harness.js";
 
 const ipc = await mockIpc("cli");

package/src/cli/commands/__tests__/plugins.test.ts

@@ -450,45 +450,21 @@ describe("plugins install - declared-schedules consent", () => {
     expect(r.exitCode).toBe(0);
   });
 
-  test("a bundled-catalog install (platform disabled) is gated too", async () => {
-    process.env.CADET_DISABLE_CLOUD = "true";
+  test("a name install absent from the catalog refuses before anything runs", async () => {
+    // A name needs the cloud catalog to resolve; an unclaimed name refuses
+    // before any install machinery runs.
     stageFixture = writeScheduleFixture;
     confirmResults = ["confirmed"];
 
     const r = await runCommand(["plugins", "install", "caveman"]);
 
     expect(platformInstallCalls.length).toBe(0);
-    expect(installPluginCalls.length).toBe(1);
-    expect(installPluginCalls[0]!.trustedSource).toBeDefined();
-    expect(confirmCalls.length).toBe(1);
-    expect(r.stdout).toContain('Plugin "caveman" declares 2 schedules:');
-    expect(r.exitCode).toBe(0);
-  });
-
-  test("a local catalog source bypasses the cloud installer", async () => {
-    catalogMatches = [
-      {
-        name: "fathom",
-        path: "local:plugins/mcp-catalog/fathom@1.0.0",
-        category: "productivity",
-        source: {
-          kind: "local",
-          path: "plugins/mcp-catalog/fathom",
-          version: "1.0.0",
-        },
-      },
-    ];
-
-    const r = await runCommand(["plugins", "install", "fathom"]);
-
-    expect(platformInstallCalls).toHaveLength(0);
-    expect(installPluginCalls).toHaveLength(1);
-    expect(installPluginCalls[0]?.trustedSource).toEqual({
-      kind: "local",
-      path: "plugins/mcp-catalog/fathom",
-      version: "1.0.0",
-    });
-    expect(r.exitCode).toBe(0);
+    expect(installPluginCalls.length).toBe(0);
+    expect(confirmCalls.length).toBe(0);
+    expect(r.stdout + r.stderr).toContain(
+      'Plugin "caveman" is not in the marketplace catalog.',
+    );
+    expect(r.exitCode).toBe(1);
   });
 
   test("falls back to the cloud installer when catalog discovery fails", async () => {
@@ -781,39 +757,6 @@ describe("plugins inspect - schedules surface", () => {
     expect(r.stdout).toContain("weekly  RRULE:FREQ=WEEKLY;BYDAY=MO  (execute)");
     expect(r.exitCode).toBe(0);
   });
-
-  test("renders a bundled package location without a GitHub URL", async () => {
-    inspectResult = {
-      ...inspectionWithSurfaces({
-        skills: [],
-        hooks: [],
-        tools: [],
-        schedules: [],
-      }),
-      installed: false,
-      status: "not-installed",
-      local: null,
-      remote: {
-        kind: "local",
-        repo: "",
-        path: "plugins/mcp-catalog/fathom",
-        commit: "1.0.0",
-        committedAt: null,
-        description: null,
-        homepage: null,
-        license: null,
-        category: "productivity",
-        marketplaceRef: "main",
-        version: "1.0.0",
-      },
-    };
-
-    const r = await runCommand(["plugins", "inspect", "fathom"]);
-
-    expect(r.stdout).toContain("bundled:plugins/mcp-catalog/fathom");
-    expect(r.stdout).not.toContain("https://github.com//");
-    expect(r.exitCode).toBe(0);
-  });
 });
 
 describe("plugins install - setup skill hint", () => {