@mycadet/assistant 0.12.7 → 0.12.9

package/src/notifications/__tests__/emit-signal-pipeline-failure.test.ts

@@ -29,13 +29,13 @@ mock.module("../../contacts/guardian-delivery-reader.js", () => ({
   guardianForChannel: () => undefined,
 }));
 
-mock.module("../../platform/client.js", () => ({
-  CadetPlatformClient: class {
+mock.module("../../cloud/client.js", () => ({
+  CadetCloudClient: class {
     static async create(): Promise<null> {
       return null;
     }
   },
-  isPlatformClientConfigured: async () => false,
+  isCloudClientConfigured: async () => false,
 }));
 
 mock.module("../broadcaster.js", () => ({
@@ -153,7 +153,7 @@ describe("emitNotificationSignal dedupe claim on failure", () => {
     );
   });
 
-  // "sent" is a completed channel delivery; "pending" is the platform push
+  // "sent" is a completed channel delivery; "pending" is the cloud push
   // that passed its outcome deadline and is still in flight. Both are
   // side effects a retry would repeat.
   for (const status of ["sent", "pending"] as const) {

package/src/notifications/activity-failed-dedupe.ts

@@ -2,7 +2,7 @@ import type { ConversationErrorCode } from "../api/events/conversation-error.js"
 import type { BackgroundJobErrorKind } from "../runtime/background-job-runner.js";
 
 /**
- * Failure codes whose cause is the whole workspace: the managed route and the
+ * Failure codes whose cause is the whole workspace: the cloud route and the
  * local machine exist once, so every job they hit shares one root cause and
  * one remedy, whatever provider or profile the job used. These collapse into
  * a single notification per cause per UTC day.

package/src/notifications/adapters/{platform.ts → cloud.ts}

@@ -2,18 +2,18 @@
  * Platform push adapter for native mobile notification delivery.
  *
  * POSTs a `notification_intent` payload to
- * `/v1/assistants/{id}/push/dispatch/`. The platform endpoint fans the
+ * `/v1/assistants/{id}/push/dispatch/`. The cloud endpoint fans the
  * notification out to registered device tokens for the bound user. Provider
  * feature gates return 202 with `{ skipped: "flag_off" }` when no provider runs.
  *
  * Guardian-sensitive notifications and completion previews include the
- * resolved guardian principal so the platform can scope native fan-out.
+ * resolved guardian principal so the cloud can scope native fan-out.
  * Explicitly owned background completions require that principal to match.
  * Ordinary replies and scheduled results retain platform-owner delivery
  * when the guardian lookup is unavailable.
  */
 
-import { CadetPlatformClient } from "../../platform/client.js";
+import { CadetCloudClient } from "../../cloud/client.js";
 import { getLogger } from "../../util/logger.js";
 import {
   isRetryableNetworkError,
@@ -67,7 +67,7 @@ const ATTEMPT_TIMEOUT_MS = 5_000;
  * The recovery is load-bearing rather than cosmetic. Copy composed entirely of
  * media embeds, which the pass-through path copies into both the title and the
  * body, flattens to nothing, and the pipeline's empty-copy guards all run
- * upstream of this adapter. The platform's serializer rejects a blank title,
+ * upstream of this adapter. The cloud's serializer rejects a blank title,
  * so an unrecovered field costs the whole notification, not just its wording.
  */
 function flattenAlertField(value: string): string {
@@ -110,7 +110,7 @@ function acceptedPlatforms(body: unknown): RemotePushPlatform[] | undefined {
   );
 }
 
-export class PlatformPushAdapter implements ChannelAdapter {
+export class CloudPushAdapter implements ChannelAdapter {
   readonly channel: NotificationChannel = "platform";
 
   async send(
@@ -121,7 +121,7 @@ export class PlatformPushAdapter implements ChannelAdapter {
     if (isCompletionRecipientUnavailable(payload, destination)) {
       return { success: false, error: "completion recipient unavailable" };
     }
-    const client = await CadetPlatformClient.create();
+    const client = await CadetCloudClient.create();
     if (!client) {
       log.warn(
         { sourceEventName: payload.sourceEventName },
@@ -130,7 +130,7 @@ export class PlatformPushAdapter implements ChannelAdapter {
       return { success: false, error: "platform client unavailable" };
     }
 
-    if (!client.platformAssistantId) {
+    if (!client.cloudAssistantId) {
       log.warn(
         { sourceEventName: payload.sourceEventName },
         "Platform assistant ID not configured — skipping push dispatch",
@@ -159,7 +159,7 @@ export class PlatformPushAdapter implements ChannelAdapter {
       target_guardian_principal_id: targetGuardianPrincipalId,
     };
 
-    const path = `/v1/assistants/${encodeURIComponent(client.platformAssistantId)}/push/dispatch/`;
+    const path = `/v1/assistants/${encodeURIComponent(client.cloudAssistantId)}/push/dispatch/`;
     const accumulatedPlatforms = new Set<RemotePushPlatform>();
     let platformsReported = false;
     const remotePushPlatforms = () =>

package/src/notifications/broadcaster.ts

@@ -285,7 +285,7 @@ export interface BroadcastDecisionOptions {
   resultsSink?: NotificationDeliveryResult[];
 }
 
-// Cap on how long the deferred cadet send waits for the platform dispatch
+// Cap on how long the deferred cadet send waits for the cloud dispatch
 // outcome: a duplicate banner beats a late one.
 const PLATFORM_OUTCOME_DEADLINE_MS = 2_500;
 
@@ -384,7 +384,7 @@ export class NotificationBroadcaster {
     // event fires immediately, before slower channel sends (e.g. Telegram 30s
     // timeout) can delay it. Platform sorts second: the cadet intent carries
     // remotePushDispatched, so its deferred send (below) flushes right after
-    // the platform outcome is known instead of waiting behind slower channels.
+    // the cloud outcome is known instead of waiting behind slower channels.
     const dispatchRank = (channel: NotificationChannel): number => {
       if (channel === "cadet") {
         return 0;
@@ -413,7 +413,7 @@ export class NotificationBroadcaster {
         : undefined;
     const results: NotificationDeliveryResult[] = options?.resultsSink ?? [];
 
-    // Cadet pairing carried forward for the platform channel's deep link.
+    // Cadet pairing carried forward for the cloud channel's deep link.
     // A single-pass carry is safe because orderedChannels sorts cadet first.
     let cadetPairing: {
       conversationId: string;
@@ -424,9 +424,9 @@ export class NotificationBroadcaster {
     // platform dispatch outcome, not channel selection: when both channels
     // are selected, the cadet channel is still prepared first (pairing, the
     // conversation-created emission, and the pending delivery row all run
-    // eagerly, so the platform deep link keeps the cadet pairing carry), but
-    // its adapter send is deferred until the platform adapter reports whether
-    // the platform accepted a device push. Typical cost: one fast HTTP
+    // eagerly, so the cloud deep link keeps the cadet pairing carry), but
+    // its adapter send is deferred until the cloud adapter reports whether
+    // the cloud accepted a device push. Typical cost: one fast HTTP
     // round-trip before the local banner goes out, capped at
     // PLATFORM_OUTCOME_DEADLINE_MS.
     let deferredCadetSend: PendingChannelDispatch | null = null;
@@ -446,7 +446,7 @@ export class NotificationBroadcaster {
     try {
       for (const channel of orderedChannels) {
         // Platform sorts immediately after cadet, so reaching any later
-        // channel means the platform outcome is settled (or the platform
+        // channel means the cloud outcome is settled (or the cloud
         // channel was skipped): flush the deferred cadet send now so the
         // local banner is not held behind slower sends. On the cadet
         // iteration itself this is a no-op -- cadet appears at most once in
@@ -592,7 +592,7 @@ export class NotificationBroadcaster {
           );
           if (existingDelivery) {
             // On retry paths the cadet row already exists, so the fresh-pairing
-            // carry below never runs -- seed the platform deep-link carry from
+            // carry below never runs -- seed the cloud deep-link carry from
             // the duplicate row's conversation instead.
             if (channel === "cadet" && existingDelivery.conversationId) {
               cadetPairing = {
@@ -838,14 +838,14 @@ export class NotificationBroadcaster {
 
         if (channel === "cadet" && orderedChannels.includes("platform")) {
           // The cadet intent carries remotePushDispatched, so its send waits
-          // for the platform outcome; everything else (pairing, events, the
+          // for the cloud outcome; everything else (pairing, events, the
           // pending delivery row) already ran above.
           deferredCadetSend = dispatch;
           continue;
         }
 
         if (channel === "platform" && deferredCadetSend) {
-          // The local banner is urgent: wait for the platform outcome only up
+          // The local banner is urgent: wait for the cloud outcome only up
           // to the deadline (a duplicate banner beats a late one). On expiry
           // the cadet send flushes with remotePushDispatched=false while the
           // dispatch keeps running, recording its delivery row when it

package/src/notifications/decision-engine.ts

@@ -244,7 +244,7 @@ const TITLE_FIELD_DESCRIPTION = [
   "- No quotes, no markdown, no trailing punctuation",
   "- Never describe missing or thin context. Titles like 'Notification', 'Update', 'Activity complete', 'Missing context' are forbidden. Say what was done from the words that ARE present",
   "Examples:",
-  "- Body 'Your 9am standup with the platform team starts in 5 minutes' -> 'Platform standup in 5 minutes', NOT 'Platform Standup'",
+  "- Body 'Your 9am standup with the platform team starts in 5 minutes' -> 'Cloud standup in 5 minutes', NOT 'Cloud Standup'",
   "- Body 'The nightly backup job failed on db-primary at 02:14' -> 'Nightly backup failed', NOT 'Nightly Backup Failure'",
   "- Body 'Alice replied about the Q3 pricing deck and wants your notes' -> 'Alice wants notes on the Q3 deck', NOT 'Q3 Pricing Deck'",
   "- Body 'Recapped the 12 emails that needed a reply and deleted 6 newsletters' -> 'Recapped 12 emails, deleted 6', NOT 'Inbox Recap'",

package/src/notifications/destination-resolver.ts

@@ -193,7 +193,7 @@ export function resolveDestinations(
         break;
       }
       case "platform": {
-        // Platform delivery goes through the daemon's CadetPlatformClient —
+        // Platform delivery goes through the daemon's CadetCloudClient —
         // no external binding needed. Include guardianPrincipalId so the
         // adapter can scope guardian-sensitive notifications.
         const platformGuardian = resolveGuardian(guardians, "cadet");

package/src/notifications/emit-signal.ts

@@ -13,18 +13,18 @@ import type { GuardianDelivery } from "@mycadet/gateway-client";
 import { v4 as uuid } from "uuid";
 
 import { getDeliverableChannels } from "../channels/config.js";
+import { isCloudClientConfigured } from "../cloud/client.js";
 import {
   getGuardianDelivery,
   guardianForChannel,
 } from "../contacts/guardian-delivery-reader.js";
 import type { ConversationCreateType } from "../persistence/conversation-types.js";
-import { isPlatformClientConfigured } from "../platform/client.js";
 import { broadcastMessage } from "../runtime/assistant-event-hub.js";
 import { getLogger } from "../util/logger.js";
 import { withSqliteRetry } from "../util/sqlite-retry.js";
+import { CloudPushAdapter } from "./adapters/cloud.js";
 import { DiscordAdapter } from "./adapters/discord.js";
 import { CadetAdapter } from "./adapters/macos.js";
-import { PlatformPushAdapter } from "./adapters/platform.js";
 import { SlackAdapter } from "./adapters/slack.js";
 import { TelegramAdapter } from "./adapters/telegram.js";
 import { resolveAssistantInitiatedThread } from "./assistant-initiated-thread.js";
@@ -72,7 +72,7 @@ export function getBroadcaster(): NotificationBroadcaster {
       new TelegramAdapter(),
       new SlackAdapter(),
       new DiscordAdapter(),
-      new PlatformPushAdapter(),
+      new CloudPushAdapter(),
     ]);
 
     // Wire the conversation-created callback so the event goes out as soon
@@ -142,7 +142,7 @@ export async function getConnectedChannels(): Promise<NotificationChannel[]> {
       case "platform":
         // Platform push is treated as connected at the decision-engine
         // layer; the actual delivery path lazily resolves
-        // `CadetPlatformClient.create()` in `PlatformPushAdapter.send()`
+        // `CadetCloudClient.create()` in `CloudPushAdapter.send()`
         // and reports a delivery failure when credentials are absent.
         channels.push(channel);
         break;
@@ -316,7 +316,7 @@ function emitOutcome(
 
 /**
  * True when at least one channel adapter has already been handed the signal.
- * `sent` is a completed delivery; `pending` is the platform push that passed
+ * `sent` is a completed delivery; `pending` is the cloud push that passed
  * its outcome deadline and is still in flight. Both mean a retry would
  * re-deliver.
  */
@@ -449,7 +449,7 @@ export async function emitNotificationSignal<TEventName extends string>(
     const prePolicyDecision = decision;
     let platformConfigured: Promise<boolean> | undefined;
     const platformIsConfigured = () =>
-      (platformConfigured ??= isPlatformClientConfigured());
+      (platformConfigured ??= isCloudClientConfigured());
 
     // Step 2.5a: High/critical urgency signals always get both the in-app
     // system notification (cadet) and the remote push (platform),

package/src/notifications/types.ts

@@ -69,7 +69,7 @@ export const DeliveryResultSchema = z.object({
   skipped: z.boolean().optional(),
   error: z.string().optional(),
   messageId: z.string().optional(),
-  /** Set only by the platform push adapter: true when the platform accepted
+  /** Set only by the cloud push adapter: true when the cloud accepted
    *  at least one device push for delivery (not proof of device receipt). */
   remotePushAccepted: z.boolean().optional(),
   remotePushPlatforms: z.array(z.enum(["ios", "android"])).optional(),
@@ -124,7 +124,7 @@ export const ChannelDeliveryPayloadSchema = z.object({
    *  broadcaster so channel adapters render it without re-parsing
    *  `contextPayload`. */
   toolApprovalSource: ToolApprovalSourceViewSchema.optional(),
-  /** True when the platform (APNs) channel accepted a remote push for this
+  /** True when the cloud (APNs) channel accepted a remote push for this
    *  delivery. Set only on the cadet channel's payload so clients can avoid
    *  double-bannering. */
   remotePushDispatched: z.boolean().optional(),

package/src/oauth/__tests__/identity-verifier.test.ts

@@ -50,7 +50,7 @@ function makeProviderRow(
     pingBody: null,
     revokeUrl: null,
     revokeBodyTemplate: null,
-    managedServiceConfigKey: null,
+    cloudServiceConfigKey: null,
     managedServiceIsPaid: false,
     displayLabel: null,
     description: null,

package/src/oauth/__tests__/{seed-providers-managed.test.ts → seed-providers-cloud.test.ts}

@@ -7,7 +7,7 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
   test("github provider is wired up for managed mode", () => {
     const github = PROVIDER_SEED_DATA.github;
     expect(github).toBeDefined();
-    expect(github.managedServiceConfigKey).toBe("github-oauth");
+    expect(github.cloudServiceConfigKey).toBe("github-oauth");
     expect("github-oauth" in ServicesSchema.shape).toBe(true);
   });
 
@@ -32,7 +32,7 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
   test("figma requests only scopes an app on any plan can grant", () => {
     const figma = PROVIDER_SEED_DATA.figma;
     expect(figma).toBeDefined();
-    expect(figma.managedServiceConfigKey).toBe("figma-oauth");
+    expect(figma.cloudServiceConfigKey).toBe("figma-oauth");
     expect("figma-oauth" in ServicesSchema.shape).toBe(true);
 
     // Figma rejects the whole authorization request when the app cannot grant
@@ -114,12 +114,12 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
 
   test("Link does not ship a Stripe publishable key to BYO installs", () => {
     // Link's authorize endpoint needs a `key` param naming the Stripe account
-    // behind the client_id. Cadet's belongs only in the platform registry,
-    // where it pairs with the platform's own client. Seeding it here would
+    // behind the client_id. Cadet's belongs only in the cloud registry,
+    // where it pairs with the cloud's own client. Seeding it here would
     // send our merchant identity from every self-hosted install.
     const link = PROVIDER_SEED_DATA.stripe_link;
     expect(link).toBeDefined();
-    expect(link.managedServiceConfigKey).toBe("stripe-link-oauth");
+    expect(link.cloudServiceConfigKey).toBe("stripe-link-oauth");
     expect(link.authorizeParams).toBeUndefined();
     expect(JSON.stringify(link)).not.toContain("pk_live_");
   });
@@ -151,7 +151,7 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
     // Shopify has no global OAuth host: every endpoint lives on the
     // merchant's own domain. Hardcoding any host here would send every
     // merchant's authorization to the wrong store, so the {tenant_host}
-    // placeholder the platform substitutes must survive.
+    // placeholder the cloud substitutes must survive.
     const shopify = PROVIDER_SEED_DATA.shopify;
     expect(shopify).toBeDefined();
     for (const url of [
@@ -204,9 +204,9 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
   test("quickbooks is wired up for managed mode behind its flag", () => {
     const quickbooks = PROVIDER_SEED_DATA.quickbooks;
     expect(quickbooks).toBeDefined();
-    expect(quickbooks.managedServiceConfigKey).toBe("quickbooks-oauth");
+    expect(quickbooks.cloudServiceConfigKey).toBe("quickbooks-oauth");
     expect("quickbooks-oauth" in ServicesSchema.shape).toBe(true);
-    // Hidden until the platform side and client ids are live, like Figma
+    // Hidden until the cloud side and client ids are live, like Figma
     // and Shopify.
     expect(quickbooks.featureFlag).toBe("quickbooks-oauth");
   });
@@ -225,7 +225,7 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
 
   test("quickbooks keeps its per-company URL templates", () => {
     // Every Accounting API path is scoped to the realm the user picked on
-    // Intuit's consent screen. The platform fills {realm_id} from the
+    // Intuit's consent screen. The cloud fills {realm_id} from the
     // connection; a hardcoded realm here would send every company's calls
     // to the wrong books.
     const quickbooks = PROVIDER_SEED_DATA.quickbooks;
@@ -276,13 +276,13 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
     }
   });
 
-  test("every managedServiceConfigKey resolves to a ServicesSchema key", () => {
-    // Cross-repo invariant: a provider with managedServiceConfigKey but no
+  test("every cloudServiceConfigKey resolves to a ServicesSchema key", () => {
+    // Cross-repo invariant: a provider with cloudServiceConfigKey but no
     // matching ServicesSchema entry silently falls back to BYO mode in
     // connection-resolver.ts. This test guards against that drift.
     const offenders: Array<{ provider: string; key: string }> = [];
     for (const [provider, seed] of Object.entries(PROVIDER_SEED_DATA)) {
-      const key = seed.managedServiceConfigKey;
+      const key = seed.cloudServiceConfigKey;
       if (key && !(key in ServicesSchema.shape)) {
         offenders.push({ provider, key });
       }
@@ -290,7 +290,7 @@ describe("PROVIDER_SEED_DATA managed mode wiring", () => {
     expect(offenders).toEqual([]);
   });
 
-  test("github managed service schema defaults to your-own", () => {
+  test("github cloud service schema defaults to your-own", () => {
     const parsed = ServicesSchema.shape["github-oauth"].parse({});
     expect(parsed.mode).toBe("your-own");
   });

package/src/oauth/byo-connection.test.ts

@@ -89,7 +89,7 @@ const mockProviders = new Map<
     tokenEndpointAuthMethod?: string;
     tokenExchangeBodyFormat?: string;
     baseUrl?: string;
-    managedServiceConfigKey?: string | null;
+    cloudServiceConfigKey?: string | null;
   }
 >();
 
@@ -225,7 +225,7 @@ async function setupCredential(
       service === "google"
         ? "https://gmail.googleapis.com/gmail/v1/users/me"
         : undefined,
-    managedServiceConfigKey: null,
+    cloudServiceConfigKey: null,
   });
   mockApps.set(appId, {
     id: appId,