@mycadet/assistant 0.12.7 → 0.12.9

package/src/__tests__/tool-audit.test.ts

@@ -4,7 +4,7 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 // columns: only a confirmed `false` NULLs them.
 let shareAnalytics: boolean | "unknown" = true;
 
-mock.module("../platform/consent-cache.js", () => ({
+mock.module("../cloud/consent-cache.js", () => ({
   getRawShareAnalytics: () => shareAnalytics,
 }));
 

package/src/__tests__/tool-execution-pipeline.benchmark.test.ts

@@ -16,8 +16,9 @@
  * - ToolExecutor overhead < 20ms regardless of tool execution time
  */
 
-import { beforeAll, describe, expect, mock, test } from "bun:test";
+import { beforeAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
+import { setAllFlagsOffForTesting } from "../__tests__/feature-flag-test-helpers.js";
 import { installThresholdReaderMock } from "./gateway-threshold-reader-mock.js";
 
 // Local registry for ToolExecutor tests — the mock delegates to this map
@@ -38,10 +39,6 @@ mock.module("../tools/registry.js", () => ({
   },
 }));
 
-mock.module("../config/assistant-feature-flags.js", () => ({
-  isAssistantFeatureFlagEnabled: () => false,
-}));
-
 mock.module("../config/env-registry.js", () => ({
   getIsContainerized: () => false,
 }));
@@ -103,6 +100,11 @@ import { scanText } from "../security/secret-scanner.js";
 import { ToolExecutor } from "../tools/executor.js";
 import type { Tool, ToolContext, ToolExecutionResult } from "../tools/types.js";
 
+beforeEach(() => {
+  // Real flag resolution replaces the former blanket module mock.
+  setAllFlagsOffForTesting();
+});
+
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------

package/src/__tests__/tool-executor-lifecycle-events.test.ts

@@ -103,7 +103,7 @@ mock.module("../telemetry/tool-audit.js", () => ({
 
 // Analytics consent is granted so any consent-gated telemetry path the audit
 // terminals consult sees the opted-in state.
-mock.module("../platform/consent-cache.js", () => ({
+mock.module("../cloud/consent-cache.js", () => ({
   getRawShareAnalytics: () => true,
 }));
 

package/src/__tests__/turn-events-store.test.ts

@@ -315,7 +315,7 @@ describe("queryUnreportedTurnEvents", () => {
     const byId = Object.fromEntries(events.map((e) => [e.id, e]));
 
     // sqlite's json_extract yields 1/0 for JSON booleans, so these must come
-    // back as real booleans. A raw 1 would be rejected by the platform's
+    // back as real booleans. A raw 1 would be rejected by the cloud's
     // BooleanField and the event silently dropped at ingest.
     expect(byId[scripted.id].scripted).toBe(true);
     expect(byId[typed.id].scripted).toBe(false);

package/src/__tests__/twilio-routes.test.ts

@@ -255,7 +255,7 @@ mock.module("../daemon/handlers/config-channels.js", () => ({
   }),
 }));
 
-mock.module("../inbound/platform-callback-registration.js", () => ({
+mock.module("../inbound/cloud-callback-registration.js", () => ({
   registerCallbackRoute: async () => {},
   resolveCallbackUrl: async (resolver: () => string | Promise<string>) =>
     await resolver(),
@@ -1376,6 +1376,7 @@ describe("twilio webhook routes", () => {
       expect(result.hasCredentials).toBe(true);
       expect((loadRawConfig() as Record<string, unknown>).twilio).toEqual({
         accountSid: "AC_new_credentials",
+        phoneNumber: "",
         setupStarted: true,
       });
     });

package/src/__tests__/ui-choice-copy-surfaces.test.ts

@@ -56,7 +56,7 @@ describe("choice and copy_block surface definitions", () => {
     expect(getSurfaceTypeEnum()).toContain("oauth_connect");
     expect(uiShowTool.description).toContain("recommended");
     expect(uiShowTool.description).toContain("visible copy button");
-    expect(uiShowTool.description).toContain("managed OAuth");
+    expect(uiShowTool.description).toContain("cloud OAuth");
   });
 
   test("choice and oauth_connect are interactive but copy_block is display-only", () => {

package/src/__tests__/unified-turn-context-client-os.test.ts

@@ -3,7 +3,7 @@
  *
  * `interface` is the transport surface (always "web" for the web/iOS/macOS
  * apps, which share one renderer); `client_os` is the real OS, carried
- * separately so the model knows the platform without the OS perturbing
+ * separately so the model knows the cloud without the OS perturbing
  * transport/host-proxy capability inference. These pin that both lines render
  * independently and that `client_os` is omitted when absent.
  */

package/src/__tests__/validate-input.test.ts

@@ -638,7 +638,7 @@ describe("coerceArrayShapes", () => {
       const result = coerceArrayShapes(input, schema);
       expect(result).toBe(input);
       const validation = validateInputAgainstSchema(
-        "scaffold_managed_skill",
+        "scaffold_cloud_skill",
         result,
         schema,
       );
@@ -656,7 +656,7 @@ describe("coerceArrayShapes", () => {
       schema,
     );
     expect(
-      validateInputAgainstSchema("scaffold_managed_skill", coerced, schema),
+      validateInputAgainstSchema("scaffold_cloud_skill", coerced, schema),
     ).toEqual({ ok: true });
     expect(coerced.activation_hints).toEqual(["user asks to deploy staging"]);
   });
@@ -694,7 +694,7 @@ describe("coerceArrayShapes", () => {
       schema,
     );
     const validation = validateInputAgainstSchema(
-      "scaffold_managed_skill",
+      "scaffold_cloud_skill",
       coerced,
       schema,
     );
@@ -747,7 +747,7 @@ describe("validateInputAgainstSchema: array shape error message", () => {
 
   test("points at the JSON array form when a string is passed", () => {
     const result = validateInputAgainstSchema(
-      "scaffold_managed_skill",
+      "scaffold_cloud_skill",
       { activation_hints: "[deploy staging" },
       schema,
     );
@@ -762,7 +762,7 @@ describe("validateInputAgainstSchema: array shape error message", () => {
 
   test("names an object when an object is passed", () => {
     const result = validateInputAgainstSchema(
-      "scaffold_managed_skill",
+      "scaffold_cloud_skill",
       { activation_hints: { first: "deploy staging" } },
       schema,
     );

package/src/__tests__/verification-outbound-delivery.test.ts

@@ -84,7 +84,7 @@ const { startOutbound, resendOutbound } =
 /**
  * A destination shaped the way each channel's own addresses are.
  *
- * Email is absent: its transport goes through the platform client, which is a
+ * Email is absent: its transport goes through the cloud client, which is a
  * heavier boundary than this file's concern. It reaches delivery through the
  * same shared path as the two spec-driven channels here, so that path is
  * covered.

package/src/__tests__/voice-config-update.test.ts

@@ -2,13 +2,13 @@ import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 
-import * as actualManagedSpeech from "../platform/managed-speech.js";
+import * as actualCloudSpeech from "../cloud/cloud-speech.js";
 
-let mockManagedSpeechAvailable = false;
+let mockCloudSpeechAvailable = false;
 
-mock.module("../platform/managed-speech.js", () => ({
-  ...actualManagedSpeech,
-  managedSpeechAvailable: async () => mockManagedSpeechAvailable,
+mock.module("../cloud/cloud-speech.js", () => ({
+  ...actualCloudSpeech,
+  managedSpeechAvailable: async () => mockCloudSpeechAvailable,
 }));
 
 // ---------------------------------------------------------------------------
@@ -71,7 +71,7 @@ beforeEach(() => {
   ensureTestDir();
   writeConfig({});
   invalidateConfigCache();
-  mockManagedSpeechAvailable = false;
+  mockCloudSpeechAvailable = false;
 });
 
 afterEach(() => {
@@ -145,7 +145,7 @@ describe("voice_config_update — tts_provider", () => {
   });
 
   test("tts_provider cadet persists when a cloud connection is available", async () => {
-    mockManagedSpeechAvailable = true;
+    mockCloudSpeechAvailable = true;
 
     const result = await run(
       { setting: "tts_provider", value: "cadet" },
@@ -245,7 +245,7 @@ describe("voice_config_update — tts_voice_id (managed/cadet active)", () => {
     ).toBeUndefined();
   });
 
-  test("accepts an ElevenLabs voice id as a managed model (managed serves ElevenLabs voices)", async () => {
+  test("accepts an ElevenLabs voice id as a cloud model (managed serves ElevenLabs voices)", async () => {
     makeCadetActive();
 
     const result = await run(
@@ -259,7 +259,7 @@ describe("voice_config_update — tts_voice_id (managed/cadet active)", () => {
     );
   });
 
-  test("does not broadcast the ElevenLabs ttsVoiceId key for a managed voice", async () => {
+  test("does not broadcast the ElevenLabs ttsVoiceId key for a cloud voice", async () => {
     makeCadetActive();
     const messages: any[] = [];
     const ctx = makeContext({
@@ -276,7 +276,7 @@ describe("voice_config_update — tts_voice_id (managed/cadet active)", () => {
     expect(result.content).not.toContain("broadcast");
   });
 
-  test("hints the inline picker for the next managed voice change", async () => {
+  test("hints the inline picker for the next cloud voice change", async () => {
     makeCadetActive();
 
     const result = await run(
@@ -285,7 +285,7 @@ describe("voice_config_update — tts_voice_id (managed/cadet active)", () => {
     );
 
     expect(result.isError).toBe(false);
-    expect(result.content).toStartWith("Cadet managed voice updated to");
+    expect(result.content).toStartWith("Cadet Cloud voice updated to");
     expect(result.content).toContain(
       'ui_show { surface_type: "voice_picker", data: {} }',
     );
@@ -537,7 +537,7 @@ describe("voice_config_update — stt_provider", () => {
   });
 
   test("persists the cadet provider when a cloud connection is available", async () => {
-    mockManagedSpeechAvailable = true;
+    mockCloudSpeechAvailable = true;
 
     const result = await run(
       { setting: "stt_provider", value: "cadet" },
@@ -549,7 +549,7 @@ describe("voice_config_update — stt_provider", () => {
   });
 
   test("rejects the cadet provider without a cloud connection", async () => {
-    mockManagedSpeechAvailable = false;
+    mockCloudSpeechAvailable = false;
 
     const result = await run(
       { setting: "stt_provider", value: "cadet" },
@@ -917,7 +917,7 @@ describe("voice_config_update - stt_language", () => {
 
 describe("voice_config_update — catalog-driven provider validation", () => {
   test("rejects tts_provider cadet without a cloud connection", async () => {
-    mockManagedSpeechAvailable = false;
+    mockCloudSpeechAvailable = false;
 
     const result = await run(
       { setting: "tts_provider", value: "cadet" },
@@ -931,7 +931,7 @@ describe("voice_config_update — catalog-driven provider validation", () => {
 
   test("accepts every provider ID in the catalog", async () => {
     // The catalog includes cadet, which is gated on a cloud connection.
-    mockManagedSpeechAvailable = true;
+    mockCloudSpeechAvailable = true;
     const catalogIds = listCatalogProviderIds();
     expect(catalogIds.length).toBeGreaterThanOrEqual(1);
 

package/src/__tests__/voice-ingress-preflight.test.ts

@@ -8,10 +8,10 @@ let mockCredentialReadiness: Record<string, unknown>;
 let credentialReadinessCalls = 0;
 
 // Spread the real env-registry so the config loader's transitive
-// `util/platform` imports still resolve; only getIsPlatform is driven per test.
+// `util/platform` imports still resolve; only getIsCloud is driven per test.
 mock.module("../config/env-registry.js", () => ({
   ...realEnvRegistry,
-  getIsPlatform: () => mockGetIsPlatform(),
+  getIsCloud: () => mockGetIsPlatform(),
 }));
 
 mock.module("../calls/telephony-credential-preflight.js", () => ({
@@ -90,7 +90,7 @@ describe("voice ingress preflight", () => {
   });
 
   test("credential readiness gates platform-callback deployments too", async () => {
-    // The platform short-circuit covers only the ingress-URL half — the
+    // The cloud short-circuit covers only the ingress-URL half — the
     // daemon still performs STT/TTS on platform deployments.
     mockGetIsPlatform = () => true;
     setConfig("ingress", { enabled: false });
@@ -104,7 +104,7 @@ describe("voice ingress preflight", () => {
     }
   });
 
-  test("runs the credential readiness check on the platform success path", async () => {
+  test("runs the credential readiness check on the cloud success path", async () => {
     mockGetIsPlatform = () => true;
     setConfig("ingress", { enabled: false });