@multiplatform.one/config 7.4.0 → 7.5.0

package/src/vitest.ts

@@ -1,8 +1,61 @@
+import fs from "node:fs";
+import Module from "node:module";
 import path from "node:path";
+import { fileURLToPath } from "node:url";
 import { tamaguiPlugin } from "@tamagui/vite-plugin";
 import react from "@vitejs/plugin-react";
 import type { UserConfig } from "vite";
 
+const pinReactRequireSetup = path.resolve(
+  path.dirname(fileURLToPath(import.meta.url)),
+  "../pin-react-require.cjs",
+);
+
+/**
+ * CJS `require('react')` does not go through Vite aliases. `use-sync-external-store`
+ * is a valid Node import, so Vitest leaves it external even when we ask to inline
+ * it, and Node then loads the hoisted root copy — a different inode than the
+ * `.pnpm` copy Vite binds. Patching Module._resolveFilename in the vitest
+ * process (config eval + workers that re-load this factory) makes that
+ * require land on the same physical copy as the aliases.
+ */
+function pinNodeReactRequire(reactDir: string, reactDomDir: string, schedulerDir: string): void {
+  const ctor = Module as typeof Module & {
+    _resolveFilename: (
+      request: string,
+      parent: unknown,
+      isMain: boolean,
+      options?: unknown,
+    ) => string;
+    _mpoOneReact?: boolean;
+  };
+  if (ctor._mpoOneReact) return;
+  ctor._mpoOneReact = true;
+  const orig = ctor._resolveFilename;
+  ctor._resolveFilename = function pinned(request, parent, isMain, options) {
+    const next =
+      request === "react"
+        ? reactDir
+        : request.startsWith("react/")
+          ? path.join(reactDir, request.slice("react/".length))
+          : request === "react-dom"
+            ? reactDomDir
+            : request.startsWith("react-dom/")
+              ? path.join(reactDomDir, request.slice("react-dom/".length))
+              : request === "scheduler"
+                ? schedulerDir
+                : null;
+    if (next) {
+      try {
+        return orig.call(this, next, parent, isMain, options);
+      } catch {
+        // package layout didn't match — keep Node's original lookup
+      }
+    }
+    return orig.call(this, request, parent, isMain, options);
+  };
+}
+
 export interface CreateVitestConfigOptions {
   /**
    * Path to the Tamagui config file for test environments.
@@ -168,22 +221,54 @@ export function createVitestConfig(options: CreateVitestConfigOptions = {}): Use
     resolveAliases["react-native-svg"] = "@tamagui/react-native-svg";
   }
   if (dedupeReact) {
-    resolveAliases.react = path.resolve(rootNodeModules, "react");
-    resolveAliases["react-dom"] = path.resolve(rootNodeModules, "react-dom");
-    resolveAliases["react-dom/client"] = path.resolve(rootNodeModules, "react-dom/client");
-    resolveAliases["react-dom/server"] = path.resolve(rootNodeModules, "react-dom/server");
-    resolveAliases["react/jsx-runtime"] = path.resolve(rootNodeModules, "react/jsx-runtime");
-    resolveAliases["react/jsx-dev-runtime"] = path.resolve(
-      rootNodeModules,
-      "react/jsx-dev-runtime",
-    );
-    resolveAliases.scheduler = path.resolve(rootNodeModules, "scheduler");
+    // MPO-37. `.npmrc` sets `node-linker=hoisted`, so the workspace ROOT gets
+    // a real `node_modules/react` directory while each package's own
+    // `node_modules/react` is a symlink into `.pnpm/react@<v>/...`. Those are
+    // two PHYSICALLY distinct copies of the same version, and Vite resolves
+    // symlinks to their real path — so aliasing at the root while a dependency
+    // (say @tanstack/react-query, whose source Vite transforms) resolves
+    // through the package symlink puts two Reacts in one module graph.
+    //
+    // react-dom then installs its dispatcher into one copy while the component
+    // tree reads the other, and every render dies on
+    // `Cannot read properties of null (reading 'useEffect')` — the whole
+    // components render suite, and the render half of forms.
+    //
+    // So resolve each package to ONE physical copy, preferring the one the
+    // package under test actually resolves. react and react-dom live in
+    // DIFFERENT `.pnpm` directories (`react@19.2.5` and
+    // `react-dom@19.2.5_react@19.2.5`), so this is per-package: a shared
+    // parent directory does not exist and assuming one loses react-dom.
+    const onePhysicalCopy = (pkg: string): string => {
+      for (const base of [path.resolve(process.cwd(), "node_modules"), rootNodeModules]) {
+        try {
+          return fs.realpathSync(path.resolve(base, pkg));
+        } catch {
+          // not installed at this level — fall through to the next base
+        }
+      }
+      return path.resolve(rootNodeModules, pkg);
+    };
+    const reactDir = onePhysicalCopy("react");
+    const reactDomDir = onePhysicalCopy("react-dom");
+    resolveAliases.react = reactDir;
+    resolveAliases["react-dom"] = reactDomDir;
+    resolveAliases["react-dom/client"] = path.join(reactDomDir, "client");
+    resolveAliases["react-dom/server"] = path.join(reactDomDir, "server");
+    resolveAliases["react/jsx-runtime"] = path.join(reactDir, "jsx-runtime");
+    resolveAliases["react/jsx-dev-runtime"] = path.join(reactDir, "jsx-dev-runtime");
+    const schedulerDir = onePhysicalCopy("scheduler");
+    resolveAliases.scheduler = schedulerDir;
+    process.env.MPO_VITEST_REACT = reactDir;
+    process.env.MPO_VITEST_REACT_DOM = reactDomDir;
+    process.env.MPO_VITEST_SCHEDULER = schedulerDir;
+    pinNodeReactRequire(reactDir, reactDomDir, schedulerDir);
   }
 
   const testConfig: Record<string, unknown> = {
     environment,
     globals: true,
-    setupFiles,
+    setupFiles: dedupeReact ? [pinReactRequireSetup, ...setupFiles] : setupFiles,
     testTimeout,
     coverage: {
       provider: "v8" as const,
@@ -203,8 +288,25 @@ export function createVitestConfig(options: CreateVitestConfigOptions = {}): Use
     },
     server: {
       deps: {
-        inline: ["react-native-web", "one", /@tamagui\//, "tamagui", ...inlineDeps],
-        ...(externalDeps.length > 0 ? { external: externalDeps } : {}),
+        // `@tanstack/*` ships `.ts` source; Vite already transforms it, but its
+        // CJS child `use-sync-external-store` is a valid Node import and stays
+        // external unless named here. Node then `require('react')`s the hoisted
+        // root directory — a different inode than the `.pnpm` copy the aliases
+        // bind. Measured Gantt stack after rebase onto main (forms Button now
+        // calls `@tanstack/react-store`): useCallback from node_modules/react,
+        // useSelector from @tanstack/react-store/src, react-dom from .pnpm.
+        inline: [
+          "react-native-web",
+          "one",
+          /@tamagui\//,
+          "tamagui",
+          /@tanstack\//,
+          "use-sync-external-store",
+          ...inlineDeps,
+        ],
+        ...(externalDeps.length > 0
+          ? { external: [pinReactRequireSetup, ...externalDeps] }
+          : { external: [pinReactRequireSetup] }),
         interopDefault: true,
       },
     },
@@ -217,33 +319,43 @@ export function createVitestConfig(options: CreateVitestConfigOptions = {}): Use
     plugins,
     test: testConfig,
     resolve: {
-      extensions: [
-        ".test.ts",
-        ".test.tsx",
-        ".web.ts",
-        ".web.tsx",
-        ".web.js",
-        ".web.jsx",
-        ".ts",
-        ".tsx",
-        ".js",
-        ".jsx",
-      ],
+      // Never list .test.* here. Vite tries these suffixes in order for an
+      // extensionless specifier, so a leading ".test.ts" makes `import "./foo"`
+      // resolve to foo.test.ts instead of foo.ts whenever both exist. That drags
+      // the test file (and whatever it imports, e.g. node:test) into the module
+      // graph and vitest dies with "Cannot bundle Node.js built-in node:test".
+      // Test files are collected by test.include globs, not by resolution.
+      extensions: [".web.ts", ".web.tsx", ".web.js", ".web.jsx", ".ts", ".tsx", ".js", ".jsx"],
       mainFields: ["browser", "module", "main"],
       alias: {
         ...resolveAliases,
         ...aliases,
       },
       conditions,
-      dedupe: dedupeReact ? ["react", "react-dom", "scheduler"] : [],
+      // Do not also `dedupe` react. Vite's dedupe always picks the project-root
+      // copy, which under `node-linker=hoisted` is a different inode than the
+      // `.pnpm` copy the aliases bind. That split is the MPO-37 crash: the
+      // alias sends react-dom to `.pnpm`, dedupe sends @tanstack/react-store's
+      // `import 'react'` to the hoisted root, dispatcher is null.
+      dedupe: [],
     },
     define: {
       __DEV__: true,
       global: "globalThis",
+      // This replaces the `process` identifier in transformed modules. Keep the
+      // MPO_VITEST_* paths on that stub so pin-react-require.cjs still sees
+      // them if Vite ever transforms the setup file.
       process: JSON.stringify({
         env: {
           NODE_ENV: "test",
           NODE_DEBUG: false,
+          ...(dedupeReact
+            ? {
+                MPO_VITEST_REACT: process.env.MPO_VITEST_REACT,
+                MPO_VITEST_REACT_DOM: process.env.MPO_VITEST_REACT_DOM,
+                MPO_VITEST_SCHEDULER: process.env.MPO_VITEST_SCHEDULER,
+              }
+            : {}),
         },
         platform: process.platform,
         version: process.version,

package/types/vitest.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"vitest.d.ts","sourceRoot":"","sources":["../src/vitest.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC,MAAM,WAAW,yBAAyB;IACxC;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,GAAG,KAAK,CAAC;IAE/B;;OAEG;IACH,WAAW,CAAC,EAAE,OAAO,GAAG,WAAW,GAAG,MAAM,CAAC;IAE7C;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IAExB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEjC;;OAEG;IACH,QAAQ,CAAC,EAAE;QACT,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;KACpB,CAAC;IAEF;;;OAGG;IACH,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAE7B;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IAEtB;;;OAGG;IACH,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,kBAAkB,CAAC,OAAO,GAAE,yBAA8B,GAAG,UAAU,CAmJtF"}
+{"version":3,"file":"vitest.d.ts","sourceRoot":"","sources":["../src/vitest.ts"],"names":[],"mappings":"AAMA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAoDvC,MAAM,WAAW,yBAAyB;IACxC;;;;OAIG;IACH,aAAa,CAAC,EAAE,MAAM,GAAG,KAAK,CAAC;IAE/B;;OAEG;IACH,WAAW,CAAC,EAAE,OAAO,GAAG,WAAW,GAAG,MAAM,CAAC;IAE7C;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;IAExB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEjC;;OAEG;IACH,QAAQ,CAAC,EAAE;QACT,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;KACpB,CAAC;IAEF;;;OAGG;IACH,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAE7B;;;OAGG;IACH,WAAW,CAAC,EAAE,OAAO,CAAC;IAEtB;;;OAGG;IACH,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB;;OAEG;IACH,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,OAAO,CAAC,EAAE,MAAM,EAAE,CAAC;IAEnB;;OAEG;IACH,eAAe,CAAC,EAAE,OAAO,CAAC;CAC3B;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,kBAAkB,CAAC,OAAO,GAAE,yBAA8B,GAAG,UAAU,CA8MtF"}