@multiplatform.one/config 7.4.0 → 7.5.0

package/README.md

@@ -55,3 +55,30 @@ Extend from the tsconfig presets:
 ```
 
 Available presets: `base.json`, `build.json`, `app.json`.
+
+### Oxlint
+
+Convention rules travel with the package. Consuming apps add one line:
+
+```json
+{
+  "jsPlugins": ["@multiplatform.one/config/oxlint"]
+}
+```
+
+Then enable `mpo-conventions/no-hex-literals` on the globs you want (mpo's
+own `oxlintrc.json` turns it on for `features/**`). Palette modules
+(`themes/base.ts`, `themes/accent.ts`, `*palette*`) are exempt.
+
+### Lint (node-script checks)
+
+CSS-in-apps, features-twin, silent token no-ops, and the LC-65 size-recipe
+pilot run through `runConventionChecks({ roots })`:
+
+```ts
+import { runConventionChecks } from "@multiplatform.one/config/lint";
+
+runConventionChecks({
+  roots: { root: process.cwd() },
+});
+```

package/lib/vitest.js

@@ -1,8 +1,33 @@
+import Module from "node:module";
+import fs from "node:fs";
 import path from "node:path";
 import { tamaguiPlugin } from "@tamagui/vite-plugin";
+import { fileURLToPath } from "node:url";
 import react from "@vitejs/plugin-react";
 
 //#region src/vitest.ts
+const pinReactRequireSetup = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../pin-react-require.cjs");
+/**
+* CJS `require('react')` does not go through Vite aliases. `use-sync-external-store`
+* is a valid Node import, so Vitest leaves it external even when we ask to inline
+* it, and Node then loads the hoisted root copy — a different inode than the
+* `.pnpm` copy Vite binds. Patching Module._resolveFilename in the vitest
+* process (config eval + workers that re-load this factory) makes that
+* require land on the same physical copy as the aliases.
+*/
+function pinNodeReactRequire(reactDir, reactDomDir, schedulerDir) {
+	const ctor = Module;
+	if (ctor._mpoOneReact) return;
+	ctor._mpoOneReact = true;
+	const orig = ctor._resolveFilename;
+	ctor._resolveFilename = function pinned(request, parent, isMain, options) {
+		const next = request === "react" ? reactDir : request.startsWith("react/") ? path.join(reactDir, request.slice(6)) : request === "react-dom" ? reactDomDir : request.startsWith("react-dom/") ? path.join(reactDomDir, request.slice(10)) : request === "scheduler" ? schedulerDir : null;
+		if (next) try {
+			return orig.call(this, next, parent, isMain, options);
+		} catch {}
+		return orig.call(this, request, parent, isMain, options);
+	};
+}
 /**
 * Creates a shared Vitest configuration for multiplatform.one packages.
 *
@@ -49,18 +74,31 @@ function createVitestConfig(options = {}) {
 		resolveAliases["react-native-svg"] = "@tamagui/react-native-svg";
 	}
 	if (dedupeReact) {
-		resolveAliases.react = path.resolve(rootNodeModules, "react");
-		resolveAliases["react-dom"] = path.resolve(rootNodeModules, "react-dom");
-		resolveAliases["react-dom/client"] = path.resolve(rootNodeModules, "react-dom/client");
-		resolveAliases["react-dom/server"] = path.resolve(rootNodeModules, "react-dom/server");
-		resolveAliases["react/jsx-runtime"] = path.resolve(rootNodeModules, "react/jsx-runtime");
-		resolveAliases["react/jsx-dev-runtime"] = path.resolve(rootNodeModules, "react/jsx-dev-runtime");
-		resolveAliases.scheduler = path.resolve(rootNodeModules, "scheduler");
+		const onePhysicalCopy = (pkg) => {
+			for (const base of [path.resolve(process.cwd(), "node_modules"), rootNodeModules]) try {
+				return fs.realpathSync(path.resolve(base, pkg));
+			} catch {}
+			return path.resolve(rootNodeModules, pkg);
+		};
+		const reactDir = onePhysicalCopy("react");
+		const reactDomDir = onePhysicalCopy("react-dom");
+		resolveAliases.react = reactDir;
+		resolveAliases["react-dom"] = reactDomDir;
+		resolveAliases["react-dom/client"] = path.join(reactDomDir, "client");
+		resolveAliases["react-dom/server"] = path.join(reactDomDir, "server");
+		resolveAliases["react/jsx-runtime"] = path.join(reactDir, "jsx-runtime");
+		resolveAliases["react/jsx-dev-runtime"] = path.join(reactDir, "jsx-dev-runtime");
+		const schedulerDir = onePhysicalCopy("scheduler");
+		resolveAliases.scheduler = schedulerDir;
+		process.env.MPO_VITEST_REACT = reactDir;
+		process.env.MPO_VITEST_REACT_DOM = reactDomDir;
+		process.env.MPO_VITEST_SCHEDULER = schedulerDir;
+		pinNodeReactRequire(reactDir, reactDomDir, schedulerDir);
 	}
 	const testConfig = {
 		environment,
 		globals: true,
-		setupFiles,
+		setupFiles: dedupeReact ? [pinReactRequireSetup, ...setupFiles] : setupFiles,
 		testTimeout,
 		coverage: {
 			provider: "v8",
@@ -88,9 +126,11 @@ function createVitestConfig(options = {}) {
 				"one",
 				/@tamagui\//,
 				"tamagui",
+				/@tanstack\//,
+				"use-sync-external-store",
 				...inlineDeps
 			],
-			...externalDeps.length > 0 ? { external: externalDeps } : {},
+			...externalDeps.length > 0 ? { external: [pinReactRequireSetup, ...externalDeps] } : { external: [pinReactRequireSetup] },
 			interopDefault: true
 		} }
 	};
@@ -102,8 +142,6 @@ function createVitestConfig(options = {}) {
 		test: testConfig,
 		resolve: {
 			extensions: [
-				".test.ts",
-				".test.tsx",
 				".web.ts",
 				".web.tsx",
 				".web.js",
@@ -123,11 +161,7 @@ function createVitestConfig(options = {}) {
 				...aliases
 			},
 			conditions,
-			dedupe: dedupeReact ? [
-				"react",
-				"react-dom",
-				"scheduler"
-			] : []
+			dedupe: []
 		},
 		define: {
 			__DEV__: true,
@@ -135,7 +169,12 @@ function createVitestConfig(options = {}) {
 			process: JSON.stringify({
 				env: {
 					NODE_ENV: "test",
-					NODE_DEBUG: false
+					NODE_DEBUG: false,
+					...dedupeReact ? {
+						MPO_VITEST_REACT: process.env.MPO_VITEST_REACT,
+						MPO_VITEST_REACT_DOM: process.env.MPO_VITEST_REACT_DOM,
+						MPO_VITEST_SCHEDULER: process.env.MPO_VITEST_SCHEDULER
+					} : {}
 				},
 				platform: process.platform,
 				version: process.version,

package/lint.d.ts

@@ -0,0 +1,19 @@
+export type ConventionRoots = {
+  root?: string;
+  apps?: string;
+  features?: string;
+  public?: string;
+};
+
+export type RunConventionChecksOptions = {
+  roots?: ConventionRoots;
+};
+
+export function resolveRoots(roots?: ConventionRoots): {
+  root: string;
+  apps: string;
+  features: string;
+  public: string;
+};
+
+export function runConventionChecks(options?: RunConventionChecksOptions): number;